Page MenuHomePhabricator
Feed Advanced Search

Mar 15 2021

epriestley moved T13534: Inline Comment errata after editing persistence from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13515: Differential: Inlines and View Options from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch from Backlog to Next on the Differential board.
Mar 15 2021, 5:08 PM · Differential
epriestley moved T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Backlog to Next on the Differential board.
Mar 15 2021, 5:08 PM · Accessibility, Differential
epriestley moved T13639: Allow revisions to be queried by affected path via the API from Backlog to Next on the Differential board.
Mar 15 2021, 5:07 PM · Conduit, Differential

Mar 14 2021

epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".
Mar 14 2021, 8:02 PM · Conduit, Differential
epriestley added a comment to T13639: Allow revisions to be queried by affected path via the API.

I'm likely to break the paths constraint for frozen API method differential.query. This was added by D2788 as a Facebook-specific patch with no rationale that I can dig up, and the author didn't have any related changes from around that time.

Mar 14 2021, 7:54 PM · Conduit, Differential
epriestley triaged T13639: Allow revisions to be queried by affected path via the API as Wishlist priority.
Mar 14 2021, 7:50 PM · Conduit, Differential

Mar 11 2021

epriestley added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

I don't think those use cases are necessarily bad, there's just a little bit of a slippery slope to, say, "Git sure looks a lot like a database" and then support issues like "it's hard to manage my 3,500 automated review requests".

Mar 11 2021, 7:46 PM · Differential
cspeckmim added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

Adding a data point, "Foist Upon" was a surprise hit among the developers here and additionally we have successfully utilized the conduit API to take advantage of foisting

There are probably also some off-label use cases where, for example, bots create revisions on behalf of users. I'm not thrilled about these, ...

oops 😬

Mar 11 2021, 7:38 PM · Differential

Mar 10 2021

epriestley closed T13628: Provide "Foist Upon", an inverse operation to "Commandeer" as Resolved.

This promoted and has been in the Phacility cluster for a few days without issues.

Mar 10 2021, 6:21 PM · Differential

Mar 4 2021

epriestley added a revision to T13628: Provide "Foist Upon", an inverse operation to "Commandeer": D21595: Hide the "Author" field in Differential on the web create workflow.
Mar 4 2021, 5:44 PM · Differential
epriestley added a revision to T13628: Provide "Foist Upon", an inverse operation to "Commandeer": D21592: Improve rendering behavior for "foist upon" with an empty tokenizer.
Mar 4 2021, 12:01 AM · Differential

Mar 3 2021

epriestley added a revision to T13628: Provide "Foist Upon", an inverse operation to "Commandeer": D21591: Provide a more general "Author" transaction for Differential.
Mar 3 2021, 11:47 PM · Differential
epriestley triaged T13628: Provide "Foist Upon", an inverse operation to "Commandeer" as Low priority.
Mar 3 2021, 6:51 PM · Differential

Feb 26 2021

epriestley closed T13617: Blocks of added lines have an off-by-one error when porting phantom comments as Resolved.

Presuming this is resolved until evidence to the contrary arises.

Feb 26 2021, 11:06 PM · Differential

Feb 25 2021

epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.

See also T13068, which suggests rendering mentions in a special style when the user has muted the object.

Feb 25 2021, 7:25 PM · Policy, Differential

Feb 21 2021

epriestley added a revision to T13617: Blocks of added lines have an off-by-one error when porting phantom comments: D21572: When mapping phantom comments across changes, correct an off-by-one issue.
Feb 21 2021, 5:03 PM · Differential
epriestley triaged T13617: Blocks of added lines have an off-by-one error when porting phantom comments as Normal priority.
Feb 21 2021, 4:38 PM · Differential

Feb 19 2021

epriestley closed T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php" as Resolved.

That covered everything that looked low-hanging.

Feb 19 2021, 4:35 PM · Database, Differential
epriestley added a revision to T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php": D21570: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php".
Feb 19 2021, 3:48 PM · Database, Differential
epriestley updated the task description for T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php".
Feb 19 2021, 3:21 PM · Database, Differential
epriestley triaged T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php" as Low priority.
Feb 19 2021, 3:21 PM · Database, Differential

Feb 18 2021

epriestley closed T13609: Expose buildable object and container PHIDs as build variables as Resolved.
Feb 18 2021, 9:38 PM · Differential, Harbormaster
epriestley added a revision to T13609: Expose buildable object and container PHIDs as build variables: D21569: Add more useful PHIDs to Harbormaster build variables.
Feb 18 2021, 9:35 PM · Differential, Harbormaster
epriestley triaged T13609: Expose buildable object and container PHIDs as build variables as Normal priority.
Feb 18 2021, 9:32 PM · Differential, Harbormaster
epriestley added a comment to T12952: Reviewer not able to see diff.

See T13602 for eventual followup.

Feb 18 2021, 8:16 PM · Differential, Bug Report

Feb 16 2021

epriestley updated the task description for T9069: arc patch can't handle binary file correctly.
Feb 16 2021, 7:11 PM · Differential, Restricted Project, Arcanist

Feb 15 2021

epriestley closed T13605: Implement a "differential.changeset.search" API method as Resolved.

See T13125 and PHI1997 for followup.

Feb 15 2021, 7:47 PM · Harbormaster, Differential
epriestley added a revision to T13605: Implement a "differential.changeset.search" API method: D21558: Provide a "differential.changeset.search" Conduit API method.
Feb 15 2021, 7:07 PM · Harbormaster, Differential
epriestley added a revision to T13605: Implement a "differential.changeset.search" API method: D21557: Add a PHID to Changesets.
Feb 15 2021, 6:13 PM · Harbormaster, Differential
epriestley triaged T13605: Implement a "differential.changeset.search" API method as Normal priority.
Feb 15 2021, 6:01 PM · Harbormaster, Differential

Feb 13 2021

epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21556: When a revision has only human reviewers but none can view it, show a warning banner.
Feb 13 2021, 9:21 PM · Policy, Differential
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21555: When a reviewer can't see a revision, show it clearly in the reviewer list.
Feb 13 2021, 9:12 PM · Policy, Differential
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21554: Render user hovercards with context information about their ability to see the context object.
Feb 13 2021, 8:56 PM · Policy, Differential
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21553: Restructure Hovercards to support more context information.
Feb 13 2021, 7:59 PM · Policy, Differential

Feb 12 2021

epriestley updated the task description for T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.
Feb 12 2021, 7:52 PM · Differential

Feb 5 2021

epriestley added a comment to T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration.

See also PHI1987 for another case of this.

Feb 5 2021, 4:30 PM · Arcanist, Customer Impact, Differential, Spaces, Feature Request
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21548: Propagate the "ContextObject" to Remarkup rendering in timelines.
Feb 5 2021, 4:15 PM · Policy, Differential
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
  • When rendering a "no view permission" hovercard, it would be nice to annotate it with an explicit "The user can't see this object" piece of context information.
Feb 5 2021, 4:10 PM · Policy, Differential
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21547: When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI.
Feb 5 2021, 4:06 PM · Policy, Differential
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
  • Context objects don't make it into timeline rendering engines.
  • Context objects don't make it into comment previews.
Feb 5 2021, 1:15 AM · Policy, Differential
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21546: Lift bulk tests for "many users against one object" capabilities into "PolicyFilterSet".
Feb 5 2021, 1:15 AM · Policy, Differential

Feb 4 2021

epriestley triaged T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers as Normal priority.
Feb 4 2021, 10:15 PM · Policy, Differential

Jan 13 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Jan 13 2021, 9:38 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Jan 13 2021, 9:01 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Jan 13 2021, 8:33 PM · Accessibility, Differential

Sep 17 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:52 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:38 PM · Differential

Sep 16 2020

epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
Sep 16 2020, 12:44 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21464: Log unexpected exceptions raised by Conduit calls.
Sep 16 2020, 12:24 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21463: When raising a Conduit client exception, show the called method in the error message.
Sep 16 2020, 12:20 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Sep 16 2020, 12:19 AM · Differential
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Sep 16 2020, 12:16 AM · Differential

Sep 8 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21460: When a commit is marked "closeable", clear the "published" flag.
Sep 8 2020, 8:42 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Sep 8 2020, 8:16 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Sep 8 2020, 7:55 PM · Differential

Sep 4 2020

epriestley renamed T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Include "Moved/Copied" gutter in 1-up diffs, and add aural cues to Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Sep 4 2020, 5:56 PM · Accessibility, Differential

Aug 17 2020

epriestley added a parent task for T13521: FormationView could do more Javascript magic around device layouts and header elements: T13574: Make responsive UI elements respond to container width, not window width.
Aug 17 2020, 3:52 PM · Differential

Aug 13 2020

epriestley triaged T13571: When viewing LFS files in Differential or Diffusion, show blob content where reasonable as Normal priority.
Aug 13 2020, 8:12 PM · Diffusion, Differential

Aug 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Aug 12 2020, 9:19 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Aug 12 2020, 8:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21448: Wrap all direct access to author/committer properties on "CommitData".
Aug 12 2020, 7:42 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".
Aug 12 2020, 7:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.
Aug 12 2020, 7:08 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21444: Remove "bin/repository lookup-users" workflow.
Aug 12 2020, 7:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Aug 12 2020, 6:41 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Aug 12 2020, 6:32 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21441: Delete some commit dead parsing code.
Aug 12 2020, 4:31 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21440: Fix some content/background overflow issues with commit graph lists.
Aug 12 2020, 3:54 PM · Differential

Aug 10 2020

epriestley added a project to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: Accessibility.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting as Wishlist priority.
Aug 10 2020, 8:18 PM · Accessibility, Differential

Aug 5 2020

epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
Aug 5 2020, 5:07 PM · Differential

Jul 28 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21431: Improve handle/status list display on devices in commit graph lists.
Jul 28 2020, 6:15 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21430: Improve commit action item layout on mobile.
Jul 28 2020, 5:08 PM · Differential

Jul 17 2020

epriestley added a revision to T2495: Improve whitespace expansion of tab literals: D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Jul 17 2020, 10:07 PM · Restricted Project, FreeBSD, Differential, Diffusion

Jul 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21418: Improve desktop and mobile layouts for new "CommitGridView".
Jul 12 2020, 9:26 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Jul 12 2020, 7:45 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21416: Clean up some minor commit list CSS.
Jul 12 2020, 6:03 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21415: Remove "PhabricatorAuditListView".
Jul 12 2020, 5:44 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Jul 12 2020, 4:25 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Jul 12 2020, 4:16 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Jul 12 2020, 3:41 PM · Differential

Jul 10 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21411: Improve rendering of history graph in "CommitGraphView".
Jul 10 2020, 6:44 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Jul 10 2020, 6:20 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21409: Remove the "Graph" view as a dedicated repository view.
Jul 10 2020, 5:56 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21408: Remove "Recent Commits" from repository landing page.
Jul 10 2020, 5:48 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21407: Remove "DiffusionTagTableView".
Jul 10 2020, 4:25 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21406: Remove the "authored" subheader from commits.
Jul 10 2020, 4:20 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21405: Modernize "Author" and "Committer" rendering for commits.
Jul 10 2020, 4:16 PM · Differential
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

The broader structural issue here is:

Jul 10 2020, 4:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Jul 10 2020, 4:05 PM · Differential

Jul 9 2020

epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

A second issue is that some of the "publish" behavior depends on the commit/revision relationship. This can still be sequenced correctly entirely in the publish daemon, but "close related revisions" and "publish the commit" are not entirely independent.

Jul 9 2020, 10:24 PM · Differential
epriestley triaged T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Normal priority.
Jul 9 2020, 10:13 PM · Differential

Jun 9 2020

epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked, as Resolved.
Jun 9 2020, 12:32 AM · Differential, Arcanist, Feature Request

Jun 8 2020

epriestley removed a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9457: arc diff crashes when trying to stash submodule diffs.
Jun 8 2020, 1:50 PM · Arcanist, Differential

Jun 6 2020

benwick added a comment to Blog Post: Quick Look: Suggesting Edits with Inline Comments.

Will this feature come to diffusion for audit workflows?

Jun 6 2020, 12:34 PM · Differential, Quick Look

May 23 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21287: Fix an issue where inline comments with only edit suggestions are considered empty.
May 23 2020, 3:18 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In previews, suggestions aren't highlighted properly (likely just missing CSS).
May 23 2020, 3:15 PM · Inline Comments, Diffusion, Differential

May 22 2020

epriestley created Blog Post: Quick Look: Suggesting Edits with Inline Comments.
May 22 2020, 9:41 PM · Differential, Quick Look