Page MenuHomePhabricator

Inline Comment errata after editing persistence
Open, WishlistPublic


Mostly from T13513:

  • Inline previews don't mark comments that are being edited in a special way.
  • Audits do not have a warning about submitting unsubmitted inlines. They do submit them.
  • DocumentEngine does not render inline context in email. Instead, email shows no context for inlines on DocumentEngine views.
  • The menu hover state for non-done inlines is weird (and for done inlines, although it's less visible).
  • The selection reticle does not redraw/resize after "Edit Comment".
  • When a selection event that does not originate from the paths panel occurs, the paths panel is not scrolled, so the selected changeset may be offscreen. Possibly, we should scroll the paths panel to put the changeset into the viewport.
  • The "Done" border for inlines is weirdly colored, now (both draft and non-draft).
  • In previews, suggestions aren't highlighted properly (likely just missing CSS).

From T13515:

  • The "hidden file has hidden inlines" UI is a little under-designed:

Screen Shot 2020-04-17 at 10.48.13 AM.png (253×1 px, 35 KB)

Event Timeline

epriestley triaged this task as Wishlist priority.May 14 2020, 6:13 PM
epriestley created this task.

When you are viewing a change under engine X, and comments made under engine Y are present, they are not handled specially.

Moved to T13642.

Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.

  • Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.

Moved to T13559.