This task was filed through the "New Feature Request" form.
Tue, Aug 15
Just sweeping this up, rewriting the property display to show +x seems reasonable to me but I think it's self-evident enough that we don't need to keep a task around for it.
I don't think this meets the high bar required by modern feature requests (see "Upstreamable Feautures" in Planning).
(This isn't anything upstream-actionable.)
I don't think this clearly describes a root problem. PHI33 touches on similar issues, and I'll file something vaguely in this realm if anything comes of that.
Sun, Aug 6
Sat, Aug 5
remind me to add some more icons for Link.
That looks pretty hawt.
Fri, Aug 4
Happy to take a look if you found a reasonable way to get access to $request. If you're reading $_REQUEST['__path__'] directly or something though the eventual upstream version probably won't look too similar.
I've written a patch to make this work for the project sidebar nav for my organization's install. I don't want to take up your time with it if it's not helpful, but let me know if you'd like me to push a diff.
Thu, Aug 3
I'm just going to merge this into T5258. There are two separate issues here:
This bug does exist on this server, but unclear why. Maybe related to size of image, but probably best solution is some command-line tool to regenerate all file transforms? I don't think making PHIDs easy to find inside the app is very user friendly.
Doesn't look like the repository will even attempt to clone over HTTPS:
Wed, Aug 2
Why did they need regenerating in the first place?
This is an unusually low-tech solution but I can't think of any reasons why it won't work.
I'm obviously low on AM brian power today.
Heh, that was going to be my suggestion in the original discourse post, but I figured it was too simplistic. Glad to hear we're on the same page. Thanks everyone!
That sounds much easier than all the solutions I came up with.
Is there any reason that the rule "if any menu items have the same link target as the request URI, highlight the first one" wouldn't work?
Or maybe there is a simple way to get the link to highlight, I couldn't think of one though.
A link doesn't stay highlighted if clicked on. Like dashboards, I can understand wanting multiple board views from the sidebar.
- What's the root problem?
- Why can't they use links?
- How is this different from T12374?
Oh, I didn't even expect that option to be configurable on Phacility given it's a security related setting. I'll turn it on and do some speed tests next week to see if I get any measurable difference in cloning.
Have you enabled diffusion.allow-http-auth?
When you click Clone in the Phacility UI on a repository, it doesn't show any HTTPS URLs. It's possible it works if you copy the URL from the address bar, but the UI in Phacility itself doesn't give any kind of indication that it will work.
Tue, Aug 1
Feel free to use our Discourse for general admin questions (as opposed to our working tasks). Thank you!
@ofbeaton Thanks for the tips. Sounds better than the approach we are using to slightly modify the code base.
We use puppet to deploy phabricator stable from a copy on a local file server, then have it run a shell script that applies our patches using git apply on .patch files. Lastly we restart services.
@ofbeaton Just curious what's your strategy on applying patches as part of your deployment for phabricator? Do you use a find/replace strategy? Apply diffs?
Mon, Jul 31
Thu, Jul 27
Agreed. I haven't experienced the problem since I upgraded, so I think it was related to an earlier fix, even if it wasn't the identified fix (which should have already been in my install when I did have the problems). There's nothing that needs to be addressed here.
This is vague and may not actually identify a problem; I don't plan to pursue it.
This seems to mostly be a matter of taste, and we already have behavior similar to the behavior of git, which seems reasonable.
We aren't going to implement a bin/phd start-missing-daemon command.