Page MenuHomePhabricator

Propagate the "ContextObject" to Remarkup rendering in timelines
ClosedPublic

Authored by epriestley on Feb 5 2021, 4:15 PM.

Details

Summary

Ref T13602. Currently, timeline comment rendering does not (by default) propagate the context object to the rendering layer.

This means that @mentions of users who can't see the object aren't rendered properly (currently: they show up as blue, but should show up as grey).

Pass the context down the stack and into the remarkup engine.

Test Plan

Screen Shot 2021-02-05 at 8.13.07 AM.png (144×233 px, 7 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM
This revision was automatically updated to reflect the committed changes.