Page MenuHomePhabricator

Propagate the "ContextObject" to Remarkup rendering in timelines
ClosedPublic

Authored by epriestley on Fri, Feb 5, 4:15 PM.

Details

Summary

Ref T13602. Currently, timeline comment rendering does not (by default) propagate the context object to the rendering layer.

This means that @mentions of users who can't see the object aren't rendered properly (currently: they show up as blue, but should show up as grey).

Pass the context down the stack and into the remarkup engine.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 13, 9:37 PM
This revision was automatically updated to reflect the committed changes.