Page MenuHomePhabricator

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Needs ReviewPublic

Authored by epriestley on Sun, Jul 12, 3:41 PM.
This revision needs review, but there are no reviewers specified.



Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 24777
Build 34176: Run Core Tests
Build 34175: arc lint + arc unit

Event Timeline

epriestley created this revision.Sun, Jul 12, 3:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Jul 12, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
epriestley updated this revision to Diff 50957.Sun, Jul 12, 3:43 PM
  • Rebuild Celerity map.
epriestley requested review of this revision.Sun, Jul 12, 3:44 PM