Page MenuHomePhabricator

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 8:01 PM
Unknown Object (File)
Wed, Feb 21, 2:12 AM
Unknown Object (File)
Mon, Feb 19, 7:47 AM
Unknown Object (File)
Jan 9 2024, 8:05 AM
Unknown Object (File)
Dec 27 2023, 2:49 PM
Unknown Object (File)
Dec 27 2023, 1:34 PM
Unknown Object (File)
Dec 22 2023, 3:19 AM
Unknown Object (File)
Dec 21 2023, 12:31 AM
Subscribers
None

Details

Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2020, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.