Page MenuHomePhabricator

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 3:41 PM.
Tags
None
Referenced Files
F18682198: D21412.diff
Fri, Sep 26, 5:22 AM
F18680926: D21412.diff
Fri, Sep 26, 3:31 AM
F18651007: D21412.id50957.diff
Sun, Sep 21, 2:30 AM
F18571126: D21412.id51029.diff
Wed, Sep 10, 4:44 AM
F18571125: D21412.id50957.diff
Wed, Sep 10, 4:44 AM
F18571123: D21412.id50956.diff
Wed, Sep 10, 4:44 AM
F18101240: D21412.diff
Aug 9 2025, 12:23 PM
F18056363: D21412.diff
Aug 4 2025, 8:17 AM
Subscribers
None

Details

Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2020, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.