Page MenuHomePhabricator

Render user hovercards with context information about their ability to see the context object

Authored by epriestley on Sat, Feb 13, 8:56 PM.



Ref T13602. When rendering a user hovercard, pass the object on which the reference appears. If the user can't see the object, make it clear on the hovecard.

Restyle the "nopermission" markup in mentions to make it more obvious what the style means: instead of grey text, use red with an explicit icon.

Test Plan

Screen Shot 2021-02-13 at 12.50.53 PM.png (467×564 px, 35 KB)

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Feb 13, 8:57 PM
Harbormaster failed remote builds in B25114: Diff 51305!
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 13, 9:38 PM
This revision was automatically updated to reflect the committed changes.