Page MenuHomePhabricator

DifferentialRevisionQuery omits GROUP BY when querying by hash
Closed, ResolvedPublic

Description

See PHI1864.

DifferentialRevisionQuery does not add a GROUP BY to the query properly when querying by hash. This is not likely to cause problems in any real-world situation, but does cause explicit errors after code was added in D21400 to detect this issue.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley created this task.
epriestley added a revision: Restricted Differential Revision.Sep 16 2020, 12:19 AM
epriestley added a revision: Restricted Differential Revision.
epriestley added a revision: Restricted Differential Revision.Sep 16 2020, 12:24 AM
epriestley added a commit: Restricted Diffusion Commit.Sep 16 2020, 12:34 AM
epriestley added a commit: Restricted Diffusion Commit.Sep 16 2020, 12:37 AM
epriestley added a commit: Restricted Diffusion Commit.