Maniphest T13581

DifferentialRevisionQuery omits GROUP BY when querying by hash
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Sep 16 2020, 12:16 AM

Tags

Referenced Files

None

Subscribers

Description

DifferentialRevisionQuery does not add a GROUP BY to the query properly when querying by hash. This is not likely to cause problems in any real-world situation, but does cause explicit errors after code was added in D21400 to detect this issue.

Revisions and Commits

rARC Arcanist
	D21463	rARCde209ec06488 When raising a Conduit client exception, show the called method in the error…
rP Phabricator
	D21464	rP969587f7b0c3 Log unexpected exceptions raised by Conduit calls
	D21462	rP2a83df578604 Fix an issue where a GROUP BY was missing when a query matched a revision using…

Related Objects

Mentioned Here: D21400: Require rows passed to "loadAllFromArray()" have unique keys

Event Timeline

epriestley triaged this task as Normal priority.Sep 16 2020, 12:16 AM

epriestley created this task.

epriestley added a revision: D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.Sep 16 2020, 12:19 AM

epriestley added a revision: D21463: When raising a Conduit client exception, show the called method in the error message.

epriestley added a revision: D21464: Log unexpected exceptions raised by Conduit calls.Sep 16 2020, 12:24 AM

epriestley added a commit: rARCde209ec06488: When raising a Conduit client exception, show the called method in the error….Sep 16 2020, 12:34 AM

epriestley added a commit: rP2a83df578604: Fix an issue where a GROUP BY was missing when a query matched a revision using….Sep 16 2020, 12:37 AM

epriestley added a commit: rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls.

epriestley closed this task as Resolved.Sep 16 2020, 12:44 AM