Page MenuHomePhabricator

Modernize "Author" and "Committer" rendering for commits
Needs ReviewPublic

Authored by epriestley on Fri, Jul 10, 4:16 PM.
This revision needs review, but there are no reviewers specified.



Ref T13552. Give "Commit" objects a more modern, identity-aware way to render author and committer information.

This uses handles in a more modern way and gives us a single read callsite for raw author and committer names.

Test Plan
  • Grepped for callers to the old methods, found none. (There are a lot of "renderAuthor()" callers in transactions, but this call takes no parameters.)
  • Viewed some commits, saw sensible lists of authors and committers.

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 24767
Build 34158: Run Core Tests
Build 34157: arc lint + arc unit

Event Timeline

epriestley created this revision.Fri, Jul 10, 4:16 PM
epriestley requested review of this revision.Fri, Jul 10, 4:17 PM