Feed All Stories

Today

allixsenos requested review of D18871: Fix Diffusion fatal when blame commits refer to broken Differential revisions.
Wed, Jan 17, 1:40 AM
allixsenos added a revision to T13040: Fatal in Diffusion blame with missing leaves (deleted repository): D18871: Fix Diffusion fatal when blame commits refer to broken Differential revisions.
Wed, Jan 17, 1:40 AM
allixsenos created T13040: Fatal in Diffusion blame with missing leaves (deleted repository).
Wed, Jan 17, 1:22 AM

Yesterday

epriestley added a comment to T13023: Non-standard patches lead to exceptions being generated.

Tangential, but T8768 is a case where we generated an unfaithful synthetic diff (a diff --git that the git binary could not generate since 2006) and took the blame for it.

Tue, Jan 16, 10:22 PM · Differential
epriestley updated the task description for T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .
Tue, Jan 16, 10:20 PM · Git, Mercurial, Arcanist
epriestley edited the content of Changelog.
Tue, Jan 16, 10:17 PM
epriestley created 2018 Week 2 (Mid January).
Tue, Jan 16, 10:16 PM
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

I'm not totally sure all variants of this are fixed, but I don't know how to reproduce any remaining issues.

Tue, Jan 16, 10:15 PM · Git, Mercurial, Arcanist
epriestley committed rARCe64cbd3ba73d: Merge branch "master" into "experimental". (authored by epriestley).
Merge branch "master" into "experimental".
Tue, Jan 16, 9:59 PM
epriestley committed rARC2e02332216c6: Add trailing tabs when generating synthetic Git diffs for files with spaces (authored by epriestley).
Add trailing tabs when generating synthetic Git diffs for files with spaces
Tue, Jan 16, 9:57 PM
epriestley closed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them , a subtask of T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats, as Resolved.
Tue, Jan 16, 9:57 PM · Arcanist, Differential
epriestley closed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them as Resolved by committing rARC2e02332216c6: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Tue, Jan 16, 9:57 PM · Git, Mercurial, Arcanist
epriestley closed D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Tue, Jan 16, 9:57 PM
epriestley committed rP3e983b583dc0: Fix a transposed feed story in Badges (authored by epriestley).
Fix a transposed feed story in Badges
Tue, Jan 16, 9:57 PM
epriestley closed D18870: Fix a transposed feed story in Badges.
Tue, Jan 16, 9:57 PM
amckinley accepted D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Tue, Jan 16, 9:27 PM
amckinley accepted D18870: Fix a transposed feed story in Badges.
Tue, Jan 16, 9:26 PM
yelirekim added a comment to Q644: Is it possible to create a database for an application which just stores edges? (Answer 564).

thank you

Tue, Jan 16, 7:26 PM
yelirekim closed Q644: Is it possible to create a database for an application which just stores edges? as resolved.
Tue, Jan 16, 7:25 PM
epriestley updated the answer details for Q644: Is it possible to create a database for an application which just stores edges? (Answer 564).
Tue, Jan 16, 7:24 PM
epriestley added Q644: Is it possible to create a database for an application which just stores edges? (Answer 564).
Tue, Jan 16, 7:16 PM
epriestley updated the diff for D18870: Fix a transposed feed story in Badges.
  • Make the grammar a bit smoother?
Tue, Jan 16, 7:08 PM
epriestley added a comment to D18870: Fix a transposed feed story in Badges.

I'm also not really sure this string is grammatical English.

Tue, Jan 16, 7:07 PM
epriestley requested review of D18870: Fix a transposed feed story in Badges.
Tue, Jan 16, 7:04 PM
yelirekim updated the question details for Q644: Is it possible to create a database for an application which just stores edges?.
Tue, Jan 16, 6:54 PM
yelirekim asked Q644: Is it possible to create a database for an application which just stores edges?.
Tue, Jan 16, 6:53 PM
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

I filed a summary of this in the Mercurial upstream to waste someone else's time so I feel better:

Tue, Jan 16, 5:21 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

This is an explicit behavior in Mercurial and dates from 2007:

Tue, Jan 16, 4:49 PM · Git, Mercurial, Arcanist
epriestley updated the summary of D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Tue, Jan 16, 4:31 PM
epriestley requested review of D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Tue, Jan 16, 4:26 PM
epriestley added a revision to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them : D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Tue, Jan 16, 4:26 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

The rule Git uses appears to literally be "does the filename include a space":

Tue, Jan 16, 4:01 PM · Git, Mercurial, Arcanist
epriestley renamed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them from `arc patch` fails to add two files starting by the same word, then a space on hg to Under Mercurial, `arc patch` mishandles files with spaces in them .
Tue, Jan 16, 3:42 PM · Git, Mercurial, Arcanist

Mon, Jan 15

mpadourek awarded Q457: How should "aliases" work in the .arcconfig file? a Like token.
Mon, Jan 15, 9:42 AM

Thu, Jan 11

alawson added a comment to T10575: Support project tags on Passphrase credentials.

I have been trying to see about another way to do this until this is added (if it is I should say). We are finally getting ready to move to Phabricator, and I was hoping there was at least a shortcode or something I can use. Currently what I was trying to do was paste the query URL for a particular project's Passphrase credentials. What we were going to try was getting the query for whichever project's passwords, copying it, and adding it to the Project as a custom link.

Thu, Jan 11, 9:54 PM · Projects, Passphrase, Feature Request
epriestley requested review of D18868: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor.
Thu, Jan 11, 7:10 PM
epriestley added a dependent revision for D18867: Restore bulk edit support for remarkup fields (description, add comment): D18868: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor.
Thu, Jan 11, 7:08 PM
epriestley added a revision to T13025: Update bulk editor: D18868: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor.
Thu, Jan 11, 7:08 PM · Transactions, ApplicationEditor
epriestley requested review of D18867: Restore bulk edit support for remarkup fields (description, add comment).
Thu, Jan 11, 6:19 PM
epriestley added a revision to T13025: Update bulk editor: D18867: Restore bulk edit support for remarkup fields (description, add comment).
Thu, Jan 11, 6:17 PM · Transactions, ApplicationEditor
epriestley added a dependent revision for D18866: Support "select" types in bulk editor (status, priority): D18867: Restore bulk edit support for remarkup fields (description, add comment).
Thu, Jan 11, 6:17 PM
epriestley updated the diff for D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions.
  • Push the worker changes back to D18862.
  • Actually delete the old bulk edit Javascript behavior (the primary JS change here is a move + delete lots of code, not new code).
Thu, Jan 11, 5:44 PM
epriestley updated the diff for D18862: Provide a generic transaction-oriented bulk job worker.
  • Pull the minor changes from D18863 to here (value vs old) to improve conceptual purity.
Thu, Jan 11, 5:42 PM
epriestley requested review of D18866: Support "select" types in bulk editor (status, priority).
Thu, Jan 11, 5:36 PM
epriestley added a revision to T13025: Update bulk editor: D18866: Support "select" types in bulk editor (status, priority).
Thu, Jan 11, 5:35 PM · Transactions, ApplicationEditor
epriestley added a dependent revision for D18864: Remove the Maniphest-specific bulk job type: D18866: Support "select" types in bulk editor (status, priority).
Thu, Jan 11, 5:35 PM
epriestley added a comment to D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions.

D18862 was basically just a guess at what the implementation should look like, I didn't wire it up until this change. It could really be part of this change, I split them mostly because I wrote that first (before doing any of the other changes here), then backed off and took a different approach, but it was still sitting in a separate commit locally. Moving those changes to D18862 or merging D18862 into this would probably be a little more "pure" in some sense, the changes were just split into somewhat-reasonable chunks on disk already so I left them like that.

Thu, Jan 11, 3:52 PM
epriestley added a comment to D18862: Provide a generic transaction-oriented bulk job worker.

I think each actual edit normally writes at least 5 rows when it actually applies (offhand: transaction, feed story, mail message, notification row, Herald transcript) so the overhead of the bulk job should always be fairly low compared to the overhead of actually performing an edit, even though it's high relative to, say, holding a string in memory.

Thu, Jan 11, 3:30 PM
epriestley committed rP53b4882b8073: (stable) Fix a copy/paste error on the burnup chart (authored by epriestley).
(stable) Fix a copy/paste error on the burnup chart
Thu, Jan 11, 3:08 PM
epriestley committed rP82bfb9817920: Fix a copy/paste error on the burnup chart (authored by epriestley).
Fix a copy/paste error on the burnup chart
Thu, Jan 11, 3:07 PM
epriestley closed D18865: Fix a copy/paste error on the burnup chart.
Thu, Jan 11, 3:07 PM
amckinley added a comment to D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions.

There are some pieces here I don't really understand; will come back with lots of questions soon.

Thu, Jan 11, 12:34 AM
amckinley accepted D18862: Provide a generic transaction-oriented bulk job worker.
Thu, Jan 11, 12:26 AM
amckinley accepted D18864: Remove the Maniphest-specific bulk job type.
Thu, Jan 11, 12:19 AM
amckinley accepted D18865: Fix a copy/paste error on the burnup chart.
Thu, Jan 11, 12:18 AM

Wed, Jan 10

epriestley requested review of D18865: Fix a copy/paste error on the burnup chart.
Wed, Jan 10, 9:35 PM
epriestley requested review of D18864: Remove the Maniphest-specific bulk job type.
Wed, Jan 10, 9:16 PM
epriestley requested review of D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions.
Wed, Jan 10, 9:15 PM
epriestley added a revision to T13025: Update bulk editor: D18864: Remove the Maniphest-specific bulk job type.
Wed, Jan 10, 9:15 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Update bulk editor: D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions.
Wed, Jan 10, 9:12 PM · Transactions, ApplicationEditor
epriestley added a dependent revision for D18862: Provide a generic transaction-oriented bulk job worker: D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions.
Wed, Jan 10, 9:12 PM
epriestley requested review of D18862: Provide a generic transaction-oriented bulk job worker.
Wed, Jan 10, 9:07 PM
epriestley added a revision to T13025: Update bulk editor: D18862: Provide a generic transaction-oriented bulk job worker.
Wed, Jan 10, 9:07 PM · Transactions, ApplicationEditor
epriestley added a dependent revision for D18806: Rebuild the bulk editor on SearchEngine: D18862: Provide a generic transaction-oriented bulk job worker.
Wed, Jan 10, 9:06 PM
epriestley added a comment to rARCf1ba27ffedd5: Add "arc diff --draft".

You can git checkout experimental to switch to the experimental branch. This may not merge to master until the entire experimental branch merges, which is possibly far in the future.

Wed, Jan 10, 6:27 PM

Tue, Jan 9

kugel- added a comment to rARCf1ba27ffedd5: Add "arc diff --draft".

Is this going to land in master any time soon? Our company would love to use the draft feature.

Tue, Jan 9, 8:33 PM
epriestley closed T8303: Mercurial hooks as Invalid.

I'm going to close this since it was mostly answered and the remaining questions (about custom extension development) are outside the scope of modern support. See T13039 for a followup about numeric fields in Herald.

Tue, Jan 9, 4:55 PM · Mercurial, Diffusion
epriestley triaged T13039: Support numeric fields in Herald as Low priority.
Tue, Jan 9, 4:54 PM · Herald
jcox awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Dat Boi token.
Tue, Jan 9, 4:50 PM · Security
epriestley archived Customer Impact.
Tue, Jan 9, 4:46 PM
epriestley updated the task description for T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.
Tue, Jan 9, 4:44 PM · Mercurial, Arcanist
epriestley closed T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state as Invalid.

Ah, thanks! This is probably effectively covered by T9948 anyway -- one of the major changes for the Git flavor of that (T9657) was "put things back the way they were when anything goes wrong, even if we discard merge/rebase work", and that seems like a better behavior. I'll make a note there just in case.

Tue, Jan 9, 4:42 PM · Arcanist, Mercurial
epriestley archived Prioritized.
Tue, Jan 9, 3:31 PM
JeanFred added a watcher for Prioritized: JeanFred.
Tue, Jan 9, 1:34 PM

Mon, Jan 8

cspeckmim added a comment to T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state.

I tried a few scenarios for this and wasn't able to reproduce

  1. Single commit in diff that creates conflict
  2. Multiple commits in diff that all create conflicts
  3. Single commit in diff where first commit does not create conflict but second does
Mon, Jan 8, 5:58 PM · Arcanist, Mercurial
BYK abandoned D15676: Fix root path finding on Windows.
Mon, Jan 8, 3:03 PM
BYK abandoned D15693: Remove Windows workarounds from ArcanistGitAPI.
Mon, Jan 8, 3:03 PM
BYK abandoned D8084: Add GenericXUnitTestEngine.
Mon, Jan 8, 3:03 PM
BYK abandoned D15675: Fix Windows escaping.

Alright! You know where to find me or this patch if interest arises :)

Mon, Jan 8, 3:02 PM
epriestley added a comment to D15675: Fix Windows escaping.

Probably, yes. Our modern roadmap is almost entirely driven by paying customers, and no customers have expressed interest in this.

Mon, Jan 8, 2:58 PM
BYK added a comment to D15675: Fix Windows escaping.

@epriestley is the best course of action for this diff to abandon it?

Mon, Jan 8, 2:49 PM
mpadourek awarded Q629: Default empty value for custom "select" field a Like token.
Mon, Jan 8, 11:42 AM
mpadourek awarded T10004: ApplicationEditor Errata a Like token.
Mon, Jan 8, 11:34 AM · ApplicationEditor
mpadourek awarded T10162: Custom form support for Projects workboards a Like token.
Mon, Jan 8, 11:33 AM · Feature Request
mpadourek awarded T418: Integrate CustomField into more interfaces a Like token.
Mon, Jan 8, 11:32 AM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields
mpadourek awarded T4863: Allow Workboard Cards to be customized for display a Love token.
Mon, Jan 8, 11:32 AM · Projects, Workboards, Wikimedia
mpadourek awarded T5535: Provide event hook for rendering event calendars a Love token.
Mon, Jan 8, 11:24 AM · Calendar
mpadourek awarded T5045: Use Calendar to Display Query Results a Love token.
Mon, Jan 8, 11:24 AM · Calendar
mpadourek awarded T7930: Let Calendar provide date services to other applications a Like token.
Mon, Jan 8, 10:42 AM · Calendar

Sun, Jan 7

This is a test notification, sent at Sun, Jan 7, 11:49 AM.
Sun, Jan 7, 8:19 AM

Sat, Jan 6

amckinley edited the content of 2018 Week 1 (Early January).
Sat, Jan 6, 6:34 PM
amckinley edited the content of 2018 Week 1 (Early January).
Sat, Jan 6, 6:32 PM
cspeckmim edited the content of 2018 Week 1 (Early January).
Sat, Jan 6, 4:51 PM
cspeckmim awarded Changelog a Mountain of Wealth token.
Sat, Jan 6, 4:47 PM
epriestley edited the content of 2018 Week 1 (Early January).
Sat, Jan 6, 4:38 PM
kristo.mario awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Party Time token.
Sat, Jan 6, 4:36 PM · Security
epriestley edited the content of Changelog.
Sat, Jan 6, 4:30 PM
epriestley created 2018 Week 1 (Early January).
Sat, Jan 6, 4:20 PM
epriestley committed rPf9d9125f93ac: (stable) Promote 2018 Week 1 (authored by epriestley).
(stable) Promote 2018 Week 1
Sat, Jan 6, 3:33 PM
epriestley updated the task description for T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.
Sat, Jan 6, 3:26 PM · Phacility, Security, Mail