Page MenuHomePhabricator
Feed All Stories

Thu, Jul 22

0 updated subscribers of T13662: Mentions break Phriction preview.
Thu, Jul 22, 4:23 AM · Phriction
0 created T13662: Mentions break Phriction preview.
Thu, Jul 22, 4:20 AM · Phriction

Wed, Jul 21

epriestley added a comment to T13648: Transaction publishing may stall during mail expansion of package recipients.

The stalled transactions on this host published after I deployed the update.

Wed, Jul 21, 11:39 PM · Transactions
epriestley removed a reviewer for D21498: Fix error handler on PHP 8: Unknown Object (Owners Package).
Wed, Jul 21, 11:36 PM
epriestley removed a reviewer for D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__: Unknown Object (Owners Package).
Wed, Jul 21, 11:34 PM
epriestley committed rP387d3b4983d7: Resolve deleted packages properly as having no mailable members (authored by epriestley).
Resolve deleted packages properly as having no mailable members
Wed, Jul 21, 9:50 PM
epriestley closed D21707: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:50 PM
epriestley closed T13648: Transaction publishing may stall during mail expansion of package recipients as Resolved by committing rP387d3b4983d7: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:50 PM · Transactions
epriestley requested review of D21707: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:27 PM
epriestley updated the task description for T13661: Give Phame configurable interact policies.
Wed, Jul 21, 9:26 PM · Phacility, Phame
epriestley triaged T13661: Give Phame configurable interact policies as Low priority.
Wed, Jul 21, 9:25 PM · Phacility, Phame
epriestley closed D21687: Correct the flow of edit authority when sending messages to HarbormasterBuild objects.
Wed, Jul 21, 9:24 PM
epriestley added a revision to T13648: Transaction publishing may stall during mail expansion of package recipients: D21707: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:22 PM · Transactions
epriestley closed D21696: Add a side nav to Conduit API method console pages.
Wed, Jul 21, 9:19 PM
epriestley closed D21699: Rename "HarbormasterRestartException" to "HarbormasterMessageException".
Wed, Jul 21, 9:18 PM
epriestley closed D21695: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.
Wed, Jul 21, 9:18 PM
epriestley committed rP3df1e175273f: Add a side nav to Conduit API method console pages (authored by epriestley).
Add a side nav to Conduit API method console pages
Wed, Jul 21, 9:18 PM
epriestley closed D21698: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables.
Wed, Jul 21, 9:18 PM
epriestley committed rP2ff1d4b3b007: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods (authored by epriestley).
Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods
Wed, Jul 21, 9:18 PM
epriestley committed rP4cffaa600bec: Rename "HarbormasterRestartException" to "HarbormasterMessageException" (authored by epriestley).
Rename "HarbormasterRestartException" to "HarbormasterMessageException"
Wed, Jul 21, 9:18 PM
epriestley committed rP4c4123f98b6d: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort… (authored by epriestley).
Allow "harbormaster.sendmessage" to send control command (pause, restart, abort…
Wed, Jul 21, 9:18 PM
epriestley committed rP346ffc51e100: Modularize "HarbormasterBuildableTransaction" (authored by epriestley).
Modularize "HarbormasterBuildableTransaction"
Wed, Jul 21, 9:18 PM
epriestley closed D21694: Modularize "HarbormasterBuildableTransaction".
Wed, Jul 21, 9:18 PM
epriestley closed D21693: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".
Wed, Jul 21, 9:18 PM
epriestley committed rP706b91adf677: Remove "HarbormasterBuildableTransaction::TYPE_CREATE" (authored by epriestley).
Remove "HarbormasterBuildableTransaction::TYPE_CREATE"
Wed, Jul 21, 9:18 PM
epriestley committed rP1a1395579f95: Remove "HarbormasterBuildCommand" (authored by epriestley).
Remove "HarbormasterBuildCommand"
Wed, Jul 21, 9:18 PM
epriestley closed D21692: Remove "HarbormasterBuildCommand".
Wed, Jul 21, 9:18 PM
epriestley closed D21691: Modularize almost all Harbormaster build message workflows and UI/UX.
Wed, Jul 21, 9:18 PM
epriestley committed rP1212dc5fbe8b: Modularize almost all Harbormaster build message workflows and UI/UX (authored by epriestley).
Modularize almost all Harbormaster build message workflows and UI/UX
Wed, Jul 21, 9:18 PM
epriestley committed rP8bbee921398d: Modularize individual Harbormaster build messages (authored by epriestley).
Modularize individual Harbormaster build messages
Wed, Jul 21, 9:17 PM
epriestley closed D21690: Modularize individual Harbormaster build messages.
Wed, Jul 21, 9:17 PM
epriestley closed D21689: Modularize HarbormasterBuildTransaction.
Wed, Jul 21, 9:17 PM
epriestley committed rP6dfea0adaddc: Modularize HarbormasterBuildTransaction (authored by epriestley).
Modularize HarbormasterBuildTransaction
Wed, Jul 21, 9:17 PM
epriestley committed rPb84c02959a8b: Remove "HarbormasterBuildTransaction::TYPE_CREATE" (authored by epriestley).
Remove "HarbormasterBuildTransaction::TYPE_CREATE"
Wed, Jul 21, 9:17 PM
epriestley committed rP012af00731fd: Improve formality of "HarbormasterBuild" states (authored by epriestley).
Improve formality of "HarbormasterBuild" states
Wed, Jul 21, 9:17 PM
epriestley committed rPbf83fffca129: Correct the flow of edit authority when sending messages to HarbormasterBuild… (authored by epriestley).
Correct the flow of edit authority when sending messages to HarbormasterBuild…
Wed, Jul 21, 9:17 PM
epriestley closed D21688: Remove "HarbormasterBuildTransaction::TYPE_CREATE".
Wed, Jul 21, 9:17 PM
epriestley closed D21685: Improve formality of "HarbormasterBuild" states.
Wed, Jul 21, 9:17 PM
epriestley committed rPb48d4fabaf9e: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage" (authored by epriestley).
Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"
Wed, Jul 21, 9:17 PM
epriestley closed D21684: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage".
Wed, Jul 21, 9:17 PM
epriestley committed rP0f93d1ffe450: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"… (authored by epriestley).
Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"…
Wed, Jul 21, 9:17 PM
epriestley closed D21683: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages" table.
Wed, Jul 21, 9:17 PM
cspeckmim closed D21706: Update other usages of "hg rebase" to use the new extension-enabling function.
Wed, Jul 21, 9:11 PM
cspeckmim committed rARC76a2976fd9a4: Update other usages of "hg rebase" to use the new extension-enabling function (authored by cspeckmim).
Update other usages of "hg rebase" to use the new extension-enabling function
Wed, Jul 21, 9:11 PM
cspeckmim updated the test plan for D21706: Update other usages of "hg rebase" to use the new extension-enabling function.
Wed, Jul 21, 9:11 PM
epriestley accepted D21706: Update other usages of "hg rebase" to use the new extension-enabling function.
Wed, Jul 21, 9:06 PM
cspeckmim updated the diff for D21706: Update other usages of "hg rebase" to use the new extension-enabling function.

These keep springing up

Wed, Jul 21, 9:03 PM
cspeckmim requested review of D21706: Update other usages of "hg rebase" to use the new extension-enabling function.
Wed, Jul 21, 8:59 PM
cspeckmim added a revision to T13659: `arc land` may fail with missing rebase extension: D21706: Update other usages of "hg rebase" to use the new extension-enabling function.
Wed, Jul 21, 8:59 PM · Arcanist, Mercurial
Harbormaster failed to build B25495: rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in… for rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in…!
Wed, Jul 21, 5:22 PM
epriestley committed rARCec68005d758c: Remove "phutil_deprecated()" (authored by epriestley).
Remove "phutil_deprecated()"
Wed, Jul 21, 5:21 PM
epriestley closed D21704: Remove "phutil_deprecated()".
Wed, Jul 21, 5:21 PM
epriestley closed D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:21 PM
epriestley committed rARC8bb7d5889050: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()" (authored by epriestley).
Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()"
Wed, Jul 21, 5:21 PM
epriestley closed T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()" as Resolved by committing rARC8bb7d5889050: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:21 PM · Infrastructure
epriestley committed rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in… (authored by epriestley).
Use "resolve()", not "execute()", for PhutilExecPassthru callsites in…
Wed, Jul 21, 5:21 PM
epriestley closed D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 5:21 PM
epriestley added inline comments to D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:20 PM
cspeckmim accepted D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 5:18 PM
cspeckmim accepted D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:17 PM
epriestley updated the test plan for D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:12 PM
epriestley requested review of D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:12 PM
epriestley added a revision to T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()": D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:11 PM · Infrastructure
epriestley requested review of D21704: Remove "phutil_deprecated()".
Wed, Jul 21, 5:08 PM
epriestley requested review of D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 4:56 PM
epriestley added a revision to T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()": D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 4:54 PM · Infrastructure
epriestley triaged T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()" as Low priority.
Wed, Jul 21, 4:49 PM · Infrastructure
epriestley added a comment to T13659: `arc land` may fail with missing rebase extension.

(After picking up D21697, the approach works properly in my environment where I originally ran into this, but there are a couple of rebase calls still present in ArcanistMercurialLandEngine that don't use the new API yet.)

Wed, Jul 21, 4:44 PM · Arcanist, Mercurial
epriestley added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

I just use TextMate, which is a fairly lightweight editor. I have it minimally configured to disable a couple of default behaviors and add a couple aliases, and I have a crude "jump-to-definition" script set up that tries to open whatever file defines the class/function under the cursor and succeeds about 95% of the time.

Wed, Jul 21, 4:29 PM
cspeckmim added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

Do you use an editor like PHPStorm or WebStorm? So far I've been using SublimeText and ripgrep as the primarily tools.

Wed, Jul 21, 4:56 AM
cspeckmim closed D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 4:40 AM
cspeckmim committed rARCac365c3ee509: Refactor how Mercurial runs commands that require extensions (authored by cspeckmim).
Refactor how Mercurial runs commands that require extensions
Wed, Jul 21, 4:40 AM
cspeckmim updated the test plan for D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 4:19 AM
epriestley added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

...the one with --onto-remote default not appearing in the trace output...

Wed, Jul 21, 4:14 AM
cspeckmim added inline comments to D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 4:10 AM
cspeckmim added inline comments to D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 4:05 AM
epriestley added inline comments to D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 4:04 AM
cspeckmim updated the diff for D21697: Refactor how Mercurial runs commands that require extensions.
  • Updated the MercurialMarkerQuery to use a similar execPassthruWithExtension(). This results in printing the execution with --trace and better encapsulates the functions handling the extension-enabling details.
  • Made newConfiguredFuture() to combine the environment/cwd configuration for mercurial executions.
  • Updated to store result of func_get_args() into a variable first instead of passing directly into a function call.
  • Updated comments.
Wed, Jul 21, 4:01 AM
cspeckmim added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

Oh I forgot to include that it does launch the regular local version of arc-ls-markers in my sample output, which may have provided more context for my comment about the one with --onto-remote default not appearing in the trace output

Wed, Jul 21, 3:37 AM
cspeckmim added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

...or did you mean something else?

Specifically the arc-ls-markers which uses the --output argument, which appears to only be used when a remote marker is specified for landing. That uses $api->newPassthru(). When checking the output from arc land --onto-remote default it doesn't appear to log the execution of the passthru.

Wed, Jul 21, 3:36 AM
epriestley committed rARC35c1b9bf027b: Fix an ExecFuture typo, "preprebuilt" (authored by epriestley).
Fix an ExecFuture typo, "preprebuilt"
Wed, Jul 21, 3:18 AM
epriestley closed D21702: Fix an ExecFuture typo, "preprebuilt".
Wed, Jul 21, 3:18 AM
epriestley requested review of D21702: Fix an ExecFuture typo, "preprebuilt".
Wed, Jul 21, 3:15 AM
epriestley accepted D21697: Refactor how Mercurial runs commands that require extensions.

Thanks! Couple of minor inlines but I didn't catch anything substantial.

Wed, Jul 21, 3:14 AM
cspeckmim added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

On a non-head dirty commit I ran arc diff --trace and could confirm these ran properly

$ hg --encoding utf-8 --config 'extensions.arg-hg=/Users/cspeckrun/Source/phacility/arcanist/support/hg/arc-hg.py' arc-amend --logfile /private/var/folders/cg/364w44254v5767ydf_x1tg_80000gn/T/cglmx89uf3ks4gow/45330-yqYFDu
Wed, Jul 21, 1:54 AM
cspeckmim updated the diff for D21697: Refactor how Mercurial runs commands that require extensions.

Simplify some of the code by splitting out the bit which produces the flag to enable the extension and the bit that combines everything into an array of arguments to be passed into e.g. execxLocal().

Wed, Jul 21, 1:47 AM
cspeckmim added inline comments to D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 1:26 AM
cspeckmim published D21697: Refactor how Mercurial runs commands that require extensions for review.

Okay I think this is ready for review. I'm not too certain I'm handling the command pattern population properly but I learned more about PHP reflection.

Wed, Jul 21, 1:15 AM
0 closed D21701: Suppress PHP 8 deprecation warning in startup.
Wed, Jul 21, 1:07 AM
0 committed rP2f1acf8b10cb: Suppress PHP 8 deprecation warning in startup (authored by 0).
Suppress PHP 8 deprecation warning in startup
Wed, Jul 21, 1:07 AM
epriestley accepted D21701: Suppress PHP 8 deprecation warning in startup.
Wed, Jul 21, 1:03 AM
epriestley added a comment to T13648: Transaction publishing may stall during mail expansion of package recipients.

This happens when a recipient list includes an Owners package which has been destroyed. Specifically, we'll exit this section of PhabricatorMetaMTAMemberQuery with out the PHID in $package_map, and then fail to return it:

Wed, Jul 21, 1:03 AM · Transactions
0 published D21701: Suppress PHP 8 deprecation warning in startup for review.
Wed, Jul 21, 1:00 AM
0 added a revision to T13588: PHP 8 Compatibility: D21701: Suppress PHP 8 deprecation warning in startup.
Wed, Jul 21, 12:54 AM · Infrastructure
cspeckmim added a comment to D21680: An assortment of fixes and updates to using arc-land with mercurial.

Oh, maybe I'm mixing up running arc diff B against running plain arc diff while being on B

Wed, Jul 21, 12:53 AM
cspeckmim closed T3271: Before launching $EDITOR from arc, print that we're doing it, a subtask of T13098: Plans: Arcanist toolsets and extensions, as Resolved.
Wed, Jul 21, 12:37 AM · Arcanist, Plans
cspeckmim closed T3271: Before launching $EDITOR from arc, print that we're doing it as Resolved.

Marking this as resolved by D21700. If there are further details or input we can re-open to further address.

Wed, Jul 21, 12:37 AM · Arcanist
cspeckmim closed D21700: Display informative message when arc launches an editor.
Wed, Jul 21, 12:33 AM
cspeckmim committed rARC232363e387da: Display informative message when arc launches an editor (authored by cspeckmim).
Display informative message when arc launches an editor
Wed, Jul 21, 12:33 AM
cspeckmim updated the diff for D21700: Display informative message when arc launches an editor.

Update formatting

Wed, Jul 21, 12:32 AM