Fri, Sep 13
In stacked area charts, when we stack areas, we accumulate some error by stacking integer points on top of interpolated points.
if prototypes are disabled, some stuff is broken, particularly "View Chart".
At the lowest levels:
This needs a lot more work, but here's very roughly where I'm trying to go with this:
Thu, Sep 12
D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.
For LDAP, brew install openldap + --with-ldap=/usr/local/opt/openldap/.
Here's the fate of the various issues discussed here:
This should be reworked some day (perhaps partly here) into some more cohesive API, perhaps newLink().
One other thing is that PhabricatorApplicationPolicyChangeTransaction->renderApplicationPolicy() has unconventional behaviors which are not very helpful and not consistent with normal CAN_EDIT / CAN_VIEW transactions. This is somewhat perplexing because ModularTransactions has renderPolicy() already, which has better behavior. I think it didn't exist yet when Applications modularized in D17757, and when it was introduced in D19829 I just overlooked the opportunity to update it.
In Applications → (Pick Something), if an application policy is set to "Custom Policy", the policy is not linked.
Wed, Sep 11
I upstreamed this to Chrome here: https://bugs.chromium.org/p/chromium/issues/detail?id=1003002
I understand this was supposed to be mentioned here: Herald ignores commits that are ancestors of permanent refs if they were previously pushed to some other non-permanent ref.