Page MenuHomePhabricator
Feed All Stories

Today

epriestley closed T13462: Correct some policy/membership issues in milestone creation as Resolved.
Tue, Nov 19, 7:13 AM · Projects, Policy
epriestley committed rPd58eddcf0ad4: When predicting project membership during edits, predict milestones will have… (authored by epriestley).
When predicting project membership during edits, predict milestones will have…
Tue, Nov 19, 7:07 AM
epriestley closed D20920: When predicting project membership during edits, predict milestones will have parent membership.
Tue, Nov 19, 7:07 AM
epriestley committed rP959504a4881c: When predicting object policies for project milestones, adjust objects so they… (authored by epriestley).
When predicting object policies for project milestones, adjust objects so they…
Tue, Nov 19, 7:06 AM
epriestley closed D20919: When predicting object policies for project milestones, adjust objects so they behave like milestones.
Tue, Nov 19, 7:06 AM
epriestley requested review of D20920: When predicting project membership during edits, predict milestones will have parent membership.
Tue, Nov 19, 6:53 AM
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We materialize some members into the milestone? This causes no real problems, but we shouldn't materialize members into milestones.

Tue, Nov 19, 6:53 AM · Projects, Policy
epriestley added a revision to T13462: Correct some policy/membership issues in milestone creation: D20920: When predicting project membership during edits, predict milestones will have parent membership.
Tue, Nov 19, 6:52 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We predict the wrong set of members for the milestone when testing policies: we predict "no members", but should predict "exactly the same as the members of the parent project"?

Tue, Nov 19, 6:42 AM · Projects, Policy
epriestley requested review of D20919: When predicting object policies for project milestones, adjust objects so they behave like milestones.
Tue, Nov 19, 6:30 AM
epriestley added a revision to T13462: Correct some policy/membership issues in milestone creation: D20919: When predicting object policies for project milestones, adjust objects so they behave like milestones.
Tue, Nov 19, 6:29 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We check the wrong edit policy when testing if you can create a milestone: we check the default application policy, but should check the parent project policy?

Tue, Nov 19, 6:13 AM · Projects, Policy
epriestley triaged T13462: Correct some policy/membership issues in milestone creation as Normal priority.
Tue, Nov 19, 6:09 AM · Projects, Policy
epriestley committed rPde66a8ece185: Remove "stronger/weaker" policy color hints from object headers (authored by epriestley).
Remove "stronger/weaker" policy color hints from object headers
Tue, Nov 19, 6:05 AM
epriestley closed D20918: Remove "stronger/weaker" policy color hints from object headers.
Tue, Nov 19, 6:05 AM
epriestley closed T13461: Remove policy tag coloration in object header UI as Resolved by committing rPde66a8ece185: Remove "stronger/weaker" policy color hints from object headers.
Tue, Nov 19, 6:05 AM · Policy
epriestley updated the task description for T13461: Remove policy tag coloration in object header UI.
Tue, Nov 19, 6:04 AM · Policy
epriestley requested review of D20918: Remove "stronger/weaker" policy color hints from object headers.
Tue, Nov 19, 6:01 AM
epriestley added a revision to T13461: Remove policy tag coloration in object header UI: D20918: Remove "stronger/weaker" policy color hints from object headers.
Tue, Nov 19, 6:00 AM · Policy
epriestley committed rP1996b0cd55c5: Update the "owner can always view/edit" policy exception rule (authored by epriestley).
Update the "owner can always view/edit" policy exception rule
Tue, Nov 19, 5:54 AM
epriestley closed D20917: Update the "owner can always view/edit" policy exception rule.
Tue, Nov 19, 5:54 AM
epriestley closed T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Resolved by committing rP1996b0cd55c5: Update the "owner can always view/edit" policy exception rule.
Tue, Nov 19, 5:54 AM · Policy, Maniphest
epriestley triaged T13461: Remove policy tag coloration in object header UI as Low priority.
Tue, Nov 19, 5:49 AM · Policy
epriestley requested review of D20917: Update the "owner can always view/edit" policy exception rule.
Tue, Nov 19, 5:42 AM
epriestley added a revision to T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs: D20917: Update the "owner can always view/edit" policy exception rule.
Tue, Nov 19, 5:41 AM · Policy, Maniphest
epriestley triaged T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Low priority.
Tue, Nov 19, 5:38 AM · Policy, Maniphest
epriestley committed rARCe19fe12f7ecd: (experimental) When "arc close-revision --finalize ..." skips closing a… (authored by epriestley).
(experimental) When "arc close-revision --finalize ..." skips closing a…
Tue, Nov 19, 5:12 AM
epriestley committed rARC039144ea24ba: Allow "arc upgrade" to work on the "experimental" branch (authored by epriestley).
Allow "arc upgrade" to work on the "experimental" branch
Tue, Nov 19, 4:53 AM
epriestley closed D20916: Allow "arc upgrade" to work on the "experimental" branch.
Tue, Nov 19, 4:53 AM
epriestley closed T13459: Allow "arc upgrade" to upgrade the "experimental" branch as Resolved by committing rARC039144ea24ba: Allow "arc upgrade" to work on the "experimental" branch.
Tue, Nov 19, 4:53 AM · Arcanist
epriestley requested review of D20916: Allow "arc upgrade" to work on the "experimental" branch.
Tue, Nov 19, 4:53 AM
epriestley added a revision to T13459: Allow "arc upgrade" to upgrade the "experimental" branch: D20916: Allow "arc upgrade" to work on the "experimental" branch.
Tue, Nov 19, 4:52 AM · Arcanist
epriestley triaged T13459: Allow "arc upgrade" to upgrade the "experimental" branch as Low priority.
Tue, Nov 19, 4:47 AM · Arcanist
epriestley committed rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a… (authored by epriestley).
When "arc close-revision --finalize ..." skips closing a revision, print a…
Tue, Nov 19, 4:31 AM
epriestley closed D20915: When "arc close-revision --finalize ..." skips closing a revision, print a message.
Tue, Nov 19, 4:31 AM
epriestley closed T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message as Resolved by committing rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a….
Tue, Nov 19, 4:31 AM · Arcanist
epriestley requested review of D20915: When "arc close-revision --finalize ..." skips closing a revision, print a message.
Tue, Nov 19, 4:31 AM
epriestley added a revision to T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message: D20915: When "arc close-revision --finalize ..." skips closing a revision, print a message.
Tue, Nov 19, 4:30 AM · Arcanist
epriestley updated the task description for T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message.
Tue, Nov 19, 4:15 AM · Arcanist
epriestley claimed T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message.
Tue, Nov 19, 4:14 AM · Arcanist
epriestley triaged T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message as Low priority.
Tue, Nov 19, 4:14 AM · Arcanist

Sun, Nov 17

Kwisatz awarded T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available a Like token.
Sun, Nov 17, 3:22 PM · Haskell.org, Auth

Thu, Nov 14

epriestley requested review of D20914: Update repository identities after all mutations to users and email addresses.
Thu, Nov 14, 7:51 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20914: Update repository identities after all mutations to users and email addresses.
Thu, Nov 14, 7:49 PM · Diffusion
epriestley requested review of D20913: Give "PhabricatorUserEmail" a PHID.
Thu, Nov 14, 7:32 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20913: Give "PhabricatorUserEmail" a PHID.
Thu, Nov 14, 7:31 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Uhhhh, absolutely none of this works because PhabricatorUserEmail does not have a PHID.

Thu, Nov 14, 7:20 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Another likely bug is:

Thu, Nov 14, 7:05 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Currently, the flow here is that changes queue a daemon task.

Thu, Nov 14, 6:42 PM · Diffusion
epriestley requested review of D20912: Use DestructionEngine to destroy UserEmail objects.
Thu, Nov 14, 6:25 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20912: Use DestructionEngine to destroy UserEmail objects.
Thu, Nov 14, 6:24 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Removing an email does not properly disassociate identities. This unambiguously should.

Thu, Nov 14, 6:12 PM · Diffusion
epriestley requested review of D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Thu, Nov 14, 5:36 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Thu, Nov 14, 5:34 AM · Diffusion
epriestley requested review of D20910: Consolidate repository identity resolution and detection code.
Thu, Nov 14, 4:52 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20910: Consolidate repository identity resolution and detection code.
Thu, Nov 14, 4:50 AM · Diffusion
epriestley requested review of D20909: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event.
Thu, Nov 14, 4:27 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20909: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event.
Thu, Nov 14, 4:25 AM · Diffusion
epriestley requested review of D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently.
Thu, Nov 14, 4:10 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently.
Thu, Nov 14, 4:09 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.

Thu, Nov 14, 3:22 AM · Diffusion
epriestley requested review of D20907: Make repository identity email address association case-insensitive.
Thu, Nov 14, 3:17 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20907: Make repository identity email address association case-insensitive.
Thu, Nov 14, 3:15 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.
  • When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.
Thu, Nov 14, 3:05 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

The internal construction with LIKE '%...' is also not great:

Thu, Nov 14, 2:47 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Looking up identities by email address is improperly case-sensitive, because the query is a LIKE query against a binary column.

Thu, Nov 14, 2:46 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Here's a list of bugs I expect exist, although I haven't made it far as reproducing them yet:

Thu, Nov 14, 2:41 AM · Diffusion
epriestley added a parent task for T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: T13444: Provide a standalone script entry point for resolving a repository identity.
Thu, Nov 14, 2:12 AM · Diffusion
epriestley added a subtask for T13444: Provide a standalone script entry point for resolving a repository identity: T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration.
Thu, Nov 14, 2:12 AM · Diffusion
epriestley triaged T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Low priority.
Thu, Nov 14, 1:35 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

We currently have bin/repository rebuild-identities, which takes a list of repository identifiers or --all. This has a lot of history in T12164 and we currently queue an "activity" for it during migrations in 20180809.repo_identities.activity.php.

Thu, Nov 14, 1:19 AM · Diffusion

Wed, Nov 13

epriestley committed rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits (authored by epriestley).
Surface edits to "Text" panels on dashboards as remarkup edits
Wed, Nov 13, 6:35 PM
epriestley closed D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:35 PM
epriestley closed T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Resolved by committing rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:35 PM · Dashboards, Remarkup
epriestley requested review of D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:33 PM
epriestley added a revision to T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc): D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:32 PM · Dashboards, Remarkup
epriestley triaged T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Low priority.
Wed, Nov 13, 6:31 PM · Dashboards, Remarkup
epriestley committed rP2adc36ba0b8d: Correctly identify more SSH private key problems as "formatting" or… (authored by epriestley).
Correctly identify more SSH private key problems as "formatting" or…
Wed, Nov 13, 6:22 PM
epriestley closed D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:22 PM
epriestley closed T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys as Resolved.

I've marked D20905 as resolving this. This isn't really "resolved" completely, but T13454 has a better description of what the problems are and why they're difficult. Our behavior is, at least, substantially better than it was before.

Wed, Nov 13, 6:19 PM · Passphrase
epriestley closed T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys, a subtask of T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body, as Resolved.
Wed, Nov 13, 6:19 PM · Auth
epriestley requested review of D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:18 PM
epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:17 PM · Auth
epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:17 PM · Passphrase
epriestley added a parent task for T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.
Wed, Nov 13, 6:12 PM · Passphrase
epriestley added a subtask for T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys.
Wed, Nov 13, 6:12 PM · Auth
epriestley abandoned D20904: Perform a more sophisticated test for private keys with credentials.

I have a fancier version of this in the works.

Wed, Nov 13, 5:45 PM
epriestley claimed T13455: Make "View Options" in Differential sticky across reloads.
Wed, Nov 13, 4:07 PM · Differential
epriestley triaged T13455: Make "View Options" in Differential sticky across reloads as Low priority.
Wed, Nov 13, 4:07 PM · Differential
epriestley added a comment to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.

On Ubuntu 14, the messages are a little less helpful:

Wed, Nov 13, 4:01 AM · Auth
epriestley updated the task description for T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.
Wed, Nov 13, 3:11 AM · Auth

Mon, Nov 11

20after4 edited the content of Community Resources.
Mon, Nov 11, 10:12 PM
epriestley edited the content of 2019 Week 44 (Early November).
Mon, Nov 11, 7:45 PM
epriestley requested review of D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:21 PM
epriestley added a revision to T13123: Plans: Improve SSH key parsing and handling: D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:19 PM · Plans, Auth
epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:19 PM · Auth
epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:19 PM · Passphrase
epriestley triaged T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body as Low priority.
Mon, Nov 11, 7:15 PM · Auth
Firehed requested review of D20903: Ensure __path__ is set on POST requests when running on CLI webserver.
Mon, Nov 11, 6:27 PM
earthian added a watcher for Nuance: earthian.
Mon, Nov 11, 7:04 AM