Page MenuHomePhabricator
Feed All Stories

Yesterday

dereckson abandoned D16856: Allow Pygments to recognize .rs files as Rust.

Broader work required than extension/language map update, see T3626.

Sun, Oct 21, 9:13 PM
dereckson abandoned D17104: Update PhabricatorPhabricatorAuthProvider client create URL.

A better long-term solution than a temporary fix is wanted, per D17104#203911

Sun, Oct 21, 9:12 PM
dereckson abandoned D15336: L10n: projects → project tags.

Stale localisation issue

Sun, Oct 21, 9:11 PM
dereckson requested review of D19749: Address continue statement scope.
Sun, Oct 21, 9:08 PM

Sat, Oct 20

epriestley edited the content of Changelog.
Sat, Oct 20, 10:48 AM
epriestley committed rP9c514bcf93d8: (stable) Promote 2018 Week 42 (authored by epriestley).
(stable) Promote 2018 Week 42
Sat, Oct 20, 10:47 AM
epriestley created 2018 Week 42 (Late October).
Sat, Oct 20, 10:47 AM
epriestley committed rPe2cf1e42887a: Skip copied code detection for changes that are too large for it to be useful (authored by epriestley).
Skip copied code detection for changes that are too large for it to be useful
Sat, Oct 20, 10:36 AM
epriestley closed D19748: Skip copied code detection for changes that are too large for it to be useful.
Sat, Oct 20, 10:36 AM
epriestley added a commit to T13210: Plans: 2018 Week 41-43 Bonus Content: rPe2cf1e42887a: Skip copied code detection for changes that are too large for it to be useful.
Sat, Oct 20, 10:36 AM · Plans
epriestley added a comment to D19748: Skip copied code detection for changes that are too large for it to be useful.

Should this hook into any of the HUGE/TRULY_CRAZY_HUGE diff detection stuff that got fixed a few months ago instead of defining a new constant here?

Sat, Oct 20, 10:32 AM

Fri, Oct 19

amckinley accepted D19748: Skip copied code detection for changes that are too large for it to be useful.
Fri, Oct 19, 9:27 PM
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

One more of these just came in for repo003.

Fri, Oct 19, 8:56 PM · Phacility, Ops
epriestley committed rPe0dea4c4862f: Fix `packages(project)` to work properly and add it to… (authored by epriestley).
Fix `packages(project)` to work properly and add it to…
Fri, Oct 19, 8:53 PM
epriestley added a commit to T13210: Plans: 2018 Week 41-43 Bonus Content: rPe0dea4c4862f: Fix `packages(project)` to work properly and add it to….
Fri, Oct 19, 8:53 PM · Plans
epriestley closed D19747: Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource".
Fri, Oct 19, 8:53 PM
epriestley requested review of D19748: Skip copied code detection for changes that are too large for it to be useful.
Fri, Oct 19, 8:29 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-43 Bonus Content: D19748: Skip copied code detection for changes that are too large for it to be useful.
Fri, Oct 19, 8:27 PM · Plans
amckinley accepted D19747: Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource".
Fri, Oct 19, 7:15 PM
epriestley updated the task description for T13210: Plans: 2018 Week 41-43 Bonus Content.
Fri, Oct 19, 6:51 PM · Plans
epriestley updated the task description for T13210: Plans: 2018 Week 41-43 Bonus Content.
Fri, Oct 19, 6:22 PM · Plans
epriestley updated the task description for T13210: Plans: 2018 Week 41-43 Bonus Content.
Fri, Oct 19, 6:22 PM · Plans
epriestley updated the task description for T13210: Plans: 2018 Week 41-43 Bonus Content.
Fri, Oct 19, 5:59 PM · Plans
epriestley updated the task description for T13210: Plans: 2018 Week 41-43 Bonus Content.
Fri, Oct 19, 5:55 PM · Plans
epriestley renamed T13210: Plans: 2018 Week 41-43 Bonus Content from Plans: 2018 Week 41-42 Bonus Content to Plans: 2018 Week 41-43 Bonus Content.
Fri, Oct 19, 5:54 PM · Plans
epriestley requested review of D19747: Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource".
Fri, Oct 19, 11:47 AM
epriestley added a revision to T13210: Plans: 2018 Week 41-43 Bonus Content: D19747: Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource".
Fri, Oct 19, 11:46 AM · Plans
epriestley added a comment to T7413: Build an opt-in "report stats to upstream" workflow to collect version/usage data.

I never remember the name of this ticket, so here are the things I think it's called: phone home mothership

Fri, Oct 19, 11:09 AM
epriestley closed T12703: When integrated, CircleCI and Harbormaster can send redundant notifications as Wontfix.

This currently appears to be mooted by T13188.

Fri, Oct 19, 9:27 AM · Feature Request, Harbormaster

Wed, Oct 17

epriestley added a comment to T13109: Improve cluster write feedback and write routing.

I think you can cherry-pick those changes safely. I suspect further changes connected to T13211 and/or T10884 in the near future are likely to be difficult to cherry-pick, though, so ideally you should try to upgrade.

Wed, Oct 17, 10:01 PM · Diffusion
epriestley added a comment to T13115: Handle mail bounces inside Phabricator.

To pull the list down (this takes a while since we can only grab 100 results at a time and the API takes a while to respond):

Wed, Oct 17, 8:47 PM · Mail
epriestley added a comment to T13115: Handle mail bounces inside Phabricator.

See PHI962, where a GSuite-backed install has seen multiple "550 No Such User" bounces to the same address even though the address exists. It's currently unclear if this is an issue in Mailgun, GSuite, the series of tubes between the two, or elsewhere.

Wed, Oct 17, 8:24 PM · Mail
nickz added a comment to T13109: Improve cluster write feedback and write routing.

@epriestley : our current phabricator version is c46be2a70b4db72d61e76690ef095384de2c3f91 that was landed on 04/13, will there be any issues if we directly cherry pick the recent two versions without pulling any other changes?
rP51073b972ece: Try to route cluster writes to nodes which won't need to synchronize first.Wed, Oct 17, 3:08 PM
rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync.

Wed, Oct 17, 7:37 PM · Diffusion
epriestley added a comment to D19734: Try to route cluster writes to nodes which won't need to synchronize first.

I made another large push, then a series of small pushes. The big push hit secure001. The small pushes then hit:

Wed, Oct 17, 3:33 PM
epriestley committed rGITTEST49114a7de0e5: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:30 PM
epriestley committed rGITTEST738948f95d81: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:27 PM
epriestley committed rGITTEST2de33fdf738e: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:27 PM
epriestley committed rGITTEST5e0f895d1c0f: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:26 PM
epriestley committed rGITTESTc56a4ff06d80: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:26 PM
epriestley committed rGITTESTa7be3e2aa581: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:25 PM
epriestley committed rGITTEST404db5a67fb9: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:25 PM
epriestley committed rGITTEST8b328030efe5: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:23 PM
epriestley committed rGITTESTc4d1d42bbae1: junk (authored by epriestley).
junk
Wed, Oct 17, 3:23 PM
epriestley committed rGITTEST1b03b6585a82: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:23 PM
epriestley committed rGITTESTd436a0c5f471: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:23 PM
epriestley committed rGITTEST7cd463ac8fdc: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:23 PM
epriestley committed rGITTESTe1b6dd9a0b84: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:20 PM
epriestley committed rGITTESTb89271fe5459: junk (authored by epriestley).
junk
Wed, Oct 17, 3:20 PM
epriestley committed rGITTESTcab297cefce9: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:20 PM
epriestley committed rGITTEST3ebf6b894bc2: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:20 PM
epriestley committed rGITTEST263b2838d91f: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 3:20 PM
epriestley committed rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync (authored by epriestley).
Explicitly shuffle nodes before selecting one for cluster sync
Wed, Oct 17, 3:11 PM
epriestley added a commit to T13109: Improve cluster write feedback and write routing: rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync.
Wed, Oct 17, 3:11 PM · Diffusion
epriestley added a commit to T10884: Sort repository, database and notification services better (by network distance): rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync.
Wed, Oct 17, 3:11 PM · Clusters
epriestley added a commit to T13202: Plans: 2018 Week 38-40 Bonus Content: rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync.
Wed, Oct 17, 3:11 PM · Plans
epriestley closed D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Wed, Oct 17, 3:11 PM
epriestley committed rP51073b972ece: Try to route cluster writes to nodes which won't need to synchronize first (authored by epriestley).
Try to route cluster writes to nodes which won't need to synchronize first
Wed, Oct 17, 3:08 PM
epriestley added a commit to T13109: Improve cluster write feedback and write routing: rP51073b972ece: Try to route cluster writes to nodes which won't need to synchronize first.
Wed, Oct 17, 3:08 PM · Diffusion
epriestley closed D19734: Try to route cluster writes to nodes which won't need to synchronize first.
Wed, Oct 17, 3:08 PM
epriestley added a commit to T13202: Plans: 2018 Week 38-40 Bonus Content: rP51073b972ece: Try to route cluster writes to nodes which won't need to synchronize first.
Wed, Oct 17, 3:08 PM · Plans
epriestley added a comment to D19734: Try to route cluster writes to nodes which won't need to synchronize first.

Big push is:

Wed, Oct 17, 3:03 PM
epriestley committed rGITTEST95c84be7b254: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 2:59 PM
epriestley committed rGITTESTc16fb0b65383: junk (authored by epriestley).
junk
Wed, Oct 17, 2:53 PM
epriestley committed rGITTESTb7dd276db8b3: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 2:53 PM
epriestley committed rGITTEST97c8829d1240: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 2:52 PM
epriestley committed rGITTEST8ddec6e1b323: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 2:49 PM
epriestley committed rGITTEST463b5a50f94b: More Stuff (authored by epriestley).
More Stuff
Wed, Oct 17, 2:49 PM
epriestley added a comment to D19734: Try to route cluster writes to nodes which won't need to synchronize first.

To "sort of" test this in a real environment, I'm going to do this:

Wed, Oct 17, 2:48 PM
epriestley updated the task description for T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Wed, Oct 17, 2:04 PM · Plans, Phacility
epriestley edited the content of Changelog.
Wed, Oct 17, 6:45 AM
epriestley committed rPHU8c1091dc9892: (stable) Promote 2018 Week 41 (authored by epriestley).
(stable) Promote 2018 Week 41
Wed, Oct 17, 6:44 AM
epriestley committed rPa0f323a72f81: (stable) Promote 2018 Week 41 (authored by epriestley).
(stable) Promote 2018 Week 41
Wed, Oct 17, 6:44 AM
epriestley created 2018 Week 41 (Mid October).
Wed, Oct 17, 6:43 AM

Tue, Oct 16

amckinley accepted D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Tue, Oct 16, 10:38 PM
epriestley planned changes to D19746: Make the Harbormaster build plan edit engine forms configurable.

This is slightly more involved than I initially believed, we have a "Default Edit Policy" and "Default View Policy" which should probably be nuked now and PHI933 also has a sub-request for an "Author" object policy.

Tue, Oct 16, 8:19 PM
epriestley requested review of D19746: Make the Harbormaster build plan edit engine forms configurable.
Tue, Oct 16, 7:49 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-43 Bonus Content: D19746: Make the Harbormaster build plan edit engine forms configurable.
Tue, Oct 16, 7:48 PM · Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

One idea here: T12961 and T13012 are security issues related to the misuse of -- in argument lists. I think there was one more (less severe issue?) with Git elsewhere, too.

Tue, Oct 16, 2:54 PM · Arcanist, Plans
epriestley renamed T13210: Plans: 2018 Week 41-43 Bonus Content from Plans: 2018 Week 41 Bonus Content to Plans: 2018 Week 41-42 Bonus Content.
Tue, Oct 16, 2:32 PM · Plans
epriestley added a project to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call: Drydock.
Tue, Oct 16, 2:32 PM · Drydock
epriestley added a comment to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.

This is entirely reasonable, the only reason it doesn't already exist is that the lease owner may be any of several different types of objects (I think: user, repository, another Drydock object, maybe null?) and we don't have a convenient UI datasource for letting users type to select any one of these various object types.

Tue, Oct 16, 2:32 PM · Drydock
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Tue, Oct 16, 1:36 PM · Plans, Drydock, Harbormaster
epriestley added a comment to D19734: Try to route cluster writes to nodes which won't need to synchronize first.

We can make shuffle() predictable, but should probably implement our own state-maintaining PRNG to do so. If we use srand() / mt_srand() without maintaining our own state:

Tue, Oct 16, 1:34 PM
joshuaspence awarded D19734: Try to route cluster writes to nodes which won't need to synchronize first a Doubloon token.
Tue, Oct 16, 8:48 AM
yingshu awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Pterodactyl token.
Tue, Oct 16, 8:06 AM · Restricted Project, Workboards

Mon, Oct 15

avivey added a comment to D19639: Make the Arcanist comment remover less aggressive about stripping instructional comments.

https://discourse.phabricator-community.org/t/latest-arcanist-incorrecly-parses-comments/2013 reports an issue with this new behavior - probably if the Subscribers is left empty, the parser takes the first line of the comment.

Mon, Oct 15, 10:58 PM
epriestley closed T13213: Thoughts on Control Systems as Resolved.

¯\_(ツ)_/¯

Mon, Oct 15, 9:49 PM
epriestley added a revision to T13213: Thoughts on Control Systems: D19745: Caspian, a robotics control system.
Mon, Oct 15, 9:42 PM
amckinley accepted D19734: Try to route cluster writes to nodes which won't need to synchronize first.
Mon, Oct 15, 9:37 PM
epriestley triaged T13213: Thoughts on Control Systems as Wishlist priority.
Mon, Oct 15, 8:04 PM

Fri, Oct 12

jwarner updated the task description for T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.
Fri, Oct 12, 4:27 PM · Drydock
jwarner triaged T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call as Normal priority.
Fri, Oct 12, 4:27 PM · Drydock
epriestley added a member for Blessed Committers: jwarner.
Fri, Oct 12, 4:13 PM
epriestley added a member for Community: jwarner.
Fri, Oct 12, 4:13 PM
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Fri, Oct 12, 3:19 PM · Plans, Drydock, Harbormaster

Thu, Oct 11

epriestley committed rP0a51bc4f05bf: Add a space after "View Inline" in mail to prevent double-click on the filename… (authored by epriestley).
Add a space after "View Inline" in mail to prevent double-click on the filename…
Thu, Oct 11, 8:44 PM
epriestley closed D19742: Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline".
Thu, Oct 11, 8:44 PM
epriestley added a commit to T13210: Plans: 2018 Week 41-43 Bonus Content: rP0a51bc4f05bf: Add a space after "View Inline" in mail to prevent double-click on the filename….
Thu, Oct 11, 8:44 PM · Plans
amckinley accepted D19742: Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline".
Thu, Oct 11, 8:42 PM
epriestley committed rP8bffc9ea0efe: In "bin/bulk export", require "--output <path>" by default (authored by epriestley).
In "bin/bulk export", require "--output <path>" by default
Thu, Oct 11, 8:35 PM