Page MenuHomePhabricator
Feed All Stories

Today

epriestley requested review of D20813: Fix a typo in preamble X-Forwarded-For psuedocode.
Sun, Sep 15, 2:01 PM
reed edited the content of 2019 Week 36 (Early September).
Sun, Sep 15, 11:49 AM

Fri, Sep 13

epriestley edited the content of Changelog.
Fri, Sep 13, 7:37 PM
epriestley created an object: 2019 Week 37 (Mid September).
Fri, Sep 13, 7:36 PM
epriestley committed rP80d17ad7804e: (stable) Promote 2019 Week 37 (authored by epriestley).
(stable) Promote 2019 Week 37
Fri, Sep 13, 7:35 PM
epriestley committed rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings… (authored by epriestley).
(stable) Don't offer personal saved queries in global "Search Scope" settings…
Fri, Sep 13, 7:34 PM
epriestley triaged T13417: "bin/storage upgrade" should test for replication problems before applying migrations as Low priority.
Fri, Sep 13, 7:31 PM · Database
epriestley added a comment to T13279: Build Charting for Facts.

In stacked area charts, when we stack areas, we accumulate some error by stacking integer points on top of interpolated points.

Fri, Sep 13, 5:12 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

if prototypes are disabled, some stuff is broken, particularly "View Chart".

Fri, Sep 13, 4:45 PM · Plans, Facts
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

At the lowest levels:

Fri, Sep 13, 3:24 AM · Phriction
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

This needs a lot more work, but here's very roughly where I'm trying to go with this:

Fri, Sep 13, 2:57 AM · Phriction
epriestley committed rP3dcb4a7b5036: Work around rendering engine freeze in Chrome 77 affecting workboards (authored by epriestley).
Work around rendering engine freeze in Chrome 77 affecting workboards
Fri, Sep 13, 2:04 AM
epriestley closed D20812: Work around rendering engine freeze in Chrome 77 affecting workboards.
Fri, Sep 13, 2:04 AM
epriestley requested review of D20812: Work around rendering engine freeze in Chrome 77 affecting workboards.
Fri, Sep 13, 2:00 AM
epriestley added a revision to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior: D20812: Work around rendering engine freeze in Chrome 77 affecting workboards.
Fri, Sep 13, 1:59 AM · Google Chrome

Thu, Sep 12

epriestley committed rP3f6620336216: Fix a straggling callsite to "renderApplicationPolicy()" (authored by epriestley).
Fix a straggling callsite to "renderApplicationPolicy()"
Thu, Sep 12, 11:27 PM
epriestley closed D20811: Fix a straggling callsite to "renderApplicationPolicy()".
Thu, Sep 12, 11:27 PM
epriestley requested review of D20811: Fix a straggling callsite to "renderApplicationPolicy()".
Thu, Sep 12, 11:23 PM
epriestley triaged T13416: Transaction logs may overheat explosively as Low priority.
Thu, Sep 12, 11:22 PM · Feed
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20811: Fix a straggling callsite to "renderApplicationPolicy()".
Thu, Sep 12, 11:21 PM · Policy
epriestley committed rP41f0b8b0a3a1: Allow subtypes to specify "mutations", to control the behavior of the "Change… (authored by epriestley).
Allow subtypes to specify "mutations", to control the behavior of the "Change…
Thu, Sep 12, 11:17 PM
epriestley closed D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action.
Thu, Sep 12, 11:17 PM
epriestley closed T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Resolved by committing rP41f0b8b0a3a1: Allow subtypes to specify "mutations", to control the behavior of the "Change….
Thu, Sep 12, 11:17 PM · EditEngine
epriestley requested review of D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action.
Thu, Sep 12, 11:13 PM
epriestley added a revision to T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis: D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action.
Thu, Sep 12, 11:12 PM · EditEngine
epriestley triaged T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Low priority.
Thu, Sep 12, 10:39 PM · EditEngine
epriestley committed rP3e6012803725: Support "Subtype" in Herald (authored by epriestley).
Support "Subtype" in Herald
Thu, Sep 12, 9:34 PM
epriestley closed D20809: Support "Subtype" in Herald.
Thu, Sep 12, 9:34 PM
epriestley committed rPd60d4e6a0521: Don't present users with Herald fields/actions for uninstalled applications… (authored by epriestley).
Don't present users with Herald fields/actions for uninstalled applications…
Thu, Sep 12, 9:33 PM
epriestley closed D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them.
Thu, Sep 12, 9:33 PM
epriestley requested review of D20809: Support "Subtype" in Herald.
Thu, Sep 12, 8:18 PM
epriestley requested review of D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them.
Thu, Sep 12, 7:59 PM
epriestley closed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Resolved.

D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.

Thu, Sep 12, 7:59 PM · Applications, Herald
epriestley added a revision to T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them.
Thu, Sep 12, 7:57 PM · Applications, Herald
epriestley triaged T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes as Low priority.
Thu, Sep 12, 7:30 PM · Infrastructure
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

For LDAP, brew install openldap + --with-ldap=/usr/local/opt/openldap/.

Thu, Sep 12, 5:25 PM · Infrastructure
epriestley committed rP4f845d8f8c77: When users encounter a policy exception for a non-view capability with a custom… (authored by epriestley).
When users encounter a policy exception for a non-view capability with a custom…
Thu, Sep 12, 4:49 PM
epriestley closed T13411: Improve "Custom Policy" behavior in policy dialogs as Resolved by committing rP4f845d8f8c77: When users encounter a policy exception for a non-view capability with a custom….
Thu, Sep 12, 4:49 PM · Policy
epriestley closed D20807: When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules.
Thu, Sep 12, 4:49 PM
epriestley committed rP0c7ea8c94215: When users fail a "CAN_SEE" check, give them an "opaque" policy explanation (authored by epriestley).
When users fail a "CAN_SEE" check, give them an "opaque" policy explanation
Thu, Sep 12, 4:42 PM
epriestley closed D20806: When users fail a "CAN_SEE" check, give them an "opaque" policy explanation.
Thu, Sep 12, 4:42 PM
epriestley committed rP9a36e6931cf7: Inline custom policy rules inside policy capability explanation dialogs (authored by epriestley).
Inline custom policy rules inside policy capability explanation dialogs
Thu, Sep 12, 4:41 PM
epriestley closed D20805: Inline custom policy rules inside policy capability explanation dialogs.
Thu, Sep 12, 4:41 PM
epriestley committed rP506f93b4a390: Give policy name rendering explicit "text name", "capability link", and… (authored by epriestley).
Give policy name rendering explicit "text name", "capability link", and…
Thu, Sep 12, 4:39 PM
epriestley closed D20804: Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways.
Thu, Sep 12, 4:39 PM
epriestley committed rPc9b0d107f079: Remove unused "icon" parameter from policy name rendering (authored by epriestley).
Remove unused "icon" parameter from policy name rendering
Thu, Sep 12, 4:38 PM
epriestley closed D20803: Remove unused "icon" parameter from policy name rendering.
Thu, Sep 12, 4:38 PM
epriestley committed rP9c6969e81022: Remove "Editable By" description fields in Passphrase, Phame, and Spaces (authored by epriestley).
Remove "Editable By" description fields in Passphrase, Phame, and Spaces
Thu, Sep 12, 4:37 PM
epriestley closed D20802: Remove "Editable By" description fields in Passphrase, Phame, and Spaces.
Thu, Sep 12, 4:37 PM
epriestley committed rPa35d7c3c218a: Update rendering of policy edit transactions in Applications (authored by epriestley).
Update rendering of policy edit transactions in Applications
Thu, Sep 12, 4:33 PM
epriestley closed D20801: Update rendering of policy edit transactions in Applications.
Thu, Sep 12, 4:32 PM
epriestley committed rPa0ade503e166: Remove "Moved Document from ..." notice in Phriction (authored by epriestley).
Remove "Moved Document from ..." notice in Phriction
Thu, Sep 12, 4:32 PM
epriestley closed D20800: Remove "Moved Document from ..." notice in Phriction.
Thu, Sep 12, 4:32 PM
epriestley requested review of D20807: When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules.
Thu, Sep 12, 4:32 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20807: When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules.
Thu, Sep 12, 4:30 PM · Policy
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details as Resolved.

Here's the fate of the various issues discussed here:

Thu, Sep 12, 4:04 PM · Design, Policy
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details, a subtask of T13411: Improve "Custom Policy" behavior in policy dialogs, as Resolved.
Thu, Sep 12, 4:03 PM · Policy
epriestley requested review of D20806: When users fail a "CAN_SEE" check, give them an "opaque" policy explanation.
Thu, Sep 12, 3:59 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20806: When users fail a "CAN_SEE" check, give them an "opaque" policy explanation.
Thu, Sep 12, 3:57 PM · Policy
epriestley requested review of D20805: Inline custom policy rules inside policy capability explanation dialogs.
Thu, Sep 12, 3:40 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20805: Inline custom policy rules inside policy capability explanation dialogs.
Thu, Sep 12, 3:39 PM · Policy
epriestley added a parent task for T6802: "Custom policy" for editing/viewing does not link to details: T13411: Improve "Custom Policy" behavior in policy dialogs.
Thu, Sep 12, 3:13 PM · Design, Policy
epriestley added a subtask for T13411: Improve "Custom Policy" behavior in policy dialogs: T6802: "Custom policy" for editing/viewing does not link to details.
Thu, Sep 12, 3:13 PM · Policy
epriestley requested review of D20804: Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways.
Thu, Sep 12, 2:48 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20804: Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways.
Thu, Sep 12, 2:46 PM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

This should be reworked some day (perhaps partly here) into some more cohesive API, perhaps newLink().

Thu, Sep 12, 2:15 PM · Policy
epriestley requested review of D20803: Remove unused "icon" parameter from policy name rendering.
Thu, Sep 12, 2:10 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20803: Remove unused "icon" parameter from policy name rendering.
Thu, Sep 12, 2:08 PM · Policy
epriestley requested review of D20802: Remove "Editable By" description fields in Passphrase, Phame, and Spaces.
Thu, Sep 12, 2:07 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20802: Remove "Editable By" description fields in Passphrase, Phame, and Spaces.
Thu, Sep 12, 2:06 PM · Policy
epriestley requested review of D20801: Update rendering of policy edit transactions in Applications.
Thu, Sep 12, 2:04 PM
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: D20801: Update rendering of policy edit transactions in Applications.
Thu, Sep 12, 2:03 PM · Policy
leoluk awarded D20800: Remove "Moved Document from ..." notice in Phriction a Like token.
Thu, Sep 12, 9:50 AM
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

One other thing is that PhabricatorApplicationPolicyChangeTransaction->renderApplicationPolicy() has unconventional behaviors which are not very helpful and not consistent with normal CAN_EDIT / CAN_VIEW transactions. This is somewhat perplexing because ModularTransactions has renderPolicy() already, which has better behavior. I think it didn't exist yet when Applications modularized in D17757, and when it was introduced in D19829 I just overlooked the opportunity to update it.

Thu, Sep 12, 4:47 AM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

In Applications(Pick Something), if an application policy is set to "Custom Policy", the policy is not linked.

Thu, Sep 12, 4:39 AM · Policy
epriestley requested review of D20800: Remove "Moved Document from ..." notice in Phriction.
Thu, Sep 12, 4:06 AM
epriestley added a revision to T13410: Update Phriction UI structural behaviors: D20800: Remove "Moved Document from ..." notice in Phriction.
Thu, Sep 12, 4:04 AM · Phriction

Wed, Sep 11

epriestley added a comment to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior.

I upstreamed this to Chrome here: https://bugs.chromium.org/p/chromium/issues/detail?id=1003002

Wed, Sep 11, 6:00 PM · Google Chrome
epriestley triaged T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior as Normal priority.
Wed, Sep 11, 5:53 PM · Google Chrome
mormegil added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I understand this was supposed to be mentioned here: Herald ignores commits that are ancestors of permanent refs if they were previously pushed to some other non-permanent ref.

Wed, Sep 11, 9:10 AM · Diffusion, Herald

Tue, Sep 10

epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Tue, Sep 10, 10:05 PM · Phriction
epriestley committed rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no… (authored by epriestley).
(stable) Fix global search scope fatal on 404 page (or other pages with no…
Tue, Sep 10, 2:11 PM
20after4 awarded T13377: Write about "how to solve problems with program behavior" a Mountain of Wealth token.
Tue, Sep 10, 1:46 PM · Guides

Mon, Sep 9

epriestley committed rPd2e1c4163a3b: When a project has a custom icon, use that icon to label the project policy in… (authored by epriestley).
When a project has a custom icon, use that icon to label the project policy in…
Mon, Sep 9, 8:38 PM
epriestley closed T8808: Policy menu should show actual project icon next to project as Resolved by committing rPd2e1c4163a3b: When a project has a custom icon, use that icon to label the project policy in….
Mon, Sep 9, 8:38 PM · Policy
epriestley closed D20799: When a project has a custom icon, use that icon to label the project policy in the policy dropown.
Mon, Sep 9, 8:38 PM
epriestley requested review of D20799: When a project has a custom icon, use that icon to label the project policy in the policy dropown.
Mon, Sep 9, 8:37 PM
epriestley added a revision to T8808: Policy menu should show actual project icon next to project: D20799: When a project has a custom icon, use that icon to label the project policy in the policy dropown.
Mon, Sep 9, 8:35 PM · Policy
epriestley committed rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field (authored by epriestley).
Improve rendering of Herald rules in "Another Herald rule..." field
Mon, Sep 9, 8:30 PM
epriestley closed D20798: Improve rendering of Herald rules in "Another Herald rule..." field.
Mon, Sep 9, 8:29 PM
epriestley closed T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule' as Resolved by committing rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field.
Mon, Sep 9, 8:29 PM · Restricted Project, Herald
epriestley requested review of D20798: Improve rendering of Herald rules in "Another Herald rule..." field.
Mon, Sep 9, 8:27 PM
epriestley added a revision to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule': D20798: Improve rendering of Herald rules in "Another Herald rule..." field.
Mon, Sep 9, 8:25 PM · Restricted Project, Herald
epriestley committed rP7593a265d593: When Herald changes object subscribers, always hide the feed story (authored by epriestley).
When Herald changes object subscribers, always hide the feed story
Mon, Sep 9, 8:17 PM
epriestley closed D20797: When Herald changes object subscribers, always hide the feed story.
Mon, Sep 9, 8:17 PM
epriestley closed T8952: Hide "Herald added subscribers..." stories from feed completely as Resolved by committing rP7593a265d593: When Herald changes object subscribers, always hide the feed story.
Mon, Sep 9, 8:17 PM · Feed, Herald
epriestley committed rP454771446306: Add a "Remove flag" action to Herald (authored by epriestley).
Add a "Remove flag" action to Herald
Mon, Sep 9, 8:16 PM
epriestley closed D20796: Add a "Remove flag" action to Herald.
Mon, Sep 9, 8:16 PM
epriestley closed T13409: Support a "Remove Flag" action in Herald as Resolved by committing rP454771446306: Add a "Remove flag" action to Herald.
Mon, Sep 9, 8:16 PM · Herald
epriestley requested review of D20797: When Herald changes object subscribers, always hide the feed story.
Mon, Sep 9, 8:15 PM