Page MenuHomePhabricator
Feed All Stories

Yesterday

tiguchi awarded T7616: Arcanist to be able to access site requiring client side SSL certificate a Like token.
Mon, Jan 27, 9:31 PM · Arcanist, libphutil

Fri, Jan 24

epriestley requested review of D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Fri, Jan 24, 1:17 AM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Fri, Jan 24, 1:16 AM · Projects, Owners, Herald
epriestley committed rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs (authored by epriestley).
Omit "--" in older fallback commands for Git remote URIs
Fri, Jan 24, 12:51 AM
epriestley closed D20952: Omit "--" in older fallback commands for Git remote URIs.
Fri, Jan 24, 12:51 AM
epriestley updated the diff for D20952: Omit "--" in older fallback commands for Git remote URIs.
  • Only omit "--" in "git ls-remote", since it seems like it's okay for even very old "git config".
Fri, Jan 24, 12:50 AM
epriestley requested review of D20952: Omit "--" in older fallback commands for Git remote URIs.
Fri, Jan 24, 12:39 AM
epriestley added a revision to T13481: Don't require "git remote get-url" in Arcanist: D20952: Omit "--" in older fallback commands for Git remote URIs.
Fri, Jan 24, 12:39 AM · Arcanist

Thu, Jan 23

epriestley requested review of D20951: In Herald transcripts, render some field values in a more readable way.
Thu, Jan 23, 11:40 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20951: In Herald transcripts, render some field values in a more readable way.
Thu, Jan 23, 11:38 PM · Projects, Owners, Herald
epriestley committed rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a… (authored by epriestley).
In Git, fall back across versions more cleanly when trying to get the URI for a…
Thu, Jan 23, 11:19 PM
epriestley closed D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.
Thu, Jan 23, 11:19 PM
epriestley closed T13481: Don't require "git remote get-url" in Arcanist as Resolved by committing rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a….
Thu, Jan 23, 11:19 PM · Arcanist
epriestley requested review of D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.
Thu, Jan 23, 11:18 PM
epriestley added a revision to T13481: Don't require "git remote get-url" in Arcanist: D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.
Thu, Jan 23, 11:17 PM · Arcanist
epriestley updated the task description for T13481: Don't require "git remote get-url" in Arcanist.
Thu, Jan 23, 10:12 PM · Arcanist
epriestley triaged T13481: Don't require "git remote get-url" in Arcanist as Wishlist priority.
Thu, Jan 23, 10:09 PM · Arcanist
epriestley requested review of D20949: In Herald transcript rendering, don't store display labels in keys.
Thu, Jan 23, 7:53 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20949: In Herald transcript rendering, don't store display labels in keys.
Thu, Jan 23, 7:51 PM · Projects, Owners, Herald
epriestley requested review of D20948: Remove legacy pre-loading of handles from Herald rendering.
Thu, Jan 23, 7:43 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20948: Remove legacy pre-loading of handles from Herald rendering.
Thu, Jan 23, 7:42 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

Remaining work:

Thu, Jan 23, 2:43 AM · Projects, Owners, Herald
epriestley committed rPb38449ce8f4b: Implement an "Author's packages" Herald field for Differential (authored by epriestley).
Implement an "Author's packages" Herald field for Differential
Thu, Jan 23, 2:28 AM
epriestley closed D20947: Implement an "Author's packages" Herald field for Differential.
Thu, Jan 23, 2:27 AM
epriestley committed rP6c4500046f7c: Add "Project tags added" and "Project tags removed" fields in Herald (authored by epriestley).
Add "Project tags added" and "Project tags removed" fields in Herald
Thu, Jan 23, 2:21 AM
epriestley closed D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Thu, Jan 23, 2:21 AM
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

D20947 does not implement "Author's packages" as a "Commit Content" field, nor as a "Commit Content (Hook)" field. The reason for this is that getting the modern authorPHID in both cases is somewhat complicated.

Thu, Jan 23, 2:20 AM · Projects, Owners, Herald
epriestley requested review of D20947: Implement an "Author's packages" Herald field for Differential.
Thu, Jan 23, 2:19 AM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20947: Implement an "Author's packages" Herald field for Differential.
Thu, Jan 23, 2:17 AM · Projects, Owners, Herald

Tue, Jan 21

epriestley requested review of D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Tue, Jan 21, 7:33 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Tue, Jan 21, 7:31 PM · Projects, Owners, Herald
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

The logic here appears to be that gc.auto is set to some value (by default: 6,700). If the number of loose objects exceeds this threshold (technically, if the number of loose objects in objects/17/ is more than 1/256th of this value), it triggers a repack (in a comment, git repack -d -l).

Tue, Jan 21, 6:00 PM · Phacility, Diffusion
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

See PHI1613, where an install hit this warning (and resolved it by running git prune):

Tue, Jan 21, 5:13 PM · Phacility, Diffusion
epriestley lowered the priority of T13473: Provide full payload logging for inbound CircleCI build requests from Low to Wishlist.

The issue in PHI1605 resolved itself without apparent intervention, presumably as a result of changes on the CircleCI side. I can't find any release notes to shed any light on things, but this is no longer time-sensitive.

Tue, Jan 21, 5:12 PM · Infrastructure

Fri, Jan 17

epriestley renamed T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones from Fix various policy issues issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones to Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.
Fri, Jan 17, 5:19 PM · Policy, Projects
epriestley triaged T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Wishlist priority.
Fri, Jan 17, 5:05 PM · Projects, Owners, Herald
epriestley added a comment to T13395: Strip libphutil for parts.

See also https://discourse.phabricator-community.org/t/storage-upgrade-failed-class-phutilauthadapter-not-defined/3468.

Fri, Jan 17, 4:55 PM · libphutil

Thu, Jan 16

epriestley committed rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0 (authored by epriestley).
Update "git rev-parse" invocation to work in Git 2.25.0
Thu, Jan 16, 7:39 PM
epriestley closed D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:39 PM
epriestley closed T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Resolved by committing rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:39 PM · Diffusion
epriestley requested review of D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:38 PM
epriestley added a revision to T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0: D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:37 PM · Diffusion
epriestley triaged T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Low priority.
Thu, Jan 16, 7:18 PM · Diffusion
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

See T13478 for followup.

Thu, Jan 16, 6:50 PM · Restricted Project, Projects, Bug Report
epriestley triaged T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones as Low priority.
Thu, Jan 16, 6:49 PM · Policy, Projects
epriestley reopened T10779: Cannot manage base project milestones if base project has subprojects as "Open".

I'm also still able to reproduce this specific variant of things, so it looks like I was too optimistic about T13462 covering this in at least some cases.

Thu, Jan 16, 4:50 PM · Restricted Project, Projects, Bug Report

Wed, Jan 15

epriestley committed rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other… (authored by epriestley).
Fix two issues with missing whitespace when elements stack on top of each other…
Wed, Jan 15, 4:53 PM
epriestley closed D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Wed, Jan 15, 4:53 PM
epriestley closed T13476: Correct vertical spacing issues when some components wrap across a line break as Resolved by committing rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other….
Wed, Jan 15, 4:53 PM · Design
epriestley requested review of D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Wed, Jan 15, 4:49 PM
epriestley added a revision to T13476: Correct vertical spacing issues when some components wrap across a line break: D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Wed, Jan 15, 4:48 PM · Design
epriestley added a comment to T13476: Correct vertical spacing issues when some components wrap across a line break.

A similar issue occurs when the "Visible To" control wraps with spaces enabled. To reproduce this...

Wed, Jan 15, 4:46 PM · Design
epriestley added a comment to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.

This should be fixed by D20943. Note that "Mute" in this context mutes notifications about edits to the object (e.g. "Alice renamed rule Hxxx from X to Y."), not notifications sent by the rule itself.

Wed, Jan 15, 4:31 PM · Herald
epriestley committed rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions (authored by epriestley).
Allow the Herald Rule Editor to apply generic "Edge" transactions
Wed, Jan 15, 4:29 PM
epriestley closed D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:29 PM
epriestley closed T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Resolved by committing rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:29 PM · Herald
epriestley requested review of D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:29 PM
epriestley added a revision to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`: D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:27 PM · Herald
epriestley triaged T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Wishlist priority.
Wed, Jan 15, 4:23 PM · Herald
epriestley closed T13477: (2020 Week 3) Restart AWS host db025 (i-05bc80634586ef7a0) as Resolved.

This went through cleanly.

Wed, Jan 15, 4:19 PM · Ops, Phacility
epriestley closed T13453: Update Asana Auth Adapter for "gid" API changes as Resolved.

These changes seem to have stuck.

Wed, Jan 15, 2:40 AM · Asana, Auth
epriestley triaged T13477: (2020 Week 3) Restart AWS host db025 (i-05bc80634586ef7a0) as Low priority.
Wed, Jan 15, 2:36 AM · Ops, Phacility
epriestley triaged T13476: Correct vertical spacing issues when some components wrap across a line break as Low priority.
Wed, Jan 15, 2:34 AM · Design
epriestley triaged T13475: Fix incorrect MFA badge on some stories when MFA is not configured at all as Low priority.
Wed, Jan 15, 2:28 AM · Auth

Tue, Jan 14

epriestley committed rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning (authored by epriestley).
Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning
Tue, Jan 14, 8:23 PM
epriestley closed D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:23 PM
epriestley closed T13471: Guard call to "get_magic_quotes_gpc()" during startup as Resolved by committing rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:23 PM · Infrastructure
epriestley requested review of D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:22 PM
epriestley added a revision to T13471: Guard call to "get_magic_quotes_gpc()" during startup: D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:21 PM · Infrastructure
epriestley committed rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer (authored by epriestley).
Update deprecated array access syntax in Porter stemmer
Tue, Jan 14, 8:11 PM
epriestley closed D20941: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:11 PM
epriestley closed T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Resolved by committing rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:11 PM · Search
epriestley requested review of D20941: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:11 PM
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20941: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:04 PM · Search
epriestley added a comment to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4.

I thought this was some kind of complicated mess with the regex on line 420, but it's actually an issue with this:

Tue, Jan 14, 8:03 PM · Search
epriestley committed rP767528c0ed55: Move search query parser/compiler classes to Phabricator (authored by epriestley).
Move search query parser/compiler classes to Phabricator
Tue, Jan 14, 7:50 PM
epriestley closed D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:49 PM
epriestley committed rPHUcc2a3dbf5903: Move search query compiler / stemmer classes out of libphutil (authored by epriestley).
Move search query compiler / stemmer classes out of libphutil
Tue, Jan 14, 7:49 PM
epriestley closed D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:49 PM
epriestley requested review of D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:49 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:48 PM · libphutil
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:48 PM · Search
epriestley updated the diff for D20939: Move search query parser/compiler classes to Phabricator.
  • Also move the Porter stemmer.
  • Ran some search queries.
Tue, Jan 14, 7:47 PM
epriestley requested review of D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:42 PM
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:41 PM · Search
epriestley added a revision to T13395: Strip libphutil for parts: D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:41 PM · libphutil
epriestley added a comment to T13474: Track mentions on an individual field-by-field basis.

(Since a full implementation here will imply that removing a custom field from configuration may "unmention" an arbitrarily large number of relationships, and we can't easily do that inline or at display time, the ultimately implementation would likely include a more robust version of this script.)

Tue, Jan 14, 7:21 PM · Infrastructure
epriestley added a comment to T13474: Track mentions on an individual field-by-field basis.

In PHI1602, I proposed a script to "reset" mentions on an object. The use case this serves is:

Tue, Jan 14, 7:13 PM · Infrastructure
epriestley triaged T13474: Track mentions on an individual field-by-field basis as Wishlist priority.
Tue, Jan 14, 6:32 PM · Infrastructure
epriestley triaged T13473: Provide full payload logging for inbound CircleCI build requests as Low priority.
Tue, Jan 14, 6:17 PM · Infrastructure
epriestley accepted D20938: breakout: migrate to python3.

If systems with no binary named python are reasonable to expect, and it sounds like they are, this is fine as-is. I've added you to Blessed Committers so you should be able to land this change yourself (check the project description for some guidance), or let me know if you run into issues. After this lands, I'll land a followup in arc anoid to test for a python3 and emit a friendlier error if it isn't present.

Tue, Jan 14, 4:35 PM
epriestley added a member for Blessed Committers: beber.
Tue, Jan 14, 4:35 PM
artms added a comment to T5422: Does Phabricator integrate with JIRA?.

In jira 8.6.1 settings are now in:

  • AdministrationApplicationsApplication links
Tue, Jan 14, 3:31 PM · Guides, Doorkeeper
leoluk added a comment to D20938: breakout: migrate to python3.

It's possible (and common) to write code that is both valid Python 2 and 3, like in this case.

Tue, Jan 14, 3:26 PM

Mon, Jan 13

epriestley added a comment to T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/.

This page intentionally has a no-Javascript, no-drag-and-drop upload form for users who use obscure Linux window managers that don't support drag and drop.

Mon, Jan 13, 7:32 PM
epriestley merged task T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Mon, Jan 13, 7:26 PM
epriestley merged T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Mon, Jan 13, 7:26 PM · Files
epriestley requested changes to D20938: breakout: migrate to python3.

This is almost certainly fine, but I don't actually have this bleeding-edge far-future version of Python installed on my stock Macbook (macOS Mojave):

Mon, Jan 13, 6:29 PM
epriestley added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

If you believe you've found a bug in Phabricator, please report it by creating a new thread on Discourse.

Mon, Jan 13, 6:23 PM · Projects, Bug Report (Needs Information)
epriestley triaged T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Wishlist priority.
Mon, Jan 13, 4:49 PM · Search