Page MenuHomePhabricator
Feed All Stories

Yesterday

epriestley edited the content of Changelog.
Sat, Aug 8, 2:39 AM
epriestley committed rP5e3768473711: (stable) Promote 2020 Week 31 (authored by epriestley).
(stable) Promote 2020 Week 31
Sat, Aug 8, 2:38 AM
epriestley created an object: 2020 Week 31 (Early August).
Sat, Aug 8, 2:38 AM

Wed, Aug 5

epriestley committed rPce0dc9a2ba2c: Correct an apparent off-by-one error when adjusting inlines across revision… (authored by epriestley).
Correct an apparent off-by-one error when adjusting inlines across revision…
Wed, Aug 5, 8:13 PM
epriestley committed rPdbdfac1e072e: Recover inline comments which are "adjusted" off the end of a diff (authored by epriestley).
Recover inline comments which are "adjusted" off the end of a diff
Wed, Aug 5, 8:13 PM
epriestley closed D21436: Correct an apparent off-by-one error when adjusting inlines across revision changes.
Wed, Aug 5, 8:12 PM
epriestley closed D21435: Recover inline comments which are "adjusted" off the end of a diff.
Wed, Aug 5, 8:12 PM
epriestley requested review of D21436: Correct an apparent off-by-one error when adjusting inlines across revision changes.
Wed, Aug 5, 8:11 PM
epriestley requested review of D21435: Recover inline comments which are "adjusted" off the end of a diff.
Wed, Aug 5, 8:01 PM
epriestley committed rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or… (authored by epriestley).
In Jupyter notebooks, read strings stored in the raw as either "string" or…
Wed, Aug 5, 7:26 PM
epriestley closed D21434: In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently.
Wed, Aug 5, 7:26 PM
epriestley updated the task description for T13241: Guide: SMS is Insecure.
Wed, Aug 5, 7:22 PM · Security, Guides
epriestley requested review of D21434: In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently.
Wed, Aug 5, 7:20 PM
epriestley added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

With newer inline comment functionality there is no ability to create submitted inline comments for bots or via API directly.

Wed, Aug 5, 6:59 PM
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.

Wed, Aug 5, 6:55 PM
epriestley committed rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines (authored by epriestley).
In 1-up source diffs, retain the "No newline at end of file" on "\" lines
Wed, Aug 5, 5:17 PM
epriestley closed D21433: In 1-up source diffs, retain the "No newline at end of file" on "\" lines.
Wed, Aug 5, 5:17 PM
epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
Wed, Aug 5, 5:07 PM · Differential
epriestley requested review of D21433: In 1-up source diffs, retain the "No newline at end of file" on "\" lines.
Wed, Aug 5, 4:50 PM
epriestley added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.

Wed, Aug 5, 3:51 PM
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

What is not programmatical way to "submit" unsubmitted inline comments? Some users are using it to post comments from bots, now if we use differential.createinline api method all bot comments are visible as unsubmitted and looks like there is no way to set it in stone...

Wed, Aug 5, 11:39 AM

Sun, Aug 2

Harbormaster failed to build B24817: rP287b7485a68a: (stable) Move "Wait for Previous Commits to Build" out of prototype for rP287b7485a68a: (stable) Move "Wait for Previous Commits to Build" out of prototype!
Sun, Aug 2, 2:56 AM
epriestley committed rP287b7485a68a: (stable) Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
(stable) Move "Wait for Previous Commits to Build" out of prototype
Sun, Aug 2, 2:55 AM

Thu, Jul 30

jg added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.

lotsofthumbsup

Thu, Jul 30, 7:56 PM
epriestley added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.

See PHI1833.

Thu, Jul 30, 7:50 PM
epriestley committed rPc1eeacd8500b: Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
Move "Wait for Previous Commits to Build" out of prototype
Thu, Jul 30, 7:46 PM
epriestley closed D21432: Move "Wait for Previous Commits to Build" out of prototype.
Thu, Jul 30, 7:46 PM
epriestley requested review of D21432: Move "Wait for Previous Commits to Build" out of prototype.
Thu, Jul 30, 7:45 PM

Tue, Jul 28

epriestley requested review of D21431: Improve handle/status list display on devices in commit graph lists.
Tue, Jul 28, 6:16 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21431: Improve handle/status list display on devices in commit graph lists.
Tue, Jul 28, 6:15 PM · Differential
epriestley requested review of D21430: Improve commit action item layout on mobile.
Tue, Jul 28, 5:11 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21430: Improve commit action item layout on mobile.
Tue, Jul 28, 5:08 PM · Differential

Mon, Jul 27

epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Mon, Jul 27, 6:06 PM · Guides, Arcanist

Sat, Jul 25

epriestley edited the content of Changelog.
Sat, Jul 25, 3:26 PM
epriestley committed rARCccd39feb6d3b: (stable) Promote 2020 Week 29 (authored by epriestley).
(stable) Promote 2020 Week 29
Sat, Jul 25, 3:25 PM
epriestley committed rP1b54f45c4c47: (stable) Promote 2020 Week 29 (authored by epriestley).
(stable) Promote 2020 Week 29
Sat, Jul 25, 3:25 PM
epriestley created an object: 2020 Week 29 (Late July).
Sat, Jul 25, 3:25 PM
avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.

related to T3278, probably?

Sat, Jul 25, 10:57 AM · Typeahead, Feature Request

Fri, Jul 24

epriestley committed rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior (authored by epriestley).
Revert use of "user-select: all" to modify tab selection behavior
Fri, Jul 24, 8:41 PM
epriestley added a reverting change for D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior: rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior.
Fri, Jul 24, 8:41 PM
epriestley closed D21429: Revert use of "user-select: all" to modify tab selection behavior.
Fri, Jul 24, 8:41 PM
epriestley requested review of D21429: Revert use of "user-select: all" to modify tab selection behavior.
Fri, Jul 24, 8:41 PM
epriestley added a comment to D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.

I reverted this in D21429, since it also makes these sequences select with a single click.

Fri, Jul 24, 8:40 PM
epriestley added a reverting change for D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior: D21429: Revert use of "user-select: all" to modify tab selection behavior.
Fri, Jul 24, 8:40 PM
epriestley added a comment to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.

In D21426, I removed phd.trace and phd.verbose.

Fri, Jul 24, 12:18 AM · Daemons

Thu, Jul 23

epriestley committed rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options (authored by epriestley).
Remove ancient "phd.trace" and "phd.verbose" configuration options
Thu, Jul 23, 7:31 PM
epriestley closed D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
Thu, Jul 23, 7:31 PM
epriestley updated the diff for D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
  • Include "obsolete config" setup checks.
Thu, Jul 23, 7:28 PM
epriestley requested review of D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
Thu, Jul 23, 7:23 PM
epriestley added a revision to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes: D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
Thu, Jul 23, 7:22 PM · Daemons
epriestley committed rP78d1b62bb8e9: Streamline handling of Futures and PIDs in daemons (authored by epriestley).
Streamline handling of Futures and PIDs in daemons
Thu, Jul 23, 6:22 PM
epriestley committed rP5f0535934d72: Manage PIDs more carefully in DaemonHandle (authored by epriestley).
Manage PIDs more carefully in DaemonHandle
Thu, Jul 23, 6:22 PM
epriestley closed D21424: Manage PIDs more carefully in DaemonHandle.
Thu, Jul 23, 6:22 PM
epriestley closed D21425: Streamline handling of Futures and PIDs in daemons.
Thu, Jul 23, 6:22 PM
epriestley committed rARCceb082ef6b29: Give Futures clearer start/end and exception semantics (authored by epriestley).
Give Futures clearer start/end and exception semantics
Thu, Jul 23, 6:22 PM
epriestley closed D21423: Give Futures clearer start/end and exception semantics.
Thu, Jul 23, 6:22 PM
epriestley claimed T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.
Thu, Jul 23, 6:05 PM · Daemons
epriestley triaged T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes as Wishlist priority.
Thu, Jul 23, 6:05 PM · Daemons
epriestley updated the diff for D21425: Streamline handling of Futures and PIDs in daemons.
  • Use "$caught", not "$ex", to make the code less fragile.
Thu, Jul 23, 5:42 PM
epriestley requested review of D21425: Streamline handling of Futures and PIDs in daemons.
Thu, Jul 23, 5:41 PM
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: D21425: Streamline handling of Futures and PIDs in daemons.
Thu, Jul 23, 5:40 PM · Daemons
epriestley updated the diff for D21423: Give Futures clearer start/end and exception semantics.
  • Add "ExecFuture->hasPID()" to simplify reading PID information.
Thu, Jul 23, 5:17 PM
epriestley added a comment to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall.

The call sequence here is approximately:

Thu, Jul 23, 5:11 PM · Daemons
epriestley requested review of D21424: Manage PIDs more carefully in DaemonHandle.
Thu, Jul 23, 5:10 PM
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: D21424: Manage PIDs more carefully in DaemonHandle.
Thu, Jul 23, 5:09 PM · Daemons
epriestley requested review of D21423: Give Futures clearer start/end and exception semantics.
Thu, Jul 23, 5:08 PM
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: D21423: Give Futures clearer start/end and exception semantics.
Thu, Jul 23, 5:07 PM · Daemons
epriestley triaged T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall as Normal priority.
Thu, Jul 23, 2:58 PM · Daemons
epriestley committed rPfcb75d0503c6: Fix an issue where prose diffing may fail after hitting the PCRE backtracking… (authored by epriestley).
Fix an issue where prose diffing may fail after hitting the PCRE backtracking…
Thu, Jul 23, 2:46 PM
epriestley closed D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit.
Thu, Jul 23, 2:46 PM
epriestley closed T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Resolved by committing rPfcb75d0503c6: Fix an issue where prose diffing may fail after hitting the PCRE backtracking….
Thu, Jul 23, 2:46 PM · Infrastructure
epriestley requested review of D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit.
Thu, Jul 23, 2:41 PM
epriestley added a revision to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()": D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit.
Thu, Jul 23, 2:40 PM · Infrastructure
epriestley added a comment to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()".

This is a PCRE backtracking issue. It reproduces on an input corpus of length 3,277 bytes with only "x", " " (space), and "\n" (newline) characters, and disappears if I increase pcre.backtrack_limit.

Thu, Jul 23, 2:36 PM · Infrastructure
epriestley triaged T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Low priority.
Thu, Jul 23, 1:41 PM · Infrastructure

Wed, Jul 22

epriestley added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

Please use Discourse to discuss Phabricator.

Wed, Jul 22, 11:49 PM · Arcanist, Guides
jbrownEP added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

This task references more details on "Excuses" and "Prompts", but there isn't any. Is there any way to provide context around lint issues?

Wed, Jul 22, 11:46 PM · Arcanist, Guides
epriestley committed rP324445589b5e: (stable) Fix an issue with destruction of Revision and Diff objects with… (authored by epriestley).
(stable) Fix an issue with destruction of Revision and Diff objects with…
Wed, Jul 22, 8:20 PM
epriestley committed rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates (authored by epriestley).
Fix an issue with destruction of Revision and Diff objects with viewstates
Wed, Jul 22, 8:07 PM
epriestley closed D21421: Fix an issue with destruction of Revision and Diff objects with viewstates.
Wed, Jul 22, 8:07 PM
epriestley requested review of D21421: Fix an issue with destruction of Revision and Diff objects with viewstates.
Wed, Jul 22, 6:56 PM
epriestley added a comment to D21041: Use a named remote and branches for staging to help git-lfs.

If you believe you've found a bug in Phabricator, please report it on Discourse, including complete reproduction instructions.

Wed, Jul 22, 2:07 AM
maroux added inline comments to D21041: Use a named remote and branches for staging to help git-lfs.
Wed, Jul 22, 1:03 AM

Tue, Jul 21

ipalencar updated ipalencar.
Tue, Jul 21, 6:42 PM
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Tue, Jul 21, 6:24 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Tue, Jul 21, 6:24 PM · Guides, Arcanist
epriestley triaged T13553: Creating a milestone via the API fails when accessing the project's parent as Normal priority.
Tue, Jul 21, 5:54 PM · Transactions, Projects

Mon, Jul 20

epriestley removed a member for Phacility Core Access: amckinley.
Mon, Jul 20, 5:23 PM
epriestley removed a member for Phacility: amckinley.
Mon, Jul 20, 5:23 PM
epriestley defrocked amckinley.
Mon, Jul 20, 5:23 PM

Sat, Jul 18

epriestley committed rPd32c3f8d7d65: (stable) Likely, fix a warning when rendering modified coverage (authored by epriestley).
(stable) Likely, fix a warning when rendering modified coverage
Sat, Jul 18, 2:45 AM
epriestley committed rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage (authored by epriestley).
Likely, fix a warning when rendering modified coverage
Sat, Jul 18, 2:45 AM
epriestley closed D21420: Likely, fix a warning when rendering modified coverage.
Sat, Jul 18, 2:45 AM
epriestley requested review of D21420: Likely, fix a warning when rendering modified coverage.
Sat, Jul 18, 2:45 AM

Fri, Jul 17

epriestley committed rP37ffb71c4d5e: In source views, wrap display tabs in "user-select: all" to improve cursor… (authored by epriestley).
In source views, wrap display tabs in "user-select: all" to improve cursor…
Fri, Jul 17, 10:10 PM
epriestley closed D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Fri, Jul 17, 10:10 PM
epriestley requested review of D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Fri, Jul 17, 10:08 PM
epriestley added a revision to T2495: Improve whitespace expansion of tab literals: D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Fri, Jul 17, 10:07 PM · Restricted Project, FreeBSD, Diffusion, Differential

Thu, Jul 16

epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)

Thu, Jul 16, 3:11 PM · Harbormaster
Kwisatz added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Is this really a harbormaster problem though? I would have located it within Differential.

Thu, Jul 16, 12:49 PM · Harbormaster