Page MenuHomePhabricator
Feed All Stories

Today

amckinley accepted D20674: Provide a basic detail view for user activity logs.
Wed, Jul 24, 2:18 AM
amckinley accepted D20671: Modularize user activity log message types.
Wed, Jul 24, 2:17 AM
amckinley accepted D20678: Contain fallout from overheating feed queries on user profile pages.
Wed, Jul 24, 2:14 AM

Yesterday

epriestley requested review of D20678: Contain fallout from overheating feed queries on user profile pages.
Tue, Jul 23, 11:04 PM
epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20678: Contain fallout from overheating feed queries on user profile pages.
Tue, Jul 23, 11:03 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

To reproduce this easily:

Tue, Jul 23, 10:57 PM · Feed
epriestley triaged T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Low priority.
Tue, Jul 23, 10:47 PM · Feed
epriestley abandoned D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".

I'm likely going to propose some variation of this change, but focus it on max_allowed_packet and on emphasizing that there are two different copies of this setting with different error/failure behavior.

Tue, Jul 23, 1:24 PM
epriestley triaged T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Normal priority.
Tue, Jul 23, 1:18 PM · Harbormaster
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

We could also consider these things:

Tue, Jul 23, 1:10 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

So actual actionable stuff here is:

Tue, Jul 23, 1:04 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?) to During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
Tue, Jul 23, 12:59 PM · Ops, Restricted Project, Phacility
artms committed rPcd449254256d: Allow users with no CAN_EDIT permissions to silence projects if they want to (authored by artms).
Allow users with no CAN_EDIT permissions to silence projects if they want to
Tue, Jul 23, 10:14 AM
artms closed D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Tue, Jul 23, 10:14 AM
Herald updated subscribers of T3980: Support "Bind to External Thing" to define project membership.
Tue, Jul 23, 2:26 AM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects

Mon, Jul 22

epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Bumping max_allowed_packet to 1G in the server config resolved things. The export process then spent a long time doing a bin/files migration (which could use a progress bar, maybe) and is now doing a dump (which could too, although I'm less sure of how we'd build one).

Mon, Jul 22, 11:52 PM · Ops, Restricted Project, Phacility
amckinley accepted D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Mon, Jul 22, 11:00 PM
amckinley accepted D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Mon, Jul 22, 10:59 PM
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
190722 18:55:55 [Warning] Aborted connection 6 to db: '<instance>_differential' user: 'root' host: 'localhost' (Got a packet bigger than 'max_allowed_packet' bytes)
Mon, Jul 22, 6:59 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I adjusted innodb_log_file_size to 1GB and attempted the import again, but ran into the same issue.

Mon, Jul 22, 6:16 PM · Ops, Restricted Project, Phacility
epriestley planned changes to D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".

Let me hold this until I'm more confident I'm on the right track.

Mon, Jul 22, 6:16 PM
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?).
Mon, Jul 22, 6:13 PM · Ops, Restricted Project, Phacility
epriestley added inline comments to D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Mon, Jul 22, 5:08 PM
epriestley updated the summary of D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Mon, Jul 22, 5:07 PM
epriestley requested review of D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Mon, Jul 22, 5:06 PM
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Mon, Jul 22, 5:05 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Mon, Jul 22, 4:38 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "go away" on large dumps? to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size".
Mon, Jul 22, 4:27 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

The "age of the last checkpoint" error appears to primarily implicate innodb_log_file_size, which is currently set to the default value (5MB):

Mon, Jul 22, 4:26 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I'll also double check wait_timeout and interactive_timeout...

Mon, Jul 22, 4:01 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Aha! The MySQL error log actually appears to have something useful:

Mon, Jul 22, 3:55 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Run it with source ...;

Mon, Jul 22, 3:54 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Unzip the dump before running it.

Mon, Jul 22, 3:45 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Look at the unzipped dump and see if line 13935 is bad in some obvious way.

Mon, Jul 22, 3:40 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Whatever the resolution is here might also motivate tailoring our restore/import instructions, since this error is pretty opaque and the next steps aren't obvious.)

Mon, Jul 22, 3:21 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Internally, see also PHI1329.)

Mon, Jul 22, 3:18 PM · Ops, Restricted Project, Phacility
epriestley triaged T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting as Low priority.
Mon, Jul 22, 3:18 PM · Ops, Restricted Project, Phacility
epriestley accepted D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Mon, Jul 22, 2:13 PM
artms requested review of D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Mon, Jul 22, 11:09 AM

Sat, Jul 20

Krinkle awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Orange Medal token.
Sat, Jul 20, 7:07 PM · Auth
Krinkle added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

See also https://trac.wildfiregames.com/wiki/Phabricator#Downloadapatch where a tedious workaround is needed in order to apply patches to a mirror of an SVN repo that is updated once a day:

Sat, Jul 20, 5:51 PM · Restricted Project, Arcanist

Fri, Jul 19

aklapper awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Love token.
Fri, Jul 19, 11:07 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Not all of this has landed yet, but once it does:

Fri, Jul 19, 10:55 PM · Auth
epriestley committed rP4fd473e7eda6: Remove explicit administrative actions from the user activity log (authored by epriestley).
Remove explicit administrative actions from the user activity log
Fri, Jul 19, 10:46 PM
epriestley closed D20670: Remove explicit administrative actions from the user activity log.
Fri, Jul 19, 10:46 PM
epriestley committed rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()" (authored by epriestley).
Simplify implementation of "SysetemAction->getSystemActionConstant()"
Fri, Jul 19, 10:45 PM
epriestley closed D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".
Fri, Jul 19, 10:45 PM
epriestley committed rPa75766c0e501: Replace old rate limiting in password login flow with "SystemAction" rate… (authored by epriestley).
Replace old rate limiting in password login flow with "SystemAction" rate…
Fri, Jul 19, 10:45 PM
epriestley closed D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Fri, Jul 19, 10:45 PM
epriestley committed rPe090b32c7528: Add a rate limit to requesting account recovery links from a given remote… (authored by epriestley).
Add a rate limit to requesting account recovery links from a given remote…
Fri, Jul 19, 10:43 PM
epriestley closed D20667: Add a rate limit to requesting account recovery links from a given remote address.
Fri, Jul 19, 10:43 PM
epriestley committed rP80294e7a4ad1: Add a rate limit to generating new account recovery links for a given account (authored by epriestley).
Add a rate limit to generating new account recovery links for a given account
Fri, Jul 19, 10:42 PM
epriestley closed D20666: Add a rate limit to generating new account recovery links for a given account.
Fri, Jul 19, 10:42 PM
epriestley committed rPced416cc735a: Allow Auth messages to have detailed descriptions and default values, then give… (authored by epriestley).
Allow Auth messages to have detailed descriptions and default values, then give…
Fri, Jul 19, 10:39 PM
epriestley closed D20665: Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both.
Fri, Jul 19, 10:39 PM
Harbormaster failed to build B23170: rPa0c9f9f90c81: Allow installs to customize mail body guidance in the "Email Login" and "Set… for rPa0c9f9f90c81: Allow installs to customize mail body guidance in the "Email Login" and "Set…!
Fri, Jul 19, 10:39 PM
epriestley committed rP38d30af362e6: Give "Auth Messages" a view/detail state before users customize them (authored by epriestley).
Give "Auth Messages" a view/detail state before users customize them
Fri, Jul 19, 10:39 PM
epriestley closed D20664: Give "Auth Messages" a view/detail state before users customize them.
Fri, Jul 19, 10:38 PM
epriestley committed rPa0c9f9f90c81: Allow installs to customize mail body guidance in the "Email Login" and "Set… (authored by epriestley).
Allow installs to customize mail body guidance in the "Email Login" and "Set…
Fri, Jul 19, 10:37 PM
epriestley closed D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.
Fri, Jul 19, 10:37 PM
epriestley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

(Noted in T13346 before I land this and we forget about it.)

Fri, Jul 19, 10:37 PM
epriestley triaged T13346: Make "bin/auth lock" also lock "Customize Messages" in Auth as Low priority.
Fri, Jul 19, 10:36 PM · Auth
epriestley requested review of D20674: Provide a basic detail view for user activity logs.
Fri, Jul 19, 10:32 PM
epriestley committed rP5dd489500155: Move "Password Reset" email to "PeopleMailEngine" (authored by epriestley).
Move "Password Reset" email to "PeopleMailEngine"
Fri, Jul 19, 10:30 PM
epriestley closed D20662: Move "Password Reset" email to "PeopleMailEngine".
Fri, Jul 19, 10:30 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20674: Provide a basic detail view for user activity logs.
Fri, Jul 19, 10:30 PM · Auth
epriestley requested review of D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Fri, Jul 19, 10:07 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Fri, Jul 19, 10:05 PM · Auth
epriestley requested review of D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Fri, Jul 19, 9:53 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Fri, Jul 19, 9:51 PM · Auth
amckinley accepted D20670: Remove explicit administrative actions from the user activity log.
Fri, Jul 19, 9:45 PM
amckinley accepted D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".
Fri, Jul 19, 9:44 PM
epriestley requested review of D20671: Modularize user activity log message types.
Fri, Jul 19, 9:43 PM
amckinley accepted D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Fri, Jul 19, 9:43 PM
amckinley accepted D20667: Add a rate limit to requesting account recovery links from a given remote address.
Fri, Jul 19, 9:42 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20671: Modularize user activity log message types.
Fri, Jul 19, 9:41 PM · Auth
amckinley accepted D20666: Add a rate limit to generating new account recovery links for a given account.
Fri, Jul 19, 9:41 PM
amckinley accepted D20665: Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both.
Fri, Jul 19, 9:40 PM
epriestley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

I can do that since I was just fiddling around in there.

Fri, Jul 19, 9:15 PM
amckinley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

Yeah -- I lean toward thinking that we probably should make bin/auth lock also lock the guidance messages too.

Fri, Jul 19, 9:02 PM
amckinley accepted D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.
Fri, Jul 19, 8:46 PM
epriestley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

Yeah -- I lean toward thinking that we probably should make bin/auth lock also lock the guidance messages too. This class of attack feels like a bit of a stretch since no one reads instructions anyway, but letting an attacker replace the login screen with This page has moved temporarily, click [[ here ]] to go to the new login page. and then 9,000 newlines to push all the actual login controls off the page is at least sort of plausible-attack-flavored.

Fri, Jul 19, 8:45 PM
amckinley accepted D20664: Give "Auth Messages" a view/detail state before users customize them.
Fri, Jul 19, 8:24 PM
amckinley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

Are we worried about attackers changing the guidance to something like "To prove that your Phabricator account is in use, please email the following link to bob.hackerman@gmail.com and don't read the rest of this email"?

Fri, Jul 19, 8:20 PM
amckinley accepted D20662: Move "Password Reset" email to "PeopleMailEngine".
Fri, Jul 19, 8:00 PM
epriestley requested review of D20670: Remove explicit administrative actions from the user activity log.
Fri, Jul 19, 6:18 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20670: Remove explicit administrative actions from the user activity log.
Fri, Jul 19, 6:17 PM · Auth
epriestley requested review of D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".
Fri, Jul 19, 5:29 PM
epriestley added inline comments to D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Fri, Jul 19, 5:28 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".
Fri, Jul 19, 5:27 PM · Auth
epriestley requested review of D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Fri, Jul 19, 5:22 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Fri, Jul 19, 5:21 PM · Auth
epriestley requested review of D20667: Add a rate limit to requesting account recovery links from a given remote address.
Fri, Jul 19, 5:04 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20667: Add a rate limit to requesting account recovery links from a given remote address.
Fri, Jul 19, 5:02 PM · Auth
epriestley requested review of D20666: Add a rate limit to generating new account recovery links for a given account.
Fri, Jul 19, 4:44 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20666: Add a rate limit to generating new account recovery links for a given account.
Fri, Jul 19, 4:42 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

It may be useful to provide helper methods to support normalizing these actor types (e.g., email addresses should be case-insensitive).

Fri, Jul 19, 4:34 PM · Auth
epriestley requested review of D20665: Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both.
Fri, Jul 19, 4:29 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20665: Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both.
Fri, Jul 19, 4:28 PM · Auth
epriestley updated the diff for D20664: Give "Auth Messages" a view/detail state before users customize them.
  • Correct "messags".
Fri, Jul 19, 4:04 PM