Page MenuHomePhabricator
Feed All Stories

Yesterday

amckinley accepted D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Mon, Mar 18, 11:14 PM
amckinley accepted D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Mon, Mar 18, 11:13 PM
epriestley requested review of D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Mon, Mar 18, 11:09 PM
epriestley added a revision to T13091: Ferret "Relevance" order does not always have all the columns it needs available: D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Mon, Mar 18, 11:07 PM · Search
epriestley requested review of D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Mon, Mar 18, 10:53 PM
epriestley added a revision to T13091: Ferret "Relevance" order does not always have all the columns it needs available: D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Mon, Mar 18, 10:52 PM · Search
amckinley accepted D20293: Convert complex query subclasses to use internal cursors.

I got the gist of this, but the Maniphest stuff is pretty black magic. I'll trust in your test plan.

Mon, Mar 18, 10:28 PM
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

I also checked for more leftovers in instances/, but it looks like we don't have any non-default paging there.

Mon, Mar 18, 10:23 PM · Diffusion
epriestley added a commit to T11413: Support renaming Phacility instances: Unknown Object (Diffusion Commit).
Mon, Mar 18, 10:21 PM · Phacility
epriestley committed rPa6fd8f04792d: When performing complex edits, pause sub-editors before they publish to… (authored by epriestley).
When performing complex edits, pause sub-editors before they publish to…
Mon, Mar 18, 10:21 PM
epriestley closed D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.
Mon, Mar 18, 10:20 PM
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

I've poked around a fair bit locally, although I'm not totally confident I got every combination of paging columns and queries. I think anything that was missed is very likely to produce an explicit error rather than mysterious behavior, so I'm not too worried about it. Stuff to keep an eye on:

Mon, Mar 18, 10:12 PM · Diffusion
epriestley added inline comments to D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 10:04 PM
amckinley accepted D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 10:01 PM
amckinley accepted D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Mon, Mar 18, 9:56 PM
amckinley accepted D20294: When queries overheat, raise an exception.
Mon, Mar 18, 9:56 PM
epriestley requested review of D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Mon, Mar 18, 9:53 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Mon, Mar 18, 9:52 PM · Diffusion
amckinley accepted D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.
Mon, Mar 18, 9:51 PM
epriestley requested review of D20294: When queries overheat, raise an exception.
Mon, Mar 18, 9:42 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20294: When queries overheat, raise an exception.
Mon, Mar 18, 9:40 PM · Diffusion
epriestley added inline comments to D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:13 PM
epriestley added inline comments to D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:12 PM
epriestley requested review of D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:06 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:04 PM · Diffusion
epriestley added a child revision for D20292: Convert simple query subclasses to use internal cursors: D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:04 PM
epriestley claimed T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
Mon, Mar 18, 9:02 PM · Diffusion
epriestley added inline comments to D20288: Hard code a "close task" action on every column Trigger.
Mon, Mar 18, 8:00 PM
epriestley added inline comments to D20287: Allow triggers to be attached to and removed from workboard columns.
Mon, Mar 18, 7:50 PM
amckinley accepted D20288: Hard code a "close task" action on every column Trigger.
Mon, Mar 18, 7:39 PM
amckinley accepted D20287: Allow triggers to be attached to and removed from workboard columns.
Mon, Mar 18, 7:14 PM
epriestley requested review of D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 7:03 PM
epriestley updated the diff for D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.
  • Farewell, Herlad.
Mon, Mar 18, 7:03 PM
epriestley added a comment to D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.

🎺 HERE COMES HERLAD 🎺

Mon, Mar 18, 7:02 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 7:01 PM · Diffusion
epriestley added a child revision for D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects: D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 7:01 PM
amckinley accepted D20286: Modularize workboard column transactions.
Mon, Mar 18, 6:57 PM
amckinley accepted D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.
Mon, Mar 18, 6:48 PM
epriestley added a comment to D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.

Old sequence:

Mon, Mar 18, 6:27 PM
epriestley requested review of D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.
Mon, Mar 18, 6:21 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.
Mon, Mar 18, 6:19 PM · Diffusion

Sun, Mar 17

leoluk awarded T8924: Add push notification support a Like token.
Sun, Mar 17, 9:39 AM · Notifications

Sat, Mar 16

epriestley edited the content of Changelog.
Sat, Mar 16, 9:20 PM
epriestley created 2019 Week 11 (Mid March).
Sat, Mar 16, 8:55 PM
epriestley committed rPHU564c7b305974: (stable) Promote 2019 Week 11 (authored by epriestley).
(stable) Promote 2019 Week 11
Sat, Mar 16, 8:55 PM
epriestley committed rPc767b045b245: (stable) Promote 2019 Week 11 (authored by epriestley).
(stable) Promote 2019 Week 11
Sat, Mar 16, 8:55 PM
epriestley placed T7607: Invoicing emails probably need some work up for grabs.
Sat, Mar 16, 8:41 PM · Phortune, Phacility
epriestley placed T11456: Don't lose user in NUX flow because of Timezone issues up for grabs.
Sat, Mar 16, 8:41 PM · Design, Phacility, NUX
epriestley placed T11132: New Phabricator NUX up for grabs.
Sat, Mar 16, 8:41 PM · Design, Phacility, NUX
epriestley placed T9515: Build a "quorum" mechanism and associated UI up for grabs.
Sat, Mar 16, 8:41 PM · Restricted Project, Notifications, Phacility, Auth
epriestley committed rPb469a5134ddd: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in… (authored by epriestley).
Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in…
Sat, Mar 16, 7:36 PM
epriestley closed T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer as Resolved by committing rPb469a5134ddd: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in….
Sat, Mar 16, 7:36 PM · Mail
epriestley closed D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
Sat, Mar 16, 7:36 PM
epriestley updated the task description for T13263: Plans: 2019 Week 11 Bonus Content.
Sat, Mar 16, 7:34 PM · Plans
epriestley added a comment to D20279: Provide basic scaffolding for workboard column triggers.

On trigger names, I'm currently imagining that we're likely to end up with a "quick" workflow where you just pick some rules for a column and we don't make you name the trigger, and a "slow and thoughtful" workflow where you take time to set things up and name the triggers. Not sure that'll stick or exactly what it'll look like.

Sat, Mar 16, 2:29 AM

Fri, Mar 15

amckinley accepted D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
Fri, Mar 15, 11:23 PM
amckinley accepted D20279: Provide basic scaffolding for workboard column triggers.
Fri, Mar 15, 10:56 PM
epriestley committed rP492b03628f19: Fix a typo in Drydock "Land" operations (authored by epriestley).
Fix a typo in Drydock "Land" operations
Fri, Mar 15, 9:53 PM
epriestley closed D20290: Fix a typo in Drydock "Land" operations.
Fri, Mar 15, 9:53 PM
amckinley accepted D20290: Fix a typo in Drydock "Land" operations.
Fri, Mar 15, 9:51 PM
epriestley requested review of D20290: Fix a typo in Drydock "Land" operations.
Fri, Mar 15, 9:49 PM
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Fri, Mar 15, 8:55 PM · Phacility
leoluk awarded T182: Commit into repository directly from differential a Like token.
Fri, Mar 15, 6:01 PM · Haskell.org, Restricted Project, Differential
leoluk awarded T11091: Make `arc patch` try the local working copy and staging areas a Like token.
Fri, Mar 15, 6:00 PM · Haskell.org, Arcanist
epriestley requested review of D20288: Hard code a "close task" action on every column Trigger.
Fri, Mar 15, 5:11 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20288: Hard code a "close task" action on every column Trigger.
Fri, Mar 15, 5:10 PM · Workboards (v3), Restricted Project
epriestley added a child revision for D20287: Allow triggers to be attached to and removed from workboard columns: D20288: Hard code a "close task" action on every column Trigger.
Fri, Mar 15, 5:10 PM
fanis removed a watcher for Plans: fanis.
Fri, Mar 15, 11:19 AM

Thu, Mar 14

epriestley requested review of D20287: Allow triggers to be attached to and removed from workboard columns.
Thu, Mar 14, 5:25 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20287: Allow triggers to be attached to and removed from workboard columns.
Thu, Mar 14, 5:24 PM · Workboards (v3), Restricted Project
epriestley added a child revision for D20286: Modularize workboard column transactions: D20287: Allow triggers to be attached to and removed from workboard columns.
Thu, Mar 14, 5:23 PM
epriestley added inline comments to D20286: Modularize workboard column transactions.
Thu, Mar 14, 3:25 PM
epriestley requested review of D20286: Modularize workboard column transactions.
Thu, Mar 14, 3:24 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20286: Modularize workboard column transactions.
Thu, Mar 14, 3:23 PM · Workboards (v3), Restricted Project
epriestley added a child revision for D20279: Provide basic scaffolding for workboard column triggers: D20286: Modularize workboard column transactions.
Thu, Mar 14, 3:22 PM
epriestley updated the diff for D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
  • Add SendGrid SMTP to the blocklist.
  • Simplify negative/default implementations of supportsMessageIDHeader().
Thu, Mar 14, 3:13 PM
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I also vaguely think some mailer API historically rejected mail with a "Message-ID" header with an actual error ("You can't set this header, we're going to set it for you.") rather than just ignoring/replacing it (maybe SendGrid?), but I might be misremembering or that behavior may have changed. We could still always set the header and drop it in the Adapter nowadays, this whole thing is just a nest of hornets and kicking it has pretty limited upside.

Thu, Mar 14, 3:10 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I was imagining keeping the Message-ID, while having the first email also include the same value for In-Reply-To — I completely agree that removing the Message-ID would not work out. If the first email always included both fields, thus referencing itself as a reply to itself, I suppose there could be MUAs that would go into infinite loops. So, maybe too risky.

Thu, Mar 14, 3:07 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I can imagine that cases like this may exist:

Thu, Mar 14, 2:58 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

The only effect I can imagine of always setting the In-Reply-To would be to encourage threading where it's not currently happening, so removing the behavior and deleting all these little methods would be very attractive to me if it were my project. :)

Thu, Mar 14, 2:46 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

There's probably some argument here for removing this behavior and assuming we can never generate a "Message-ID", but I'm hesitant to make changes like that since client threading is largely unknowable black magic which we can not test, and the current approach seems to generally produce acceptable results without an overwhelming amount of collateral complexity.

Thu, Mar 14, 2:20 PM · Mail
epriestley updated the diff for D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
  • Fix "the the" typo.
Thu, Mar 14, 2:00 PM
epriestley requested review of D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
Thu, Mar 14, 1:54 PM
epriestley added a revision to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer: D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
Thu, Mar 14, 1:53 PM · Mail
epriestley renamed T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer from Restore In-Reply-To field to first email about a Differential revision to Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.
Thu, Mar 14, 1:03 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

It worked!

Thu, Mar 14, 12:24 PM · Mail
kislinsk added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Very happy to see that you guys are working on this, thank you. 👍

Thu, Mar 14, 8:32 AM · Workboards (v3), Restricted Project

Wed, Mar 13

epriestley committed rPdf53d72e794c: Allow "Move Tasks to Column..." to prompt for MFA (authored by epriestley).
Allow "Move Tasks to Column..." to prompt for MFA
Wed, Mar 13, 11:30 PM
epriestley added a commit to T13074: Plans: Workboard triggers, groups, and subproject columns: rPdf53d72e794c: Allow "Move Tasks to Column..." to prompt for MFA.
Wed, Mar 13, 11:30 PM · Workboards (v3), Plans, Projects
epriestley closed D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Wed, Mar 13, 11:30 PM
epriestley committed rP04f9e72cbd10: Don't subscribe bots implicitly when they act on objects, or when they are… (authored by epriestley).
Don't subscribe bots implicitly when they act on objects, or when they are…
Wed, Mar 13, 11:28 PM
epriestley closed D20284: Don't subscribe bots implicitly when they act on objects, or when they are mentioned.
Wed, Mar 13, 11:28 PM
amckinley accepted D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Wed, Mar 13, 8:21 PM
amckinley accepted D20284: Don't subscribe bots implicitly when they act on objects, or when they are mentioned.
Wed, Mar 13, 8:21 PM
epriestley requested review of D20284: Don't subscribe bots implicitly when they act on objects, or when they are mentioned.
Wed, Mar 13, 6:50 PM
epriestley closed T10745: Emails are sent out about restricted changes as Wontfix.

This is an unconstructive mess that I don't specifically plan to act on. T13069 and other work may eventually resolve this case indirectly.

Wed, Mar 13, 6:27 PM · Restricted Project, Bug Report
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

report back on whether it mitigates

Wed, Mar 13, 6:16 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I merely wanted to have both possible resolutions on the table, one of which was to give the first message the ID later used In-Reply-To.

Wed, Mar 13, 5:03 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

How old were things before the upgrade? (Roughly: less or more than about a year old?)

Wed, Mar 13, 5:02 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

This previous behavior violated standards — the In-Reply-To identifier is supposed to be the Message-ID of a previously delivered email — but at least it wove a consistent fiction for mail clients.

Wed, Mar 13, 4:46 PM · Mail