Page MenuHomePhabricator
Feed All Stories

Yesterday

20after4 added a comment to T10915: Allow story points to just be task count.

I think that this is something we(Wikimedia) can patch downstream in our fork, I don't think there is anything further to add to this upstream discussion.

Thu, May 28, 6:27 PM · Restricted Project, Feature Request
epriestley requested review of D21294: Allow PhutilArrayCheck to accept a list of objects as a context.
Thu, May 28, 6:09 PM
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

Piledriver would also benefit from having some functional equivalent of destroying an Almanac resource. This can be implemented as a piledriver.destroyed property, but a formal disabled state would be cleaner. PHI1331 is vaguely related.

Thu, May 28, 5:53 PM · Phacility
mbinder added a comment to T10915: Allow story points to just be task count.

Bumping again simply because this has come up a few times this month. Teams I work with want to use a WIP feature, but don't use the current implementation because it tracks points instead of tasks. Reviewing the rest of the comments in this thread, all of it remains relevant to those use-cases.

Thu, May 28, 5:45 PM · Restricted Project, Feature Request
SirensOfTitan edited the content of Community Resources.
Thu, May 28, 4:13 PM
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.
  • When Piledriver destroys a resource pile, it's helpful if it can read the entire authoritative state from sources by using only a pile ID.
    • EC2 can do this with "DescribeTags".
    • Almanac currently can not. Almanac types should support searching by property value.
      • This could be directly on almanac.*.search.
      • Or this could be generic, via T12799.
Thu, May 28, 3:23 PM · Phacility
epriestley committed rARCa0c346bf63ec: Add a support class to simplify typechecking list-of-objects return values (authored by epriestley).
Add a support class to simplify typechecking list-of-objects return values
Thu, May 28, 2:33 PM
epriestley closed D21293: Add a support class to simplify typechecking list-of-objects return values.
Thu, May 28, 2:33 PM
epriestley committed rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell… (authored by epriestley).
Mark the wildcard argument to "arc liberate" as a path argument for shell…
Thu, May 28, 2:33 PM
epriestley closed D21292: Mark the wildcard argument to "arc liberate" as a path argument for shell completion.
Thu, May 28, 2:33 PM
epriestley requested review of D21293: Add a support class to simplify typechecking list-of-objects return values.
Thu, May 28, 2:31 PM
epriestley requested review of D21292: Mark the wildcard argument to "arc liberate" as a path argument for shell completion.
Thu, May 28, 2:25 PM

Wed, May 27

epriestley closed T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation as Resolved.

Problem 2: Arcanist does not check that messages emitted by linters have a valid line number.

Wed, May 27, 7:40 PM · Arcanist
epriestley committed rARCfce72b9c89d7: Make lint tests handle paths better and distinguish between "0" and "null" more… (authored by epriestley).
Make lint tests handle paths better and distinguish between "0" and "null" more…
Wed, May 27, 7:38 PM
epriestley closed D21291: Make lint tests handle paths better and distinguish between "0" and "null" more carefully.
Wed, May 27, 7:38 PM
epriestley requested review of D21291: Make lint tests handle paths better and distinguish between "0" and "null" more carefully.
Wed, May 27, 7:37 PM
epriestley added a revision to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation: D21291: Make lint tests handle paths better and distinguish between "0" and "null" more carefully.
Wed, May 27, 7:36 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.

Problem 3: The cpplint unit tests fail, and the failure appears to be pre-existing and significant.

Wed, May 27, 6:56 PM · Arcanist
epriestley committed rARC4aebaaf60895: (stable) Fix an issue when rendering a lint message which removes whitespace at… (authored by epriestley).
(stable) Fix an issue when rendering a lint message which removes whitespace at…
Wed, May 27, 6:28 PM
epriestley committed rARCe69aa3260388: Fix an issue when rendering a lint message which removes whitespace at the end… (authored by epriestley).
Fix an issue when rendering a lint message which removes whitespace at the end…
Wed, May 27, 6:28 PM
epriestley closed D21290: Fix an issue when rendering a lint message which removes whitespace at the end of a file.
Wed, May 27, 6:28 PM
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.
  • Problem 4: If a file ends in non-newline whitespace, the text linter may raise a message which removes that line. The renderer then tries to highlight part of it, which fatals.
Wed, May 27, 6:28 PM · Arcanist
epriestley requested review of D21290: Fix an issue when rendering a lint message which removes whitespace at the end of a file.
Wed, May 27, 6:26 PM
epriestley added a revision to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation: D21290: Fix an issue when rendering a lint message which removes whitespace at the end of a file.
Wed, May 27, 6:26 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.

Here's a simplified reproduction case for "Problem 1":

Wed, May 27, 6:07 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.
  • Problem 1: cpplint may raise messages at line 0, but arcanist can not render these messages after the severity of runtime-level errors was increased in D21044.
Wed, May 27, 6:04 PM · Arcanist
epriestley committed rARC609c8c9fdc32: (stable) In the "cpplint" binding, raise messages on "line 0" without a line (authored by epriestley).
(stable) In the "cpplint" binding, raise messages on "line 0" without a line
Wed, May 27, 6:00 PM
epriestley committed rARC25ee39b657b8: In the "cpplint" binding, raise messages on "line 0" without a line (authored by epriestley).
In the "cpplint" binding, raise messages on "line 0" without a line
Wed, May 27, 5:59 PM
epriestley closed D21289: In the "cpplint" binding, raise messages on "line 0" without a line.
Wed, May 27, 5:59 PM
epriestley requested review of D21289: In the "cpplint" binding, raise messages on "line 0" without a line.
Wed, May 27, 5:58 PM
epriestley added a revision to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation: D21289: In the "cpplint" binding, raise messages on "line 0" without a line.
Wed, May 27, 5:58 PM · Arcanist
epriestley triaged T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation as Low priority.
Wed, May 27, 5:55 PM · Arcanist

Tue, May 26

epriestley closed T13467: Expand the "ddata003" volume as Resolved.

Effectively mooted by T13542.

Tue, May 26, 8:32 PM · Phacility
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

I've written some Terraform-class tooling which can likely automate all the actual hardware allocations. This needs some more work, but I believe the tricky stuff (mostly: representing resources and allowing templating to reference resources which haven't been built yet) is at least working.

Tue, May 26, 8:31 PM · Phacility
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

Subnet/NAT issues in T12816.

Tue, May 26, 8:18 PM · Phacility
epriestley closed T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction as Resolved.

Continued in T13542.

Tue, May 26, 8:13 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T12801: Simplify Almanac services in the Phacility production cluster as Resolved.

The major offender here (services per instance) was fixed by updating caching, and I destroyed all the old services. This is perhaps spiritually continued in T13542.

Tue, May 26, 8:11 PM · Almanac, Ops, Phacility
epriestley updated the task description for T13542: Rebalance Phacility instances into a private subnet.
Tue, May 26, 8:10 PM · Phacility
epriestley closed T12999: Replace cluster magnetic volumes with SSD volumes as Resolved.

Continued in T13542.

Tue, May 26, 8:10 PM · Phacility, Ops
epriestley closed T12856: Evaluate various "infrastructure-as-code" products as Resolved.

Continued in T13542. I wrote a Terraform/CloudFormation-style service in PHP over the last couple of days.

Tue, May 26, 8:07 PM · Ops, Phacility
epriestley closed T12816: Setup NAT for the primary Phacility cluster as Resolved.

Continued in T13542.

Tue, May 26, 8:03 PM · Ops, Phacility
epriestley updated the task description for T13542: Rebalance Phacility instances into a private subnet.
Tue, May 26, 8:03 PM · Phacility
epriestley triaged T13542: Rebalance Phacility instances into a private subnet as Low priority.
Tue, May 26, 8:02 PM · Phacility
epriestley committed rP621f9de4bb9c: (stable) In Phortune accounts, prevent self-removal more narrowly (authored by epriestley).
(stable) In Phortune accounts, prevent self-removal more narrowly
Tue, May 26, 2:10 PM
epriestley committed rPf686a0b8275e: In Phortune accounts, prevent self-removal more narrowly (authored by epriestley).
In Phortune accounts, prevent self-removal more narrowly
Tue, May 26, 2:09 PM
epriestley closed D21288: In Phortune accounts, prevent self-removal more narrowly.
Tue, May 26, 2:09 PM
epriestley updated the summary of D21288: In Phortune accounts, prevent self-removal more narrowly.
Tue, May 26, 2:08 PM
epriestley updated the summary of D21288: In Phortune accounts, prevent self-removal more narrowly.
Tue, May 26, 2:07 PM
epriestley requested review of D21288: In Phortune accounts, prevent self-removal more narrowly.
Tue, May 26, 2:07 PM

Mon, May 25

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Committer identities ... they're currently stored in a JSON blob so there's no efficient way to query them.

Mon, May 25, 2:26 PM · Customer Impact, Diffusion (v3)
sshannin added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

That was sufficient to get what I needed, thanks so much.

Mon, May 25, 2:15 PM · Customer Impact, Diffusion (v3)
tycho.tatitscheff awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Mountain of Wealth token.
Mon, May 25, 7:58 AM · Differential, Quick Look
claassen awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Like token.
Mon, May 25, 7:55 AM · Differential, Quick Look

Sun, May 24

PXke awarded T13540: "Dark Mode" UI issues a Love token.
Sun, May 24, 3:52 PM · Design
PXke awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
Sun, May 24, 3:31 PM · Differential, Quick Look
PXke awarded Blog Post: Quick Look: Inline Comments on Character Ranges a Love token.
Sun, May 24, 3:30 PM · Quick Look, Differential
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Is there a way to find which object(s) an (unmapped) identity was discovered on?

Sun, May 24, 2:16 PM · Customer Impact, Diffusion (v3)

Sat, May 23

sshannin added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Is there a way to find which object(s) an (unmapped) identity was discovered on? After a rebuild-identities, I have an empty string identity and a couple asdf-style garbage ones. I'd like to find the source of them and either fix them there or see the context to understand the appropriate identity mapping.

Sat, May 23, 6:31 PM · Customer Impact, Diffusion (v3)
epriestley committed rP38991188d6d1: (stable) Fix an issue where inline comments with only edit suggestions are… (authored by epriestley).
(stable) Fix an issue where inline comments with only edit suggestions are…
Sat, May 23, 3:25 PM
epriestley committed rPa529efa5b855: Fix an issue where inline comments with only edit suggestions are considered… (authored by epriestley).
Fix an issue where inline comments with only edit suggestions are considered…
Sat, May 23, 3:25 PM
epriestley closed D21287: Fix an issue where inline comments with only edit suggestions are considered empty.
Sat, May 23, 3:25 PM
epriestley requested review of D21287: Fix an issue where inline comments with only edit suggestions are considered empty.
Sat, May 23, 3:19 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21287: Fix an issue where inline comments with only edit suggestions are considered empty.
Sat, May 23, 3:18 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In previews, suggestions aren't highlighted properly (likely just missing CSS).
Sat, May 23, 3:15 PM · Inline Comments, Diffusion, Differential
avivey awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Manufacturing Defect? token.
Sat, May 23, 6:19 AM · Differential, Quick Look
mcorteel awarded Blog Post: Quick Look: Inline Comments on Character Ranges a Love token.
Sat, May 23, 5:47 AM · Quick Look, Differential
hskiba awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Mountain of Wealth token.
Sat, May 23, 2:04 AM · Differential, Quick Look

Fri, May 22

epriestley committed rP4042ea648518: (stable) When cancelling an edit of an inline with content, don't hide the… (authored by epriestley).
(stable) When cancelling an edit of an inline with content, don't hide the…
Fri, May 22, 10:41 PM
epriestley committed rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline (authored by epriestley).
When cancelling an edit of an inline with content, don't hide the inline
Fri, May 22, 10:40 PM
epriestley closed D21286: When cancelling an edit of an inline with content, don't hide the inline.
Fri, May 22, 10:40 PM
epriestley requested review of D21286: When cancelling an edit of an inline with content, don't hide the inline.
Fri, May 22, 10:30 PM
cspeckmim awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
Fri, May 22, 9:53 PM · Differential, Quick Look
epriestley edited the content of Changelog.
Fri, May 22, 9:44 PM
epriestley created an object: 2020 Week 20 (Late May).
Fri, May 22, 9:43 PM
epriestley created Blog Post: Quick Look: Suggesting Edits with Inline Comments.
Fri, May 22, 9:41 PM · Differential, Quick Look
epriestley committed rP73024e454239: (stable) Promote 2020 Week 20 (authored by epriestley).
(stable) Promote 2020 Week 20
Fri, May 22, 9:23 PM
epriestley committed rP959a835b95dd: When executing a repository passthru command via CommandEngine, don't set a… (authored by epriestley).
When executing a repository passthru command via CommandEngine, don't set a…
Fri, May 22, 6:54 PM
epriestley closed D21284: When executing a repository passthru command via CommandEngine, don't set a timeout.
Fri, May 22, 6:54 PM
epriestley committed rP828798f3e1b4: (stable) Fix two rendering issues with Jupyter notebooks (authored by epriestley).
(stable) Fix two rendering issues with Jupyter notebooks
Fri, May 22, 6:54 PM
epriestley committed rP4fd0628fae45: Fix two rendering issues with Jupyter notebooks (authored by epriestley).
Fix two rendering issues with Jupyter notebooks
Fri, May 22, 6:54 PM
epriestley closed D21285: Fix two rendering issues with Jupyter notebooks.
Fri, May 22, 6:54 PM
epriestley requested review of D21285: Fix two rendering issues with Jupyter notebooks.
Fri, May 22, 6:52 PM
sshannin added a comment to T7469: Handle folder copies/moves more gracefully.

(there's usually no value in reviewing individual file-level changes in a "create a new branch X" commit)

Completely agree that there's no value in reviewing those individually. But to be clear, my point in making this ticket was mostly that you can't discern from the browser that this was a "create a new branch" commit. Right now it just renders the whole file tree saying showing 3000 files individually copied instead of a simpler/single line saying the whole directory was copied.

Fri, May 22, 6:10 PM · Diffusion, Subversion
epriestley requested review of D21284: When executing a repository passthru command via CommandEngine, don't set a timeout.
Fri, May 22, 12:46 PM
epriestley added a revision to T13541: Very large repositories may fail initial fetches after 15 minutes: D21284: When executing a repository passthru command via CommandEngine, don't set a timeout.
Fri, May 22, 12:45 PM · Diffusion
epriestley triaged T13541: Very large repositories may fail initial fetches after 15 minutes as Low priority.
Fri, May 22, 12:02 PM · Diffusion
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

Since many of these options probably don't have "right answers", I'm trying this reasonable-seeming variation on some repositories which seem like they'll benefit from a repack:

Fri, May 22, 3:03 AM · Phacility, Diffusion

Thu, May 21

epriestley committed rP87fb35abb72e: Prevent keyboard selection of change blocks inside edit suggestions (authored by epriestley).
Prevent keyboard selection of change blocks inside edit suggestions
Thu, May 21, 10:38 PM
epriestley closed D21283: Prevent keyboard selection of change blocks inside edit suggestions.
Thu, May 21, 10:37 PM
epriestley committed rP66566f878d82: Make "Open in Editor" use the simple line number of the current selected block (authored by epriestley).
Make "Open in Editor" use the simple line number of the current selected block
Thu, May 21, 10:31 PM
epriestley closed D21282: Make "Open in Editor" use the simple line number of the current selected block.
Thu, May 21, 10:31 PM
epriestley updated the summary of D21283: Prevent keyboard selection of change blocks inside edit suggestions.
Thu, May 21, 10:10 PM
epriestley requested review of D21283: Prevent keyboard selection of change blocks inside edit suggestions.
Thu, May 21, 10:07 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21283: Prevent keyboard selection of change blocks inside edit suggestions.
Thu, May 21, 10:06 PM · Inline Comments, Diffusion, Differential
epriestley updated the diff for D21282: Make "Open in Editor" use the simple line number of the current selected block.
  • Ignore selected elements that are not part of the current changeset.
Thu, May 21, 9:44 PM
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • n, etc., can incorrectly select blocks inside a diff inside a suggestion.
Thu, May 21, 9:41 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21282: Make "Open in Editor" use the simple line number of the current selected block.
Thu, May 21, 9:32 PM
epriestley triaged T13540: "Dark Mode" UI issues as Wishlist priority.
Thu, May 21, 8:32 PM · Design
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

See PHI1748. I ran a query against a subset of instances to determine how widespread usage of "Dark Mode" is, to help inform a decision to either implement the mode properly (see T12311) or remove the mode. The query was of this form:

Thu, May 21, 8:08 PM · Phacility
epriestley closed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) as Resolved.

I think (?) this was pretty much resolved by the last round of changes. See T13291 for some followups.

Thu, May 21, 4:03 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia