Feed All Stories
Yesterday
Yesterday
epriestley edited the content of Changelog.
(stable) Promote 2020 Week 31
epriestley created an object: 2020 Week 31 (Early August).
Wed, Aug 5
Wed, Aug 5
epriestley committed rPce0dc9a2ba2c: Correct an apparent off-by-one error when adjusting inlines across revision… (authored by epriestley).
Correct an apparent off-by-one error when adjusting inlines across revision…
epriestley committed rPdbdfac1e072e: Recover inline comments which are "adjusted" off the end of a diff (authored by epriestley).
Recover inline comments which are "adjusted" off the end of a diff
epriestley requested review of D21435: Recover inline comments which are "adjusted" off the end of a diff.
epriestley committed rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or… (authored by epriestley).
In Jupyter notebooks, read strings stored in the raw as either "string" or…
epriestley updated the task description for T13241: Guide: SMS is Insecure.
epriestley added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
With newer inline comment functionality there is no ability to create submitted inline comments for bots or via API directly.
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
epriestley committed rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines (authored by epriestley).
In 1-up source diffs, retain the "No newline at end of file" on "\" lines
epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
epriestley added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.
What is not programmatical way to "submit" unsubmitted inline comments? Some users are using it to post comments from bots, now if we use differential.createinline api method all bot comments are visible as unsubmitted and looks like there is no way to set it in stone...
Sun, Aug 2
Sun, Aug 2
epriestley committed rP287b7485a68a: (stable) Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
(stable) Move "Wait for Previous Commits to Build" out of prototype
Thu, Jul 30
Thu, Jul 30
jg added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.
epriestley added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.
See PHI1833.
epriestley committed rPc1eeacd8500b: Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
Move "Wait for Previous Commits to Build" out of prototype
epriestley requested review of D21432: Move "Wait for Previous Commits to Build" out of prototype.
Tue, Jul 28
Tue, Jul 28
epriestley requested review of D21431: Improve handle/status list display on devices in commit graph lists.
epriestley requested review of D21430: Improve commit action item layout on mobile.
Mon, Jul 27
Mon, Jul 27
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Sat, Jul 25
Sat, Jul 25
epriestley edited the content of Changelog.
(stable) Promote 2020 Week 29
(stable) Promote 2020 Week 29
epriestley created an object: 2020 Week 29 (Late July).
avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.
related to T3278, probably?
Fri, Jul 24
Fri, Jul 24
epriestley committed rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior (authored by epriestley).
Revert use of "user-select: all" to modify tab selection behavior
epriestley requested review of D21429: Revert use of "user-select: all" to modify tab selection behavior.
epriestley added a comment to D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
I reverted this in D21429, since it also makes these sequences select with a single click.
epriestley added a comment to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.
In D21426, I removed phd.trace and phd.verbose.
Thu, Jul 23
Thu, Jul 23
epriestley committed rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options (authored by epriestley).
Remove ancient "phd.trace" and "phd.verbose" configuration options
epriestley updated the diff for D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
- Include "obsolete config" setup checks.
epriestley requested review of D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
epriestley committed rP78d1b62bb8e9: Streamline handling of Futures and PIDs in daemons (authored by epriestley).
Streamline handling of Futures and PIDs in daemons
epriestley committed rP5f0535934d72: Manage PIDs more carefully in DaemonHandle (authored by epriestley).
Manage PIDs more carefully in DaemonHandle
epriestley committed rARCceb082ef6b29: Give Futures clearer start/end and exception semantics (authored by epriestley).
Give Futures clearer start/end and exception semantics
epriestley triaged T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes as Wishlist priority.
epriestley updated the diff for D21425: Streamline handling of Futures and PIDs in daemons.
- Use "$caught", not "$ex", to make the code less fragile.
epriestley requested review of D21425: Streamline handling of Futures and PIDs in daemons.
epriestley updated the diff for D21423: Give Futures clearer start/end and exception semantics.
- Add "ExecFuture->hasPID()" to simplify reading PID information.
epriestley added a comment to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall.
The call sequence here is approximately:
epriestley requested review of D21424: Manage PIDs more carefully in DaemonHandle.
epriestley requested review of D21423: Give Futures clearer start/end and exception semantics.
epriestley triaged T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall as Normal priority.
epriestley committed rPfcb75d0503c6: Fix an issue where prose diffing may fail after hitting the PCRE backtracking… (authored by epriestley).
Fix an issue where prose diffing may fail after hitting the PCRE backtracking…
epriestley added a comment to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()".
This is a PCRE backtracking issue. It reproduces on an input corpus of length 3,277 bytes with only "x", " " (space), and "\n" (newline) characters, and disappears if I increase pcre.backtrack_limit.
epriestley triaged T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Low priority.
Wed, Jul 22
Wed, Jul 22
epriestley added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".
Please use Discourse to discuss Phabricator.
jbrownEP added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".
This task references more details on "Excuses" and "Prompts", but there isn't any. Is there any way to provide context around lint issues?
epriestley committed rP324445589b5e: (stable) Fix an issue with destruction of Revision and Diff objects with… (authored by epriestley).
(stable) Fix an issue with destruction of Revision and Diff objects with…
epriestley committed rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates (authored by epriestley).
Fix an issue with destruction of Revision and Diff objects with viewstates
epriestley added a comment to D21041: Use a named remote and branches for staging to help git-lfs.
If you believe you've found a bug in Phabricator, please report it on Discourse, including complete reproduction instructions.
maroux added inline comments to D21041: Use a named remote and branches for staging to help git-lfs.
Tue, Jul 21
Tue, Jul 21
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
epriestley triaged T13553: Creating a milestone via the API fails when accessing the project's parent as Normal priority.
Mon, Jul 20
Mon, Jul 20
epriestley defrocked amckinley.
Sat, Jul 18
Sat, Jul 18
epriestley committed rPd32c3f8d7d65: (stable) Likely, fix a warning when rendering modified coverage (authored by epriestley).
(stable) Likely, fix a warning when rendering modified coverage
epriestley committed rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage (authored by epriestley).
Likely, fix a warning when rendering modified coverage
epriestley requested review of D21420: Likely, fix a warning when rendering modified coverage.
Fri, Jul 17
Fri, Jul 17
epriestley committed rP37ffb71c4d5e: In source views, wrap display tabs in "user-select: all" to improve cursor… (authored by epriestley).
In source views, wrap display tabs in "user-select: all" to improve cursor…
Thu, Jul 16
Thu, Jul 16
epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.
Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)
Kwisatz added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.
Is this really a harbormaster problem though? I would have located it within Differential.