Page MenuHomePhabricator
Feed All Stories

Yesterday

epriestley committed rP2e2dc47f0763: In the Herald test console, don't consider transactions that Herald rules… (authored by epriestley).
In the Herald test console, don't consider transactions that Herald rules…
Wed, May 22, 11:34 PM
epriestley closed D20547: In the Herald test console, don't consider transactions that Herald rules applied.
Wed, May 22, 11:34 PM
epriestley committed rP31e623afcc92: Use the same transaction group ID for transactions applied indirectly by a sub… (authored by epriestley).
Use the same transaction group ID for transactions applied indirectly by a sub…
Wed, May 22, 11:33 PM
epriestley closed D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
Wed, May 22, 11:33 PM
epriestley committed rPf6af1c437424: When creating a Phriction document, mark initial transactions as "create"… (authored by epriestley).
When creating a Phriction document, mark initial transactions as "create"…
Wed, May 22, 11:28 PM
epriestley closed D20548: When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email.
Wed, May 22, 11:28 PM
epriestley committed rPb95bf722d55e: Drop the "update revision with commit diff" transaction if the revision is… (authored by epriestley).
Drop the "update revision with commit diff" transaction if the revision is…
Wed, May 22, 11:26 PM
epriestley closed D20545: Drop the "update revision with commit diff" transaction if the revision is already closed.
Wed, May 22, 11:26 PM
epriestley committed rP1eff4fdca332: Prevent "Differential Revision: ..." from counting as a mention in commit… (authored by epriestley).
Prevent "Differential Revision: ..." from counting as a mention in commit…
Wed, May 22, 11:22 PM
epriestley closed D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
Wed, May 22, 11:22 PM
epriestley committed rPfa4dcaa3aaff: Stabilize sorting of feed stories with similar strength (authored by epriestley).
Stabilize sorting of feed stories with similar strength
Wed, May 22, 10:51 PM
epriestley closed D20540: Stabilize sorting of feed stories with similar strength.
Wed, May 22, 10:51 PM
amckinley accepted D20548: When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email.
Wed, May 22, 10:39 PM
amckinley accepted D20545: Drop the "update revision with commit diff" transaction if the revision is already closed.
Wed, May 22, 10:36 PM
amckinley accepted D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
Wed, May 22, 10:30 PM
amckinley accepted D20547: In the Herald test console, don't consider transactions that Herald rules applied.
Wed, May 22, 10:30 PM
epriestley requested review of D20548: When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email.
Wed, May 22, 10:17 PM
epriestley added a revision to T13289: Plans: 2019 Week 21 Bonus Content: D20548: When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email.
Wed, May 22, 10:15 PM · Plans
epriestley added a comment to D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.

D20547 alone would also fix this specific problem (by skipping the Herald transactions), but I think this change is good on its own and generally makes behavior more consistent/expected.

Wed, May 22, 9:50 PM
epriestley requested review of D20547: In the Herald test console, don't consider transactions that Herald rules applied.
Wed, May 22, 9:49 PM
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: D20547: In the Herald test console, don't consider transactions that Herald rules applied.
Wed, May 22, 9:48 PM · Herald
epriestley requested review of D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
Wed, May 22, 9:43 PM
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
Wed, May 22, 9:41 PM · Herald
amckinley accepted D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
Wed, May 22, 9:37 PM
epriestley requested review of D20545: Drop the "update revision with commit diff" transaction if the revision is already closed.
Wed, May 22, 9:32 PM
epriestley added a revision to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": D20545: Drop the "update revision with commit diff" transaction if the revision is already closed.
Wed, May 22, 9:31 PM · Diffusion, Differential
amckinley added a comment to D20540: Stabilize sorting of feed stories with similar strength.

Reading PHI1222; nice catch!

Wed, May 22, 9:19 PM
amckinley accepted D20540: Stabilize sorting of feed stories with similar strength.
Wed, May 22, 9:18 PM
epriestley requested review of D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
Wed, May 22, 9:16 PM
amckinley updated the summary of D20540: Stabilize sorting of feed stories with similar strength.
Wed, May 22, 9:15 PM
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
Wed, May 22, 9:15 PM · Remarkup, Diffusion
epriestley added a revision to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
Wed, May 22, 9:15 PM · Diffusion, Differential
epriestley added a comment to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon.

Currently, I think the primary transactions and transactions triggered by Herald are getting different group IDs. They should be the same group ID, e.g. all these transactions should be in the same "group" for the purposes of collecting transactions into effect groups:

Wed, May 22, 7:56 PM · Herald
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

(This is mostly for my own notes and contains roughly zero insight.)

Wed, May 22, 6:07 PM · Diffusion, Differential
epriestley added a project to T13292: Create a "Sounds" application: Sounds.
Wed, May 22, 4:56 PM · Sounds
epriestley created Sounds.
Wed, May 22, 4:56 PM
epriestley added a comment to T13292: Create a "Sounds" application.

If we were just doing personal notification sounds, I think there'd be a good argument for making this a Settings panel.

Wed, May 22, 4:54 PM · Sounds
epriestley triaged T13293: `arc land` using git-svn fails in certain configurations as Low priority.
Wed, May 22, 4:30 PM · Subversion, Git, Arcanist
epriestley added projects to T13293: `arc land` using git-svn fails in certain configurations: Arcanist, Git, Subversion.
Wed, May 22, 4:30 PM · Subversion, Git, Arcanist
epriestley accepted D19681: Fix arc land on odd/modern git-svn checkouts.

Thanks, T13293 makes this much clearer.

Wed, May 22, 4:30 PM
epriestley added a comment to T13294: Provide a transaction-level view of feed.

Per D20533, the major query this UI uses is currently unkeyed (no dateCreated key on transaction tables).

Wed, May 22, 3:44 PM · Feed, Transactions
epriestley committed rPf91bef64f163: Stack chart functions in a more physical way (authored by epriestley).
Stack chart functions in a more physical way
Wed, May 22, 12:40 PM
epriestley closed D20506: Stack chart functions in a more physical way.
Wed, May 22, 12:40 PM
epriestley committed rPf190c42bcd2e: Store charts earlier and build them out a little later (authored by epriestley).
Store charts earlier and build them out a little later
Wed, May 22, 12:39 PM
epriestley closed D20504: Store charts earlier and build them out a little later.
Wed, May 22, 12:39 PM
epriestley committed rP493a6b72c1c0: Automatically select the range for charts in a general way (authored by epriestley).
Automatically select the range for charts in a general way
Wed, May 22, 12:37 PM
epriestley closed D20503: Automatically select the range for charts in a general way.
Wed, May 22, 12:37 PM
epriestley committed rPe90360c28967: Wrap "<min, max>" chart domain pairs in an "Interval" class (authored by epriestley).
Wrap "<min, max>" chart domain pairs in an "Interval" class
Wed, May 22, 12:29 PM
epriestley closed D20502: Wrap "<min, max>" chart domain pairs in an "Interval" class.
Wed, May 22, 12:29 PM
epriestley committed rPa80426b339c4: Provide chart function labels over the wire instead of making them up (authored by epriestley).
Provide chart function labels over the wire instead of making them up
Wed, May 22, 12:23 PM
epriestley closed D20501: Provide chart function labels over the wire instead of making them up.
Wed, May 22, 12:23 PM
epriestley added inline comments to D20501: Provide chart function labels over the wire instead of making them up.
Wed, May 22, 12:22 PM
epriestley committed rPc6052b41a604: Label important data on charts (authored by epriestley).
Label important data on charts
Wed, May 22, 12:21 PM
epriestley closed D20500: Label important data on charts.
Wed, May 22, 12:21 PM
epriestley committed rP81456db5594e: Roughly support stacked area charts (authored by epriestley).
Roughly support stacked area charts
Wed, May 22, 12:19 PM
epriestley closed D20498: Roughly support stacked area charts.
Wed, May 22, 12:19 PM
epriestley committed rP0776b5ca2c4d: Update D3 to the current version (authored by epriestley).
Update D3 to the current version
Wed, May 22, 12:16 PM
epriestley closed D20497: Update D3 to the current version.
Wed, May 22, 12:16 PM
epriestley committed rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine" (authored by epriestley).
Consolidate burndown logic into a "BurndownChartEngine"
Wed, May 22, 12:10 PM
epriestley closed D20496: Consolidate burndown logic into a "BurndownChartEngine".
Wed, May 22, 12:10 PM
epriestley committed rP0aee3da19e6a: Add a "Reports" menu item to Projects (authored by epriestley).
Add a "Reports" menu item to Projects
Wed, May 22, 12:09 PM
epriestley closed D20495: Add a "Reports" menu item to Projects.
Wed, May 22, 12:09 PM
epriestley committed rPf87c1ac362a7: Start the fact daemon in "bin/phd start" (authored by epriestley).
Start the fact daemon in "bin/phd start"
Wed, May 22, 11:58 AM
epriestley closed D20489: Start the fact daemon in "bin/phd start".
Wed, May 22, 11:58 AM
epriestley committed rP10afe1f2b59c: Fix handling of "null" domain values in Charts (authored by epriestley).
Fix handling of "null" domain values in Charts
Wed, May 22, 11:51 AM
epriestley closed D20488: Fix handling of "null" domain values in Charts.
Wed, May 22, 11:51 AM
epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.

See also T13290. Now that full URIs count as mentions (D20527), the text "Differential Revision: ..." in commits is counting as a mention, and "mentioning" the associated revision.

Wed, May 22, 11:51 AM · Remarkup, Diffusion
epriestley committed rP146317f2c447: Remove the legacy chart behavior from Maniphest (authored by epriestley).
Remove the legacy chart behavior from Maniphest
Wed, May 22, 11:48 AM
epriestley closed D20487: Remove the legacy chart behavior from Maniphest.
Wed, May 22, 11:48 AM
epriestley committed rPf8ebc71b8f21: Replace the chart in Maniphest Reports with a chart driven by Facts (authored by epriestley).
Replace the chart in Maniphest Reports with a chart driven by Facts
Wed, May 22, 11:44 AM
epriestley closed D20486: Replace the chart in Maniphest Reports with a chart driven by Facts.
Wed, May 22, 11:44 AM
epriestley committed rPff6b13872ccf: Add a rough "Chart" Dashboard Panel (authored by epriestley).
Add a rough "Chart" Dashboard Panel
Wed, May 22, 11:36 AM
epriestley closed D20485: Add a rough "Chart" Dashboard Panel.
Wed, May 22, 11:36 AM
epriestley committed rPc458b50b8569: Render charts from storage instead of just one ad-hoc hard-coded chart (authored by epriestley).
Render charts from storage instead of just one ad-hoc hard-coded chart
Wed, May 22, 11:32 AM
epriestley closed D20483: Render charts from storage instead of just one ad-hoc hard-coded chart.
Wed, May 22, 11:31 AM
epriestley added a comment to D20503: Automatically select the range for charts in a general way.

(We also don't need to tick the y-max -- we could tick at 100 and draw to 110.)

Wed, May 22, 11:30 AM
epriestley added a comment to D20503: Automatically select the range for charts in a general way.

Yeah, I ideally want to try to round up, up to X%, to the nearest "nice" number, like if the range is 0-93 we show 0-100, since "100" is the nearest "nice round number" above 93. There was some simple code for this before (visual-max = actual-max * 1.2 or something) which makes the shape of the graph look good but doesn't produce the most satisfying ticks on the Y-axis or the ideally satisfying Y-max.

Wed, May 22, 11:29 AM
joshuaspence updated the diff for D20526: Make it easier to parse external linter versions.

Implement parseVersionOutput in ArcanistExternalLinter so that it can be proxied from within another instance of ArcanistExternalLinter

Wed, May 22, 3:27 AM
joshuaspence updated the summary of D20526: Make it easier to parse external linter versions.
Wed, May 22, 3:24 AM
joshuaspence updated the diff for D20542: Be more strict when checking linter versions.

Rebase

Wed, May 22, 1:59 AM
joshuaspence requested review of D20542: Be more strict when checking linter versions.
Wed, May 22, 1:25 AM
joshuaspence requested review of D20541: Use the checkstyle reporter with JSHint.
Wed, May 22, 1:00 AM
joshuaspence updated the diff for D20526: Make it easier to parse external linter versions.

Rebase

Wed, May 22, 12:50 AM
joshuaspence added a comment to D20532: Fix handling of empty line/column in linter tests.

Unrelated but I noticed that ArcanistBundleTestCase::testGitRepository fails locally for me when running arc unit --everything:

Wed, May 22, 12:37 AM
joshuaspence updated the summary of D20526: Make it easier to parse external linter versions.
Wed, May 22, 12:32 AM
epriestley requested review of D20540: Stabilize sorting of feed stories with similar strength.
Wed, May 22, 12:05 AM

Tue, May 21

amckinley accepted D20506: Stack chart functions in a more physical way.
Tue, May 21, 10:56 PM
amckinley accepted D20504: Store charts earlier and build them out a little later.
Tue, May 21, 10:40 PM
amckinley accepted D20503: Automatically select the range for charts in a general way.
Tue, May 21, 10:30 PM
amckinley accepted D20502: Wrap "<min, max>" chart domain pairs in an "Interval" class.
Tue, May 21, 10:27 PM
amckinley accepted D20501: Provide chart function labels over the wire instead of making them up.
Tue, May 21, 9:38 PM
amckinley accepted D20500: Label important data on charts.
Tue, May 21, 9:36 PM
amckinley accepted D20496: Consolidate burndown logic into a "BurndownChartEngine".
Tue, May 21, 9:35 PM
amckinley accepted D20486: Replace the chart in Maniphest Reports with a chart driven by Facts.
Tue, May 21, 9:34 PM
amckinley accepted D20485: Add a rough "Chart" Dashboard Panel.
Tue, May 21, 8:36 PM
amckinley accepted D20483: Render charts from storage instead of just one ad-hoc hard-coded chart.
Tue, May 21, 8:28 PM
epriestley committed rP4180b337cf7e: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference… (authored by epriestley).
Add a "{src ...}" Remarkup rule to provide a more flexible way to reference…
Tue, May 21, 8:12 PM
epriestley closed D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.
Tue, May 21, 8:12 PM
epriestley committed rP56e7bde68d9b: Recognize self-URI links to Diffusion files and give them special rendering… (authored by epriestley).
Recognize self-URI links to Diffusion files and give them special rendering…
Tue, May 21, 8:07 PM
epriestley closed D20538: Recognize self-URI links to Diffusion files and give them special rendering behavior.
Tue, May 21, 8:07 PM