Page MenuHomePhabricator

Fix an issue where known Subversion commits are incorrectly shown as "Discovering..."
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:52 PM.

Details

Summary

Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases.

Use "withRepository()", which gives us the correct identifier resolution behavior.

Test Plan

Viewed a subversion repository history in Diffusion, saw commit details after change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:55 PM
This revision was automatically updated to reflect the committed changes.