Page MenuHomePhabricator

When an in-process worker subtask fails permanently, don't fatal the whole process
ClosedPublic

Authored by epriestley on Sep 8 2020, 8:15 PM.
Tags
None
Referenced Files
F15443414: D21459.id51069.diff
Thu, Mar 27, 4:15 AM
F15441728: D21459.id.diff
Wed, Mar 26, 7:36 PM
F15431088: D21459.diff
Mon, Mar 24, 10:25 AM
F15390029: D21459.diff
Sat, Mar 15, 5:51 AM
F15333014: D21459.diff
Mar 7 2025, 11:06 PM
F15286194: D21459.id51069.diff
Mar 4 2025, 7:00 PM
F15286168: D21459.id51089.diff
Mar 4 2025, 6:47 PM
F15283826: D21459.id.diff
Mar 4 2025, 8:39 AM
Subscribers
None

Details

Summary

Ref T13552. Fixes T13569. Currently, if a process uses in-process tasks (usually, a debugging/diagnostic workflow) and those tasks (or tasks those tasks queue) fail permanently, the exception escapes to top level and the process exits.

This isn't desirable; catch the exception and fail them locally instead.

Test Plan

With a failing Asana integration and misconfigured Webhook, ran bin/repository reparse --publish ....

  • Before: fatals on each substep.
  • After: warnings emitted for failed substep, but process completes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.