Software Engineering Lead
MIM Software, Inc.
Software Engineering Lead
MIM Software, Inc.
is srs bsness mode taking over? i'm in a panic :[
FWIW I patched this locally and it fixes the scenarios I've seen this issue.
After updating the task a million times I did reduce the reproduction steps to just not having the user in the Default View Policy (presumably at time of creation the creator is not in the Subscribers policy group explaining the others' scenarios. I had updated the description to note that but I chould've made that much more clear. Spaces were totally a red herring.
@phillco - Is this for like, seeing code reviews that haven't had active participation in while? So users could see what's not being reviewed and lend a hand? Under the assumption that the "most-qualified" stakeholders (or Owners?) are already reviewers/subscribers of a code change but aren't being active, how effective would others' review be?
Thanks @chad for the help and motivation~
The key ingredient is to next set the default View/Edit policy of Maniphest to the Employees group (for Default Space which user is not accessible to)
what's your policy on supporting "random" PHP snippets from "sources" into Phabricator code
What is the best way to log something to the web server logs? I've been mostly using exceptions but that's proving to be more and more cumbersome.
I tried reproducing this on my phacility instance but I couldn't. Additional steps I took to mimic my setup were:
Maybe this should've been reported on T10004?
I am seeing this too. I've not confirmed 100% but I think it has to do with Spaces:
We ran the script provided above to get an audit of at-risk files. Afterwards we upgraded our instance and the upgrade succeeded however its attempts to delete the affected files failed. The failure is due to using a local file store which is accessible to our web service account but not the phabricator phd services account (T4752). After correcting the file permissions so both accounts have appropriate access, running upgrade again doesn't seem to remove the files.
This guide should have most of the information you ask about:
Tried again with node v6.9.4 (current version of node with CentOS7), and still has same problem 😢
That's a good point about also accumulating any security notes
Asking someone who is say, 16 months behind to read 80 changelogs seems detrimental to having people keep up to date.
This is partly why I would like this -- the Upgrade / Compatibility section of changelogs is probably the only near-mandatory sections to review before upgrading (things might behave differently until you do databasey things, the way a configuration behaves has changed, etc.). My process for upgrading right now begins with reviewing the changelogs to make sure I don't miss any pre/post-intall steps, and I'd like to automate part of that if possible. For a site that's upgrading weekly this isn't a challenge, but sites that are unable to upgrade as frequently would (should?) be sifting through this stuff anyways. I think this would be part of community resources and not officially part of Phabricator.
Did I really have an extra space in the title
Different parts of the repository page may or may not load indicating error. I refreshed on the page with the commit a few times and sometimes it says the commit is missing and other times it can't load the content, and other times it can't load the paths, but sometimes it can load them.
I'm good with the current balance of the changelogs - the one thing I think would be nifty is being able to accumulate the Upgrade/Compatibility sections across changelogs, for sites that aren't able to upgrade weekly. I was considering making a script to scrape that info but haven't had a chance to sit down for it. Also it'd be relying on the changelog format to be consistent (seems to be pretty darn consistent).
I tried removing white space: nowrap; (from one of .phabricator-action-view button.phabricator-action-view-item, .phabricator-action-view-item) in the browser inspector on FF and it looks like it goes back to normal (even when expanding).
Workaround is to URL-encode the parenthesis (%29) or use the remarkup style
[Back to the Future](https://en.wikipedia.org/wiki/Starship_Troopers_(film%29) [[ https://en.wikipedia.org/wiki/Starship_Troopers_(film) | Jurassic Park ]]
One use case for "locking" a task could be:
I like the idea of a feed/panel that shows recently active objects and not the individual events, but I don't know that I have a specific use case for it now. For how I use feed I think being able to filter out commits would be a nifty plus, as those tend to pollute the feed during arc land activity (and comments in tow). I don't think I feel too strongly about it right now though, as most of my work is driven via email activity and I primarily use Feed as a means of discoverability so I can poke my head in if something sounds interesting~
Add catfacts tooltip to each application?
Not a big deal since it'll be a while before any install has enough badges for it to matter.
Ooh just kidding. Ctrl+Refresh fixed everything
In my scenario the external companies would not see eachother's tasks (separate Spaces), nor other internal items (default Space). However the developers within my company would need to see things from across multiple Spaces.
Do these dashboards contain sensitive information?
For the use-case I was trying to outline in T9501, this would be the case. We work with a handful of external companies and use Phabricator for organizing and communicating work. We also use Phabricator for our code review. Each project with external company (People, Projects, Maniphest) is organized into separate Spaces so that they are fully isolated, and we have a default space for internal use for Diffusion/Differential. Ideally when a user from Company A logs in they would land on a dashboard that shows only the Projects/Maniphest for them, while Company B user logs in and only shows the Projects/Maniphest for them.
Probably very similar or even dupe of T9501
I don't believe we've seen this pop up again. I can't be certain because right now all the log files are empty, but that means the errors went away?
You can make your own extension to Remarkup to allow auto-linking. I have one setup which I based off of P1129, P1209 which regex matches on Task-xxxx and uses the xxxx to link to our system. That works well and is sufficient for what we need.
Just tested this out with having global menu items of Create Task forms and Projects, each which are only visible based on some policy - looks to not have any issues hiding/showing based on those policies. Thanks for all this, when I get these changes into production install I'll check for feedback but I'm anticipating it will be a smoother experience for everyone.
Phrequent is a prototype application which is not supported. If you want to try it out understanding this, you must change a configuration allowing prototype applications (see config phabricator.show-prototypes), then you will be able to install the application.
Maybe my calendar setup isn't common but I usually have multiple overlapping meetings each week - I know others at the same company manage their calendar in a similar fashion.
Aha that makes sense. Thanks.
Out of curiosity, why are there "Context not available." indicators here? Am I not supposed to see R25 Secure?
Is it possible this is related to the E argument mentioned in T12071, but for arc clients?
Oh, the way I worded my original comment is confusing. I noticed the missing/unviewable panel on the homepage first then went to investigate and found error.
I just got this fatal error when trying to manage my dashboard on this install:
Adding E to variables_order seems to fix it!
cspeck@speckimac ~/S/hgtest> hg pus -r master pushing to ssh://repo-testing.code/source/hgtest/ searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files
I will give that a try. My understanding of the problem/solution here is that when prepushkey hook is invoked by mercurial, it's within an environment that contains the changes of the transaction being requested, all of that being communicated via the environment variables. When this hook runs it shells out to execute some other mercurial commands to inspect the repository it loses that environment and is no longer operating within the environment of the transaction (resulting in the error about an unknown revision which is the one being pushed). I'm not really familiar with PHP, variables_order or $_ENV. Is the E thing for variables_order something that causes sub-processes to inherit the environment?
Also I very probably meant "inline comment" and not "inline diff"
I do not have persistent chat open.
I came across a small bug with the "auto-suggest" feature. In differential I was writing an inline diff, and ended with :/ to show my face in plain ascii, and hit ⌘+enter immediately after to complete my inline diff. After typing :/ the auto-complete popped up and when I saved the draft with ⌘+enter it forever immortalized the auto-complete popup on screen with no seeming way to get rid of it (refreshing probably fixes~). I can reproduce on this install.
I've been seeing exceptions about "Can't parse an empty diff" in daemon logs, which I believe happens occasionally when merging commits and using a strategy to ignore changes from the incoming commit. This happens when merging a branch which might contain commits with similar/same changes which should not be kept due to already being resolved upstream. This results in any phabricator revisions/audits always showing the "Loading Content" when viewing in web.
Almanac's is a bit tight too
I upgraded last Friday to 2604c5af55f654d36f8db2f080b96486c4572216, so far this exception has not popped up again. I will check again later in the week.
Ah I guess it was a custom query - I checked someone else's dashboard who I know shows audits and theirs did not have the same issue as it was using a built-in one. Thanks for explaining, I can see how migrating a saved query would be difficult/impossible with no major benefits. I had never come across that type of error showing on page like that before and just wanted to check.
I upgraded to 5efbf4d74aa72c5a7d7f161ea8c5aa33ac0e3189, after which when navigating to the list of audits on dashboard I get an error:
Exception: Query "need" is unknown to application search engine "PhabricatorCommitSearchEngine"!
The dashboard panel used the "Needs Audit" query (I believe was at least based on a default query) - is that expected for this? After modifying the dashboard to use a new panel using the new "Active Audits" query the dashboard correctly shows the results.
(Upgraded from 5efbf4d74aa72c5a7d7f161ea8c5aa33ac0e3189)
Confirmed this is fixed after upgrading to 864d3984ebdb42b9a2670103ca3607342e46b7dc
Yeah that makes sense. On mobile you don't get the dash but in that scenario you're probably wanting to look at most recently activity and not so much of "what do I have to do today".
Would it be the same effort to show that there are any vs. no items needing addressed?
My first internship I was tasked with working on an application as sole developer. It started at 8.6k lines in a Main.cs file and at the end of the summer I left with it at about 15.5k. Luckily we didn't do code reviews.
hmm everything seems in order
yup it works
cats are naturally dubious so i'm not surprised
sort by awesome, descending