User Details
- User Since
- Dec 8 2014, 6:48 PM (513 w, 3 d)
- Availability
- Available
Jun 6 2023
Found two more quick issues
- Adding search results to dashboard hit an error
- Viewing the prototype calendar event failed after creating an event
May 30 2023
Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.
Fix new exception message to be phtranslated
Correct the check for an empty username
Revert addition of custom error-types
May 29 2023
One more simplification
Some simplifications
May 28 2023
I tried creating, updating, and landing a diff revision with the change to throw an exception and none of the workflows were interrupted/error'd.
Switch to using coalesce(), revert json parsing behavior change and throw exception instead, update .editorconfig
Maybe better querystring parsing
Clean up loop logic
Remove calls to phlog
May 27 2023
If you want to try to handle these cases, I think it would be reasonable to make AphrontApplicationConfiguration store the raw strings somewhere before it sends them to PhutilQueryStringParser so you don't have to copy/paste 100 lines out of readHTTPPOSTData().
But presumably we're more in "fix urlencode() and call it a day" territory here than "rewrite the whole stack to support pure passthrough for a case that probably never occurs in the wild".
I will take the fix urlencode route for now but this is good to know
May 26 2023
I probably have missed some code paths but this revision has touched a lot of files as-is
May 24 2023
Updating to verify before landing that I haven't included further changes
May 16 2023
Revert change that doesn't distinguish between invalid vs. inaccessible dashboards
Fixed another issue with user log entries
May 9 2023
Remove unnecessary function
I changed the approach from what I initially had in D21862, which was to add the PhabricatorProfileMenuItem::getDefaultName() as an abstract function and make the default implementation of getDisplayName() to read the 'name' menu property from the config.
My session expired and ran into a few more issues
I jumped the gun and updated my local arcanist to using php 8.2 which introduced the UT errors
Remove changes to profile menu files
Thank you for the thorough explanation. Yesterday I tried searching for how to dynamically add functions to classes but apparently my searching today is better~
Made suggested changes except I haven't pulled out the profile menu stuff yet.
May 8 2023
Be consistent with usage/checks
Apr 29 2023
As an example, given this code
private $name;
I was ready to suggest that after further investigation was made, recalling the "recent" refactor work of the mercurial command-with-extensions changes we looked at 😄
Gotcha. I'm going to take a swing at updating past 8.0 and see what crops up. Also thanks for the tip with PHPAST. I haven't looked too much into it other than trying to get it working on Windows a year or so back
Would this be reasonable to address with a new server-side setup check, similar to the checks for post_max_size and op_cache values?