Page MenuHomePhabricator

cspeckmim (Christopher Speck)
Xevioid

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 8 2014, 6:48 PM (513 w, 3 d)
Availability
Available

Software Engineering Lead

MIM Software, Inc.

http://www.mimsoftware.com/

{F1081352}

Recent Activity

Jun 6 2023

cspeckmim updated the diff for D21873: Addressing PHP8 incompatibilities - Diffusion, Drydock, Harbormastor.

Found two more quick issues

  • Adding search results to dashboard hit an error
  • Viewing the prototype calendar event failed after creating an event
Jun 6 2023, 2:06 AM
cspeckmim published D21873: Addressing PHP8 incompatibilities - Diffusion, Drydock, Harbormastor for review.
Jun 6 2023, 1:47 AM

May 30 2023

cspeckmim closed D21870: Address some PHP8 incompatibilities - Arcanist.
May 30 2023, 4:39 PM
cspeckmim committed rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist (authored by cspeckmim).
Address some PHP8 incompatibilities - Arcanist
May 30 2023, 4:39 PM
cspeckmim published D21870: Address some PHP8 incompatibilities - Arcanist for review.

Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.

May 30 2023, 4:26 PM
cspeckmim closed D21869: Addressing PHP8 incompatibilities - Miscellaneous.
May 30 2023, 4:06 PM
cspeckmim committed rP40b272fa51ea: Addressing PHP8 incompatibilities - Miscellaneous (authored by cspeckmim).
Addressing PHP8 incompatibilities - Miscellaneous
May 30 2023, 4:06 PM
cspeckmim closed D21872: Addressing PHP8 incompatibilities - Conduit.
May 30 2023, 3:58 PM
cspeckmim committed rPdd94e2efcfb7: Addressing PHP8 incompatibilities - Conduit (authored by cspeckmim).
Addressing PHP8 incompatibilities - Conduit
May 30 2023, 3:58 PM
cspeckmim updated the diff for D21872: Addressing PHP8 incompatibilities - Conduit.

Fix new exception message to be phtranslated

May 30 2023, 3:57 PM
cspeckmim closed D21871: Addressing some PHP8 incompatibilities - Dashboard.
May 30 2023, 3:48 PM
cspeckmim committed rP60158470d04a: Addressing some PHP8 incompatibilities - Dashboard (authored by cspeckmim).
Addressing some PHP8 incompatibilities - Dashboard
May 30 2023, 3:48 PM
cspeckmim updated the summary of D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.
May 30 2023, 3:35 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.
May 30 2023, 3:35 PM · Infrastructure
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21865: Updates for PHP 8.2 compatibility - Arcanist.
May 30 2023, 3:35 PM · Infrastructure
cspeckmim updated the summary of D21865: Updates for PHP 8.2 compatibility - Arcanist.
May 30 2023, 3:35 PM
cspeckmim updated the summary of D21866: Addressing some PHP 8 incompatibilities - Remarkup.
May 30 2023, 3:35 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21866: Addressing some PHP 8 incompatibilities - Remarkup.
May 30 2023, 3:35 PM · Infrastructure
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21868: Addressing some PHP8 incompatibilities - Misc. Applications.
May 30 2023, 3:35 PM · Infrastructure
cspeckmim updated the summary of D21868: Addressing some PHP8 incompatibilities - Misc. Applications.
May 30 2023, 3:35 PM
cspeckmim updated the summary of D21872: Addressing PHP8 incompatibilities - Conduit.
May 30 2023, 3:34 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21872: Addressing PHP8 incompatibilities - Conduit.
May 30 2023, 3:34 PM · Infrastructure
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21871: Addressing some PHP8 incompatibilities - Dashboard.
May 30 2023, 3:34 PM · Infrastructure
cspeckmim updated the summary of D21871: Addressing some PHP8 incompatibilities - Dashboard.
May 30 2023, 3:34 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21869: Addressing PHP8 incompatibilities - Miscellaneous.
May 30 2023, 3:34 PM · Infrastructure
cspeckmim updated the summary of D21869: Addressing PHP8 incompatibilities - Miscellaneous.
May 30 2023, 3:34 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21870: Address some PHP8 incompatibilities - Arcanist.
May 30 2023, 3:34 PM · Infrastructure
cspeckmim updated the diff for D21869: Addressing PHP8 incompatibilities - Miscellaneous.

Correct the check for an empty username

May 30 2023, 3:21 PM
cspeckmim planned changes to D21869: Addressing PHP8 incompatibilities - Miscellaneous.
May 30 2023, 3:19 PM
cspeckmim added inline comments to D21869: Addressing PHP8 incompatibilities - Miscellaneous.
May 30 2023, 3:19 PM
cspeckmim updated the diff for D21872: Addressing PHP8 incompatibilities - Conduit.

Revert addition of custom error-types

May 30 2023, 3:17 PM
cspeckmim planned changes to D21872: Addressing PHP8 incompatibilities - Conduit.
May 30 2023, 3:17 PM

May 29 2023

cspeckmim published D21869: Addressing PHP8 incompatibilities - Miscellaneous for review.
May 29 2023, 11:56 PM
cspeckmim published D21871: Addressing some PHP8 incompatibilities - Dashboard for review.
May 29 2023, 11:55 PM
cspeckmim published D21872: Addressing PHP8 incompatibilities - Conduit for review.
May 29 2023, 11:55 PM
cspeckmim closed D21868: Addressing some PHP8 incompatibilities - Misc. Applications.
May 29 2023, 2:41 PM
cspeckmim committed rPcf400694c717: Addressing some PHP8 incompatibilities - Misc. Applications (authored by cspeckmim).
Addressing some PHP8 incompatibilities - Misc. Applications
May 29 2023, 2:41 PM
cspeckmim added inline comments to D21868: Addressing some PHP8 incompatibilities - Misc. Applications.
May 29 2023, 1:10 PM
cspeckmim updated the summary of D21868: Addressing some PHP8 incompatibilities - Misc. Applications.
May 29 2023, 4:21 AM
cspeckmim published D21868: Addressing some PHP8 incompatibilities - Misc. Applications for review.
May 29 2023, 4:21 AM
cspeckmim closed D21865: Updates for PHP 8.2 compatibility - Arcanist.
May 29 2023, 3:57 AM
cspeckmim committed rARC34b20ec7d88d: Updates for PHP 8.2 compatibility - Arcanist (authored by cspeckmim).
Updates for PHP 8.2 compatibility - Arcanist
May 29 2023, 3:57 AM
cspeckmim closed D21867: Updates for Mercurial's HTTP protocol.
May 29 2023, 3:12 AM
cspeckmim committed rP0b6e758978a9: Updates for Mercurial's HTTP protocol (authored by cspeckmim).
Updates for Mercurial's HTTP protocol
May 29 2023, 3:12 AM
cspeckmim closed D21866: Addressing some PHP 8 incompatibilities - Remarkup.
May 29 2023, 3:12 AM
cspeckmim committed rPec9ebe532e52: Addressing some PHP 8 incompatibilities - Remarkup (authored by cspeckmim).
Addressing some PHP 8 incompatibilities - Remarkup
May 29 2023, 3:12 AM
cspeckmim closed D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.
May 29 2023, 3:10 AM
cspeckmim committed rPce3d484b0ec7: Addressing some PHP8 incompatibilities - Diffusion & Differential (authored by cspeckmim).
Addressing some PHP8 incompatibilities - Diffusion & Differential
May 29 2023, 3:10 AM
cspeckmim updated the diff for D21867: Updates for Mercurial's HTTP protocol.

One more simplification

May 29 2023, 3:08 AM
cspeckmim updated the diff for D21867: Updates for Mercurial's HTTP protocol.

Some simplifications

May 29 2023, 3:06 AM

May 28 2023

cspeckmim added a comment to D21865: Updates for PHP 8.2 compatibility - Arcanist.

I tried creating, updating, and landing a diff revision with the change to throw an exception and none of the workflows were interrupted/error'd.

May 28 2023, 11:23 PM
cspeckmim updated the diff for D21865: Updates for PHP 8.2 compatibility - Arcanist.

Switch to using coalesce(), revert json parsing behavior change and throw exception instead, update .editorconfig

May 28 2023, 11:14 PM
cspeckmim updated the diff for D21867: Updates for Mercurial's HTTP protocol.

Maybe better querystring parsing

May 28 2023, 10:51 PM
cspeckmim updated the diff for D21866: Addressing some PHP 8 incompatibilities - Remarkup.

Clean up loop logic

May 28 2023, 10:50 PM
cspeckmim updated the diff for D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.

Remove calls to phlog

May 28 2023, 10:49 PM

May 27 2023

cspeckmim planned changes to D21865: Updates for PHP 8.2 compatibility - Arcanist.
May 27 2023, 2:31 AM
cspeckmim planned changes to D21866: Addressing some PHP 8 incompatibilities - Remarkup.
May 27 2023, 2:23 AM
cspeckmim planned changes to D21867: Updates for Mercurial's HTTP protocol.

If you want to try to handle these cases, I think it would be reasonable to make AphrontApplicationConfiguration store the raw strings somewhere before it sends them to PhutilQueryStringParser so you don't have to copy/paste 100 lines out of readHTTPPOSTData().

But presumably we're more in "fix urlencode() and call it a day" territory here than "rewrite the whole stack to support pure passthrough for a case that probably never occurs in the wild".

I will take the fix urlencode route for now but this is good to know

May 27 2023, 2:20 AM
cspeckmim added a comment to D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.

The two phlog() commands introduced in error handling seem unrelated, can we strip those out of this change? Everything else looks good.

May 27 2023, 2:13 AM

May 26 2023

cspeckmim retitled D21866: Addressing some PHP 8 incompatibilities - Remarkup from Addressing some PHP 8 incompatibilities - Remarpkup to Addressing some PHP 8 incompatibilities - Remarkup.
May 26 2023, 9:03 PM
cspeckmim published D21867: Updates for Mercurial's HTTP protocol for review.
May 26 2023, 8:53 PM
cspeckmim published D21866: Addressing some PHP 8 incompatibilities - Remarkup for review.
May 26 2023, 8:11 PM
cspeckmim published D21865: Updates for PHP 8.2 compatibility - Arcanist for review.
May 26 2023, 7:55 PM
cspeckmim published D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential for review.

I probably have missed some code paths but this revision has touched a lot of files as-is

May 26 2023, 7:51 PM

May 24 2023

cspeckmim added inline comments to D21862: Addressing some PHP 8 incompatibilities.
May 24 2023, 9:32 PM
cspeckmim closed D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 24 2023, 9:11 PM
cspeckmim committed rP58995268dd97: Addressing some PHP8 incompatibilities - ProfileMenuItem (authored by cspeckmim).
Addressing some PHP8 incompatibilities - ProfileMenuItem
May 24 2023, 9:11 PM
cspeckmim closed D21862: Addressing some PHP 8 incompatibilities.
May 24 2023, 9:10 PM
cspeckmim committed rPf6214f060e78: Addressing some PHP 8 incompatibilities (authored by cspeckmim).
Addressing some PHP 8 incompatibilities
May 24 2023, 9:10 PM
cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

Updating to verify before landing that I haven't included further changes

May 24 2023, 9:09 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 24 2023, 9:07 PM · Infrastructure
cspeckmim updated the summary of D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 24 2023, 9:07 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21862: Addressing some PHP 8 incompatibilities.
May 24 2023, 9:06 PM · Infrastructure
cspeckmim updated the summary of D21862: Addressing some PHP 8 incompatibilities.
May 24 2023, 9:06 PM

May 16 2023

cspeckmim updated the diff for D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.

Revert change that doesn't distinguish between invalid vs. inaccessible dashboards

May 16 2023, 4:41 PM
cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

Fixed another issue with user log entries

May 16 2023, 4:40 PM
cspeckmim planned changes to D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 16 2023, 3:36 PM

May 9 2023

cspeckmim updated the diff for D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.

Remove unnecessary function

May 9 2023, 4:09 AM
cspeckmim added inline comments to D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 9 2023, 4:08 AM
cspeckmim added a comment to D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.

I changed the approach from what I initially had in D21862, which was to add the PhabricatorProfileMenuItem::getDefaultName() as an abstract function and make the default implementation of getDisplayName() to read the 'name' menu property from the config.

May 9 2023, 4:03 AM
cspeckmim requested review of D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 9 2023, 3:59 AM
cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

My session expired and ran into a few more issues

May 9 2023, 3:52 AM
cspeckmim added inline comments to D21862: Addressing some PHP 8 incompatibilities.
May 9 2023, 2:30 AM
cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

I jumped the gun and updated my local arcanist to using php 8.2 which introduced the UT errors

May 9 2023, 2:28 AM
cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

Remove changes to profile menu files

May 9 2023, 2:16 AM
cspeckmim planned changes to D21862: Addressing some PHP 8 incompatibilities.

Thank you for the thorough explanation. Yesterday I tried searching for how to dynamically add functions to classes but apparently my searching today is better~

May 9 2023, 1:36 AM
cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

Made suggested changes except I haven't pulled out the profile menu stuff yet.

May 9 2023, 1:29 AM
cspeckmim added inline comments to D21862: Addressing some PHP 8 incompatibilities.
May 9 2023, 1:21 AM

May 8 2023

cspeckmim updated the diff for D21862: Addressing some PHP 8 incompatibilities.

Be consistent with usage/checks

May 8 2023, 2:22 AM
cspeckmim added inline comments to D21862: Addressing some PHP 8 incompatibilities.
May 8 2023, 2:22 AM
cspeckmim retitled D21862: Addressing some PHP 8 incompatibilities from Addressing PHP 8 incompatibilities to Addressing some PHP 8 incompatibilities.
May 8 2023, 1:53 AM
cspeckmim published D21862: Addressing some PHP 8 incompatibilities for review.
May 8 2023, 1:32 AM

Apr 29 2023

cspeckmim added a comment to T13588: PHP 8 Compatibility.

As an example, given this code

private $name;
Apr 29 2023, 8:33 PM · Infrastructure
cspeckmim added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

I was ready to suggest that after further investigation was made, recalling the "recent" refactor work of the mercurial command-with-extensions changes we looked at 😄

Apr 29 2023, 7:46 PM · Infrastructure
cspeckmim added a comment to T13588: PHP 8 Compatibility.

Gotcha. I'm going to take a swing at updating past 8.0 and see what crops up. Also thanks for the tip with PHPAST. I haven't looked too much into it other than trying to get it working on Windows a year or so back

Apr 29 2023, 4:49 PM · Infrastructure
cspeckmim added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

Would this be reasonable to address with a new server-side setup check, similar to the checks for post_max_size and op_cache values?

Apr 29 2023, 2:04 PM · Infrastructure

Apr 26 2023

cspeckmim added a comment to T13588: PHP 8 Compatibility.

PHP 8.1 disallows strlen(null).
...
Broadly, Phabricator likely will not pass the empty string as a constraint in these cases...
...
D21762 introduces phutil_nonempty_string(), which is like this test but slightly stricter (it raises an exception for wonky values) and easier to revisit later (i.e., use of this function is a hint that the code can be made more strict about value types).
...
Upshot:

  • if (strlen($maybe_null)) may be replaced in all cases with if (phutil_nonempty_string($maybe_null)) to work in PHP 8.1 and not break any code which wasn't already extremely suspicious (...stringlike() may be required if the value may be an object, usually a URI object).
  • This is usually not the most desirable replacement, but probably 95% of these aren't realistically worth being surgical about.
  • In new code, prefer increasing type strictness over these more-flexible tests.
Apr 26 2023, 7:05 PM · Infrastructure

Apr 25 2023

cspeckmim closed D21861: Fix support for pk-zip compressed figlet font files.
Apr 25 2023, 8:30 PM
cspeckmim committed rPbc6f4786a2e3: Fix support for pk-zip compressed figlet font files (authored by cspeckmim).
Fix support for pk-zip compressed figlet font files
Apr 25 2023, 8:30 PM
cspeckmim retitled D21861: Fix support for pk-zip compressed figlet font files from Remove support for compressed figlet font files. to Fix support for pk-zip compressed figlet font files.
Apr 25 2023, 7:34 PM