Page MenuHomePhabricator
Differential D21441

Delete some commit dead parsing code
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 4:31 PM.
Tags
None
Referenced Files
F19083375: D21441.id51078.diff
Dec 2 2025, 12:34 PM
F19041575: D21441.diff
Nov 26 2025, 4:08 PM
F19012006: D21441.id.diff
Nov 22 2025, 11:47 AM
F18993553: D21441.id51040.diff
Nov 19 2025, 8:11 AM
F18837333: D21441.diff
Oct 27 2025, 4:55 AM
F18825009: D21441.id.diff
Oct 23 2025, 7:02 PM
F18823301: D21441.id51078.diff
Oct 23 2025, 11:14 AM
F18776331: D21441.id51040.diff
Oct 10 2025, 9:46 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP367cd289270d: Delete some commit dead parsing code
Summary

Ref T13552. Neither "$hashes" or "$user" are used, and constructing them has no side effects.

Test Plan

Searched for these symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2020, 4:31 PM
Harbormaster completed remote builds in B24855: Diff 51040.Aug 12 2020, 4:32 PM
epriestley requested review of this revision.Aug 12 2020, 4:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
Closed by commit rP367cd289270d: Delete some commit dead parsing code (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP367cd289270d: Delete some commit dead parsing code.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
commitmessageparser/
8 lines

Diff 51078

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility