When a revision has only human reviewers but none can view it, show a warning banner
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 9:21 PM.

Tags

None

Referenced Files

	F19909465: D21556.diff
	Thu, Apr 2, 12:53 AM

	F19903522: D21556.id.diff
	Tue, Mar 31, 2:03 AM

	F19843356: D21556.diff
	Mar 12 2026, 12:55 AM

	F19829005: D21556.id51316.diff
	Mar 10 2026, 12:33 AM

	F19819319: D21556.diff
	Mar 6 2026, 5:27 AM

	F19774513: D21556.id51316.diff
	Feb 21 2026, 6:09 PM

	F19502808: D21556.id51316.diff
	Jan 8 2026, 7:43 PM

	F19317369: D21556.id51308.diff
	Dec 25 2025, 5:39 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits: rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning…

Summary

Ref T13602. Warn when a reivison has at least one human reviewer, no non-human reviewers, and no human reviewers can view it.

Test Plan

Screen Shot 2021-02-13 at 1.18.47 PM.png (284×570 px, 22 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 13 2021, 9:21 PM

Harbormaster completed remote builds in B25117: Diff 51308.Feb 13 2021, 9:22 PM

epriestley requested review of this revision.Feb 13 2021, 9:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:38 PM

Closed by commit rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

24 lines

Diff 51316

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

When a revision has only human reviewers but none can view it, show a warning bannerClosedPublicActions