Page MenuHomePhabricator
Differential D21409

Remove the "Graph" view as a dedicated repository view
Needs ReviewPublic
Actions

Authored by epriestley on Fri, Jul 10, 5:56 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Summary

Ref T13552. Currently, Diffusion has two effectively identical history views, the "Graph" view and the "History" view.

These arose out of product uncertainty about the importance of the graph, but I think we can just put the graph on the "object item list" view and merge these views.

Test Plan

Looked at repositories in Diffusion, no longer saw a "Graph" tab. Grepped for "graph"-related symbols.

Diff Detail

Repository
rP Phabricator
Branch
publish6
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24771
Build 34166: Run Core Tests
Build 34165: arc lint + arc unit

Event Timeline

epriestley created this revision.Fri, Jul 10, 5:56 PM
Harbormaster completed remote builds in B24771: Diff 50952.Fri, Jul 10, 5:57 PM
epriestley requested review of this revision.Fri, Jul 10, 5:57 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
application/
1 line
controller/
14 lines
repository/
storage/
2 lines

Diff 50952

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionGraphController.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility