Page MenuHomePhabricator
Differential D21417

Unify more build, property, auditor, and status information into "CommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 7:45 PM.
Tags
None
Referenced Files
F18141185: D21417.id50962.diff
Thu, Aug 14, 6:25 AM
F18140643: D21417.id51034.diff
Thu, Aug 14, 4:12 AM
F18109446: D21417.id.diff
Mon, Aug 11, 1:40 PM
F18104020: D21417.diff
Sun, Aug 10, 9:17 AM
F18101245: D21417.diff
Sat, Aug 9, 12:23 PM
F18087533: D21417.id50962.diff
Wed, Aug 6, 4:20 AM
F17826807: D21417.diff
Sat, Jul 26, 7:38 AM
F17632542: D21417.id.diff
Jul 10 2025, 3:31 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP8aec3f916b39: Unify more build, property, auditor, and status information into…
Summary

Ref T13552. In unifying the various Graph/List/Table commit views, some information was dropped -- particularly, audit status.

Restore most of it. The result isn't very pretty, but has most of the required information.

Test Plan

Screen Shot 2020-07-12 at 12.45.12 PM.png (146×1 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 12 2020, 7:45 PM
Harbormaster completed remote builds in B24782: Diff 50962.Jul 12 2020, 7:47 PM
epriestley requested review of this revision.Jul 12 2020, 7:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
Closed by commit rP8aec3f916b39: Unify more build, property, auditor, and status information into… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8aec3f916b39: Unify more build, property, auditor, and status information into….

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
audit/
query/
3 lines
diffusion/
view/
227 lines
view/
phui/
41 lines
webroot/
rsrc/
css/
phui/
object-item/
6 lines

Diff 51034

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Phabricator · Built by Phacility