Page MenuHomePhabricator

When a commit is marked "closeable", clear the "published" flag
ClosedPublic

Authored by epriestley on Tue, Sep 8, 8:42 PM.

Details

Summary

Ref T13552. When a previously discovered commit becomes reachable from a permanent ref, we re-queue workers to update it. However, the commit may already be marked as "published", so the publish worker may do nothing.

It would perhaps be simpler to not mark the commit as published when it isn't reachable from a permanent ref, but this is tricky because the flag is also part of the "imported / all steps" state (see T13580).

Until that can be cleaned up, just clear the flag.

Test Plan
  • Pushed a commit with "fixes X" to a non-permanent branch.
  • Pushed it to a permanent branch.
  • Before change: task failed to close.
  • After change: task closes properly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 16, 12:37 AM
This revision was automatically updated to reflect the committed changes.