Page MenuHomePhabricator

Restructure Hovercards to support more context information
ClosedPublic

Authored by epriestley on Sat, Feb 13, 7:59 PM.

Details

Summary

Ref T13602. Currently, Hovercards are functions only of the object they represent (and the viewer, etc).

Recent changes to how users who can't see an object are rendered motivate making them a function of both the object they represent and the context in which they are being viewed. In particular, this enables a hovecard for a user to explain "This user can't see the thing you're lookign at right now.", so visual "exiled" markers can have a path forward toward discovery.

Test Plan
  • This change isn't expected to affect any behavior.
  • Viewed hovercards, moused over/out, resized windows, viewed standalone cards, viewed debug cards, saw no behavioral changes.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 13, 9:37 PM
This revision was automatically updated to reflect the committed changes.