Page MenuHomePhabricator

Improve desktop and mobile layouts for new "CommitGridView"
Needs ReviewPublic

Authored by epriestley on Sun, Jul 12, 9:26 PM.
This revision needs review, but there are no reviewers specified.



Ref T13552. The current layout doesn't work particularly well on desktops or devices.

We have some device/desktop table layout code, but it isn't generic. We also have property list layout code, but it isn't generic either.

Provide generic layout elements ("Fuel", from "Phabricator UI Layout" to "PHUIL"?) and narrowly specialize their display behavior. Then swap the ListItemView stuff to use it.

Test Plan

Saw slightly better responsive behavior:

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 24783
Build 34188: Run Core Tests
Build 34187: arc lint + arc unit

Event Timeline

epriestley created this revision.Sun, Jul 12, 9:26 PM
epriestley requested review of this revision.Sun, Jul 12, 9:27 PM