Page MenuHomePhabricator

Improve desktop and mobile layouts for new "CommitGridView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 3:01 PM
Unknown Object (File)
Thu, Feb 22, 2:30 PM
Unknown Object (File)
Thu, Feb 22, 2:30 PM
Unknown Object (File)
Wed, Feb 21, 3:48 PM
Unknown Object (File)
Mon, Feb 19, 7:47 AM
Unknown Object (File)
Jan 5 2024, 1:19 PM
Unknown Object (File)
Dec 27 2023, 1:35 PM
Unknown Object (File)
Dec 22 2023, 3:19 AM
Subscribers
None

Details

Summary

Ref T13552. The current layout doesn't work particularly well on desktops or devices.

We have some device/desktop table layout code, but it isn't generic. We also have property list layout code, but it isn't generic either.

Provide generic layout elements ("Fuel", from "Phabricator UI Layout" to "PHUIL"?) and narrowly specialize their display behavior. Then swap the ListItemView stuff to use it.

Test Plan

Saw slightly better responsive behavior:

Screen Shot 2020-07-12 at 2.25.14 PM.png (145×1 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.