Page MenuHomePhabricator

Improve desktop and mobile layouts for new "CommitGridView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 9:26 PM.
Tags
None
Referenced Files
F19010535: D21418.id.diff
Sat, Nov 22, 4:50 AM
F18993542: D21418.id50963.diff
Wed, Nov 19, 8:10 AM
F18954390: D21418.diff
Wed, Nov 12, 5:37 PM
F18897739: D21418.diff
Fri, Nov 7, 5:37 PM
F18837316: D21418.diff
Oct 27 2025, 4:54 AM
F18810978: D21418.id51035.diff
Oct 20 2025, 12:23 AM
F18734336: D21418.id.diff
Sep 30 2025, 10:52 PM
F18631778: D21418.diff
Sep 16 2025, 4:54 PM
Subscribers
None

Details

Summary

Ref T13552. The current layout doesn't work particularly well on desktops or devices.

We have some device/desktop table layout code, but it isn't generic. We also have property list layout code, but it isn't generic either.

Provide generic layout elements ("Fuel", from "Phabricator UI Layout" to "PHUIL"?) and narrowly specialize their display behavior. Then swap the ListItemView stuff to use it.

Test Plan

Saw slightly better responsive behavior:

Screen Shot 2020-07-12 at 2.25.14 PM.png (145×1 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.