Page MenuHomePhabricator

Turn "bypassCache" into a no-op in "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 4:17 PM
Unknown Object (File)
Tue, May 27, 10:50 AM
Unknown Object (File)
Apr 26 2025, 3:51 PM
Unknown Object (File)
Apr 25 2025, 4:19 PM
Unknown Object (File)
Apr 24 2025, 9:43 AM
Unknown Object (File)
Apr 24 2025, 1:09 AM
Unknown Object (File)
Apr 4 2025, 9:33 PM
Unknown Object (File)
Mar 31 2025, 3:36 PM
Subscribers
None

Details

Summary

Ref T13552. The internal caller for this now uses "internal.commit.search", which is always authority-reading. No legitimate external caller should rely on the behavior of "bypassCache"; no-op it to simplify behavior.

Test Plan

Called "diffusion.querycommits", saw the same data as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.