Turn "bypassCache" into a no-op in "diffusion.querycommits"
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 7:11 PM.

Tags

None

Referenced Files

	F15470317: D21447.id51081.diff
	Fri, Apr 4, 9:33 PM

	F15459736: D21447.diff
	Mon, Mar 31, 3:36 PM

	F15455755: D21447.diff
	Sun, Mar 30, 4:39 AM

	F15446818: D21447.id51081.diff
	Thu, Mar 27, 8:26 PM

	F15444543: D21447.id51081.diff
	Thu, Mar 27, 9:59 AM

	F15437232: D21447.id.diff
	Tue, Mar 25, 6:28 PM

	F15431722: D21447.id51081.diff
	Mon, Mar 24, 2:06 PM

	F15431243: D21447.diff
	Mon, Mar 24, 11:15 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits"

Summary

Ref T13552. The internal caller for this now uses "internal.commit.search", which is always authority-reading. No legitimate external caller should rely on the behavior of "bypassCache"; no-op it to simplify behavior.

Test Plan

Called "diffusion.querycommits", saw the same data as before.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2020, 7:11 PM

Harbormaster completed remote builds in B24861: Diff 51046.Aug 12 2020, 7:12 PM

epriestley requested review of this revision.Aug 12 2020, 7:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM

Closed by commit rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits".

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryCommitsConduitAPIMethod.php

35 lines

Diff 51081

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Turn "bypassCache" into a no-op in "diffusion.querycommits"ClosedPublicActions