Page MenuHomePhabricator

Turn "bypassCache" into a no-op in "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:11 PM.
Tags
None
Referenced Files
F18206637: D21447.id51046.diff
Mon, Aug 18, 4:04 PM
F18119712: D21447.id51081.diff
Wed, Aug 13, 10:07 AM
F18105238: D21447.id.diff
Sun, Aug 10, 5:04 PM
F18101263: D21447.diff
Sat, Aug 9, 12:24 PM
F18100155: D21447.diff
Sat, Aug 9, 11:28 AM
Unknown Object (File)
Jul 4 2025, 4:45 PM
Unknown Object (File)
May 28 2025, 4:17 PM
Unknown Object (File)
May 27 2025, 10:50 AM
Subscribers
None

Details

Summary

Ref T13552. The internal caller for this now uses "internal.commit.search", which is always authority-reading. No legitimate external caller should rely on the behavior of "bypassCache"; no-op it to simplify behavior.

Test Plan

Called "diffusion.querycommits", saw the same data as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.