Page MenuHomePhabricator

Turn "bypassCache" into a no-op in "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:11 PM.

Details

Summary

Ref T13552. The internal caller for this now uses "internal.commit.search", which is always authority-reading. No legitimate external caller should rely on the behavior of "bypassCache"; no-op it to simplify behavior.

Test Plan

Called "diffusion.querycommits", saw the same data as before.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 16, 12:36 AM
This revision was automatically updated to reflect the committed changes.