Page MenuHomePhabricator

Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes
ClosedPublic

Authored by epriestley on Sep 16 2020, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 17, 1:53 PM
Unknown Object (File)
Jun 16 2022, 4:45 AM
Unknown Object (File)
May 29 2022, 1:59 AM
Unknown Object (File)
May 26 2022, 7:14 PM
Unknown Object (File)
May 26 2022, 11:26 AM
Unknown Object (File)
May 23 2022, 4:31 AM
Subscribers
None

Details

Summary

Ref T13581. If you query for revisions by hash and provide multiple hashes (A, B) which match a single revision (e.g., older and newer diffs for that revision), the query omits a GROUP BY clause but should contain one.

Add a GROUP BY clause in this case.

Test Plan

With a working copy that has multiple hashes corresponding to a single revision, ran arc branches before and after the change. Before, got this error:

[2020-09-15 17:02:07] EXCEPTION: (ConduitClientException) ERR-CONDUIT-CORE: Rows passed to "loadAllFromArray(...)" include two or more rows with the same ID ("130"). Rows must have unique IDs. An underlying query may be missing a GROUP BY. at [<arcanist>/src/conduit/ConduitFuture.php:65]

After, clean execution.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable