Page MenuHomePhabricator
Differential D21449

Make "CommitData" wrap and persist a "CommitRef" record
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 8:02 PM.
Tags
None
Referenced Files
F17636887: D21449.id51048.diff
Fri, Jul 11, 12:33 PM
F17634420: D21449.id.diff
Thu, Jul 10, 11:07 PM
F17614107: D21449.diff
Wed, Jul 9, 12:31 PM
Unknown Object (File)
Thu, Jul 3, 1:13 PM
Unknown Object (File)
Jun 13 2025, 4:53 PM
Unknown Object (File)
Jun 1 2025, 7:38 PM
Unknown Object (File)
May 29 2025, 9:00 PM
Unknown Object (File)
May 28 2025, 7:47 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record
Summary

Ref T13552. Turn "CommitData" into an application-level layer on top of the repository-level "CommitRef" object.

For older commits which will not have a "CommitRef" record on disk, build a synthetic one at runtime. This could eventually be migrated.

Test Plan

Ran "bin/repository reparse --message", browsed Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2020, 8:02 PM
Harbormaster completed remote builds in B24863: Diff 51048.Aug 12 2020, 8:03 PM
epriestley requested review of this revision.Aug 12 2020, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
Closed by commit rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
data/
4 lines
repository/
storage/
5 lines
57 lines
worker/
20 lines
commitmessageparser/
46 lines

Diff 51085

View Options

src/applications/diffusion/data/DiffusionCommitRef.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility