Page MenuHomePhabricator
Differential D21557

Add a PHID to Changesets
ClosedPublic
Actions

Authored by epriestley on Feb 15 2021, 6:13 PM.
Tags
None
Referenced Files
F18993603: D21557.id51317.diff
Wed, Nov 19, 8:12 AM
F18752278: D21557.id.diff
Oct 4 2025, 2:43 PM
F18734393: D21557.id.diff
Sep 30 2025, 10:53 PM
F18672637: D21557.id51320.diff
Sep 25 2025, 7:58 AM
F18599583: D21557.id.diff
Sep 13 2025, 7:45 AM
F18592266: D21557.diff
Sep 12 2025, 11:50 AM
F18587699: D21557.id51320.diff
Sep 11 2025, 10:08 PM
F18586778: D21557.diff
Sep 11 2025, 7:41 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13605: Implement a "differential.changeset.search" API method
Commits
rPec5476a01f5f: Add a PHID to Changesets
Summary

Ref T13605. Changesets currently have no PHID, which limits their ability to use standard API infrastructure.

Give them a PHID, since there's no reason they don't have one other than their age.

Test Plan
  • Ran migrations, saw PHIDs populated.
  • Created new changesets, saw PHIDs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 15 2021, 6:13 PM
Owners added a subscriber: Restricted Owners Package.Feb 15 2021, 6:13 PM
Harbormaster completed remote builds in B25127: Diff 51317.Feb 15 2021, 6:15 PM
epriestley requested review of this revision.Feb 15 2021, 6:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2021, 7:11 PM
Closed by commit rPec5476a01f5f: Add a PHID to Changesets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPec5476a01f5f: Add a PHID to Changesets.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
26 lines
src/
applications/
differential/
phid/
41 lines
storage/
5 lines

Diff 51320

View Options

resources/sql/autopatches/20210215.changeset.01.phid.sql

Loading...
View Options

resources/sql/autopatches/20210215.changeset.02.phid-populate.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/phid/DifferentialChangesetPHIDType.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
Phabricator · Built by Phacility