Bug ReportBugs
ActivePublic

Details

Description

This task was filed via the "New Bug Report" form.

Recent Activity

Today

epriestley added a revision to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: D18160: Move 'set' config option type to new structure.
Mon, Jun 26, 5:27 PM · Bug Report
epriestley added a revision to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: D18159: Convert 'class' config options to new validation.
Mon, Jun 26, 5:15 PM · Bug Report
epriestley added a revision to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: D18158: Convert "bool" config values to new modular system.
Mon, Jun 26, 4:57 PM · Bug Report
epriestley added a revision to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: D18157: Convert the "list<string>" and "list<regex>" Config option types.
Mon, Jun 26, 4:34 PM · Bug Report
epriestley added a revision to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: D18156: Convert "enum" and "string" config options to new modular option types.
Mon, Jun 26, 4:08 PM · Bug Report
epriestley added a revision to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: D18155: Begin modularizing config options in a more modern way.
Mon, Jun 26, 3:52 PM · Bug Report
epriestley added a subtask for T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default: T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Mon, Jun 26, 2:04 PM · Bug Report
epriestley added a parent task for T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default.
Mon, Jun 26, 2:04 PM · Maniphest, Bug Report
epriestley lowered the priority of T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out from Normal to Low.

For private reasons affecting the reporting install, this no longer has customer impact.

Mon, Jun 26, 2:02 PM · Policy, Profile Menu Item, Dashboards, Bug Report

Fri, Jun 23

epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

That sounds like a bug, but my guess is that the investigation would probably turn up "wow you are dumb at writing software" in about 3 minutes and not really get us much closer to a fix, which is probably "rewrite arc patch to fix 200 problems".

Fri, Jun 23, 11:40 PM · Arcanist, Mercurial, Bug Report
cspeckmim added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

Also, I've noticed that when applying dependent revisions like this, it seems that usually all of the commits will apply cleanly (without prompting) except for the last one, which will always fail to locate the commit to apply on and prompt whether to apply to current working copy state. Based on what I think arcanist is doing I would expect all patches to prompt whether to apply to working copy (since all patches will be given new commit IDs) -- it seems strange that all will apply cleanly except the last one. Does that sound like a bug or am I misunderstanding what's happening? I can try to investigate/debug if you think it might be a bug.

Fri, Jun 23, 11:37 PM · Arcanist, Mercurial, Bug Report
epriestley added a commit to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out: rPa19859053300: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:31 PM · Policy, Profile Menu Item, Dashboards, Bug Report
epriestley closed T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Resolved by committing rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched….
Fri, Jun 23, 7:29 PM · Feed, Bug Report
epriestley triaged T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Normal priority.
Fri, Jun 23, 7:16 PM · Policy, Profile Menu Item, Dashboards, Bug Report
epriestley added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

D18152 should improve this: we'll still select the item as the default item, but will now render the navigation normally so the user can click other items:

Fri, Jun 23, 7:15 PM · Policy, Profile Menu Item, Dashboards, Bug Report
epriestley added a revision to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out: D18152: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:11 PM · Policy, Profile Menu Item, Dashboards, Bug Report
epriestley claimed T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Fri, Jun 23, 6:59 PM · Policy, Profile Menu Item, Dashboards, Bug Report
xp500 created T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Fri, Jun 23, 6:56 PM · Policy, Profile Menu Item, Dashboards, Bug Report
epriestley renamed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities from Prioritys are wrong to Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Fri, Jun 23, 6:20 PM · Maniphest, Bug Report
epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

Specifically, the issue is that multiple different priorities used the same keywords ("low", "high").

Fri, Jun 23, 6:19 PM · Maniphest, Bug Report
Luke081515.2 added a project to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: Maniphest.
Fri, Jun 23, 5:36 PM · Maniphest, Bug Report
Luke081515.2 added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

This looks like the update changed the behaviour, not sure if this is intended, but it broke configs, that worked before. I currently fixed this by chaning my config to:

{
  "100": {
    "name": "Unbreak Now!",
    "short": "Unbreak!",
    "color": "pink",
    "keywords": [
      "unbreak"
    ]
  },
  "90": {
    "name": "Needs Triage",
    "short": "Triage",
    "color": "violet",
    "keywords": [
      "triage"
    ]
  },
  "80": {
    "name": "High",
    "short": "High",
    "color": "red",
    "keywords": [
      "high"
    ]
  },
  "70": {
    "name": "Higher than normal",
    "short": "Higher than normal",
    "color": "orange",
    "keywords": [
      "high-than-normal"
    ]
  },
  "50": {
    "name": "Normal",
    "short": "Normal",
    "color": "yellow",
    "keywords": [
      "normal"
    ]
  },
  "25": {
    "name": "Lower than normal",
    "short": "Lower than normal",
    "color": "green",
    "keywords": [
      "lower-than-normal"
    ]
  },
  "1": {
    "name": "Low",
    "short": "Low",
    "color": "sky",
    "keywords": [
      "low"
    ]
  },
  "0": {
    "name": "Wishlist",
    "short": "Wishlist",
    "color": "skyblue",
    "keywords": [
      "wishlist"
    ]
  }
}
Fri, Jun 23, 5:34 PM · Maniphest, Bug Report
Luke081515.2 added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

I was able to track this down: This is happening since rP8008ade9af46: Use keywords instead of ints to update task priority in ManiphestEditEngine.

Fri, Jun 23, 5:30 PM · Maniphest, Bug Report
Luke081515.2 created T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Fri, Jun 23, 5:30 PM · Maniphest, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

(That is, our behavior seems clearly incorrect.)

Fri, Jun 23, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

This just looks unambiguously wrong to me.

Fri, Jun 23, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default.

I'm going to modularize this, but not before the release cut.

Fri, Jun 23, 4:48 PM · Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I can verify this fixes it! Thanks for this guys.

Fri, Jun 23, 4:47 PM · Remarkup, Bug Report
epriestley triaged T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Low priority.

(I think D18132 should fix this once someone gets a chance to look at it.)

Fri, Jun 23, 4:22 PM · Feed, Bug Report
epriestley added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

This should now be fixed in HEAD of master, and promote to stable within about 12 hours. Thanks for the report! Let us know if you run into anything else.

Fri, Jun 23, 3:43 PM · Remarkup, Bug Report
epriestley closed T12867: Youtube remarkup rule fails to parse "ambiguous URI" as Resolved by committing rP988a52cf1acd: Fix ambiguous URI parsing in Youtube Remarkup rule.
Fri, Jun 23, 3:43 PM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I’m fine waiting for the fix. Thanks @epriestley

Fri, Jun 23, 3:42 PM · Remarkup, Bug Report
epriestley added a revision to T12867: Youtube remarkup rule fails to parse "ambiguous URI": D18149: Fix ambiguous URI parsing in Youtube Remarkup rule.
Fri, Jun 23, 2:37 PM · Remarkup, Bug Report
epriestley renamed T12867: Youtube remarkup rule fails to parse "ambiguous URI" from Daemon fails to parse "ambiguous URI" to Youtube remarkup rule fails to parse "ambiguous URI".
Fri, Jun 23, 2:30 PM · Remarkup, Bug Report
epriestley claimed T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I think a minimal reproduction case which is typical of this example is:

Fri, Jun 23, 1:35 PM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

Looks to be just the presence of the "?" in the text

Fri, Jun 23, 6:47 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

"XXX://123456 XXX XXX XXX://123456 XXX XXX"

Fri, Jun 23, 6:47 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

You and me both. I am super confused.

Fri, Jun 23, 6:46 AM · Remarkup, Bug Report
chad added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

Well the stack trace says "PhabricatorYoutubeRemarkupRule", so I'm confused what the issue is.

Fri, Jun 23, 6:44 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

LOL @chad Literally reproduced this issue here by trying to paste the above line without the back ticks

Fri, Jun 23, 6:42 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I'm not sure how without giving you the entire commit message which I cannot. I think key would be a having a commit with a line (probably the first one) that looks like this "XXX://123456 XXX XXX XXX? XXX://123456 XXX XXX XXX"

Fri, Jun 23, 6:42 AM · Remarkup, Bug Report
chad added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

How can we reproduce this issue locally?

Fri, Jun 23, 6:18 AM · Remarkup, Bug Report
jcarrillo7 updated subscribers of T12867: Youtube remarkup rule fails to parse "ambiguous URI".
Fri, Jun 23, 6:13 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

There also seems like there may be an issue with the current parsing logic since the "detected URI" has spaces which I do not think are valid in a uri and it should have been detected as two separate URI's with some stuff in the middle.

Fri, Jun 23, 6:12 AM · Remarkup, Bug Report
jcarrillo7 added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

The URI that is ambiguous is a URI to a company App on MacOS. The only part of the URI that matters is the xxx://123456. The rest is just the title of the item referenced by this URI and this title contains a "?" which mixed with T12526 may be causing this issue. There may also be a place you now need to catch exceptions thanks to URI parsing logic changes. Just guessing here from what I can tell in the code.

Fri, Jun 23, 6:07 AM · Remarkup, Bug Report
jcarrillo7 created T12867: Youtube remarkup rule fails to parse "ambiguous URI".
Fri, Jun 23, 5:57 AM · Remarkup, Bug Report

Thu, Jun 22

epriestley closed T12860: Search by tag does not work in Phriction as Resolved by committing rP519bec3e6f36: Make searching by tags work in Phriction.
Thu, Jun 22, 6:01 PM · Phriction, Bug Report
epriestley added a revision to T12860: Search by tag does not work in Phriction: D18145: Make searching by tags work in Phriction.
Thu, Jun 22, 5:26 PM · Phriction, Bug Report
chad added a comment to T12863: adasdasdasdasd.

nyancat

Thu, Jun 22, 7:12 AM · Feature Request (Needs Information), Bug Report
avivey closed T12863: adasdasdasdasd as Spite.
Thu, Jun 22, 6:46 AM · Feature Request (Needs Information), Bug Report