Bug ReportBugs
ArchivedPublic

Watchers

  • This project does not have any watchers.

Details

Description

This task was filed via the "New Bug Report" form.

Recent Activity

Wed, Feb 21

epriestley moved T10635: Loading differential revision slow when lots of unit test messages exist from Backlog to Logs / Unit Logs on the Harbormaster board.
Wed, Feb 21, 2:40 PM · Restricted Project, Haskell.org, Harbormaster, Performance, Bug Report

Fri, Feb 16

epriestley added a commit to T12907: Unable to download large files through alternative file domain: rPHUe1f7cfefe880: Provide a streaming HTTP response parser.
Fri, Feb 16, 7:09 PM · Bug Report
epriestley added a commit to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: rPHU9f49d4ed21f1: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Fri, Feb 16, 7:08 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

D19111 doesn't fix this in the general case, but should produce the desired behavior for most inputs such that the input is in the form [x](y) and y is the URI of a Wikipedia article.

Fri, Feb 16, 7:07 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

The intent isn't unambiguous in the general case, consider: Blah blah (see also [x](y)).

Fri, Feb 16, 7:06 PM · Remarkup, Bug Report
epriestley added a revision to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: D19111: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Fri, Feb 16, 7:05 PM · Remarkup, Bug Report
epriestley merged T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Fri, Feb 16, 6:28 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Ah thanks!

Fri, Feb 16, 6:23 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

The non-bold ones also open in a new tab.

Fri, Feb 16, 6:20 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Oh! Yes. Sort of.

Fri, Feb 16, 6:17 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Just curious, but is the bold effect intentional in the "No Encoding Relative" scenario?

Fri, Feb 16, 5:57 PM · Phriction, Remarkup, Bug Report
epriestley closed T12344: Relative links to Phriction pages misinterprets URL-encoded characters as Resolved by committing rPb8bb4d3ad590: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/"….
Fri, Feb 16, 5:55 PM · Phriction, Remarkup, Bug Report
epriestley closed T10969: Incorrect Phriction link in email as Resolved by committing rPbfdc9411f705: Provide context objects for remarkup mail rendering, fixing Phriction relative….
Fri, Feb 16, 5:55 PM · Phriction, Bug Report
epriestley added a revision to T12344: Relative links to Phriction pages misinterprets URL-encoded characters: D19106: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/" Phriction document.
Fri, Feb 16, 2:44 PM · Phriction, Remarkup, Bug Report
epriestley added a revision to T10969: Incorrect Phriction link in email: D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email.
Fri, Feb 16, 1:18 PM · Phriction, Bug Report

Wed, Feb 14

epriestley moved T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Backlog to Next on the Phriction board.
Wed, Feb 14, 2:43 PM · Phriction, Remarkup, Bug Report
epriestley moved T10969: Incorrect Phriction link in email from Backlog to Next on the Phriction board.
Wed, Feb 14, 2:33 PM · Phriction, Bug Report
epriestley moved T12793: Unable to move Phriction documents from Backlog to Next on the Phriction board.
Wed, Feb 14, 2:31 PM · Customer Impact, Bug Report, Phriction

Tue, Feb 13

epriestley closed T10559: Lease Working Copy Hangs on lease failure, but should fail as Resolved.

After changes T13073, I am no longer able to reproduce this. That task has made some improvements and may have fixed whatever happened here.

Tue, Feb 13, 4:03 PM · Drydock, Bug Report

Sun, Feb 11

epriestley closed T12714: `differential.createcomment` can race automatic revision closure as Resolved by committing rP653bc0fa019f: Read lock all transaction edits.
Sun, Feb 11, 4:07 AM · Transactions, Bug Report, Restricted Project
epriestley added a revision to T12714: `differential.createcomment` can race automatic revision closure: D19059: Read lock all transaction edits.
Sun, Feb 11, 2:05 AM · Transactions, Bug Report, Restricted Project
epriestley added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

It isn't currently retroactive: the fix is in transition logic and the transition just didn't trigger before.

Sun, Feb 11, 12:41 AM · Restricted Project, Harbormaster, Bug Report
swisspol added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

Is this retroactive to builds in this half state prior to this commit and
deploy?

Sun, Feb 11, 12:17 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T10746: Aborted build in Harbormaster still shows as building in Diffusion as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Sun, Feb 11, 12:08 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T11154: Build results don't always get conferred to their buildable as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Sun, Feb 11, 12:08 AM · Restricted Project, Harbormaster, Bug Report

Sat, Feb 10

epriestley added a revision to T11154: Build results don't always get conferred to their buildable: D19055: When a build is aborted, fail the buildable.
Sat, Feb 10, 7:38 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: D19055: When a build is aborted, fail the buildable.
Sat, Feb 10, 7:38 PM · Restricted Project, Harbormaster, Bug Report

Thu, Feb 8

epriestley closed T11389: Object links merged in plain text email as Resolved by committing rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>".
Thu, Feb 8, 5:52 PM · Remarkup, Bug Report, Mail
epriestley added a comment to T11389: Object links merged in plain text email.

D19032 now renders D123 in text contexts (plaintext email) as D123 <https://dev.tyrellcorp.com/D123> instead of https://dev.tyrellcorp.com/D123.

Thu, Feb 8, 5:51 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T11389: Object links merged in plain text email: D19032: Render object remarkup references in a text context as "Dxxx <uri>".
Thu, Feb 8, 5:50 PM · Remarkup, Bug Report, Mail
epriestley moved T11389: Object links merged in plain text email from Backlog to Stamps/Failover on the Mail board.
Thu, Feb 8, 5:50 PM · Remarkup, Bug Report, Mail
epriestley closed T10189: Differential email headers seem to be missing as Resolved by committing rP6186f0aa91b6: Briefly document mail stamps and remove obsolete header documentation.
Thu, Feb 8, 5:31 PM · Differential, Mail, Bug Report
epriestley added a comment to T10189: Differential email headers seem to be missing.

D19030 marks this as fixed: it removes this documentation.

Thu, Feb 8, 5:23 PM · Differential, Mail, Bug Report
epriestley moved T10189: Differential email headers seem to be missing from v3 to Stamps/Failover on the Mail board.
Thu, Feb 8, 5:21 PM · Differential, Mail, Bug Report
epriestley added a revision to T10189: Differential email headers seem to be missing: D19030: Briefly document mail stamps and remove obsolete header documentation.
Thu, Feb 8, 5:21 PM · Differential, Mail, Bug Report
epriestley closed T12689: Mail is still received after resigning from a revision as Resolved by committing rP1cd3a593784a: When users resign from revisions, stop expanding projects/packages to include….
Thu, Feb 8, 2:29 PM · Mail, Differential, Bug Report
epriestley closed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place as Resolved by committing rPdbe479f0d9de: Don't send error/exception mail to unverified addresses.
Thu, Feb 8, 2:26 PM · Mail, Bug Report

Wed, Feb 7

epriestley added a revision to T12644: Emoji autocomplete ordering doesn't follow unicode standards: D19023: Improve handling of skin tone variant emoji.
Wed, Feb 7, 6:53 PM · Remarkup, Bug Report
epriestley added a revision to T12689: Mail is still received after resigning from a revision: D19021: When users resign from revisions, stop expanding projects/packages to include them.
Wed, Feb 7, 4:08 PM · Mail, Differential, Bug Report
epriestley added a revision to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place: D19018: Don't send error/exception mail to unverified addresses.
Wed, Feb 7, 1:18 PM · Mail, Bug Report
tolbrino added a comment to T10725: Can't access binary files of differential revision.

I've been running into the same issue for a while now. Using the Default Policy set to Subscribers for Files works well when adding files to Phriction pages and Maniphest tickets. However, when adding binary files as part of a Diff the creator of that Diff needs to change each files permissions by hand before a reviewer can download the Diff. Moreover, this needs to be repeated for every new version of that Diff.

Wed, Feb 7, 8:58 AM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19011: Provide a streaming HTTP response parser.
Wed, Feb 7, 12:14 AM · Bug Report

Sun, Feb 4

epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Sun, Feb 4, 3:01 PM · Diffusion, Bug Report

Fri, Feb 2

ofbeaton added a comment to T12359: Registration does not accept valid email addresses.

We have also found legitimate users who have valid email addresses (Irish users) that are not accepted.

Fri, Feb 2, 8:35 PM · Bug Report
ofbeaton added a comment to T12718: Local email validation with apostrophe.

For those visiting from the future via search, I have decided to publish an unofficial bug patch in a github repo, as it breaks once in awhile due to upstream changes.

Fri, Feb 2, 8:31 PM · Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

Thanks @mcorteel, I'll take a look.

Fri, Feb 2, 5:01 PM · Arcanist, Bug Report

Thu, Feb 1

epriestley closed T11138: mail is not delivered if metamta.placeholder-to-recipient is null as Invalid.

This report doesn't include working reproduction instructions so we can't move forward.

Thu, Feb 1, 10:58 PM · Mail, Bug Report
epriestley closed T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part as Resolved.

I can't reproduce this; it may have been fixed by D18776 + D18778.

Thu, Feb 1, 10:54 PM · Mail, Bug Report
mcorteel added a comment to T12785: Arc unit command fails with PHPUnit 6.

@cmmata here is my diff. It can probably be improved, but it works for me:

1diff --git a/src/unit/engine/PhpunitTestEngine.php b/src/unit/engine/PhpunitTestEngine.php
2index 8206b787..ef01fda4 100644
3--- a/src/unit/engine/PhpunitTestEngine.php
4+++ b/src/unit/engine/PhpunitTestEngine.php
5@@ -52,7 +52,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
6​ if (!Filesystem::pathExists($test_path)) {
7​ continue;
8​ }
9- $json_tmp = new TempFile();
10+ $xml_tmp = new TempFile();
11​ $clover_tmp = null;
12​ $clover = null;
13​ if ($this->getEnableCoverage() !== false) {
14@@ -64,10 +64,10 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
15
16​ $stderr = '-d display_errors=stderr';
17
18- $futures[$test_path] = new ExecFuture('%C %C %C --log-json %s %C %s',
19- $this->phpunitBinary, $config, $stderr, $json_tmp, $clover, $test_path);
20+ $futures[$test_path] = new ExecFuture('%C %C %C --log-junit %s %C %s',
21+ $this->phpunitBinary, $config, $stderr, $xml_tmp, $clover, $test_path);
22​ $tmpfiles[$test_path] = array(
23- 'json' => $json_tmp,
24+ 'xml' => $xml_tmp,
25​ 'clover' => $clover_tmp,
26​ );
27​ }
28@@ -81,7 +81,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
29
30​ $results[] = $this->parseTestResults(
31​ $test,
32- $tmpfiles[$test]['json'],
33+ $tmpfiles[$test]['xml'],
34​ $tmpfiles[$test]['clover'],
35​ $stderr);
36​ }
37@@ -90,17 +90,17 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
38​ }
39
40​ /**
41- * Parse test results from phpunit json report.
42+ * Parse test results from phpunit XML report.
43​ *
44​ * @param string $path Path to test
45- * @param string $json_tmp Path to phpunit json report
46+ * @param string $xml_tmp Path to phpunit XML report
47​ * @param string $clover_tmp Path to phpunit clover report
48​ * @param string $stderr Data written to stderr
49​ *
50​ * @return array
51​ */
52- private function parseTestResults($path, $json_tmp, $clover_tmp, $stderr) {
53- $test_results = Filesystem::readFile($json_tmp);
54+ private function parseTestResults($path, $xml_tmp, $clover_tmp, $stderr) {
55+ $test_results = Filesystem::readFile($xml_tmp);
56​ return id(new ArcanistPhpunitTestResultParser())
57​ ->setEnableCoverage($this->getEnableCoverage())
58​ ->setProjectRoot($this->projectRoot)
59diff --git a/src/unit/parser/ArcanistPhpunitTestResultParser.php b/src/unit/parser/ArcanistPhpunitTestResultParser.php
60index 5ccff970..3d7fcd77 100644
61--- a/src/unit/parser/ArcanistPhpunitTestResultParser.php
62+++ b/src/unit/parser/ArcanistPhpunitTestResultParser.php
63@@ -9,10 +9,10 @@
64​ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
65
66​ /**
67- * Parse test results from phpunit json report
68+ * Parse test results from phpunit XML report
69​ *
70​ * @param string $path Path to test
71- * @param string $test_results String containing phpunit json report
72+ * @param string $test_results String containing phpunit XML report
73​ *
74​ * @return array
75​ */
76@@ -25,7 +25,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
77​ return array($result);
78​ }
79
80- $report = $this->getJsonReport($test_results);
81+ $report = simplexml_load_string($test_results);
82
83​ // coverage is for all testcases in the executed $path
84​ $coverage = array();
85@@ -36,56 +36,36 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
86​ $last_test_finished = true;
87
88​ $results = array();
89- foreach ($report as $event) {
90- switch (idx($event, 'event')) {
91- case 'test':
92- break;
93- case 'testStart':
94- $last_test_finished = false;
95- // fall through
96- default:
97- continue 2; // switch + loop
98- }
99-
100+ foreach ($report->testsuite as $test_suite) {
101​ $status = ArcanistUnitTestResult::RESULT_PASS;
102​ $user_data = '';
103
104- if ('fail' == idx($event, 'status')) {
105+ if ((int)$test_suite['failures'] > 0) {
106​ $status = ArcanistUnitTestResult::RESULT_FAIL;
107- $user_data .= idx($event, 'message')."\n";
108- foreach (idx($event, 'trace') as $trace) {
109- $user_data .= sprintf(
110- "\n%s:%s",
111- idx($trace, 'file'),
112- idx($trace, 'line'));
113+ foreach ($test_suite->testcase as $test_case) {
114+ foreach ($test_case->failure as $failure) {
115+ $user_data .= sprintf(
116+ "\n%s",
117+ (string)$failure);
118+ }
119​ }
120- } else if ('error' == idx($event, 'status')) {
121- if (strpos(idx($event, 'message'), 'Skipped Test') !== false) {
122- $status = ArcanistUnitTestResult::RESULT_SKIP;
123- $user_data .= idx($event, 'message');
124- } else if (strpos(
125- idx($event, 'message'),
126- 'Incomplete Test') !== false) {
127- $status = ArcanistUnitTestResult::RESULT_SKIP;
128- $user_data .= idx($event, 'message');
129- } else {
130- $status = ArcanistUnitTestResult::RESULT_BROKEN;
131- $user_data .= idx($event, 'message');
132- foreach (idx($event, 'trace') as $trace) {
133- $user_data .= sprintf(
134- "\n%s:%s",
135- idx($trace, 'file'),
136- idx($trace, 'line'));
137+ } else if ($test_suite['errors'] > 0) {
138+ $status = ArcanistUnitTestResult::RESULT_BROKEN;
139+ foreach ($test_suite->testcase as $test_case) {
140+ foreach ($test_case->error as $error) {
141+ $user_data .= sprintf(
142+ "\n%s",
143+ (string)$error);
144​ }
145​ }
146​ }
147
148- $name = preg_replace('/ \(.*\)/s', '', idx($event, 'test'));
149+ $name = preg_replace('/ \(.*\)/s', '', $test_suite['name']);
150
151​ $result = new ArcanistUnitTestResult();
152​ $result->setName($name);
153​ $result->setResult($status);
154- $result->setDuration(idx($event, 'time'));
155+ $result->setDuration((float)$test_suite['time']);
156​ $result->setCoverage($coverage);
157​ $result->setUserData($user_data);
158
159@@ -95,7 +75,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
160
161​ if (!$last_test_finished) {
162​ $results[] = id(new ArcanistUnitTestResult())
163- ->setName(idx($event, 'test')) // use last event
164+ ->setName($test_suite['name']) // use last event
165​ ->setUserData($this->stderr)
166​ ->setResult(ArcanistUnitTestResult::RESULT_BROKEN);
167​ }
168@@ -161,28 +141,4 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
169​ return $reports;
170​ }
171
172- /**
173- * We need this non-sense to make json generated by phpunit
174- * valid.
175- *
176- * @param string $json String containing JSON report
177- * @return array JSON decoded array
178- */
179- private function getJsonReport($json) {
180-
181- if (empty($json)) {
182- throw new Exception(
183- pht(
184- 'JSON report file is empty, it probably means that phpunit '.
185- 'failed to run tests. Try running %s with %s option and then run '.
186- 'generated phpunit command yourself, you might get the answer.',
187- 'arc unit',
188- '--trace'));
189- }
190-
191- $json = preg_replace('/}{\s*"/', '},{"', $json);
192- $json = '['.$json.']';
193- return phutil_json_decode($json);
194- }
195-
196​ }

Thu, Feb 1, 11:00 AM · Arcanist, Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

@mcorteel I have the same problem, arc unit only works with phpunit 5.7. If I use 6.5, it fails. Do you have that patch anywhere with public access so we can use it while it's not published?

Thu, Feb 1, 9:47 AM · Arcanist, Bug Report