Page MenuHomePhabricator
Differential D21414

Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 4:25 PM.
Tags
None
Referenced Files
F15417000: D21414.diff
Thu, Mar 20, 2:44 PM
F15375043: D21414.id50959.diff
Wed, Mar 12, 9:22 PM
F15339080: D21414.diff
Sun, Mar 9, 2:16 PM
F15334748: D21414.diff
Sat, Mar 8, 11:49 AM
F15331783: D21414.id.diff
Fri, Mar 7, 1:39 PM
F15331713: D21414.id50959.diff
Fri, Mar 7, 12:57 PM
F15291798: D21414.id51031.diff
Wed, Mar 5, 1:14 AM
Unknown Object (File)
Feb 9 2025, 9:46 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
Summary

Ref T13552.

Currently, the "Browse" page shows a snippet of unmerged changes if you're looking at a non-default branch. Remove this for consistency with the simplified main "Browse" page. This is reachable via "Compare".

Update the "Compare" page to use the new "CommitGraphView".

Test Plan
  • Looked at the "Browse" page of "stable".
  • Looked at the "Compare" page for "stable vs master".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 12 2020, 4:25 PM
Harbormaster completed remote builds in B24779: Diff 50959.Jul 12 2020, 4:26 PM
epriestley requested review of this revision.Jul 12 2020, 4:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:00 PM
Closed by commit rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".

Revision Contents
Changeset List

Diff 51031

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCompareController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryView.php

Loading...
Phabricator · Built by Phacility