Fix a view fatal in CommitGraphView when commits are undiscovered
ClosedPublic
Actions

Authored by epriestley on Sep 8 2020, 7:55 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered

Summary

This condition is flipped and can fatal by passing a NULL value for $commit to a typehinted method.

Test Plan

Viewed history page with undiscovered commits.

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Sep 8 2020, 7:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

diffusion/

view/

2 lines