Page MenuHomePhabricator

Improve rendering behavior for "foist upon" with an empty tokenizer
ClosedPublic

Authored by epriestley on Mar 4 2021, 12:01 AM.
Tags
None
Referenced Files
F15529998: D21592.id51408.diff
Wed, Apr 23, 12:26 AM
F15517028: D21592.id51408.diff
Fri, Apr 18, 11:38 PM
F15507019: D21592.id51407.diff
Tue, Apr 15, 3:48 PM
F15470081: D21592.diff
Fri, Apr 4, 7:31 PM
F15455731: D21592.diff
Sun, Mar 30, 4:29 AM
F15439769: D21592.id.diff
Wed, Mar 26, 9:22 AM
F15434145: D21592.diff
Tue, Mar 25, 2:13 AM
F15432189: D21592.id51407.diff
Mon, Mar 24, 4:41 PM
Subscribers
None

Details

Summary

Ref T13628. If you "Foist Upon", then delete the value in the tokenizer, then scroll down to the preview, you currently get an ugly "Unknown Object (???)" rendering.

This is technically correct in some vague sense and the transaction won't apply, but provide a more aesthetic rendering instead.

Test Plan

Screen Shot 2021-03-03 at 3.58.38 PM.png (531×589 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 12:08 AM
This revision was automatically updated to reflect the committed changes.