Page MenuHomePhabricator

Improve rendering behavior for "foist upon" with an empty tokenizer
ClosedPublic

Authored by epriestley on Mar 4 2021, 12:01 AM.
Tags
None
Referenced Files
F18110978: D21592.diff
Tue, Aug 12, 3:47 AM
F17958160: D21592.id.diff
Fri, Aug 1, 6:50 AM
F17948645: D21592.diff
Thu, Jul 31, 9:38 PM
F17756262: D21592.id51408.diff
Jul 22 2025, 1:53 PM
F17756260: D21592.id51407.diff
Jul 22 2025, 1:53 PM
F17756036: D21592.id.diff
Jul 22 2025, 1:33 PM
F17732066: D21592.diff
Jul 20 2025, 3:52 AM
Unknown Object (File)
May 29 2025, 8:32 AM
Subscribers
None

Details

Summary

Ref T13628. If you "Foist Upon", then delete the value in the tokenizer, then scroll down to the preview, you currently get an ugly "Unknown Object (???)" rendering.

This is technically correct in some vague sense and the transaction won't apply, but provide a more aesthetic rendering instead.

Test Plan

Screen Shot 2021-03-03 at 3.58.38 PM.png (531×589 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 12:08 AM
This revision was automatically updated to reflect the committed changes.