Page MenuHomePhabricator

Lift bulk tests for "many users against one object" capabilities into "PolicyFilterSet"
ClosedPublic

Authored by epriestley on Feb 5 2021, 1:15 AM.

Details

Summary

Ref T13602. Currently, the policy framework can not execute "test if many users can see one object" particluarly efficiently. This test must be executed more broadly to implement the changes in T13602.

To avoid making this any worse than it already is, lift this block into a wrapper class that has a bulk queue + fetch API and could eventually be optimized.

Test Plan

Viewed a task with an @mention of a user without permission to see it in the summary, saw it rendered in a disabled style.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 13, 9:37 PM
This revision was automatically updated to reflect the committed changes.