Page MenuHomePhabricator

Differential: Inlines and View Options
Closed, ResolvedPublic

Description

Completed

  • The "Open in Editor" keyboard shortcut currently requires a file to be focused, but can also function with a comment focused. (In this case, it should try to jump to that line.)
  • In Diffusion, when viewing a single file, the "\" keystroke could be bound to "Open in Editor".
  • Editor URIs don't support repository short names.
  • Editor URIs should explicitly forbid "/../" from appearing in paths to prevent hyjinx.
  • I think loadEditorLink() currently relies incorrectly on the behavior of strtr() being magical / reading minds.
  • See PHI1661, which would like a keyboard shortcut for "Open in Editor".
  • See PHI1659, which would like the "do not show unchanged files with no comments in intradiffs" rule to improve to "do not show unchanged files with no non-hidden comments in intradiffs".
  • The "View As..." engine selector doesn't omit engines which can't render diffs.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley triaged this task as Normal priority.Apr 17 2020, 3:11 PM
epriestley created this task.

keyboard shortcut for "Open in Editor".

Safari now prompts you with this dialog every time a page opens an external application:

Screen Shot 2020-04-17 at 8.26.10 AM.png (133×469 px, 17 KB)

This can be avoided by dragging an <a href="..."> link from the webpage into the Textmate app in the dock, and presumably likewise for other applications. This might motivate making "Open in Editor" a top-level icon, at least on desktop for users who have configured an external editor.

epriestley added a revision: Restricted Differential Revision.Apr 17 2020, 4:52 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 17 2020, 5:06 PM
epriestley added a revision: Restricted Differential Revision.Apr 17 2020, 5:32 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 17 2020, 5:52 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 4:56 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 6:25 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 6:34 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 9:31 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 10:24 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 10:26 PM
epriestley added a revision: Restricted Differential Revision.Apr 18 2020, 11:11 PM
epriestley added a revision: Restricted Differential Revision.Apr 19 2020, 2:09 PM
epriestley added a revision: Restricted Differential Revision.Apr 19 2020, 2:20 PM
epriestley added a revision: Restricted Differential Revision.Apr 19 2020, 3:57 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 19 2020, 3:59 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 19 2020, 4:02 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 19 2020, 4:04 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 19 2020, 4:37 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 19 2020, 4:41 PM
epriestley added a commit: Restricted Diffusion Commit.