Page MenuHomePhabricator

Differential: Inlines and View Options
Closed, ResolvedPublic



  • The "Open in Editor" keyboard shortcut currently requires a file to be focused, but can also function with a comment focused. (In this case, it should try to jump to that line.)
  • In Diffusion, when viewing a single file, the "\" keystroke could be bound to "Open in Editor".
  • Editor URIs don't support repository short names.
  • Editor URIs should explicitly forbid "/../" from appearing in paths to prevent hyjinx.
  • I think loadEditorLink() currently relies incorrectly on the behavior of strtr() being magical / reading minds.
  • See PHI1661, which would like a keyboard shortcut for "Open in Editor".
  • See PHI1659, which would like the "do not show unchanged files with no comments in intradiffs" rule to improve to "do not show unchanged files with no non-hidden comments in intradiffs".
  • The "View As..." engine selector doesn't omit engines which can't render diffs.

Event Timeline

epriestley triaged this task as Normal priority.Apr 17 2020, 3:11 PM
epriestley created this task.

keyboard shortcut for "Open in Editor".

Safari now prompts you with this dialog every time a page opens an external application:

Screen Shot 2020-04-17 at 8.26.10 AM.png (133×469 px, 17 KB)

This can be avoided by dragging an <a href="..."> link from the webpage into the Textmate app in the dock, and presumably likewise for other applications. This might motivate making "Open in Editor" a top-level icon, at least on desktop for users who have configured an external editor.