Page MenuHomePhabricator

Provide a more general "Author" transaction for Differential
ClosedPublic

Authored by epriestley on Mar 3 2021, 11:47 PM.

Details

Summary

Ref T13628. Currently, Differential has a "Commandeer" action, but no way to edit the author otherwise.

This is largely archaic: there is no reason to prevent editing the author, and this makes it difficult to undo mistakes if you commandeer by accident.

Instead, provide a normal "Author" field and a "Foist Upon" action, similar to the "Owner" and "Claim/Assign" fields in Maniphest.

Test Plan
  • Applied author transactions as the old author ("foisted"), the new author ("commandeered"), and an arbitrary third party ("changed author").
  • Tried to unassign author, etc.
  • Viewed stories in feed and transaction timeline.
  • Saw sensible automatic reviewer changes.
  • Used existing "Commandeer" action, which is unchanged.
  • Called "transaction.search" and saw reasonable transaction values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 3 2021, 11:48 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.
epriestley edited reviewers, added: bjshively; removed: epriestley.