Page MenuHomePhabricator

Fix an out-of-order issue in the new update-during-publish behavior
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:38 PM.
Tags
None
Referenced Files
F17756207: D21468.id51099.diff
Tue, Jul 22, 1:51 PM
F17756203: D21468.id51098.diff
Tue, Jul 22, 1:51 PM
F17756014: D21468.id.diff
Tue, Jul 22, 1:32 PM
F17732045: D21468.diff
Sun, Jul 20, 3:51 AM
Unknown Object (File)
Wed, Jul 2, 9:57 PM
Unknown Object (File)
Wed, Jul 2, 9:54 PM
Unknown Object (File)
Jun 18 2025, 5:55 PM
Unknown Object (File)
Jun 18 2025, 7:50 AM
Subscribers
None

Details

Summary

Ref T13552. The Herald field "Accepted Differential revision" (and similar fields) depend on the task/revision update steps running before Herald executes.

Herald currently executes first, so it never sees associated revisions. Swap this order.

Test Plan

Published a commit, got a clean parse/import. Will test with production rules ("Cowboy Commits").

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:39 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.