Page MenuHomePhabricator
Differential D21468

Fix an out-of-order issue in the new update-during-publish behavior
ClosedPublic
Actions

Authored by epriestley on Sep 17 2020, 8:38 PM.

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior
Summary

Ref T13552. The Herald field "Accepted Differential revision" (and similar fields) depend on the task/revision update steps running before Herald executes.

Herald currently executes first, so it never sees associated revisions. Swap this order.

Test Plan

Published a commit, got a clean parse/import. Will test with production rules ("Cowboy Commits").

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 17 2020, 8:38 PM
Harbormaster completed remote builds in B24913: Diff 51098.Sep 17 2020, 8:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:39 PM
epriestley requested review of this revision.
Closed by commit rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior.
epriestley added a commit: rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
9 lines

Diff 51099

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php

Loading...
Phabricator · Built by Phacility