Page MenuHomePhabricator

Fix an out-of-order issue in the new update-during-publish behavior
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:38 PM.

Details

Summary

Ref T13552. The Herald field "Accepted Differential revision" (and similar fields) depend on the task/revision update steps running before Herald executes.

Herald currently executes first, so it never sees associated revisions. Swap this order.

Test Plan

Published a commit, got a clean parse/import. Will test with production rules ("Cowboy Commits").

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:39 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.