Page MenuHomePhabricator

epriestley (Evan Priestley)Administrator
Overengineer

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (397 w, 4 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Today

epriestley committed rARC5ef6599239fe: [Wilds] When reading ".arcrc" files, modernize the data we read in-process if… (authored by epriestley).
[Wilds] When reading ".arcrc" files, modernize the data we read in-process if…
Sat, Sep 22, 12:00 AM
epriestley closed D19696: [Wilds] When reading ".arcrc" files, modernize the data we read in-process if they're in an older format on disk.
Sat, Sep 22, 12:00 AM

Yesterday

epriestley committed rARCc64f86c2f632: [Wilds] Flesh out most of the new Config objects (authored by epriestley).
[Wilds] Flesh out most of the new Config objects
Fri, Sep 21, 11:58 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCc64f86c2f632: [Wilds] Flesh out most of the new Config objects.
Fri, Sep 21, 11:58 PM · Arcanist, Plans
epriestley closed D19695: [Wilds] Flesh out most of the new Config objects.
Fri, Sep 21, 11:58 PM
epriestley committed rARC23aaf85eafce: [Wilds] Allow class loading to continue on failure (authored by epriestley).
[Wilds] Allow class loading to continue on failure
Fri, Sep 21, 11:56 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC23aaf85eafce: [Wilds] Allow class loading to continue on failure.
Fri, Sep 21, 11:56 PM · Arcanist, Plans
epriestley committed rARC412484022bc5: [Wilds] Prepare for more modular configuration management (authored by epriestley).
[Wilds] Prepare for more modular configuration management
Fri, Sep 21, 11:54 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC412484022bc5: [Wilds] Prepare for more modular configuration management.
Fri, Sep 21, 11:54 PM · Arcanist, Plans
epriestley closed D19694: [Wilds] Prepare for more modular configuration management.
Fri, Sep 21, 11:54 PM
epriestley committed rARC11599cedb619: [Wilds] Implement a Filesystem::concatenatePaths(...) method (authored by epriestley).
[Wilds] Implement a Filesystem::concatenatePaths(...) method
Fri, Sep 21, 11:52 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC11599cedb619: [Wilds] Implement a Filesystem::concatenatePaths(...) method.
Fri, Sep 21, 11:52 PM · Arcanist, Plans
epriestley closed D19691: [Wilds] Implement a Filesystem::concatenatePaths(...) method.
Fri, Sep 21, 11:52 PM
epriestley added inline comments to D19691: [Wilds] Implement a Filesystem::concatenatePaths(...) method.
Fri, Sep 21, 11:51 PM
epriestley committed rARCc05bbd7be67a: [Wilds] Allow "arc liberate" to liberate itself again (authored by epriestley).
[Wilds] Allow "arc liberate" to liberate itself again
Fri, Sep 21, 11:51 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCc05bbd7be67a: [Wilds] Allow "arc liberate" to liberate itself again.
Fri, Sep 21, 11:51 PM · Arcanist, Plans
epriestley closed D19690: [Wilds] Allow "arc liberate" to liberate itself again.
Fri, Sep 21, 11:51 PM
epriestley added a comment to D19689: [Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way.

Nice catches! I managed to catch those later but not before the code actually hit them and died. 🦂

Fri, Sep 21, 11:50 PM
epriestley committed rARCd9362570189e: [Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way (authored by epriestley).
[Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way
Fri, Sep 21, 11:48 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCd9362570189e: [Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way.
Fri, Sep 21, 11:48 PM · Arcanist, Plans
epriestley closed D19689: [Wilds] Rewrite WorkingCopyIdentity in a more modern/modular way.
Fri, Sep 21, 11:48 PM
epriestley committed rARC9a94aa216b1d: [Wilds] Slightly simplify fatal handling during "arc" setup (authored by epriestley).
[Wilds] Slightly simplify fatal handling during "arc" setup
Fri, Sep 21, 11:46 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC9a94aa216b1d: [Wilds] Slightly simplify fatal handling during "arc" setup.
Fri, Sep 21, 11:46 PM · Arcanist, Plans
epriestley closed D19693: [Wilds] Slightly simplify fatal handling during "arc" setup.
Fri, Sep 21, 11:46 PM
epriestley committed rARCfe0c29389518: [Wilds] Remove include_path mangling and drop support for "externals/includes" (authored by epriestley).
[Wilds] Remove include_path mangling and drop support for "externals/includes"
Fri, Sep 21, 11:44 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCfe0c29389518: [Wilds] Remove include_path mangling and drop support for "externals/includes".
Fri, Sep 21, 11:44 PM · Arcanist, Plans
epriestley closed D19692: [Wilds] Remove include_path mangling and drop support for "externals/includes".
Fri, Sep 21, 11:44 PM
epriestley committed rARC8e0e07664a83: [Wilds] Remove libphutil (authored by epriestley).
[Wilds] Remove libphutil
Fri, Sep 21, 11:40 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC8e0e07664a83: [Wilds] Remove libphutil.
Fri, Sep 21, 11:40 PM · Arcanist, Plans
epriestley closed D19688: [Wilds] Remove libphutil.
Fri, Sep 21, 11:40 PM
epriestley added a comment to D19688: [Wilds] Remove libphutil.

libphutil/ currently includes a ~2.5MB "xhpast.exe". I took this opportunity to remove it.

Fri, Sep 21, 11:29 PM
epriestley triaged T13205: Perhaps, provide options for hardening long-lived and relatively stable directories in Drydock? as Wishlist priority.
Fri, Sep 21, 11:27 PM · Drydock
epriestley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

In order for threading to work in email clients, the Message-ID header needs to be set on the initial email, with following emails having In-Reply-To / References set to that same Message-ID.

Fri, Sep 21, 11:25 PM · Mail, Differential
epriestley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

I can't reproduce this: mail threads properly in my client.

Fri, Sep 21, 11:23 PM · Mail, Differential
epriestley committed rARCf0608eef9b3b: [Wilds] Remove the defunct "scripts/arcanist.php" script (authored by epriestley).
[Wilds] Remove the defunct "scripts/arcanist.php" script
Fri, Sep 21, 11:03 PM
epriestley committed rARCd8f660ec6f6a: [Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php` (authored by epriestley).
[Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php`
Fri, Sep 21, 11:00 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCd8f660ec6f6a: [Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php`.
Fri, Sep 21, 11:00 PM · Arcanist, Plans
epriestley closed D19687: [Wilds] Move ArcanistRuntime to `support/ArcanistRuntime.php`.
Fri, Sep 21, 11:00 PM
epriestley committed rARCd62830195cfa: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc` (authored by epriestley).
[Wilds] Rename "--load-phutil-library" to "--library" in new `arc`
Fri, Sep 21, 10:59 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCd62830195cfa: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc`.
Fri, Sep 21, 10:59 PM · Arcanist, Plans
epriestley closed D19686: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc`.
Fri, Sep 21, 10:59 PM
epriestley committed rARCbaadc1f84260: [Wilds] Sort of make "arc help" work again (authored by epriestley).
[Wilds] Sort of make "arc help" work again
Fri, Sep 21, 10:58 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARCbaadc1f84260: [Wilds] Sort of make "arc help" work again.
Fri, Sep 21, 10:58 PM · Arcanist, Plans
epriestley closed D19679: [Wilds] Sort of make "arc help" work again.
Fri, Sep 21, 10:58 PM
epriestley committed rARC8e51f89c794b: [Wilds] Make "arc liberate" run in the untamed wilds (authored by epriestley).
[Wilds] Make "arc liberate" run in the untamed wilds
Fri, Sep 21, 10:57 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC8e51f89c794b: [Wilds] Make "arc liberate" run in the untamed wilds.
Fri, Sep 21, 10:57 PM · Arcanist, Plans
epriestley closed D19678: [Wilds] Make "arc liberate" run in the untamed wilds.
Fri, Sep 21, 10:57 PM
epriestley committed rARC7d05dbec155b: [Wilds] Rewrite "arc" entrypoints for toolsets (authored by epriestley).
[Wilds] Rewrite "arc" entrypoints for toolsets
Fri, Sep 21, 10:56 PM
epriestley added a commit to T13098: Plans: Arcanist toolsets and extensions: rARC7d05dbec155b: [Wilds] Rewrite "arc" entrypoints for toolsets.
Fri, Sep 21, 10:56 PM · Arcanist, Plans
epriestley closed D19677: [Wilds] Rewrite "arc" entrypoints for toolsets.
Fri, Sep 21, 10:56 PM
epriestley abandoned D19685: When running libphutil scripts, repair bad "variables_order".

This rolled into the "nuke libphutil forever" change, but I'm not currently planning to land it to libphutil prior to that because the things it addresses are all very niche and there's some possibility it does goofy things and breaks the world or something.

Fri, Sep 21, 10:53 PM
epriestley updated the diff for D19700: [Wilds] Update "arc shell-complete" for toolsets.
  • More-tested version which removes ZSH support since it doesn't work.
Fri, Sep 21, 10:45 PM
epriestley requested review of D19700: [Wilds] Update "arc shell-complete" for toolsets.
Fri, Sep 21, 10:45 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19700: [Wilds] Update "arc shell-complete" for toolsets.
Fri, Sep 21, 10:44 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Fri, Sep 21, 10:39 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Fri, Sep 21, 10:05 PM · Arcanist, Plans
epriestley added inline comments to D19699: [Wilds] Shove the logging stuff into a bit of an abstraction before it gets out of control.
Fri, Sep 21, 8:36 PM

Thu, Sep 20

epriestley added inline comments to D19695: [Wilds] Flesh out most of the new Config objects.
Thu, Sep 20, 11:17 PM
epriestley added inline comments to D19699: [Wilds] Shove the logging stuff into a bit of an abstraction before it gets out of control.
Thu, Sep 20, 10:46 PM
epriestley requested review of D19699: [Wilds] Shove the logging stuff into a bit of an abstraction before it gets out of control.
Thu, Sep 20, 10:45 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19699: [Wilds] Shove the logging stuff into a bit of an abstraction before it gets out of control.
Thu, Sep 20, 10:45 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Thu, Sep 20, 10:31 PM · Arcanist, Plans
epriestley requested review of D19698: [Wilds] Make "arc call-conduit ..." call Conduit methods.
Thu, Sep 20, 10:07 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19698: [Wilds] Make "arc call-conduit ..." call Conduit methods.
Thu, Sep 20, 10:07 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Thu, Sep 20, 9:52 PM · Arcanist, Plans
epriestley added a comment to T13203: Arcanist Wilds Patch Notes (Ongoing).

Also, damn, I've used libphutil for so many things - ExecFuture and HTTPSFuture are just by far the best thing out there for async work.

Thu, Sep 20, 9:47 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Thu, Sep 20, 9:45 PM · Arcanist, Plans
epriestley added a comment to D19688: [Wilds] Remove libphutil.

press_f_to_pay_respects.txt

Thu, Sep 20, 9:10 PM
epriestley added a comment to D19688: [Wilds] Remove libphutil.

I'd imagine replacing master and stable in libphutil/ with a single "TOMBSTONE.txt" file explaining everything, and leaving it there indefinitely. So pulling will keep working, it just won't do anything interesting.

Thu, Sep 20, 9:10 PM
epriestley added a comment to D19688: [Wilds] Remove libphutil.

Yeah. rP needs rARC, but rARC is now completely standalone.

Thu, Sep 20, 8:31 PM
epriestley updated the summary of D19697: [Wilds] Continue toward a generalized "arc alias" workflow.
Thu, Sep 20, 6:29 PM
epriestley requested review of D19697: [Wilds] Continue toward a generalized "arc alias" workflow.
Thu, Sep 20, 6:28 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19697: [Wilds] Continue toward a generalized "arc alias" workflow.
Thu, Sep 20, 6:28 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Thu, Sep 20, 6:11 PM · Arcanist, Plans
epriestley added a comment to D19694: [Wilds] Prepare for more modular configuration management.

The version and/or installation status of xhpast likely differs across nodes on the secure tier, so one file got highlighted by (say) secure001 and got a full XHPAST parse, while the other got highlighted by (say) secure003 and fell back to the Pygments lexer.

Thu, Sep 20, 5:42 PM
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Thu, Sep 20, 2:26 PM · Arcanist, Plans
epriestley added a comment to D17593: Maniphest: Allow restricting custom fields to subtypes.

In theory, probably. In practice, anything not coming through a support pact is probably going to sit in queue for an eternity nowadays.

Thu, Sep 20, 12:46 PM
epriestley retitled D19696: [Wilds] When reading ".arcrc" files, modernize the data we read in-process if they're in an older format on disk from [Wilds] When reading ".arcrc" files, modernize them if they're in an older format to [Wilds] When reading ".arcrc" files, modernize the data we read in-process if they're in an older format on disk.
Thu, Sep 20, 12:39 PM
epriestley added a comment to D19696: [Wilds] When reading ".arcrc" files, modernize the data we read in-process if they're in an older format on disk.

Today, arcconfig files are JSON and won't parse if you have comments:

Thu, Sep 20, 12:39 PM

Wed, Sep 19

epriestley committed rP3244324cb1ab: Fix comment box borders in timelines after Phriction commenting (authored by epriestley).
Fix comment box borders in timelines after Phriction commenting
Wed, Sep 19, 8:57 PM
epriestley added a commit to T13202: Plans: 2018 Week 38 Bonus Content: rP3244324cb1ab: Fix comment box borders in timelines after Phriction commenting.
Wed, Sep 19, 8:57 PM · Plans
epriestley closed D19684: Fix comment box borders in timelines after Phriction commenting.
Wed, Sep 19, 8:57 PM
epriestley added inline comments to D19685: When running libphutil scripts, repair bad "variables_order".
Wed, Sep 19, 6:22 PM
epriestley requested review of D19696: [Wilds] When reading ".arcrc" files, modernize the data we read in-process if they're in an older format on disk.
Wed, Sep 19, 6:08 PM
epriestley added a comment to D19678: [Wilds] Make "arc liberate" run in the untamed wilds.

I'm copy-pasting these diffs from the command line with git show | pbcopy, since arc diff doesn't run on any of these branches yet. The git show diff is missing context, versus the git diff -U9999 ... diff that arc generates internally.

Wed, Sep 19, 5:48 PM
epriestley requested review of D19695: [Wilds] Flesh out most of the new Config objects.
Wed, Sep 19, 5:42 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19695: [Wilds] Flesh out most of the new Config objects.
Wed, Sep 19, 5:36 PM · Arcanist, Plans
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Wed, Sep 19, 1:03 PM · Plans, Diffusion
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Wed, Sep 19, 12:53 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Wed, Sep 19, 12:43 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Wed, Sep 19, 12:37 PM · Plans, Drydock

Tue, Sep 18

epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Tue, Sep 18, 9:11 PM · Arcanist, Plans
epriestley requested review of D19694: [Wilds] Prepare for more modular configuration management.
Tue, Sep 18, 9:10 PM
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Tue, Sep 18, 9:05 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Tue, Sep 18, 8:59 PM · Arcanist, Plans
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19694: [Wilds] Prepare for more modular configuration management.
Tue, Sep 18, 8:36 PM · Arcanist, Plans
epriestley requested review of D19693: [Wilds] Slightly simplify fatal handling during "arc" setup.
Tue, Sep 18, 8:10 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: D19693: [Wilds] Slightly simplify fatal handling during "arc" setup.
Tue, Sep 18, 8:10 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Tue, Sep 18, 8:08 PM · Arcanist, Plans
epriestley requested review of D19692: [Wilds] Remove include_path mangling and drop support for "externals/includes".
Tue, Sep 18, 8:08 PM