epriestley (Evan Priestley)
Overengineer

Projects (80)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

Badges

User Since
Feb 8 2011, 1:28 AM (310 w, 3 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Today

epriestley accepted D17238: Remove counts from home navigation.

We could definitely integrate this into MenuItem (at least, if Home is staying wide? Maybe not if it's collapsing like Projects?) but ideally maybe no one notices or misses this stuff.

Sat, Jan 21, 12:07 AM

Yesterday

epriestley added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Fri, Jan 20, 11:40 PM · Conpherence
epriestley created T12138: Send-on-Enter and Fullscreen Mode interact destructively.
Fri, Jan 20, 11:36 PM · Conpherence
epriestley added a comment to D17238: Remove counts from home navigation.

tarnation

Fri, Jan 20, 11:35 PM
epriestley added a comment to D17238: Remove counts from home navigation.

Maybe even some CSS!

Fri, Jan 20, 11:27 PM
epriestley requested changes to D17238: Remove counts from home navigation.

I think we can get rid of a lot more stuff, like DifferentialApplication->loadNeedAttentionRevisions(), PhabricatorApplication->loadStatus() and callsites, the entire PhabricatorApplicationStatusView class, the stuff in People, Phrequent, Maniphest and Flags, probably some strings in USEnglishTranslation if you want to get ambitious, and the MAX_STATUS_ITEMS constant. Like seven million lines of code.

Fri, Jan 20, 11:26 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to, see Consulting to move forward.

Fri, Jan 20, 11:23 PM · Bug Report (Needs Information)
epriestley added a comment to T12137: Stemming + MySQL Fulltext search can lead to unexpected results.

How do I reproduce unexpected results at the application level (for example, what's something I can search for that doesn't match but should match)?

Fri, Jan 20, 11:18 PM · Bug Report
epriestley added a comment to T11521: Request Review action should clear "accepted older" status.

Yes and no. So: maybe?

Fri, Jan 20, 11:12 PM · Restricted Project, Differential, Bug Report
epriestley committed rPddf82a815b9a: Remove duplicate setIsRequired() (authored by epriestley).
Remove duplicate setIsRequired()
Fri, Jan 20, 8:27 PM
epriestley closed D17237: Remove duplicate setIsRequired() by committing rPddf82a815b9a: Remove duplicate setIsRequired().
Fri, Jan 20, 8:26 PM
epriestley added a comment to rP2dfe79cfc713: When updating revisions in response to commits, reuse previously generated diffs.

The !== null also catches this bug:

Fri, Jan 20, 8:13 PM
epriestley created D17237: Remove duplicate setIsRequired().
Fri, Jan 20, 8:06 PM
epriestley committed rPd24739ee3cfa: Minor consistency/order updates for menu items which reference other objects (authored by epriestley).
Minor consistency/order updates for menu items which reference other objects
Fri, Jan 20, 7:58 PM
epriestley closed D17236: Minor consistency/order updates for menu items which reference other objects by committing rPd24739ee3cfa: Minor consistency/order updates for menu items which reference other objects.
Fri, Jan 20, 7:58 PM
epriestley committed rP8113b7691089: Validate menu item fields (links, projects, dashboards, applications, forms… (authored by epriestley).
Validate menu item fields (links, projects, dashboards, applications, forms…
Fri, Jan 20, 7:58 PM
epriestley added a commit to T12128: Favorites Menu Errata : rP8113b7691089: Validate menu item fields (links, projects, dashboards, applications, forms….
Fri, Jan 20, 7:58 PM · Profile Menu Item
epriestley closed D17235: Validate menu item fields (links, projects, dashboards, applications, forms, etc) by committing rP8113b7691089: Validate menu item fields (links, projects, dashboards, applications, forms….
Fri, Jan 20, 7:58 PM
epriestley added a comment to D17236: Minor consistency/order updates for menu items which reference other objects.

I think this is reasonable to have even if we rename since it costs us ~nothing and adds some flexibility. I think broader renaming is still on the table; we could do "light" renames, like one of these:

Fri, Jan 20, 7:56 PM
epriestley created D17236: Minor consistency/order updates for menu items which reference other objects.
Fri, Jan 20, 7:44 PM
epriestley added a comment to T11957: Add MenuEngine to Home.

While I've got you, how do you feel about a diff to:

Fri, Jan 20, 7:34 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

(If there's pushback, maybe like a "one-time hacky copy your old global app settings into the menu script that we don't support" sort of thing? But I'd guess users won't feel like this is too painful since the new menu is a lot more flexible/powerful.)

Fri, Jan 20, 7:31 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

I think it would potentially be reasonable to not migrate, especially if you do another blog post like the Favorites one to ease migration pain. Global stuff is relatively recent and pretty easy to put back in place, and I think a gentle nudge to configure the menu to work well for your install isn't a bad thing.

Fri, Jan 20, 7:29 PM · Profile Menu Item, Dashboards
epriestley added a comment to T12136: What to do with "Application Counts" with MenuItem.

Maybe less complainey now that Audit and Differential have fairly sane default "stuff you should do" bucketed queries which can go on a dashboard? But who knows. I tend to think we should make an effort to toss these and see how much pushback we get. In particular, they're very expensive to build relative to their utility (and no one has complained yet that I nuked the Audit count, although it has only been gone for a little while).

Fri, Jan 20, 7:24 PM · Profile Menu Item, Dashboards
epriestley created D17235: Validate menu item fields (links, projects, dashboards, applications, forms, etc).
Fri, Jan 20, 7:16 PM
epriestley added a revision to T12128: Favorites Menu Errata : D17235: Validate menu item fields (links, projects, dashboards, applications, forms, etc).
Fri, Jan 20, 7:16 PM · Profile Menu Item
epriestley closed T12129: Mercurial repository updates cause high CPU usage as "Invalid".

Sounds good. I'm going to close this since it doesn't seem to be moving toward becoming a bug report which we can accept upstream.

Fri, Jan 20, 6:24 PM · Bug Report (Needs Information)
epriestley renamed T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username from "when editing bot account settings, the default values suggest I'm editing my own settings" to "When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username".
Fri, Jan 20, 6:20 PM · Bug Report
epriestley triaged T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username as "Wishlist" priority.

There's a TODO about this in the code:

Fri, Jan 20, 6:19 PM · Bug Report
cspeckmim awarded T12134: Develop a Nuance-based Phabricator reporting/support flow a Party Time token.
Fri, Jan 20, 6:00 PM · Abuse
epriestley merged task T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Fri, Jan 20, 6:00 PM · Public & Media Relations, Support
epriestley merged T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Fri, Jan 20, 6:00 PM · Abuse
epriestley added a comment to T9212: Community Feedback: How should we handle free support?.

I'm going to merge this into T12134, which begins defining a more concrete plan roughly following some of the outline above. The major change from an upstream perspective since this task was filed is that we have a more specific set of harder technical requirements around support for Phacility SAAS instances (particularly after the launch of free instances), so it makes more sense to let those requirements drive product design and then accommodate general free support under that umbrella. Broadly, I expect to move support (bug reports, feature requests) into Nuance and continue reducing user access to the upstream.

Fri, Jan 20, 6:00 PM · Public & Media Relations, Support
epriestley created T12134: Develop a Nuance-based Phabricator reporting/support flow.
Fri, Jan 20, 5:32 PM · Abuse
epriestley created D17234: Put "View Edit History" above "Remove Comment" in timeline comment action dropdown.
Fri, Jan 20, 3:40 PM
epriestley added a revision to T12131: Edit History inserts itself wherever it feels like: D17234: Put "View Edit History" above "Remove Comment" in timeline comment action dropdown.
Fri, Jan 20, 3:40 PM · Bug Report
Ondrej awarded T2393: Adds a "Needs Verification" state to Audits a Like token.
Fri, Jan 20, 3:38 PM · Restricted Project, Audit
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

(This change was half-accidental, and then I just figured I'd roll it into T2393 when I realized I'd made it.)

Fri, Jan 20, 3:30 PM · Bug Report
epriestley merged T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Fri, Jan 20, 3:30 PM · Restricted Project, Audit
epriestley merged task T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Fri, Jan 20, 3:29 PM · Bug Report
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

This did actually change in connection with T10978, but only if audit.can-author-close-audit is configured. I plan to resolve T2393 (maybe today?) and hopefully get rid of "Close" and this option entirely. I'm just going to merge this there.

Fri, Jan 20, 3:29 PM · Bug Report
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to work with you one-on-one to help troubleshoot issues in your environment, but we can't offer that kind of support for free. This process almost always takes up a large amount of our time and very rarely uncovers any real bugs in Phabricator or helps anyone except the single user experiencing a configuration problem. See Support Resources for more discussion of the kinds of free and paid support we offer. If you'd like to move forward with one-on-one configuration and environment support, see Consulting.

Fri, Jan 20, 12:51 PM · Bug Report (Needs Information)

Thu, Jan 19

epriestley edited projects for T12129: Mercurial repository updates cause high CPU usage, added: Bug Report (Needs Information); removed Bug Report.
Thu, Jan 19, 11:58 PM · Bug Report (Needs Information)
epriestley awarded Image Macro "tarnation" a Pterodactyl token.
Thu, Jan 19, 11:57 PM
epriestley accepted D17233: Remove motivator panel.

tarnation

Thu, Jan 19, 10:54 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I am unable to reproduce the issue you described by following the steps provided. To move forward:

Thu, Jan 19, 10:06 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Here's what I did to try to reproduce this:

Thu, Jan 19, 10:04 PM · Bug Report (Needs Information)
epriestley accepted D17231: Mark fields as required on MenuItems.

This only controls the UI, I can counterdiff you for actual validation logic. I think there's an existing TODO on "Link" items anyway since they have no validation on typing garbage in for the link target, which can be confusing since security code then nukes it on the display side.

Thu, Jan 19, 9:39 PM
epriestley added a comment to D17230: Remove timeline from Profile Manage.

You could, but it's enough work that I don't think it's worthwhile until we do a general update here (maybe related to generally improving logging/security stuff?), since "Disable / Enable" isn't transactional right now.

Thu, Jan 19, 9:16 PM
epriestley accepted D17230: Remove timeline from Profile Manage.

I'd like to fix this timeline to show administrative events, particularly account disables/enables. This information is indirectly available in People > Activity Logs but inconvenient to access. However, I can put the timeline back after I fix it.

Thu, Jan 19, 9:01 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

(A synthetic repository which you create by running hg commit in a loop, or instructions which allow us to build such a synthetic repository, are also fine.)

Thu, Jan 19, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

An existing, open source project is perfectly fine, provided you first verify that it reproduces the problem.

Thu, Jan 19, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

We need specific reproduction steps to move forward, and "a repository with about 2800 commits" isn't sufficiently specific.

Thu, Jan 19, 8:35 PM · Bug Report (Needs Information)
epriestley committed rPf8cebdc418e8: Make Differential inline events actually trigger comment preview refreshes (authored by epriestley).
Make Differential inline events actually trigger comment preview refreshes
Thu, Jan 19, 8:32 PM
epriestley closed D17229: Make Differential inline events actually trigger comment preview refreshes by committing rPf8cebdc418e8: Make Differential inline events actually trigger comment preview refreshes.
Thu, Jan 19, 8:32 PM
jmeador awarded D17229: Make Differential inline events actually trigger comment preview refreshes a 100 token.
Thu, Jan 19, 7:56 PM
epriestley added inline comments to D17229: Make Differential inline events actually trigger comment preview refreshes.
Thu, Jan 19, 7:55 PM
epriestley created D17229: Make Differential inline events actually trigger comment preview refreshes.
Thu, Jan 19, 7:54 PM
epriestley committed rPa9158d34d46a: Show commit audit status in repository history tables, including merge commit… (authored by epriestley).
Show commit audit status in repository history tables, including merge commit…
Thu, Jan 19, 7:43 PM
epriestley closed T6024: Display (post-push) audit-state in Diffusion commit-list as "Resolved" by committing rPa9158d34d46a: Show commit audit status in repository history tables, including merge commit….
Thu, Jan 19, 7:43 PM · Restricted Project, Audit, Diffusion
epriestley added a commit to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: rPa9158d34d46a: Show commit audit status in repository history tables, including merge commit….
Thu, Jan 19, 7:43 PM · Diffusion, Audit, Feature Request
epriestley closed D17227: Show commit audit status in repository history tables, including merge commit lists by committing rPa9158d34d46a: Show commit audit status in repository history tables, including merge commit….
Thu, Jan 19, 7:43 PM
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Inlines to Future on the Audit board.
Thu, Jan 19, 7:32 PM · Audit
epriestley added a comment to T12127: Allow EditEngine forms to have custom icons.

This is easy but I think you want to get rid of all the IconSet stuff and just let everything have any icon?

Thu, Jan 19, 7:32 PM · EditEngine, Profile Menu Item
epriestley added a comment to T6507: Audit inline comments doesn't account for synthetic authors.

This report is probably correct and the remedy is likely also correct, but getting lint into Diffusion is completely in shambles so I'm actually not immediately sure how to reproduce it, at least in a reasonable / moderately-convenient way.

Thu, Jan 19, 7:31 PM · Audit
epriestley added a commit to T11096: Redesign main header / quick create / search: rPb0dfd42eef29: Don't require edit capability on the Favorites application to edit personal….
Thu, Jan 19, 7:16 PM · Design & Planning
epriestley committed rPb0dfd42eef29: Don't require edit capability on the Favorites application to edit personal… (authored by epriestley).
Don't require edit capability on the Favorites application to edit personal…
Thu, Jan 19, 7:15 PM
epriestley closed D17228: Don't require edit capability on the Favorites application to edit personal menu items by committing rPb0dfd42eef29: Don't require edit capability on the Favorites application to edit personal….
Thu, Jan 19, 7:15 PM
epriestley added a comment to D17228: Don't require edit capability on the Favorites application to edit personal menu items.

Yeah, non-admins editing their own items.

Thu, Jan 19, 7:15 PM
epriestley added a revision to T11096: Redesign main header / quick create / search: D17228: Don't require edit capability on the Favorites application to edit personal menu items.
Thu, Jan 19, 7:11 PM · Design & Planning
epriestley created D17228: Don't require edit capability on the Favorites application to edit personal menu items.
Thu, Jan 19, 7:11 PM
epriestley added a comment to T11096: Redesign main header / quick create / search.

Not intentional -- @chad, I can figure out what's going on there since it might reasonably be me and I have a local repro.

Thu, Jan 19, 7:00 PM · Design & Planning
epriestley awarded T5867: Move Quick Create to MenuItemEngine a Party Time token.
Thu, Jan 19, 6:54 PM · Design & Planning
epriestley added a revision to T6024: Display (post-push) audit-state in Diffusion commit-list: D17227: Show commit audit status in repository history tables, including merge commit lists.
Thu, Jan 19, 6:53 PM · Restricted Project, Audit, Diffusion
epriestley added a revision to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: D17227: Show commit audit status in repository history tables, including merge commit lists.
Thu, Jan 19, 6:53 PM · Diffusion, Audit, Feature Request
epriestley created D17227: Show commit audit status in repository history tables, including merge commit lists.
Thu, Jan 19, 6:53 PM
epriestley moved T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only from Backlog to Future on the Audit board.
Thu, Jan 19, 4:52 PM · Diffusion, Audit, Feature Request
epriestley renamed T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only from "Audits of true merge commits may present duplicate changes in potentially large audit requests" to "Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only".
Thu, Jan 19, 4:52 PM · Diffusion, Audit, Feature Request
epriestley edited projects for T12098: Create Revision from FavoritesMenuItem doesn't work, added: Differential; removed Diffusion.
Thu, Jan 19, 4:46 PM · Differential, Bug Report
azurasean awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Thu, Jan 19, 10:30 AM · Restricted Project, Workboards

Wed, Jan 18

epriestley closed T12122: Cannot login to Phabricator as "Resolved".
Wed, Jan 18, 10:59 PM · Bug Report
epriestley added a comment to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.

I think the big trick on this is going to be making inline comments work somewhat-correctly in the extreme case of octopus merges.

Wed, Jan 18, 10:48 PM · Diffusion, Audit, Feature Request
epriestley added a comment to T12122: Cannot login to Phabricator.

Does upgrading past b21cd24341c6552a3fbd21305ca682a161129a6b resolve it?

Wed, Jan 18, 10:43 PM · Bug Report
epriestley added projects to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: Audit, Diffusion.
Wed, Jan 18, 9:47 PM · Diffusion, Audit, Feature Request
epriestley added a comment to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.

As an adversarial actor, I can use the proposed rule to avoid audit of dangerous changes like this:

Wed, Jan 18, 9:37 PM · Diffusion, Audit, Feature Request
epriestley committed rP269dd81f9178: Allow users to re-accept or re-reject a revision if they have authority over… (authored by epriestley).
Allow users to re-accept or re-reject a revision if they have authority over…
Wed, Jan 18, 9:16 PM
epriestley closed D17226: Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state by committing rP269dd81f9178: Allow users to re-accept or re-reject a revision if they have authority over….
Wed, Jan 18, 9:16 PM
epriestley committed rPb8e04fe0419d: Improve handle batching behavior for commit list view (authored by epriestley).
Improve handle batching behavior for commit list view
Wed, Jan 18, 9:15 PM
epriestley added a commit to T10978: Modernize Audit: rPb8e04fe0419d: Improve handle batching behavior for commit list view.
Wed, Jan 18, 9:15 PM · Audit
epriestley closed D17225: Improve handle batching behavior for commit list view by committing rPb8e04fe0419d: Improve handle batching behavior for commit list view.
Wed, Jan 18, 9:15 PM
epriestley committed rP45c3aaeb269e: Attempt to make dropdown item actions more consistent (authored by epriestley).
Attempt to make dropdown item actions more consistent
Wed, Jan 18, 9:15 PM
epriestley closed D17222: Attempt to make dropdown item actions more consistent by committing rP45c3aaeb269e: Attempt to make dropdown item actions more consistent.
Wed, Jan 18, 9:15 PM
epriestley committed rP90258ed491d5: Fix property shadowing on ActionListView after conversion to TagView (authored by epriestley).
Fix property shadowing on ActionListView after conversion to TagView
Wed, Jan 18, 9:14 PM
epriestley closed D17223: Fix property shadowing on ActionListView after conversion to TagView by committing rP90258ed491d5: Fix property shadowing on ActionListView after conversion to TagView.
Wed, Jan 18, 9:14 PM
epriestley closed T3917: Avoid or easily handle 'duplicate' audits as "Resolved".

My merge of T6557 here was questionable, but I think this is a case where the audits are basically correct and the remedy is better cleanup tools.

Wed, Jan 18, 9:12 PM · Restricted Project, Audit
epriestley created D17226: Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state.
Wed, Jan 18, 9:01 PM
epriestley added a comment to T6557: Automatic auditing should ignore merges.

Sounds good, thanks.

Wed, Jan 18, 8:44 PM · Audit
epriestley changed the status of T6557: Automatic auditing should ignore merges from "Duplicate" to "Invalid".

On re-reading T3917 I agree it has approximately nothing to do with this, but see also T5338, where I think I go through a flow like this and it doesn't trigger an audit.

Wed, Jan 18, 8:44 PM · Audit
epriestley closed T5338: Incorrect handling of merge commits as "Invalid".

Per above, not sure how to reproduce this.

Wed, Jan 18, 8:41 PM · Audit, Differential
epriestley added a comment to T5338: Incorrect handling of merge commits.

I don't believe this report, but here goes:

Wed, Jan 18, 8:41 PM · Audit, Differential