Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (457 w, 6 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Thu, Nov 14

epriestley requested review of D20914: Update repository identities after all mutations to users and email addresses.
Thu, Nov 14, 7:51 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20914: Update repository identities after all mutations to users and email addresses.
Thu, Nov 14, 7:49 PM · Diffusion
epriestley requested review of D20913: Give "PhabricatorUserEmail" a PHID.
Thu, Nov 14, 7:32 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20913: Give "PhabricatorUserEmail" a PHID.
Thu, Nov 14, 7:31 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Uhhhh, absolutely none of this works because PhabricatorUserEmail does not have a PHID.

Thu, Nov 14, 7:20 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Another likely bug is:

Thu, Nov 14, 7:05 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Currently, the flow here is that changes queue a daemon task.

Thu, Nov 14, 6:42 PM · Diffusion
epriestley requested review of D20912: Use DestructionEngine to destroy UserEmail objects.
Thu, Nov 14, 6:25 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20912: Use DestructionEngine to destroy UserEmail objects.
Thu, Nov 14, 6:24 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Removing an email does not properly disassociate identities. This unambiguously should.

Thu, Nov 14, 6:12 PM · Diffusion
epriestley requested review of D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Thu, Nov 14, 5:36 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Thu, Nov 14, 5:34 AM · Diffusion
epriestley requested review of D20910: Consolidate repository identity resolution and detection code.
Thu, Nov 14, 4:52 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20910: Consolidate repository identity resolution and detection code.
Thu, Nov 14, 4:50 AM · Diffusion
epriestley requested review of D20909: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event.
Thu, Nov 14, 4:27 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20909: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event.
Thu, Nov 14, 4:25 AM · Diffusion
epriestley requested review of D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently.
Thu, Nov 14, 4:10 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently.
Thu, Nov 14, 4:09 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.

Thu, Nov 14, 3:22 AM · Diffusion
epriestley requested review of D20907: Make repository identity email address association case-insensitive.
Thu, Nov 14, 3:17 AM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20907: Make repository identity email address association case-insensitive.
Thu, Nov 14, 3:15 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.
  • When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.
Thu, Nov 14, 3:05 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

The internal construction with LIKE '%...' is also not great:

Thu, Nov 14, 2:47 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Looking up identities by email address is improperly case-sensitive, because the query is a LIKE query against a binary column.

Thu, Nov 14, 2:46 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Here's a list of bugs I expect exist, although I haven't made it far as reproducing them yet:

Thu, Nov 14, 2:41 AM · Diffusion
epriestley added a parent task for T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: T13444: Provide a standalone script entry point for resolving a repository identity.
Thu, Nov 14, 2:12 AM · Diffusion
epriestley added a subtask for T13444: Provide a standalone script entry point for resolving a repository identity: T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration.
Thu, Nov 14, 2:12 AM · Diffusion
epriestley triaged T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Low priority.
Thu, Nov 14, 1:35 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

We currently have bin/repository rebuild-identities, which takes a list of repository identifiers or --all. This has a lot of history in T12164 and we currently queue an "activity" for it during migrations in 20180809.repo_identities.activity.php.

Thu, Nov 14, 1:19 AM · Diffusion

Wed, Nov 13

epriestley committed rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits (authored by epriestley).
Surface edits to "Text" panels on dashboards as remarkup edits
Wed, Nov 13, 6:35 PM
epriestley closed D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:35 PM
epriestley closed T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Resolved by committing rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:35 PM · Dashboards, Remarkup
epriestley requested review of D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:33 PM
epriestley added a revision to T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc): D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Wed, Nov 13, 6:32 PM · Dashboards, Remarkup
epriestley triaged T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Low priority.
Wed, Nov 13, 6:31 PM · Dashboards, Remarkup
epriestley committed rP2adc36ba0b8d: Correctly identify more SSH private key problems as "formatting" or… (authored by epriestley).
Correctly identify more SSH private key problems as "formatting" or…
Wed, Nov 13, 6:22 PM
epriestley closed D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:22 PM
epriestley closed T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys as Resolved.

I've marked D20905 as resolving this. This isn't really "resolved" completely, but T13454 has a better description of what the problems are and why they're difficult. Our behavior is, at least, substantially better than it was before.

Wed, Nov 13, 6:19 PM · Passphrase
epriestley closed T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys, a subtask of T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body, as Resolved.
Wed, Nov 13, 6:19 PM · Auth
epriestley requested review of D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:18 PM
epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:17 PM · Auth
epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.
Wed, Nov 13, 6:17 PM · Passphrase
epriestley added a parent task for T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.
Wed, Nov 13, 6:12 PM · Passphrase
epriestley added a subtask for T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys.
Wed, Nov 13, 6:12 PM · Auth
epriestley abandoned D20904: Perform a more sophisticated test for private keys with credentials.

I have a fancier version of this in the works.

Wed, Nov 13, 5:45 PM
epriestley claimed T13455: Make "View Options" in Differential sticky across reloads.
Wed, Nov 13, 4:07 PM · Differential
epriestley triaged T13455: Make "View Options" in Differential sticky across reloads as Low priority.
Wed, Nov 13, 4:07 PM · Differential
epriestley added a comment to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.

On Ubuntu 14, the messages are a little less helpful:

Wed, Nov 13, 4:01 AM · Auth
epriestley updated the task description for T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.
Wed, Nov 13, 3:11 AM · Auth

Mon, Nov 11

epriestley edited the content of 2019 Week 44 (Early November).
Mon, Nov 11, 7:45 PM
epriestley requested review of D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:21 PM
epriestley added a revision to T13123: Plans: Improve SSH key parsing and handling: D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:19 PM · Plans, Auth
epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:19 PM · Auth
epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: D20904: Perform a more sophisticated test for private keys with credentials.
Mon, Nov 11, 7:19 PM · Passphrase
epriestley triaged T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body as Low priority.
Mon, Nov 11, 7:15 PM · Auth

Sat, Nov 9

epriestley committed rARC2979752639a0: (experimental) Merge branch "master" into experimental (authored by epriestley).
(experimental) Merge branch "master" into experimental
Sat, Nov 9, 2:16 AM
epriestley edited the content of Changelog.
Sat, Nov 9, 2:10 AM
epriestley created an object: 2019 Week 45 (Mid November).
Sat, Nov 9, 2:09 AM
epriestley committed rPcf6df55dbee3: (stable) Promote 2019 Week 45 (authored by epriestley).
(stable) Promote 2019 Week 45
Sat, Nov 9, 2:08 AM
epriestley committed rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"… (authored by epriestley).
Improve recovery from panel action rendering exceptions, and mark "Changeset"…
Sat, Nov 9, 1:15 AM
epriestley closed T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor as Resolved by committing rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"….
Sat, Nov 9, 1:15 AM · Dashboards
epriestley closed D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Sat, Nov 9, 1:15 AM
epriestley requested review of D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Sat, Nov 9, 1:13 AM
epriestley added a revision to T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor: D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Sat, Nov 9, 1:12 AM · Dashboards
epriestley claimed T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor.
Sat, Nov 9, 1:09 AM · Dashboards
epriestley committed rPa3f4cbd7484b: Correct rendering of workboard column move stories when a single transaction… (authored by epriestley).
Correct rendering of workboard column move stories when a single transaction…
Sat, Nov 9, 12:57 AM
epriestley closed D20901: Correct rendering of workboard column move stories when a single transaction performs moves on multiple boards.
Sat, Nov 9, 12:57 AM
epriestley requested review of D20901: Correct rendering of workboard column move stories when a single transaction performs moves on multiple boards.
Sat, Nov 9, 12:56 AM
epriestley committed rPb83b3224bb75: Add an "Advanced/Developer..." action item for viewing object handle details… (authored by epriestley).
Add an "Advanced/Developer..." action item for viewing object handle details…
Sat, Nov 9, 12:47 AM
epriestley closed D20887: Add an "Advanced/Developer..." action item for viewing object handle details and hovercards.
Sat, Nov 9, 12:47 AM

Fri, Nov 8

epriestley committed rPcd60a8aa563b: Update various Asana odds-and-ends for "gid" API changes (authored by epriestley).
Update various Asana odds-and-ends for "gid" API changes
Fri, Nov 8, 5:08 PM
epriestley closed D20900: Update various Asana odds-and-ends for "gid" API changes.
Fri, Nov 8, 5:08 PM
epriestley requested review of D20900: Update various Asana odds-and-ends for "gid" API changes.
Fri, Nov 8, 5:03 PM
epriestley committed rP2223d6b91467: Update Asana Auth adapter for "gid" API changes (authored by epriestley).
Update Asana Auth adapter for "gid" API changes
Fri, Nov 8, 5:02 PM
epriestley closed D20899: Update Asana Auth adapter for "gid" API changes.
Fri, Nov 8, 5:02 PM
epriestley added a revision to T13453: Update Asana Auth Adapter for "gid" API changes: D20900: Update various Asana odds-and-ends for "gid" API changes.
Fri, Nov 8, 5:01 PM · Asana, Auth
epriestley requested review of D20899: Update Asana Auth adapter for "gid" API changes.
Fri, Nov 8, 5:01 PM
epriestley added a revision to T13453: Update Asana Auth Adapter for "gid" API changes: D20899: Update Asana Auth adapter for "gid" API changes.
Fri, Nov 8, 5:00 PM · Asana, Auth
epriestley added a comment to T13453: Update Asana Auth Adapter for "gid" API changes.

This may also impact the Doorkeeper integration, which reads "id" fields from a few calls.

Fri, Nov 8, 4:45 PM · Asana, Auth
epriestley triaged T13453: Update Asana Auth Adapter for "gid" API changes as Wishlist priority.
Fri, Nov 8, 4:44 PM · Asana, Auth
epriestley committed rP338b4cb2e709: Prevent workboard cards from being grabbed by the "Txxx" object name text (authored by epriestley).
Prevent workboard cards from being grabbed by the "Txxx" object name text
Fri, Nov 8, 4:30 PM
epriestley closed D20898: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Fri, Nov 8, 4:30 PM
epriestley closed T13452: Clarify behavior of object names on workboard cards as Resolved by committing rP338b4cb2e709: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Fri, Nov 8, 4:30 PM · Workboards
epriestley requested review of D20898: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Fri, Nov 8, 4:29 PM
epriestley added a revision to T13452: Clarify behavior of object names on workboard cards: D20898: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Fri, Nov 8, 4:28 PM · Workboards
epriestley triaged T13452: Clarify behavior of object names on workboard cards as Wishlist priority.
Fri, Nov 8, 4:24 PM · Workboards
epriestley added a comment to T13451: Chrome double-click selection behavior has changed in LayoutNG.

I'm planning to give Chrome some time to triage the report. If it sits there for a while or they decide it's how LayoutNG is going to handle this case, I'll look for workarounds. I don't think our intent/markup is totally unambiguous, and it may be reasonable to decide that this behavior is acceptable, even though Safari and Firefox have different behavior.

Fri, Nov 8, 4:10 PM · Google Chrome
epriestley updated the task description for T13451: Chrome double-click selection behavior has changed in LayoutNG.
Fri, Nov 8, 4:07 PM · Google Chrome
epriestley renamed T13451: Chrome double-click selection behavior has changed in LayoutNG from Chrome double-click selection behavior has changed in Chrome ~78? to Chrome double-click selection behavior has changed in LayoutNG.
Fri, Nov 8, 4:06 PM · Google Chrome
epriestley added a comment to T13451: Chrome double-click selection behavior has changed in LayoutNG.

Here's a simple reproduction case:

Fri, Nov 8, 4:05 PM · Google Chrome
epriestley triaged T13451: Chrome double-click selection behavior has changed in LayoutNG as Low priority.
Fri, Nov 8, 3:41 PM · Google Chrome
epriestley committed rPd4491ddc225e: Fix an issue with 1up diff block rendering for added or removed blocks (authored by epriestley).
Fix an issue with 1up diff block rendering for added or removed blocks
Fri, Nov 8, 3:37 PM
epriestley closed D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Fri, Nov 8, 3:37 PM
epriestley updated subscribers of D20897: Fix an issue with 1up diff block rendering for added or removed blocks.

See also https://discourse.phabricator-community.org/t/error-when-trying-to-view-jupyter-notebooks-changes-via-view-unified/3258.

Fri, Nov 8, 3:36 PM
epriestley updated the test plan for D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Fri, Nov 8, 3:36 PM
epriestley requested review of D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Fri, Nov 8, 3:36 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Fri, Nov 8, 3:35 PM · Differential
epriestley triaged T13450: Update "Renaming Instances" in Phacility documentation as Wishlist priority.
Fri, Nov 8, 2:27 AM · Phacility
epriestley added a subtask for T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes: T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules.
Fri, Nov 8, 12:57 AM · Custom Fields, Maniphest
epriestley added a parent task for T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules: T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.
Fri, Nov 8, 12:57 AM · Transactions