Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (492 w, 1 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Sun, Jul 12

epriestley requested review of D21418: Improve desktop and mobile layouts for new "CommitGridView".
Sun, Jul 12, 9:27 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21418: Improve desktop and mobile layouts for new "CommitGridView".
Sun, Jul 12, 9:26 PM · Differential
epriestley requested review of D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Sun, Jul 12, 7:47 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Sun, Jul 12, 7:45 PM · Differential
epriestley requested review of D21416: Clean up some minor commit list CSS.
Sun, Jul 12, 6:04 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21416: Clean up some minor commit list CSS.
Sun, Jul 12, 6:03 PM · Differential
epriestley requested review of D21415: Remove "PhabricatorAuditListView".
Sun, Jul 12, 5:45 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21415: Remove "PhabricatorAuditListView".
Sun, Jul 12, 5:44 PM · Differential
epriestley requested review of D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Sun, Jul 12, 4:26 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Sun, Jul 12, 4:25 PM · Differential
epriestley requested review of D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Sun, Jul 12, 4:17 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Sun, Jul 12, 4:16 PM · Differential
epriestley requested review of D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Sun, Jul 12, 3:44 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Sun, Jul 12, 3:41 PM · Differential

Sat, Jul 11

epriestley committed rARC2565cc7b4d1d: (stable) Promote 2020 Week 27 (authored by epriestley).
(stable) Promote 2020 Week 27
Sat, Jul 11, 4:34 PM
epriestley edited the content of Changelog.
Sat, Jul 11, 4:33 PM
epriestley committed rP2710a1e7aa42: (stable) Promote 2020 Week 27 (authored by epriestley).
(stable) Promote 2020 Week 27
Sat, Jul 11, 4:32 PM
epriestley created an object: 2020 Week 27 (Mid July).
Sat, Jul 11, 4:32 PM

Fri, Jul 10

epriestley requested review of D21411: Improve rendering of history graph in "CommitGraphView".
Fri, Jul 10, 6:46 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21411: Improve rendering of history graph in "CommitGraphView".
Fri, Jul 10, 6:44 PM · Differential
epriestley requested review of D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Fri, Jul 10, 6:22 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Fri, Jul 10, 6:20 PM · Differential
epriestley requested review of D21409: Remove the "Graph" view as a dedicated repository view.
Fri, Jul 10, 5:57 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21409: Remove the "Graph" view as a dedicated repository view.
Fri, Jul 10, 5:56 PM · Differential
epriestley requested review of D21408: Remove "Recent Commits" from repository landing page.
Fri, Jul 10, 5:49 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21408: Remove "Recent Commits" from repository landing page.
Fri, Jul 10, 5:48 PM · Differential
epriestley requested review of D21407: Remove "DiffusionTagTableView".
Fri, Jul 10, 4:27 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21407: Remove "DiffusionTagTableView".
Fri, Jul 10, 4:25 PM · Differential
epriestley requested review of D21406: Remove the "authored" subheader from commits.
Fri, Jul 10, 4:21 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21406: Remove the "authored" subheader from commits.
Fri, Jul 10, 4:20 PM · Differential
Krinkle awarded T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags a Orange Medal token.
Fri, Jul 10, 4:17 PM · Mail
epriestley requested review of D21405: Modernize "Author" and "Committer" rendering for commits.
Fri, Jul 10, 4:17 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21405: Modernize "Author" and "Committer" rendering for commits.
Fri, Jul 10, 4:16 PM · Differential
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

The broader structural issue here is:

Fri, Jul 10, 4:11 PM · Differential
epriestley requested review of D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Fri, Jul 10, 4:06 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Fri, Jul 10, 4:05 PM · Differential

Thu, Jul 9

epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

A second issue is that some of the "publish" behavior depends on the commit/revision relationship. This can still be sequenced correctly entirely in the publish daemon, but "close related revisions" and "publish the commit" are not entirely independent.

Thu, Jul 9, 10:24 PM · Differential
epriestley triaged T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Normal priority.
Thu, Jul 9, 10:13 PM · Differential
epriestley renamed T13361: Get rid of the "Actions" dropdown in Diffusion from Get rid of the "Actions" dropdown in in Diffusion to Get rid of the "Actions" dropdown in Diffusion.
Thu, Jul 9, 9:37 PM · Design, Diffusion
epriestley closed T13369: When a large number of commits are pushed to a repository, import them at lower priority as Resolved.

This appears stable.

Thu, Jul 9, 9:36 PM · Daemons, Diffusion
epriestley committed rP1d4d860cb5a0: Allow non-authors to "Request Review" of draft revisions (authored by epriestley).
Allow non-authors to "Request Review" of draft revisions
Thu, Jul 9, 9:21 PM
epriestley committed rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't… (authored by epriestley).
Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…
Thu, Jul 9, 9:21 PM
epriestley committed rPb21b73b8dd35: Expand Revision transaction API to allow actions to vary more broadly based on… (authored by epriestley).
Expand Revision transaction API to allow actions to vary more broadly based on…
Thu, Jul 9, 9:21 PM
epriestley closed D21403: Allow non-authors to "Request Review" of draft revisions.
Thu, Jul 9, 9:20 PM
epriestley closed D21401: Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state.
Thu, Jul 9, 9:20 PM
epriestley closed D21402: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers.
Thu, Jul 9, 9:20 PM
epriestley requested review of D21403: Allow non-authors to "Request Review" of draft revisions.
Thu, Jul 9, 9:11 PM
epriestley requested review of D21402: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers.
Thu, Jul 9, 9:02 PM
epriestley requested review of D21401: Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state.
Thu, Jul 9, 7:31 PM
epriestley requested review of D21400: Require rows passed to "loadAllFromArray()" have unique keys.
Thu, Jul 9, 5:58 PM
epriestley added a reverting change for D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly: D21400: Require rows passed to "loadAllFromArray()" have unique keys.
Thu, Jul 9, 5:56 PM
epriestley committed rP852e368cb777: (stable) Fix an issue where querying for a large number of projects by slug… (authored by epriestley).
(stable) Fix an issue where querying for a large number of projects by slug…
Thu, Jul 9, 5:50 PM
epriestley committed rP73c4240415e0: Add some additional patterns to the "filter Mercurial --debug output" list (authored by epriestley).
Add some additional patterns to the "filter Mercurial --debug output" list
Thu, Jul 9, 5:50 PM
epriestley closed D21398: Add some additional patterns to the "filter Mercurial --debug output" list.
Thu, Jul 9, 5:50 PM
epriestley committed rP56838c0e3dc2: Fix an issue where querying for a large number of projects by slug could… (authored by epriestley).
Fix an issue where querying for a large number of projects by slug could…
Thu, Jul 9, 5:50 PM
epriestley closed D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly.
Thu, Jul 9, 5:50 PM
epriestley requested review of D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly.
Thu, Jul 9, 5:49 PM
epriestley requested review of D21398: Add some additional patterns to the "filter Mercurial --debug output" list.
Thu, Jul 9, 5:35 PM
epriestley committed rARC65cda1596f25: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them… (authored by epriestley).
Preserve bookmarks across "hg rebase --keep --collapse", and destroy them…
Thu, Jul 9, 12:43 AM
epriestley closed D21397: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them before "hg strip/prune".
Thu, Jul 9, 12:43 AM

Wed, Jul 8

epriestley requested review of D21397: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them before "hg strip/prune".
Wed, Jul 8, 11:21 PM
epriestley committed rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception (authored by epriestley).
When "arc land" fails a Mercurial push, actually raise it as an exception
Wed, Jul 8, 10:30 PM
epriestley committed rARC354da1ddaa89: When saving and restoring local state in Mercurial, also save and restore… (authored by epriestley).
When saving and restoring local state in Mercurial, also save and restore…
Wed, Jul 8, 10:30 PM
epriestley committed rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly (authored by epriestley).
Clean up push failure messaging in "arc land" slightly
Wed, Jul 8, 10:30 PM
epriestley closed D21396: When saving and restoring local state in Mercurial, also save and restore bookmarks.
Wed, Jul 8, 10:30 PM
epriestley closed D21395: Clean up push failure messaging in "arc land" slightly.
Wed, Jul 8, 10:30 PM
epriestley closed D21394: When "arc land" fails a Mercurial push, actually raise it as an exception.
Wed, Jul 8, 10:30 PM
epriestley requested review of D21396: When saving and restoring local state in Mercurial, also save and restore bookmarks.
Wed, Jul 8, 9:37 PM
epriestley requested review of D21395: Clean up push failure messaging in "arc land" slightly.
Wed, Jul 8, 9:14 PM
epriestley requested review of D21394: When "arc land" fails a Mercurial push, actually raise it as an exception.
Wed, Jul 8, 9:12 PM

Tue, Jul 7

epriestley committed rARCe3ed781f363d: (stable) Fix additional Mercurial/Python compatibility issues in "arc land" (authored by epriestley).
(stable) Fix additional Mercurial/Python compatibility issues in "arc land"
Tue, Jul 7, 5:21 PM
epriestley committed rARC41774ba9cceb: Fix additional Mercurial/Python compatibility issues in "arc land" (authored by epriestley).
Fix additional Mercurial/Python compatibility issues in "arc land"
Tue, Jul 7, 5:20 PM
epriestley closed D21393: Fix additional Mercurial/Python compatibility issues in "arc land".
Tue, Jul 7, 5:20 PM
epriestley requested review of D21393: Fix additional Mercurial/Python compatibility issues in "arc land".
Tue, Jul 7, 5:19 PM

Mon, Jul 6

epriestley committed rARC1a54e1103c23: (stable) Allow "hg arc-ls-markers" to run under Python 2 or Python 3 (authored by epriestley).
(stable) Allow "hg arc-ls-markers" to run under Python 2 or Python 3
Mon, Jul 6, 10:34 PM
epriestley committed rARCa28e76b7b3df: Allow "hg arc-ls-markers" to run under Python 2 or Python 3 (authored by epriestley).
Allow "hg arc-ls-markers" to run under Python 2 or Python 3
Mon, Jul 6, 10:29 PM
epriestley closed D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Mon, Jul 6, 10:29 PM
epriestley requested review of D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Mon, Jul 6, 10:29 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Mon, Jul 6, 10:29 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

See PHI1807. At time of writing, arc land can delete the local master if you land it onto itself. This isn't a big deal (it gives you the command to get it back), but not intended and undesirable. Although it isn't recommended, arc land is supposed to support working in master and landing master into itself.

Mon, Jul 6, 10:00 PM · Arcanist
epriestley committed rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley).
(stable) Fix a MarkerRef call to get the active bookmark in Mercurial
Mon, Jul 6, 9:08 PM
epriestley committed rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley).
Fix a MarkerRef call to get the active bookmark in Mercurial
Mon, Jul 6, 9:08 PM
epriestley closed D21391: Fix a MarkerRef call to get the active bookmark in Mercurial.
Mon, Jul 6, 9:08 PM
epriestley requested review of D21391: Fix a MarkerRef call to get the active bookmark in Mercurial.
Mon, Jul 6, 9:06 PM

Fri, Jul 3

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Fri, Jul 3, 8:19 PM · Guides, Arcanist
epriestley edited the content of Changelog.
Fri, Jul 3, 8:13 PM
epriestley created an object: 2020 Week 26 (Early July).
Fri, Jul 3, 8:11 PM
epriestley committed rARC8795282286a7: (stable) Promote 2020 Week 26 (authored by epriestley).
(stable) Promote 2020 Week 26
Fri, Jul 3, 8:10 PM
epriestley committed rPb2f0937e300c: (stable) Promote 2020 Week 26 (authored by epriestley).
(stable) Promote 2020 Week 26
Fri, Jul 3, 8:10 PM
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Fri, Jul 3, 7:46 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Fri, Jul 3, 7:45 PM · Guides, Arcanist
epriestley committed rARCa5480609f870: Render the state tree in "arc branches" slightly more cleanly (authored by epriestley).
Render the state tree in "arc branches" slightly more cleanly
Fri, Jul 3, 7:43 PM
epriestley closed D21390: Render the state tree in "arc branches" slightly more cleanly.
Fri, Jul 3, 7:43 PM
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Fri, Jul 3, 7:43 PM · Guides, Arcanist
epriestley updated the diff for D21390: Render the state tree in "arc branches" slightly more cleanly.
  • Improve "stack" behavior.
Fri, Jul 3, 6:54 PM
epriestley requested review of D21390: Render the state tree in "arc branches" slightly more cleanly.
Fri, Jul 3, 6:40 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21390: Render the state tree in "arc branches" slightly more cleanly.
Fri, Jul 3, 6:39 PM · Arcanist
epriestley added a comment to T13551: "debug.time-limit" no longer functions in PHP7.

A sometimes-suitable replacement would be some bin/request mechanism which simulates a web request in process. There are some limits to how authentic this can be, but for some substantial subset of hangs it may still be useful.

Fri, Jul 3, 6:02 PM · Infrastructure

Wed, Jul 1

epriestley triaged T13551: "debug.time-limit" no longer functions in PHP7 as Wishlist priority.
Wed, Jul 1, 7:32 PM · Infrastructure
epriestley added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

PHI1776 is another report of this behavior.

Wed, Jul 1, 7:05 PM · Bug Report, Diffusion