Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (423 w, 3 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Yesterday

epriestley requested review of D20306: Add a "Play Sound" workboard trigger rule.
Thu, Mar 21, 10:28 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20306: Add a "Play Sound" workboard trigger rule.
Thu, Mar 21, 10:27 PM · Workboards (v3), Restricted Project
epriestley added a comment to T6415: Workboard drag and drop freezes indefinitely if it cannot access the server even temporarily.

After D20305, this can be "fixed" with this change:

Thu, Mar 21, 8:47 PM · Workboards
epriestley requested review of D20305: If the user cancels a workboard drop flow, put things back where they were.
Thu, Mar 21, 8:42 PM
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20305: If the user cancels a workboard drop flow, put things back where they were.
Thu, Mar 21, 8:41 PM · Workboards (v3), Plans, Projects
epriestley requested review of D20304: When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip.
Thu, Mar 21, 8:24 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20304: When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip.
Thu, Mar 21, 8:24 PM · Workboards (v3), Restricted Project
epriestley requested review of D20303: Show a trigger rule summary on the rule view page.
Thu, Mar 21, 7:32 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20303: Show a trigger rule summary on the rule view page.
Thu, Mar 21, 7:31 PM · Workboards (v3), Restricted Project
epriestley abandoned D16859: Let Herald know when workboard cards have been moved to another column.

Presumably soon-to-be obsoleted by changes on T5474.

Thu, Mar 21, 7:09 PM
epriestley commandeered D16859: Let Herald know when workboard cards have been moved to another column.
Thu, Mar 21, 7:08 PM
epriestley closed T10336: Animate changes to workboards as Wontfix.

We may still pursue this, especially after T4900, but a lot of the use cases / needs are mostly theoretical and it's not clear they're actually necessary. Some of the actual solutions (like T10335) may largely provide enough clarity about these cases on their own. I'm currently planning to wait for feedback about recent and near-future changes (including triggers) and then fix whatever issues arise surgically -- possibly through animation, but possibly through other UI/UX remedies.

Thu, Mar 21, 7:05 PM · Workboards (v3)
epriestley closed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint as Resolved.

Those changes haven't landed yet but I'm just going to tidy this up a little early, see T13074 for followups.

Thu, Mar 21, 7:00 PM · Workboards (v3)
epriestley requested review of D20302: Write workboard trigger rules to the database.
Thu, Mar 21, 6:53 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20302: Write workboard trigger rules to the database.
Thu, Mar 21, 6:52 PM · Workboards (v3), Restricted Project
epriestley requested review of D20301: Mostly make the editor UI for triggers work.
Thu, Mar 21, 4:44 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20301: Mostly make the editor UI for triggers work.
Thu, Mar 21, 4:43 PM · Workboards (v3), Restricted Project
epriestley added a comment to D20046: Read "$_POST" before hooking the profiler, and remove "aphront.default-application-configuration-class".

Please report issues you encounter with Phabricator via Discourse, not by commenting here.

Thu, Mar 21, 1:51 PM
kerberizer awarded T2334: Implement Google Calendar v3 API into Calendar a Love token.
Thu, Mar 21, 9:09 AM · Restricted Project, Prioritized, Calendar

Wed, Mar 20

epriestley requested review of D20300: Don't show workboard action previews if the action won't have any effect.
Wed, Mar 20, 2:35 AM
epriestley added a revision to T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint: D20300: Don't show workboard action previews if the action won't have any effect.
Wed, Mar 20, 2:33 AM · Workboards (v3)

Tue, Mar 19

epriestley requested review of D20299: Preview the effects of a drag-and-drop operation on workboards.
Tue, Mar 19, 11:10 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20299: Preview the effects of a drag-and-drop operation on workboards.
Tue, Mar 19, 11:09 PM · Workboards (v3), Restricted Project
epriestley added a revision to T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint: D20299: Preview the effects of a drag-and-drop operation on workboards.
Tue, Mar 19, 11:09 PM · Workboards (v3)
epriestley claimed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint.
Tue, Mar 19, 11:02 PM · Workboards (v3)
epriestley closed T13251: Upgrading: PhutilURI Query Parameter Changes as Resolved.

This seems to have quieted down, now.

Tue, Mar 19, 8:46 PM · Installing & Upgrading, Guides, Infrastructure
epriestley closed T13264: Maybe stack multiple breadcrumb sequences? as Wontfix.

Probably a bad idea but maybe I'll revisit this at some point.

Tue, Mar 19, 8:45 PM · Design
epriestley closed T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery" as Resolved.

I believe this is now resolved. See D20291 for technical details on the main issue and T13266 for a followup.

Tue, Mar 19, 8:45 PM · Diffusion
epriestley committed rPb90e02bec287: Select Ferret fulltext columns in results so fulltext queries work under UNION (authored by epriestley).
Select Ferret fulltext columns in results so fulltext queries work under UNION
Tue, Mar 19, 8:22 PM
epriestley added a commit to T13091: Ferret "Relevance" order does not always have all the columns it needs available: rPb90e02bec287: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Tue, Mar 19, 8:22 PM · Search
epriestley closed D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Tue, Mar 19, 8:22 PM
epriestley committed rPa8ba8217d84f: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query (authored by epriestley).
Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query
Tue, Mar 19, 8:20 PM
epriestley added a commit to T13091: Ferret "Relevance" order does not always have all the columns it needs available: rPa8ba8217d84f: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Tue, Mar 19, 8:20 PM · Search
epriestley closed D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Tue, Mar 19, 8:20 PM
epriestley updated the diff for D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
  • Also skip these columns in "WHERE" on the second page and beyond.
Tue, Mar 19, 8:16 PM
epriestley committed rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a… (authored by epriestley).
Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Tue, Mar 19, 8:04 PM
epriestley added a commit to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a….
Tue, Mar 19, 8:04 PM · Diffusion
epriestley closed D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Tue, Mar 19, 8:04 PM
epriestley committed rP18b444e427b0: When queries overheat, raise an exception (authored by epriestley).
When queries overheat, raise an exception
Tue, Mar 19, 8:03 PM
epriestley added a commit to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": rP18b444e427b0: When queries overheat, raise an exception.
Tue, Mar 19, 8:03 PM · Diffusion
epriestley closed D20294: When queries overheat, raise an exception.
Tue, Mar 19, 8:03 PM
epriestley committed rP8449c1793ace: Convert complex query subclasses to use internal cursors (authored by epriestley).
Convert complex query subclasses to use internal cursors
Tue, Mar 19, 8:02 PM
epriestley added a commit to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": rP8449c1793ace: Convert complex query subclasses to use internal cursors.
Tue, Mar 19, 8:02 PM · Diffusion
epriestley closed D20293: Convert complex query subclasses to use internal cursors.
Tue, Mar 19, 8:02 PM
epriestley committed rPd4847c3eeb78: Convert simple query subclasses to use internal cursors (authored by epriestley).
Convert simple query subclasses to use internal cursors
Tue, Mar 19, 8:00 PM
epriestley closed D20292: Convert simple query subclasses to use internal cursors.
Tue, Mar 19, 8:00 PM
epriestley added a commit to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": rPd4847c3eeb78: Convert simple query subclasses to use internal cursors.
Tue, Mar 19, 8:00 PM · Diffusion
epriestley committed rP1b0ef4391032: Separate internal and external Query Cursors more cleanly, to fix pagination… (authored by epriestley).
Separate internal and external Query Cursors more cleanly, to fix pagination…
Tue, Mar 19, 8:00 PM
epriestley closed D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.
Tue, Mar 19, 8:00 PM
epriestley added a commit to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": rP1b0ef4391032: Separate internal and external Query Cursors more cleanly, to fix pagination….
Tue, Mar 19, 8:00 PM · Diffusion
epriestley triaged T13266: Upgrading: Minor Changes to Query Paging / Cursors as Normal priority.
Tue, Mar 19, 6:51 PM · Installing & Upgrading
epriestley updated the diff for D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
  • Add a small explanatory comment pointing here.
Tue, Mar 19, 6:37 PM
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

Also, what is "By Relevance" ?

Tue, Mar 19, 6:34 PM · Search
epriestley requested review of D20298: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank > ...".
Tue, Mar 19, 6:26 PM
epriestley added a revision to T13091: Ferret "Relevance" order does not always have all the columns it needs available: D20298: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank > ...".
Tue, Mar 19, 6:24 PM · Search
epriestley updated the diff for D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
  • Remove the created/modified properties from the raw result row (this is just housekeeping, I don't believe it affects anything).
  • Move the _ft_magic strings to class constants (more housekeeping).
Tue, Mar 19, 2:28 PM

Mon, Mar 18

epriestley requested review of D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Mon, Mar 18, 11:09 PM
epriestley added a revision to T13091: Ferret "Relevance" order does not always have all the columns it needs available: D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Mon, Mar 18, 11:07 PM · Search
epriestley requested review of D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Mon, Mar 18, 10:53 PM
epriestley added a revision to T13091: Ferret "Relevance" order does not always have all the columns it needs available: D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Mon, Mar 18, 10:52 PM · Search
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

I also checked for more leftovers in instances/, but it looks like we don't have any non-default paging there.

Mon, Mar 18, 10:23 PM · Diffusion
epriestley added a commit to T11413: Support renaming Phacility instances: Unknown Object (Diffusion Commit).
Mon, Mar 18, 10:21 PM · Phacility
epriestley committed rPa6fd8f04792d: When performing complex edits, pause sub-editors before they publish to… (authored by epriestley).
When performing complex edits, pause sub-editors before they publish to…
Mon, Mar 18, 10:21 PM
epriestley closed D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.
Mon, Mar 18, 10:20 PM
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

I've poked around a fair bit locally, although I'm not totally confident I got every combination of paging columns and queries. I think anything that was missed is very likely to produce an explicit error rather than mysterious behavior, so I'm not too worried about it. Stuff to keep an eye on:

Mon, Mar 18, 10:12 PM · Diffusion
epriestley added inline comments to D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 10:04 PM
epriestley requested review of D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Mon, Mar 18, 9:53 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Mon, Mar 18, 9:52 PM · Diffusion
epriestley requested review of D20294: When queries overheat, raise an exception.
Mon, Mar 18, 9:42 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20294: When queries overheat, raise an exception.
Mon, Mar 18, 9:40 PM · Diffusion
epriestley added inline comments to D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:13 PM
epriestley added inline comments to D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:12 PM
epriestley requested review of D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:06 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:04 PM · Diffusion
epriestley added a child revision for D20292: Convert simple query subclasses to use internal cursors: D20293: Convert complex query subclasses to use internal cursors.
Mon, Mar 18, 9:04 PM
epriestley claimed T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
Mon, Mar 18, 9:02 PM · Diffusion
epriestley added inline comments to D20288: Hard code a "close task" action on every column Trigger.
Mon, Mar 18, 8:00 PM
epriestley added inline comments to D20287: Allow triggers to be attached to and removed from workboard columns.
Mon, Mar 18, 7:50 PM
epriestley requested review of D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 7:03 PM
epriestley updated the diff for D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.
  • Farewell, Herlad.
Mon, Mar 18, 7:03 PM
epriestley added a comment to D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.

🎺 HERE COMES HERLAD 🎺

Mon, Mar 18, 7:02 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 7:01 PM · Diffusion
epriestley added a child revision for D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects: D20292: Convert simple query subclasses to use internal cursors.
Mon, Mar 18, 7:01 PM
epriestley added a comment to D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.

Old sequence:

Mon, Mar 18, 6:27 PM
epriestley requested review of D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.
Mon, Mar 18, 6:21 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects.
Mon, Mar 18, 6:19 PM · Diffusion

Sat, Mar 16

epriestley edited the content of Changelog.
Sat, Mar 16, 9:20 PM
epriestley created 2019 Week 11 (Mid March).
Sat, Mar 16, 8:55 PM
epriestley committed rPHU564c7b305974: (stable) Promote 2019 Week 11 (authored by epriestley).
(stable) Promote 2019 Week 11
Sat, Mar 16, 8:55 PM
epriestley committed rPc767b045b245: (stable) Promote 2019 Week 11 (authored by epriestley).
(stable) Promote 2019 Week 11
Sat, Mar 16, 8:55 PM
epriestley placed T7607: Invoicing emails probably need some work up for grabs.
Sat, Mar 16, 8:41 PM · Phortune, Phacility
epriestley placed T11456: Don't lose user in NUX flow because of Timezone issues up for grabs.
Sat, Mar 16, 8:41 PM · Design, Phacility, NUX
epriestley placed T11132: New Phabricator NUX up for grabs.
Sat, Mar 16, 8:41 PM · Design, Phacility, NUX
epriestley placed T9515: Build a "quorum" mechanism and associated UI up for grabs.
Sat, Mar 16, 8:41 PM · Restricted Project, Notifications, Phacility, Auth
epriestley committed rPb469a5134ddd: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in… (authored by epriestley).
Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in…
Sat, Mar 16, 7:36 PM
epriestley closed T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer as Resolved by committing rPb469a5134ddd: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in….
Sat, Mar 16, 7:36 PM · Mail
epriestley closed D20285: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers".
Sat, Mar 16, 7:36 PM
epriestley updated the task description for T13263: Plans: 2019 Week 11 Bonus Content.
Sat, Mar 16, 7:34 PM · Plans
epriestley added a comment to D20279: Provide basic scaffolding for workboard column triggers.

On trigger names, I'm currently imagining that we're likely to end up with a "quick" workflow where you just pick some rules for a column and we don't make you name the trigger, and a "slow and thoughtful" workflow where you take time to set things up and name the triggers. Not sure that'll stick or exactly what it'll look like.

Sat, Mar 16, 2:29 AM

Fri, Mar 15

epriestley committed rP492b03628f19: Fix a typo in Drydock "Land" operations (authored by epriestley).
Fix a typo in Drydock "Land" operations
Fri, Mar 15, 9:53 PM