Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (427 w, 5 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Fri, Apr 19

epriestley committed rPa82a2b84599d: Simplify non-bare working copy rules for the new "git fetch" strategy (authored by epriestley).
Simplify non-bare working copy rules for the new "git fetch" strategy
Fri, Apr 19, 2:06 PM
epriestley closed D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Fri, Apr 19, 2:06 PM
epriestley committed rPe1076528ef76: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >… (authored by epriestley).
Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >…
Fri, Apr 19, 2:05 PM
epriestley closed D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Fri, Apr 19, 2:05 PM
epriestley planned changes to D20454: Treat chart functions as pipe/chain, instead of both configuring and evaluating through function composition.

Sleeping on this, "FunctionChain" should just be a function chain(...) or compose(...) or something, which evaluates as compose(f, g, h)(x) => f(g(h(x))).

Fri, Apr 19, 1:49 PM
epriestley added inline comments to D20454: Treat chart functions as pipe/chain, instead of both configuring and evaluating through function composition.
Fri, Apr 19, 1:25 AM
epriestley requested review of D20454: Treat chart functions as pipe/chain, instead of both configuring and evaluating through function composition.
Fri, Apr 19, 1:14 AM
epriestley accepted D20453: Improve timeline rendering for old macros.
Fri, Apr 19, 1:12 AM
epriestley added inline comments to D20446: Simplify implementation of "pure" Chart functions.
Fri, Apr 19, 12:13 AM
epriestley added a comment to D20452: Separate "accumulate(...)" from Fact functions.

On selecting a domain, you can build a chain like this:

Fri, Apr 19, 12:02 AM

Thu, Apr 18

epriestley added inline comments to D20446: Simplify implementation of "pure" Chart functions.
Thu, Apr 18, 11:45 PM
epriestley added a comment to D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.

In a future diff, scale() and shift() take two arguments and work, although I'm likely rethinking exactly how the composition/chaining part of this works (see D20452 for rambling).

Thu, Apr 18, 11:41 PM
epriestley abandoned D20452: Separate "accumulate(...)" from Fact functions.

I'm think I'm going to tackle this a little differently. Mostly more rambling:

Thu, Apr 18, 11:15 PM
epriestley added a comment to D20452: Separate "accumulate(...)" from Fact functions.

Also featured here is "load the data for all functions in the call tree, not just top-level functions".

Thu, Apr 18, 9:11 PM
epriestley requested review of D20452: Separate "accumulate(...)" from Fact functions.
Thu, Apr 18, 9:09 PM
epriestley added a revision to T13279: Build Charting for Facts: D20452: Separate "accumulate(...)" from Fact functions.
Thu, Apr 18, 9:07 PM · Plans, Facts
epriestley committed rPd8dba26a08f4: Add a "sin()" function to charts (authored by epriestley).
Add a "sin()" function to charts
Thu, Apr 18, 8:19 PM
epriestley closed D20444: Add a "sin()" function to charts.
Thu, Apr 18, 8:19 PM
epriestley committed rPc4e4448ee649: Add chart functions "x()" and "constant(3)" (authored by epriestley).
Add chart functions "x()" and "constant(3)"
Thu, Apr 18, 8:17 PM
epriestley closed D20443: Add chart functions "x()" and "constant(3)".
Thu, Apr 18, 8:16 PM
epriestley added inline comments to D20443: Add chart functions "x()" and "constant(3)".
Thu, Apr 18, 8:15 PM
epriestley committed rPcd2215fd4a69: Don't warn that workboard columns need a name when editing milestone columns (authored by epriestley).
Don't warn that workboard columns need a name when editing milestone columns
Thu, Apr 18, 8:13 PM
epriestley closed D20448: Don't warn that workboard columns need a name when editing milestone columns.
Thu, Apr 18, 8:13 PM
epriestley committed rP23d8f000f709: Select the domain (X-axis range) for charts before pulling data (authored by epriestley).
Select the domain (X-axis range) for charts before pulling data
Thu, Apr 18, 8:11 PM
epriestley closed D20442: Select the domain (X-axis range) for charts before pulling data.
Thu, Apr 18, 8:11 PM
epriestley updated the diff for D20442: Select the domain (X-axis range) for charts before pulling data.
  • Small simplification.
Thu, Apr 18, 8:08 PM
epriestley added inline comments to D20442: Select the domain (X-axis range) for charts before pulling data.
Thu, Apr 18, 8:07 PM
epriestley committed rP954831f5336b: Separate chart functions into a class tree (authored by epriestley).
Separate chart functions into a class tree
Thu, Apr 18, 8:06 PM
epriestley closed D20441: Separate chart functions into a class tree.
Thu, Apr 18, 8:06 PM
epriestley added a comment to D20441: Separate chart functions into a class tree.

Maybe the algorithm is:

Thu, Apr 18, 2:59 PM
epriestley added inline comments to D20441: Separate chart functions into a class tree.
Thu, Apr 18, 2:20 PM
epriestley committed rP45b3c23148d0: Fetch chart data via async request and redraw charts when the window is resized (authored by epriestley).
Fetch chart data via async request and redraw charts when the window is resized
Thu, Apr 18, 2:10 PM
epriestley closed D20440: Fetch chart data via async request and redraw charts when the window is resized.
Thu, Apr 18, 2:10 PM
epriestley committed rP044c6fbc19d4: Support drawing multiple functions on the same chart (authored by epriestley).
Support drawing multiple functions on the same chart
Thu, Apr 18, 2:07 PM
epriestley closed D20439: Support drawing multiple functions on the same chart.
Thu, Apr 18, 2:07 PM
epriestley added inline comments to D20439: Support drawing multiple functions on the same chart.
Thu, Apr 18, 2:07 PM
epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Unknown Object (Differential Revision).
Thu, Apr 18, 2:05 PM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

This could be made slightly cleaner with a setSummary() to set a shorter summary:

Thu, Apr 18, 2:02 PM · Auth, Security
epriestley requested review of D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Thu, Apr 18, 2:01 PM
epriestley committed rP02981f0add6d: Fix negative chart values, add storage for charts (authored by epriestley).
Fix negative chart values, add storage for charts
Thu, Apr 18, 1:59 PM
epriestley closed D20438: Fix negative chart values, add storage for charts.
Thu, Apr 18, 1:59 PM
epriestley added a revision to T13280: Permanent Refs Errata: D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Thu, Apr 18, 1:58 PM · Diffusion
epriestley added a comment to T13280: Permanent Refs Errata.

The git fetch change in D20421 does actually affect non-bare repositories:

Thu, Apr 18, 1:53 PM · Diffusion
epriestley added a comment to D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.

It looks like this does actually cause some issues with very old non-bare repositories. I'll follow up in T13280. I'm likely to move toward "users should convert these to bare repositories" over retaining non-bare support, since it's been at least like 4-5 years since we created non-bare repositories.

Thu, Apr 18, 1:45 PM
epriestley requested review of D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Thu, Apr 18, 1:43 PM
epriestley added a revision to T13279: Build Charting for Facts: D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Thu, Apr 18, 1:41 PM · Plans, Facts
epriestley added a comment to T13281: Draft revisions and the Herald "Is newly created" condition interact badly.

This is expected: the revision is not newly created.

Thu, Apr 18, 1:03 PM
epriestley added inline comments to D20435: In Git repositories, use "git symbolic-ref HEAD ..." to select the default branch.
Thu, Apr 18, 1:01 PM
epriestley closed T13281: Draft revisions and the Herald "Is newly created" condition interact badly as Invalid.

This is expected: the revision is not newly created.

Thu, Apr 18, 1:00 PM
epriestley committed rPfaf0a311ec9e: In Git repositories, use "git symbolic-ref HEAD ..." to select the default… (authored by epriestley).
In Git repositories, use "git symbolic-ref HEAD ..." to select the default…
Thu, Apr 18, 12:46 PM
epriestley closed T5963: Hosted repos could set default branch in HEAD to help new clones as Resolved by committing rPfaf0a311ec9e: In Git repositories, use "git symbolic-ref HEAD ..." to select the default….
Thu, Apr 18, 12:46 PM · Diffusion
epriestley closed D20435: In Git repositories, use "git symbolic-ref HEAD ..." to select the default branch.
Thu, Apr 18, 12:46 PM
epriestley committed rP7be671fb0750: Update "Autoclose" documentation to focus on "Permanent Refs" instead (authored by epriestley).
Update "Autoclose" documentation to focus on "Permanent Refs" instead
Thu, Apr 18, 12:43 PM
epriestley closed D20434: Update "Autoclose" documentation to focus on "Permanent Refs" instead.
Thu, Apr 18, 12:43 PM
epriestley added inline comments to D20434: Update "Autoclose" documentation to focus on "Permanent Refs" instead.
Thu, Apr 18, 12:42 PM
epriestley updated the diff for D20434: Update "Autoclose" documentation to focus on "Permanent Refs" instead.
  • Mention refs/notes.
Thu, Apr 18, 12:42 PM
epriestley committed rPc33f544e7417: Deprecate "Track Only" in the Diffusion UI (authored by epriestley).
Deprecate "Track Only" in the Diffusion UI
Thu, Apr 18, 12:40 PM
epriestley changed the status of T12967: Mercurical branches don't display tracking status properly from Wontfix to Resolved by committing rPc33f544e7417: Deprecate "Track Only" in the Diffusion UI.
Thu, Apr 18, 12:40 PM · Diffusion, Bug Report
epriestley closed D20433: Deprecate "Track Only" in the Diffusion UI.
Thu, Apr 18, 12:40 PM
epriestley committed rP6449a0ecb2da: Rename some internal "Autoclose" mentions to "Permanent Refs" (authored by epriestley).
Rename some internal "Autoclose" mentions to "Permanent Refs"
Thu, Apr 18, 12:38 PM
epriestley closed D20432: Rename some internal "Autoclose" mentions to "Permanent Refs".
Thu, Apr 18, 12:38 PM
epriestley committed rPd1223ac577e8: When a commit appears as an ancestor of a permanent ref for the first time, run… (authored by epriestley).
When a commit appears as an ancestor of a permanent ref for the first time, run…
Thu, Apr 18, 12:37 PM
epriestley closed D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.
Thu, Apr 18, 12:37 PM
epriestley requested review of D20448: Don't warn that workboard columns need a name when editing milestone columns.
Thu, Apr 18, 12:33 PM
epriestley committed rP9107c2e26208: Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field (authored by epriestley).
Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field
Thu, Apr 18, 12:32 PM
epriestley closed D20427: Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field.
Thu, Apr 18, 12:32 PM
epriestley committed rPaed755e1d88b: Expose repository ref rules via "diffusion.repository.search" (authored by epriestley).
Expose repository ref rules via "diffusion.repository.search"
Thu, Apr 18, 12:27 PM
epriestley closed D20426: Expose repository ref rules via "diffusion.repository.search".
Thu, Apr 18, 12:27 PM
epriestley added inline comments to D20426: Expose repository ref rules via "diffusion.repository.search".
Thu, Apr 18, 12:27 PM
epriestley committed rP7a4ef2bad876: Move the repository "Publishing" option to the "Basics" panel in repository… (authored by epriestley).
Move the repository "Publishing" option to the "Basics" panel in repository…
Thu, Apr 18, 12:24 PM
epriestley closed D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.
Thu, Apr 18, 12:24 PM
epriestley updated the diff for D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.
  • Wordsmithing.
  • Clarify that "reactivate" is not retroactive.
Thu, Apr 18, 12:22 PM
epriestley committed rPec9237fe13c5: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off" (authored by epriestley).
In repository settings, fold "Autoclose On/Off" into "Publishing On/Off"
Thu, Apr 18, 12:17 PM
epriestley closed D20424: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off".
Thu, Apr 18, 12:17 PM
epriestley committed rPc7b2553ca084: Rename most user-facing "Autoclose" strings to "Permanent Refs" (authored by epriestley).
Rename most user-facing "Autoclose" strings to "Permanent Refs"
Thu, Apr 18, 12:14 PM
epriestley closed D20423: Rename most user-facing "Autoclose" strings to "Permanent Refs".
Thu, Apr 18, 12:14 PM
epriestley updated the diff for D20423: Rename most user-facing "Autoclose" strings to "Permanent Refs".
  • Fix "in/is unavailable" typo.
  • Clarify that we aren't going to banish other refs to the shadow realm.
Thu, Apr 18, 12:12 PM
epriestley updated the task description for T13280: Permanent Refs Errata.
Thu, Apr 18, 12:10 PM · Diffusion
epriestley committed rPe910c76e65e5: Add "Fetch Rules" to observed Git repositories (authored by epriestley).
Add "Fetch Rules" to observed Git repositories
Thu, Apr 18, 12:09 PM
epriestley closed D20422: Add "Fetch Rules" to observed Git repositories.
Thu, Apr 18, 12:09 PM
epriestley triaged T13280: Permanent Refs Errata as Normal priority.
Thu, Apr 18, 12:09 PM · Diffusion
epriestley committed rP78aab6d4a56f: When observing a repository in Git, just "fetch <url>" without worrying about… (authored by epriestley).
When observing a repository in Git, just "fetch <url>" without worrying about…
Thu, Apr 18, 12:05 PM
epriestley closed D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.
Thu, Apr 18, 12:05 PM
epriestley committed rP1cda1402c7c2: Do not publish/notify about commits which are not reachable from any… (authored by epriestley).
Do not publish/notify about commits which are not reachable from any…
Thu, Apr 18, 12:05 PM
epriestley closed D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
Thu, Apr 18, 12:05 PM
epriestley committed rP904dbf0db666: Make the "git upload-pack" proxy more robust (authored by epriestley).
Make the "git upload-pack" proxy more robust
Thu, Apr 18, 12:04 PM
epriestley closed D20436: Make the "git upload-pack" proxy more robust.
Thu, Apr 18, 12:04 PM
epriestley updated the diff for D20436: Make the "git upload-pack" proxy more robust.
  • Update the "final frame" comment to make the "pass it through, but later" part more clear.
Thu, Apr 18, 12:02 PM
epriestley added a comment to D20436: Make the "git upload-pack" proxy more robust.
Thu, Apr 18, 11:59 AM
epriestley committed rPe08ba99dd3db: Proxy the "git upload-pack" wire protocol (authored by epriestley).
Proxy the "git upload-pack" wire protocol
Thu, Apr 18, 11:58 AM
epriestley closed D20381: Proxy the "git upload-pack" wire protocol.
Thu, Apr 18, 11:58 AM
epriestley committed rP35539a019ce1: Add an optional protocol log to `git` SSH workflows (authored by epriestley).
Add an optional protocol log to `git` SSH workflows
Thu, Apr 18, 11:57 AM
epriestley closed D20380: Add an optional protocol log to `git` SSH workflows.
Thu, Apr 18, 11:57 AM
mormegil awarded rPc648077625e3: Don't warn about a locked database value after users run "bin/auth lock" a Haypence token.
Thu, Apr 18, 11:12 AM
epriestley committed rPc648077625e3: Don't warn about a locked database value after users run "bin/auth lock" (authored by epriestley).
Don't warn about a locked database value after users run "bin/auth lock"
Thu, Apr 18, 2:54 AM
epriestley closed D20447: Don't warn about a locked database value after users run "bin/auth lock".
Thu, Apr 18, 2:54 AM
epriestley edited the content of Changelog.
Thu, Apr 18, 1:56 AM
epriestley created 2019 Week 16 (Late April).
Thu, Apr 18, 1:55 AM
epriestley committed rPHU3e6a9946bcfc: (stable) Promote 2019 Week 16 (authored by epriestley).
(stable) Promote 2019 Week 16
Thu, Apr 18, 1:53 AM
epriestley committed rPf040a591e617: (stable) Promote 2019 Week 16 (authored by epriestley).
(stable) Promote 2019 Week 16
Thu, Apr 18, 1:53 AM