Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (478 w, 1 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Yesterday

epriestley committed rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;" (authored by epriestley).
Fix improper XHPAST parsing of namespace grammar like "use x as private;"
Tue, Apr 7, 9:35 PM
epriestley closed D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".
Tue, Apr 7, 9:35 PM
epriestley committed rARCe03431def8c0: Fix XHPAST parsing of variadic calls (authored by epriestley).
Fix XHPAST parsing of variadic calls
Tue, Apr 7, 9:33 PM
epriestley closed D21067: Fix XHPAST parsing of variadic calls.
Tue, Apr 7, 9:33 PM
epriestley committed rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format (authored by epriestley).
Update XHPAST "expect" test blocks to the new stable, human-readable format
Tue, Apr 7, 9:32 PM
epriestley closed D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.
Tue, Apr 7, 9:32 PM
epriestley committed rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable (authored by epriestley).
Make XHPAST unit test "expect" blocks stable and human-readable
Tue, Apr 7, 9:32 PM
epriestley closed D21065: Make XHPAST unit test "expect" blocks stable and human-readable.
Tue, Apr 7, 9:32 PM
epriestley committed rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code (authored by epriestley).
Remove duplication of XHPAST version in PHP and C code
Tue, Apr 7, 9:31 PM
epriestley closed D21064: Remove duplication of XHPAST version in PHP and C code.
Tue, Apr 7, 9:31 PM
epriestley committed rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3 (authored by epriestley).
Revert xhpast changes that impacted builds under Bison 2.3
Tue, Apr 7, 9:29 PM
epriestley closed D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:29 PM
epriestley closed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) as Resolved by committing rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:29 PM · XHPAST
epriestley abandoned D17820: Replace all the PHPAST JSON test data with readable test data.

Superseded by D21066.

Tue, Apr 7, 9:28 PM
epriestley closed T4334: Support PHP5.4+ syntax in XHPAST as Resolved.

Much of this is supported now; T13492 has some general followup.

Tue, Apr 7, 9:27 PM · XHPAST
epriestley requested review of D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".
Tue, Apr 7, 9:25 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".
Tue, Apr 7, 9:24 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

XHPAST currently can not parse $x = yield $y;.

Tue, Apr 7, 9:21 PM · Infrastructure
epriestley requested review of D21065: Make XHPAST unit test "expect" blocks stable and human-readable.

Test failures are expected.

Tue, Apr 7, 9:14 PM
epriestley requested review of D21067: Fix XHPAST parsing of variadic calls.
Tue, Apr 7, 9:13 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21067: Fix XHPAST parsing of variadic calls.
Tue, Apr 7, 9:12 PM · Infrastructure
epriestley requested review of D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.
Tue, Apr 7, 9:11 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.
Tue, Apr 7, 9:11 PM · Infrastructure
epriestley added a comment to D17819: Make PHPAST parser tests stable and human-readable.

(This was ultimately superseded by D21065.)

Tue, Apr 7, 9:09 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21065: Make XHPAST unit test "expect" blocks stable and human-readable.
Tue, Apr 7, 9:08 PM · Infrastructure
epriestley requested review of D21064: Remove duplication of XHPAST version in PHP and C code.
Tue, Apr 7, 9:05 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21064: Remove duplication of XHPAST version in PHP and C code.
Tue, Apr 7, 9:04 PM · Infrastructure
epriestley renamed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) from XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) to XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
Tue, Apr 7, 9:03 PM · XHPAST
epriestley requested review of D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:02 PM
epriestley added a revision to T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3): D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:02 PM · XHPAST
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

This is entangled with T9753.

Tue, Apr 7, 2:08 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

XHPAST currently can not parse $x = yield $y;. I suspect this was added to the PHP grammar after XHPAST diverged. I'm hopeful the fix is straightforward.

Tue, Apr 7, 1:53 PM · Infrastructure
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to Windows on the XHPAST board.
Tue, Apr 7, 1:33 PM · Windows, XHPAST
epriestley moved T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings from Backlog to Windows on the XHPAST board.
Tue, Apr 7, 1:33 PM · XHPAST
epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Future on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST, Arcanist
epriestley closed T7301: XHPAST application is not optimized for mobile as Wontfix.

No current plans to pursue this.

Tue, Apr 7, 1:32 PM · XHPAST, Mobile
epriestley moved T10971: php lint: catch `"${var}"` vs `"{$var}"` from Backlog to String Variables on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST, Lint, Feature Request
epriestley moved T11081: XHPAST doesn't handle complex embedded variables in strings using the same quoting style from Backlog to String Variables on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST, Bug Report
epriestley moved T8049: Improve parsing of variables embedded in strings in XHPAST from Backlog to String Variables on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST
epriestley triaged T9286: XHPAST fails to recognize inline HTML starting with "<?php" as Wishlist priority.
Tue, Apr 7, 1:31 PM · XHPAST
epriestley moved T9286: XHPAST fails to recognize inline HTML starting with "<?php" from Backlog to Future on the XHPAST board.
Tue, Apr 7, 1:31 PM · XHPAST
epriestley renamed T8325: XHPASTLinter does not scope parameters to closures correctly from Treat functions with parameters defined in other functions in XHPASTLinter correctly to XHPASTLinter does not scope parameters to closures correctly.
Tue, Apr 7, 1:31 PM · XHPAST, Lint
epriestley moved T8325: XHPASTLinter does not scope parameters to closures correctly from Backlog to Future on the XHPAST board.
Tue, Apr 7, 1:30 PM · XHPAST, Lint
epriestley closed T9062: Generalize PHPAST application as Wontfix.

No plans to pursue this.

Tue, Apr 7, 1:29 PM · XHPAST
epriestley closed T8534: Need a way to retrieve fully qualified class name as Wontfix.

No longer clear what this accomplishes.

Tue, Apr 7, 1:29 PM · XHPAST
epriestley closed T6195: Replace XHPAST with a pure PHP implementation as Wontfix.

I don't currently plan to pursue this.

Tue, Apr 7, 1:28 PM · XHPAST
epriestley closed T10257: xhpast does not build on ARM hardware as Wontfix.

This is very old and we have no outstanding customer requests for ARM support.

Tue, Apr 7, 1:27 PM · XHPAST, Bug Report

Mon, Apr 6

epriestley closed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given" as Resolved.

I deployed D21062, and the three examples in the original report look good now. I checked about a dozen other pages and couldn't find anything else broken; let me know if I missed anything. Thanks for the report!

Mon, Apr 6, 7:02 PM · Diviner
epriestley committed rP58fbf64a2786: Refine handling of "@task" attributes in Diviner (authored by epriestley).
Refine handling of "@task" attributes in Diviner
Mon, Apr 6, 6:51 PM
epriestley closed D21062: Refine handling of "@task" attributes in Diviner.
Mon, Apr 6, 6:51 PM
epriestley requested review of D21062: Refine handling of "@task" attributes in Diviner.
Mon, Apr 6, 6:51 PM
epriestley added a revision to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given": D21062: Refine handling of "@task" attributes in Diviner.
Mon, Apr 6, 6:50 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

The second issue is that the API still returns a string when there is exactly one @attribute of a given type. This is a bit goofy; PhutilExecChannel is another example case.

Mon, Apr 6, 6:47 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

I deployed D21061. First two example pages are good now, third one is hitting a different error. New trace is:

Mon, Apr 6, 6:45 PM · Diviner
aklapper awarded T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given" a Like token.
Mon, Apr 6, 6:43 PM · Diviner
epriestley committed rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API (authored by epriestley).
Update DivinerAtomController for a long-ago change to the docblock parser API
Mon, Apr 6, 6:31 PM
epriestley closed D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Mon, Apr 6, 6:31 PM
epriestley requested review of D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Mon, Apr 6, 6:22 PM
epriestley added a revision to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given": D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Mon, Apr 6, 6:21 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

Docblocks may have multiple copies of the same @attribute directive, like this:

Mon, Apr 6, 6:19 PM · Diviner
epriestley claimed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Mon, Apr 6, 6:11 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

Here's the full stack trace:

Mon, Apr 6, 6:11 PM · Diviner
epriestley committed rARC33dc2fe8194d: Allow "phage" to print execution status on SIGINT (authored by epriestley).
Allow "phage" to print execution status on SIGINT
Mon, Apr 6, 6:09 PM
epriestley closed D21060: Allow "phage" to print execution status on SIGINT.
Mon, Apr 6, 6:09 PM
epriestley requested review of D21060: Allow "phage" to print execution status on SIGINT.
Mon, Apr 6, 6:09 PM
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: D21060: Allow "phage" to print execution status on SIGINT.
Mon, Apr 6, 6:08 PM · Arcanist
epriestley closed T13499: Make "undefined index" PHP errors throw a RuntimeException as Resolved.

One long-standing warning in a unit test cropped up (D21055) but if this does have far-reaching implications, they don't seem terribly obvious/common.

Mon, Apr 6, 2:26 PM · Infrastructure
epriestley closed T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as Resolved.

Character encoding issues aren't stable yet (see also T13500) but I think everything else here is.

Mon, Apr 6, 2:25 PM · Windows

Sun, Apr 5

epriestley committed rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley).
(stable) Whitelist "vscode://" as an allowed Editor protocol
Sun, Apr 5, 4:47 PM
epriestley committed rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline… (authored by epriestley).
(stable) Add an "isDone" flag to "transaction.search" for Differential inline…
Sun, Apr 5, 4:37 PM
epriestley committed rPf1d1ec3d77f1: Add an "isDone" flag to "transaction.search" for Differential inline comments (authored by epriestley).
Add an "isDone" flag to "transaction.search" for Differential inline comments
Sun, Apr 5, 4:36 PM
epriestley closed D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments.
Sun, Apr 5, 4:36 PM
epriestley requested review of D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments.
Sun, Apr 5, 4:05 PM
epriestley committed rARC32005f26a4e7: Move Phage to FuturePool (authored by epriestley).
Move Phage to FuturePool
Sun, Apr 5, 12:56 PM
epriestley closed D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:56 PM
epriestley requested review of D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:51 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:50 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist

Fri, Apr 3

epriestley committed rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother… (authored by epriestley).
(stable) If daemon running-as-user setup check fails its query, don't bother…
Fri, Apr 3, 11:29 PM
epriestley committed rP33b73d887ae3: If daemon running-as-user setup check fails its query, don't bother with it (authored by epriestley).
If daemon running-as-user setup check fails its query, don't bother with it
Fri, Apr 3, 11:19 PM
epriestley closed D21057: If daemon running-as-user setup check fails its query, don't bother with it.
Fri, Apr 3, 11:19 PM
epriestley requested review of D21057: If daemon running-as-user setup check fails its query, don't bother with it.
Fri, Apr 3, 11:13 PM
epriestley committed rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref… (authored by epriestley).
Improve performance when marking commits as unreachable after multiple ref…
Fri, Apr 3, 8:29 PM
epriestley committed rP1e7cc72cd835: Improve performance when marking commits as unreachable after multiple ref… (authored by epriestley).
Improve performance when marking commits as unreachable after multiple ref…
Fri, Apr 3, 8:28 PM
epriestley closed D21056: Improve performance when marking commits as unreachable after multiple ref deletions.
Fri, Apr 3, 8:28 PM
epriestley requested review of D21056: Improve performance when marking commits as unreachable after multiple ref deletions.
Fri, Apr 3, 8:28 PM
epriestley committed rP1a59cae743c2: Update some Phabricator behaviors for changes to Futures (authored by epriestley).
Update some Phabricator behaviors for changes to Futures
Fri, Apr 3, 7:28 PM
epriestley closed D21054: Update some Phabricator behaviors for changes to Futures.
Fri, Apr 3, 7:28 PM
epriestley requested review of D21054: Update some Phabricator behaviors for changes to Futures.
Fri, Apr 3, 7:27 PM
epriestley committed rP067b04aaf148: If HTTP response headers are already sent, don't fiddle with "zlib. (authored by epriestley).
If HTTP response headers are already sent, don't fiddle with "zlib.
Fri, Apr 3, 7:25 PM
epriestley closed D21055: If HTTP response headers are already sent, don't fiddle with "zlib.output_compression".
Fri, Apr 3, 7:25 PM
epriestley requested review of D21055: If HTTP response headers are already sent, don't fiddle with "zlib.output_compression".
Fri, Apr 3, 7:22 PM
epriestley committed rARC099c2ae64845: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures (authored by epriestley).
Introduce "FuturePool" to make it easier to manage an ongoing pool of futures
Fri, Apr 3, 7:05 PM
epriestley closed D21053: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures.
Fri, Apr 3, 7:05 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21054: Update some Phabricator behaviors for changes to Futures.
Fri, Apr 3, 7:03 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley requested review of D21053: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures.
Fri, Apr 3, 6:57 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21053: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures.
Fri, Apr 3, 6:56 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

XHPAST currently can't build an AST for $result = yield ..., even though this is a valid construct. This is probably a straightforward fix.

Fri, Apr 3, 2:38 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley removed 1 auditor(s) for rARC4d55067fd87f: Make the "result" property on Future private: epriestley.
Fri, Apr 3, 2:03 PM

Thu, Apr 2

epriestley added a comment to T13500: During startup, guarantee "(string)1.23" is "1.23", not "1,23".

See also T13209.

Thu, Apr 2, 11:32 PM · Arcanist
epriestley committed rARC368aec16a1ee: Update some ancient "set X=Y" environment code for new Windows execution… (authored by epriestley).
Update some ancient "set X=Y" environment code for new Windows execution…
Thu, Apr 2, 8:51 PM