Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (532 w, 2 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Wed, Apr 14

epriestley triaged T13651: Most complex variation of "column" transaction type in "maniphest.edit" fails to validate as Low priority.
Wed, Apr 14, 7:13 PM · Maniphest

Thu, Apr 8

epriestley added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Yes. I closed down registration on this install (secure.phabricator.com) several years ago because the overwhelming majority of users who registered accounts here didn't read or follow the rules. Access to secure.phabricator.com is now invite-only.

Thu, Apr 8, 12:53 PM · Security, Git

Wed, Apr 7

epriestley closed D21662: Don't attempt to test capabilities on incomplete handles.
Wed, Apr 7, 9:56 PM
epriestley committed rP95662ae8f1a7: Don't attempt to test capabilities on incomplete handles (authored by epriestley).
Don't attempt to test capabilities on incomplete handles
Wed, Apr 7, 9:56 PM
epriestley requested review of D21662: Don't attempt to test capabilities on incomplete handles.
Wed, Apr 7, 9:54 PM
epriestley added a comment to D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..

Ah, I think it's:

Wed, Apr 7, 9:46 PM
epriestley added a comment to D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..

(This might need to be sprite-sheeted too, but I think the sprite stuff hasn't been used in years -- since we switched pretty much everything to icon fonts -- and don't remember exactly how it works. I can look into it and do the actual bin/uh-generate-a-sprite-sheet or whatever in a followup.)

Wed, Apr 7, 9:42 PM
epriestley accepted D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..

Thanks!

Wed, Apr 7, 9:41 PM

Tue, Apr 6

epriestley triaged T13649: Address higher-impact `arc` toolsets behaviors as Normal priority.
Tue, Apr 6, 3:54 PM · Arcanist

Mon, Mar 29

epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Mon, Mar 29, 4:44 PM · Almanac, Infrastructure, Phacility
epriestley committed rP5efe7fb4c181: On inline comments, track an explicit "committed" content state (authored by epriestley).
On inline comments, track an explicit "committed" content state
Mon, Mar 29, 4:01 PM
epriestley committed rP1308a5555fee: Update client logic for inline comment "Save" and "Cancel" actions (authored by epriestley).
Update client logic for inline comment "Save" and "Cancel" actions
Mon, Mar 29, 4:01 PM
epriestley committed rP6fd55d692f14: Formally track "initial", "committed", and "active" states for inline comments (authored by epriestley).
Formally track "initial", "committed", and "active" states for inline comments
Mon, Mar 29, 4:01 PM
epriestley committed rPb75517918d86: When creating an inline comment, populate the content state with the default… (authored by epriestley).
When creating an inline comment, populate the content state with the default…
Mon, Mar 29, 4:01 PM
epriestley committed rP428fff2e58f3: Fix an issue when undoing mutiple inline comment deletions (authored by epriestley).
Fix an issue when undoing mutiple inline comment deletions
Mon, Mar 29, 4:01 PM
epriestley closed D21651: On inline comments, track an explicit "committed" content state.
Mon, Mar 29, 4:01 PM
epriestley closed D21653: Formally track "initial", "committed", and "active" states for inline comments.
Mon, Mar 29, 4:01 PM
epriestley closed D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Mon, Mar 29, 4:01 PM
epriestley closed D21652: When creating an inline comment, populate the content state with the default suggestion text.
Mon, Mar 29, 4:00 PM
epriestley closed D21650: Fix an issue when undoing mutiple inline comment deletions.
Mon, Mar 29, 4:00 PM
epriestley committed rPd30c3a961cd9: Make the client authoritative for "Cancel" actions (authored by epriestley).
Make the client authoritative for "Cancel" actions
Mon, Mar 29, 4:00 PM
epriestley committed rP60e869f4114f: Make the client authoritative for "Save" actions (authored by epriestley).
Make the client authoritative for "Save" actions
Mon, Mar 29, 4:00 PM
epriestley closed D21649: Make the client authoritative for "Cancel" actions.
Mon, Mar 29, 4:00 PM
epriestley committed rPb964731b6a6b: Make inline "ContentState" a client object, and track "hasSuggestion" on it (authored by epriestley).
Make inline "ContentState" a client object, and track "hasSuggestion" on it
Mon, Mar 29, 4:00 PM
epriestley committed rPcb00cb99e244: Make client inlines track an "active" state (authored by epriestley).
Make client inlines track an "active" state
Mon, Mar 29, 4:00 PM
epriestley committed rP87c6c270b435: Fix an issue where inlines could be duplicated in the client list (authored by epriestley).
Fix an issue where inlines could be duplicated in the client list
Mon, Mar 29, 4:00 PM
epriestley committed rP0f04d9e58458: Remove direct reads of form state from main Inline client code (authored by epriestley).
Remove direct reads of form state from main Inline client code
Mon, Mar 29, 4:00 PM
epriestley closed D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mon, Mar 29, 4:00 PM
epriestley closed D21648: Make the client authoritative for "Save" actions.
Mon, Mar 29, 4:00 PM
epriestley closed D21642: Fix an issue where inlines could be duplicated in the client list.
Mon, Mar 29, 4:00 PM
epriestley closed D21646: Make client inlines track an "active" state.
Mon, Mar 29, 4:00 PM
epriestley closed D21647: Remove direct reads of form state from main Inline client code.
Mon, Mar 29, 4:00 PM

Sun, Mar 28

epriestley committed rP2afedad61c51: (stable) Skip "git for-each-ref" when identifying deleted commits (authored by epriestley).
(stable) Skip "git for-each-ref" when identifying deleted commits
Sun, Mar 28, 6:16 PM
epriestley committed rPaa70b008f3a1: Skip "git for-each-ref" when identifying deleted commits (authored by epriestley).
Skip "git for-each-ref" when identifying deleted commits
Sun, Mar 28, 6:04 PM
epriestley closed D21658: Skip "git for-each-ref" when identifying deleted commits.
Sun, Mar 28, 6:04 PM
epriestley requested review of D21658: Skip "git for-each-ref" when identifying deleted commits.
Sun, Mar 28, 5:59 PM
epriestley added a revision to T13647: Reduce repository update cost for repositories with large numbers of refs: D21658: Skip "git for-each-ref" when identifying deleted commits.
Sun, Mar 28, 5:58 PM · Diffusion
epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

One call to for-each-ref comes from resolving a list of commit hashes, to test if they still exist. This is accomplished with DiffusionLowLevelResolveRefsQuery, which calls git for-each-ref first and falls back to git cat-file --batch-check.

Sun, Mar 28, 5:44 PM · Diffusion
epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

Has this repository changed?

Sun, Mar 28, 5:25 PM · Diffusion

Sat, Mar 27

epriestley committed rP33c847e667b6: (stable) Correct issue with "bindings" conduit attachment (authored by epriestley).
(stable) Correct issue with "bindings" conduit attachment
Sat, Mar 27, 4:26 PM
epriestley committed rP5b8b5f214148: Correct issue with "bindings" conduit attachment (authored by epriestley).
Correct issue with "bindings" conduit attachment
Sat, Mar 27, 4:26 PM
epriestley closed D21657: Correct issue with "bindings" conduit attachment.
Sat, Mar 27, 4:26 PM
epriestley requested review of D21657: Correct issue with "bindings" conduit attachment.
Sat, Mar 27, 4:26 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21657: Correct issue with "bindings" conduit attachment.
Sat, Mar 27, 4:25 PM · Almanac
epriestley triaged T13648: Transaction publishing may stall during mail expansion of package recipients as Wishlist priority.
Sat, Mar 27, 2:57 PM · Transactions

Fri, Mar 26

epriestley triaged T13647: Reduce repository update cost for repositories with large numbers of refs as Normal priority.
Fri, Mar 26, 11:09 PM · Diffusion
epriestley closed T13639: Allow revisions to be queried by affected path via the API as Resolved.

This is now in stable; presuming it works until evidence to the contrary emerges.

Fri, Mar 26, 6:08 PM · Conduit, Differential
epriestley edited the content of Changelog.
Fri, Mar 26, 6:07 PM
epriestley created an object: 2021 Week 13 (Late March).
Fri, Mar 26, 6:06 PM
epriestley committed rARC7af9846f994a: (stable) Promote 2021 Week 13 (authored by epriestley).
(stable) Promote 2021 Week 13
Fri, Mar 26, 6:05 PM
epriestley committed rPda8a579600c0: (stable) Promote 2021 Week 13 (authored by epriestley).
(stable) Promote 2021 Week 13
Fri, Mar 26, 6:05 PM
epriestley added a comment to T13646: Add "E" to "variables_order" in Phacility environments.

D21656 fixes variables_order.

Fri, Mar 26, 5:52 PM · Phacility, Infrastructure
epriestley added a revision to T13646: Add "E" to "variables_order" in Phacility environments: Unknown Object (Differential Revision).
Fri, Mar 26, 5:19 PM · Phacility, Infrastructure
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: Unknown Object (Differential Revision).
Fri, Mar 26, 5:15 PM · Almanac
epriestley updated the test plan for D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Fri, Mar 26, 3:48 PM
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Fri, Mar 26, 3:48 PM · Accessibility, Differential

Thu, Mar 25

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Thu, Mar 25, 9:14 PM · Accessibility, Differential
epriestley requested review of D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Thu, Mar 25, 9:13 PM
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Thu, Mar 25, 9:13 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Thu, Mar 25, 9:12 PM · Accessibility, Differential
epriestley requested review of D21653: Formally track "initial", "committed", and "active" states for inline comments.
Thu, Mar 25, 9:11 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21653: Formally track "initial", "committed", and "active" states for inline comments.
Thu, Mar 25, 9:10 PM · Accessibility, Differential
epriestley requested review of D21652: When creating an inline comment, populate the content state with the default suggestion text.
Thu, Mar 25, 9:08 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21652: When creating an inline comment, populate the content state with the default suggestion text.
Thu, Mar 25, 9:07 PM · Accessibility, Differential
epriestley requested review of D21651: On inline comments, track an explicit "committed" content state.
Thu, Mar 25, 9:06 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21651: On inline comments, track an explicit "committed" content state.
Thu, Mar 25, 9:05 PM · Accessibility, Differential
epriestley requested review of D21650: Fix an issue when undoing mutiple inline comment deletions.
Thu, Mar 25, 9:04 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21650: Fix an issue when undoing mutiple inline comment deletions.
Thu, Mar 25, 9:03 PM · Accessibility, Differential
epriestley requested review of D21649: Make the client authoritative for "Cancel" actions.
Thu, Mar 25, 9:01 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21649: Make the client authoritative for "Cancel" actions.
Thu, Mar 25, 9:00 PM · Accessibility, Differential
epriestley requested review of D21648: Make the client authoritative for "Save" actions.
Thu, Mar 25, 8:59 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21648: Make the client authoritative for "Save" actions.
Thu, Mar 25, 8:58 PM · Accessibility, Differential
epriestley requested review of D21647: Remove direct reads of form state from main Inline client code.
Thu, Mar 25, 8:57 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21647: Remove direct reads of form state from main Inline client code.
Thu, Mar 25, 8:56 PM · Accessibility, Differential
epriestley requested review of D21646: Make client inlines track an "active" state.
Thu, Mar 25, 8:55 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21646: Make client inlines track an "active" state.
Thu, Mar 25, 8:54 PM · Accessibility, Differential
epriestley requested review of D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Thu, Mar 25, 8:52 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Thu, Mar 25, 8:51 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

The "Cancel" button should mean "Delete" if...

Thu, Mar 25, 8:21 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Thu, Mar 25, 6:16 PM · Accessibility, Differential
epriestley triaged T13646: Add "E" to "variables_order" in Phacility environments as Low priority.
Thu, Mar 25, 3:31 PM · Phacility, Infrastructure

Wed, Mar 24

epriestley committed rP61272e7ac31a: Correct "getActiveBindings()" method name (authored by epriestley).
Correct "getActiveBindings()" method name
Wed, Mar 24, 5:15 PM
epriestley closed D21644: Correct "getActiveBindings()" method name.
Wed, Mar 24, 5:15 PM
epriestley requested review of D21644: Correct "getActiveBindings()" method name.
Wed, Mar 24, 5:13 PM

Tue, Mar 23

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Currently, the inline code partially conflates four separate content states:

Tue, Mar 23, 5:57 PM · Accessibility, Differential

Mar 22 2021

epriestley committed rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()" (authored by epriestley).
On Windows, implement "Filesystem::copyFile()" with "copy()"
Mar 22 2021, 7:00 PM
epriestley closed D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 7:00 PM
epriestley renamed T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions from Filesystem class invokes "copy" command on Windows, which fails after "bypass_shell" changes to Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 7:00 PM · Windows, Arcanist
epriestley added a comment to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

D21643 "fixes" this by using copy(). However:

Mar 22 2021, 6:59 PM · Windows, Arcanist
epriestley requested review of D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM
epriestley added a revision to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions: D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM · Windows, Arcanist
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 6:14 PM · Windows, Arcanist
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 22 2021, 6:13 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

When you "Quote" a comment, then cancel, the comment disappears from the UI.

Mar 22 2021, 5:36 PM · Accessibility, Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 22 2021, 5:32 PM · Differential
epriestley added a comment to T13534: Inline Comment errata after editing persistence.

When you are viewing a change under engine X, and comments made under engine Y are present, they are not handled specially.

Mar 22 2021, 5:32 PM · Differential
epriestley updated the task description for T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file.
Mar 22 2021, 5:31 PM · Differential

Mar 20 2021

epriestley added a comment to D21624: Remove or correct various "phabricator/" references to "libphutil".

Diviner updates based on the deployed software version on secure, and I just haven't deployed this yet. Stuff usually gets deployed in about a day, this has been on the slower side since I've been moving furniture.

Mar 20 2021, 3:55 PM

Mar 18 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 18 2021, 6:45 PM · Accessibility, Differential
epriestley requested review of D21642: Fix an issue where inlines could be duplicated in the client list.
Mar 18 2021, 6:40 PM