Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (588 w, 6 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Fri, May 20

epriestley requested review of D21833: Don't consider file references inside quoted text blocks to grant "attachment intent".
Fri, May 20, 6:23 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21833: Don't consider file references inside quoted text blocks to grant "attachment intent".
Fri, May 20, 6:23 PM · Remarkup
epriestley requested review of D21832: Only attach files that are both referenced in Remarkup and attached by explicit metadata.
Fri, May 20, 5:48 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21832: Only attach files that are both referenced in Remarkup and attached by explicit metadata.
Fri, May 20, 5:48 PM · Remarkup
epriestley closed D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
Fri, May 20, 5:27 PM
epriestley committed rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley).
Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
Fri, May 20, 5:27 PM
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
Fri, May 20, 5:24 PM · Remarkup
epriestley requested review of D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
Fri, May 20, 5:12 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
Fri, May 20, 5:12 PM · Remarkup

Thu, May 19

epriestley closed D21830: Generate file attachment transactions for explicit Remarkup attachments on common edit pathways.
Thu, May 19, 8:21 PM
epriestley committed rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on… (authored by epriestley).
Generate file attachment transactions for explicit Remarkup attachments on…
Thu, May 19, 8:21 PM
epriestley committed rPfee8297121f0: Remove file attachment edge types, including API access (authored by epriestley).
Remove file attachment edge types, including API access
Thu, May 19, 8:21 PM
epriestley committed rPb872640c160a: Remove all "FileHasObject" edge reads and writes (authored by epriestley).
Remove all "FileHasObject" edge reads and writes
Thu, May 19, 8:21 PM
epriestley closed D21823: Remove file attachment edge types, including API access.
Thu, May 19, 8:21 PM
epriestley closed D21820: Remove all "FileHasObject" edge reads and writes.
Thu, May 19, 8:21 PM
epriestley closed D21818: Copy file attachment edges to new storage.
Thu, May 19, 8:21 PM
epriestley committed rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes (authored by epriestley).
Remove all "ObjectHasFile" edge reads and writes
Thu, May 19, 8:21 PM
epriestley closed D21819: Remove all "ObjectHasFile" edge reads and writes.
Thu, May 19, 8:21 PM
epriestley committed rP0329df0fa8d4: Copy file attachment edges to new storage (authored by epriestley).
Copy file attachment edges to new storage
Thu, May 19, 8:21 PM
epriestley closed D21817: Adjust paste content transaction to support earlier file PHID extraction.
Thu, May 19, 8:21 PM
epriestley committed rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction (authored by epriestley).
Adjust paste content transaction to support earlier file PHID extraction
Thu, May 19, 8:21 PM
epriestley committed rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage (authored by epriestley).
Double-write file attachment to old "edge" storage and new "attachment" storage
Thu, May 19, 8:21 PM
epriestley closed D21816: Double-write file attachment to old "edge" storage and new "attachment" storage.
Thu, May 19, 8:21 PM
epriestley closed D21815: Remove "PhabricatorFile->detachFromObject()".
Thu, May 19, 8:21 PM
epriestley closed D21813: Add database storage for a dedicated file attachment table.
Thu, May 19, 8:21 PM
epriestley committed rP7fcc0f9ebd91: Remove "PhabricatorFile->detachFromObject()" (authored by epriestley).
Remove "PhabricatorFile->detachFromObject()"
Thu, May 19, 8:21 PM
epriestley committed rPcfa42c5e655c: Add database storage for a dedicated file attachment table (authored by epriestley).
Add database storage for a dedicated file attachment table
Thu, May 19, 8:21 PM
epriestley closed D21812: Do not extract file PHIDs from remarkup blocks for attachment.
Thu, May 19, 8:21 PM
epriestley committed rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley).
Do not extract file PHIDs from remarkup blocks for attachment
Thu, May 19, 8:21 PM
epriestley requested review of D21830: Generate file attachment transactions for explicit Remarkup attachments on common edit pathways.
Thu, May 19, 8:20 PM
epriestley triaged T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default" as Normal priority.
Thu, May 19, 8:08 PM · Remarkup
epriestley abandoned D21829: Generate attachment edges from drag-and-dropped files in stacked comments.

This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).

Thu, May 19, 7:59 PM
epriestley requested review of D21829: Generate attachment edges from drag-and-dropped files in stacked comments.
Thu, May 19, 7:30 PM
epriestley updated the diff for D21818: Copy file attachment edges to new storage.
  • Perform this migration entirely in SQL instead.
Thu, May 19, 7:10 PM
epriestley closed D21821: Fix some test suite stragglers with PHP 8.1 compatibility.
Thu, May 19, 7:04 PM
epriestley committed rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility (authored by epriestley).
Fix some test suite stragglers with PHP 8.1 compatibility
Thu, May 19, 7:04 PM
epriestley committed rP7693a711a725: Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads (authored by epriestley).
Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads
Thu, May 19, 7:03 PM
epriestley closed D21828: Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads.
Thu, May 19, 7:03 PM
epriestley closed D21827: Give "RemarkupControl" support for tracking metadata.
Thu, May 19, 7:03 PM
epriestley committed rP33a0731619e8: Give "RemarkupControl" support for tracking metadata (authored by epriestley).
Give "RemarkupControl" support for tracking metadata
Thu, May 19, 7:03 PM
epriestley requested review of D21828: Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads.
Thu, May 19, 7:02 PM
epriestley updated the diff for D21827: Give "RemarkupControl" support for tracking metadata.
  • Slightly smaller API, because versioned drafts are not coupled to form inputs.
Thu, May 19, 6:44 PM
epriestley requested review of D21827: Give "RemarkupControl" support for tracking metadata.
Thu, May 19, 6:22 PM
epriestley closed T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception, a subtask of T13588: PHP 8 Compatibility, as Resolved.
Thu, May 19, 5:33 PM · Infrastructure
epriestley closed T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception as Resolved.

Resolved by D21824.

Thu, May 19, 5:33 PM · Conpherence

Tue, May 17

epriestley closed T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Resolved.
Tue, May 17, 11:31 PM · Security, Feed
epriestley committed rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads (authored by epriestley).
Fix an exception in cursor pagination of Conpherence threads
Tue, May 17, 11:31 PM
epriestley closed D21824: Fix an exception in cursor pagination of Conpherence threads.
Tue, May 17, 11:31 PM
epriestley closed D21826: Remove "feed.publish" API.
Tue, May 17, 11:31 PM
epriestley committed rP431612023dae: Remove "feed.publish" API (authored by epriestley).
Remove "feed.publish" API
Tue, May 17, 11:31 PM
epriestley updated the diff for D21826: Remove "feed.publish" API.
  • Include library map update.
Tue, May 17, 11:30 PM
epriestley requested review of D21826: Remove "feed.publish" API.
Tue, May 17, 11:29 PM
epriestley added a revision to T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable: D21826: Remove "feed.publish" API.
Tue, May 17, 11:29 PM · Security, Feed
epriestley triaged T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Normal priority.
Tue, May 17, 11:27 PM · Security, Feed
epriestley closed D21825: Fix a PHP 8.1 repository marker issue in Mercurial.
Tue, May 17, 11:20 PM
epriestley committed rARC85c953ebe4a6: Fix a PHP 8.1 repository marker issue in Mercurial (authored by epriestley).
Fix a PHP 8.1 repository marker issue in Mercurial
Tue, May 17, 11:20 PM
epriestley added a comment to T13588: PHP 8 Compatibility.

A user just ran into this exception with Arcanist...

Tue, May 17, 11:20 PM · Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: D21825: Fix a PHP 8.1 repository marker issue in Mercurial.
Tue, May 17, 11:18 PM · Infrastructure
epriestley requested review of D21825: Fix a PHP 8.1 repository marker issue in Mercurial.
Tue, May 17, 11:18 PM
epriestley closed D21822: Straggling fixes for PhutilURI under PHP 8.1.
Tue, May 17, 11:08 PM
epriestley committed rARC942b54a6977a: Straggling fixes for PhutilURI under PHP 8.1 (authored by epriestley).
Straggling fixes for PhutilURI under PHP 8.1
Tue, May 17, 11:08 PM
epriestley requested review of D21824: Fix an exception in cursor pagination of Conpherence threads.
Tue, May 17, 11:08 PM
epriestley added a revision to T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception: D21824: Fix an exception in cursor pagination of Conpherence threads.
Tue, May 17, 11:08 PM · Conpherence

Mon, May 16

epriestley added a subtask for T13588: PHP 8 Compatibility: T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception.
Mon, May 16, 8:50 PM · Infrastructure
epriestley added a parent task for T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception: T13588: PHP 8 Compatibility.
Mon, May 16, 8:50 PM · Conpherence
epriestley triaged T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception as Low priority.
Mon, May 16, 8:50 PM · Conpherence

Thu, May 12

epriestley requested review of D21823: Remove file attachment edge types, including API access.
Thu, May 12, 10:40 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21822: Straggling fixes for PhutilURI under PHP 8.1.
Thu, May 12, 10:38 PM · Infrastructure
epriestley requested review of D21822: Straggling fixes for PhutilURI under PHP 8.1.
Thu, May 12, 10:38 PM
epriestley requested review of D21821: Fix some test suite stragglers with PHP 8.1 compatibility.
Thu, May 12, 10:37 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21821: Fix some test suite stragglers with PHP 8.1 compatibility.
Thu, May 12, 10:37 PM · Infrastructure
epriestley requested review of D21820: Remove all "FileHasObject" edge reads and writes.
Thu, May 12, 10:25 PM
epriestley requested review of D21819: Remove all "ObjectHasFile" edge reads and writes.
Thu, May 12, 10:15 PM
epriestley requested review of D21818: Copy file attachment edges to new storage.
Thu, May 12, 9:59 PM
epriestley requested review of D21817: Adjust paste content transaction to support earlier file PHID extraction.
Thu, May 12, 9:43 PM
epriestley requested review of D21816: Double-write file attachment to old "edge" storage and new "attachment" storage.
Thu, May 12, 9:34 PM
epriestley requested review of D21815: Remove "PhabricatorFile->detachFromObject()".
Thu, May 12, 9:15 PM
epriestley closed D21814: Add "pht_list()", a translation wrapper for lists of items.
Thu, May 12, 5:57 PM
epriestley committed rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items (authored by epriestley).
Add "pht_list()", a translation wrapper for lists of items
Thu, May 12, 5:57 PM
epriestley requested review of D21814: Add "pht_list()", a translation wrapper for lists of items.
Thu, May 12, 5:57 PM

Tue, May 10

epriestley requested review of D21813: Add database storage for a dedicated file attachment table.
Tue, May 10, 11:24 PM
epriestley requested review of D21812: Do not extract file PHIDs from remarkup blocks for attachment.
Tue, May 10, 6:54 PM
epriestley added a comment to T13588: PHP 8 Compatibility.

I am pretty sure that this error message does not exist prior to PHP 8.1, and PHP 7.4 can not possibly emit it. See here for some evidence that this is true -- note that the error message is not present in the script output until PHP 8.1:

Tue, May 10, 12:18 PM · Infrastructure

Mon, May 9

epriestley closed T13677: Drydock may grow resource pools too cautiously as Resolved.

There may be additional work here, but presuming this is more or less resolved until evidence to the contrary arises.

Mon, May 9, 10:21 PM · Drydock
epriestley closed T13679: Non-administrators can incorrectly edit default global settings as Resolved.

I believe D21811 covers this completely.

Mon, May 9, 10:19 PM · Security
epriestley updated the task description for T13679: Non-administrators can incorrectly edit default global settings.
Mon, May 9, 10:18 PM · Security
epriestley committed rP698ada2470b1: Correct overbroad automatic capability grant of global settings objects (authored by epriestley).
Correct overbroad automatic capability grant of global settings objects
Mon, May 9, 10:10 PM
epriestley closed D21811: Correct overbroad automatic capability grant of global settings objects.
Mon, May 9, 10:10 PM
epriestley requested review of D21811: Correct overbroad automatic capability grant of global settings objects.
Mon, May 9, 10:10 PM
epriestley added a revision to T13679: Non-administrators can incorrectly edit default global settings: D21811: Correct overbroad automatic capability grant of global settings objects.
Mon, May 9, 10:10 PM · Security
epriestley triaged T13679: Non-administrators can incorrectly edit default global settings as Normal priority.
Mon, May 9, 10:08 PM · Security
epriestley closed T13678: Remarkup objects may form rendering cycles when embedded as Resolved.
Mon, May 9, 7:02 PM · Remarkup
epriestley closed D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
Mon, May 9, 6:21 PM
epriestley committed rP01253d533bbc: Prevent embedded remarkup content from cycling when it contains embedded self… (authored by epriestley).
Prevent embedded remarkup content from cycling when it contains embedded self…
Mon, May 9, 6:21 PM
epriestley added a comment to D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.

Screen Shot 2022-05-09 at 11.16.25 AM.png (1×2 px, 321 KB)

Mon, May 9, 6:20 PM
epriestley requested review of D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
Mon, May 9, 6:20 PM
epriestley added a revision to T13678: Remarkup objects may form rendering cycles when embedded: D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
Mon, May 9, 6:20 PM · Remarkup
epriestley triaged T13678: Remarkup objects may form rendering cycles when embedded as Normal priority.
Mon, May 9, 6:06 PM · Remarkup
epriestley closed D21809: In Drydock, yield for reclaiming resources in the "released" state.
Mon, May 9, 5:45 PM
epriestley committed rPa640a4a4930f: In Drydock, yield for reclaiming resources in the "released" state (authored by epriestley).
In Drydock, yield for reclaiming resources in the "released" state
Mon, May 9, 5:45 PM