epriestley (Evan Priestley)Administrator
Overengineer

Projects (75)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (340 w, 4 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Thu, Aug 17

epriestley accepted D18444: Hide branch status if repository is not hg.
Thu, Aug 17, 9:44 PM
epriestley accepted D18443: Add more information to Branch status page in Manage Repository.
Thu, Aug 17, 6:58 PM
epriestley accepted D18441: List branch on main repository view.
Thu, Aug 17, 6:50 PM
epriestley accepted D18437: Give mobile page tabs more space.
Thu, Aug 17, 6:48 PM
epriestley committed rP68008dce609b: Fix a possible database ref fatal during MySQL setup checks if a host is… (authored by epriestley).
Fix a possible database ref fatal during MySQL setup checks if a host is…
Thu, Aug 17, 6:43 PM
epriestley added a commit to T12966: Phabricator should survive a restart and setup checks with an unreachable master: rP68008dce609b: Fix a possible database ref fatal during MySQL setup checks if a host is….
Thu, Aug 17, 6:43 PM · Clusters
epriestley closed D18442: Fix a possible database ref fatal during MySQL setup checks if a host is unreachable.
Thu, Aug 17, 6:43 PM
epriestley created D18442: Fix a possible database ref fatal during MySQL setup checks if a host is unreachable.
Thu, Aug 17, 6:35 PM
epriestley added a revision to T12966: Phabricator should survive a restart and setup checks with an unreachable master: D18442: Fix a possible database ref fatal during MySQL setup checks if a host is unreachable.
Thu, Aug 17, 6:35 PM · Clusters
epriestley updated the task description for T12966: Phabricator should survive a restart and setup checks with an unreachable master.
Thu, Aug 17, 6:17 PM · Clusters
epriestley added a parent task for T12966: Phabricator should survive a restart and setup checks with an unreachable master: T10769: Read-Only Mode Errata.
Thu, Aug 17, 6:15 PM · Clusters
epriestley added a subtask for T10769: Read-Only Mode Errata: T12966: Phabricator should survive a restart and setup checks with an unreachable master.
Thu, Aug 17, 6:15 PM · Clusters
epriestley created T12966: Phabricator should survive a restart and setup checks with an unreachable master.
Thu, Aug 17, 6:15 PM · Clusters
epriestley committed rPc9986fd5dee6: Don't fatal in ElasticSearch setup check if no "master" database is configured (authored by epriestley).
Don't fatal in ElasticSearch setup check if no "master" database is configured
Thu, Aug 17, 5:39 PM
epriestley added a commit to T12965: When no "master" database is configured, the ElasticSearch setup check can fatal: rPc9986fd5dee6: Don't fatal in ElasticSearch setup check if no "master" database is configured.
Thu, Aug 17, 5:39 PM · Database, Clusters, Search
epriestley closed D18440: Don't fatal in ElasticSearch setup check if no "master" database is configured.
Thu, Aug 17, 5:39 PM
epriestley created D18440: Don't fatal in ElasticSearch setup check if no "master" database is configured.
Thu, Aug 17, 4:53 PM
epriestley added a revision to T12965: When no "master" database is configured, the ElasticSearch setup check can fatal: D18440: Don't fatal in ElasticSearch setup check if no "master" database is configured.
Thu, Aug 17, 4:53 PM · Database, Clusters, Search
epriestley added a comment to D18439: Show error message in Diffusion if branch is not tracked.

Can you cover these cases in your test plan?

Thu, Aug 17, 4:51 PM
epriestley created T12965: When no "master" database is configured, the ElasticSearch setup check can fatal.
Thu, Aug 17, 4:41 PM · Database, Clusters, Search
epriestley accepted D18436: Update Settings to use TwoColumn fixed layout.
Thu, Aug 17, 2:36 PM
epriestley accepted D18435: Update VCS Password settings page.
Thu, Aug 17, 2:35 PM

Wed, Aug 16

epriestley added a comment to T12838: Make sure "state" is in new Branch view.

Yes. In Mercurial, branch heads may be "Open" or "Closed".

Wed, Aug 16, 9:14 PM · Design & Planning, Diffusion
epriestley accepted D18434: Add branch, tag info to Diffusion Headers.
Wed, Aug 16, 7:11 PM
epriestley accepted D18433: Set border on crumbs on Lint page.
Wed, Aug 16, 7:11 PM
epriestley updated the task description for T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Wed, Aug 16, 7:01 PM · Transactions
epriestley merged T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Wed, Aug 16, 6:58 PM · Transactions
epriestley merged task T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Wed, Aug 16, 6:58 PM · Notifications
epriestley added a comment to T5891: Add button to notification panel to concatenate notifications on the same objects.

I'm going to merge this into T12963, which isn't exactly the same but overlaps this substantially. It's possible we'll pursue a more narrow "vacation review" mode eventually, but we'd want to finish T12963 first and make sure it didn't adequately address this problem on its own.

Wed, Aug 16, 6:58 PM · Notifications
epriestley created T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Wed, Aug 16, 6:55 PM · Transactions
darkwing awarded T10363: Reorient publishing (Doorkeeper, feed.http-hooks) around transactions instead of feed stories a Like token.
Wed, Aug 16, 5:02 PM · Nuance, Restricted Project, Feed, Doorkeeper
MatanUbe awarded T10350: Scripts to migrate old "points" fields and move projects beneath other projects a Party Time token.
Wed, Aug 16, 12:05 PM · Projects (v3)
DominicFrei awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Wed, Aug 16, 11:19 AM · Calendar

Tue, Aug 15

tomekj2ee awarded T6072: Improve usability of `arc diff` a Like token.
Tue, Aug 15, 10:02 PM · Restricted Project, Documentation, Arcanist
epriestley accepted D18432: Add pattern search to diffusion home.
Tue, Aug 15, 9:14 PM
epriestley accepted D18431: Move Diffusion Actions into action bar on home.
Tue, Aug 15, 6:36 PM
epriestley closed T6861: PHP sort function is unpredictable to human minds when dealing with mixed types as Resolved.

Practically, msortv() and PhutilSortVector are now the solution here. They provide high-performance (no usort*()), multi-dimensional, stable, explicitly typed sort.

Tue, Aug 15, 6:17 PM · Infrastructure
epriestley accepted D18430: Simplify Create Repository page.
Tue, Aug 15, 6:04 PM
epriestley removed a project from T9518: In diff summary linting error code shown instead of message, when PHP_CodeSniffer linter was used: Differential.
Tue, Aug 15, 5:59 PM · Lint
epriestley closed T10856: Small Revision page enhanchments as Resolved.

Just sweeping this up, rewriting the property display to show +x seems reasonable to me but I think it's self-evident enough that we don't need to keep a task around for it.

Tue, Aug 15, 5:58 PM · Restricted Project, Feature Request, Differential
epriestley closed T11218: Differential advanced search: bucket/group by repository, a subtask of T9287: Working with many repositories, as Wontfix.
Tue, Aug 15, 5:56 PM · Restricted Project, Restricted Project, Diffusion
epriestley closed T11218: Differential advanced search: bucket/group by repository as Wontfix.

I don't think this meets the high bar required by modern feature requests (see "Upstreamable Feautures" in Planning).

Tue, Aug 15, 5:56 PM · Restricted Project, Differential, Feature Request
epriestley closed T11900: Create bot reviewers that do code analysis and post findings as inline comments. as Wontfix.

(This isn't anything upstream-actionable.)

Tue, Aug 15, 5:55 PM · Differential, Feature Request
epriestley moved T12534: Differential still appears in "responsible users" query after resigning as a reviewer from Backlog to Reviewer Rules on the Differential board.
Tue, Aug 15, 5:54 PM · Bug Report (Needs Information), Differential
epriestley moved T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review" from Backlog to Reviewer Rules on the Differential board.
Tue, Aug 15, 5:54 PM · Differential
epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Reviewer Rules on the Differential board.
Tue, Aug 15, 5:53 PM · Mail, Differential, Bug Report
epriestley closed T12733: (2017 Week 20) Inline Comments Errata / Feedback as Resolved.

This seems to have calmed down.

Tue, Aug 15, 5:53 PM · Inline Comments, Installing & Upgrading, Differential
epriestley moved T12920: Retracting requested changes can leave revision in "Needs Revision" state from Backlog to Reviewer Rules on the Differential board.
Tue, Aug 15, 5:53 PM · Restricted Project, Differential, Bug Report
epriestley closed T10967: Move Differential reviewers back to a dedicated database storage table as Resolved.

We appear to have survived this. D18398 removed the double writes. There's a bit more cleanup (we could remove the edge type and actually destroy the older data) but that can happen whenever we get around to it.

Tue, Aug 15, 5:51 PM · Restricted Project, Infrastructure, Differential
epriestley closed T1084: Preview what's new in a diff when attaching it to an existing revision as Wontfix.

This is five years old, and doesn't meet the requirements of a modern feature request. If you're still interested in this, feel free to start a new discussion on Discourse.

Tue, Aug 15, 5:49 PM · Restricted Project, Differential, Arcanist
epriestley closed T8134: There should be a way to quickly navigate between new comments as Wontfix.

This doesn't meet the criteria of a modern feature request and predates significant changes to the inline comment UI. If this is still an issue, feel free to start a new discussion on Discourse.

Tue, Aug 15, 5:46 PM · Restricted Project, Differential
epriestley closed T12548: Unable to initialize database with invalid credentials in configuration file as Invalid.

Closing this for lack of feedback, feel free to resurrect it if you get back to it.

Tue, Aug 15, 5:34 PM · Database, Bug Report
epriestley closed T12602: Assignees of tasks don't count as subscribers in maniphest search as Invalid.

This isn't a bug; they aren't subscribers, and aren't listed in "Subscribers" in the right-hand column or in "Subscribers" in "Edit Task".

Tue, Aug 15, 5:32 PM · Maniphest, Bug Report
epriestley closed T10890: Less chatty Maniphest feed rendering as Wontfix.

I don't think this clearly describes a root problem. PHI33 touches on similar issues, and I'll file something vaguely in this realm if anything comes of that.

Tue, Aug 15, 5:19 PM · Maniphest, Feature Request
epriestley accepted D18429: Build a basic DiffusionPatternSearchView.
Tue, Aug 15, 11:42 AM
epriestley accepted D18428: Move pattern search into Diffusion header.
Tue, Aug 15, 1:48 AM

Mon, Aug 14

epriestley added a comment to T12962: Unable to review instance billing information on `admin.phacility.com`.

I just clicked through it, I don't think there's any reason for staff to be there normally.

Mon, Aug 14, 10:39 PM · Phacility
epriestley assigned T12962: Unable to review instance billing information on `admin.phacility.com` to chad.
Mon, Aug 14, 10:03 PM · Phacility
epriestley created T12962: Unable to review instance billing information on `admin.phacility.com`.
Mon, Aug 14, 10:01 PM · Phacility
epriestley added a comment to T12957: Maybe get rid of timeline icons.

I find the timeline icons in Differential useful sometimes.

Mon, Aug 14, 8:17 PM · Design & Planning
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: D18426: Separate saved queries in applications into "personal" and "global" queries.
Mon, Aug 14, 8:15 PM · ApplicationSearch
epriestley created D18426: Separate saved queries in applications into "personal" and "global" queries.
Mon, Aug 14, 8:15 PM
epriestley closed T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`) as Resolved.

There doesn't seem to be anything actionable remaining on our end.

Mon, Aug 14, 8:07 PM · Subversion, Mercurial, Git, Security
epriestley updated the diff for D18422: Make the default ApplicationSearch query explicit, not just the first item in the list.
  • Fix typo of "disalbed".
Mon, Aug 14, 7:19 PM
epriestley accepted D18425: Remove "File Name" search tool.
Mon, Aug 14, 6:51 PM
epriestley committed rP766ecf8d6b70: Update "Reporting Bugs" documentation for removal of free instances (authored by epriestley).
Update "Reporting Bugs" documentation for removal of free instances
Mon, Aug 14, 6:28 PM
epriestley closed D18423: Update "Reporting Bugs" documentation for removal of free instances.
Mon, Aug 14, 6:28 PM
epriestley accepted D18424: Touch up typeahead behavior in locate-file.
Mon, Aug 14, 6:27 PM
epriestley created D18423: Update "Reporting Bugs" documentation for removal of free instances.
Mon, Aug 14, 6:16 PM
epriestley created D18422: Make the default ApplicationSearch query explicit, not just the first item in the list.
Mon, Aug 14, 6:13 PM
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: D18422: Make the default ApplicationSearch query explicit, not just the first item in the list.
Mon, Aug 14, 6:13 PM · ApplicationSearch
epriestley accepted D18421: Add a link directly to Browse in Diffusion.
Mon, Aug 14, 6:13 PM
epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

We still get a tiny mess where administrators clicking "pin" might mean "pin by default for all users" or "pin by default for just me" but that's reasonable to clarify in the workflow.

Mon, Aug 14, 4:58 PM · ApplicationSearch
epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

Currently, users may hide or reorder builtin queries. With the simplest version of the plan above, users will lose that ability: builtin queries will always be visible (unless hidden by an administrator) and always at the bottom of the list.

Mon, Aug 14, 4:30 PM · ApplicationSearch
epriestley committed rP8c3243ef6870: Lightly modernize NamedQueryQuery (authored by epriestley).
Lightly modernize NamedQueryQuery
Mon, Aug 14, 4:07 PM
epriestley added a commit to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: rP8c3243ef6870: Lightly modernize NamedQueryQuery.
Mon, Aug 14, 4:07 PM · ApplicationSearch
epriestley closed D18420: Lightly modernize NamedQueryQuery.
Mon, Aug 14, 4:07 PM
epriestley added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

@aubort, please use the community forum (see: Discourse) if you'd like to discuss this issue.

Mon, Aug 14, 4:05 PM · Diffusion
epriestley added a comment to T12742: `arc land` shows only part of the error that causes the final squash to fail.

@aleb, if you like to continue discussion of this please use the appropriate channels, as @chad suggested above (at the time, they were Conpherence and Ponder, but the appropriate channel is now the community forum -- see: Discourse).

Mon, Aug 14, 4:04 PM · Bug Report
epriestley created D18420: Lightly modernize NamedQueryQuery.
Mon, Aug 14, 4:01 PM
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: D18420: Lightly modernize NamedQueryQuery.
Mon, Aug 14, 4:01 PM · ApplicationSearch

Sat, Aug 12

epriestley added a comment to T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.

In https://hackerone.com/reports/259246 (not currently disclosed) a researcher found an actual issue with figlet. Although it would probably be hard to develop into a practical attack, it does make me feel better about the decision to pull all this stuff into PHP (not just dot) when the dot issue was originally identified.

Sat, Aug 12, 11:02 PM · Remarkup, Security, Installing & Upgrading
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I've landed the two scary migration changes (D18418, D18419) and deployed them here without any obvious issues arising. The actual effects here are:

Sat, Aug 12, 11:17 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley committed rP48a74de0b649: Move all revision status transactions to modern values and mechanics (authored by epriestley).
Move all revision status transactions to modern values and mechanics
Sat, Aug 12, 11:06 AM
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP48a74de0b649: Move all revision status transactions to modern values and mechanics.
Sat, Aug 12, 11:06 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed D18419: Move all revision status transactions to modern values and mechanics.
Sat, Aug 12, 11:06 AM
epriestley committed rP7b695aa43bd1: Migrate revision storage to modern status constants ("accepted") instead of… (authored by epriestley).
Migrate revision storage to modern status constants ("accepted") instead of…
Sat, Aug 12, 11:02 AM
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP7b695aa43bd1: Migrate revision storage to modern status constants ("accepted") instead of….
Sat, Aug 12, 11:02 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed D18418: Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2").
Sat, Aug 12, 11:02 AM
epriestley added a parent task for T929: Allow two arbitrary revisions to be compared in Diffusion: T12824: Redesign Diffusion.
Sat, Aug 12, 10:52 AM · Diffusion (v3), Restricted Project
epriestley added a subtask for T12824: Redesign Diffusion: T929: Allow two arbitrary revisions to be compared in Diffusion.
Sat, Aug 12, 10:52 AM · Design & Planning, Diffusion
epriestley merged T12831: Update compare page with more features into T929: Allow two arbitrary revisions to be compared in Diffusion.
Sat, Aug 12, 10:52 AM · Diffusion (v3), Restricted Project
epriestley merged task T12831: Update compare page with more features into T929: Allow two arbitrary revisions to be compared in Diffusion.
Sat, Aug 12, 10:52 AM · Design & Planning, Diffusion
epriestley added a comment to T12831: Update compare page with more features.

I'm just going to merge this into T929, I don't think it's a distinct task. I'll link that to T12824.

Sat, Aug 12, 10:52 AM · Design & Planning, Diffusion
epriestley closed T12854: Clean up resources for decommissioned `repo012`, a subtask of T12798: Decommission cluster host `repo012`, as Resolved.
Sat, Aug 12, 10:50 AM · Ops, Phacility
epriestley closed T12854: Clean up resources for decommissioned `repo012` as Resolved.

They should fix themselves once the instance is suspended.

Sat, Aug 12, 10:50 AM · Ops, Phacility
epriestley added a subtask for T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index.
Sat, Aug 12, 10:44 AM · Restricted Project, Search
epriestley added a parent task for T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index: T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.
Sat, Aug 12, 10:44 AM · Customer Impact, Search
epriestley committed rP5348f34c9eec: Make all revision status readers explicitly read modern or legacy status (authored by epriestley).
Make all revision status readers explicitly read modern or legacy status
Sat, Aug 12, 12:22 AM
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP5348f34c9eec: Make all revision status readers explicitly read modern or legacy status.
Sat, Aug 12, 12:22 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential