Psyduck is the greatest pokemon of all time.
User Details
User Details
- User Since
- Feb 8 2011, 1:28 AM (512 w, 1 d)
- Roles
- Administrator
- Availability
- Available
Thu, Nov 19
Thu, Nov 19
Seems reasonable, definitely the highest impact-per-character change I can come up with.
epriestley triaged T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes as Normal priority.
Sat, Nov 7
Sat, Nov 7
epriestley requested review of D21493: Separate Herald transcripts into several different views.
epriestley triaged T13586: In Herald transcripts, surface exceptions encountered while evaluating fields as Low priority.
epriestley closed T13298: Improve Herald profiling information available in transcripts as Resolved.
The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issuses.
Tue, Nov 3
Tue, Nov 3
epriestley committed rPbf8707d3a9bf: Add a basic "harbormaster.step.search" API method (authored by epriestley).
Add a basic "harbormaster.step.search" API method
epriestley committed rP34082efb02c7: Add a basic "harbormaster.step.edit" API method (authored by epriestley).
Add a basic "harbormaster.step.edit" API method
epriestley updated the summary of D21488: Add a basic "harbormaster.step.search" API method.
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
- There is no way to pull custom field values with *.search. See above.
- There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
- There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
- As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
- There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
epriestley requested review of D21489: Add a basic "harbormaster.step.edit" API method.
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
epriestley updated the diff for D21488: Add a basic "harbormaster.step.search" API method.
- Use more consistent capitalization.
epriestley requested review of D21488: Add a basic "harbormaster.step.search" API method.
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
epriestley renamed T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values from PCRE segfaults readily with default "pcre.backtrace_limit" and "pcre.recursion_limit" values to PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.
epriestley committed rPae5a38f3349f: Guarantee terms in PhabricatorAuthPasswordEngine are strings (authored by epriestley).
Guarantee terms in PhabricatorAuthPasswordEngine are strings
This appears fixed by D21484 (and @20after4 confirmed the fix on rPc0414732 -- thanks!) so I'm going to mark it as resolved.
epriestley requested review of D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
epriestley added a comment to T2312: Modifying PHP.
Oct 30 2020
Oct 30 2020
epriestley added a comment to D21484: Fix isValidGitShallowCloneResponse.
Ah, thanks for the pointers!
Fix isValidGitShallowCloneResponse
Minor nitpicks inlines, I'll just tweak them locally as I land this.
epriestley committed rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients (authored by epriestley).
Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Oct 24 2020
Oct 24 2020
Oct 19 2020
Oct 19 2020
epriestley committed rP86ad69863930: (stable) When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
(stable) When a new, deleted, draft inline is revived with "Undo", undelete it
epriestley committed rPbc4f86d27996: When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
When a new, deleted, draft inline is revived with "Undo", undelete it
epriestley requested review of D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
epriestley edited the content of Changelog.
epriestley created an object: 2020 Week 42.
(stable) Promote 2020 Week 42
(stable) Promote 2020 Week 42
epriestley committed rPb2e96df3a3be: Update "arc call-conduit" instructions in Conduit API console for required "--" (authored by epriestley).
Update "arc call-conduit" instructions in Conduit API console for required "--"
Oct 16 2020
Oct 16 2020
epriestley committed rARC4b3baca999a4: Fix a typo of "previously" in FutureIterator (authored by epriestley).
Fix a typo of "previously" in FutureIterator
epriestley committed rP2b8bbae5fb27: Set an explicit height when drawing the dependent revision graph (authored by epriestley).
Set an explicit height when drawing the dependent revision graph
epriestley requested review of D21481: Set an explicit height when drawing the dependent revision graph.
epriestley committed rP058d2489e7a3: Expose the "file attached to object" and "object attached to file" edges via… (authored by epriestley).
Expose the "file attached to object" and "object attached to file" edges via…
epriestley committed rP1f7c736f9ab6: Add a "Comment content" field to Herald (authored by epriestley).
Add a "Comment content" field to Herald
epriestley requested review of D21479: Add a "Comment content" field to Herald.
epriestley triaged T13583: Support reasonable guardrails against mismatched data retention policies in comment content as Normal priority.
epriestley requested review of D21478: Fix a typo of "previously" in FutureIterator.
epriestley committed rARCccf74a40dd3b: Fix an issue where "phutil_utf8v()" could fatal when passed an integer (authored by epriestley).
Fix an issue where "phutil_utf8v()" could fatal when passed an integer
epriestley requested review of D21477: Fix an issue where "phutil_utf8v()" could fatal when passed an integer.
Oct 2 2020
Oct 2 2020
epriestley committed rP0f27cd46ccad: Never render "Show More Context" inside an inline comment suggestion diff (authored by epriestley).
Never render "Show More Context" inside an inline comment suggestion diff
epriestley committed rP0f0e94ca71fe: Use "getInlines()", not "_inlines", to access inlines on client Changeset… (authored by epriestley).
Use "getInlines()", not "_inlines", to access inlines on client Changeset…
epriestley updated the diff for D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
- Fix a possible call reentrancy issue, where "getInlines()" and "getInlineForRow()" could call one another.
Sep 30 2020
Sep 30 2020
epriestley accepted D21474: Fix rubocop lint tests.
You should be able to land this yourself directly, see the description of Blessed Committers for details or let me know if you run into issues. "Land Revision" in the web UI should also work.
epriestley committed rARC524aa2aed2ad: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend. (authored by epriestley).
Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.
Sep 28 2020
Sep 28 2020
epriestley committed rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively (authored by epriestley).
When printing, wrap all content in Remarkup tables more aggressively
epriestley added a comment to D21472: When printing, wrap all content in Remarkup tables more aggressively.
Here's the remaining goofy behavior:
epriestley requested review of D21472: When printing, wrap all content in Remarkup tables more aggressively.
Sep 18 2020
Sep 18 2020
epriestley edited the content of Changelog.
(stable) Promote 2020 Week 37
(stable) Promote 2020 Week 37
epriestley created an object: 2020 Week 37 (Mid September).
epriestley committed rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"… (authored by epriestley).
In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…
Sep 17 2020
Sep 17 2020
epriestley committed rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as… (authored by epriestley).
Fix an issue where known Subversion commits are incorrectly shown as…
epriestley committed rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior (authored by epriestley).
Fix an out-of-order issue in the new update-during-publish behavior