Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (506 w, 1 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Mon, Oct 19

epriestley committed rP86ad69863930: (stable) When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
(stable) When a new, deleted, draft inline is revived with "Undo", undelete it
Mon, Oct 19, 7:37 PM
epriestley committed rPbc4f86d27996: When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
When a new, deleted, draft inline is revived with "Undo", undelete it
Mon, Oct 19, 7:34 PM
epriestley closed D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
Mon, Oct 19, 7:34 PM
epriestley requested review of D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
Mon, Oct 19, 7:32 PM
epriestley edited the content of Changelog.
Mon, Oct 19, 7:05 PM
epriestley created an object: 2020 Week 42.
Mon, Oct 19, 7:04 PM
epriestley committed rARCac54d61d7af2: (stable) Promote 2020 Week 42 (authored by epriestley).
(stable) Promote 2020 Week 42
Mon, Oct 19, 7:04 PM
epriestley committed rP916bce119a2b: (stable) Promote 2020 Week 42 (authored by epriestley).
(stable) Promote 2020 Week 42
Mon, Oct 19, 7:04 PM
epriestley committed rPb2e96df3a3be: Update "arc call-conduit" instructions in Conduit API console for required "--" (authored by epriestley).
Update "arc call-conduit" instructions in Conduit API console for required "--"
Mon, Oct 19, 7:02 PM
epriestley closed D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Mon, Oct 19, 7:02 PM
epriestley requested review of D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Mon, Oct 19, 6:55 PM
epriestley added a revision to T13491: Why does Arcanist require "--"?: D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Mon, Oct 19, 6:54 PM · Guides

Fri, Oct 16

epriestley committed rARC4b3baca999a4: Fix a typo of "previously" in FutureIterator (authored by epriestley).
Fix a typo of "previously" in FutureIterator
Fri, Oct 16, 9:23 PM
epriestley closed D21478: Fix a typo of "previously" in FutureIterator.
Fri, Oct 16, 9:23 PM
epriestley committed rP2b8bbae5fb27: Set an explicit height when drawing the dependent revision graph (authored by epriestley).
Set an explicit height when drawing the dependent revision graph
Fri, Oct 16, 9:10 PM
epriestley closed D21481: Set an explicit height when drawing the dependent revision graph.
Fri, Oct 16, 9:10 PM
epriestley requested review of D21481: Set an explicit height when drawing the dependent revision graph.
Fri, Oct 16, 9:06 PM
epriestley committed rP058d2489e7a3: Expose the "file attached to object" and "object attached to file" edges via… (authored by epriestley).
Expose the "file attached to object" and "object attached to file" edges via…
Fri, Oct 16, 8:45 PM
epriestley closed D21480: Expose the "file attached to object" and "object attached to file" edges via "edge.search".
Fri, Oct 16, 8:45 PM
epriestley requested review of D21480: Expose the "file attached to object" and "object attached to file" edges via "edge.search".
Fri, Oct 16, 8:43 PM
epriestley committed rP1f7c736f9ab6: Add a "Comment content" field to Herald (authored by epriestley).
Add a "Comment content" field to Herald
Fri, Oct 16, 8:43 PM
epriestley closed D21479: Add a "Comment content" field to Herald.
Fri, Oct 16, 8:43 PM
epriestley requested review of D21479: Add a "Comment content" field to Herald.
Fri, Oct 16, 8:30 PM
epriestley added a revision to T13583: Support reasonable guardrails against mismatched data retention policies in comment content: D21479: Add a "Comment content" field to Herald.
Fri, Oct 16, 8:29 PM · Herald
epriestley triaged T13583: Support reasonable guardrails against mismatched data retention policies in comment content as Normal priority.
Fri, Oct 16, 8:27 PM · Herald
epriestley requested review of D21478: Fix a typo of "previously" in FutureIterator.
Fri, Oct 16, 7:31 PM
epriestley added a revision to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool: D21478: Fix a typo of "previously" in FutureIterator.
Fri, Oct 16, 7:31 PM · Daemons
epriestley committed rARCccf74a40dd3b: Fix an issue where "phutil_utf8v()" could fatal when passed an integer (authored by epriestley).
Fix an issue where "phutil_utf8v()" could fatal when passed an integer
Fri, Oct 16, 4:22 PM
epriestley closed D21477: Fix an issue where "phutil_utf8v()" could fatal when passed an integer.
Fri, Oct 16, 4:22 PM
epriestley requested review of D21477: Fix an issue where "phutil_utf8v()" could fatal when passed an integer.
Fri, Oct 16, 4:20 PM

Fri, Oct 2

epriestley committed rP0f27cd46ccad: Never render "Show More Context" inside an inline comment suggestion diff (authored by epriestley).
Never render "Show More Context" inside an inline comment suggestion diff
Fri, Oct 2, 4:47 PM
epriestley closed D21476: Never render "Show More Context" inside an inline comment suggestion diff.
Fri, Oct 2, 4:47 PM
epriestley requested review of D21476: Never render "Show More Context" inside an inline comment suggestion diff.
Fri, Oct 2, 4:46 PM
epriestley committed rP0f0e94ca71fe: Use "getInlines()", not "_inlines", to access inlines on client Changeset… (authored by epriestley).
Use "getInlines()", not "_inlines", to access inlines on client Changeset…
Fri, Oct 2, 4:19 PM
epriestley closed D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
Fri, Oct 2, 4:19 PM
epriestley updated the diff for D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
  • Fix a possible call reentrancy issue, where "getInlines()" and "getInlineForRow()" could call one another.
Fri, Oct 2, 4:18 PM
epriestley requested review of D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
Fri, Oct 2, 4:12 PM

Wed, Sep 30

epriestley accepted D21474: Fix rubocop lint tests.

You should be able to land this yourself directly, see the description of Blessed Committers for details or let me know if you run into issues. "Land Revision" in the web UI should also work.

Wed, Sep 30, 3:17 PM
epriestley added a member for Community: bootstraponline.
Wed, Sep 30, 3:07 PM
epriestley added a member for Blessed Committers: bootstraponline.
Wed, Sep 30, 3:07 PM
epriestley committed rARC524aa2aed2ad: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend. (authored by epriestley).
Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.
Wed, Sep 30, 2:49 PM
epriestley closed D21473: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.exception_ignore_args".
Wed, Sep 30, 2:49 PM
epriestley requested review of D21473: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.exception_ignore_args".
Wed, Sep 30, 2:49 PM

Mon, Sep 28

epriestley accepted D21471: fail `arc diff` if second lfs push errors.
Mon, Sep 28, 4:55 PM
epriestley committed rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively (authored by epriestley).
When printing, wrap all content in Remarkup tables more aggressively
Mon, Sep 28, 4:47 PM
epriestley closed D21472: When printing, wrap all content in Remarkup tables more aggressively.
Mon, Sep 28, 4:47 PM
epriestley added a comment to D21472: When printing, wrap all content in Remarkup tables more aggressively.

Here's the remaining goofy behavior:

Mon, Sep 28, 4:47 PM
epriestley requested review of D21472: When printing, wrap all content in Remarkup tables more aggressively.
Mon, Sep 28, 4:23 PM
epriestley added a revision to T13564: Remarkup tables should show all content when printed to PDF: D21472: When printing, wrap all content in Remarkup tables more aggressively.
Mon, Sep 28, 4:22 PM · Google Chrome, Remarkup

Sep 18 2020

epriestley edited the content of Changelog.
Sep 18 2020, 7:03 PM
epriestley committed rARC68dba1a2c6d9: (stable) Promote 2020 Week 37 (authored by epriestley).
(stable) Promote 2020 Week 37
Sep 18 2020, 7:00 PM
epriestley committed rP5e06d924f8eb: (stable) Promote 2020 Week 37 (authored by epriestley).
(stable) Promote 2020 Week 37
Sep 18 2020, 7:00 PM
epriestley created an object: 2020 Week 37 (Mid September).
Sep 18 2020, 6:55 PM
epriestley committed rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"… (authored by epriestley).
In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…
Sep 18 2020, 6:23 PM
epriestley closed D21470: In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly.
Sep 18 2020, 6:23 PM
epriestley requested review of D21470: In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly.
Sep 18 2020, 6:22 PM

Sep 17 2020

epriestley committed rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as… (authored by epriestley).
Fix an issue where known Subversion commits are incorrectly shown as…
Sep 17 2020, 8:55 PM
epriestley closed D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:55 PM
epriestley requested review of D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:53 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:52 PM · Differential
epriestley committed rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior (authored by epriestley).
Fix an out-of-order issue in the new update-during-publish behavior
Sep 17 2020, 8:40 PM
epriestley closed D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:40 PM
epriestley requested review of D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:39 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:38 PM · Differential
epriestley closed D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Sep 17 2020, 8:20 PM
epriestley committed rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions (authored by epriestley).
In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
Sep 17 2020, 8:20 PM
epriestley requested review of D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Sep 17 2020, 8:19 PM
epriestley added a revision to T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring: D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Sep 17 2020, 8:19 PM · Arcanist, Conduit
epriestley triaged T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring as Low priority.
Sep 17 2020, 8:17 PM · Arcanist, Conduit
epriestley committed rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by… (authored by epriestley).
Fix a slow memory leak in long-lived FutureIterator objects, as used by…
Sep 17 2020, 7:56 PM
epriestley closed D21466: Fix a slow memory leak in long-lived FutureIterator objects, as used by FuturePool.
Sep 17 2020, 7:56 PM
epriestley requested review of D21466: Fix a slow memory leak in long-lived FutureIterator objects, as used by FuturePool.
Sep 17 2020, 7:53 PM
epriestley added a comment to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool.

This synthetic script demonstrates the conceptual problem with FutureIterator:

Sep 17 2020, 7:49 PM · Daemons
epriestley committed rPa754c694deab: Add missing indexes to DrydockRepositoryOperation (authored by epriestley).
Add missing indexes to DrydockRepositoryOperation
Sep 17 2020, 7:10 PM
epriestley closed D21465: Add missing indexes to DrydockRepositoryOperation.
Sep 17 2020, 7:10 PM
epriestley requested review of D21465: Add missing indexes to DrydockRepositoryOperation.
Sep 17 2020, 7:09 PM

Sep 16 2020

epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
Sep 16 2020, 12:44 AM · Differential
epriestley committed rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls (authored by epriestley).
Log unexpected exceptions raised by Conduit calls
Sep 16 2020, 12:37 AM
epriestley committed rP2a83df578604: Fix an issue where a GROUP BY was missing when a query matched a revision using… (authored by epriestley).
Fix an issue where a GROUP BY was missing when a query matched a revision using…
Sep 16 2020, 12:37 AM
epriestley committed rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… (authored by epriestley).
When an in-process worker subtask fails permanently, don't fatal the whole…
Sep 16 2020, 12:37 AM
epriestley committed rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… (authored by epriestley).
Move task and revision closure to the "publishing" step of the commit import…
Sep 16 2020, 12:37 AM
epriestley committed rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered (authored by epriestley).
Fix a view fatal in CommitGraphView when commits are undiscovered
Sep 16 2020, 12:37 AM
epriestley committed rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag (authored by epriestley).
When a commit is marked "closeable", clear the "published" flag
Sep 16 2020, 12:37 AM
epriestley committed rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record (authored by epriestley).
Make "CommitData" wrap and persist a "CommitRef" record
Sep 16 2020, 12:37 AM
epriestley closed D21464: Log unexpected exceptions raised by Conduit calls.
Sep 16 2020, 12:37 AM
epriestley closed D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Sep 16 2020, 12:37 AM
epriestley closed D21460: When a commit is marked "closeable", clear the "published" flag.
Sep 16 2020, 12:37 AM
epriestley committed rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" (authored by epriestley).
Wrap all direct access to author/committer properties on "CommitData"
Sep 16 2020, 12:37 AM
epriestley closed D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Sep 16 2020, 12:37 AM
epriestley committed rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley).
Turn "bypassCache" into a no-op in "diffusion.querycommits"
Sep 16 2020, 12:37 AM
epriestley closed T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Resolved by committing rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole….
Sep 16 2020, 12:37 AM · Daemons
epriestley committed rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… (authored by epriestley).
Build "DiffusionCommitRef" objects from "internal.commit.search", not…
Sep 16 2020, 12:37 AM
epriestley closed D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Sep 16 2020, 12:37 AM
epriestley closed D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Sep 16 2020, 12:37 AM
epriestley committed rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley).
Lift Diffusion Conduit call proxying to the root level of Conduit
Sep 16 2020, 12:37 AM
epriestley committed rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow (authored by epriestley).
Remove "bin/repository lookup-users" workflow
Sep 16 2020, 12:37 AM
epriestley committed rPa9506097ea04: Add "internal.commit.search" to replace the cache bypass mode of "diffusion. (authored by epriestley).
Add "internal.commit.search" to replace the cache bypass mode of "diffusion.
Sep 16 2020, 12:37 AM
epriestley closed D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Sep 16 2020, 12:37 AM
epriestley committed rP367cd289270d: Delete some commit dead parsing code (authored by epriestley).
Delete some commit dead parsing code
Sep 16 2020, 12:37 AM
epriestley closed D21448: Wrap all direct access to author/committer properties on "CommitData".
Sep 16 2020, 12:36 AM