Page MenuHomePhabricator

epriestley (Evan Priestley)Administrator
Overengineer

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (405 w, 2 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Today

epriestley committed rP533e4e13b35a: Add a `bin/herald test ...` for doing test runs via the CLI (authored by epriestley).
Add a `bin/herald test ...` for doing test runs via the CLI
Thu, Nov 15, 11:49 PM
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rP533e4e13b35a: Add a `bin/herald test ...` for doing test runs via the CLI.
Thu, Nov 15, 11:49 PM · Plans
epriestley closed D19806: Add a `bin/herald test ...` for doing test runs via the CLI.
Thu, Nov 15, 11:49 PM
epriestley committed rP8a8123c9db3b: Replace the primary "Disabled/Enabled" Herald Rule filter with… (authored by epriestley).
Replace the primary "Disabled/Enabled" Herald Rule filter with…
Thu, Nov 15, 11:47 PM
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rP8a8123c9db3b: Replace the primary "Disabled/Enabled" Herald Rule filter with….
Thu, Nov 15, 11:47 PM · Plans
epriestley closed D19805: Replace the primary "Disabled/Enabled" Herald Rule filter with "Active/Inactive", considering author status.
Thu, Nov 15, 11:47 PM
epriestley committed rPbbd292b9b34e: Modernize the Herald rule search engine (authored by epriestley).
Modernize the Herald rule search engine
Thu, Nov 15, 11:37 PM
epriestley closed D19803: Modernize the Herald rule search engine.
Thu, Nov 15, 11:37 PM
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rPbbd292b9b34e: Modernize the Herald rule search engine.
Thu, Nov 15, 11:37 PM · Plans
epriestley added inline comments to D19806: Add a `bin/herald test ...` for doing test runs via the CLI.
Thu, Nov 15, 11:21 PM
epriestley committed rPea6d2afa8685: Fix flickering tooltips in Chrome when the tip container overlaps the… (authored by epriestley).
Fix flickering tooltips in Chrome when the tip container overlaps the…
Thu, Nov 15, 6:44 PM
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rPea6d2afa8685: Fix flickering tooltips in Chrome when the tip container overlaps the….
Thu, Nov 15, 6:44 PM · Plans
epriestley closed D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Thu, Nov 15, 6:44 PM
epriestley closed T8440: Tooltip flicker at certain cursor positions as Resolved by committing rPea6d2afa8685: Fix flickering tooltips in Chrome when the tip container overlaps the….
Thu, Nov 15, 6:44 PM · PHUI
epriestley added a comment to T13179: sshd with "ForceUser" does not compile on High Sierra.

Good news: recent versions of sshd can pass the key fingerprint to the AuthorizedKeysCommand with %f: https://bugzilla.mindrot.org/show_bug.cgi?id=2081

Thu, Nov 15, 5:28 PM · Setup, Phacility
epriestley added a comment to T13179: sshd with "ForceUser" does not compile on High Sierra.

OpenSSH 7.9p1 builds cleanly and does not segfault immediately if configured like this:

Thu, Nov 15, 4:41 PM · Setup, Phacility
epriestley added a comment to T13179: sshd with "ForceUser" does not compile on High Sierra.

Yikes on rPe57bfbf421f4. Let me see if I can make this build.

Thu, Nov 15, 4:21 PM · Setup, Phacility
epriestley committed rP66896e8bf716: (stable) Pull some debugging code back out of "master" (authored by epriestley).
(stable) Pull some debugging code back out of "master"
Thu, Nov 15, 4:21 PM
epriestley committed rPe57bfbf421f4: Pull some debugging code back out of "master" (authored by epriestley).
Pull some debugging code back out of "master"
Thu, Nov 15, 4:20 PM
epriestley added a comment to T13216: 2018 Week 45-46 Bonus Content.

See PHI885, which requests timeouts on git fetch during working copy construction.

Thu, Nov 15, 3:42 PM · Plans
epriestley requested review of D19814: Continue cleaning up queries in the wake of changes to "%Q".
Thu, Nov 15, 2:02 PM
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19814: Continue cleaning up queries in the wake of changes to "%Q".
Thu, Nov 15, 2:00 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19814: Continue cleaning up queries in the wake of changes to "%Q".
Thu, Nov 15, 2:00 PM · Plans
epriestley added a child revision for D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision": D19814: Continue cleaning up queries in the wake of changes to "%Q".
Thu, Nov 15, 2:00 PM
epriestley updated the task description for T13216: 2018 Week 45-46 Bonus Content.
Thu, Nov 15, 1:44 PM · Plans
epriestley requested review of D19813: On the Diffusion cluster status page, improve device sort order.
Thu, Nov 15, 1:44 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19813: On the Diffusion cluster status page, improve device sort order.
Thu, Nov 15, 1:42 PM · Plans
epriestley requested review of D19812: Use "%P" to protect session key hashes in SessionEngine queries from DarkConsole.
Thu, Nov 15, 1:33 PM
epriestley updated the task description for T13216: 2018 Week 45-46 Bonus Content.
Thu, Nov 15, 1:33 PM · Plans
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19812: Use "%P" to protect session key hashes in SessionEngine queries from DarkConsole.
Thu, Nov 15, 1:32 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a revision to T6960: Support %P in qsprintf(): D19812: Use "%P" to protect session key hashes in SessionEngine queries from DarkConsole.
Thu, Nov 15, 1:32 PM · Security, Infrastructure
epriestley added a child revision for D19811: Keep the new "%P" query conversion out of the service call profiler by unmasking later: D19812: Use "%P" to protect session key hashes in SessionEngine queries from DarkConsole.
Thu, Nov 15, 1:32 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19812: Use "%P" to protect session key hashes in SessionEngine queries from DarkConsole.
Thu, Nov 15, 1:32 PM · Plans
epriestley requested review of D19811: Keep the new "%P" query conversion out of the service call profiler by unmasking later.
Thu, Nov 15, 1:29 PM
epriestley added a revision to T6960: Support %P in qsprintf(): D19811: Keep the new "%P" query conversion out of the service call profiler by unmasking later.
Thu, Nov 15, 1:28 PM · Security, Infrastructure
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19811: Keep the new "%P" query conversion out of the service call profiler by unmasking later.
Thu, Nov 15, 1:28 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19811: Keep the new "%P" query conversion out of the service call profiler by unmasking later.
Thu, Nov 15, 1:28 PM · Plans
epriestley updated the task description for T13217: Upgrading: Hardening of qsprintf().
Thu, Nov 15, 1:26 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added inline comments to D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision".
Thu, Nov 15, 1:16 PM
epriestley requested review of D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision".
Thu, Nov 15, 1:15 PM
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision".
Thu, Nov 15, 1:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision".
Thu, Nov 15, 1:14 PM · Plans
epriestley updated the task description for T13216: 2018 Week 45-46 Bonus Content.
Thu, Nov 15, 12:20 PM · Plans
epriestley requested review of D19809: Improve text overflow behavior for hovercards with (for example) long package names.
Thu, Nov 15, 12:20 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19809: Improve text overflow behavior for hovercards with (for example) long package names.
Thu, Nov 15, 12:18 PM · Plans
epriestley updated the summary of D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Thu, Nov 15, 12:17 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Thu, Nov 15, 12:16 PM · Plans
epriestley updated the summary of D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Thu, Nov 15, 12:16 PM
epriestley requested review of D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Thu, Nov 15, 12:13 PM
epriestley added a revision to T8440: Tooltip flicker at certain cursor positions: D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Thu, Nov 15, 12:05 PM · PHUI
epriestley added a comment to T8440: Tooltip flicker at certain cursor positions.

Here's the DOM with the tooltip container and timestamp container colored:

Thu, Nov 15, 12:03 PM · PHUI
epriestley committed rP96f9b0917e21: Improve performance of two recent commit migrations (authored by epriestley).
Improve performance of two recent commit migrations
Thu, Nov 15, 11:52 AM
epriestley closed D19802: Improve performance of two recent commit migrations.
Thu, Nov 15, 11:52 AM
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rP96f9b0917e21: Improve performance of two recent commit migrations.
Thu, Nov 15, 11:52 AM · Plans
epriestley committed rP86fd2041484f: Fix all query warnings in "arc unit --everything" (authored by epriestley).
Fix all query warnings in "arc unit --everything"
Thu, Nov 15, 11:51 AM
epriestley added a commit to T13217: Upgrading: Hardening of qsprintf(): rP86fd2041484f: Fix all query warnings in "arc unit --everything".
Thu, Nov 15, 11:51 AM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rP86fd2041484f: Fix all query warnings in "arc unit --everything".
Thu, Nov 15, 11:51 AM · Plans
epriestley closed D19801: Fix all query warnings in "arc unit --everything".
Thu, Nov 15, 11:51 AM
epriestley committed rPHU0e6ee5937ca5: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf() (authored by epriestley).
Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf()
Thu, Nov 15, 11:50 AM
epriestley added a commit to T13217: Upgrading: Hardening of qsprintf(): rPHU0e6ee5937ca5: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf().
Thu, Nov 15, 11:50 AM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley closed D19800: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf().
Thu, Nov 15, 11:50 AM
epriestley added a commit to T13216: 2018 Week 45-46 Bonus Content: rPHU0e6ee5937ca5: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf().
Thu, Nov 15, 11:50 AM · Plans
epriestley committed rP2f10d4adebf9: Continue making application fixes to Phabricator for changes to %Q semantics (authored by epriestley).
Continue making application fixes to Phabricator for changes to %Q semantics
Thu, Nov 15, 11:50 AM
epriestley added a commit to T13217: Upgrading: Hardening of qsprintf(): rP2f10d4adebf9: Continue making application fixes to Phabricator for changes to %Q semantics.
Thu, Nov 15, 11:50 AM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley closed D19790: Continue making application fixes to Phabricator for changes to %Q semantics.
Thu, Nov 15, 11:50 AM
epriestley committed rP98690ee326ce: Update many Phabricator queries for new %Q query semantics (authored by epriestley).
Update many Phabricator queries for new %Q query semantics
Thu, Nov 15, 11:48 AM
epriestley added a commit to T13217: Upgrading: Hardening of qsprintf(): rP98690ee326ce: Update many Phabricator queries for new %Q query semantics.
Thu, Nov 15, 11:48 AM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley closed D19789: Update many Phabricator queries for new %Q query semantics.
Thu, Nov 15, 11:48 AM
epriestley added inline comments to D19789: Update many Phabricator queries for new %Q query semantics.
Thu, Nov 15, 11:42 AM
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

A couple of narrow ideas here:

Thu, Nov 15, 11:42 AM · People, Phacility, Abuse
epriestley updated the diff for D19789: Update many Phabricator queries for new %Q query semantics.
  • Fix nul vs null.
Thu, Nov 15, 3:24 AM
epriestley requested review of D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction.

Stacked on qsprintf() changes.

Thu, Nov 15, 12:20 AM
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction.
Thu, Nov 15, 12:10 AM · Plans, Differential, Harbormaster
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction.
Thu, Nov 15, 12:10 AM · Plans
epriestley added a comment to T13216: 2018 Week 45-46 Bonus Content.

the message is sent from inside applyFinalEffects(), which is still inside the transaction

Thu, Nov 15, 12:00 AM · Plans

Yesterday

epriestley added a comment to T13216: 2018 Week 45-46 Bonus Content.

See PHI970, which identifies an issue with containerPHID not being populated correctly on a subset of buildables.

Wed, Nov 14, 11:51 PM · Plans
epriestley updated the task description for T13216: 2018 Week 45-46 Bonus Content.
Wed, Nov 14, 11:39 PM · Plans
epriestley committed rP64b52b9952dd: Make SELECT construction in PolicyAwareQuery safer (authored by epriestley).
Make SELECT construction in PolicyAwareQuery safer
Wed, Nov 14, 11:32 PM
epriestley added a commit to T13217: Upgrading: Hardening of qsprintf(): rP64b52b9952dd: Make SELECT construction in PolicyAwareQuery safer.
Wed, Nov 14, 11:32 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley closed D19785: Make SELECT construction in PolicyAwareQuery safer.
Wed, Nov 14, 11:32 PM
epriestley requested review of D19806: Add a `bin/herald test ...` for doing test runs via the CLI.

Stacked on qsprintf(),.

Wed, Nov 14, 11:30 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19806: Add a `bin/herald test ...` for doing test runs via the CLI.
Wed, Nov 14, 11:29 PM · Plans
epriestley requested review of D19805: Replace the primary "Disabled/Enabled" Herald Rule filter with "Active/Inactive", considering author status.

Stacked on qsprintf().

Wed, Nov 14, 11:27 PM
epriestley abandoned D19804: Moo Moo Moo.
Wed, Nov 14, 11:27 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19805: Replace the primary "Disabled/Enabled" Herald Rule filter with "Active/Inactive", considering author status.
Wed, Nov 14, 11:11 PM · Plans
epriestley committed rPe26c4bddab33: Replace magical "branch" behavior in "diffusion.branchquery" with an explicit… (authored by epriestley).
Replace magical "branch" behavior in "diffusion.branchquery" with an explicit…
Wed, Nov 14, 10:51 PM
epriestley added a commit to T13210: Plans: 2018 Week 41-44 Bonus Content: rPe26c4bddab33: Replace magical "branch" behavior in "diffusion.branchquery" with an explicit….
Wed, Nov 14, 10:51 PM · Plans
epriestley closed D19771: Replace magical "branch" behavior in "diffusion.branchquery" with an explicit "patterns".
Wed, Nov 14, 10:51 PM
epriestley requested review of D19804: Moo Moo Moo.
Wed, Nov 14, 10:27 PM
epriestley requested review of D19803: Modernize the Herald rule search engine.

Stacked on qsprintf() stuff.

Wed, Nov 14, 8:19 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19803: Modernize the Herald rule search engine.
Wed, Nov 14, 8:11 PM · Plans
epriestley requested review of D19802: Improve performance of two recent commit migrations.

Stacked on qsprintf() stuff.

Wed, Nov 14, 6:03 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19802: Improve performance of two recent commit migrations.
Wed, Nov 14, 5:45 PM · Plans

Tue, Nov 13

epriestley updated the diff for D19801: Fix all query warnings in "arc unit --everything".
  • Fix a couple minor oddities.
Tue, Nov 13, 6:41 PM
epriestley requested review of D19801: Fix all query warnings in "arc unit --everything".

Failing because it depends on %Z and %LK in D19800.

Tue, Nov 13, 6:35 PM
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19801: Fix all query warnings in "arc unit --everything".
Tue, Nov 13, 6:33 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a child revision for D19800: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf(): D19801: Fix all query warnings in "arc unit --everything".
Tue, Nov 13, 6:33 PM
epriestley added a revision to T13216: 2018 Week 45-46 Bonus Content: D19801: Fix all query warnings in "arc unit --everything".
Tue, Nov 13, 6:33 PM · Plans
epriestley requested review of D19800: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf().
Tue, Nov 13, 6:30 PM
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19800: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf().
Tue, Nov 13, 6:29 PM · Installing & Upgrading, Infrastructure, Security, Guides