epriestley (Evan Priestley)Administrator
Overengineer

Projects (80)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (320 w, 14 h)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Today

epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

In fact, I'm pretty surprised that your workflow doesn't hit major bugs/issues all the time, unless this stuff is currently far bugger than I believe it is. If you ever tag "Project Y" before moving a task to "Milestone 3", you'd no longer be able to move it from the workboard since it would vanish (until T11036)? Do you have a very specific sequence of organizational steps you take to avoid these issues? Are you just not using workboards at all?

Tue, Mar 28, 2:28 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

(And, unless it's also bugged, I believe moving from a milestone to a non-milestone column on "Project X" should already strip subprojects. The proposed behavior just prevents there from being any subprojects to strip.)

Tue, Mar 28, 2:24 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

I agree, I don't think project tags should ever be automatically removed.

Tue, Mar 28, 2:20 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

No, I don't mean that, as written.

Tue, Mar 28, 2:13 PM · Bug Report
epriestley closed T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for as "Resolved".

This has been out in the world for a little bit without exploding. I'd like to maybe do a bit of UI touchup but that can happen after T12272.

Tue, Mar 28, 1:31 PM · Audit, Restricted Project, Differential
epriestley closed T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for, a subtask of T10967: Move Differential reviewers back to a dedicated database storage table, as "Resolved".
Tue, Mar 28, 1:31 PM · Restricted Project, Infrastructure, Differential
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: D17568: When voiding "Accept" reviews, also void "Reject" reviews.
Tue, Mar 28, 1:24 PM · Restricted Project, Infrastructure, Differential
epriestley created D17568: When voiding "Accept" reviews, also void "Reject" reviews.
Tue, Mar 28, 1:24 PM
epriestley created D17567: Remove old code for "Request Review" action from Differential.
Tue, Mar 28, 1:10 PM
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: D17567: Remove old code for "Request Review" action from Differential.
Tue, Mar 28, 1:10 PM · Restricted Project, Infrastructure, Differential
epriestley edited projects for T12454: db schema error, added: Bug Report (Needs Information); removed Bug Report.

If you believe you've found a bug in Phabricator, we need all the information discussed in Contributing Bug Reports to move forward. Specifically:

Tue, Mar 28, 12:55 PM · Bug Report (Needs Information)
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: D17566: Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted".
Tue, Mar 28, 12:52 PM · Restricted Project, Infrastructure, Differential
epriestley created D17566: Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted".
Tue, Mar 28, 12:52 PM
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

I believe the expected behavior is that "milestone, subproject" kicks the task out of the milestone (leaving it in only the subproject) while "subproject, milestone" kicks it out of the subproject (leaving it in only the milestone).

Tue, Mar 28, 12:41 PM · Bug Report
epriestley closed T1081: Ability to undo a diff as "Wontfix".

I'm going to close this because I think it no longer meets the modern requirements for a feature request (it was filed in 2012). In particular, I don't understand why this is a problem:

Tue, Mar 28, 12:07 PM · Arcanist, Differential
epriestley added a comment to T10967: Move Differential reviewers back to a dedicated database storage table.

The workflow thing is somewhat nontrivial. Previously, we would explicitly downgrade "Accept" into "Accepted Older" when an author used "Request Review".

Tue, Mar 28, 11:57 AM · Restricted Project, Infrastructure, Differential
epriestley added a comment to D17564: Address some New Search Configuration Errata.

Just as a general workflow suggestion, I'd encourage you to do this as a bunch of small changes instead of one big "fix everything" change: I'm completely happy to review very small changes (e.g., just remove code with no callers; just do text fixes; etc). I'm also planning to help with T12450 myself and getting small pieces upstream sooner makes that easier in terms of testing/conflicts. It's completely fine for T12450 to end up with like 20 revisions attached to it, and I think this generally makes all the review/coordination/release/project management type stuff easier (and, at least for me, the engineering stuff too).

Tue, Mar 28, 11:47 AM
epriestley added a comment to T10967: Move Differential reviewers back to a dedicated database storage table.

From T10967, there's a minor workflow issue with "request review" incorrectly putting accepted changes back into an "accepted" state from this.

Tue, Mar 28, 11:32 AM · Restricted Project, Infrastructure, Differential
epriestley edited the description of T12450: New Search Configuration Errata.
Tue, Mar 28, 11:30 AM · Search
VRspace4 awarded T4900: Workboards updating in real time a Like token.
Tue, Mar 28, 5:06 AM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to D17564: Address some New Search Configuration Errata.

20after4 requested review of this revision.
This revision is now accepted and ready to land.

Tue, Mar 28, 1:44 AM

Yesterday

epriestley added a comment to T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.

Yep, thanks!

Mon, Mar 27, 8:42 PM · Projects, Maniphest, Search, Feature Request
epriestley merged T10872: any(Project) does not include Milestones of Project into T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.
Mon, Mar 27, 8:42 PM · Projects, Maniphest, Search, Feature Request
epriestley merged task T10872: any(Project) does not include Milestones of Project into T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.
Mon, Mar 27, 8:42 PM · Restricted Project, ApplicationSearch, Projects, Bug Report
epriestley accepted D17564: Address some New Search Configuration Errata.
Mon, Mar 27, 7:46 PM
epriestley accepted D17565: Scope syntax css rules to direct descendants only in diffs.
Mon, Mar 27, 5:25 PM
epriestley added a comment to T9900: Figlet does not properly render apostrophes with some characters.

THANKS FOR RUINING THE JOKE EVERYONE

Mon, Mar 27, 4:40 PM · Contributor Onboarding, Remarkup
epriestley accepted D17563: Cleaner fullscreen / preview states for Remarkup bar.

If you fullscreen, then click "Upload File", do the masks get screwed up and/or stuck?

Mon, Mar 27, 3:14 PM
epriestley edited projects for T12452: Can't edit task description after upgrading to the latest version, added: Bug Report (Needs Information); removed Bug Report.

We need reproduction steps to move forward. See Providing Reproduction Steps.

Mon, Mar 27, 3:11 PM · Bug Report (Needs Information)
epriestley added a comment to T12450: New Search Configuration Errata.

so it's tokenizing maniphest.query as two separate tokens

Mon, Mar 27, 3:05 PM · Search

Sun, Mar 26

epriestley reopened T8918: Header shows number of notifications and various other controls on the 2FA auth screen as "Open".

(This was incorrectly closed by the text "doesn't actually fix T8918" in rP08de131da525.)

Sun, Mar 26, 8:15 PM · Security, Auth
epriestley reopened T8918: Header shows number of notifications and various other controls on the 2FA auth screen, a subtask of T8442: Build Space switching UI, as "Open".
Sun, Mar 26, 8:15 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T12450: New Search Configuration Errata.

Personal notes:

Sun, Mar 26, 2:35 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 1:04 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:55 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:54 PM · Search
epriestley added a comment to D17300: Add repositories to fulltext search index..

It probably should -- you could always write \\n if you really wanted a literal backslash + n -- I think we just haven't hit it before.

Sun, Mar 26, 12:50 PM · Diffusion, Search
epriestley added a project to T6906: Archived / closed objects don't have "closed" look in typeahead results, in global search typeahead only: Contributor Onboarding.
Sun, Mar 26, 12:47 PM · Contributor Onboarding, Search, Design & Planning
epriestley renamed T6906: Archived / closed objects don't have "closed" look in typeahead results, in global search typeahead only from "archived / closed objects don't have "closed" look in typeahead results" to "Archived / closed objects don't have "closed" look in typeahead results, in global search typeahead only".
Sun, Mar 26, 12:47 PM · Contributor Onboarding, Search, Design & Planning
epriestley moved T8646: Provide more context for search results, particularly wiki documents from v2 to v3 on the Search board.
Sun, Mar 26, 12:46 PM · Design & Planning, Search, Restricted Project
epriestley moved T5941: Show Phriction Pages in Search Typeahead from Backlog to v3 on the Search board.
Sun, Mar 26, 12:46 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:44 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:44 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:44 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.
I can not reproduce it on wikimedia's install.
Sun, Mar 26, 12:43 PM · Search
epriestley closed T8602: "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch as "Resolved".

Presuming this is resolved since @20after4 couldn't reproduce it after T12450, feel free to follow up there or in a new task if you're still seeing issues.

Sun, Mar 26, 12:43 PM · Elasticsearch, Search
epriestley renamed T12438: Project tokenizer functions like "any()" and "not()" do not include descendants from "Unable to query tasks from multiple projects in maniphest advanced " to "Project tokenizer functions like "any()" and "not()" do not include descendants".
Sun, Mar 26, 12:42 PM · Projects, Maniphest, Search, Feature Request
epriestley removed a project from T4182: add date chooser for ApplicationSearch date fields: Search.
Sun, Mar 26, 12:41 PM · ApplicationSearch
epriestley moved T7860: Project tags can not be found via the fulltext search index from Backlog to v2 on the Search board.
Sun, Mar 26, 12:41 PM · Search
epriestley closed T10640: Allow application queries to be promoted as global search modes as "Wontfix".

I don't plan to implement the original feature as described.

Sun, Mar 26, 12:41 PM · Search, Feature Request
epriestley moved T10315: Make it more clear to users how to rebuild search indexes after adding search support to custom fields from Backlog to v2 on the Search board.
Sun, Mar 26, 12:36 PM · Custom Fields, Search, Documentation
epriestley moved T9777: Search's autocomplete doesn't work on non-standard reserved keys in Object.prototype in Firefox's JavaScript engine from Backlog to v2 on the Search board.
Sun, Mar 26, 12:36 PM · Search
epriestley closed T10639: Implement a complex Gmail-style "to:<name>" query language as "Wontfix".

We haven't seen significant additional interest in this in more than a year. I expect to implement T7860 but, not a query microlanguage.

Sun, Mar 26, 12:36 PM · Search, Feature Request
epriestley moved T12443: Applying fulltext limits first causes missing results from Backlog to v2 on the Search board.
Sun, Mar 26, 12:32 PM · Restricted Project, Search, Bug Report
epriestley moved T12003: Explain to users how fulltext queries are parsed and executed from Backlog to v2 on the Search board.
Sun, Mar 26, 12:32 PM · Search
epriestley moved T12450: New Search Configuration Errata from Backlog to v2 on the Search board.
Sun, Mar 26, 12:32 PM · Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:30 PM · Search
epriestley closed T9460: Unable to search for open tasks using Elasticsearch as "Resolved".

Presuming this is resolved by D17384, see T12450 for followups.

Sun, Mar 26, 12:30 PM · Elasticsearch, Search
epriestley closed T8598: Incorrect Elasticsearch index as "Resolved".

Presuming this is resolved by new indexes in D17384, see T12450 for followups.

Sun, Mar 26, 12:29 PM · Elasticsearch, Search
epriestley closed T6892: Invalid search result when I input less than 2 Korean character., a subtask of T12003: Explain to users how fulltext queries are parsed and executed, as "Resolved".
Sun, Mar 26, 12:28 PM · Search
epriestley closed T6892: Invalid search result when I input less than 2 Korean character. as "Resolved".

This was tagged ElasticSearch and may now be resolved (see T12450) but also lacks information we require in a modern bug report (specifically: precise reproduction instructions). If this is still an issue at HEAD of master, feel free to follow up on T12450 or file a new report with reproduction steps.

Sun, Mar 26, 12:28 PM · Elasticsearch
epriestley closed T4692: Slashes are being double-escaped (or not escaped?) when passed to ElasticSearch as "Resolved".

Presuming this is resolved by D17384 (but maybe @20after4 can correct me).

Sun, Mar 26, 12:26 PM · Elasticsearch
epriestley removed a project from T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Elasticsearch.
Sun, Mar 26, 12:25 PM · Support Impact, Search
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:25 PM · Search
epriestley closed T10161: Fulltext indexing produces invalid JSON documents in Elasticsearch as "Resolved".

Presuming this is either resolved by T9893/D17384 or no longer relevant. Follow up on T12450 or file a new task if you're still seeing issues.

Sun, Mar 26, 12:24 PM · Elasticsearch, Bug Report
epriestley edited the description of T12450: New Search Configuration Errata.
Sun, Mar 26, 12:24 PM · Search
epriestley closed T5282: Provide documentation on setting up ElasticSearch as "Resolved".

I'm just going to close this in favor of T12450.

Sun, Mar 26, 12:20 PM · Elasticsearch, Documentation
epriestley closed T5282: Provide documentation on setting up ElasticSearch, a subtask of T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it, as "Resolved".
Sun, Mar 26, 12:20 PM · Support Impact, Search
epriestley created T12450: New Search Configuration Errata.
Sun, Mar 26, 12:20 PM · Search
epriestley added a comment to T6552: Implement partial / wildcard searching (Elasticsearch).

As a general product decision, I do not expect search to be substring search by default -- searching for pricot on Google does not match documents containing apricot. But we can sort this out in the long run.

Sun, Mar 26, 12:16 PM · Elasticsearch, Search
epriestley accepted D17300: Add repositories to fulltext search index..

One minor inline.

Sun, Mar 26, 12:11 PM · Diffusion, Search
epriestley added a comment to D17300: Add repositories to fulltext search index..

In terms of figuring out which repository your working copy is, what does arc which show?

Sun, Mar 26, 12:08 PM · Diffusion, Search

Sat, Mar 25

epriestley closed T12448: Rotate 2017 SSL certificate for `secure.phabricator.com` as "Resolved".

These are now up to date.

Sat, Mar 25, 12:56 PM · Ops
epriestley committed rP8f7983a5be3a: (stable) Only hibernate the Taskmaster after 15 seconds of inactivity (authored by epriestley).
(stable) Only hibernate the Taskmaster after 15 seconds of inactivity
Sat, Mar 25, 12:02 PM
epriestley committed rPHUb133c2770148: (stable) Allow daemons to read their own idle state (authored by epriestley).
(stable) Allow daemons to read their own idle state
Sat, Mar 25, 12:02 PM
epriestley committed rPa41d158490c0: Only hibernate the Taskmaster after 15 seconds of inactivity (authored by epriestley).
Only hibernate the Taskmaster after 15 seconds of inactivity
Sat, Mar 25, 12:02 PM
epriestley committed rPHUc581e769f10c: Allow daemons to read their own idle state (authored by epriestley).
Allow daemons to read their own idle state
Sat, Mar 25, 12:01 PM
epriestley committed rPHUe11e4887ae66: (stable) Don't hibernate daemons if we'd sleep for less than 30 seconds (authored by epriestley).
(stable) Don't hibernate daemons if we'd sleep for less than 30 seconds
Sat, Mar 25, 11:47 AM
epriestley committed rPHUfbffb8bf834c: Don't hibernate daemons if we'd sleep for less than 30 seconds (authored by epriestley).
Don't hibernate daemons if we'd sleep for less than 30 seconds
Sat, Mar 25, 11:47 AM
epriestley committed rPb2c029cbad5d: (stable) Make the default Trigger hibernation 3 minutes instead of 5 seconds (authored by epriestley).
(stable) Make the default Trigger hibernation 3 minutes instead of 5 seconds
Sat, Mar 25, 11:18 AM
epriestley committed rP2cda280cde20: Make the default Trigger hibernation 3 minutes instead of 5 seconds (authored by epriestley).
Make the default Trigger hibernation 3 minutes instead of 5 seconds
Sat, Mar 25, 11:17 AM
epriestley committed rPHUb3caacfc1197: (stable) When daemons hibernate, mark them as not busy (authored by epriestley).
(stable) When daemons hibernate, mark them as not busy
Sat, Mar 25, 10:17 AM
epriestley committed rPHUc8a3262a4667: When daemons hibernate, mark them as not busy (authored by epriestley).
When daemons hibernate, mark them as not busy
Sat, Mar 25, 10:17 AM
epriestley closed T12449: Cannot set access control for creating new Maniphest forms as "Resolved".

I'm going to presume this is approximately resolved.

Sat, Mar 25, 1:09 AM · Bug Report
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

But if you say "Haskell" you may have to wait a minute.

Sat, Mar 25, 12:46 AM · Conduit, Feature Request
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

Maybe easier would be for you to tell me what language you want to use and I'll just write you a snippet which encodes a request?

Sat, Mar 25, 12:45 AM · Conduit, Feature Request
epriestley edited the content of Changelog.
Sat, Mar 25, 12:42 AM
epriestley committed rPHU75da31a28222: (stable) Promote 2017 Week 12 (authored by epriestley).
(stable) Promote 2017 Week 12
Sat, Mar 25, 12:42 AM
epriestley committed rARC60aaee0ed3f5: (stable) Promote 2017 Week 12 (authored by epriestley).
(stable) Promote 2017 Week 12
Sat, Mar 25, 12:42 AM
epriestley committed rP6f1e2d80553a: (stable) Promote 2017 Week 12 (authored by epriestley).
(stable) Promote 2017 Week 12
Sat, Mar 25, 12:42 AM
epriestley created 2017 Week 12 (Very Late March).
Sat, Mar 25, 12:41 AM
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

The page implies that all I should need to do is POST up, for example, the following:

Sat, Mar 25, 12:38 AM · Conduit, Feature Request

Fri, Mar 24

epriestley committed rPb4effdf26c3e: Fix a rendering fatal for unknown edge constants (authored by epriestley).
Fix a rendering fatal for unknown edge constants
Fri, Mar 24, 11:59 PM
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

(In the longer term, the permissions here could probably be cleaned up, but I think that's the cleanest fix without upstream changes.)

Fri, Mar 24, 10:53 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

You can edit the "Create Form" form and change "Visible To:" to "Members of Project: Doctorate in Form Theory". Then only members of that project will be able to create other forms or edit the form form, I believe.

Fri, Mar 24, 10:50 PM · Bug Report
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Ah. I think you'd just see this, then:

Fri, Mar 24, 10:01 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Overall, you only get checkboxes for users, packages and projects which are already reviewers, with the exception that you'll get one for yourself if you aren't a reviewer yet.

Fri, Mar 24, 9:47 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

I think there is also zero legitimate reason for the form-configuring-form to be editable and this entire workflow essentially represents a trap for the unwary.

Fri, Mar 24, 9:43 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

If you can't enable that form, you might need to go hunt it down in the database and manually enable it (or tell me what you hit and we'll fix it if it's a bug).

Fri, Mar 24, 9:38 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

Can you click that link, then "Enable Form"? Or do you get some kind of error?

Fri, Mar 24, 9:36 PM · Bug Report