epriestley (Evan Priestley)Administrator
Overengineer

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (376 w, 23 h)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Yesterday

epriestley requested review of D19404: Fix a typo in the Diffusion importing user guide.
Tue, Apr 24, 11:02 PM
epriestley added a comment to D19403: Add "Content type" and "Rule type" fields to Herald rules for Herald rules.

The only other field which seems possibly useful here is "Name", but I can't really come up with any reasons why you'd ever want to do something when, e.g., a rule's name matches some regexp.

Tue, Apr 24, 10:45 PM
epriestley requested review of D19403: Add "Content type" and "Rule type" fields to Herald rules for Herald rules.
Tue, Apr 24, 10:44 PM
epriestley added a revision to T13130: Plans: 2018 Week 17 Bonus Content: D19403: Add "Content type" and "Rule type" fields to Herald rules for Herald rules.
Tue, Apr 24, 10:43 PM · Plans
epriestley added a dependent revision for D19400: Support Herald rules for Herald rules: D19403: Add "Content type" and "Rule type" fields to Herald rules for Herald rules.
Tue, Apr 24, 10:43 PM
epriestley updated the task description for T13130: Plans: 2018 Week 17 Bonus Content.
Tue, Apr 24, 4:29 PM · Plans
epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

I'm going to tentatively put this (the Phriction rule, specifically) into T13130 for this week although I'm not sure how much work getting getDefaultPolicyForObject() to return the root document policy is and maybe that's Unbelievably Difficult. Let me take a quick look at that and you can either run with it or I can pick it up if it's some kind of weird arcana.

Tue, Apr 24, 4:26 PM · Policy, PHUI, Phriction
ermik awarded T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud) a Like token.
Tue, Apr 24, 12:11 PM

Mon, Apr 23

epriestley updated the diff for D19400: Support Herald rules for Herald rules.
  • Fix "a another".
  • Remove stray "phlog()".
Mon, Apr 23, 10:05 PM
epriestley added inline comments to D19399: Manage object mailKeys automatically in Mail instead of storing them on objects.
Mon, Apr 23, 10:04 PM
epriestley committed rP16af0d35e510: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft" (authored by epriestley).
In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
Mon, Apr 23, 9:39 PM
epriestley added a commit to T13130: Plans: 2018 Week 17 Bonus Content: rP16af0d35e510: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft".
Mon, Apr 23, 9:39 PM · Plans
epriestley closed D19398: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft".
Mon, Apr 23, 9:39 PM
epriestley updated the task description for T13065: Move storage for `mailKey` to the Mail application.
Mon, Apr 23, 9:23 PM · Mail
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

Ah, yeah. No idea why I typed "blind" instead.

Mon, Apr 23, 9:23 PM · Mail
epriestley added inline comments to D19399: Manage object mailKeys automatically in Mail instead of storing them on objects.
Mon, Apr 23, 9:10 PM
epriestley requested review of D19400: Support Herald rules for Herald rules.
Mon, Apr 23, 9:08 PM
epriestley updated the summary of D19399: Manage object mailKeys automatically in Mail instead of storing them on objects.
Mon, Apr 23, 9:07 PM
epriestley added a dependent revision for D19399: Manage object mailKeys automatically in Mail instead of storing them on objects: D19400: Support Herald rules for Herald rules.
Mon, Apr 23, 9:07 PM
epriestley added a revision to T13130: Plans: 2018 Week 17 Bonus Content: D19400: Support Herald rules for Herald rules.
Mon, Apr 23, 9:07 PM · Plans
epriestley requested review of D19399: Manage object mailKeys automatically in Mail instead of storing them on objects.
Mon, Apr 23, 9:02 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D19399: Manage object mailKeys automatically in Mail instead of storing them on objects.
Mon, Apr 23, 9:01 PM · Mail
epriestley added a comment to T13130: Plans: 2018 Week 17 Bonus Content.

One option is to write "Herald Rules for Herald Rules".

Mon, Apr 23, 3:09 AM · Plans

Sun, Apr 22

epriestley added a comment to T13130: Plans: 2018 Week 17 Bonus Content.

Offhand, two possible issues with that:

Sun, Apr 22, 9:29 PM · Plans
epriestley added a comment to T13130: Plans: 2018 Week 17 Bonus Content.

See PHI580. An install would like write API access to object relationships (depends on, fixes, etc). This is complicated, but perhaps plannable, and we may be able to put a reasonable facade with partial support into the upstream.

Sun, Apr 22, 3:59 PM · Plans
epriestley added a comment to T13130: Plans: 2018 Week 17 Bonus Content.

See PHI592. A diff with 600MB of videos required more than two hours to turn into an email patch, which exceeded the task lease duration and cascaded into various other kinds of problems.

Sun, Apr 22, 3:06 PM · Plans
epriestley added a comment to T13130: Plans: 2018 Week 17 Bonus Content.

See PHI285. An install would like a way to monitor changes to Herald rules.

Sun, Apr 22, 2:37 PM · Plans
epriestley added a comment to T13130: Plans: 2018 Week 17 Bonus Content.

See PHI251. This requests an "Ignore generated changes." option for Owners.

Sun, Apr 22, 2:11 PM · Plans

Sat, Apr 21

epriestley requested review of D19398: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft".
Sat, Apr 21, 8:11 PM
epriestley added a revision to T13130: Plans: 2018 Week 17 Bonus Content: D19398: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft".
Sat, Apr 21, 8:09 PM · Plans
epriestley closed T13124: Plans: 2018 Week 16 Bonus Content as Resolved.
Sat, Apr 21, 7:58 PM · Plans
epriestley committed rP7622f6afccf4: Fix excessively severe CSP URI error during first-time setup (authored by epriestley).
Fix excessively severe CSP URI error during first-time setup
Sat, Apr 21, 4:44 PM
epriestley closed D19396: Fix excessively severe CSP URI error during first-time setup.
Sat, Apr 21, 4:43 PM
epriestley awarded D19394: Update install_ubuntu.sh to the new age a Doubloon token.
Sat, Apr 21, 4:43 PM
epriestley accepted D19394: Update install_ubuntu.sh to the new age.

I didn't catch anything substantive beyond the typo @amckinley caught.

Sat, Apr 21, 4:43 PM
epriestley requested review of D19396: Fix excessively severe CSP URI error during first-time setup.
Sat, Apr 21, 4:32 PM
epriestley added a comment to D19394: Update install_ubuntu.sh to the new age.

Incidentally, the first page shown after the install

Sat, Apr 21, 2:10 PM
epriestley added a comment to D19394: Update install_ubuntu.sh to the new age.

I do sort of like the ring of "confuguring".

Sat, Apr 21, 2:09 PM
richardvanvelzen awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a The World Burns token.
Sat, Apr 21, 10:45 AM · Design & Planning, Differential, Plans
eadler awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a Hungry Hippo token.
Sat, Apr 21, 5:33 AM · Design & Planning, Differential, Plans

Fri, Apr 20

epriestley edited the content of Changelog.
Fri, Apr 20, 9:54 PM
epriestley committed rARC23f199bf1807: (stable) Promote 2018 Week 16 (authored by epriestley).
(stable) Promote 2018 Week 16
Fri, Apr 20, 9:53 PM
epriestley committed rP201c56a91ee5: (stable) Promote 2018 Week 16 (authored by epriestley).
(stable) Promote 2018 Week 16
Fri, Apr 20, 9:53 PM
epriestley created 2018 Week 16 (Late April).
Fri, Apr 20, 9:53 PM
epriestley updated the task description for T13126: Plans: Diffusion cleanup for document engine.
Fri, Apr 20, 9:38 PM · Plans, Diffusion
epriestley committed rP33da9f833fdd: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`) (authored by epriestley).
Fix odd line number line wrapping on embedded pastes (`{Pxxx}`)
Fri, Apr 20, 9:20 PM
epriestley closed D19393: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`).
Fri, Apr 20, 9:20 PM
epriestley added a commit to T13126: Plans: Diffusion cleanup for document engine: rP33da9f833fdd: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`).
Fri, Apr 20, 9:20 PM · Plans, Diffusion
epriestley committed rP8c78cde32f5e: Stop "git blame" from printing "^" markers on root repository commits (authored by epriestley).
Stop "git blame" from printing "^" markers on root repository commits
Fri, Apr 20, 9:13 PM
epriestley closed D19392: Stop "git blame" from printing "^" markers on root repository commits.
Fri, Apr 20, 9:13 PM
epriestley added a commit to T13126: Plans: Diffusion cleanup for document engine: rP8c78cde32f5e: Stop "git blame" from printing "^" markers on root repository commits.
Fri, Apr 20, 9:13 PM · Plans, Diffusion
epriestley committed rP95e179d9a4f3: Fix a fatal in the document engine blame view with files that blame to the… (authored by epriestley).
Fix a fatal in the document engine blame view with files that blame to the…
Fri, Apr 20, 9:13 PM
epriestley added a commit to T13126: Plans: Diffusion cleanup for document engine: rP95e179d9a4f3: Fix a fatal in the document engine blame view with files that blame to the….
Fri, Apr 20, 9:12 PM · Plans, Diffusion
epriestley closed D19391: Fix a fatal in the document engine blame view with files that blame to the initial commit.
Fri, Apr 20, 9:12 PM
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

As a general update here since a couple installs are keeping an eye on it, I have a big chunk of the "use instance.state for everything" diff written, but some of the caching logic is tricky and I haven't had a solid chunk of uninterrupted time to stare at it in the last couple days so I don't expect to get it out in time for the release this week.

Fri, Apr 20, 9:10 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a commit to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Diffusion Commit).
Fri, Apr 20, 9:03 PM · Plans, Ops, Infrastructure, Phacility
epriestley requested review of D19393: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`).
Fri, Apr 20, 8:17 PM
epriestley added a revision to T13126: Plans: Diffusion cleanup for document engine: D19393: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`).
Fri, Apr 20, 8:16 PM · Plans, Diffusion
epriestley requested review of D19392: Stop "git blame" from printing "^" markers on root repository commits.
Fri, Apr 20, 8:12 PM
epriestley added a dependent revision for D19391: Fix a fatal in the document engine blame view with files that blame to the initial commit: D19392: Stop "git blame" from printing "^" markers on root repository commits.
Fri, Apr 20, 8:11 PM
epriestley added a revision to T13126: Plans: Diffusion cleanup for document engine: D19392: Stop "git blame" from printing "^" markers on root repository commits.
Fri, Apr 20, 8:11 PM · Plans, Diffusion
epriestley updated the task description for T13126: Plans: Diffusion cleanup for document engine.
Fri, Apr 20, 7:59 PM · Plans, Diffusion
epriestley requested review of D19391: Fix a fatal in the document engine blame view with files that blame to the initial commit.
Fri, Apr 20, 7:56 PM
epriestley added a revision to T13126: Plans: Diffusion cleanup for document engine: D19391: Fix a fatal in the document engine blame view with files that blame to the initial commit.
Fri, Apr 20, 7:55 PM · Plans, Diffusion
epriestley added a comment to D19380: Allow demoted builds to automatically promote if builds pass after a restart.

Oh, no problem.

Fri, Apr 20, 5:55 PM
epriestley committed rP9bf4df2c1ddf: Allow demoted builds to automatically promote if builds pass after a restart (authored by epriestley).
Allow demoted builds to automatically promote if builds pass after a restart
Fri, Apr 20, 5:51 PM
epriestley added a commit to T13124: Plans: 2018 Week 16 Bonus Content: rP9bf4df2c1ddf: Allow demoted builds to automatically promote if builds pass after a restart.
Fri, Apr 20, 5:51 PM · Plans
epriestley closed D19380: Allow demoted builds to automatically promote if builds pass after a restart.
Fri, Apr 20, 5:51 PM
epriestley updated the task description for T13130: Plans: 2018 Week 17 Bonus Content.
Fri, Apr 20, 4:29 PM · Plans
epriestley accepted D19389: Correctly parse `git status --porcelain=2` output with filenames with spaces.
Fri, Apr 20, 2:07 AM
epriestley added a comment to T4200: Building OS packages and install scripts.

I'm happy to bring either change upstream if you want to do the legwork. We could also move them to a wiki page or something. No option here feels particularly good to me.

Fri, Apr 20, 2:07 AM · Guides, Setup
epriestley accepted D19388: Add unique constraint to AlmanacInterfaces.

I can't come up with any other ways to break this.

Fri, Apr 20, 1:56 AM
epriestley added a comment to D19388: Add unique constraint to AlmanacInterfaces.

I think this reattaches the bindings to the interface we delete, not the actual survivor? Maybe I'm crazy but:

Fri, Apr 20, 1:15 AM
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Fri, Apr 20, 1:08 AM · Plans, Differential
epriestley updated the task description for T13130: Plans: 2018 Week 17 Bonus Content.
Fri, Apr 20, 12:43 AM · Plans
epriestley added a commit to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Diffusion Commit).
Fri, Apr 20, 12:25 AM · Plans, Ops, Infrastructure, Phacility
epriestley added a commit to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Diffusion Commit).
Fri, Apr 20, 12:25 AM · Plans, Ops, Infrastructure, Phacility
epriestley committed rP843bfb4fd8ac: Add a "commits" attachment to "differential.diff.search" for retrieving local… (authored by epriestley).
Add a "commits" attachment to "differential.diff.search" for retrieving local…
Fri, Apr 20, 12:25 AM
epriestley added a commit to T13124: Plans: 2018 Week 16 Bonus Content: rP843bfb4fd8ac: Add a "commits" attachment to "differential.diff.search" for retrieving local….
Fri, Apr 20, 12:25 AM · Plans
epriestley closed D19386: Add a "commits" attachment to "differential.diff.search" for retrieving local commit information.
Fri, Apr 20, 12:25 AM
epriestley committed rP19403fdb8e29: Improve color use in "[+++- ]" element for colorblind users (authored by epriestley).
Improve color use in "[+++- ]" element for colorblind users
Fri, Apr 20, 12:24 AM
epriestley added a commit to T13127: Plans: Form Steering Committee For "+/-" Line Indicators: rP19403fdb8e29: Improve color use in "[+++- ]" element for colorblind users.
Fri, Apr 20, 12:24 AM · Design & Planning, Differential, Plans
epriestley closed D19385: Improve color use in "[+++- ]" element for colorblind users.
Fri, Apr 20, 12:24 AM
epriestley committed rP70d67a3908b8: Fix the most significant "phantom notification" badness (authored by epriestley).
Fix the most significant "phantom notification" badness
Fri, Apr 20, 12:24 AM
epriestley closed T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view as Resolved by committing rP70d67a3908b8: Fix the most significant "phantom notification" badness.
Fri, Apr 20, 12:24 AM · Wikimedia, Notifications
epriestley added a commit to T13131: Notifications menu has a couple of minor rendering issues: rP70d67a3908b8: Fix the most significant "phantom notification" badness.
Fri, Apr 20, 12:24 AM · Design & Planning, Aphlict
epriestley added a commit to T13124: Plans: 2018 Week 16 Bonus Content: rP70d67a3908b8: Fix the most significant "phantom notification" badness.
Fri, Apr 20, 12:24 AM · Plans
epriestley closed D19384: Fix the most significant "phantom notification" badness.
Fri, Apr 20, 12:24 AM

Thu, Apr 19

epriestley added a comment to D19388: Add unique constraint to AlmanacInterfaces.

Definitely OK to just make the rows as-correct-as-possible without writing transactions for them.

Thu, Apr 19, 11:49 PM
epriestley added a comment to D19388: Add unique constraint to AlmanacInterfaces.

I haven't run into that LOCK TABLE thing before, but some googling suggests that maybe you need to be using raw queryfx() stuff on the same $conn? I'd normally expect the existing w mode $conn to get reused (since we can use a 'w' conn for 'r'), but maybe that isn't actually what happens today.

Thu, Apr 19, 11:18 PM
epriestley accepted D19387: Add edge tables for Phlux.
Thu, Apr 19, 10:38 PM
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Thu, Apr 19, 7:56 PM · Plans, Differential
epriestley requested review of D19386: Add a "commits" attachment to "differential.diff.search" for retrieving local commit information.
Thu, Apr 19, 7:03 PM
epriestley added a revision to T13124: Plans: 2018 Week 16 Bonus Content: D19386: Add a "commits" attachment to "differential.diff.search" for retrieving local commit information.
Thu, Apr 19, 7:02 PM · Plans
epriestley requested review of D19385: Improve color use in "[+++- ]" element for colorblind users.
Thu, Apr 19, 6:32 PM
epriestley added a revision to T13127: Plans: Form Steering Committee For "+/-" Line Indicators: D19385: Improve color use in "[+++- ]" element for colorblind users.
Thu, Apr 19, 6:31 PM · Design & Planning, Differential, Plans
epriestley added a comment to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.

After D19384, we'll automatically mark these "phantom" notifications as read when you open the menu to review them:

Thu, Apr 19, 6:09 PM · Wikimedia, Notifications
epriestley added a comment to T13131: Notifications menu has a couple of minor rendering issues.

D19384 cleans this up a little bit and mostly fixes the "phantom unread notification" issue in T8953.

Thu, Apr 19, 6:07 PM · Design & Planning, Aphlict
epriestley requested review of D19384: Fix the most significant "phantom notification" badness.
Thu, Apr 19, 6:00 PM
epriestley added a revision to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view: D19384: Fix the most significant "phantom notification" badness.
Thu, Apr 19, 5:59 PM · Wikimedia, Notifications