Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (616 w, 2 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Tue, Nov 22

epriestley triaged T13691: Prevent 2015 Audi Q3 radio from playing music on vehicle start as Normal priority.
Tue, Nov 22, 9:51 PM · Hardware

Fri, Nov 4

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Couple of years ago the furnace wasn't working so well. Light comes on, three reds. Pressure switch stuck open. I take off a panel, pull the pressure switches. The contacts close properly. No clue what's wrong. Call an HVAC guy. He's pretty busy. No problem, we got plenty of sweaters. Ha. He makes it out early the next week.

Fri, Nov 4, 4:04 AM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

... condensate drain ...

Fri, Nov 4, 12:28 AM · Hardware
epriestley triaged T13690: A Considered Review: PCB Manufacturing as Wishlist priority.
Fri, Nov 4, 12:21 AM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

...there's enough absorbent material underneath the sink...

Fri, Nov 4, 12:05 AM · Hardware

Thu, Nov 3

epriestley updated the task description for T13689: A Considered Review: 3D Printing.
Thu, Nov 3, 11:44 PM · Hardware
epriestley triaged T13689: A Considered Review: 3D Printing as Wishlist priority.
Thu, Nov 3, 11:43 PM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

I can't see a way to make the trap be any less garbage than it is because the 4" flanged tailpipe (the shortest flanged 1-1/4" tailpipe I could find) plus an additional 8" of tailpipe underneath it (the only 1-1/4" branch tailpipe I could find, which is only available with a slip fitting) means that the bottom of the lower tailpipe is super low. It looks like I left an extra 6" of flexible pipe on the drain side for fun, but that's just the rigid bottom of the tailpipe plus the minimum bend radius without making the flexible pipe start to crimp -- the bottom of the tailpipe is like 1-1/2" below the black plastic retainer clip.

Thu, Nov 3, 9:09 PM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Since there's no fresh water supply to the dehumidifier I don't think there's much benefit to an air gap, as there's no way backflow could ever contaminate a supply line. A clogged sink drain could possibly drain sink water out through the dehumidifier bucket, but the top of the drain line is only ~1"-2" below the top of the sink so it would overflow the basin onto the floor before very long anyway.

Thu, Nov 3, 8:14 PM · Hardware

Oct 26 2022

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Other options I explored and rejected:

Oct 26 2022, 8:42 PM · Hardware
epriestley triaged T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe? as Wishlist priority.
Oct 26 2022, 8:34 PM · Hardware
epriestley created Hardware.
Oct 26 2022, 8:32 PM
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
  • Inline Comments: See PHI2217. See PHI2206. Inline comments don't currently attach images.
  • Destroying Edges: See PHI2201. See PHI2217. Destroying files that have old edge types may raise warnings. The destruction still works, although it doesn't hit the edges.
  • Destroying Files: See PHI2217. Destroying an object doesn't destroy corresponding FileAttachment objects, so you can end up with ghosts in the UI.
Oct 26 2022, 8:08 PM · Remarkup
epriestley closed T13683: Security Guidance: References to Files in Remarkup as Resolved.

There are some remaining non-security bugs with this that I'll follow up on in T13682. I believe the security side of this is now resolved.

Oct 26 2022, 8:03 PM · Guides, Files, Security
epriestley added a comment to T13683: Security Guidance: References to Files in Remarkup .

The details of this attack will be disclosed at a later date, once installs have had some sort of plausible chance to upgrade.

Oct 26 2022, 8:01 PM · Guides, Files, Security
epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.

An earlier patch here (rCORE6d6170f76463) swapped binlogs to MIXED and set a 24-hour retention policy. This issue has not reoccurred in the cluster since that patch went out, but the root causes remain unresolved.

Oct 26 2022, 7:58 PM · Drydock
epriestley closed T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Resolved.

I filed T13687 as a followup for preventing this particular sort of error (where a Phobject is incorrectly serialized directly).

Oct 26 2022, 7:56 PM · EditEngine, Files
epriestley triaged T13687: Consider implementing "JsonSerializable" in Phobject to forbid serialization as Wishlist priority.
Oct 26 2022, 7:56 PM · Infrastructure
epriestley closed T13686: Disable Ubuntu unattended upgrades as Resolved.

I patched and partially deployed this in early August. Another unattended MySQL upgrade went out on Monday night, also didn't restart MySQL on affected hosts, and caused some downtime on hosts that didn't have the patch (to "disable unattended upgrades"). I've now deployed this everywhere, and am presuming this is fixed until evidence arises to the contrary.

Oct 26 2022, 7:53 PM · Phacility

Oct 25 2022

epriestley added a comment to T13686: Disable Ubuntu unattended upgrades.

See also PHI2219, PHI2220.

Oct 25 2022, 12:17 PM · Phacility

Aug 8 2022

epriestley added a comment to T13652: Notes on Ardunio CNC drivers.
FeatureDimension
Barrel6.8mm
Divot Size2.5mm H x 1.15mm W x 1.6mm D
Divot Distance7mm
Shaft~3mm
Aug 8 2022, 5:17 PM

Jul 29 2022

epriestley triaged T13686: Disable Ubuntu unattended upgrades as Normal priority.
Jul 29 2022, 12:16 PM · Phacility

Jul 8 2022

epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

That's very likely the same problem, and I think it should be fixed by updating to the current stable (rPf2a7db1 or newer).

Jul 8 2022, 3:57 AM · EditEngine, Files

Jun 14 2022

epriestley committed rPf2a7db1b1a1c: (stable) Flatten "RemarkupValue" objects when setting field defaults for custom… (authored by epriestley).
(stable) Flatten "RemarkupValue" objects when setting field defaults for custom…
Jun 14 2022, 5:12 PM
epriestley closed D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:37 PM
epriestley committed rP9426765a2c6a: Flatten "RemarkupValue" objects when setting field defaults for custom forms (authored by epriestley).
Flatten "RemarkupValue" objects when setting field defaults for custom forms
Jun 14 2022, 4:37 PM
epriestley requested review of D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:32 PM
epriestley added a revision to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization: D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:32 PM · EditEngine, Files
epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

...ideally this sort of thing should fail loudly at serialization time...

Jun 14 2022, 4:29 PM · EditEngine, Files
epriestley triaged T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Normal priority.
Jun 14 2022, 1:09 PM · EditEngine, Files

Jun 13 2022

epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.
  • The drydock_resource table could use a (status, ...) key to satisfy common/default queries.
Jun 13 2022, 1:16 PM · Drydock

Jun 7 2022

epriestley triaged T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable as Normal priority.
Jun 7 2022, 3:04 AM · Drydock

Jun 3 2022

epriestley committed rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented… (authored by epriestley).
(stable) Fix repository URI generation for SVN commit identifiers represented…
Jun 3 2022, 10:16 PM
epriestley closed D21852: Fix repository URI generation for SVN commit identifiers represented with integer types.
Jun 3 2022, 10:01 PM
epriestley committed rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with… (authored by epriestley).
Fix repository URI generation for SVN commit identifiers represented with…
Jun 3 2022, 10:01 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21852: Fix repository URI generation for SVN commit identifiers represented with integer types.
Jun 3 2022, 10:00 PM · Infrastructure
epriestley requested review of D21852: Fix repository URI generation for SVN commit identifiers represented with integer types.
Jun 3 2022, 10:00 PM

May 31 2022

epriestley closed D21851: Fix a policy issue where permissions were not properly checked when disabling global builtin queries.
May 31 2022, 6:00 PM
epriestley committed rP944b257d5df3: Fix a policy issue where permissions were not properly checked when disabling… (authored by epriestley).
Fix a policy issue where permissions were not properly checked when disabling…
May 31 2022, 6:00 PM
epriestley requested review of D21851: Fix a policy issue where permissions were not properly checked when disabling global builtin queries.
May 31 2022, 5:59 PM
epriestley closed D21850: Remove obsolete, policy-violating "owners.query" API method.
May 31 2022, 5:44 PM
epriestley committed rP3052ed14849c: Remove obsolete, policy-violating "owners.query" API method (authored by epriestley).
Remove obsolete, policy-violating "owners.query" API method
May 31 2022, 5:44 PM
epriestley requested review of D21850: Remove obsolete, policy-violating "owners.query" API method.
May 31 2022, 5:43 PM

May 28 2022

epriestley committed rP95481b5e3c49: (stable) Improve remarkup metadata robustness against debris in the database (authored by epriestley).
(stable) Improve remarkup metadata robustness against debris in the database
May 28 2022, 1:30 PM
epriestley closed D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM
epriestley committed rP835cd7f2706f: Improve remarkup metadata robustness against debris in the database (authored by epriestley).
Improve remarkup metadata robustness against debris in the database
May 28 2022, 1:29 PM
epriestley requested review of D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM · Remarkup

May 27 2022

epriestley edited the content of Changelog.
May 27 2022, 6:33 PM
epriestley created an object: 2022 Week 21 (Late May).
May 27 2022, 6:14 PM
epriestley triaged T13683: Security Guidance: References to Files in Remarkup as Normal priority.
May 27 2022, 6:13 PM · Guides, Files, Security
epriestley committed rPd075f3e93c02: (stable) Promote 2022 Week 21 (authored by epriestley).
(stable) Promote 2022 Week 21
May 27 2022, 6:13 PM
epriestley committed rARCb6babd9a07f4: (stable) Promote 2022 Week 21 (authored by epriestley).
(stable) Promote 2022 Week 21
May 27 2022, 6:13 PM
epriestley closed D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:15 PM
epriestley committed rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley).
Update Slowvote poll status to use sensible string constants
May 27 2022, 5:15 PM
epriestley committed rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object (authored by epriestley).
Separate Slowvote poll status onto a dedicated object
May 27 2022, 5:15 PM
epriestley closed D21847: Separate Slowvote poll status onto a dedicated object.
May 27 2022, 5:15 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:14 PM · Remarkup
epriestley requested review of D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:14 PM

May 26 2022

epriestley requested review of D21847: Separate Slowvote poll status onto a dedicated object.
May 26 2022, 5:46 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21847: Separate Slowvote poll status onto a dedicated object.
May 26 2022, 5:46 PM · Remarkup
epriestley closed D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:27 PM
epriestley committed rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants (authored by epriestley).
Update Slowvote voting methods to use sensible string constants
May 26 2022, 5:27 PM
epriestley requested review of D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:24 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:24 PM · Remarkup
epriestley closed D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:17 PM
epriestley committed rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley).
Move Slowvote vote types to a separate object
May 26 2022, 5:17 PM
epriestley updated the diff for D21845: Move Slowvote vote types to a separate object.
  • Update some file/class names.
May 26 2022, 5:09 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:09 PM · Remarkup
epriestley requested review of D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:09 PM
epriestley committed rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley).
Update Slowvote to use sensible string constants for response visibility
May 26 2022, 4:59 PM
epriestley closed D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM
epriestley closed D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:58 PM
epriestley committed rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley).
Move Slowvote response visibility to a separate object
May 26 2022, 4:58 PM
epriestley requested review of D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:40 PM · Remarkup
epriestley requested review of D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:40 PM
epriestley committed rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage (authored by epriestley).
Migrate "SlowvotePoll" to modern mailkey storage
May 26 2022, 4:29 PM
epriestley closed D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 4:29 PM
epriestley closed D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 4:29 PM
epriestley committed rPd91727e66ceb: Update nonstandard PHID key on "SlowvotePoll" (authored by epriestley).
Update nonstandard PHID key on "SlowvotePoll"
May 26 2022, 4:29 PM
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.

May 26 2022, 12:13 AM · Mail
epriestley requested review of D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM · Remarkup
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM · Mail
epriestley requested review of D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 12:00 AM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 12:00 AM · Remarkup

May 25 2022

epriestley closed D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:56 PM
epriestley committed rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support… (authored by epriestley).
Update "Files" attachment table to show more attachment details and support…
May 25 2022, 7:56 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:53 PM · Remarkup
epriestley requested review of D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:53 PM
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".

"PhabricatorApplicationTransactionCommentView->setDraft()" has exactly two callers: one in Slowvote...

May 25 2022, 5:33 PM · Remarkup
epriestley closed D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:25 PM
epriestley committed rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley).
Pass "object" to modular transaction methods explicitly
May 25 2022, 5:25 PM
epriestley requested review of D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:18 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:18 PM · Remarkup

May 24 2022

epriestley closed D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".
May 24 2022, 5:19 PM
epriestley committed rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" (authored by epriestley).
Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
May 24 2022, 5:19 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".
May 24 2022, 5:08 PM · Remarkup