epriestley (Evan Priestley)Administrator
Overengineer

Projects (76)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (332 w, 5 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Fri, Jun 23

epriestley committed rP314723d309cb: (stable) Rebuild Celerity map on stable. (authored by epriestley).
(stable) Rebuild Celerity map on stable.
Fri, Jun 23, 11:55 PM
epriestley edited the content of Changelog.
Fri, Jun 23, 11:55 PM
epriestley created 2017 Week 25 (Late June).
Fri, Jun 23, 11:54 PM
epriestley committed rPHU30065f1c5a39: (stable) Promote 2017 Week 25 (authored by epriestley).
(stable) Promote 2017 Week 25
Fri, Jun 23, 11:48 PM
epriestley committed rP0934ef6abc35: (stable) Promote 2017 Week 25 (authored by epriestley).
(stable) Promote 2017 Week 25
Fri, Jun 23, 11:48 PM
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

That sounds like a bug, but my guess is that the investigation would probably turn up "wow you are dumb at writing software" in about 3 minutes and not really get us much closer to a fix, which is probably "rewrite arc patch to fix 200 problems".

Fri, Jun 23, 11:40 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it's currently expected, yes. We don't create branches for dependencies in Git either, currently. I don't think this is terribly unreasonable, but I'm also not sure it's terribly useful (does it just help you keep track of which commits are part of the leaf?) and it makes cleanup more difficult by creating more total branch/bookmark artifacts in the local working copy.

Fri, Jun 23, 11:39 PM · Arcanist, Mercurial, Feature Request
epriestley committed rPa19859053300: Degrade more gracefully when ProfileMenu dashboards fail to render (authored by epriestley).
Degrade more gracefully when ProfileMenu dashboards fail to render
Fri, Jun 23, 7:31 PM
epriestley added a commit to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out: rPa19859053300: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:31 PM · Customer Impact, Policy, Profile Menu Item, Dashboards, Bug Report
epriestley closed D18152: Degrade more gracefully when ProfileMenu dashboards fail to render by committing rPa19859053300: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:31 PM
epriestley committed rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched… (authored by epriestley).
Let PhabricatorSearchCheckboxesField survive saved query data with mismatched…
Fri, Jun 23, 7:29 PM
epriestley closed T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Resolved by committing rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched….
Fri, Jun 23, 7:29 PM · Feed, Bug Report
epriestley closed D18132: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types by committing rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched….
Fri, Jun 23, 7:29 PM
epriestley added inline comments to D18152: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:28 PM
epriestley triaged T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Normal priority.
Fri, Jun 23, 7:16 PM · Customer Impact, Policy, Profile Menu Item, Dashboards, Bug Report
epriestley added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

D18152 should improve this: we'll still select the item as the default item, but will now render the navigation normally so the user can click other items:

Fri, Jun 23, 7:15 PM · Customer Impact, Policy, Profile Menu Item, Dashboards, Bug Report
epriestley created D18152: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:11 PM
epriestley added a revision to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out: D18152: Degrade more gracefully when ProfileMenu dashboards fail to render.
Fri, Jun 23, 7:11 PM · Customer Impact, Policy, Profile Menu Item, Dashboards, Bug Report
epriestley claimed T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Fri, Jun 23, 6:59 PM · Customer Impact, Policy, Profile Menu Item, Dashboards, Bug Report
epriestley renamed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities from Prioritys are wrong to Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Fri, Jun 23, 6:20 PM · Maniphest, Bug Report
epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

Specifically, the issue is that multiple different priorities used the same keywords ("low", "high").

Fri, Jun 23, 6:19 PM · Maniphest, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

(That is, our behavior seems clearly incorrect.)

Fri, Jun 23, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

This just looks unambiguously wrong to me.

Fri, Jun 23, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12845: Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default.

I'm going to modularize this, but not before the release cut.

Fri, Jun 23, 4:48 PM · Bug Report
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

Some of the (3), (2), (1) stuff is that we're trying to pick a single behavior which addresses most use cases reasonably well. For example, if we use "natural" bookmark names that will tend to make things much worse for users in bucket (3).

Fri, Jun 23, 4:48 PM · Arcanist, Mercurial, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Thanks, that's much more clear than the original description!

Fri, Jun 23, 4:42 PM · Remarkup, Feature Request
epriestley committed rPHU0a4487d37cd7: Don't warn about use of "Throwable" under PHP5 (authored by epriestley).
Don't warn about use of "Throwable" under PHP5
Fri, Jun 23, 4:30 PM
epriestley added a commit to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: rPHU0a4487d37cd7: Don't warn about use of "Throwable" under PHP5.
Fri, Jun 23, 4:30 PM · Infrastructure
epriestley closed D18151: Don't warn about use of "Throwable" under PHP5 by committing rPHU0a4487d37cd7: Don't warn about use of "Throwable" under PHP5.
Fri, Jun 23, 4:30 PM
epriestley triaged T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Low priority.

(I think D18132 should fix this once someone gets a chance to look at it.)

Fri, Jun 23, 4:22 PM · Feed, Bug Report
epriestley created D18151: Don't warn about use of "Throwable" under PHP5.
Fri, Jun 23, 4:21 PM
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: D18151: Don't warn about use of "Throwable" under PHP5.
Fri, Jun 23, 4:21 PM · Infrastructure
epriestley triaged T12866: Batch repository editing or repository groups for shared access control settings as Low priority.
Fri, Jun 23, 4:18 PM · Diffusion, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Fri, Jun 23, 4:18 PM · Remarkup, Feature Request
epriestley added a project to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Infrastructure.
Fri, Jun 23, 3:54 PM · Infrastructure
epriestley added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

This should now be fixed in HEAD of master, and promote to stable within about 12 hours. Thanks for the report! Let us know if you run into anything else.

Fri, Jun 23, 3:43 PM · Remarkup, Bug Report
epriestley committed rP988a52cf1acd: Fix ambiguous URI parsing in Youtube Remarkup rule (authored by epriestley).
Fix ambiguous URI parsing in Youtube Remarkup rule
Fri, Jun 23, 3:43 PM
epriestley closed D18149: Fix ambiguous URI parsing in Youtube Remarkup rule by committing rP988a52cf1acd: Fix ambiguous URI parsing in Youtube Remarkup rule.
Fri, Jun 23, 3:43 PM
epriestley closed T12867: Youtube remarkup rule fails to parse "ambiguous URI" as Resolved by committing rP988a52cf1acd: Fix ambiguous URI parsing in Youtube Remarkup rule.
Fri, Jun 23, 3:43 PM · Remarkup, Bug Report
epriestley committed rP219ae8b6c950: Remove old "Landing Strategy" code (authored by epriestley).
Remove old "Landing Strategy" code
Fri, Jun 23, 3:14 PM
epriestley closed T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential as Resolved by committing rP219ae8b6c950: Remove old "Landing Strategy" code.
Fri, Jun 23, 3:14 PM · Drydock, Differential
epriestley closed D18150: Remove old "Landing Strategy" code by committing rP219ae8b6c950: Remove old "Landing Strategy" code.
Fri, Jun 23, 3:13 PM
epriestley added a revision to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: D18150: Remove old "Landing Strategy" code.
Fri, Jun 23, 3:10 PM · Drydock, Differential
epriestley created D18150: Remove old "Landing Strategy" code.
Fri, Jun 23, 3:10 PM
epriestley added a revision to T12867: Youtube remarkup rule fails to parse "ambiguous URI": D18149: Fix ambiguous URI parsing in Youtube Remarkup rule.
Fri, Jun 23, 2:37 PM · Remarkup, Bug Report
epriestley created D18149: Fix ambiguous URI parsing in Youtube Remarkup rule.
Fri, Jun 23, 2:37 PM
epriestley renamed T12867: Youtube remarkup rule fails to parse "ambiguous URI" from Daemon fails to parse "ambiguous URI" to Youtube remarkup rule fails to parse "ambiguous URI".
Fri, Jun 23, 2:30 PM · Remarkup, Bug Report
epriestley added projects to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Differential, Drydock.
Fri, Jun 23, 2:24 PM · Drydock, Differential
epriestley added a project to T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: Customer Impact.

A related issue surfaced recently. Actual use case (forensically reconstructed):

Fri, Jun 23, 2:22 PM · Customer Impact, Maniphest, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

Oh, this is actually the Mercurial flavor of this action. We have this one in the Git flavor, which is why I was surprised:

Fri, Jun 23, 2:02 PM · Drydock, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

My expectation is that this action can never appear -- this is the pre-Drydock hacky temporary action -- so something troubling is afoot.

Fri, Jun 23, 2:01 PM · Drydock, Differential
epriestley created T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.
Fri, Jun 23, 1:59 PM · Drydock, Differential
epriestley added a comment to T12866: Batch repository editing or repository groups for shared access control settings.

See also T10005 (bulk editors for all applications) and T6722.

Fri, Jun 23, 1:38 PM · Diffusion, Feature Request
epriestley claimed T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I think a minimal reproduction case which is typical of this example is:

Fri, Jun 23, 1:35 PM · Remarkup, Bug Report

Thu, Jun 22

epriestley accepted D18148: Add a top level tab navigation option to PHUITwoColumnView.

That Throwable thing is fallout from T12855.

Thu, Jun 22, 7:29 PM
epriestley closed T12859: Some means of updating builtin images without a manual purge as Resolved.

Ah, alright. Yeah, behavior is:

Thu, Jun 22, 6:24 PM · Design & Planning
epriestley reopened T12859: Some means of updating builtin images without a manual purge as "Open".
Thu, Jun 22, 6:20 PM · Design & Planning
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Oh, maybe I misunderstood. I thought you wanted an easier way to test changes in a development environment, but it sounds like you actually want end users to immediately get the new images instead of needing to wait 7 days for them?

Thu, Jun 22, 6:20 PM · Design & Planning
epriestley committed rP224c4692ee0e: Add a cache purger for builtin files (authored by epriestley).
Add a cache purger for builtin files
Thu, Jun 22, 6:14 PM
epriestley committed rPbd3f441098a0: Modularize "bin/cache" purgers (authored by epriestley).
Modularize "bin/cache" purgers
Thu, Jun 22, 6:14 PM
epriestley closed T12859: Some means of updating builtin images without a manual purge as Resolved by committing rP224c4692ee0e: Add a cache purger for builtin files.
Thu, Jun 22, 6:14 PM · Design & Planning
epriestley added a commit to T12859: Some means of updating builtin images without a manual purge: rPbd3f441098a0: Modularize "bin/cache" purgers.
Thu, Jun 22, 6:14 PM · Design & Planning
epriestley closed D18147: Add a cache purger for builtin files by committing rP224c4692ee0e: Add a cache purger for builtin files.
Thu, Jun 22, 6:14 PM
epriestley closed D18146: Modularize "bin/cache" purgers by committing rPbd3f441098a0: Modularize "bin/cache" purgers.
Thu, Jun 22, 6:14 PM
epriestley committed rP519bec3e6f36: Make searching by tags work in Phriction (authored by epriestley).
Make searching by tags work in Phriction
Thu, Jun 22, 6:01 PM
epriestley closed T12860: Search by tag does not work in Phriction as Resolved by committing rP519bec3e6f36: Make searching by tags work in Phriction.
Thu, Jun 22, 6:01 PM · Phriction, Bug Report
epriestley closed D18145: Make searching by tags work in Phriction by committing rP519bec3e6f36: Make searching by tags work in Phriction.
Thu, Jun 22, 6:01 PM
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

A slightly more aggressive fix would be to make these have a 5 second TTL in development or something (or hash the file modification time into the builtin key? But that's a bit tricky...) so you'd never have to purge the cache, but I think this arises rarely enough that it isn't too valuable.

Thu, Jun 22, 5:58 PM · Design & Planning
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Strictly speaking, you still have to do a "manual purge" (with bin/cache ...) after D18146, but I assume you just didn't want to have to fish around in the DB.

Thu, Jun 22, 5:57 PM · Design & Planning
epriestley added a revision to T12859: Some means of updating builtin images without a manual purge: D18147: Add a cache purger for builtin files.
Thu, Jun 22, 5:56 PM · Design & Planning
epriestley created D18147: Add a cache purger for builtin files.
Thu, Jun 22, 5:56 PM
epriestley added a revision to T12859: Some means of updating builtin images without a manual purge: D18146: Modularize "bin/cache" purgers.
Thu, Jun 22, 5:44 PM · Design & Planning
epriestley created D18146: Modularize "bin/cache" purgers.
Thu, Jun 22, 5:44 PM
epriestley added a comment to D18145: Make searching by tags work in Phriction.

I think this has never worked. This line came from D14652, but I don't think it worked before that either.

Thu, Jun 22, 5:26 PM
epriestley created D18145: Make searching by tags work in Phriction.
Thu, Jun 22, 5:26 PM
epriestley added a revision to T12860: Search by tag does not work in Phriction: D18145: Make searching by tags work in Phriction.
Thu, Jun 22, 5:26 PM · Phriction, Bug Report
epriestley accepted D18144: Fix AA in repository images.
Thu, Jun 22, 5:11 PM
epriestley added a comment to D18144: Fix AA in repository images.

so smooth :3

Thu, Jun 22, 5:11 PM

Wed, Jun 21

epriestley added a comment to D18143: New icons for repositories.

It's good the world of art has people like us to make sure icons directly represent real objects in a 1:1 way.

Wed, Jun 21, 9:33 PM
epriestley accepted D18143: New icons for repositories.

I have reviewed these icons for literally representing true objects in a factual way.

Wed, Jun 21, 8:55 PM
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.
$engine = new PhabricatorDestructionEngine();
$engine->destroyObject($file);
Wed, Jun 21, 8:13 PM · Design & Planning
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Also not sure how to "retire" ones from Projects I don't intend to replace (low value).

Wed, Jun 21, 6:57 PM · Design & Planning
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

If you want to move forward with that:

Wed, Jun 21, 6:35 PM · Diffusion, Ops, Daemons, Phacility
epriestley added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Great! Please mail support at support@phacility.com and identify which instance you're paying us for, then we're happy to help you. We won't help you here, since this isn't the right way for customers to get support.

Wed, Jun 21, 6:27 PM · Phacility, Feature Request
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

Every repo host is equally affected, so I'd like to deploy crontabs as part of the regular deployment process if we use them as part of the approach here. That would require first codifying a handful of custom crontabs, including one on secure which regenerates documentation daily on only one host. This codification should happen anyway eventually, but it's a little bit of work, and wasted effort if we're switching to Chef/Salt/Ansible/etc soon anyway.

Wed, Jun 21, 5:57 PM · Diffusion, Ops, Daemons, Phacility
epriestley merged T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Wed, Jun 21, 5:23 PM · Restricted Project, Diffusion, Feature Request
epriestley merged task T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Wed, Jun 21, 5:23 PM · Diffusion, Feature Request
epriestley closed T12861: How to intergrate Infer's analysis result into Phabricator? as Invalid.

If you're a Phacility customer, please mail support at support@phacility.com (and identify your instance).

Wed, Jun 21, 5:22 PM · Phacility, Feature Request
epriestley added a comment to T12835: ArcanistDiffParser fails to parse filenames.

Why is git diff --no-index being used instead of and diff, and why is --no-prefix being used?

Wed, Jun 21, 4:59 PM · Arcanist, Bug Report
tomekj2ee awarded T7924: Unprototype Calendar (v1) a Love token.
Wed, Jun 21, 4:14 PM · Restricted Project, Prioritized, Calendar
epriestley closed T12858: test as Invalid.
Wed, Jun 21, 10:56 AM
epriestley committed rP149e6aaa2170: Let "<select />" EditEngine fields canonicalize saved defaults (authored by epriestley).
Let "<select />" EditEngine fields canonicalize saved defaults
Wed, Jun 21, 12:42 AM
epriestley closed D18142: Let "<select />" EditEngine fields canonicalize saved defaults by committing rP149e6aaa2170: Let "<select />" EditEngine fields canonicalize saved defaults.
Wed, Jun 21, 12:42 AM
epriestley added a commit to T12124: Counterintuitive priority setting via maniphest.edit conduit call: rP149e6aaa2170: Let "<select />" EditEngine fields canonicalize saved defaults.
Wed, Jun 21, 12:42 AM · Maniphest, Conduit, Bug Report

Tue, Jun 20

epriestley created D18142: Let "<select />" EditEngine fields canonicalize saved defaults.
Tue, Jun 20, 10:27 PM
epriestley added a revision to T12124: Counterintuitive priority setting via maniphest.edit conduit call: D18142: Let "<select />" EditEngine fields canonicalize saved defaults.
Tue, Jun 20, 10:27 PM · Maniphest, Conduit, Bug Report
20after4 awarded T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes a Baby Tequila token.
Tue, Jun 20, 8:12 PM · Infrastructure
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

Here's another clue, from the relevant host's error log:

Tue, Jun 20, 1:02 PM · Diffusion, Ops, Daemons, Phacility
epriestley committed rP17fc447503af: Don't compute MIME type of noninitial chunks from `diffusion.filecontentquery` (authored by epriestley).
Don't compute MIME type of noninitial chunks from `diffusion.filecontentquery`
Tue, Jun 20, 12:45 PM
epriestley added a commit to T12857: Temporary directory fullness can cause daemon issues?: rP17fc447503af: Don't compute MIME type of noninitial chunks from `diffusion.filecontentquery`.
Tue, Jun 20, 12:45 PM · Diffusion, Ops, Daemons, Phacility