Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (571 w, 2 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Tue, Jan 11

vhbit awarded D21743: Fix a PHP 8.1 issue in lint rendering a Party Time token.
Tue, Jan 11, 4:34 PM

Dec 19 2021

epriestley closed T11230: Phacility: Private Clusters as Wontfix.

See T12847. All the technical parts of this are now solved except for billing, but since Phacility is winding down I no longer plan to pursue it.

Dec 19 2021, 8:45 PM · Phacility
epriestley closed T8688: Attach and initialize backup volumes during `remote deploy` workflow as Resolved.

I resolved this in rCORE320b2854.

Dec 19 2021, 8:43 PM · Phacility
epriestley closed T12847: A Pathway Towards Private Clusters as Wontfix.

After T13630:

Dec 19 2021, 8:39 PM · Plans, Ops, Phacility
epriestley closed T12847: A Pathway Towards Private Clusters, a subtask of T11230: Phacility: Private Clusters, as Wontfix.
Dec 19 2021, 8:39 PM · Phacility
epriestley closed T13601: Support "SCA" / "3D Secure 2" in billing workflows as Wontfix.

Only one instance was impacted by this and I just credited them until 2099. I don't currently expect to pursue this.

Dec 19 2021, 8:26 PM · Phacility, Phortune
epriestley closed T13610: Support per-node billing for hosted Phacility instances as Wontfix.

I no longer expect to pursue this.

Dec 19 2021, 8:25 PM · Phortune, Phacility
epriestley closed T13618: When a Phacility "rbak" device does not exist, backups can run twice and converge to a "successful" but inconsistent state as Wontfix.
  • Hosts in the repo class are now build by Piledriver (see T13630), which automatically creates the rbak device entries, so this error isn't likely to occur again.
  • I also don't expect to launch any more hosts.
Dec 19 2021, 8:25 PM · Phacility
epriestley closed T13654: Wind Down Phacility Operations as Resolved.

I compacted secure onto new hardware (T13671) and shut down saux001 ("Land Revision") and sbuild001 (Harbormaster remote builds). I think all the remaining work is covered under T13630 (largely, just a handful of large database migrations remain).

Dec 19 2021, 8:23 PM · Phacility
epriestley closed T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware as Resolved.

I just swapped configs over without merging the LBs, since it wasn't immediately obvious to me what the Application vs Classic state of the world is and swapping was good enough.

Dec 19 2021, 7:35 PM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

The aphlict/notify stuff still needs to be tweaked. I think the snlb + slb setup can be merged into a single slb with "TCP (Secure)" forwarding now.

Dec 19 2021, 4:19 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

Databases are moved and secure is out of read-only mode. I'm going to adjust repository configuration, then I should be able to tear down secure001.

Dec 19 2021, 4:11 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I'm going to put secure back into read-only mode now and move the databases to the new host.

Dec 19 2021, 12:08 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I brought up the new host and pointed the slb001 load balancer at it. The database is still on the old host, and the new host doesn't have repositories yet, but the basics seem to be working.

Dec 19 2021, 12:07 AM · Phacility

Dec 18 2021

epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

Merging 003 into 001 worked fine with a few expected tricks (e.g., when secure is in read-only mode, you can't push a change to take it out of read-only mode, since pushing is a write). Next up is launching a modern m4.large secure-pool host and then migrating the data.

Dec 18 2021, 7:57 PM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I'm putting secure into read-only mode now, with the intent of completing steps 1-5 above.

Dec 18 2021, 7:13 PM · Phacility
epriestley committed rPdec95228a241: Add a "--database <name> ..." flag to "bin/storage dump" (authored by epriestley).
Add a "--database <name> ..." flag to "bin/storage dump"
Dec 18 2021, 7:11 PM
epriestley closed D21745: Add a "--database <name> ..." flag to "bin/storage dump".
Dec 18 2021, 7:11 PM
epriestley updated the diff for D21745: Add a "--database <name> ..." flag to "bin/storage dump".
  • Fix missing variable initialization.
Dec 18 2021, 7:09 PM
epriestley requested review of D21745: Add a "--database <name> ..." flag to "bin/storage dump".
Dec 18 2021, 7:07 PM
epriestley added a revision to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware: D21745: Add a "--database <name> ..." flag to "bin/storage dump".
Dec 18 2021, 7:06 PM · Phacility

Dec 17 2021

epriestley triaged T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware as Low priority.
Dec 17 2021, 7:32 PM · Phacility

Dec 16 2021

epriestley committed rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration (authored by epriestley).
Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
Dec 16 2021, 11:24 PM
epriestley closed D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
Dec 16 2021, 11:24 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix another random PHP 8.1 issue.
Dec 16 2021, 11:21 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a PHP 8.1 issue in application search code.
Dec 16 2021, 11:17 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a PHP 8.1 check in local disk storage engine code.
Dec 16 2021, 11:15 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a PHP 8.1 issue in user querying.
Dec 16 2021, 11:15 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a piece of user initializing code for PHP 8.1.
Dec 16 2021, 11:13 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Correct behavior in query clause construction.
Dec 16 2021, 11:11 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a strlen() in query construction.
Dec 16 2021, 11:09 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Add annotations for interfaces implemented by PhabricatorHandleList.
Dec 16 2021, 11:08 PM
epriestley requested review of D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
Dec 16 2021, 11:08 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
Dec 16 2021, 11:07 PM · Infrastructure
epriestley added a comment to T13588: PHP 8 Compatibility.

PHP 8.1 changed semantics of static variables in methods. See:

Dec 16 2021, 10:42 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

See also T13588. Using static::class to work around changes to the scope of static in PHP 8.1 is also possible now that PHP 5.5 is the minimum version, and some uses of get_class($this) might be replaceable. There's no strong motivator for this, it's just a little cleaner.

Dec 16 2021, 10:40 PM · Infrastructure
epriestley added a comment to T13637: PHP Static Method Variable Scope.

See also T13588.

Dec 16 2021, 10:37 PM · Lint, Guides
epriestley lowered the priority of T13655: Provide a formal "destroyed" status for Phacility instances from Normal to Wishlist.

It would still be nice to have this from a completeness/correctness perspective, but other changes have made it less valuable:

Dec 16 2021, 2:58 PM · Phacility

Dec 14 2021

epriestley added a comment to T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way.

...possibly, but not conclusively, a result of an SSH version upgrade...

Dec 14 2021, 8:02 PM · Passphrase, Diffusion
epriestley triaged T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way as Wishlist priority.
Dec 14 2021, 5:58 PM · Passphrase, Diffusion

Dec 11 2021

epriestley requested review of D21743: Fix a PHP 8.1 issue in lint rendering.
Dec 11 2021, 7:18 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21743: Fix a PHP 8.1 issue in lint rendering.
Dec 11 2021, 7:17 PM · Infrastructure
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I put all the database migration stuff everywhere and it appears stable. I'm hooking up Postmark as an outbound pathway now. If I get that working, I'll let it sit for a while and start migrating databases.

Dec 11 2021, 5:43 PM · Almanac, Infrastructure, Phacility
epriestley edited the content of Changelog.
Dec 11 2021, 3:48 PM
epriestley committed rARC3f08a11b10a3: (stable) Promote 2021 Week 50 (authored by epriestley).
(stable) Promote 2021 Week 50
Dec 11 2021, 3:48 PM
epriestley committed rP5c5b7daaeba3: (stable) Promote 2021 Week 50 (authored by epriestley).
(stable) Promote 2021 Week 50
Dec 11 2021, 3:48 PM
epriestley created an object: 2021 Week 50 (Mid December).
Dec 11 2021, 3:47 PM

Dec 10 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Finally, there are other some MySQL version issues which can be avoided with:

Dec 10 2021, 6:22 PM · Almanac, Infrastructure, Phacility
epriestley closed D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:42 AM
epriestley committed rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes (authored by epriestley).
Provide additional Arcanist PHP 8.1 fixes
Dec 10 2021, 12:42 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
  • Also fix service profiler test case.
Dec 10 2021, 12:41 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
  • Fix unit tests and a handful of other errors.
Dec 10 2021, 12:38 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:37 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:36 AM
epriestley requested review of D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:21 AM
epriestley added a revision to T13588: PHP 8 Compatibility: D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:21 AM · Infrastructure

Dec 9 2021

epriestley closed D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 11:59 PM
epriestley committed rARC488f13a60e88: Add a lint rule forbidding use of "each()" (authored by epriestley).
Add a lint rule forbidding use of "each()"
Dec 9 2021, 11:59 PM
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The new core/ support for the API is partially deployed; the new services/ support isn't anywhere yet.

Dec 9 2021, 11:13 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to D21741: Add a lint rule forbidding use of "each()".

Ah, yep, should be 7.2 -- thanks!

Dec 9 2021, 10:10 PM
epriestley updated the summary of D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 10:10 PM
epriestley requested review of D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 9:55 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 9:55 PM · Infrastructure
epriestley closed D21740: Correct some Arcanist behaviors under PHP8.1.
Dec 9 2021, 9:44 PM
epriestley committed rARC3626582354e4: Correct some Arcanist behaviors under PHP8.1 (authored by epriestley).
Correct some Arcanist behaviors under PHP8.1
Dec 9 2021, 9:44 PM
epriestley requested review of D21740: Correct some Arcanist behaviors under PHP8.1.
Dec 9 2021, 8:46 PM
epriestley added a comment to T13588: PHP 8 Compatibility.

See also T13232. Here's a possible build strategy for PHP 8.1 under macOS Mojave. Anyone reasonable should probably give up and use brew instead.

Dec 9 2021, 8:46 PM · Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: D21740: Correct some Arcanist behaviors under PHP8.1.
Dec 9 2021, 8:46 PM · Infrastructure

Dec 8 2021

epriestley edited the content of Migrating Repository Shards.
Dec 8 2021, 9:39 PM · Phacility

Dec 4 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The latest version of Phabricator itself is everywhere.

Dec 4 2021, 11:46 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I'm going to hold it until the weekend and try deploying then if things look calm on my end.

Dec 4 2021, 9:23 PM · Almanac, Infrastructure, Phacility

Dec 2 2021

epriestley committed rPdc705cea7fec: Document Mailgun as discouraged, and update Postmark remote address blocks (authored by epriestley).
Document Mailgun as discouraged, and update Postmark remote address blocks
Dec 2 2021, 10:56 PM
epriestley closed D21738: Document Mailgun as discouraged, and update Postmark remote address blocks.
Dec 2 2021, 10:56 PM
epriestley closed D21739: Update the extracted cURL SSL CA bundle.
Dec 2 2021, 10:56 PM
epriestley committed rARC13d3a3c3b100: Update the extracted cURL SSL CA bundle (authored by epriestley).
Update the extracted cURL SSL CA bundle
Dec 2 2021, 10:56 PM
epriestley requested review of D21739: Update the extracted cURL SSL CA bundle.
Dec 2 2021, 10:56 PM
epriestley requested review of D21738: Document Mailgun as discouraged, and update Postmark remote address blocks.
Dec 2 2021, 10:50 PM
epriestley added a revision to T13669: Discourage use of Mailgun as a mail provider: D21738: Document Mailgun as discouraged, and update Postmark remote address blocks.
Dec 2 2021, 10:48 PM · Guides, Mail
epriestley updated the task description for T13669: Discourage use of Mailgun as a mail provider.
Dec 2 2021, 10:42 PM · Guides, Mail
epriestley updated the task description for T13669: Discourage use of Mailgun as a mail provider.
Dec 2 2021, 10:39 PM · Guides, Mail
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

I'm satisfied that we aren't violating our commitment to our customers by continuing to use Mailgun as a service provider...

Dec 2 2021, 10:39 PM · Phacility, Security, Mail
epriestley created U49 Mailgun Discouraged.
Dec 2 2021, 10:34 PM
epriestley added a comment to T13669: Discourage use of Mailgun as a mail provider.

Purely venting, but the advanced version of "click here to schedule a mysterious meeting" is to outright lie -- pretending that you deeply respect the recipient's achievements -- before asking them to schedule a mysterious meeting.

Dec 2 2021, 10:30 PM · Guides, Mail
epriestley triaged T13669: Discourage use of Mailgun as a mail provider as Normal priority.
Dec 2 2021, 10:12 PM · Guides, Mail

Dec 1 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

While waiting to deploy db stuff, I was planning to look at pruning dead data out of S3 -- but, on closer examination, the total S3 bill is something like $1/day, so no priority on that whatsoever.

Dec 1 2021, 11:57 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver also needs to be able to provision database hosts, but these are more-or-less a trivial subset of repository hosts.

Dec 1 2021, 11:47 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.
  • Make InstancesStateQuery use a dictionary when building the database ref information internally.
Dec 1 2021, 11:06 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 11:03 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 10:44 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 9:34 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Restricted Differential Revision.
Dec 1 2021, 9:25 PM · Almanac, Infrastructure, Phacility
epriestley edited the content of Changelog.
Dec 1 2021, 9:23 PM
epriestley committed rARC59b273fd15d3: (stable) Promote 2021 Week 49 (authored by epriestley).
(stable) Promote 2021 Week 49
Dec 1 2021, 9:22 PM
epriestley committed rPd96bd22b8d59: (stable) Promote 2021 Week 49 (authored by epriestley).
(stable) Promote 2021 Week 49
Dec 1 2021, 9:21 PM
epriestley created an object: 2021 Week 49 (Early December).
Dec 1 2021, 9:21 PM
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver also needs to be able to provision database hosts, but these are more-or-less a trivial subset of repository hosts.

Dec 1 2021, 8:44 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I completed all the repository migrations over the weekend and seemingly haven't run into any issues.

Dec 1 2021, 8:41 PM · Almanac, Infrastructure, Phacility

Nov 22 2021

epriestley closed T13653: After an AWS event, Phacility hosts may come up with swap only partially configured as Resolved.

This appears resolved: the workflow now tests that /proc/meminfo reports an appropriate value for TotalSwap.

Nov 22 2021, 2:02 PM · Phacility
epriestley committed rARCc23222438b30: (stable) Provide an API for parsing swap information from "/proc/meminfo" (authored by epriestley).
(stable) Provide an API for parsing swap information from "/proc/meminfo"
Nov 22 2021, 1:45 PM
epriestley closed D21733: Provide an API for parsing swap information from "/proc/meminfo".
Nov 22 2021, 1:45 PM