Psyduck is the greatest pokemon of all time.
- User Since
- Feb 8 2011, 1:28 AM (423 w, 3 d)
After D20305, this can be "fixed" with this change:
Presumably soon-to-be obsoleted by changes on T5474.
We may still pursue this, especially after T4900, but a lot of the use cases / needs are mostly theoretical and it's not clear they're actually necessary. Some of the actual solutions (like T10335) may largely provide enough clarity about these cases on their own. I'm currently planning to wait for feedback about recent and near-future changes (including triggers) and then fix whatever issues arise surgically -- possibly through animation, but possibly through other UI/UX remedies.
Those changes haven't landed yet but I'm just going to tidy this up a little early, see T13074 for followups.
Please report issues you encounter with Phabricator via Discourse, not by commenting here.
Wed, Mar 20
Tue, Mar 19
This seems to have quieted down, now.
Probably a bad idea but maybe I'll revisit this at some point.
- Also skip these columns in "WHERE" on the second page and beyond.
- Add a small explanatory comment pointing here.
Also, what is "By Relevance" ?
- Remove the created/modified properties from the raw result row (this is just housekeeping, I don't believe it affects anything).
- Move the _ft_magic strings to class constants (more housekeeping).
Mon, Mar 18
I also checked for more leftovers in instances/, but it looks like we don't have any non-default paging there.
I've poked around a fair bit locally, although I'm not totally confident I got every combination of paging columns and queries. I think anything that was missed is very likely to produce an explicit error rather than mysterious behavior, so I'm not too worried about it. Stuff to keep an eye on:
- Farewell, Herlad.
🎺 HERE COMES HERLAD 🎺
Sat, Mar 16
On trigger names, I'm currently imagining that we're likely to end up with a "quick" workflow where you just pick some rules for a column and we don't make you name the trigger, and a "slow and thoughtful" workflow where you take time to set things up and name the triggers. Not sure that'll stick or exactly what it'll look like.