Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (519 w, 6 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Sat, Jan 23

epriestley triaged T13592: Initial discovery in large repositories may take an unreasonably long amount of time as Low priority.
Sat, Jan 23, 5:46 PM · Diffusion
epriestley edited the content of Changelog.
Sat, Jan 23, 4:35 AM
epriestley edited the content of Changelog.
Sat, Jan 23, 4:35 AM
epriestley edited the content of Changelog.
Sat, Jan 23, 4:35 AM
epriestley created an object: 2021 Week 4 (Late January).
Sat, Jan 23, 4:30 AM
epriestley committed rARC66d1acec7042: (stable) Promote 2021 Week 4 (authored by epriestley).
(stable) Promote 2021 Week 4
Sat, Jan 23, 4:20 AM
epriestley committed rP498fcd34ac9f: (stable) Promote 2021 Week 4 (authored by epriestley).
(stable) Promote 2021 Week 4
Sat, Jan 23, 4:20 AM
epriestley committed rP1da94dcf499e: Correct some issues around IMPORTED_PERMANENT in RefEngine (authored by epriestley).
Correct some issues around IMPORTED_PERMANENT in RefEngine
Sat, Jan 23, 3:52 AM
epriestley closed D21518: Correct some issues around IMPORTED_PERMANENT in RefEngine.
Sat, Jan 23, 3:52 AM
epriestley committed rP15e022d64870: Support an "--active" flag for selecting active tasks (authored by epriestley).
Support an "--active" flag for selecting active tasks
Sat, Jan 23, 3:51 AM
epriestley committed rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair" (authored by epriestley).
Correct the behavior of "bin/repository discover --repair"
Sat, Jan 23, 3:51 AM
epriestley closed D21516: Lift logic for queueing commit import tasks into RepositoryEngine.
Sat, Jan 23, 3:51 AM
epriestley committed rP3cb543ef8fc6: Lift logic for queueing commit import tasks into RepositoryEngine (authored by epriestley).
Lift logic for queueing commit import tasks into RepositoryEngine
Sat, Jan 23, 3:51 AM
epriestley committed rP2d0e7c37e1f5: Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of… (authored by epriestley).
Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of…
Sat, Jan 23, 3:51 AM
epriestley closed D21517: Support an "--active" flag for selecting active tasks.
Sat, Jan 23, 3:51 AM
epriestley committed rP6716d4f6ae17: Separate "shouldPublishRef()" from "isPermanentRef()" and set… (authored by epriestley).
Separate "shouldPublishRef()" from "isPermanentRef()" and set…
Sat, Jan 23, 3:51 AM
epriestley closed D21515: Separate "shouldPublishRef()" from "isPermanentRef()" and set "IMPORTED_PERMANENT" more narrowly.
Sat, Jan 23, 3:51 AM
epriestley closed D21514: Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag.
Sat, Jan 23, 3:51 AM
epriestley closed D21513: Correct the behavior of "bin/repository discover --repair".
Sat, Jan 23, 3:51 AM
epriestley added a comment to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".

After D21518:

Sat, Jan 23, 3:51 AM · Daemons, Diffusion
epriestley requested review of D21518: Correct some issues around IMPORTED_PERMANENT in RefEngine.
Sat, Jan 23, 12:39 AM
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21518: Correct some issues around IMPORTED_PERMANENT in RefEngine.
Sat, Jan 23, 12:38 AM · Daemons, Diffusion
epriestley requested review of D21517: Support an "--active" flag for selecting active tasks.
Sat, Jan 23, 12:12 AM
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21517: Support an "--active" flag for selecting active tasks.
Sat, Jan 23, 12:10 AM · Daemons, Diffusion

Fri, Jan 22

epriestley added a comment to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".

These parts seem likely resolved once I convince myself the patches so far actually work:

Fri, Jan 22, 11:57 PM · Daemons, Diffusion
epriestley added a comment to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".

I have a change to add containerPHID locally, but it ends up having relatively high complexity because several other patches (including 20190909.herald.01.rebuild.php) call PhabricatorRebuildIndexesWorker::rebuildObjectsWithQuery(...), which does not work if executed in sequence prior to a worker queue schema change.

Fri, Jan 22, 11:47 PM · Daemons, Diffusion
epriestley requested review of D21516: Lift logic for queueing commit import tasks into RepositoryEngine.
Fri, Jan 22, 10:52 PM
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21516: Lift logic for queueing commit import tasks into RepositoryEngine.
Fri, Jan 22, 10:50 PM · Daemons, Diffusion
epriestley requested review of D21515: Separate "shouldPublishRef()" from "isPermanentRef()" and set "IMPORTED_PERMANENT" more narrowly.
Fri, Jan 22, 10:10 PM
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21515: Separate "shouldPublishRef()" from "isPermanentRef()" and set "IMPORTED_PERMANENT" more narrowly.
Fri, Jan 22, 10:09 PM · Daemons, Diffusion
epriestley updated the task description for T13178: Plans: Support Pact Competitive Update.
Fri, Jan 22, 10:00 PM · Plans, Support, Phacility
epriestley requested review of D21514: Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag.
Fri, Jan 22, 9:43 PM
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21514: Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag.
Fri, Jan 22, 9:41 PM · Daemons, Diffusion
epriestley added a comment to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".

This also relates slightly to T13580, but I believe the two issues are addressable independently.

Fri, Jan 22, 9:24 PM · Daemons, Diffusion
epriestley added a comment to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".

However, I'd like to have a better understanding of how we're reaching this state, and I'm not satisfied that these repositories are going down the "natural" pathway (of changing ref definitions after the import starts) and suspect there is some more complicated interaction at play here.

Fri, Jan 22, 9:18 PM · Daemons, Diffusion
epriestley requested review of D21513: Correct the behavior of "bin/repository discover --repair".
Fri, Jan 22, 8:26 PM
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21513: Correct the behavior of "bin/repository discover --repair".
Fri, Jan 22, 8:25 PM · Daemons, Diffusion
epriestley added a comment to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".

I'm hoping to land at least a narrow fix for this today to support an import in PHI1979 tomorrow. However, I'd like to have a better understanding of how we're reaching this state, and I'm not satisfied that these repositories are going down the "natural" pathway (of changing ref definitions after the import starts) and suspect there is some more complicated interaction at play here.

Fri, Jan 22, 8:23 PM · Daemons, Diffusion
epriestley updated the task description for T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".
Fri, Jan 22, 6:47 PM · Daemons, Diffusion
epriestley updated the task description for T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".
Fri, Jan 22, 6:45 PM · Daemons, Diffusion
epriestley added a project to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": Daemons.
Fri, Jan 22, 6:05 PM · Daemons, Diffusion
epriestley triaged T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT" as Normal priority.
Fri, Jan 22, 6:05 PM · Daemons, Diffusion

Thu, Jan 21

epriestley triaged T13590: Large HTTP repository pushes may leave clustered repository write lock held as Normal priority.
Thu, Jan 21, 6:49 PM · Diffusion

Wed, Jan 20

epriestley closed D21512: Correct a straggling CLI format string after ref selector changes.
Wed, Jan 20, 11:05 PM
epriestley committed rPe7e8ef7e390a: Correct a straggling CLI format string after ref selector changes (authored by epriestley).
Correct a straggling CLI format string after ref selector changes
Wed, Jan 20, 11:04 PM
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21512: Correct a straggling CLI format string after ref selector changes.
Wed, Jan 20, 11:04 PM · Security, Git
epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

See PHI1977 for a somewhat-similar issue: a user was (probably) looking for an action available only in Global Herald rules, and didn't realize available actions depend on rule scope.

Wed, Jan 20, 8:45 PM · Diffusion, Herald
epriestley updated the task description for T11860: Bot email addresses can't be edited.
Wed, Jan 20, 8:25 PM · Setup, People
epriestley committed rP0e28105ff76b: Further correct and disambigutate ref selectors passed to Git on the CLI (authored by epriestley).
Further correct and disambigutate ref selectors passed to Git on the CLI
Wed, Jan 20, 8:07 PM
epriestley closed D21511: Further correct and disambigutate ref selectors passed to Git on the CLI.
Wed, Jan 20, 8:07 PM
epriestley updated the diff for D21511: Further correct and disambigutate ref selectors passed to Git on the CLI.
  • Test for "svn" before running an SVN test to fix the local test failure, since this new machine doesn't have "svn" installed yet.
Wed, Jan 20, 8:04 PM
epriestley requested review of D21511: Further correct and disambigutate ref selectors passed to Git on the CLI.
Wed, Jan 20, 7:45 PM
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21511: Further correct and disambigutate ref selectors passed to Git on the CLI.
Wed, Jan 20, 7:44 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Wed, Jan 20, 6:47 PM · Security, Git

Tue, Jan 19

epriestley added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Please use Discourse to report bugs. See https://discourse.phabricator-community.org/t/repository-view-git-command-failed-error/4510/.

Tue, Jan 19, 3:34 PM · Security, Git

Fri, Jan 15

epriestley added a comment to T3277: `arc cleanup` to cleanup branches used by `arc patch`.

grep -v master | grep -v '^[0-9a-f.]*$'

Fri, Jan 15, 7:50 PM · Arcanist
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Fri, Jan 15, 6:45 PM · Security, Git
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Fri, Jan 15, 6:44 PM · Security, Git
epriestley removed a project from T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Security.
Fri, Jan 15, 6:44 PM · Security, Git

Wed, Jan 13

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 9:38 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 9:01 PM · Accessibility, Differential
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Wed, Jan 13, 8:39 PM · Harbormaster
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 8:33 PM · Accessibility, Differential
epriestley committed rPea9cb0b625fb: Disambiguate Git ref selectors in some Git command line invocations (authored by epriestley).
Disambiguate Git ref selectors in some Git command line invocations
Wed, Jan 13, 8:31 PM
epriestley closed D21510: Disambiguate Git ref selectors in some Git command line invocations.
Wed, Jan 13, 8:31 PM
epriestley closed D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Wed, Jan 13, 8:31 PM
epriestley committed rARCb2e715fc5a9c: Provide "gitsprintf(...)" and disambiguate Git ref selectors (authored by epriestley).
Provide "gitsprintf(...)" and disambiguate Git ref selectors
Wed, Jan 13, 8:31 PM

Tue, Jan 12

epriestley updated the diff for D21510: Disambiguate Git ref selectors in some Git command line invocations.
  • Include fix for a "blame" callsite.
Tue, Jan 12, 8:43 PM
epriestley requested review of D21510: Disambiguate Git ref selectors in some Git command line invocations.
Tue, Jan 12, 8:13 PM
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21510: Disambiguate Git ref selectors in some Git command line invocations.
Tue, Jan 12, 8:11 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Tue, Jan 12, 8:10 PM · Security, Git
epriestley requested review of D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Tue, Jan 12, 8:10 PM
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Tue, Jan 12, 8:09 PM · Security, Git
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I'm not completely thrilled about maintaining PHP builtin webserver support...

Tue, Jan 12, 7:11 PM · Infrastructure
epriestley triaged T13589: Git may interpret refnames as flags in some commands which accept both refs and paths as Normal priority.
Tue, Jan 12, 6:26 PM · Security, Git
epriestley committed rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes (authored by epriestley).
Support "control" and "return/enter" in the remarkup rule for keystrokes
Tue, Jan 12, 3:47 AM
epriestley closed D21508: Support "control" and "return/enter" in the remarkup rule for keystrokes.
Tue, Jan 12, 3:47 AM
epriestley requested review of D21508: Support "control" and "return/enter" in the remarkup rule for keystrokes.
Tue, Jan 12, 3:44 AM

Mon, Jan 11

epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I added M1, etc., to the ignored list in D21507.

Mon, Jan 11, 8:16 PM · Infrastructure
epriestley closed T13575: PHP built-in webserver fails on POST as Resolved.

I think this is now resolved. I'm not completely thrilled about maintaining PHP builtin webserver support because I think use is very limited, but since I'm currently using it I expect to support it at least until I summon the nerve to deal with Homebrew.

Mon, Jan 11, 8:14 PM · Infrastructure
epriestley added a task to D20903: Ensure __path__ is set on POST requests when running on CLI webserver: T13575: PHP built-in webserver fails on POST.
Mon, Jan 11, 6:59 PM
epriestley added a revision to T13575: PHP built-in webserver fails on POST: D20903: Ensure __path__ is set on POST requests when running on CLI webserver.
Mon, Jan 11, 6:59 PM · Infrastructure
epriestley abandoned D20903: Ensure __path__ is set on POST requests when running on CLI webserver.

See T13575. This change should be obsoleted by D21506.

Mon, Jan 11, 6:58 PM
epriestley commandeered D20903: Ensure __path__ is set on POST requests when running on CLI webserver.
Mon, Jan 11, 6:55 PM
epriestley updated the summary of D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:55 PM
epriestley committed rP18f049a282f4: Fix reading of the request path when running the PHP builtin webserver (authored by epriestley).
Fix reading of the request path when running the PHP builtin webserver
Mon, Jan 11, 6:54 PM
epriestley closed D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:54 PM
epriestley committed rP04c1f67a020c: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list (authored by epriestley).
Add "M<digit>" and "P<digit>" to the default Remarkup ignore list
Mon, Jan 11, 6:54 PM
epriestley closed D21507: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.
Mon, Jan 11, 6:54 PM
epriestley requested review of D21507: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.
Mon, Jan 11, 6:52 PM
epriestley added a revision to T13575: PHP built-in webserver fails on POST: D21507: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.
Mon, Jan 11, 6:51 PM · Infrastructure
epriestley requested review of D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:36 PM
epriestley added a revision to T13575: PHP built-in webserver fails on POST: D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:34 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

Guess I should probably add M1 to the remarkup blocklist now.

Mon, Jan 11, 5:52 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I switched to an M1 Mac Mini on Big Sur, which has motivated me somewhat to try to get this working since I suspect doing another install through Homebrew on M1 silicon will be more adventure than I have stomach for.

Mon, Jan 11, 5:45 PM · Infrastructure
epriestley claimed T13575: PHP built-in webserver fails on POST.
Mon, Jan 11, 5:43 PM · Infrastructure
epriestley accepted D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.
Mon, Jan 11, 4:48 AM
epriestley accepted rARC90ac9a2ff281: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

See D21500 for discussion, the test failure was an interaction between callbacks specified in C::m form and $callback() inside xsprintf() under old versions of PHP. Resolved by D21505.

Mon, Jan 11, 4:41 AM
epriestley accepted D21505: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500.
Mon, Jan 11, 4:40 AM
epriestley added a comment to T13588: PHP 8 Compatibility.

So I don't forget:

Mon, Jan 11, 4:33 AM · Infrastructure