Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (466 w, 5 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Fri, Jan 17

epriestley renamed T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones from Fix various policy issues issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones to Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.
Fri, Jan 17, 5:19 PM · Policy, Projects
epriestley triaged T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Wishlist priority.
Fri, Jan 17, 5:05 PM · Projects, Owners, Herald
epriestley added a comment to T13395: Strip libphutil for parts.

See also https://discourse.phabricator-community.org/t/storage-upgrade-failed-class-phutilauthadapter-not-defined/3468.

Fri, Jan 17, 4:55 PM · libphutil

Thu, Jan 16

epriestley committed rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0 (authored by epriestley).
Update "git rev-parse" invocation to work in Git 2.25.0
Thu, Jan 16, 7:39 PM
epriestley closed D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:39 PM
epriestley closed T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Resolved by committing rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:39 PM · Diffusion
epriestley requested review of D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:38 PM
epriestley added a revision to T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0: D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Thu, Jan 16, 7:37 PM · Diffusion
epriestley triaged T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Low priority.
Thu, Jan 16, 7:18 PM · Diffusion
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

See T13478 for followup.

Thu, Jan 16, 6:50 PM · Restricted Project, Projects, Bug Report
epriestley triaged T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones as Low priority.
Thu, Jan 16, 6:49 PM · Policy, Projects
epriestley reopened T10779: Cannot manage base project milestones if base project has subprojects as "Open".

I'm also still able to reproduce this specific variant of things, so it looks like I was too optimistic about T13462 covering this in at least some cases.

Thu, Jan 16, 4:50 PM · Restricted Project, Projects, Bug Report

Wed, Jan 15

epriestley committed rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other… (authored by epriestley).
Fix two issues with missing whitespace when elements stack on top of each other…
Wed, Jan 15, 4:53 PM
epriestley closed D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Wed, Jan 15, 4:53 PM
epriestley closed T13476: Correct vertical spacing issues when some components wrap across a line break as Resolved by committing rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other….
Wed, Jan 15, 4:53 PM · Design
epriestley requested review of D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Wed, Jan 15, 4:49 PM
epriestley added a revision to T13476: Correct vertical spacing issues when some components wrap across a line break: D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Wed, Jan 15, 4:48 PM · Design
epriestley added a comment to T13476: Correct vertical spacing issues when some components wrap across a line break.

A similar issue occurs when the "Visible To" control wraps with spaces enabled. To reproduce this...

Wed, Jan 15, 4:46 PM · Design
epriestley added a comment to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.

This should be fixed by D20943. Note that "Mute" in this context mutes notifications about edits to the object (e.g. "Alice renamed rule Hxxx from X to Y."), not notifications sent by the rule itself.

Wed, Jan 15, 4:31 PM · Herald
epriestley committed rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions (authored by epriestley).
Allow the Herald Rule Editor to apply generic "Edge" transactions
Wed, Jan 15, 4:29 PM
epriestley closed D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:29 PM
epriestley closed T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Resolved by committing rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:29 PM · Herald
epriestley requested review of D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:29 PM
epriestley added a revision to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`: D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Wed, Jan 15, 4:27 PM · Herald
epriestley triaged T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Wishlist priority.
Wed, Jan 15, 4:23 PM · Herald
epriestley closed T13477: (2020 Week 3) Restart AWS host db025 (i-05bc80634586ef7a0) as Resolved.

This went through cleanly.

Wed, Jan 15, 4:19 PM · Ops, Phacility
epriestley closed T13453: Update Asana Auth Adapter for "gid" API changes as Resolved.

These changes seem to have stuck.

Wed, Jan 15, 2:40 AM · Asana, Auth
epriestley triaged T13477: (2020 Week 3) Restart AWS host db025 (i-05bc80634586ef7a0) as Low priority.
Wed, Jan 15, 2:36 AM · Ops, Phacility
epriestley triaged T13476: Correct vertical spacing issues when some components wrap across a line break as Low priority.
Wed, Jan 15, 2:34 AM · Design
epriestley triaged T13475: Fix incorrect MFA badge on some stories when MFA is not configured at all as Low priority.
Wed, Jan 15, 2:28 AM · Auth

Tue, Jan 14

epriestley committed rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning (authored by epriestley).
Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning
Tue, Jan 14, 8:23 PM
epriestley closed D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:23 PM
epriestley closed T13471: Guard call to "get_magic_quotes_gpc()" during startup as Resolved by committing rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:23 PM · Infrastructure
epriestley requested review of D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:22 PM
epriestley added a revision to T13471: Guard call to "get_magic_quotes_gpc()" during startup: D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Tue, Jan 14, 8:21 PM · Infrastructure
epriestley committed rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer (authored by epriestley).
Update deprecated array access syntax in Porter stemmer
Tue, Jan 14, 8:11 PM
epriestley closed D20941: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:11 PM
epriestley closed T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Resolved by committing rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:11 PM · Search
epriestley requested review of D20941: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:11 PM
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20941: Update deprecated array access syntax in Porter stemmer.
Tue, Jan 14, 8:04 PM · Search
epriestley added a comment to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4.

I thought this was some kind of complicated mess with the regex on line 420, but it's actually an issue with this:

Tue, Jan 14, 8:03 PM · Search
epriestley committed rP767528c0ed55: Move search query parser/compiler classes to Phabricator (authored by epriestley).
Move search query parser/compiler classes to Phabricator
Tue, Jan 14, 7:50 PM
epriestley closed D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:49 PM
epriestley committed rPHUcc2a3dbf5903: Move search query compiler / stemmer classes out of libphutil (authored by epriestley).
Move search query compiler / stemmer classes out of libphutil
Tue, Jan 14, 7:49 PM
epriestley closed D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:49 PM
epriestley requested review of D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:49 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:48 PM · libphutil
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:48 PM · Search
epriestley updated the diff for D20939: Move search query parser/compiler classes to Phabricator.
  • Also move the Porter stemmer.
  • Ran some search queries.
Tue, Jan 14, 7:47 PM
epriestley requested review of D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:42 PM
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:41 PM · Search
epriestley added a revision to T13395: Strip libphutil for parts: D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:41 PM · libphutil
epriestley added a comment to T13474: Track mentions on an individual field-by-field basis.

(Since a full implementation here will imply that removing a custom field from configuration may "unmention" an arbitrarily large number of relationships, and we can't easily do that inline or at display time, the ultimately implementation would likely include a more robust version of this script.)

Tue, Jan 14, 7:21 PM · Infrastructure
epriestley added a comment to T13474: Track mentions on an individual field-by-field basis.

In PHI1602, I proposed a script to "reset" mentions on an object. The use case this serves is:

Tue, Jan 14, 7:13 PM · Infrastructure
epriestley triaged T13474: Track mentions on an individual field-by-field basis as Wishlist priority.
Tue, Jan 14, 6:32 PM · Infrastructure
epriestley triaged T13473: Provide full payload logging for inbound CircleCI build requests as Low priority.
Tue, Jan 14, 6:17 PM · Infrastructure
epriestley accepted D20938: breakout: migrate to python3.

If systems with no binary named python are reasonable to expect, and it sounds like they are, this is fine as-is. I've added you to Blessed Committers so you should be able to land this change yourself (check the project description for some guidance), or let me know if you run into issues. After this lands, I'll land a followup in arc anoid to test for a python3 and emit a friendlier error if it isn't present.

Tue, Jan 14, 4:35 PM
epriestley added a member for Blessed Committers: beber.
Tue, Jan 14, 4:35 PM

Mon, Jan 13

epriestley added a comment to T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/.

This page intentionally has a no-Javascript, no-drag-and-drop upload form for users who use obscure Linux window managers that don't support drag and drop.

Mon, Jan 13, 7:32 PM
epriestley merged task T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Mon, Jan 13, 7:26 PM
epriestley merged T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Mon, Jan 13, 7:26 PM · Files
epriestley requested changes to D20938: breakout: migrate to python3.

This is almost certainly fine, but I don't actually have this bleeding-edge far-future version of Python installed on my stock Macbook (macOS Mojave):

Mon, Jan 13, 6:29 PM
epriestley added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

If you believe you've found a bug in Phabricator, please report it by creating a new thread on Discourse.

Mon, Jan 13, 6:23 PM · Projects, Bug Report (Needs Information)
epriestley triaged T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Wishlist priority.
Mon, Jan 13, 4:49 PM · Search

Thu, Jan 9

brablc awarded T5427: Force a line break in a table cell a Like token.
Thu, Jan 9, 4:18 PM · Remarkup

Dec 19 2019

epriestley triaged T13471: Guard call to "get_magic_quotes_gpc()" during startup as Wishlist priority.
Dec 19 2019, 6:52 PM · Infrastructure
epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

See also PHI1594, which wants:

Dec 19 2019, 5:18 PM · Workboards (v3)
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

See also PHI1579.

Dec 19 2019, 5:11 PM

Dec 13 2019

epriestley edited the content of Changelog.
Dec 13 2019, 6:44 PM
epriestley created an object: 2019 Week 50 (Mid December).
Dec 13 2019, 6:43 PM
epriestley committed rPc4b4a53cad77: (stable) Promote 2019 Week 50 (authored by epriestley).
(stable) Promote 2019 Week 50
Dec 13 2019, 6:42 PM
epriestley committed rP54bcbdaba94a: Fix an XSS issue with certain high-priority remarkup rules embedded inside… (authored by epriestley).
Fix an XSS issue with certain high-priority remarkup rules embedded inside…
Dec 13 2019, 6:38 PM
epriestley closed D20937: Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules.
Dec 13 2019, 6:37 PM
epriestley requested review of D20937: Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules.
Dec 13 2019, 6:37 PM

Dec 9 2019

epriestley accepted D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 9 2019, 6:38 PM

Nov 30 2019

epriestley requested review of D20934: Give "Config" a full-width, hierarchical layout.
Nov 30 2019, 8:05 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20934: Give "Config" a full-width, hierarchical layout.
Nov 30 2019, 8:03 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 7:55 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 6:38 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:37 PM · Design, Config
epriestley updated the summary of D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:37 PM
epriestley requested review of D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:35 PM

Nov 26 2019

epriestley requested review of D20931: Carve out a separate "Services" section of Config.
Nov 26 2019, 11:32 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20931: Carve out a separate "Services" section of Config.
Nov 26 2019, 11:31 PM · Design, Config
epriestley requested review of D20930: Carve out a separate "Modules/Extensions" section of Config.
Nov 26 2019, 11:02 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20930: Carve out a separate "Modules/Extensions" section of Config.
Nov 26 2019, 11:01 PM · Design, Config
epriestley triaged T13467: Expand the "ddata003" volume as Low priority.
Nov 26 2019, 6:00 PM · Phacility
CodeMouse92 awarded T10779: Cannot manage base project milestones if base project has subprojects a Party Time token.
Nov 26 2019, 3:17 AM · Restricted Project, Projects, Bug Report
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

I believe T13462 resolved this.

Nov 26 2019, 1:52 AM · Restricted Project, Projects, Bug Report
epriestley committed rP33c534f9b74f: Extend Config to full-width (authored by epriestley).
Extend Config to full-width
Nov 26 2019, 12:18 AM
epriestley closed D20925: Extend Config to full-width.
Nov 26 2019, 12:18 AM
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

there is no way to bin/host query against the set of instances using a particular repository shard service

Nov 26 2019, 12:14 AM · Phacility, Ops
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 26 2019, 12:09 AM · Phacility, Ops

Nov 25 2019

epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 25 2019, 11:57 PM · Phacility, Ops
epriestley committed rP1667acfa5d71: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them… (authored by epriestley).
Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them…
Nov 25 2019, 11:08 PM
epriestley closed D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:08 PM
epriestley added a comment to T11860: Bot email addresses can't be edited.

In D20927, I implemented a policy rule like this:

Nov 25 2019, 11:08 PM · Setup, People
epriestley requested review of D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:07 PM
epriestley added a revision to T11860: Bot email addresses can't be edited: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:06 PM · Setup, People
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:06 PM · Diffusion