epriestley (Evan Priestley)Administrator
Overengineer

Projects (77)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (356 w, 6 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Today

epriestley requested review of D18823: Allow Herald rules to add comments.
Mon, Dec 11, 7:50 PM

Fri, Dec 8

epriestley accepted D18822: Add drydock.blueprint.edit Conduit method.

Looks great, thanks! I added you to Blessed Committers so you should be able to arc land this yourself -- check the project description for some instructions, or yell if you run into issues.

Fri, Dec 8, 4:45 PM
epriestley added a member for Blessed Committers: timhirsh.
Fri, Dec 8, 4:45 PM

Thu, Dec 7

epriestley requested changes to D18820: Reduce mirth in 403/404 pages.

I don't think the 403 is really too funny or flavorful, maybe just get rid of the joke? Elsewhere, a button that says "Rats!" is hilarious to me, but "Peace Out" doesn't capture the same spirit or really make sense in response to hitting a 403 (you wouldn't say "Peace Out" in an analogous physical situation. But I think the button should be labeled "Go Home" or "Done" or "Cancel", not "Back", because it is very unlikely to take you back (that is, I think we should only label a button "Back" if it logically takes you backwards in a workflow, and has roughly the same effect as the browser back button).

Thu, Dec 7, 2:04 PM

Tue, Dec 5

epriestley committed rP6d3baa92f908: Execute Herald again after promoting revisions out of the "Draft" state (authored by epriestley).
Execute Herald again after promoting revisions out of the "Draft" state
Tue, Dec 5, 8:14 PM
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP6d3baa92f908: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 8:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit, a subtask of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, as Resolved.
Tue, Dec 5, 8:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Resolved by committing rP6d3baa92f908: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 8:14 PM · Herald, Differential
epriestley closed D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 8:14 PM
epriestley committed rP861bb08141a9: (stable) Fix Mercurial commit history ordering (authored by epriestley).
(stable) Fix Mercurial commit history ordering
Tue, Dec 5, 8:13 PM
epriestley committed rP50d5fa87a3fc: (stable) Restore the "Log In" menubar action (authored by epriestley).
(stable) Restore the "Log In" menubar action
Tue, Dec 5, 8:13 PM
epriestley committed rP4f8340c05f2b: Restore the "Log In" menubar action (authored by epriestley).
Restore the "Log In" menubar action
Tue, Dec 5, 8:13 PM
epriestley closed D18818: Restore the "Log In" menubar action.
Tue, Dec 5, 8:13 PM
epriestley committed rPa989dd181dd1: Fix Mercurial commit history ordering (authored by epriestley).
Fix Mercurial commit history ordering
Tue, Dec 5, 8:12 PM
epriestley closed D18817: Fix Mercurial commit history ordering.
Tue, Dec 5, 8:12 PM
epriestley requested review of D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 3:58 PM
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 3:57 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit: D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 3:57 PM · Herald, Differential
epriestley accepted D18816: Fix error for URL's that could mean several commits.

You can bold it with phutil_tag('strong', array(), $commit_identifier) if you like. I think bolding it does make it read slightly more nicely.

Tue, Dec 5, 2:36 PM
epriestley awarded D18816: Fix error for URL's that could mean several commits a Dat Boi token.
Tue, Dec 5, 2:36 PM
epriestley requested review of D18818: Restore the "Log In" menubar action.
Tue, Dec 5, 1:48 PM
epriestley requested review of D18817: Fix Mercurial commit history ordering.
Tue, Dec 5, 1:39 PM

Sun, Dec 3

epriestley requested changes to D18816: Fix error for URL's that could mean several commits.

I think this breaks unambiguous commits (like /rP<full 40-character hash>), since $commit is now an array:

Sun, Dec 3, 8:36 PM
epriestley committed rP9fdeb2d8ac95: (stable) Mark sessions as "signed all documents" when Legalpad has been… (authored by epriestley).
(stable) Mark sessions as "signed all documents" when Legalpad has been…
Sun, Dec 3, 12:16 AM
epriestley committed rPc924351a58e4: Mark sessions as "signed all documents" when Legalpad has been uninstalled (authored by epriestley).
Mark sessions as "signed all documents" when Legalpad has been uninstalled
Sun, Dec 3, 12:16 AM

Sat, Dec 2

epriestley removed reviewers for D18815: Allow additional options in .arcunit files: epriestley, Blessed Reviewers.
Sat, Dec 2, 4:27 PM
epriestley added a comment to D18815: Allow additional options in .arcunit files.

Please use the Discourse forum to suggest enhancements: https://discourse.phabricator-community.org/

Sat, Dec 2, 4:27 PM

Fri, Dec 1

epriestley edited the content of Changelog.
Fri, Dec 1, 9:29 PM
epriestley committed rPHUf3386051a959: (stable) Promote 2017 Week 48 (authored by epriestley).
(stable) Promote 2017 Week 48
Fri, Dec 1, 9:29 PM
epriestley committed rARCa3519b8fdefc: (stable) Promote 2017 Week 48 (authored by epriestley).
(stable) Promote 2017 Week 48
Fri, Dec 1, 9:28 PM
epriestley committed rP9570b843ea6b: (stable) Promote 2017 Week 48 (authored by epriestley).
(stable) Promote 2017 Week 48
Fri, Dec 1, 9:28 PM
epriestley created 2017 Week 48 (Early December).
Fri, Dec 1, 9:28 PM
epriestley triaged T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Normal priority.
Fri, Dec 1, 7:32 PM · Herald, Differential
epriestley removed reviewers for D18814: Add a option to lint trailing whitespace only on non-empty lines: epriestley, Blessed Reviewers.
Fri, Dec 1, 2:15 PM
epriestley added a comment to D18814: Add a option to lint trailing whitespace only on non-empty lines.

Sorry, I'm not interested in bringing this change upstream.

Fri, Dec 1, 2:15 PM

Thu, Nov 30

epriestley added inline comments to D18806: Rebuild the bulk editor on SearchEngine.
Thu, Nov 30, 11:46 PM
epriestley updated the diff for D18805: Make bulk editor working set editable and more homogenous.
  • Spelling fix.
Thu, Nov 30, 11:18 PM
epriestley committed rP5240cffd9c20: Fix an issue where Diffusion could fatal if the default branch was deleted (authored by epriestley).
Fix an issue where Diffusion could fatal if the default branch was deleted
Thu, Nov 30, 10:06 PM
epriestley closed D18811: Fix an issue where Diffusion could fatal if the default branch was deleted.
Thu, Nov 30, 10:06 PM
epriestley committed rP14cc0abeb37f: Fix several safety issues with repository URIs (authored by epriestley).
Fix several safety issues with repository URIs
Thu, Nov 30, 10:06 PM
epriestley closed D18810: Fix several safety issues with repository URIs.
Thu, Nov 30, 10:06 PM
epriestley accepted D18813: Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens.

(This should maybe just Ref rather than Fixes on T13019 and leave it open for some theoretical day long from now when we circle back and fix this properly.)

Thu, Nov 30, 10:04 PM
epriestley added a comment to D18810: Fix several safety issues with repository URIs.

Yeah, I'm glossing for simplicity -- the actual behavior is that the commits remain on disk until Git garbage collects them. With normal/default config, I think that's 14 days ("gc.pruneExpire"?) but it could be "never" or something like "instantly" depending on config, I think. I'm also not totally sure that any server-side stuff triggers GC behavior. We also don't currently ever GC explicitly, although this might change. My understanding of the Git GC is generally a bit fuzzy.

Thu, Nov 30, 10:02 PM
epriestley added a comment to D18812: Don't require the "gd" extension be installed in order to run unit tests.

Ideally, yeah -- I merged everything I could remember/find into T10405 as a sort of umbrella for these. In this case, Lyuba was just hitting a narrow issue with getting arc diff to make it through the workflow.

Thu, Nov 30, 9:55 PM
epriestley added a comment to D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.

Looks like that worked.

Thu, Nov 30, 9:52 PM
epriestley committed rARCf4c80a114d36: Make "arc land" prompt on "Changes Planned" revisions more explicit (authored by epriestley).
Make "arc land" prompt on "Changes Planned" revisions more explicit
Thu, Nov 30, 9:52 PM
This revision was not accepted when it landed; it landed in state Changes Planned.
Thu, Nov 30, 9:51 PM
epriestley closed T10233: arc error message unclear for accepted revision in "plan change" state as Resolved by committing rARCf4c80a114d36: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Thu, Nov 30, 9:51 PM · Restricted Project, Bug Report
epriestley committed rPf786c86a6a42: Don't require the "gd" extension be installed in order to run unit tests (authored by epriestley).
Don't require the "gd" extension be installed in order to run unit tests
Thu, Nov 30, 9:51 PM
epriestley added a commit to T10405: Phabricator should generally work properly even if "gd" is not installed: rPf786c86a6a42: Don't require the "gd" extension be installed in order to run unit tests.
Thu, Nov 30, 9:51 PM · Setup, Restricted Project
epriestley closed D18812: Don't require the "gd" extension be installed in order to run unit tests.
Thu, Nov 30, 9:51 PM
epriestley requested review of D18812: Don't require the "gd" extension be installed in order to run unit tests.
Thu, Nov 30, 9:48 PM
epriestley added a revision to T10405: Phabricator should generally work properly even if "gd" is not installed: D18812: Don't require the "gd" extension be installed in order to run unit tests.
Thu, Nov 30, 9:47 PM · Setup, Restricted Project
epriestley renamed T10405: Phabricator should generally work properly even if "gd" is not installed from New Project flow assumes gd is installed to Phabricator should generally work properly even if "gd" is not installed.
Thu, Nov 30, 9:46 PM · Setup, Restricted Project
epriestley closed T12592: User awaiting approval has no image as Resolved.

This should be fixed by changes in T13024.

Thu, Nov 30, 9:43 PM · Bug Report, Auth
epriestley closed T12657: Add Authentication Factor fails silently for users without a verified email address as Resolved.

This should be fixed by changes in T13024.

Thu, Nov 30, 9:43 PM · Auth, Bug Report
epriestley merged T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Thu, Nov 30, 9:42 PM · Setup, Restricted Project
epriestley merged task T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Thu, Nov 30, 9:42 PM · Setup, Bug Report
epriestley requested review of D18811: Fix an issue where Diffusion could fatal if the default branch was deleted.
Thu, Nov 30, 8:36 PM
epriestley updated the diff for D18810: Fix several safety issues with repository URIs.
  • Use a more conventional spelling of "unrecoverably".
Thu, Nov 30, 8:20 PM
epriestley requested review of D18810: Fix several safety issues with repository URIs.
Thu, Nov 30, 8:18 PM
epriestley committed rPHU59642f236822: Mark `ParseError` as a PHP7 builtin class (authored by epriestley).
Mark `ParseError` as a PHP7 builtin class
Thu, Nov 30, 7:30 PM
epriestley closed D18809: Mark `ParseError` as a PHP7 builtin class.
Thu, Nov 30, 7:30 PM
epriestley added a commit to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: rPHU59642f236822: Mark `ParseError` as a PHP7 builtin class.
Thu, Nov 30, 7:30 PM · Infrastructure
epriestley updated the summary of D18809: Mark `ParseError` as a PHP7 builtin class.
Thu, Nov 30, 7:29 PM
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: D18809: Mark `ParseError` as a PHP7 builtin class.
Thu, Nov 30, 7:29 PM · Infrastructure
epriestley requested review of D18809: Mark `ParseError` as a PHP7 builtin class.
Thu, Nov 30, 7:28 PM
epriestley added a member for Community: dho.
Thu, Nov 30, 7:15 PM
epriestley added a commit to T11413: Support renaming Phacility instances: Unknown Object (Diffusion Commit).
Thu, Nov 30, 7:04 PM · Phacility
epriestley added a commit to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster: Unknown Object (Diffusion Commit).
Thu, Nov 30, 7:04 PM · Customer Impact, Remarkup, Feature Request
epriestley planned changes to D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.

I'm going to land this from the wrong state after deploying D18808 to double check that change.

Thu, Nov 30, 7:04 PM
epriestley committed rP0807b70ea167: Add an explicit warning in the Differential transaction log when users skip… (authored by epriestley).
Add an explicit warning in the Differential transaction log when users skip…
Thu, Nov 30, 7:04 PM
epriestley added a commit to T10233: arc error message unclear for accepted revision in "plan change" state: rP0807b70ea167: Add an explicit warning in the Differential transaction log when users skip….
Thu, Nov 30, 7:04 PM · Restricted Project, Bug Report
epriestley closed D18808: Add an explicit warning in the Differential transaction log when users skip review.
Thu, Nov 30, 7:04 PM
epriestley added inline comments to D18808: Add an explicit warning in the Differential transaction log when users skip review.
Thu, Nov 30, 4:28 PM
epriestley requested review of D18808: Add an explicit warning in the Differential transaction log when users skip review.
Thu, Nov 30, 4:27 PM
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: D18808: Add an explicit warning in the Differential transaction log when users skip review.
Thu, Nov 30, 4:26 PM · Restricted Project, Bug Report
epriestley updated the diff for D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.

Existing prompt seems fine too:

Thu, Nov 30, 4:00 PM
epriestley updated the diff for D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.
  • Fix newline escaping, increase drama.
Thu, Nov 30, 3:59 PM
epriestley planned changes to D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.

(Actually executing my test plan.)

Thu, Nov 30, 3:55 PM
epriestley requested review of D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Thu, Nov 30, 3:54 PM
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Thu, Nov 30, 3:53 PM · Restricted Project, Bug Report
epriestley requested review of D18806: Rebuild the bulk editor on SearchEngine.
Thu, Nov 30, 3:29 PM
epriestley requested review of D18805: Make bulk editor working set editable and more homogenous.
Thu, Nov 30, 3:28 PM
epriestley added a revision to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets: D18806: Rebuild the bulk editor on SearchEngine.
Thu, Nov 30, 3:28 PM · Customer Impact, Workboards, Maniphest
epriestley added a revision to T13025: Update bulk editor: D18806: Rebuild the bulk editor on SearchEngine.
Thu, Nov 30, 3:28 PM · Transactions, ApplicationEditor
epriestley renamed T13025: Update bulk editor from Update batch editor to Update bulk editor.
Thu, Nov 30, 3:23 PM · Transactions, ApplicationEditor
epriestley added a comment to D18760: Modernize QuickSearch typeahead.

I think it'll get to do the Jump nav stuff eventually (PhabricatorJumpNavHandler) but it's fine to just have the little skeleton for now.

Thu, Nov 30, 2:57 PM
epriestley awarded D18760: Modernize QuickSearch typeahead a Hungry Hippo token.
Thu, Nov 30, 2:56 PM
epriestley accepted D18760: Modernize QuickSearch typeahead.

Thanks!

Thu, Nov 30, 2:56 PM
epriestley added a revision to T10005: Implement an ApplicationEditor-based Bulk Editor: D18805: Make bulk editor working set editable and more homogenous.
Thu, Nov 30, 1:40 PM · ApplicationEditor
epriestley added a revision to T13025: Update bulk editor: D18805: Make bulk editor working set editable and more homogenous.
Thu, Nov 30, 1:40 PM · Transactions, ApplicationEditor
epriestley added a revision to T11286: make it possible to remove tasks from a batch edit tasks workflow: D18805: Make bulk editor working set editable and more homogenous.
Thu, Nov 30, 1:40 PM · Maniphest, Feature Request
epriestley added a revision to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster: Unknown Object (Differential Revision).
Thu, Nov 30, 12:34 PM · Customer Impact, Remarkup, Feature Request
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Thu, Nov 30, 12:34 PM · Phacility

Wed, Nov 29

epriestley added a comment to T9805: XHProf will not build on PHP7.

(I'm also open to improvements to the XHProf UI in Phabricator if you plan to use that to store and review profiles. Many obvious features like tagging and API access which would make it more usable for handling profiles of projects other than Phabricator itself are likely very easy to implement. But I'm not sure there's tons of room for real integrations, even if you used everything else in Phabricator, and you may imagine tooling which can't realistically exist in the scope of Phabricator.)

Wed, Nov 29, 9:05 PM · XHProf
epriestley added a comment to T9805: XHProf will not build on PHP7.

For general context:

Wed, Nov 29, 8:58 PM · XHProf
epriestley added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

In PHI231, a more experienced user went through this workflow:

Wed, Nov 29, 7:24 PM · Restricted Project, Bug Report

Tue, Nov 28

epriestley committed rP1b76250f8995: Disallow "Accept" on drafts, allow "Resign" (authored by epriestley).
Disallow "Accept" on drafts, allow "Resign"
Tue, Nov 28, 9:46 PM
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP1b76250f8995: Disallow "Accept" on drafts, allow "Resign".
Tue, Nov 28, 9:46 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential