Psyduck is the greatest pokemon of all time.
User Details
User Details
- User Since
- Feb 8 2011, 1:28 AM (478 w, 1 d)
- Roles
- Administrator
- Availability
- Available
Yesterday
Yesterday
epriestley committed rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;" (authored by epriestley).
Fix improper XHPAST parsing of namespace grammar like "use x as private;"
epriestley committed rARCe03431def8c0: Fix XHPAST parsing of variadic calls (authored by epriestley).
Fix XHPAST parsing of variadic calls
epriestley committed rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format (authored by epriestley).
Update XHPAST "expect" test blocks to the new stable, human-readable format
epriestley committed rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable (authored by epriestley).
Make XHPAST unit test "expect" blocks stable and human-readable
epriestley committed rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code (authored by epriestley).
Remove duplication of XHPAST version in PHP and C code
epriestley committed rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3 (authored by epriestley).
Revert xhpast changes that impacted builds under Bison 2.3
Superseded by D21066.
Much of this is supported now; T13492 has some general followup.
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.
epriestley requested review of D21065: Make XHPAST unit test "expect" blocks stable and human-readable.
Test failures are expected.
epriestley requested review of D21067: Fix XHPAST parsing of variadic calls.
epriestley added a comment to D17819: Make PHPAST parser tests stable and human-readable.
(This was ultimately superseded by D21065.)
epriestley requested review of D21064: Remove duplication of XHPAST version in PHP and C code.
epriestley renamed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) from XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) to XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
epriestley requested review of D21063: Revert xhpast changes that impacted builds under Bison 2.3.
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.
This is entangled with T9753.
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.
XHPAST currently can not parse $x = yield $y;. I suspect this was added to the PHP grammar after XHPAST diverged. I'm hopeful the fix is straightforward.
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to Windows on the XHPAST board.
epriestley moved T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings from Backlog to Windows on the XHPAST board.
epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Future on the XHPAST board.
No current plans to pursue this.
epriestley moved T10971: php lint: catch `"${var}"` vs `"{$var}"` from Backlog to String Variables on the XHPAST board.
epriestley moved T8049: Improve parsing of variables embedded in strings in XHPAST from Backlog to String Variables on the XHPAST board.
epriestley triaged T9286: XHPAST fails to recognize inline HTML starting with "<?php" as Wishlist priority.
epriestley moved T9286: XHPAST fails to recognize inline HTML starting with "<?php" from Backlog to Future on the XHPAST board.
epriestley renamed T8325: XHPASTLinter does not scope parameters to closures correctly from Treat functions with parameters defined in other functions in XHPASTLinter correctly to XHPASTLinter does not scope parameters to closures correctly.
epriestley moved T8325: XHPASTLinter does not scope parameters to closures correctly from Backlog to Future on the XHPAST board.
No plans to pursue this.
No longer clear what this accomplishes.
I don't currently plan to pursue this.
This is very old and we have no outstanding customer requests for ARM support.
Mon, Apr 6
Mon, Apr 6
epriestley closed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given" as Resolved.
I deployed D21062, and the three examples in the original report look good now. I checked about a dozen other pages and couldn't find anything else broken; let me know if I missed anything. Thanks for the report!
epriestley committed rP58fbf64a2786: Refine handling of "@task" attributes in Diviner (authored by epriestley).
Refine handling of "@task" attributes in Diviner
epriestley requested review of D21062: Refine handling of "@task" attributes in Diviner.
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
The second issue is that the API still returns a string when there is exactly one @attribute of a given type. This is a bit goofy; PhutilExecChannel is another example case.
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
I deployed D21061. First two example pages are good now, third one is hitting a different error. New trace is:
epriestley committed rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API (authored by epriestley).
Update DivinerAtomController for a long-ago change to the docblock parser API
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Docblocks may have multiple copies of the same @attribute directive, like this:
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Here's the full stack trace:
epriestley committed rARC33dc2fe8194d: Allow "phage" to print execution status on SIGINT (authored by epriestley).
Allow "phage" to print execution status on SIGINT
epriestley requested review of D21060: Allow "phage" to print execution status on SIGINT.
One long-standing warning in a unit test cropped up (D21055) but if this does have far-reaching implications, they don't seem terribly obvious/common.
epriestley closed T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as Resolved.
Character encoding issues aren't stable yet (see also T13500) but I think everything else here is.
Sun, Apr 5
Sun, Apr 5
epriestley committed rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley).
(stable) Whitelist "vscode://" as an allowed Editor protocol
epriestley committed rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline… (authored by epriestley).
(stable) Add an "isDone" flag to "transaction.search" for Differential inline…
epriestley committed rPf1d1ec3d77f1: Add an "isDone" flag to "transaction.search" for Differential inline comments (authored by epriestley).
Add an "isDone" flag to "transaction.search" for Differential inline comments
Move Phage to FuturePool
epriestley requested review of D21058: Move Phage to FuturePool.
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:50 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
Fri, Apr 3
Fri, Apr 3
epriestley committed rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother… (authored by epriestley).
(stable) If daemon running-as-user setup check fails its query, don't bother…
epriestley committed rP33b73d887ae3: If daemon running-as-user setup check fails its query, don't bother with it (authored by epriestley).
If daemon running-as-user setup check fails its query, don't bother with it
epriestley committed rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref… (authored by epriestley).
Improve performance when marking commits as unreachable after multiple ref…
epriestley committed rP1e7cc72cd835: Improve performance when marking commits as unreachable after multiple ref… (authored by epriestley).
Improve performance when marking commits as unreachable after multiple ref…
epriestley committed rP1a59cae743c2: Update some Phabricator behaviors for changes to Futures (authored by epriestley).
Update some Phabricator behaviors for changes to Futures
epriestley requested review of D21054: Update some Phabricator behaviors for changes to Futures.
epriestley committed rP067b04aaf148: If HTTP response headers are already sent, don't fiddle with "zlib. (authored by epriestley).
If HTTP response headers are already sent, don't fiddle with "zlib.
epriestley committed rARC099c2ae64845: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures (authored by epriestley).
Introduce "FuturePool" to make it easier to manage an ongoing pool of futures
epriestley added a comment to T11968: Decide the fate of FutureGraph.
XHPAST currently can't build an AST for $result = yield ..., even though this is a valid construct. This is probably a straightforward fix.
epriestley removed 1 auditor(s) for rARC4d55067fd87f: Make the "result" property on Future private: epriestley.
Thu, Apr 2
Thu, Apr 2
epriestley added a comment to T13500: During startup, guarantee "(string)1.23" is "1.23", not "1,23".
See also T13209.
epriestley committed rARC368aec16a1ee: Update some ancient "set X=Y" environment code for new Windows execution… (authored by epriestley).
Update some ancient "set X=Y" environment code for new Windows execution…