Page MenuHomePhabricator

epriestley (Evan Priestley)
OverengineerAdministrator

Projects (73)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 8 2011, 1:28 AM (669 w, 1 d)
Roles
Administrator
Availability
Available

Psyduck is the greatest pokemon of all time.

Recent Activity

Thu, Nov 16

epriestley renamed T13694: Create a "BRK/First Alert" smoke detector connector adapter from Create a "BRK/First Alert" smoke detector connector adapter to Create a "BRK/First Alert" smoke detector connector adapter.
Thu, Nov 16, 8:43 PM · Hardware

Mon, Nov 13

epriestley added a comment to T13698: How do you hold a door open?.

Well now, that is certainly a nice rock.

Mon, Nov 13, 7:27 PM · Hardware
epriestley added a comment to D21862: Addressing some PHP 8 incompatibilities.

I'll see about getting it upstream.

Mon, Nov 13, 7:12 PM
epriestley updated the task description for T13700: Notes to Self, Late 2023.
Mon, Nov 13, 7:10 PM · Phacility
epriestley closed T13700: Notes to Self, Late 2023 as Resolved.

See D21826.

Mon, Nov 13, 7:10 PM · Phacility
epriestley closed D21875: Correct Aphlict websocket URI construction after PHP8 compatibility changes.
Mon, Nov 13, 7:04 PM
epriestley committed rP5720a38cfe95: Correct Aphlict websocket URI construction after PHP8 compatibility changes (authored by epriestley).
Correct Aphlict websocket URI construction after PHP8 compatibility changes
Mon, Nov 13, 7:04 PM
epriestley requested review of D21875: Correct Aphlict websocket URI construction after PHP8 compatibility changes.
Mon, Nov 13, 7:00 PM
epriestley added a revision to T13700: Notes to Self, Late 2023: D21875: Correct Aphlict websocket URI construction after PHP8 compatibility changes.
Mon, Nov 13, 7:00 PM · Phacility
epriestley added a comment to T13700: Notes to Self, Late 2023.

Next issue: can't pull from secure.

Mon, Nov 13, 6:49 PM · Phacility
epriestley added a comment to T13700: Notes to Self, Late 2023.

Issue 3:

Mon, Nov 13, 6:44 PM · Phacility
epriestley added a revision to T13700: Notes to Self, Late 2023: Unknown Object (Differential Revision).
Mon, Nov 13, 6:43 PM · Phacility
epriestley added a comment to T13700: Notes to Self, Late 2023.

With bin/provision events working again:

Mon, Nov 13, 6:29 PM · Phacility
epriestley triaged T13700: Notes to Self, Late 2023 as Wishlist priority.
Mon, Nov 13, 6:28 PM · Phacility
epriestley added a comment to D21862: Addressing some PHP 8 incompatibilities.

Your suggested patch looks correct to me, insofar as I recall what a computer looks like. I'll see about getting it upstream.

Mon, Nov 13, 5:40 PM

Jul 25 2023

epriestley triaged T13698: How do you hold a door open? as Wishlist priority.
Jul 25 2023, 2:07 PM · Hardware

Jul 18 2023

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Things I've figured out:

Jul 18 2023, 5:49 PM · Hardware

Jun 6 2023

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

I haven't used heat-set inserts yet and I'm not sure if they're trustworthy or not.

Jun 6 2023, 4:47 AM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Bobbin Case

Jun 6 2023, 4:46 AM · Hardware

May 30 2023

epriestley accepted D21870: Address some PHP8 incompatibilities - Arcanist.
May 30 2023, 4:29 PM
epriestley accepted D21871: Addressing some PHP8 incompatibilities - Dashboard.
May 30 2023, 2:35 PM
epriestley accepted D21869: Addressing PHP8 incompatibilities - Miscellaneous.

One actual logical issue inline.

May 30 2023, 2:34 PM
epriestley accepted D21872: Addressing PHP8 incompatibilities - Conduit.

Fine as-is, but see inlines about Conduit error behavior.

May 30 2023, 2:30 PM

May 29 2023

epriestley accepted D21868: Addressing some PHP8 incompatibilities - Misc. Applications.
May 29 2023, 4:28 AM

May 28 2023

epriestley accepted D21867: Updates for Mercurial's HTTP protocol.

This version looks correct to me in all non-pathological cases, thanks!

May 28 2023, 11:29 PM
epriestley accepted D21865: Updates for PHP 8.2 compatibility - Arcanist.
May 28 2023, 11:24 PM
epriestley accepted D21866: Addressing some PHP 8 incompatibilities - Remarkup.
May 28 2023, 11:03 PM
epriestley accepted D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.
May 28 2023, 11:02 PM

May 27 2023

epriestley added a comment to D21865: Updates for PHP 8.2 compatibility - Arcanist.

PhutilJSONParserException is sometimes handled specifically:

May 27 2023, 4:03 AM
epriestley added a comment to D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.

My preferred behavior is that the error is reported to the user, but not sent to the error log.

May 27 2023, 3:55 AM
epriestley accepted D21866: Addressing some PHP 8 incompatibilities - Remarkup.
May 27 2023, 12:26 AM
epriestley requested changes to D21867: Updates for Mercurial's HTTP protocol.

This is a big mess, but here's some general guidance (see also inline):

May 27 2023, 12:11 AM

May 26 2023

epriestley requested changes to D21865: Updates for PHP 8.2 compatibility - Arcanist.

I think the JSON change is suspicious, everything else looks good.

May 26 2023, 11:45 PM
epriestley requested changes to D21864: Addressing some PHP8 incompatibilities - Diffusion & Differential.

The two phlog() commands introduced in error handling seem unrelated, can we strip those out of this change? Everything else looks good.

May 26 2023, 11:37 PM

May 24 2023

epriestley accepted D21862: Addressing some PHP 8 incompatibilities.

I didn't catch anything that looks suspicious or hazardous. Thanks!

May 24 2023, 4:35 PM
epriestley accepted D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 24 2023, 4:12 PM

May 15 2023

epriestley added inline comments to D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.
May 15 2023, 5:17 PM
epriestley added a comment to D21863: Addressing some PHP8 incompatibilities - ProfileMenuItem.

(Haven't forgotten about this stuff, but the kids got sick and family is flying in soon.)

May 15 2023, 5:08 PM

May 8 2023

epriestley requested changes to D21862: Addressing some PHP 8 incompatibilities.

The relation between AuthProvider and AuthProviderConfig and AuthAdapter confused me a bit

May 8 2023, 5:07 AM

Apr 30 2023

epriestley added a comment to T13588: PHP 8 Compatibility.

I think the string typehint isn't supported until recent-ish PHP, so its availability will depend on your minimum supported version.

Apr 30 2023, 3:41 AM · Infrastructure

Apr 29 2023

epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

For https://we.phorge.it/T15281, consider modifying DiffusionGitCommandEngine->newFormattedCommand() to pass explicit configuration to Git (as we do in Mercurial) rather than requiring administrators correctly configure Git via .gitconfig via $HOME.

Apr 29 2023, 7:39 PM · Infrastructure
epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

With the caveat that I mostly dig holes in the dirt now and no longer remember how computers work:

Apr 29 2023, 2:45 PM · Infrastructure

Apr 26 2023

epriestley added a comment to T13588: PHP 8 Compatibility.

I favor dealing with them on a case-by-case basis since they don't seem especially pervasive and I think in most of the cases where I've fixed the issue, the fix I chose wasn't just to swap the call. I think these strlen() errors are often a correct/useful symptom of undesirable slop in type handling.

Apr 26 2023, 7:29 PM · Infrastructure

Apr 25 2023

epriestley accepted D21861: Fix support for pk-zip compressed figlet font files.

Aha! Looks good, then. Thanks!

Apr 25 2023, 8:08 PM
epriestley added a comment to D21861: Fix support for pk-zip compressed figlet font files.

I'm a little confused about how we ever hit the test for zip_open() (or whatever prompted the original change in D21860) if you don't have any custom compressed fonts and Phabricator doesn't ship with any custom compressed fonts? This change looks good to me, but how did we run into a problem in the first place?

Apr 25 2023, 5:13 PM
epriestley added a comment to D21860: Update Figlet implementation to be PHP8 compatible.

(It would also probably be fine to just remove support for compressed figlet fonts, they're probably saving like 5KB?)

Apr 25 2023, 3:03 PM
epriestley accepted D21860: Update Figlet implementation to be PHP8 compatible.

Thanks!

Apr 25 2023, 2:59 PM

Apr 1 2023

epriestley added a comment to D21859: Update the arc-hg.py extension to work with mercurial 6.4.

I also cherry-picked this to stable, since I don't have any specific plans around when I'm going to cut the next release right now.

Apr 1 2023, 1:59 PM
epriestley committed rARC60446ec65cfa: (stable) Update the arc-hg.py extension to work with mercurial 6.4 (authored by cspeckmim).
(stable) Update the arc-hg.py extension to work with mercurial 6.4
Apr 1 2023, 1:58 PM
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it?

Apr 1 2023, 1:58 PM · Hardware

Mar 31 2023

epriestley added a comment to T13689: A Considered Review: 3D Printing.

I've been using Fusion 360, which I'd say is "not bad". (See also T13697, perhaps.)

Mar 31 2023, 10:41 PM · Hardware
epriestley accepted D21859: Update the arc-hg.py extension to work with mercurial 6.4.

Thanks!

Mar 31 2023, 1:25 PM

Mar 2 2023

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

...I suspect that's a difficult geometry for FDM in PLA.

Mar 2 2023, 5:46 PM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

These sewing machine shaft collars are kind of tricky: thread unspools around them, so the inward face must have a completely smooth edge that can't catch or snag. This rules out a simple clamping-style shaft collar with a slit in it.

Mar 2 2023, 6:33 AM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Spool Cap (Small)

Mar 2 2023, 6:13 AM · Hardware

Feb 17 2023

epriestley edited the content of Changelog.
Feb 17 2023, 6:49 PM
epriestley renamed 2023 Week 7 (Mid February) from 2023 Week 7 to 2023 Week 7 (Mid February).
Feb 17 2023, 6:47 PM
epriestley created an object: 2023 Week 7 (Mid February).
Feb 17 2023, 6:47 PM
epriestley closed D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:36 PM
epriestley committed rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley).
Fix file PHID extraction in Pholio
Feb 17 2023, 6:36 PM
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
Feb 17 2023, 6:35 PM · Remarkup
epriestley requested review of D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:30 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:30 PM · Remarkup

Feb 7 2023

epriestley closed T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS as Resolved.

ADPClientService is a (currently) non-essential background service that collects juicy user data to send to Autodesk, since there's no way they could be expected to make ends meet on just $545/year licenses alone. You can find lots of threads about how to disable it in various Autodesk products, but none of these instructions appear to work in the current version of Fusion 360.

Feb 7 2023, 5:36 AM · Hardware

Feb 5 2023

epriestley added a comment to T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS.
...
Focus taken by Safari.
Focus taken by ADPClientService.
Focus taken by Safari.
...
Feb 5 2023, 3:54 PM · Hardware

Feb 4 2023

epriestley added a comment to T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS.

It stopped doing it as soon as I started watching it. But just wait, I'll catch it in the act. >_> <_<

Feb 4 2023, 10:03 PM · Hardware
epriestley triaged T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS as Low priority.
Feb 4 2023, 3:49 PM · Hardware
epriestley updated the summary of D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:56 PM
epriestley updated the summary of D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:55 PM
epriestley closed D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:54 PM
epriestley committed rARCd87d5f0e02e2: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()" (authored by epriestley).
Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()"
Feb 4 2023, 1:54 PM
epriestley added a comment to D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".

An easy optimization here is likely to avoid calling phutil_utf8v(...) on very long strings using a strategy like this:

Feb 4 2023, 1:53 PM
epriestley updated the diff for D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
  • Slightly smaller diff.
Feb 4 2023, 1:51 PM
epriestley requested review of D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:50 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:50 PM · Infrastructure
epriestley closed D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.
Feb 4 2023, 1:16 PM
epriestley committed rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch (authored by epriestley).
Correct a PHP8 compatibility issue when running "arc diff" with no active branch
Feb 4 2023, 1:16 PM
epriestley requested review of D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.
Feb 4 2023, 1:03 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.
Feb 4 2023, 1:03 PM · Infrastructure

Jan 23 2023

epriestley added a comment to T13689: A Considered Review: 3D Printing.

They sell "broken" Ender 3 printers on eBay for like $75 shipped. I ordered two. One had a bad board (a $40 part); one had a bad Y limit switch (a $3 part) -- so the actual cost per printer seems to be around ~$100 if you're familiar with how they work and can identify which parts aren't working.

Jan 23 2023, 7:36 PM · Hardware

Dec 22 2022

epriestley updated the task description for T13696: FAQ: Pocket Hole Joinery.
Dec 22 2022, 9:02 PM · Hardware

Dec 21 2022

epriestley triaged T13696: FAQ: Pocket Hole Joinery as Normal priority.
Dec 21 2022, 9:37 PM · Hardware
epriestley closed T13694: Create a "BRK/First Alert" smoke detector connector adapter as Resolved.

I traced the alarms back to Breaker #8 in Panel #2 (the detector tool actually worked okay this time). I disconnected the breaker and verified that killed the circuit. I swapped the alarms and updated the map of known breakers with this new information:

Dec 21 2022, 4:42 AM · Hardware

Dec 20 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

No great surprise, but the blue boards seem about the same as the red boards and have the same problems:

Dec 20 2022, 5:29 AM · Hardware
epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

The genuine article is not a JST-VH 4-pin connector -- the connecting clip is a little different, and there's no hole in the housing for (unused) pin #2. However, the pin size and spacing is right, so you can cut the connecting clip off a JST-VH and melt one of the pins out and the connector will fit well enough.

Dec 20 2022, 12:46 AM · Hardware

Dec 16 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

I bought an oscilloscope and tested the speed signal of one of the new red boards once it arrived. The scope showed the perfectly sensible signal I expected, and the signal came off the board fine once I hooked it up. So maybe the first couple boards were legitimately bad?

Dec 16 2022, 10:35 PM · Hardware
epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

This connector has a 4mm pin pitch, but I had a great deal of difficulty finding a likely-seeming bare connector with a 4mm pitch. After resigning myself to a Digikey quest for a connector that will fit a board on T13692, which also has a "4mm" pitch I realize the pitch is probably not 4mm but 3.96mm -- a wonderful pitch for which many connectors are readily available.

Dec 16 2022, 10:13 PM · Hardware
epriestley closed T13695: Improve performance of "MAXX Action Police Pursuit" vehicle as Resolved.

Here's the updated lightbar:

Dec 16 2022, 1:19 AM · Hardware

Dec 14 2022

epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

Here's my nice safe smoke detector power adapter:

Dec 14 2022, 11:23 PM · Hardware
epriestley added a comment to T13695: Improve performance of "MAXX Action Police Pursuit" vehicle.

There doesn't seem to be anything mechanically wrong with the toy, although the motor and gearbox don't seem to be accessible without breaking something.

Dec 14 2022, 12:46 AM · Hardware
epriestley triaged T13695: Improve performance of "MAXX Action Police Pursuit" vehicle as Normal priority.
Dec 14 2022, 12:06 AM · Hardware

Dec 13 2022

epriestley triaged T13694: Create a "BRK/First Alert" smoke detector connector adapter as Normal priority.
Dec 13 2022, 11:46 PM · Hardware

Dec 5 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

The capacitors on both boards arrived pretty banged up.

Dec 5 2022, 8:05 PM · Hardware

Dec 3 2022

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

String Shelf

Dec 3 2022, 7:36 AM · Hardware
epriestley attached a referenced file: F11291992: Screen Shot 2022-11-03 at 4.23.07 PM.png.
Dec 3 2022, 7:07 AM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Turny Thing

Dec 3 2022, 7:07 AM · Hardware
epriestley triaged T13693: Address various issues with Bernina B740 Sewing Machine as Normal priority.
Dec 3 2022, 6:52 AM · Hardware
epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

Motor Drivers

Dec 3 2022, 6:18 AM · Hardware

Dec 1 2022

epriestley triaged T13692: Build a portable motorized vehicle for a 3 year old as Normal priority.
Dec 1 2022, 4:02 PM · Hardware

Nov 22 2022

epriestley triaged T13691: Prevent 2015 Audi Q3 radio from playing music on vehicle start as Normal priority.
Nov 22 2022, 9:51 PM · Hardware