Page MenuHomePhabricator

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:41 PM.
Tags
None
Referenced Files
F18750165: D21443.diff
Sat, Oct 4, 6:46 AM
F18741671: D21443.id51080.diff
Thu, Oct 2, 3:03 PM
F18734346: D21443.id.diff
Tue, Sep 30, 10:52 PM
F18680906: D21443.id51042.diff
Fri, Sep 26, 3:25 AM
F18637433: D21443.id.diff
Wed, Sep 17, 7:21 AM
F18616269: D21443.id.diff
Sep 14 2025, 4:51 PM
F18612944: D21443.diff
Sep 14 2025, 10:03 AM
F18612861: D21443.diff
Sep 14 2025, 9:58 AM
Subscribers
None

Details

Summary

Ref T13552. Commit parsers currently invoke a special mode of "diffusion.querycommits", which is an older frozen method.

The replacement, "diffusion.commit.search", is not really appropriate for low-level access. This mode of having a single method which operates in "cache" or "non-cache" modes also ends up in a lot of unnecessary field shuffling.

Provide "internal.commit.search" as a modern equivalent that returns a "DiffusionCommitRef"-compatible structure.

Test Plan

Executed "internal.commit.search", got sensible low-level commit results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.