Page MenuHomePhabricator

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:41 PM.
Tags
None
Referenced Files
F19316202: D21443.diff
Thu, Dec 25, 4:25 AM
F19083377: D21443.id51080.diff
Dec 2 2025, 12:34 PM
F19014457: D21443.id51080.diff
Nov 22 2025, 8:08 PM
F19013791: D21443.id.diff
Nov 22 2025, 4:57 PM
F18993555: D21443.id51042.diff
Nov 19 2025, 8:11 AM
F18837335: D21443.diff
Oct 27 2025, 4:56 AM
F18817826: D21443.id.diff
Oct 21 2025, 6:51 PM
F18810154: D21443.id51080.diff
Oct 19 2025, 7:50 PM
Subscribers
None

Details

Summary

Ref T13552. Commit parsers currently invoke a special mode of "diffusion.querycommits", which is an older frozen method.

The replacement, "diffusion.commit.search", is not really appropriate for low-level access. This mode of having a single method which operates in "cache" or "non-cache" modes also ends up in a lot of unnecessary field shuffling.

Provide "internal.commit.search" as a modern equivalent that returns a "DiffusionCommitRef"-compatible structure.

Test Plan

Executed "internal.commit.search", got sensible low-level commit results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.