Remove construction of "author" information from "LastModified" payload in Diffusion
ClosedPublic
Actions

Authored by epriestley on Jul 10 2020, 4:05 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP81e4e5b7f9c9: Remove construction of "author" information from "LastModified" payload in…

Summary

Ref T13552. When viewing a directory in Diffusion, we make an Ajax call to get the last commit for each path.

This call currently pulls author information, since an older version of this UI showed author information.

The current UI does not show author information, so this parameter is unused. Delete the code which builds it.

Test Plan

Grepped for 'author' and references to the "pull-lastmodified" behavior. This behavior is invoked in only one place, which never generates an author placeholder.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 10 2020, 4:05 PM

Harbormaster completed remote builds in B24766: Diff 50947.Jul 10 2020, 4:06 PM

epriestley requested review of this revision.Jul 10 2020, 4:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM

Closed by commit rP81e4e5b7f9c9: Remove construction of "author" information from "LastModified" payload in… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP81e4e5b7f9c9: Remove construction of "author" information from "LastModified" payload in….

cspeckmim mentioned this in D21717: Remove history query from DiffusionRepositoryController as it is unused.Sep 4 2021, 5:55 AM

cspeckmim mentioned this in rP458ad4a8617a: Remove history query from DiffusionRepositoryController as it is unused.Sep 4 2021, 10:50 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionLastModifiedController.php

22 lines

view/

DiffusionBrowseTableView.php

1 line

Diff 51021

View Options

src/applications/diffusion/controller/DiffusionLastModifiedController.php