Page MenuHomePhabricator

Remove the "authored" subheader from commits
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:20 PM.
Tags
None
Referenced Files
F14077499: D21406.diff
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Mon, Nov 18, 2:26 PM
Unknown Object (File)
Thu, Nov 14, 3:14 AM
Unknown Object (File)
Sun, Nov 10, 11:18 AM
Unknown Object (File)
Wed, Nov 6, 12:54 PM
Unknown Object (File)
Oct 15 2024, 5:29 AM
Unknown Object (File)
Oct 7 2024, 7:12 PM
Unknown Object (File)
Oct 7 2024, 8:36 AM
Subscribers
None

Details

Summary

Ref T13552. I'm trying to reduce the number of direct callers to commit authorship metadata. This header seems low-value enough to simply remove; this information is shown more clearly and prominently in the "Provenance" UI.

In particular, commits have multiple dates (authored, committed, pushed) but this header shows only one. It currently shows the author identity and the commit date, which isn't entirely correct. And it potentially uses an "Identity" as a timeline actor, which is conceptually fine but not entirely firm ground.

Test Plan

Viewed a commit, saw no more subheader.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.