Page MenuHomePhabricator

Remove the "authored" subheader from commits
Needs ReviewPublic

Authored by epriestley on Fri, Jul 10, 4:20 PM.
This revision needs review, but there are no reviewers specified.

Details

Summary

Ref T13552. I'm trying to reduce the number of direct callers to commit authorship metadata. This header seems low-value enough to simply remove; this information is shown more clearly and prominently in the "Provenance" UI.

In particular, commits have multiple dates (authored, committed, pushed) but this header shows only one. It currently shows the author identity and the commit date, which isn't entirely correct. And it potentially uses an "Identity" as a timeline actor, which is conceptually fine but not entirely firm ground.

Test Plan

Viewed a commit, saw no more subheader.

Diff Detail

Repository
rP Phabricator
Branch
publish3
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24768
Build 34160: Run Core Tests
Build 34159: arc lint + arc unit

Event Timeline

epriestley created this revision.Fri, Jul 10, 4:20 PM
epriestley requested review of this revision.Fri, Jul 10, 4:21 PM