Differential D21547

When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI
ClosedPublic
Actions

Authored by epriestley on Fri, Feb 5, 4:06 PM.

Details

Reviewers: None
Maniphest Tasks: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits: rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the…

Summary

Ref T13602. When a subscriber can't see an object, it's currently hard to figure it out.

Show this status clearly in the curtain UI.

Test Plan

Screen Shot 2021-02-05 at 7.33.06 AM.png (233×331 px, 15 KB)

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Feb 5, 4:06 PM

Harbormaster completed remote builds in B25101: Diff 51290.Fri, Feb 5, 4:08 PM

epriestley requested review of this revision.Fri, Feb 5, 4:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 13, 9:37 PM

Closed by commit rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

applications/

phid/

PhabricatorObjectHandle.php

63 lines

policy/

filter/

PhabricatorPolicyFilterSet.php

62 lines

subscriptions/

engineextension/

PhabricatorSubscriptionsCurtainExtension.php

15 lines

view/

phui/

PHUICurtainObjectRefView.php

29 lines

webroot/

rsrc/

css/

phui/

phui-curtain-object-ref-view.css

13 lines

Diff 51312

View Options

resources/celerity/map.php

View Options

src/applications/phid/PhabricatorObjectHandle.php

View Options

src/applications/policy/filter/PhabricatorPolicyFilterSet.php

View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php

View Options

src/view/phui/PHUICurtainObjectRefView.php

View Options

webroot/rsrc/css/phui/phui-curtain-object-ref-view.css

When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51312

resources/celerity/map.php

src/applications/phid/PhabricatorObjectHandle.php

src/applications/policy/filter/PhabricatorPolicyFilterSet.php

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php

src/view/phui/PHUICurtainObjectRefView.php

webroot/rsrc/css/phui/phui-curtain-object-ref-view.css

When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI
ClosedPublic
Actions

Revision Contents
Changeset List