Page MenuHomePhabricator
Differential D21547

When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2021, 4:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 2:42 PM
Unknown Object (File)
Mon, Nov 11, 6:48 AM
Unknown Object (File)
Sat, Nov 9, 5:17 PM
Unknown Object (File)
Mon, Nov 4, 11:01 PM
Unknown Object (File)
Oct 14 2024, 8:05 PM
Unknown Object (File)
Oct 9 2024, 1:48 PM
Unknown Object (File)
Sep 26 2024, 11:45 PM
Unknown Object (File)
Sep 22 2024, 10:05 PM
View All 100 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits
rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the…
Summary

Ref T13602. When a subscriber can't see an object, it's currently hard to figure it out.

Show this status clearly in the curtain UI.

Test Plan

Screen Shot 2021-02-05 at 7.33.06 AM.png (233×331 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 5 2021, 4:06 PM
Harbormaster completed remote builds in B25101: Diff 51290.Feb 5 2021, 4:08 PM
epriestley requested review of this revision.Feb 5 2021, 4:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM
Closed by commit rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the….

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
phid/
63 lines
policy/
filter/
62 lines
subscriptions/
engineextension/
15 lines
view/
phui/
29 lines
webroot/
rsrc/
css/
phui/
13 lines

Diff 51312

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/policy/filter/PhabricatorPolicyFilterSet.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php

Loading...
View Options

src/view/phui/PHUICurtainObjectRefView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-curtain-object-ref-view.css

Loading...
Phabricator · Built by Phacility