Differential D21442

Lift Diffusion Conduit call proxying to the root level of Conduit
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 6:32 PM.

Tags

None

Referenced Files

	F17803607: D21442.id51041.diff
	Fri, Jul 25, 10:22 AM

	F17784630: D21442.id51079.diff
	Thu, Jul 24, 12:39 PM

	F17770803: D21442.id51079.diff
	Wed, Jul 23, 10:19 AM

	F17769406: D21442.id51079.diff
	Wed, Jul 23, 8:40 AM

	F17755107: D21442.diff
	Tue, Jul 22, 11:54 AM

	F17713491: D21442.id51079.diff
	Thu, Jul 17, 2:07 PM

	F17708025: D21442.id51041.diff
	Wed, Jul 16, 4:04 PM

	Unknown Object (File)
	Jun 23 2025, 12:31 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit

Summary

Ref T13552. Some Diffusion conduit calls may only be served by a node which hosts a working copy on disk, so they're proxied if received by a different node.

This capability is currently bound tightly to "DiffusionRequest", which is a bundle of context parameters used by some Diffusion calls. However, call proxying is not fundamentally a Diffusion behavior.

I want to perform proxying on a "*.search" call which does not use the "DiffusionRequest" parameter bundle. Lift proxying to the root level of Conduit.

Test Plan

Browsed diffusion in a clusterized repsository.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2020, 6:32 PM

Harbormaster completed remote builds in B24856: Diff 51041.Aug 12 2020, 6:33 PM

epriestley requested review of this revision.Aug 12 2020, 6:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM

Closed by commit rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPIMethod.php

12 lines

protocol/

ConduitAPIRequest.php

4 lines

diffusion/

conduit/

DiffusionQueryConduitAPIMethod.php

75 lines

repository/

storage/

PhabricatorRepository.php

17 lines

Diff 51079

src/applications/conduit/method/ConduitAPIMethod.php

Loading...

src/applications/conduit/protocol/ConduitAPIRequest.php

Loading...

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...