Page MenuHomePhabricator

Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView"
Needs ReviewPublic

Authored by epriestley on Fri, Jul 10, 6:20 PM.
This revision needs review, but there are no reviewers specified.



Ref T13552. Currently, commit lists are sometimes rendered as an object list and sometimes rendered as a table. There are two separate views for table rendering.

Add a fourth view ("list, with a graph") with the eventual intent of unifying all the other views. For now, this only replaces "HistoryListView" -- and needs some more work to really be a convincing replacement.

Test Plan
  • Looked at "History" in Diffusion, saw an ugly view with all the information we want.
  • Grepped for "HistoryListView", no hits.

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 24772
Build 34168: Run Core Tests
Build 34167: arc lint + arc unit

Event Timeline

epriestley created this revision.Fri, Jul 10, 6:20 PM
epriestley requested review of this revision.Fri, Jul 10, 6:22 PM