Page MenuHomePhabricator
Differential D21413

Move the view of merged changes to "DiffusionCommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 4:16 PM.
Tags
None
Referenced Files
F14756490: D21413.id50958.diff
Tue, Jan 21, 7:52 PM
Unknown Object (File)
Mon, Jan 20, 10:26 AM
Unknown Object (File)
Thu, Jan 2, 5:34 AM
Unknown Object (File)
Dec 19 2024, 12:56 AM
Unknown Object (File)
Dec 14 2024, 11:23 AM
Unknown Object (File)
Dec 12 2024, 2:49 AM
Unknown Object (File)
Dec 9 2024, 3:35 PM
Unknown Object (File)
Dec 8 2024, 3:07 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView"
Summary

Ref T13552. When viewing a merge commit, merged changes are currently shown inline. Update this view to use the new "GraphView" rendering pipeline.

Test Plan
  • Viewed a merge commit, saw merges.
  • Viewed history, profile page, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 12 2020, 4:16 PM
Harbormaster completed remote builds in B24778: Diff 50958.Jul 12 2020, 4:17 PM
epriestley requested review of this revision.Jul 12 2020, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
Closed by commit rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView".

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
6 lines
20 lines
view/
172 lines

Diff 51030

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
Phabricator · Built by Phacility