Page MenuHomePhabricator
Differential D21413

Move the view of merged changes to "DiffusionCommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 4:16 PM.
Tags
None
Referenced Files
F18734331: D21413.id.diff
Tue, Sep 30, 10:52 PM
F18702072: D21413.id.diff
Sat, Sep 27, 10:30 PM
F18693487: D21413.id51030.diff
Sat, Sep 27, 1:24 AM
F18652792: D21413.diff
Sun, Sep 21, 9:33 AM
F18614698: D21413.id.diff
Sep 14 2025, 1:08 PM
F18602350: D21413.diff
Sep 13 2025, 2:50 PM
F18571129: D21413.id51030.diff
Sep 10 2025, 4:44 AM
F18571127: D21413.id50958.diff
Sep 10 2025, 4:44 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView"
Summary

Ref T13552. When viewing a merge commit, merged changes are currently shown inline. Update this view to use the new "GraphView" rendering pipeline.

Test Plan
  • Viewed a merge commit, saw merges.
  • Viewed history, profile page, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 12 2020, 4:16 PM
Harbormaster completed remote builds in B24778: Diff 50958.Jul 12 2020, 4:17 PM
epriestley requested review of this revision.Jul 12 2020, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
Closed by commit rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView".

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
6 lines
20 lines
view/
172 lines

Diff 51030

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
Phabricator · Built by Phacility