Page MenuHomePhabricator

Fix an issue where inline comments with only edit suggestions are considered empty
ClosedPublic

Authored by epriestley on May 23 2020, 3:18 PM.

Details

Summary

Ref T13513. An inline is not considered empty if it has a suggestion, but some of the shared transaction code doesn't test for this properly.

Update the shared transaction code to be aware that application comments may have more complex emptiness rules.

Test Plan
  • Posted an inline with only an edit suggestion, comment went through.
  • Tried to post a normal empty comment, got an appropriate warning.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

@epriestley - empty inline comment with suggestion renders rather peculiar transaction which is somewhat confusing and odd... Any plans on tackling it? Like See context greyed out...