Page MenuHomePhabricator

Move task and revision closure to the "publishing" step of the commit import pipeline
ClosedPublic

Authored by epriestley on Aug 12 2020, 9:19 PM.

Details

Summary

Ref T13552. Now that these steps can build their own "CommitRef" object from storage on the "CommitData" object, move them from the "Message" step to the "Publishing" step.

This should resolve the root issue in T13552, where a commit moved from a non-permanent branch to a permanent branch does not publish closures properly.

Test Plan

Used "bin/repository reparse --publish ..." to republish changes.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 16, 12:37 AM
This revision was automatically updated to reflect the committed changes.