Differential D21450

Move task and revision closure to the "publishing" step of the commit import pipeline
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 9:19 PM.

Tags

None

Referenced Files

	F18199989: D21450.id51049.diff
	Mon, Aug 18, 3:37 AM

	F18101266: D21450.diff
	Sat, Aug 9, 12:24 PM

	F17978247: D21450.diff
	Fri, Aug 1, 5:58 PM

	F17865548: D21450.id51086.diff
	Mon, Jul 28, 3:29 AM

	F17856462: D21450.id.diff
	Sun, Jul 27, 5:21 PM

	F17846166: D21450.diff
	Sun, Jul 27, 4:29 AM

	F17705708: D21450.diff
	Jul 16 2025, 8:49 AM

	Unknown Object (File)
	Jul 3 2025, 9:59 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import…

Summary

Ref T13552. Now that these steps can build their own "CommitRef" object from storage on the "CommitData" object, move them from the "Message" step to the "Publishing" step.

This should resolve the root issue in T13552, where a commit moved from a non-permanent branch to a permanent branch does not publish closures properly.

Test Plan

Used "bin/repository reparse --publish ..." to republish changes.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2020, 9:19 PM

Harbormaster completed remote builds in B24864: Diff 51049.Aug 12 2020, 9:20 PM

epriestley requested review of this revision.Aug 12 2020, 9:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM

Closed by commit rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import….

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

PhabricatorRepositoryCommitPublishWorker.php

164 lines

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

137 lines

Diff 51086

src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php

Loading...

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...