Page MenuHomePhabricator
Feed All Stories

Today

spawnlt awarded T13039: Support numeric fields in Herald a Party Time token.
Thu, Jun 20, 5:26 AM · Herald
Herald updated subscribers of T13039: Support numeric fields in Herald.
Thu, Jun 20, 5:26 AM · Herald

Yesterday

aeiser added a comment to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.

the (Show Details) would be a great first step for us - and cover our needs. Much like the logs for Herald Rules and other areas.

Wed, Jun 19, 10:58 PM · EditEngine
amckinley requested review of D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Wed, Jun 19, 10:21 PM
amckinley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Wed, Jun 19, 10:19 PM · EditEngine
epriestley changed the visibility for D3219: Add View, Edit and Join policies to PhabricatorProject.
Wed, Jun 19, 9:45 PM
epriestley committed rP37e26f1b4531: Improve rendering of "default value changed" custom form transactions to at… (authored by epriestley).
Improve rendering of "default value changed" custom form transactions to at…
Wed, Jun 19, 8:47 PM
epriestley closed D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Wed, Jun 19, 8:47 PM
epriestley added a comment to T13318: Phacility developer setup documentation omits "local.*" hosts.

🐫 Does this button work ------>>^^^

Wed, Jun 19, 8:36 PM · Phacility
D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information is now accepted and ready to land.
Wed, Jun 19, 8:35 PM
epriestley requested review of D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Wed, Jun 19, 8:29 PM
epriestley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Wed, Jun 19, 8:27 PM · EditEngine
epriestley added a comment to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.

There are a few pieces here, since we have to thread the needle through many layers to get where we want to go.

Wed, Jun 19, 8:16 PM · EditEngine
epriestley created T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.
Wed, Jun 19, 7:54 PM · EditEngine
epriestley committed rPcaaa1394ef15: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y. (authored by epriestley).
Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.
Wed, Jun 19, 7:51 PM
epriestley closed D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 7:51 PM
epriestley closed T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility) as Resolved by committing rPcaaa1394ef15: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y..
Wed, Jun 19, 7:51 PM · Mail, Phacility
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

If JIRA links are mostly/all in the form ?page=com.jira.jira.plugin.extension.gateway-to-realms-of-wonder&exec=rm -rf / that might also mean that "links which don't really link to the task" are common and that "task + params" is more like "portal to arbitrary plugin behavior", although I'm not having much luck digging up more information about this by Googling.

Wed, Jun 19, 7:48 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

(Also, now that I've read PHI1312, I mind this^^ implementation less since that was the actual support request anyway).

Wed, Jun 19, 7:46 PM
D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address is now accepted and ready to land.
Wed, Jun 19, 7:27 PM
D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper) is now accepted and ready to land.

Do you think ( XXX-123 Order More Copier Paper ) is still a reasonable rendering if the parameter is something like ?download=123 and that means "Download Attached File 123" and clicking the link doesn't take you to XXX-123 at all?

Wed, Jun 19, 7:21 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

Also, practically, I can't actually figure out how to get either modern JIRA or Asana to generate any URI with any parameters or fragments at all. Neither appears to support linking directly to a comment.

Wed, Jun 19, 7:17 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

I guess my assumption is that ?a=b may, in the general case, completely change the meaning of the link. Although I think this has mostly been purged from the web now, an example was #! fragments before the widespread use of the history API, where https://example.com/a/#!b actually meant "Page B", not "Page A", and labeling the link "Page A" would be misleading.

Wed, Jun 19, 7:09 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

If it's the same thing, that seems possibly confusing (two different links have the same visual rendering).

Wed, Jun 19, 7:03 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

It's meaningfully more work, but the bigger thing stopping me is that I'm not sure what the best display behavior is.

Wed, Jun 19, 6:53 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

This is just short-circuiting the whole external object lookup process, right? Is it significantly more work to just fix the lookup process to preserve these fragments?

Wed, Jun 19, 6:40 PM
epriestley added inline comments to D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 6:22 PM
epriestley added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

See also T13317.

Wed, Jun 19, 6:20 PM · Wikimedia, Policy
epriestley requested review of D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 6:17 PM
epriestley added a revision to T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility): D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 6:15 PM · Mail, Phacility
epriestley requested review of D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Wed, Jun 19, 5:48 PM
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Wed, Jun 19, 5:46 PM · Remarkup, Diffusion
epriestley committed rP9f44ee393343: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic (authored by epriestley).
Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic
Wed, Jun 19, 5:45 PM
epriestley closed D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic.
Wed, Jun 19, 5:45 PM
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20591: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Wed, Jun 19, 5:44 PM · Remarkup, Diffusion
D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic is now accepted and ready to land.

👻

Wed, Jun 19, 5:42 PM
epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.

See PHI1312. The modified JIRA rules reportedly misfire on URIs with anchors or parameters. For now, the plan is to just skip these URIs. In the future, we might specialize URIs which (for example) link to comments on foreign objects.

Wed, Jun 19, 5:33 PM · Remarkup, Diffusion
epriestley closed T9720: Provide a way to link to Diffusion files, a subtask of T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does), as Resolved.
Wed, Jun 19, 5:32 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley added a comment to T9720: Provide a way to link to Diffusion files.

I'm going to close this in favor of T13291. Referencing files by full URI currently works, and relative references and other behavior is planned.

Wed, Jun 19, 5:32 PM · Restricted Project, Remarkup
epriestley closed T9720: Provide a way to link to Diffusion files, a subtask of T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion, as Resolved.
Wed, Jun 19, 5:32 PM · Remarkup, Diffusion
epriestley added a parent task for T9720: Provide a way to link to Diffusion files: T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
Wed, Jun 19, 5:31 PM · Restricted Project, Remarkup
epriestley added a subtask for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: T9720: Provide a way to link to Diffusion files.
Wed, Jun 19, 5:31 PM · Remarkup, Diffusion
epriestley added a comment to T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks.

Getting rid of the indirect writes on handle reads would probably be nice eventually, but doesn't directly accomplish anything today.

Wed, Jun 19, 5:30 PM · Installing & Upgrading, Database
epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

I think that might be everything? Not entirely sure, but haven't seen any more since the last deploy.

Wed, Jun 19, 5:29 PM · Transactions
epriestley added a task to D20587: Fix more "msort()" vs "msortv()" callsites: T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
Wed, Jun 19, 5:29 PM
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20587: Fix more "msort()" vs "msortv()" callsites.
Wed, Jun 19, 5:29 PM · Transactions
epriestley requested review of D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic.
Wed, Jun 19, 5:26 PM
epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic.
Wed, Jun 19, 5:24 PM · Quicksand
epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

D20573 has one issue where the "Select" buttons in the "Merge Duplicates In" dialog are now closing the dialog. We might be missing a JX.pass() / e.prevent() (hopefully) or might need to get slightly more creative in distinguishing between navigation links and javascript magic links.

Wed, Jun 19, 2:51 PM · Quicksand
spawnlt awarded T6491: Herald rules based on age a Party Time token.
Wed, Jun 19, 10:23 AM · Restricted Project, Herald

Tue, Jun 18

epriestley added a comment to D20568: Parse remarkup tables with something like a real parser instead of regular expressions.

Yeah, there's a lot of very ambiguous behavior here in the face of ambiguous inputs. I think we're probably not walking into too much of a minefield, but I'm not confident I picked the best behavior for all malformed/suspicious inputs.

Tue, Jun 18, 11:30 PM
D20568: Parse remarkup tables with something like a real parser instead of regular expressions is now accepted and ready to land.

I'm a little worried about a Postel's Law-style HTML parser. Later on I can envision getting more strict about what we accept in the interest of delivering more precise error messages, which might break existing pages that previously worked just by accident. I guess if it ever comes to that, we can write a migration that warns installs about suddenly-malformed wiki pages.

Tue, Jun 18, 11:26 PM
epriestley closed T13308: Phacility account import flow can misfire when both invites and account links are present as Resolved by committing Restricted Diffusion Commit.
Tue, Jun 18, 10:49 PM · Phacility
epriestley closed T13146: Phacility account import tool fails to recognize usernames with differing case, e.g. "Alice" vs "alice" as Resolved by committing Restricted Diffusion Commit.
Tue, Jun 18, 10:31 PM · Phacility
epriestley committed rP5d8ee504d645: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link… (authored by epriestley).
Replace weird, redundant list of branches in Diffusion "Manage" UI with a link…
Tue, Jun 18, 10:20 PM
epriestley closed D20584: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list.
Tue, Jun 18, 10:20 PM
epriestley closed T13312: "Branch Status" in Diffusion has a bizarre pager at the top of the element as Resolved by committing rP5d8ee504d645: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link….
Tue, Jun 18, 10:20 PM · Diffusion
epriestley committed rPdcf3ca8e0450: When a user clicks a navigation link in a dialog, close the dialog (authored by epriestley).
When a user clicks a navigation link in a dialog, close the dialog
Tue, Jun 18, 10:16 PM
epriestley closed D20573: When a user clicks a navigation link in a dialog, close the dialog.
Tue, Jun 18, 10:16 PM
epriestley committed rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser (authored by epriestley).
Parse "shallow" frames in the Git "upload-pack" wire protocol parser
Tue, Jun 18, 10:15 PM
epriestley closed D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
Tue, Jun 18, 10:15 PM
epriestley closed T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone as Resolved by committing rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
Tue, Jun 18, 10:15 PM · Diffusion
epriestley added a comment to D20573: When a user clicks a navigation link in a dialog, close the dialog.
  • Make it less so.
Tue, Jun 18, 10:12 PM
D20573: When a user clicks a navigation link in a dialog, close the dialog is now accepted and ready to land.
Tue, Jun 18, 9:49 PM
D20584: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list is now accepted and ready to land.
Tue, Jun 18, 9:19 PM
D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser is now accepted and ready to land.
Tue, Jun 18, 9:08 PM
epriestley committed rP753828649956: Fix missing link targets for "View Object" header buttons in HTML email (authored by epriestley).
Fix missing link targets for "View Object" header buttons in HTML email
Tue, Jun 18, 8:21 PM
epriestley closed D20586: Fix missing link targets for "View Object" header buttons in HTML email.
Tue, Jun 18, 8:21 PM
D20586: Fix missing link targets for "View Object" header buttons in HTML email is now accepted and ready to land.
Tue, Jun 18, 8:15 PM
epriestley committed rP6219d30f6b0b: Recommend dumping database backups with "--compress --output X" instead of "|… (authored by epriestley).
Recommend dumping database backups with "--compress --output X" instead of "|…
Tue, Jun 18, 6:37 PM
epriestley closed D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X".
Tue, Jun 18, 6:37 PM
epriestley closed T13304: Phabricator "Backups" instructions are somewhat out of date as Resolved by committing rP6219d30f6b0b: Recommend dumping database backups with "--compress --output X" instead of "|….
Tue, Jun 18, 6:37 PM · Database
epriestley committed rP1dd62f79cedb: Fix more "msort()" vs "msortv()" callsites (authored by epriestley).
Fix more "msort()" vs "msortv()" callsites
Tue, Jun 18, 6:36 PM
epriestley closed D20587: Fix more "msort()" vs "msortv()" callsites.
Tue, Jun 18, 6:36 PM
epriestley committed rP731b45d81847: In "bin/repository reparse", continue on… (authored by epriestley).
In "bin/repository reparse", continue on…
Tue, Jun 18, 6:33 PM
epriestley closed D20588: In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException".
Tue, Jun 18, 6:33 PM
epriestley closed T13315: "bin/repository reparse" stops when encountering a "PhabricatorWorkerPermanentFailureException", but should continue as Resolved by committing rP731b45d81847: In "bin/repository reparse", continue on….
Tue, Jun 18, 6:33 PM · Diffusion
epriestley updated subscribers of T13156: Plans: Improve Phacility UI for managing instance managers and cards.

See PHI954. The "support pact members" cache is currently updated only when you actually click "Support", but this is often silly and unintuitive.

Tue, Jun 18, 6:22 PM · Plans, Phacility
epriestley created T13318: Phacility developer setup documentation omits "local.*" hosts.
Tue, Jun 18, 6:20 PM · Phacility
D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X" is now accepted and ready to land.
Tue, Jun 18, 5:26 PM
D20588: In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException" is now accepted and ready to land.
Tue, Jun 18, 5:24 PM
epriestley renamed T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility) from Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility to Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility).
Tue, Jun 18, 5:22 PM · Mail, Phacility
epriestley added a comment to T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility).

Aha! This user very cleverly added noreply@admin.phacility.com to their user account before they were disabled.

Tue, Jun 18, 5:22 PM · Mail, Phacility
epriestley created T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility).
Tue, Jun 18, 5:15 PM · Mail, Phacility
D20587: Fix more "msort()" vs "msortv()" callsites is now accepted and ready to land.
Tue, Jun 18, 5:14 PM
epriestley created T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board).
Tue, Jun 18, 4:41 PM · Workboards
epriestley requested review of D20588: In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException".
Tue, Jun 18, 3:03 PM
epriestley added a revision to T13315: "bin/repository reparse" stops when encountering a "PhabricatorWorkerPermanentFailureException", but should continue: D20588: In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException".
Tue, Jun 18, 3:02 PM · Diffusion
epriestley created T13315: "bin/repository reparse" stops when encountering a "PhabricatorWorkerPermanentFailureException", but should continue.
Tue, Jun 18, 2:57 PM · Diffusion
epriestley requested review of D20587: Fix more "msort()" vs "msortv()" callsites.
Tue, Jun 18, 2:32 PM
epriestley requested review of D20586: Fix missing link targets for "View Object" header buttons in HTML email.
Tue, Jun 18, 2:27 PM
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
  • Plus a rebase for the msortv() change.
Tue, Jun 18, 1:20 AM
Harbormaster failed remote builds in B22977: Diff 49102 for D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser!
Tue, Jun 18, 1:20 AM
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

🥾

Tue, Jun 18, 1:18 AM
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Oh, not sure what happened there -- that's the local result, so maybe I ^C'd too fast. Let me just kick it...

Tue, Jun 18, 1:17 AM
amckinley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Is it expected that B22956 never completed?

Tue, Jun 18, 12:22 AM

Mon, Jun 17

epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

I deployed that last round of things to secure. Not totally confident I got everything, but hopefully we're in better shape now.

Mon, Jun 17, 9:25 PM · Transactions
epriestley committed rPaba7c98baedb: Skip loading transaction handles in an old migration (authored by epriestley).
Skip loading transaction handles in an old migration
Mon, Jun 17, 8:58 PM
epriestley closed D20570: Skip loading transaction handles in an old migration.
Mon, Jun 17, 8:57 PM
epriestley committed rPbab35f28e49d: Respect repository identities when selecting author vs auditor actions (authored by epriestley).
Respect repository identities when selecting author vs auditor actions
Mon, Jun 17, 8:56 PM