Page MenuHomePhabricator
Feed All Stories

Wed, Sep 23

ptarjan updated the summary of D21471: fail `arc diff` if second lfs push errors.
Wed, Sep 23, 8:45 PM
ptarjan updated the diff for D21471: fail `arc diff` if second lfs push errors.

fix lint

Wed, Sep 23, 8:27 PM
ptarjan requested review of D21471: fail `arc diff` if second lfs push errors.
Wed, Sep 23, 8:26 PM

Fri, Sep 18

epriestley edited the content of Changelog.
Fri, Sep 18, 7:03 PM
epriestley committed rARC68dba1a2c6d9: (stable) Promote 2020 Week 37 (authored by epriestley).
(stable) Promote 2020 Week 37
Fri, Sep 18, 7:00 PM
epriestley committed rP5e06d924f8eb: (stable) Promote 2020 Week 37 (authored by epriestley).
(stable) Promote 2020 Week 37
Fri, Sep 18, 7:00 PM
epriestley created an object: 2020 Week 37 (Mid September).
Fri, Sep 18, 6:55 PM
epriestley committed rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"… (authored by epriestley).
In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…
Fri, Sep 18, 6:23 PM
epriestley closed D21470: In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly.
Fri, Sep 18, 6:23 PM
epriestley requested review of D21470: In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly.
Fri, Sep 18, 6:22 PM

Thu, Sep 17

epriestley committed rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as… (authored by epriestley).
Fix an issue where known Subversion commits are incorrectly shown as…
Thu, Sep 17, 8:55 PM
epriestley closed D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Thu, Sep 17, 8:55 PM
epriestley requested review of D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Thu, Sep 17, 8:53 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Thu, Sep 17, 8:52 PM · Differential
epriestley committed rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior (authored by epriestley).
Fix an out-of-order issue in the new update-during-publish behavior
Thu, Sep 17, 8:40 PM
epriestley closed D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Thu, Sep 17, 8:40 PM
epriestley requested review of D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Thu, Sep 17, 8:39 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Thu, Sep 17, 8:38 PM · Differential
epriestley closed D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Thu, Sep 17, 8:20 PM
epriestley committed rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions (authored by epriestley).
In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
Thu, Sep 17, 8:20 PM
epriestley requested review of D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Thu, Sep 17, 8:19 PM
epriestley added a revision to T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring: D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Thu, Sep 17, 8:19 PM · Arcanist, Conduit
epriestley triaged T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring as Low priority.
Thu, Sep 17, 8:17 PM · Arcanist, Conduit
epriestley committed rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by… (authored by epriestley).
Fix a slow memory leak in long-lived FutureIterator objects, as used by…
Thu, Sep 17, 7:56 PM
epriestley closed D21466: Fix a slow memory leak in long-lived FutureIterator objects, as used by FuturePool.
Thu, Sep 17, 7:56 PM
epriestley requested review of D21466: Fix a slow memory leak in long-lived FutureIterator objects, as used by FuturePool.
Thu, Sep 17, 7:53 PM
epriestley added a comment to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool.

This synthetic script demonstrates the conceptual problem with FutureIterator:

Thu, Sep 17, 7:49 PM · Daemons
epriestley committed rPa754c694deab: Add missing indexes to DrydockRepositoryOperation (authored by epriestley).
Add missing indexes to DrydockRepositoryOperation
Thu, Sep 17, 7:10 PM
epriestley closed D21465: Add missing indexes to DrydockRepositoryOperation.
Thu, Sep 17, 7:10 PM
epriestley requested review of D21465: Add missing indexes to DrydockRepositoryOperation.
Thu, Sep 17, 7:09 PM

Wed, Sep 16

Harbormaster failed to build B24901: rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered for rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24898: rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… for rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not…!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24900: rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record for rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24906: rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls for rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24904: rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… for rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole…!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24902: rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag for rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24903: rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… for rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import…!
Wed, Sep 16, 12:48 AM
Harbormaster failed to build B24899: rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" for rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData"!
Wed, Sep 16, 12:47 AM
Harbormaster failed to build B24897: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" for rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits"!
Wed, Sep 16, 12:47 AM
Harbormaster failed to build B24896: rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow for rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow!
Wed, Sep 16, 12:45 AM
epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
Wed, Sep 16, 12:44 AM · Differential
epriestley committed rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls (authored by epriestley).
Log unexpected exceptions raised by Conduit calls
Wed, Sep 16, 12:37 AM
epriestley committed rP2a83df578604: Fix an issue where a GROUP BY was missing when a query matched a revision using… (authored by epriestley).
Fix an issue where a GROUP BY was missing when a query matched a revision using…
Wed, Sep 16, 12:37 AM
epriestley committed rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… (authored by epriestley).
When an in-process worker subtask fails permanently, don't fatal the whole…
Wed, Sep 16, 12:37 AM
epriestley committed rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… (authored by epriestley).
Move task and revision closure to the "publishing" step of the commit import…
Wed, Sep 16, 12:37 AM
epriestley committed rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered (authored by epriestley).
Fix a view fatal in CommitGraphView when commits are undiscovered
Wed, Sep 16, 12:37 AM
epriestley committed rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag (authored by epriestley).
When a commit is marked "closeable", clear the "published" flag
Wed, Sep 16, 12:37 AM
epriestley committed rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record (authored by epriestley).
Make "CommitData" wrap and persist a "CommitRef" record
Wed, Sep 16, 12:37 AM
epriestley closed D21464: Log unexpected exceptions raised by Conduit calls.
Wed, Sep 16, 12:37 AM
epriestley closed D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Wed, Sep 16, 12:37 AM
epriestley closed D21460: When a commit is marked "closeable", clear the "published" flag.
Wed, Sep 16, 12:37 AM
epriestley committed rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" (authored by epriestley).
Wrap all direct access to author/committer properties on "CommitData"
Wed, Sep 16, 12:37 AM
epriestley closed D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Wed, Sep 16, 12:37 AM
epriestley committed rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley).
Turn "bypassCache" into a no-op in "diffusion.querycommits"
Wed, Sep 16, 12:37 AM
epriestley closed T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Resolved by committing rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole….
Wed, Sep 16, 12:37 AM · Daemons
epriestley committed rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… (authored by epriestley).
Build "DiffusionCommitRef" objects from "internal.commit.search", not…
Wed, Sep 16, 12:37 AM
epriestley closed D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Wed, Sep 16, 12:37 AM
epriestley closed D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Wed, Sep 16, 12:37 AM
epriestley committed rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley).
Lift Diffusion Conduit call proxying to the root level of Conduit
Wed, Sep 16, 12:37 AM
epriestley committed rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow (authored by epriestley).
Remove "bin/repository lookup-users" workflow
Wed, Sep 16, 12:37 AM
epriestley committed rPa9506097ea04: Add "internal.commit.search" to replace the cache bypass mode of "diffusion. (authored by epriestley).
Add "internal.commit.search" to replace the cache bypass mode of "diffusion.
Wed, Sep 16, 12:37 AM
epriestley closed D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Wed, Sep 16, 12:37 AM
epriestley committed rP367cd289270d: Delete some commit dead parsing code (authored by epriestley).
Delete some commit dead parsing code
Wed, Sep 16, 12:37 AM
epriestley closed D21448: Wrap all direct access to author/committer properties on "CommitData".
Wed, Sep 16, 12:36 AM
epriestley closed D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.
Wed, Sep 16, 12:36 AM
epriestley closed D21444: Remove "bin/repository lookup-users" workflow.
Wed, Sep 16, 12:36 AM
epriestley closed D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".
Wed, Sep 16, 12:36 AM
epriestley closed D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Wed, Sep 16, 12:36 AM
epriestley closed D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Wed, Sep 16, 12:36 AM
epriestley closed D21441: Delete some commit dead parsing code.
Wed, Sep 16, 12:36 AM
epriestley committed rARCde209ec06488: When raising a Conduit client exception, show the called method in the error… (authored by epriestley).
When raising a Conduit client exception, show the called method in the error…
Wed, Sep 16, 12:34 AM
epriestley closed D21463: When raising a Conduit client exception, show the called method in the error message.
Wed, Sep 16, 12:34 AM
epriestley requested review of D21464: Log unexpected exceptions raised by Conduit calls.
Wed, Sep 16, 12:25 AM
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21464: Log unexpected exceptions raised by Conduit calls.
Wed, Sep 16, 12:24 AM · Differential
epriestley requested review of D21463: When raising a Conduit client exception, show the called method in the error message.
Wed, Sep 16, 12:20 AM
epriestley requested review of D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Wed, Sep 16, 12:20 AM
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21463: When raising a Conduit client exception, show the called method in the error message.
Wed, Sep 16, 12:20 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Wed, Sep 16, 12:19 AM · Differential
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Wed, Sep 16, 12:16 AM · Differential

Tue, Sep 15

epriestley committed rP3dfa89dd5d27: Update SES API to use AWSv4 signatures (authored by epriestley).
Update SES API to use AWSv4 signatures
Tue, Sep 15, 8:03 PM
epriestley closed D21461: Update SES API to use AWSv4 signatures.
Tue, Sep 15, 8:03 PM
epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly, a subtask of T13570: Amazon is retiring SMTP V3 Signatures, as Resolved.
Tue, Sep 15, 8:03 PM · Mail
epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly as Resolved by committing rP3dfa89dd5d27: Update SES API to use AWSv4 signatures.
Tue, Sep 15, 8:03 PM · Mail
epriestley requested review of D21461: Update SES API to use AWSv4 signatures.
Tue, Sep 15, 4:20 PM
epriestley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

I've marked D21461 as resolving this, since the new errors surface the particulars:

Tue, Sep 15, 4:19 PM · Mail
epriestley added a revision to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: D21461: Update SES API to use AWSv4 signatures.
Tue, Sep 15, 4:15 PM · Mail
epriestley added a revision to T13570: Amazon is retiring SMTP V3 Signatures: D21461: Update SES API to use AWSv4 signatures.
Tue, Sep 15, 4:15 PM · Mail
epriestley edited the content of Dependencies.
Tue, Sep 15, 4:08 PM
epriestley added a subtask for T13570: Amazon is retiring SMTP V3 Signatures: T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.
Tue, Sep 15, 4:08 PM · Mail
epriestley added a parent task for T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: T13570: Amazon is retiring SMTP V3 Signatures.
Tue, Sep 15, 4:08 PM · Mail

Tue, Sep 8

epriestley requested review of D21460: When a commit is marked "closeable", clear the "published" flag.
Tue, Sep 8, 8:43 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21460: When a commit is marked "closeable", clear the "published" flag.
Tue, Sep 8, 8:42 PM · Differential
epriestley requested review of D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Tue, Sep 8, 8:17 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Tue, Sep 8, 8:16 PM · Differential
epriestley added a revision to T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Tue, Sep 8, 8:15 PM · Daemons
epriestley requested review of D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Tue, Sep 8, 7:56 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Tue, Sep 8, 7:55 PM · Differential
epriestley triaged T13580: Make "fully imported" a separate commit bit or standalone flag, not a complex bitmask operation as Wishlist priority.
Tue, Sep 8, 7:49 PM · Diffusion
epriestley closed T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Resolved.
  • D21457 fixes approximately 20 additional errors identified by the linter in phabricator/.
Tue, Sep 8, 6:48 PM · Arcanist
epriestley committed rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions (authored by epriestley).
Fix a false negative in lint for "xsprintf()"-family functions
Tue, Sep 8, 6:46 PM