Page MenuHomePhabricator
Feed All Stories

Today

epriestley added a comment to T2794: Implement Phage (like Hypershell).

The non-public parts of Phage are currently very specific to Phacility's cluster and probably not generally useful. The current version of PhageRemoteWorkflow is similar to P2107 and depends on particular Phacility services and hosts to enumerate valid remotes and negotiate a connection to them through a bastion pool. These service-listing and bastion-host components are not generalized and not trivially generalizable.

Thu, Oct 21, 8:00 PM · Phage, Infrastructure
emiraga added a comment to T2794: Implement Phage (like Hypershell).

It seem to me like certain parts of phage are not published in a public repo. Are there plans to open up missing pieces?

Thu, Oct 21, 6:37 PM · Phage, Infrastructure

Tue, Oct 19

epriestley added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".
  1. As Alice, commandeer a revision authored by Baliey and reviewed by Claire. Edit it locally to do arbitrary bad things, then git push it.
  2. Make a commit, edit the commit message to say Differential Revision: D1234, where D1234 is a current, valid, accepted revision authored by anyone, then git push it.
Tue, Oct 19, 6:25 PM · Differential
epriestley added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

I believe it is extremely difficult to configure Phabricator to provide the assurance you describe, particularly if arc land does anything. If you are actually providing this guarantee ("an attacker needs two machines"), you can likely add a clause to the large amount of custom code you've written to prevent self-foisting while still supporting other foisting use cases. If you haven't written a large amount of custom code, I suspect an attacker can fairly easily deploy with one machine without using "Foist Upon".

Tue, Oct 19, 6:18 PM · Differential
ptarjan added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

Is there a way to disable this feature? Our security team has noticed that with this feature we can land code with just a single person's machine being compromised (we rely on an attacker needing two machines to deploy code as a safety mechanism). I.e. You make a revision, Foist it on someone, Approve it, then arc land it as the other person (saying y to the prompt).

Tue, Oct 19, 5:48 PM · Differential
cspeckmim added a comment to D21724: Update Mercurial's cascading of commit sets to rebase non-landed commits.

Just making a note that I did test git a while back and saw behavior that I wasn't expecting; I haven't had a chance to dig further into this. I'm not super familiar with how to visualize the commit graph in git to confirm this but I believe what happened is a graph that looked like this

A  B
| /
C
|
D  (master)
Tue, Oct 19, 2:51 AM

Sun, Oct 3

0 published D21725: Hide event start times on subsequent days for review.
Sun, Oct 3, 10:45 PM · Calendar

Fri, Oct 1

epriestley added a comment to D21425: Streamline handling of Futures and PIDs in daemons.

The Future stuff is used on both the client and server, so it lives in Arcanist rather than Phabricator. The method definition should be here:

Fri, Oct 1, 9:49 PM
jmeador added inline comments to D21425: Streamline handling of Futures and PIDs in daemons.
Fri, Oct 1, 9:25 PM

Tue, Sep 28

epriestley added a comment to T13588: PHP 8 Compatibility.

See also T12404#256288 for a note on each removal.

Tue, Sep 28, 2:41 PM · Infrastructure
epriestley added a comment to T12404: Implement a first-party SMTP client.

each is usually easy to replace and I'm happy to accept a change to replace it if someone wants to reproduce/test it. I believe this (totally ridiculous) construction:

Tue, Sep 28, 2:40 PM · Infrastructure, Mail
avivey added a comment to T13588: PHP 8 Compatibility.

From https://discourse.phabricator-community.org/t/sending-emails-causes-an-exception/4966, looks like the PHPMailer uses each which is removed in php 8.

Tue, Sep 28, 7:57 AM · Infrastructure
avivey added a comment to T12404: Implement a first-party SMTP client.

From https://discourse.phabricator-community.org/t/sending-emails-causes-an-exception/4966, it appears that both class.smtp.php and class.phpmailer-lite.php have calls to each which is removed in PHP 8.

Tue, Sep 28, 7:55 AM · Infrastructure, Mail

Fri, Sep 24

cspeckmim planned changes to D21724: Update Mercurial's cascading of commit sets to rebase non-landed commits.

Marking Plan Changes until I test this out in Git

Fri, Sep 24, 4:05 PM

Thu, Sep 23

cspeckmim updated the diff for D21724: Update Mercurial's cascading of commit sets to rebase non-landed commits.

Remove the $obsolete_map and $rebasedActiveCommit and just use $rebasedCommitMap

Thu, Sep 23, 3:39 AM
cspeckmim planned changes to D21724: Update Mercurial's cascading of commit sets to rebase non-landed commits.
Thu, Sep 23, 3:23 AM
cspeckmim requested review of D21724: Update Mercurial's cascading of commit sets to rebase non-landed commits.
Thu, Sep 23, 3:09 AM
cspeckmim added a revision to T13668: Landing a string of dependent revisions which contains branched commits will result in stripping/pruning those branched commits: D21724: Update Mercurial's cascading of commit sets to rebase non-landed commits.
Thu, Sep 23, 3:09 AM · Mercurial, Arcanist

Wed, Sep 22

cspeckmim updated the task description for T13668: Landing a string of dependent revisions which contains branched commits will result in stripping/pruning those branched commits.
Wed, Sep 22, 2:10 AM · Mercurial, Arcanist
cspeckmim created T13668: Landing a string of dependent revisions which contains branched commits will result in stripping/pruning those branched commits.
Wed, Sep 22, 2:06 AM · Mercurial, Arcanist

Sep 18 2021

cspeckmim added a comment to D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.

The second baby has arrived

aw smile.png (100×100 px, 6 KB)
dancing duck.gif (280×498 px, 2 MB)

Sep 18 2021, 2:02 AM

Sep 17 2021

epriestley added a comment to D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.

The second baby has arrived so I have about 17 seconds per day to look at my computer nowadays, but I think it would also be reasonable to backfill str_starts_with() if you run into more of this -- the strncmp() syntax has always felt pretty hard to read to me. You can do that in PHP like this:

Sep 17 2021, 1:02 PM
cspeckmim closed D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.
Sep 17 2021, 3:03 AM
cspeckmim committed rARCa028291f8e5e: Make corrections to the "arc amend" workflow in Mercurial repositories to be… (authored by cspeckmim).
Make corrections to the "arc amend" workflow in Mercurial repositories to be…
Sep 17 2021, 3:03 AM
cspeckmim retitled D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+ from Make corrections to the "arc amend" workflow used with Mercurial repositories to Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.
Sep 17 2021, 3:02 AM
cspeckmim updated the summary of D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.
Sep 17 2021, 3:01 AM
epriestley accepted D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.
Sep 17 2021, 2:20 AM

Sep 16 2021

cspeckmim updated the diff for D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.

Switch to using strncmp()

Sep 16 2021, 6:57 PM
cspeckmim requested review of D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.
Sep 16 2021, 6:55 PM
cspeckmim added a revision to T13665: The "arc amend" workflow does not work on Mercurial repositories: D21723: Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+.
Sep 16 2021, 6:54 PM · Mercurial, Arcanist
cspeckmim added inline comments to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.
Sep 16 2021, 6:35 PM

Sep 14 2021

cspeckmim updated the task description for T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing.
Sep 14 2021, 9:59 PM · Arcanist, Mercurial
cspeckmim updated the task description for T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing.
Sep 14 2021, 9:55 PM · Arcanist, Mercurial
cspeckmim created T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing.
Sep 14 2021, 9:49 PM · Arcanist, Mercurial

Sep 13 2021

epriestley added inline comments to D21680: An assortment of fixes and updates to using arc-land with mercurial.
Sep 13 2021, 9:28 PM
cspeckmim added inline comments to D21680: An assortment of fixes and updates to using arc-land with mercurial.
Sep 13 2021, 5:58 PM

Sep 7 2021

cspeckmim retitled D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling from Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to adjust it to Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.
Sep 7 2021, 6:02 PM

Sep 5 2021

cspeckmim closed T13665: The "arc amend" workflow does not work on Mercurial repositories as Resolved by committing rARCd246a0656259: Update ArcanistMercurialAPI to support getting the current commit ref.
Sep 5 2021, 7:25 PM · Mercurial, Arcanist
cspeckmim closed D21716: Update ArcanistMercurialAPI to support getting the current commit ref.
Sep 5 2021, 7:25 PM
cspeckmim committed rARCd246a0656259: Update ArcanistMercurialAPI to support getting the current commit ref (authored by cspeckmim).
Update ArcanistMercurialAPI to support getting the current commit ref
Sep 5 2021, 7:25 PM
cspeckmim added a comment to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

I played around with this some more and this feels pretty solid for resolving most common symbols. I'll poke around some of the mercurial source a bit later this week and see if I can find an easy way for resolving revset/symbols easily though a custom extension.

Sep 5 2021, 6:01 PM
cspeckmim updated the diff for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Don't bother trying to lookup bookmark/tag names when the symbol is a number as Mercurial disallows this. Also fix the revision number mapping which somehow worked? But still does now...

Sep 5 2021, 5:48 PM
cspeckmim updated the test plan for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.
Sep 5 2021, 5:34 PM
cspeckmim updated the diff for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Fix not being able to lookup commit by symbol 0

Sep 5 2021, 5:33 PM
cspeckmim updated the diff for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Include support for revision number and hash-prefix symbols

Sep 5 2021, 5:16 PM
cspeckmim added a comment to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

The "symbol" here could, in the absolute-most-general case, be a short commit hash (abcd1234) or symbolic commit (tip^^^) -- not just a bookmark or tag name -- so I think this trick (though quite clever) may run into trouble some day.

Oh yea... hmm I think it's possible to include support for commit hashes (or prefixes) as well as revision ID -- I'll try out a change real quick to see if it's simple to include support for those symbols at least. Any relativity modifiers ^^ I think are effectively impossible to handle without resorting to individual hg log commands or an extension

Sep 5 2021, 4:36 PM
epriestley accepted D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

The "symbol" here could, in the absolute-most-general case, be a short commit hash (abcd1234) or symbolic commit (tip^^^) -- not just a bookmark or tag name -- so I think this trick (though quite clever) may run into trouble some day. This looks like a reasonable fix to the immediate issue, though, and we can cross this bridge if/when we come to it.

Sep 5 2021, 3:29 PM
cspeckmim updated the diff for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

More-correct formatting for the revset

Sep 5 2021, 7:10 AM
cspeckmim updated the diff for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Update the revsets used to work around potentially invalid symbols from preventing all symbols from resolving

Sep 5 2021, 7:05 AM
cspeckmim added a comment to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Ooh actually it looks like this will work

$ hg log --revset "bookmark('re:^symbol$') or tag('re:^symbol$')"

Doing that doesn't fail if the symbol doesn't exist

Sep 5 2021, 6:45 AM
cspeckmim added a comment to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Hmm could maybe do something like hg log --rev 'bookmark() or tag() or .' to just get every commit that has a potential symbol and then process those. It would end up getting more results than necessary in every case. The query runs relatively quickly (~230ms) on our ~128k commit repository but it only has ~550 tags which I'm guessing is low -- if we tagged every build we'd have ~15k.

Sep 5 2021, 6:32 AM
cspeckmim added a comment to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Not yet handling the case where an invalid symbol results in failing to lookup any symbols

I didn't see any obvious way of doing this through revsets but I'll try some more experiments. An extension that adds a template keyword, or just a new command for this, might also be an option

Sep 5 2021, 6:11 AM
cspeckmim updated the summary of D21716: Update ArcanistMercurialAPI to support getting the current commit ref.
Sep 5 2021, 6:04 AM
cspeckmim planned changes to D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Not yet handling the case where an invalid symbol results in failing to lookup any symbols

Sep 5 2021, 6:01 AM
cspeckmim updated the diff for D21716: Update ArcanistMercurialAPI to support getting the current commit ref.

Provide implementation of ArcanistMercurialCommitSymbolCommitHardpointQuery to enable hardpoint queries for commit symbols.

Sep 5 2021, 6:00 AM
cspeckmim closed D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.
Sep 5 2021, 1:22 AM
cspeckmim committed rARCcd17e8441214: Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to… (authored by cspeckmim).
Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to…
Sep 5 2021, 1:22 AM
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

So that part is correct, but swapping the commit and branch was incidental, and I overlooked it because we usually get the same result: in common cases, this is moot because ancestors(<branch name>) is equivalent to ancestors(<heads of that branch>), and branch(<commit hash>) is equivalent to branch(<branch of that commit>). The latter is always equivalent; the former is equivalent when commit is the single head of branch, which it almost always is in regular use.

But this behavior (on this install) is unambiguously wrong:

Screen Shot 2021-09-04 at 5.28.41 PM.png (1×2 px, 407 KB)

...since b7be5c961297 (the parameter) is an ancestor of 162a9c1e8e44 (the first commit in the result set). I'll send you a diff.

Sep 5 2021, 1:21 AM · Diffusion
epriestley committed rPb9ba0418ed13: Correct a parameter order swap in "diffusion.historyquery" for Mercurial (authored by epriestley).
Correct a parameter order swap in "diffusion.historyquery" for Mercurial
Sep 5 2021, 1:16 AM
epriestley closed D21722: Correct a parameter order swap in "diffusion.historyquery" for Mercurial.
Sep 5 2021, 1:16 AM
epriestley accepted D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.
Sep 5 2021, 1:16 AM
cspeckmim added a comment to D21722: Correct a parameter order swap in "diffusion.historyquery" for Mercurial.

Thanks for checking this out

Sep 5 2021, 1:09 AM
cspeckmim accepted D21722: Correct a parameter order swap in "diffusion.historyquery" for Mercurial.
Sep 5 2021, 1:09 AM
cspeckmim added a comment to D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

Err, I updated the error message after running those cases so it no longer says "Failed liberating:" but "Failed to update library:"

Sep 5 2021, 1:08 AM
cspeckmim requested review of D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

Sorry I made a side-stop checking out the error-handling behavior from ArcanistLiberateWorkflow - I made some updates so it can detect the failure to avoid indicating success.

Sep 5 2021, 1:06 AM
cspeckmim updated the diff for D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

Update error handling of ArcanistLiberateWorkflow to detect failure from running rebuild-map.php in a separate process.

Sep 5 2021, 1:02 AM
epriestley requested review of D21722: Correct a parameter order swap in "diffusion.historyquery" for Mercurial.
Sep 5 2021, 12:48 AM
epriestley added a revision to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations: D21722: Correct a parameter order swap in "diffusion.historyquery" for Mercurial.
Sep 5 2021, 12:47 AM · Diffusion
epriestley accepted D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

Thanks!

Sep 5 2021, 12:45 AM
cspeckmim updated the diff for D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

Remove log() entirely, let filesystem errors escape outwardly.

Sep 5 2021, 12:40 AM
epriestley added a comment to D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

I think it's reasonable to remove the try/catch and just let the exception escape. It (the try-catch + log) isn't consistent with the approach to error handling in the rest of the codebase, and I can't think of any valid reason to continue here after a write failure.

Sep 5 2021, 12:38 AM
cspeckmim closed D21719: Fix searching legalpad documents by contributors.
Sep 5 2021, 12:37 AM
cspeckmim committed rP3b2868e15553: Fix searching legalpad documents by contributors (authored by cspeckmim).
Fix searching legalpad documents by contributors
Sep 5 2021, 12:37 AM
cspeckmim requested review of D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.
Sep 5 2021, 12:36 AM
cspeckmim updated the summary of D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.
Sep 5 2021, 12:36 AM
cspeckmim added inline comments to D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.
Sep 5 2021, 12:32 AM
epriestley added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

Good catch!

Sep 5 2021, 12:30 AM · Diffusion
cspeckmim updated the diff for D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

Change approach - remove --verbose, remove --quiet, remove most instances of log() being used, keep the instance when an error is encountered.

Sep 5 2021, 12:29 AM
epriestley accepted D21719: Fix searching legalpad documents by contributors.

Thanks!

Sep 5 2021, 12:17 AM

Sep 4 2021

cspeckmim closed T13634: Support marking commits as UNREACHABLE in Mercurial as Resolved.
Sep 4 2021, 11:55 PM · Diffusion
cspeckmim retitled D21719: Fix searching legalpad documents by contributors from Fix typo in legalpad search engine to Fix searching legalpad documents by contributors.
Sep 4 2021, 11:51 PM
cspeckmim published D21719: Fix searching legalpad documents by contributors for review.

I didn't make a task for this as it's a fairly small change and the reproduction/test case is also fairly simple.

Sep 4 2021, 11:11 PM
cspeckmim committed rP09c3c7d87931: Add support to marking commits as UNREACHABLE for Mercurial (authored by cspeckmim).
Add support to marking commits as UNREACHABLE for Mercurial
Sep 4 2021, 11:05 PM
cspeckmim closed D21715: Add support to marking commits as UNREACHABLE for Mercurial.
Sep 4 2021, 11:05 PM
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

One tangential thing I noticed from the error messages in these cases, in DiffusionHistoryQueryConduitAPIMethod the getMercurialResult() function executes this hg command

$path_args = array();
if (strlen($path)) {
  $path_args[] = $path;
  $revset_arg = hgsprintf(
    'reverse(ancestors(%s))',
    $commit_hash);
} else {
  $revset_arg = hgsprintf(
    'reverse(ancestors(%s)) and branch(%s)',
    $drequest->getBranch(),
    $commit_hash);
}
Sep 4 2021, 11:03 PM · Diffusion
cspeckmim closed T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations as Resolved.
Sep 4 2021, 10:51 PM · Diffusion
cspeckmim committed rP458ad4a8617a: Remove history query from DiffusionRepositoryController as it is unused (authored by cspeckmim).
Remove history query from DiffusionRepositoryController as it is unused
Sep 4 2021, 10:51 PM
cspeckmim closed D21717: Remove history query from DiffusionRepositoryController as it is unused.
Sep 4 2021, 10:50 PM
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

With just the updates to the future handling this is now the landing page I see with missing commits:

Screen Shot 2021-09-04 at 6.33.54 PM.png (948×3 px, 180 KB)

Sep 4 2021, 10:50 PM · Diffusion
cspeckmim added a comment to D21717: Remove history query from DiffusionRepositoryController as it is unused.

I tested this out and it works properly, in that there's no noticeable difference between the behavior with this change and without but including the new future updates

Sep 4 2021, 10:48 PM
cspeckmim updated the diff for D21717: Remove history query from DiffusionRepositoryController as it is unused.

Sigh maybe update arcanist too. I ran arc lint before arc diff and it said no lints...

Sep 4 2021, 10:47 PM
cspeckmim updated the diff for D21717: Remove history query from DiffusionRepositoryController as it is unused.

Try again but with arcanist on master

Sep 4 2021, 10:44 PM
cspeckmim updated the diff for D21717: Remove history query from DiffusionRepositoryController as it is unused.

Rebased onto changes (no merge needed tho)

Sep 4 2021, 10:42 PM
cspeckmim retitled D21717: Remove history query from DiffusionRepositoryController as it is unused from Update DiffusionRepositoryController to use appropriate error handling, remove history query to Remove history query from DiffusionRepositoryController as it is unused.
Sep 4 2021, 10:41 PM
cspeckmim added a comment to D21717: Remove history query from DiffusionRepositoryController as it is unused.

I'm working on testing out the issue before/after this change

Sep 4 2021, 10:23 PM
cspeckmim planned changes to D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

I'll do that

Sep 4 2021, 9:38 PM
epriestley accepted D21717: Remove history query from DiffusionRepositoryController as it is unused.

This looks great to me now, as long as I didn't miss anything with the Future stuff and it does what it's supposed to on top of D21720 + D21721.

Sep 4 2021, 9:38 PM
epriestley committed rPb757e5c30249: Use "MethodCallFuture" to move Diffusion Conduit exceptions to resolution time (authored by epriestley).
Use "MethodCallFuture" to move Diffusion Conduit exceptions to resolution time
Sep 4 2021, 9:36 PM
epriestley closed D21721: Use "MethodCallFuture" to move Diffusion Conduit exceptions to resolution time.
Sep 4 2021, 9:36 PM
epriestley accepted D21718: Update "arc liberate" to fix error with PHP 8, remove logging, modify error handling.

I'd favor this change:

Sep 4 2021, 9:35 PM