Page MenuHomePhabricator
Feed All Stories

Today

joshuaspence requested review of D20481: Apply custom fields implemented using edges to apply validation logic.
Fri, Apr 26, 4:19 AM

Yesterday

epriestley added a comment to D20480: Update Quickstart SQL.

Also, before regenerating this I disabled all the Phacility extensions. Otherwise, we get dumps of instances/ tables and such.

Thu, Apr 25, 10:57 PM
epriestley requested review of D20480: Update Quickstart SQL.
Thu, Apr 25, 10:56 PM
epriestley requested review of D20479: Make very minor generality improvements to the scope selector.
Thu, Apr 25, 10:33 PM
epriestley requested review of D20478: When building a synthetic diff in Differential, adjust diff properties correctly.
Thu, Apr 25, 10:11 PM
epriestley updated the task description for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Thu, Apr 25, 10:11 PM · Arcanist, Differential
epriestley requested review of D20477: Improve the performance of tab replacement in common cases.
Thu, Apr 25, 9:39 PM
epriestley requested review of D20476: Really fix movable panels inside tab panels by changing the JX.Request serializer.
Thu, Apr 25, 7:06 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20476: Really fix movable panels inside tab panels by changing the JX.Request serializer.
Thu, Apr 25, 7:04 PM · Dashboards
epriestley requested review of D20475: Add "Move Left" and "Move Right" to dashboard tab panels.
Thu, Apr 25, 6:41 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20475: Add "Move Left" and "Move Right" to dashboard tab panels.
Thu, Apr 25, 6:39 PM · Dashboards
epriestley requested review of D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.
Thu, Apr 25, 6:07 PM
epriestley added a revision to T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel: D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.
Thu, Apr 25, 6:05 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.
Thu, Apr 25, 6:05 PM · Dashboards
epriestley requested review of D20473: Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel.
Thu, Apr 25, 5:40 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20473: Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel.
Thu, Apr 25, 5:38 PM · Dashboards
epriestley requested review of D20472: Resore "Limit" to dashboard Query panels.
Thu, Apr 25, 5:35 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20472: Resore "Limit" to dashboard Query panels.
Thu, Apr 25, 5:34 PM · Dashboards
epriestley committed rPc0a4d1de13a8: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker (authored by epriestley).
Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker
Thu, Apr 25, 4:46 PM
epriestley closed D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Thu, Apr 25, 4:46 PM
epriestley added a comment to D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.

so these will tasks will permanently

Thu, Apr 25, 4:44 PM
epriestley added inline comments to D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Thu, Apr 25, 4:43 PM
avivey added a comment to T9530: Release Server / Workflow app / Future of Releeph .

To those still interested, Spinnaker (OSS from Netflix + Google) is targeting the Deployment part of this flow (everything after a Release Candidate is created).
It only handled "cloud" deployments, and offers as much complexity as you can ever want, including "Wait for human approval", Canary deployments, blue-green, etc.

Thu, Apr 25, 4:41 PM · Restricted Project, Harbormaster
epriestley updated the diff for D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
  • Improve help text.
Thu, Apr 25, 4:37 PM
epriestley added a comment to D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.

I think it's a little unfair to remove this and the similar warning [about running the daemons] back on line 22.

Thu, Apr 25, 4:36 PM
epriestley committed rP0fab41ff3c07: Show "hold reasons" on commit page, not on "Edit" page (authored by epriestley).
Show "hold reasons" on commit page, not on "Edit" page
Thu, Apr 25, 4:23 PM
epriestley closed D20466: Show "hold reasons" on commit page, not on "Edit" page.
Thu, Apr 25, 4:22 PM
epriestley requested review of D20471: Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button.
Thu, Apr 25, 3:13 PM
epriestley closed T9821: Allow Harbormaster build plans to run on branch push instead of per-commit as Wontfix.

Please use the Discourse forum for this kind of discussion.

Thu, Apr 25, 2:42 PM · Restricted Project, Harbormaster
pasik added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

Gentle ping here again :) Has anyone managed to get a webhook triggered on a phabricator git repo, once-per-push, not once-per-each-commit ?

Thu, Apr 25, 8:24 AM · Restricted Project, Harbormaster

Wed, Apr 24

epriestley committed rP8f43c773b832: Remove nearly all remaining references to "Autoclose" (authored by epriestley).
Remove nearly all remaining references to "Autoclose"
Wed, Apr 24, 3:29 PM
epriestley closed D20465: Remove nearly all remaining references to "Autoclose".
Wed, Apr 24, 3:29 PM
epriestley committed rP45b9859f0229: Remove "--force-autoclose" from "bin/repository reparse" (authored by epriestley).
Remove "--force-autoclose" from "bin/repository reparse"
Wed, Apr 24, 3:24 PM
epriestley closed D20464: Remove "--force-autoclose" from "bin/repository reparse".
Wed, Apr 24, 3:24 PM
epriestley committed rPa2d3d8edeb93: Move "update related object after commit" to a separate worker in the task queue (authored by epriestley).
Move "update related object after commit" to a separate worker in the task queue
Wed, Apr 24, 1:32 PM
epriestley closed D20463: Move "update related object after commit" to a separate worker in the task queue.
Wed, Apr 24, 1:32 PM
epriestley added inline comments to D20463: Move "update related object after commit" to a separate worker in the task queue.
Wed, Apr 24, 1:02 PM
epriestley committed rPb3b1cc64bdd0: When applying transactions, acquire a read lock sooner (authored by epriestley).
When applying transactions, acquire a read lock sooner
Wed, Apr 24, 12:57 PM
Herald updated subscribers of T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Wed, Apr 24, 12:57 PM · Plans, Differential, Harbormaster
epriestley closed D20462: When applying transactions, acquire a read lock sooner.
Wed, Apr 24, 12:57 PM
epriestley committed rP42c02557e4e3: Remove all remaining readers and writers for TABLE_COMMIT (authored by epriestley).
Remove all remaining readers and writers for TABLE_COMMIT
Wed, Apr 24, 12:55 PM
epriestley closed D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Wed, Apr 24, 12:55 PM
epriestley committed rPec0085fd0c7a: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table (authored by epriestley).
Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Wed, Apr 24, 12:54 PM
epriestley closed D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Wed, Apr 24, 12:54 PM
epriestley committed rP7e8dc0742bdc: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()" (authored by epriestley).
Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Wed, Apr 24, 12:53 PM
epriestley closed D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Wed, Apr 24, 12:53 PM
epriestley updated the diff for D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
  • Typechecking.
Wed, Apr 24, 12:47 PM
epriestley committed rPfc92cf438225: Move BlameController away from ancient "TABLE_COMMIT" (authored by epriestley).
Move BlameController away from ancient "TABLE_COMMIT"
Wed, Apr 24, 12:44 PM
epriestley closed D20457: Move BlameController away from ancient "TABLE_COMMIT".
Wed, Apr 24, 12:44 PM
amckinley accepted D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Wed, Apr 24, 4:10 AM
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Wed, Apr 24, 2:02 AM · Differential, Plans
epriestley added a comment to D20462: When applying transactions, acquire a read lock sooner.

I think that's reasonable -- if there are at least, say, 11 consecutive lines affected only by the same indentation level change (or the line is blank), we could show the first 3, fold the middle 5+, then show the last 3.

Wed, Apr 24, 2:00 AM
epriestley added a comment to D20466: Show "hold reasons" on commit page, not on "Edit" page.

!== 0 and !== mask have different meanings when mask has multiple bits set. Today, IMPORTED_CLOSEABLE has just one bit set, so both tests would do the same thing. But the adjacent IMPORTED_ALL mask has several, and using the more general form is safer if IMPORTED_CLOSEABLE ever has multiple bits, or this code gets copy/pasted elsewhere or something.

Wed, Apr 24, 1:59 AM
amckinley accepted D20466: Show "hold reasons" on commit page, not on "Edit" page.
Wed, Apr 24, 1:01 AM
amckinley accepted D20465: Remove nearly all remaining references to "Autoclose".
Wed, Apr 24, 12:47 AM
amckinley accepted D20464: Remove "--force-autoclose" from "bin/repository reparse".
Wed, Apr 24, 12:32 AM
amckinley accepted D20463: Move "update related object after commit" to a separate worker in the task queue.
Wed, Apr 24, 12:32 AM
jmeador added inline comments to D20462: When applying transactions, acquire a read lock sooner.
Wed, Apr 24, 12:09 AM

Tue, Apr 23

amckinley accepted D20462: When applying transactions, acquire a read lock sooner.
Tue, Apr 23, 8:03 PM
epriestley closed T13274: Guide: Overheated Queries as Resolved.

(This seems stable now, and there's no specific action here.)

Tue, Apr 23, 7:34 PM · Infrastructure, Guides
epriestley committed rP70c643c685f8: Simplify implementation of "pure" Chart functions (authored by epriestley).
Simplify implementation of "pure" Chart functions
Tue, Apr 23, 7:30 PM
epriestley closed D20446: Simplify implementation of "pure" Chart functions.
Tue, Apr 23, 7:29 PM
epriestley committed rPedaf17f3fe51: Make chart function argument parsing modular/flexible with 900 pages of error… (authored by epriestley).
Make chart function argument parsing modular/flexible with 900 pages of error…
Tue, Apr 23, 7:26 PM
epriestley closed D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
Tue, Apr 23, 7:26 PM
epriestley updated the diff for D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
  • Typo fix.
Tue, Apr 23, 7:21 PM
epriestley committed rPedda40aa3b93: (stable) Change "Revision Close" story to use commit identities only with no… (authored by epriestley).
(stable) Change "Revision Close" story to use commit identities only with no…
Tue, Apr 23, 6:58 PM
epriestley committed rP7b8ac020b521: Change "Revision Close" story to use commit identities only with no fallback to… (authored by epriestley).
Change "Revision Close" story to use commit identities only with no fallback to…
Tue, Apr 23, 6:57 PM
epriestley closed D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Tue, Apr 23, 6:57 PM
epriestley committed rP2ffc4be4e7df: (stable) Fix "before/after" cursor paging for API call "feed.query" (authored by epriestley).
(stable) Fix "before/after" cursor paging for API call "feed.query"
Tue, Apr 23, 6:57 PM
epriestley committed rPb0b8926c7564: Fix "before/after" cursor paging for API call "feed.query" (authored by epriestley).
Fix "before/after" cursor paging for API call "feed.query"
Tue, Apr 23, 6:51 PM
epriestley closed D20456: Fix "before/after" cursor paging for API call "feed.query".
Tue, Apr 23, 6:51 PM
epriestley committed rP29b2125e3f29: (stable) Fix an issue where internal paging of notifications could fail if some… (authored by epriestley).
(stable) Fix an issue where internal paging of notifications could fail if some…
Tue, Apr 23, 6:45 PM
epriestley committed rPa4a1143b1888: Fix an issue where internal paging of notifications could fail if some… (authored by epriestley).
Fix an issue where internal paging of notifications could fail if some…
Tue, Apr 23, 6:45 PM
epriestley closed D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Tue, Apr 23, 6:45 PM
epriestley requested review of D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).
Tue, Apr 23, 6:37 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).
Tue, Apr 23, 6:35 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to D20468: Consolidate readers of "differential.revisionID" property.

One note here is that HeraldPreCommitContentAdapter has some similar logic, although it's more low-level.

Tue, Apr 23, 6:08 PM
epriestley requested review of D20469: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions.
Tue, Apr 23, 6:07 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20469: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions.
Tue, Apr 23, 6:05 PM · Diffusion, Harbormaster, Herald, Audit
amckinley accepted D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Tue, Apr 23, 5:49 PM
amckinley accepted D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Tue, Apr 23, 5:48 PM
epriestley added a comment to D20468: Consolidate readers of "differential.revisionID" property.

The "how do we store this data" question kind of relates back to T13056. This is a case where we have edge-like data (Commit Has Related Revision) but we also have metadata (why the two are associated). This currently isn't stored as edge data, but a possibly cleaner approach would be:

Tue, Apr 23, 5:38 PM
epriestley updated the summary of D20468: Consolidate readers of "differential.revisionID" property.
Tue, Apr 23, 5:30 PM
epriestley requested review of D20468: Consolidate readers of "differential.revisionID" property.
Tue, Apr 23, 5:30 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20468: Consolidate readers of "differential.revisionID" property.
Tue, Apr 23, 5:28 PM · Plans, Diffusion
amckinley accepted D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Tue, Apr 23, 5:19 PM
amckinley added inline comments to D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Tue, Apr 23, 5:18 PM
amckinley accepted D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Tue, Apr 23, 5:14 PM
epriestley requested review of D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Tue, Apr 23, 4:56 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Tue, Apr 23, 4:55 PM · Plans, Diffusion
amckinley accepted D20457: Move BlameController away from ancient "TABLE_COMMIT".
Tue, Apr 23, 4:30 PM
amckinley accepted D20456: Fix "before/after" cursor paging for API call "feed.query".
Tue, Apr 23, 4:29 PM
amckinley accepted D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Tue, Apr 23, 4:28 PM
epriestley updated the task description for T13280: Permanent Refs Errata.
Tue, Apr 23, 4:28 PM · Diffusion
epriestley added a comment to D20436: Make the "git upload-pack" proxy more robust.

The reproduction case for this may be "have a ref which is an annotated tag". Let me see if that works.

Tue, Apr 23, 2:56 PM
epriestley added a comment to D20436: Make the "git upload-pack" proxy more robust.

There's not much of a wire-proto.c to reference. Here's the code that generates the entire thing we're parsing (in Git 2.21-rc1):

Tue, Apr 23, 2:51 PM
epriestley requested review of D20466: Show "hold reasons" on commit page, not on "Edit" page.
Tue, Apr 23, 2:15 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20466: Show "hold reasons" on commit page, not on "Edit" page.
Tue, Apr 23, 2:14 PM · Plans, Diffusion
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

PHI1159 would like build failures exposed to Herald to trigger audits. See also PHI953. See also PHI901.

Tue, Apr 23, 1:39 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

In PHI1008, when commit X reverts commit Y, we don't write a revert edge between X and revisions associated with Y. We should.

Tue, Apr 23, 1:32 PM · Diffusion, Harbormaster, Herald, Audit