Page MenuHomePhabricator
Feed All Stories

Yesterday

epriestley closed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given" as Resolved.

I deployed D21062, and the three examples in the original report look good now. I checked about a dozen other pages and couldn't find anything else broken; let me know if I missed anything. Thanks for the report!

Mon, Apr 6, 7:02 PM · Diviner
epriestley committed rP58fbf64a2786: Refine handling of "@task" attributes in Diviner (authored by epriestley).
Refine handling of "@task" attributes in Diviner
Mon, Apr 6, 6:51 PM
epriestley closed D21062: Refine handling of "@task" attributes in Diviner.
Mon, Apr 6, 6:51 PM
epriestley requested review of D21062: Refine handling of "@task" attributes in Diviner.
Mon, Apr 6, 6:51 PM
epriestley added a revision to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given": D21062: Refine handling of "@task" attributes in Diviner.
Mon, Apr 6, 6:50 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

The second issue is that the API still returns a string when there is exactly one @attribute of a given type. This is a bit goofy; PhutilExecChannel is another example case.

Mon, Apr 6, 6:47 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

I deployed D21061. First two example pages are good now, third one is hitting a different error. New trace is:

Mon, Apr 6, 6:45 PM · Diviner
aklapper awarded T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given" a Like token.
Mon, Apr 6, 6:43 PM · Diviner
epriestley committed rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API (authored by epriestley).
Update DivinerAtomController for a long-ago change to the docblock parser API
Mon, Apr 6, 6:31 PM
epriestley closed D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Mon, Apr 6, 6:31 PM
epriestley requested review of D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Mon, Apr 6, 6:22 PM
epriestley added a revision to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given": D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Mon, Apr 6, 6:21 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

Docblocks may have multiple copies of the same @attribute directive, like this:

Mon, Apr 6, 6:19 PM · Diviner
epriestley claimed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Mon, Apr 6, 6:11 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

Here's the full stack trace:

Mon, Apr 6, 6:11 PM · Diviner
epriestley committed rARC33dc2fe8194d: Allow "phage" to print execution status on SIGINT (authored by epriestley).
Allow "phage" to print execution status on SIGINT
Mon, Apr 6, 6:09 PM
epriestley closed D21060: Allow "phage" to print execution status on SIGINT.
Mon, Apr 6, 6:09 PM
epriestley requested review of D21060: Allow "phage" to print execution status on SIGINT.
Mon, Apr 6, 6:09 PM
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: D21060: Allow "phage" to print execution status on SIGINT.
Mon, Apr 6, 6:08 PM · Arcanist
aklapper created T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Mon, Apr 6, 2:36 PM · Diviner
epriestley closed T13499: Make "undefined index" PHP errors throw a RuntimeException as Resolved.

One long-standing warning in a unit test cropped up (D21055) but if this does have far-reaching implications, they don't seem terribly obvious/common.

Mon, Apr 6, 2:26 PM · Infrastructure
epriestley closed T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as Resolved.

Character encoding issues aren't stable yet (see also T13500) but I think everything else here is.

Mon, Apr 6, 2:25 PM · Windows

Sun, Apr 5

Harbormaster failed to build B23994: rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol for rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol!
Sun, Apr 5, 4:47 PM
epriestley committed rP088dfdb586df: (stable) Whitelist "vscode://" as an allowed Editor protocol (authored by epriestley).
(stable) Whitelist "vscode://" as an allowed Editor protocol
Sun, Apr 5, 4:47 PM
Harbormaster failed to build B23993: rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline… for rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline…!
Sun, Apr 5, 4:38 PM
epriestley committed rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline… (authored by epriestley).
(stable) Add an "isDone" flag to "transaction.search" for Differential inline…
Sun, Apr 5, 4:37 PM
epriestley committed rPf1d1ec3d77f1: Add an "isDone" flag to "transaction.search" for Differential inline comments (authored by epriestley).
Add an "isDone" flag to "transaction.search" for Differential inline comments
Sun, Apr 5, 4:36 PM
epriestley closed D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments.
Sun, Apr 5, 4:36 PM
epriestley requested review of D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments.
Sun, Apr 5, 4:05 PM
sshannin added a comment to T13488: Upgrading: Early 2020 Changes to Arcanist.

The new method of installing the shell completion seems to error out for me with EXCEPTION: (Error) Call to undefined method ArcanistShellCompleteWorkflow::getPrompt() on a fresh install:

Sun, Apr 5, 3:47 PM · Arcanist, Installing & Upgrading
epriestley committed rARC32005f26a4e7: Move Phage to FuturePool (authored by epriestley).
Move Phage to FuturePool
Sun, Apr 5, 12:56 PM
epriestley closed D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:56 PM
epriestley requested review of D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:51 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21058: Move Phage to FuturePool.
Sun, Apr 5, 12:50 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist

Sat, Apr 4

JoggerTech added inline comments to D21057: If daemon running-as-user setup check fails its query, don't bother with it.
Sat, Apr 4, 12:23 AM

Fri, Apr 3

Harbormaster failed to build B23988: rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother… for rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother…!
Fri, Apr 3, 11:29 PM
epriestley committed rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother… (authored by epriestley).
(stable) If daemon running-as-user setup check fails its query, don't bother…
Fri, Apr 3, 11:29 PM
Harbormaster failed to build B23985: rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref… for rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref…!
Fri, Apr 3, 11:28 PM
epriestley committed rP33b73d887ae3: If daemon running-as-user setup check fails its query, don't bother with it (authored by epriestley).
If daemon running-as-user setup check fails its query, don't bother with it
Fri, Apr 3, 11:19 PM
epriestley closed D21057: If daemon running-as-user setup check fails its query, don't bother with it.
Fri, Apr 3, 11:19 PM
epriestley requested review of D21057: If daemon running-as-user setup check fails its query, don't bother with it.
Fri, Apr 3, 11:13 PM
Harbormaster failed to build B23985: rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref… for rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref…!
Fri, Apr 3, 8:29 PM
epriestley committed rP2dfe5d6218f6: Improve performance when marking commits as unreachable after multiple ref… (authored by epriestley).
Improve performance when marking commits as unreachable after multiple ref…
Fri, Apr 3, 8:29 PM
epriestley committed rP1e7cc72cd835: Improve performance when marking commits as unreachable after multiple ref… (authored by epriestley).
Improve performance when marking commits as unreachable after multiple ref…
Fri, Apr 3, 8:28 PM
epriestley closed D21056: Improve performance when marking commits as unreachable after multiple ref deletions.
Fri, Apr 3, 8:28 PM
epriestley requested review of D21056: Improve performance when marking commits as unreachable after multiple ref deletions.
Fri, Apr 3, 8:28 PM
epriestley committed rP1a59cae743c2: Update some Phabricator behaviors for changes to Futures (authored by epriestley).
Update some Phabricator behaviors for changes to Futures
Fri, Apr 3, 7:28 PM
epriestley closed D21054: Update some Phabricator behaviors for changes to Futures.
Fri, Apr 3, 7:28 PM
epriestley requested review of D21054: Update some Phabricator behaviors for changes to Futures.
Fri, Apr 3, 7:27 PM
Harbormaster failed to build B23980: rP067b04aaf148: If HTTP response headers are already sent, don't fiddle with "zlib. for rP067b04aaf148: If HTTP response headers are already sent, don't fiddle with "zlib.!
Fri, Apr 3, 7:25 PM
epriestley committed rP067b04aaf148: If HTTP response headers are already sent, don't fiddle with "zlib. (authored by epriestley).
If HTTP response headers are already sent, don't fiddle with "zlib.
Fri, Apr 3, 7:25 PM
epriestley closed D21055: If HTTP response headers are already sent, don't fiddle with "zlib.output_compression".
Fri, Apr 3, 7:25 PM
epriestley requested review of D21055: If HTTP response headers are already sent, don't fiddle with "zlib.output_compression".
Fri, Apr 3, 7:22 PM
epriestley committed rARC099c2ae64845: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures (authored by epriestley).
Introduce "FuturePool" to make it easier to manage an ongoing pool of futures
Fri, Apr 3, 7:05 PM
epriestley closed D21053: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures.
Fri, Apr 3, 7:05 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21054: Update some Phabricator behaviors for changes to Futures.
Fri, Apr 3, 7:03 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley requested review of D21053: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures.
Fri, Apr 3, 6:57 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21053: Introduce "FuturePool" to make it easier to manage an ongoing pool of futures.
Fri, Apr 3, 6:56 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

XHPAST currently can't build an AST for $result = yield ..., even though this is a valid construct. This is probably a straightforward fix.

Fri, Apr 3, 2:38 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley removed 1 auditor(s) for rARC4d55067fd87f: Make the "result" property on Future private: epriestley.
Fri, Apr 3, 2:03 PM
artms edited 2 auditor(s) for rARC4d55067fd87f: Make the "result" property on Future private, removed 1: artms; added 1: epriestley.
Fri, Apr 3, 1:53 PM
artms raised a concern with rARC4d55067fd87f: Make the "result" property on Future private.

This is breaking commit breaks drydock: PHP Fatal error: Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-75/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50

Fri, Apr 3, 1:40 PM

Thu, Apr 2

epriestley added a comment to T13500: During startup, guarantee "(string)1.23" is "1.23", not "1,23".

See also T13209.

Thu, Apr 2, 11:32 PM · Arcanist
epriestley committed rARC368aec16a1ee: Update some ancient "set X=Y" environment code for new Windows execution… (authored by epriestley).
Update some ancient "set X=Y" environment code for new Windows execution…
Thu, Apr 2, 8:51 PM
epriestley closed D21052: Update some ancient "set X=Y" environment code for new Windows execution without a shell.
Thu, Apr 2, 8:51 PM
epriestley requested review of D21052: Update some ancient "set X=Y" environment code for new Windows execution without a shell.
Thu, Apr 2, 8:44 PM
epriestley committed rARCd4d095dbf692: Make Windows escaping preserve "%" symbols in arguments (authored by epriestley).
Make Windows escaping preserve "%" symbols in arguments
Thu, Apr 2, 8:44 PM
epriestley closed D21051: Make Windows escaping preserve "%" symbols in arguments.
Thu, Apr 2, 8:44 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D21052: Update some ancient "set X=Y" environment code for new Windows execution without a shell.
Thu, Apr 2, 8:44 PM · Arcanist, Windows
epriestley added a revision to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: D21052: Update some ancient "set X=Y" environment code for new Windows execution without a shell.
Thu, Apr 2, 8:44 PM · Windows
epriestley requested review of D21051: Make Windows escaping preserve "%" symbols in arguments.
Thu, Apr 2, 7:41 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D21051: Make Windows escaping preserve "%" symbols in arguments.
Thu, Apr 2, 7:40 PM · Arcanist, Windows
epriestley added a revision to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: D21051: Make Windows escaping preserve "%" symbols in arguments.
Thu, Apr 2, 7:40 PM · Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

See also:

Thu, Apr 2, 7:35 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

See also:

Thu, Apr 2, 6:12 PM · Arcanist, Windows
epriestley added a project to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: Windows.
Thu, Apr 2, 6:12 PM · Windows
epriestley committed rARC5ce1d7971746: Fix error behavior of "arc version" when it encounters a library which is not a… (authored by epriestley).
Fix error behavior of "arc version" when it encounters a library which is not a…
Thu, Apr 2, 3:24 PM
epriestley closed D21050: Fix error behavior of "arc version" when it encounters a library which is not a working copy.
Thu, Apr 2, 3:24 PM
epriestley requested review of D21050: Fix error behavior of "arc version" when it encounters a library which is not a working copy.
Thu, Apr 2, 3:20 PM
epriestley added a revision to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: D21050: Fix error behavior of "arc version" when it encounters a library which is not a working copy.
Thu, Apr 2, 3:20 PM · Windows
epriestley reopened T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as "Open".

PHI1667 has a couple of adjacent issues that I think aren't fully covered here.

Thu, Apr 2, 3:13 PM · Windows
artms added inline comments to D21034: Make the "result" property on Future private.
Thu, Apr 2, 2:54 PM
artms added inline comments to D21034: Make the "result" property on Future private.
Thu, Apr 2, 2:54 PM

Wed, Apr 1

epriestley committed rARC63276697eb8c: Fix three Windows subprocess issues (authored by epriestley).
Fix three Windows subprocess issues
Wed, Apr 1, 11:11 PM
epriestley closed T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as Resolved by committing rARC63276697eb8c: Fix three Windows subprocess issues.
Wed, Apr 1, 11:11 PM · Windows
epriestley closed D21047: Fix three Windows subprocess issues.
Wed, Apr 1, 11:11 PM
epriestley requested review of D21047: Fix three Windows subprocess issues.
Wed, Apr 1, 11:06 PM
epriestley added a revision to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: D21047: Fix three Windows subprocess issues.
Wed, Apr 1, 11:06 PM · Windows
epriestley added a comment to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable.

This may partly have arisen from changes to Future behavior, not just bypass_shell changes. In particular, ExecFuture already had approximately the desired behavior, but was documented like this:

Wed, Apr 1, 10:58 PM · Windows
epriestley added a comment to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable.

A subproblem here is that start <url> fails on Windows with bypass_shell. The likely fix is to make cmd /c start, not start, the default "browser" on Windows.

Wed, Apr 1, 10:41 PM · Windows
epriestley added a comment to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable.

Another possibility is to do a Filesystem::binaryExists() functional test on the subprocess binary, assume the failure is "missing binary" if that test fails, and assume the failure is catastrophic otherwise.

Wed, Apr 1, 10:37 PM · Windows
epriestley triaged T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as Normal priority.
Wed, Apr 1, 10:36 PM · Windows
jparise edited the content of Community Resources.
Wed, Apr 1, 10:09 PM
epriestley committed rARC492113370aa8: Fix two issues with Future key selection inside FutureIterator (authored by epriestley).
Fix two issues with Future key selection inside FutureIterator
Wed, Apr 1, 5:36 PM
epriestley closed D21046: Fix two issues with Future key selection inside FutureIterator.
Wed, Apr 1, 5:36 PM
epriestley requested review of D21046: Fix two issues with Future key selection inside FutureIterator.
Wed, Apr 1, 5:34 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21046: Fix two issues with Future key selection inside FutureIterator.
Wed, Apr 1, 5:33 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Wed, Apr 1, 1:50 PM · Lint, Arcanist

Mon, Mar 30

epriestley committed rARCb1a712add815: Integrate "ServiceProfiler" into the base "Future" (authored by epriestley).
Integrate "ServiceProfiler" into the base "Future"
Mon, Mar 30, 2:42 PM
epriestley closed D21038: Integrate "ServiceProfiler" into the base "Future".
Mon, Mar 30, 2:42 PM