Page MenuHomePhabricator
Feed All Stories

Fri, Jan 15

ptarjan added a comment to T3277: `arc cleanup` to cleanup branches used by `arc patch`.

grep -v master | grep -v '^[0-9a-f.]*$'

This part may prove slightly trickier to implement correctly in the general case.

Fri, Jan 15, 7:52 PM · Arcanist
epriestley added a comment to T3277: `arc cleanup` to cleanup branches used by `arc patch`.

grep -v master | grep -v '^[0-9a-f.]*$'

Fri, Jan 15, 7:50 PM · Arcanist
ptarjan added a comment to T3277: `arc cleanup` to cleanup branches used by `arc patch`.

+1 for this command. We have use a web-based UI for landing so our branches stick around locally. To fix this I'm currently using:

arc branches | grep ' Closed ' | sed 's/[^ ]* //' | sed 's/ .*//' | grep -v master | grep -v '^[0-9a-f.]*$' | xargs git br -D
Fri, Jan 15, 7:41 PM · Arcanist
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Fri, Jan 15, 6:45 PM · Security, Git
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Fri, Jan 15, 6:44 PM · Security, Git
epriestley removed a project from T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Security.
Fri, Jan 15, 6:44 PM · Security, Git

Thu, Jan 14

aleb added a comment to T12404: Implement a first-party SMTP client.

Recently smtp-relay.gmail.com stopped accepting email from our Phabricator instance because it turns out Phabricator was sending HELO localhost.localdomain instead of HELO smtp-relay.gmail.com when doing the SMTP connection.

Thu, Jan 14, 6:45 PM · Infrastructure, Mail

Wed, Jan 13

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 9:38 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 9:01 PM · Accessibility, Differential
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Wed, Jan 13, 8:39 PM · Harbormaster
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 8:33 PM · Accessibility, Differential
epriestley committed rPea9cb0b625fb: Disambiguate Git ref selectors in some Git command line invocations (authored by epriestley).
Disambiguate Git ref selectors in some Git command line invocations
Wed, Jan 13, 8:31 PM
epriestley closed D21510: Disambiguate Git ref selectors in some Git command line invocations.
Wed, Jan 13, 8:31 PM
epriestley closed D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Wed, Jan 13, 8:31 PM
epriestley committed rARCb2e715fc5a9c: Provide "gitsprintf(...)" and disambiguate Git ref selectors (authored by epriestley).
Provide "gitsprintf(...)" and disambiguate Git ref selectors
Wed, Jan 13, 8:31 PM
artms added inline comments to D14148: Allow Drydock leases to expire after a time limit.
Wed, Jan 13, 1:34 PM

Tue, Jan 12

epriestley updated the diff for D21510: Disambiguate Git ref selectors in some Git command line invocations.
  • Include fix for a "blame" callsite.
Tue, Jan 12, 8:43 PM
epriestley requested review of D21510: Disambiguate Git ref selectors in some Git command line invocations.
Tue, Jan 12, 8:13 PM
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21510: Disambiguate Git ref selectors in some Git command line invocations.
Tue, Jan 12, 8:11 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Tue, Jan 12, 8:10 PM · Security, Git
epriestley requested review of D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Tue, Jan 12, 8:10 PM
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Tue, Jan 12, 8:09 PM · Security, Git
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I'm not completely thrilled about maintaining PHP builtin webserver support...

Tue, Jan 12, 7:11 PM · Infrastructure
epriestley triaged T13589: Git may interpret refnames as flags in some commands which accept both refs and paths as Normal priority.
Tue, Jan 12, 6:26 PM · Security, Git
epriestley committed rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes (authored by epriestley).
Support "control" and "return/enter" in the remarkup rule for keystrokes
Tue, Jan 12, 3:47 AM
epriestley closed D21508: Support "control" and "return/enter" in the remarkup rule for keystrokes.
Tue, Jan 12, 3:47 AM
epriestley requested review of D21508: Support "control" and "return/enter" in the remarkup rule for keystrokes.
Tue, Jan 12, 3:44 AM

Mon, Jan 11

epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I added M1, etc., to the ignored list in D21507.

Mon, Jan 11, 8:16 PM · Infrastructure
epriestley closed T13575: PHP built-in webserver fails on POST as Resolved.

I think this is now resolved. I'm not completely thrilled about maintaining PHP builtin webserver support because I think use is very limited, but since I'm currently using it I expect to support it at least until I summon the nerve to deal with Homebrew.

Mon, Jan 11, 8:14 PM · Infrastructure
epriestley added a task to D20903: Ensure __path__ is set on POST requests when running on CLI webserver: T13575: PHP built-in webserver fails on POST.
Mon, Jan 11, 6:59 PM
epriestley added a revision to T13575: PHP built-in webserver fails on POST: D20903: Ensure __path__ is set on POST requests when running on CLI webserver.
Mon, Jan 11, 6:59 PM · Infrastructure
epriestley abandoned D20903: Ensure __path__ is set on POST requests when running on CLI webserver.

See T13575. This change should be obsoleted by D21506.

Mon, Jan 11, 6:58 PM
epriestley commandeered D20903: Ensure __path__ is set on POST requests when running on CLI webserver.
Mon, Jan 11, 6:55 PM
epriestley updated the summary of D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:55 PM
epriestley committed rP18f049a282f4: Fix reading of the request path when running the PHP builtin webserver (authored by epriestley).
Fix reading of the request path when running the PHP builtin webserver
Mon, Jan 11, 6:54 PM
epriestley closed D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:54 PM
epriestley committed rP04c1f67a020c: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list (authored by epriestley).
Add "M<digit>" and "P<digit>" to the default Remarkup ignore list
Mon, Jan 11, 6:54 PM
epriestley closed D21507: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.
Mon, Jan 11, 6:54 PM
epriestley requested review of D21507: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.
Mon, Jan 11, 6:52 PM
epriestley added a revision to T13575: PHP built-in webserver fails on POST: D21507: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.
Mon, Jan 11, 6:51 PM · Infrastructure
epriestley requested review of D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:36 PM
epriestley added a revision to T13575: PHP built-in webserver fails on POST: D21506: Fix reading of the request path when running the PHP builtin webserver.
Mon, Jan 11, 6:34 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

Guess I should probably add M1 to the remarkup blocklist now.

Mon, Jan 11, 5:52 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I switched to an M1 Mac Mini on Big Sur, which has motivated me somewhat to try to get this working since I suspect doing another install through Homebrew on M1 silicon will be more adventure than I have stomach for.

Mon, Jan 11, 5:45 PM · Infrastructure
epriestley claimed T13575: PHP built-in webserver fails on POST.
Mon, Jan 11, 5:43 PM · Infrastructure
jrtc27 closed D21504: Fix pyflakes tests for recent pyflakes versions.
Mon, Jan 11, 4:52 AM
jrtc27 committed rARC172381260ee7: Fix pyflakes tests for recent pyflakes versions (authored by jrtc27).
Fix pyflakes tests for recent pyflakes versions
Mon, Jan 11, 4:52 AM
jrtc27 closed D21503: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint.
Mon, Jan 11, 4:51 AM
jrtc27 committed rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint (authored by jrtc27).
Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint
Mon, Jan 11, 4:51 AM
jrtc27 closed D21502: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8.
Mon, Jan 11, 4:50 AM
jrtc27 committed rARCf64eb04300b4: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8 (authored by jrtc27).
Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8
Mon, Jan 11, 4:50 AM
jrtc27 closed D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.
Mon, Jan 11, 4:50 AM
jrtc27 committed rARC9589fd18662f: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8 (authored by jrtc27).
Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8
Mon, Jan 11, 4:50 AM
jrtc27 updated the diff for D21504: Fix pyflakes tests for recent pyflakes versions.

Rebased patch series

Mon, Jan 11, 4:49 AM
epriestley accepted D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.
Mon, Jan 11, 4:48 AM
jrtc27 updated the diff for D21503: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint.

Rebased patch series

Mon, Jan 11, 4:48 AM
jrtc27 updated the diff for D21502: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8.

Rebased patch series

Mon, Jan 11, 4:47 AM
jrtc27 updated the summary of D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.
Mon, Jan 11, 4:46 AM
jrtc27 updated the diff for D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.

Catch Throwable in the test rather than converting to Exception inside phutil_utf8_convert

Mon, Jan 11, 4:45 AM
epriestley accepted rARC90ac9a2ff281: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

See D21500 for discussion, the test failure was an interaction between callbacks specified in C::m form and $callback() inside xsprintf() under old versions of PHP. Resolved by D21505.

Mon, Jan 11, 4:41 AM
jrtc27 closed D21505: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500.
Mon, Jan 11, 4:40 AM
jrtc27 committed rARC687cb41ace6c: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500 (authored by jrtc27).
Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500
Mon, Jan 11, 4:40 AM
epriestley accepted D21505: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500.
Mon, Jan 11, 4:40 AM
jrtc27 requested review of D21505: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500.
Mon, Jan 11, 4:39 AM
epriestley added a comment to T13588: PHP 8 Compatibility.

So I don't forget:

Mon, Jan 11, 4:33 AM · Infrastructure
jrtc27 added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Ah even better.

Mon, Jan 11, 4:31 AM
epriestley added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Oh, or the array('C', 'm') version appears to work properly when invoked as $callback in all versions of PHP since PHP 5.4:

Mon, Jan 11, 4:31 AM
jrtc27 added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

https://3v4l.org/eYFoc does work for 5.2.2+ to pass by reference, provided which arguments are passed by reference is part of the contract. But probably best to keep it simple and define xsprintf_test_callback as you say.

Mon, Jan 11, 4:30 AM
epriestley added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Oh, I think the reason to use $callback(...) is the behavior of the reference parameters. Yikes.

Mon, Jan 11, 4:25 AM
epriestley added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Here's some evidence to support that theory:

Mon, Jan 11, 4:21 AM
epriestley added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Ah, I think the issue is that xsprintf() internally does this :

Mon, Jan 11, 4:19 AM
jrtc27 updated the diff for D21504: Fix pyflakes tests for recent pyflakes versions.

Stay under 80 characters (and format the other long preg_match a bit more nicely)

Mon, Jan 11, 4:12 AM
epriestley accepted D21504: Fix pyflakes tests for recent pyflakes versions.

See T10038 for general context.

Mon, Jan 11, 4:09 AM
jrtc27 added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Hm, Harbormaster is failing with:

Fatal error: Call to undefined function ArcanistFormattedStringXHPASTLinterRule::processXsprintfCallback() in /core/data/drydock/workingcopy-70/repo/arcanist/src/xsprintf/xsprintf.php on line 70

Does referencing static functions not work in old PHP versions or something? I tested with 7.4 and it was fine.

Mon, Jan 11, 4:08 AM
Harbormaster failed to build B24990: rARC90ac9a2ff281: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8 for rARC90ac9a2ff281: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8!
Mon, Jan 11, 4:05 AM
jrtc27 closed D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.
Mon, Jan 11, 4:05 AM
jrtc27 committed rARC90ac9a2ff281: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8 (authored by jrtc27).
Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8
Mon, Jan 11, 4:05 AM
jrtc27 committed rARC0adef03fdfee: Fix PhutilTypeSpec's regex handling for PHP 8 (authored by jrtc27).
Fix PhutilTypeSpec's regex handling for PHP 8
Mon, Jan 11, 4:04 AM
jrtc27 closed D21499: Fix PhutilTypeSpec's regex handling for PHP 8.
Mon, Jan 11, 4:04 AM
jrtc27 requested review of D21504: Fix pyflakes tests for recent pyflakes versions.
Mon, Jan 11, 4:03 AM
epriestley added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

Oh, I'm totally onboard with this change -- I think this behavior is generally better than the old behavior and the property of getting the input string out is useful/clever, just trying to save future-me a minute or two if this breaks and I end up here via git blame.

Mon, Jan 11, 3:52 AM
epriestley added a comment to D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.

Sounds good. I think it's very unlikely anything is relying on the type of exception thrown, and we would (or, at least, should) normally throw a narrower exception (UTF8ConversionEncodingFailedVeryNarrowlyException) if really trying to make this part of the API.

Mon, Jan 11, 3:47 AM
epriestley accepted D21503: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint.

🤷

Mon, Jan 11, 3:42 AM
epriestley accepted D21499: Fix PhutilTypeSpec's regex handling for PHP 8.

preg_match() in all modern versions of PHP seems to be willing to accept an object with __toString() as the first parameter:

Mon, Jan 11, 3:38 AM
jrtc27 added a comment to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

In the case of hypothetical zsprintf("A %XYZ B", ...), where %XYZ is some multi-character conversion like %Ls, the real zsprintf() would call sprintf("A %s B") internally, while this will call sprintf("A %sYZ B") -- that is, this callback can't know that %XYZ is a single conversion, rather than %X + YZ.

I can't think of any problems this will cause today or any theoretical problems it will cause in the future, and there's no easy way to future-proof it anyway, so I think this is the most reasonable fix.

Mon, Jan 11, 3:38 AM
epriestley accepted D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.

In the case of hypothetical zsprintf("A %XYZ B", ...), where %XYZ is some multi-character conversion like %Ls, the real zsprintf() would call sprintf("A %s B") internally, while this will call sprintf("A %sYZ B") -- that is, this callback can't know that %XYZ is a single conversion, rather than %X + YZ.

Mon, Jan 11, 3:29 AM
jrtc27 added a comment to D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.

Does this just break a test or something?

Mon, Jan 11, 3:29 AM
epriestley requested changes to D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.

Does this just break a test or something?

Mon, Jan 11, 3:18 AM
epriestley accepted D21502: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8.

Thanks!

Mon, Jan 11, 3:01 AM
jrtc27 requested review of D21503: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint.
Mon, Jan 11, 3:00 AM
jrtc27 added a comment to T13588: PHP 8 Compatibility.

With the four revisions I've just added, arc lint works with PHP 8 when run inside the arcanist repo, and arc unit --everything has no regressions compared with PHP 7.4 (both do have a few failures but they're the same and relate to pyflakes/jshint/hg, and look environment-specific so nothing to do with PHP 8).

Mon, Jan 11, 2:24 AM · Infrastructure
jrtc27 added a revision to T13588: PHP 8 Compatibility: D21499: Fix PhutilTypeSpec's regex handling for PHP 8.
Mon, Jan 11, 2:21 AM · Infrastructure
jrtc27 added a task to D21499: Fix PhutilTypeSpec's regex handling for PHP 8: T13588: PHP 8 Compatibility.
Mon, Jan 11, 2:21 AM
jrtc27 added a task to D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8: T13588: PHP 8 Compatibility.
Mon, Jan 11, 2:21 AM
jrtc27 added a revision to T13588: PHP 8 Compatibility: D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.
Mon, Jan 11, 2:21 AM · Infrastructure
jrtc27 added a revision to T13588: PHP 8 Compatibility: D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8.
Mon, Jan 11, 2:20 AM · Infrastructure
jrtc27 added a task to D21501: Fix PhutilUTF8TestCase::testUTF8Convert for PHP 8: T13588: PHP 8 Compatibility.
Mon, Jan 11, 2:20 AM
jrtc27 added a task to D21502: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8: T13588: PHP 8 Compatibility.
Mon, Jan 11, 2:20 AM
jrtc27 added a revision to T13588: PHP 8 Compatibility: D21502: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8.
Mon, Jan 11, 2:20 AM · Infrastructure
jrtc27 requested review of D21502: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8.
Mon, Jan 11, 2:06 AM