Page MenuHomePhabricator
Differential D21572

When mapping phantom comments across changes, correct an off-by-one issue
ClosedPublic
Actions

Authored by epriestley on Feb 21 2021, 5:03 PM.
Tags
None
Referenced Files
F18783132: D21572.id.diff
Mon, Oct 13, 4:05 AM
F18770147: D21572.diff
Wed, Oct 8, 11:02 AM
F18734406: D21572.id.diff
Tue, Sep 30, 10:53 PM
F18626557: D21572.id51355.diff
Sep 16 2025, 1:31 AM
F18595709: D21572.diff
Sep 12 2025, 10:34 PM
F18571646: D21572.id51356.diff
Sep 10 2025, 5:14 AM
F18571644: D21572.id51355.diff
Sep 10 2025, 5:14 AM
F18519471: D21572.diff
Sep 5 2025, 5:24 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13617: Blocks of added lines have an off-by-one error when porting phantom comments
Commits
rP6bfa990254a2: When mapping phantom comments across changes, correct an off-by-one issue
Summary

Ref T13617. When an inline comment is added inside a block of added lines, it currently ends up off-by-one when porting forward.

This is a disagreement between the mapping engine and the display engine about what "offset" means. Choose the simpler of the two interpretations.

Test Plan
  • Created a revision with the diff in T13617.
  • Added an inline in the middle of the added block.
  • Updated the revision with the same diff.
    • Before: inline incorrectly moves up by one line.
    • After: inline maps correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 21 2021, 5:03 PM
Harbormaster completed remote builds in B25164: Diff 51355.Feb 21 2021, 5:04 PM
epriestley requested review of this revision.Feb 21 2021, 5:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2021, 7:08 PM
Closed by commit rP6bfa990254a2: When mapping phantom comments across changes, correct an off-by-one issue (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6bfa990254a2: When mapping phantom comments across changes, correct an off-by-one issue.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
2 lines
storage/
__tests__/
49 lines

Diff 51356

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/parser/DifferentialLineAdjustmentMap.php

Loading...
View Options

src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php

Loading...
Phabricator · Built by Phacility