Page MenuHomePhabricator

Wrap all direct access to author/committer properties on "CommitData"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:42 PM.
Tags
None
Referenced Files
F17756200: D21448.id51084.diff
Tue, Jul 22, 1:51 PM
F17756199: D21448.id51047.diff
Tue, Jul 22, 1:51 PM
F17756012: D21448.id.diff
Tue, Jul 22, 1:32 PM
F17732043: D21448.diff
Sun, Jul 20, 3:51 AM
F17643520: D21448.id51084.diff
Fri, Jul 11, 9:39 PM
Unknown Object (File)
Thu, Jul 3, 1:09 PM
Unknown Object (File)
Sun, Jun 29, 3:03 PM
Unknown Object (File)
Jun 25 2025, 12:25 PM
Subscribers
None

Details

Summary

Ref T13552. Currently, various callers read raw properties off "CommitData" directly. Wrap these in accessors to support storage changes which persist "CommitRef" information instead.

Test Plan
  • Ran "diffusion.querycommits", saw the same data before and after.
  • Looked at a commit, saw authorship information and date.
  • Viewed tags in a repository, saw author information.
  • Ran "rebuild-identities", saw no net effect.
  • Grepped for callers to "getCommitDetail(...)".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.