Page MenuHomePhabricator
Differential D21555

When a reviewer can't see a revision, show it clearly in the reviewer list
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 9:12 PM.
Tags
None
Referenced Files
F15568879: D21555.id51313.diff
Sat, May 3, 10:01 AM
F15544226: D21555.id.diff
Sat, Apr 26, 3:43 AM
F15540794: D21555.diff
Fri, Apr 25, 8:57 AM
F15502622: D21555.id51313.diff
Mon, Apr 14, 2:32 AM
F15470684: D21555.id51313.diff
Apr 5 2025, 12:28 AM
F15467501: D21555.diff
Apr 3 2025, 3:40 PM
F15435898: D21555.diff
Mar 25 2025, 10:48 AM
F15391026: D21555.id51307.diff
Mar 15 2025, 7:53 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits
rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list
Summary

Ref T13602. Similar to subscriber and mention treatments, make it clear when a user doesn't have view permission.

Test Plan

Screen Shot 2021-02-13 at 1.10.59 PM.png (195×393 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 13 2021, 9:12 PM
Harbormaster completed remote builds in B25116: Diff 51307.Feb 13 2021, 9:13 PM
epriestley requested review of this revision.Feb 13 2021, 9:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM
Closed by commit rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
view/
23 lines
phid/
14 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
8 lines

Diff 51313

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/view/phui/PHUIStatusItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-status.css

Loading...
Phabricator · Built by Phacility