Page MenuHomePhabricator

Reviewer not able to see diff
Closed, ResolvedPublic

Description

Based on this policy description:

I expect the following steps should work.

  • Create Project "Reviewers" with Users A, B and C
  • Create a Diff with User A and assign User D to review
  • Set View Policy of revision to project "Reviewers"
  • User D can no longer see revision.

Event Timeline

chad created this task.Aug 4 2017, 10:25 PM

D7150 added this text ("a revision's reviewers can always...") and I said it "wasn't true but would be soon", but never made it true.

The easiest fix here is probably to delete this line of text, since no one appears to have relied on the behavior for almost four years and implementing the behavioral change runs into complicated questions in T4411. It might still be appropriate eventually, but probably best if tackled adjacently to that stuff.

kugel- added a subscriber: kugel-.Aug 5 2017, 8:54 PM

We require the "a revision's reviewers can always..." behavior. Please implement it instead of changing the text.

In our workflow we make reviews private to group projects (they represent departments), via herald. Occasionally we have cross-department reviews in which case the reviewers need access even if they are in another department.

chad added a comment.Aug 5 2017, 9:00 PM

The plan forward here is to correct the text. I will follow up with you on Discourse.