Page MenuHomePhabricator
Create Task
Maniphest T2222

Implement ApplicationTransactions in Differential
Closed, ResolvedPublic
Actions

Description

After T2104, we should move Differential to ApplicationTransactions.

Revisions and Commits

Restricted Differential Revision
rARC Arcanist
D8400rARC7b6b24154b71 Add "Changes Planned" and "In Preparation" states for revisions
rP Phabricator
ClosedD8477 Remove DifferentialComment
ClosedD8476 Clean up various pieces of dead/obsolete Differential code
ClosedD8475 Move lint/unit test warning code forward to Transactions
ClosedD8474 Remove almost all old Differential field code
ClosedD8473 Use PhabricatorObjectListQuery in Herald worker
ClosedD8472 Remove DifferentialFieldSelector
ClosedD8471 Move "close tasks on commit" code out of field specification stuff
ClosedD8470 Remove field selector on Diff view and Revision List View
ClosedD8469 Use CustomFields to power Conduit auxiliary dictionaries
ClosedD8459 Port Differential mail features forward to transactions
D8241rP7987b4b189d5 [Later] Drop legacyCommentID column from DifferentialTransactionComment
D8242rP9c423647d121 Drop DifferentialComment and DifferentialInlineComment
D8356rP1d90577d8c1c Drop old Differential custom field storage
D8203rP490ae05eb892 Drop differential_relationship table
D8468rP77af6be803c7 Remove host/path and test plan enable/disable options
D8456rP1df84168efd9 Remove DifferentialRevisionEditor
D8457rP50331016f718 Modernize commit message tips
D8455rPc68703fbcb27 Perform derived index updates in TransactionEditor
D8454rPa19f49632fd8 Remove willWriteRevision/didWriteRevision hooks
D8453rPfbaa12440eac Use DifferentialRevisionEditor in lipsum
D8449rPae3c1f781939 Perform commit message parsing and construction with new CustomFields
D8452rPa5fbe921b7d2 Use CustomFields in `differential.createrevision`
D8450rP6dd191a3c135 Allow configuration of Differential custom fields
D8451rPd8968755e9d1 Use CustomField for `differential.updaterevision`
D8445rP76577df50614 Extract textual object list parsing from Differential
D8444rPaff34077c52c Move Differential commit message parsing to a separate, tested class
D8443rPf25cce1e695b Remove DifferentialCommentEditor and DifferentialCommentMail
D8442rP1c51ed594065 Use TransactionEditor in differential.createcomment
D8441rPb04f706c0af6 Use TransactionEditor when closing revisions in response to commits
D8427rP49eaa9f8fe4c Use TransactionEditor in Differential mail handling
D8426rP4dfd4944c4dd Don't use CommentEditor in lipsum
D8425rP75514cc0f713 Update `differential.close` to use DifferentialTransactionEditor
D8424rP3dc9afa28dc2 Remove `differential.markcommitted`
D8405rP2ceffadee78a Support Herald rules for new Differential edits
D8404rP84020a363fee Let Herald activation depend on which transactions are being applied, and…
D8403rP4ef87eeac832 Add an explcit "Changes Planned" state for Differential
D8402rP9da6ec208111 Make updates of rejected revisions behave correctly again
D8401rP857e3aee83de Improve ApplicationTransaction behavior for poorly constructed transactions
D8378rP83206242c9dd Clean up some Differential behaviors
D8377rPb383d2c338fa Replace "Edit" controller with "EditPro" controller
D8376rPbca0ad8fdd7f Make "EditPro" controller work with diff updates
D8369rP11c1edfb7431 Implement "words of power" against ApplicationTransactions
D8368rP024c331d2ba3 Improve rendering of new-style Differential comments in feed/notifications
D8367rP647d52f24880 Improve threading of new and old Differential mail
D8364rPa5dbb1fd59ae Make new JIRA Issues field editable
D8362rPba7d67f9175f Use "CommentPro" controller instead of "Comment" controller
D8360rP62143b5455e7 Add modern Unit/Lint field support
D8361rPf6a13fd1c7b1 Use CustomField, not AuxiliaryField, to power RevisionView
D8359rP0b4a6b8bee67 Add Branch and Arcanist Project CustomFields
D8357rP8297c2131cb2 Implement more Differential fields on ApplicationTransaction/CustomField
AuditedD8355rPcd7171ec6e11 Migrate old AuxiliaryField storage to modern CustomField storage
D8354rPee2b6eebaa31 Implement detail views for many Differential fields on ApplicationTransactions
D8346rPcd080b092e20 Use ApplicationTransactions/CustomField to power Differential global search
D8343rP424ba2e58887 Render inline comments in "Pro" mail
D8340rP06fc82a3eeff Mark reviewers as "commented" when they leave a comment
D8339rPa69cca9fbb15 Update overall revision status after reviewers change
D8333rPca8c2c2d11a3 Implement Accept/Reject in ApplicationTransactions, approximately
D8331rPd07292df7fe0 Implement Commandeer action in ApplicationTransactions
D8330rP0f0673b9e526 Remove "dateCommitted" field from DifferentialRevision
D8328rP9292433daebd Implement "Resign" action against ApplicationTransactions
D8307rP4eadcf975ade Implement most Differential actions against ApplicationTransactions
D8306rPd48a88d4cd78 Add inline comment support to "Pro" comment save controller
D8304rPc7d208fda1ed Add a "Pro" version of the Differential comment save controller
D8303rP3a8eb28a074f Send basic email from new ApplicationTransaction editor
D8301rPd94c33b61aa5 Use a more modern design for "no reviewers" warning in Differential
D8293rPa24605432f60 Use standard rendering and controller for Differential subscriptions
D8294rP92ac8b5ad9a5 Make Differential inline comment rendering more consistent and somewhat more…
D8240rP04ba976a04f7 Remove references to legacy comment IDs
D8239rP7a28ca847d7c When there are no events in a timleine, render a single spacer
D8236rP23146f2bb9e7 Render Differential previews through ApplicationTransactions
D8229rP7a96de10f07a Hide seen transactions by default in all modern applications
AuditedrPe88d0f9c42d4 Merge Differential comment migration to ApplicationTransactions
D8224rP7374a0a4d4f5 Fix inline comment links for non-visible comments
D8223rP9afe52de51d7 Provide transaction strings, icons and colors for Differential
D8222rPcb20205aee10 Don't show "edit" links in Differential for now
D8215rP62cb58408346 Use timeline view in Differential and make inlines somewhat usable again
D8217rP348b07a4becf Make Asana bridge work with new Differential transactions
D8218rP015931576330 Add some missing text for Differential inline transactions
D8216rP29918e1bd47f Fix double-rendering of inline comments in mail
AuditedrP0dc73d5d9357 Always provide a valid content source for DifferentialCommentEditor
D8210rP18938b531071 Migrate Differential comments to ApplicationTransactions
D8209rP3092efdc65a4 Reduce reliance on `getRevisionID()` on DifferentialComment
D8208rP143b89286aad Remove unreachable DifferentialRevisionStatsView
D8206rP54ce4a719eb7 Fix issue where new transaction comments can be spread across multiple…
D8202rP8f9b7f419619 Move Differential to proper subscriptions
D8201rP1dbfc56d3588 Write one DifferentialComment per CommentEditor action
D8200rPc65fad3fca0e Separate revision updates into two separate comments
D8199rP8e232a8bf164 Allow Differential Mail to accept multiple comments for one mail
D8196rP305fb3fbd9c1 Migrate all Differential comment text into new storage
D7513rP4f0f95f7b587 Assign PHIDs to all diffs
D7375rP32dd8af9e5d5 Reduce surface area of DifferentialComment API
Restricted Differential RevisionrPf010730e49b0 Migrate all Differential inline comments to ApplicationTransactions
Restricted Differential RevisionrP3cb67480e063 Adjust keys for new Differential inline comment table
Restricted Differential RevisionrP7c2f6f8361c2 Simplify selection of inline comments from RevisionView
Restricted Differential RevisionrP3124838d6567 Undo D6266 (DifferentialComment PHID migration)
Restricted Differential RevisionrPd0da409eb0f8 Fix a mistakenly translated query from D6262
Restricted Differential RevisionrP75fa580f3f3f Add PHIDs to DifferentialComments
Restricted Differential RevisionrP8e8057c6fe8c Add LiskRawMigrationIterator
Restricted Differential RevisionrP6a2ae077915c Abstract access to DifferentialInlineComment behind a Query
Restricted Differential RevisionrP44302d2f07fa Add storage for new Differential transactions and transaction comments
Restricted Differential RevisionrP6a2e27ba8d70 Put all DifferentialComment loading behind DifferentialCommentQuery

Related Objects
Search...

StatusAssignedTask
 DuplicateNoneT7869 Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously)
 ResolvedepriestleyT9456 Evaluate upstream support for third-party build systems
 ResolvedepriestleyT9123 Build Phabricator in Harbormaster (v2)
 ResolvedepriestleyT2543 Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Restricted Maniphest Task
 ResolvedepriestleyT1315 Phacility Launch Status
 ResolvedepriestleyT2795 Phacility (Mid Priority)
 ResolvedchadT2637 Unbeta Pholio
 ResolvedchadT2636 It's difficult to know an inline comment didn't post/save in Pholio
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 OpenNoneT3612 Lightbox v2
Restricted Maniphest Task
 OpenNoneT11332 Present Pholio inline comments in a lightbox
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 DuplicateNoneT2644 Make Pholio work better on mobile
Restricted Maniphest Task
 ResolvedchadT1960 Breadcrumbs or similar UI-navigation for getting back to the ticket overview
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedNoneT1026 Request: ability to select line range for comment via touchscreen
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedhsbT1895 Disable live previews
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedepriestleyT4767 Autoclose and "Fixes/Ref" are too difficult for users to debug
 ResolvedepriestleyT5644 Add controls to prevent `pygmentize` from saturating system resources
 ResolvedepriestleyT5179 Unearth Differential rendering technical debt
 ResolvedjoshuaspenceT1751 Consider ways to improve revert handling
 ResolvedepriestleyT2542 Provide a link from revisions that are blamees to their blamers
 ResolvedbtrahanT3189 [feature request] Tag commits
Restricted Maniphest Task
 ResolvedbtrahanT5875 "Close Revision" and "Merge Task" interactions should be real transactions, not comments
Restricted Maniphest Task
 DuplicateepriestleyT5654 Show more context for inline comments in Differential timeline
 ResolvedepriestleyT2009 Refactor DifferentialChangesetParser to support 1-up views and sanity
Restricted Maniphest Task
 WontfixepriestleyT5742 Add commentor column to "Revision Update History" table
Restricted Maniphest Task
 ResolvedepriestleyT7358 When Replying to an Inline Comment, provide original context in email?
 ResolvedepriestleyT1460 Add "Done" link to an inline comment
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 DuplicateNoneT3959 feed attributes all diff edits to diff owner
 ResolvedepriestleyT2222 Implement ApplicationTransactions in Differential
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedepriestleyT4481 Differential Update Feedback / Rough Edges / Status

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley edited this Maniphest Task.Feb 27 2014, 7:07 PM
epriestley edited this Maniphest Task.Feb 27 2014, 7:19 PM
epriestley edited this Maniphest Task.Feb 27 2014, 8:34 PM
epriestley edited this Maniphest Task.Feb 27 2014, 10:03 PM
epriestley edited this Maniphest Task.Feb 27 2014, 11:05 PM
epriestley edited this Maniphest Task.Feb 27 2014, 11:16 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Feb 28 2014, 12:50 AM
epriestley edited this Maniphest Task.Feb 28 2014, 11:12 PM
epriestley edited this Maniphest Task.Feb 28 2014, 11:20 PM
epriestley edited this Maniphest Task.Feb 28 2014, 11:26 PM
epriestley edited this Maniphest Task.Mar 1 2014, 12:49 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 1 2014, 1:15 AM
epriestley edited this Maniphest Task.Mar 3 2014, 4:36 PM
epriestley edited this Maniphest Task.Mar 5 2014, 1:12 AM
epriestley edited this Maniphest Task.Mar 5 2014, 1:52 AM
epriestley edited this Maniphest Task.Mar 5 2014, 1:55 AM
epriestley edited this Maniphest Task.Mar 5 2014, 2:18 AM
epriestley edited this Maniphest Task.Mar 5 2014, 3:03 AM
epriestley edited this Maniphest Task.Mar 5 2014, 3:53 AM
epriestley edited this Maniphest Task.Mar 5 2014, 6:44 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 5 2014, 6:47 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 5 2014, 8:07 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 6 2014, 4:19 PM
epriestley edited this Maniphest Task.Mar 6 2014, 4:33 PM
epriestley edited this Maniphest Task.Mar 6 2014, 4:37 PM
epriestley edited this Maniphest Task.Mar 6 2014, 5:01 PM
NorthIsUp added a subscriber: NorthIsUp.Mar 6 2014, 7:43 PM
epriestley edited this Maniphest Task.Mar 7 2014, 4:09 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 7 2014, 7:07 PM
epriestley edited this Maniphest Task.Mar 7 2014, 8:04 PM
epriestley edited this Maniphest Task.Mar 7 2014, 8:18 PM
epriestley edited this Maniphest Task.Mar 7 2014, 10:22 PM
epriestley edited this Maniphest Task.Mar 8 2014, 12:01 AM
epriestley edited this Maniphest Task.Mar 8 2014, 1:44 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
Unknown Object (User) added a subscriber: Unknown Object (User).Mar 8 2014, 2:03 PM
Unknown Object (User) added a comment.EditedMar 8 2014, 2:06 PM

xxxxxxx"></''\'\

xxxxxxx"></''\'\xxxxxxx"></''\'\

Macro mushroom: xxxxxxx"></''\'\ xxxxxxx"></''\'\

epriestley added a comment.Mar 8 2014, 2:31 PM

@jablor Please do not penetration test this install. Install your own local copy of Phabricator instead.

epriestley edited this Maniphest Task.Mar 8 2014, 5:01 PM
epriestley edited this Maniphest Task.Mar 8 2014, 5:20 PM
epriestley edited this Maniphest Task.Mar 8 2014, 6:56 PM
epriestley edited this Maniphest Task.Mar 8 2014, 7:29 PM
epriestley edited this Maniphest Task.Mar 8 2014, 7:44 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:04 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:13 PM
chad removed a subscriber: chad.Mar 8 2014, 8:15 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:15 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:20 PM
epriestley edited this Maniphest Task.Mar 8 2014, 10:45 PM
epriestley edited this Maniphest Task.Mar 9 2014, 5:25 PM
epriestley edited this Maniphest Task.Mar 9 2014, 6:27 PM
epriestley edited this Maniphest Task.Mar 9 2014, 6:47 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:41 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:43 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:47 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:58 PM
epriestley edited this Maniphest Task.Mar 9 2014, 8:19 PM
epriestley edited this Maniphest Task.Mar 9 2014, 8:49 PM
epriestley edited this Maniphest Task.Mar 9 2014, 9:53 PM
epriestley edited this Maniphest Task.Mar 11 2014, 8:06 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley closed this task as Resolved.Mar 11 2014, 8:20 PM

I'm going to close this as resolved; there's some various remaining work but it's not directly related to ApplicationTransactions and pretty well covered by other tasks. All the old editors are gone from the codebase and all edits now use ApplicationTransactions. If you run into bugs, T4481 is the best place to follow up (that task is less noisy and more human-readable).

rm added a subscriber: rm.Jun 5 2014, 8:33 PM

https://secure.phabricator.com/conduit/method/differential.getrevisioncomments/ points me to this task, but this doesn't make it clear to me why differential.getrevisioncomments is doomed, or what I might use to replace it.

epriestley added a comment.Jun 5 2014, 8:35 PM

See T5112, maybe.

epriestley added a comment.Jun 5 2014, 8:40 PM

Which is not terribly helpful, I suppose.

It's obsolete and doomed because the format it emits is insufficient to represent modern transaction activity, which now records things like title and test plan edits, comment edits, and so on.

Some more general differential.querytransactions method will eventually replace it, but maybe that will be even more general (transactions.query). I don't have concrete plans on this yet.

epriestley edited this Maniphest Task.Jun 22 2014, 3:12 PM
epriestley edited this Maniphest Task.Jun 22 2014, 3:15 PM
epriestley edited this Maniphest Task.Jun 24 2014, 12:30 PM
epriestley added a commit: rP7987b4b189d5: [Later] Drop legacyCommentID column from DifferentialTransactionComment.Sep 14 2014, 11:29 PM
joshuaspence mentioned this in D9464: Remove the `inlines` workflow.Sep 22 2014, 2:24 PM
epriestley mentioned this in T2795: Phacility (Mid Priority).Oct 3 2014, 4:43 AM
joshuaspence mentioned this in rARCf8be9d7737d1: Remove the `inlines` workflow.Dec 30 2014, 11:46 PM
philip added a subscriber: philip.Jun 21 2015, 8:38 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Aug 28 2015, 8:59 PM
psung added a subscriber: psung.Jun 27 2017, 9:47 PM
Herald added a subscriber: eadler. · View Herald TranscriptJun 27 2017, 9:47 PM
epriestley mentioned this in T13127: Plans: Form Steering Committee For "+/-" Line Indicators.Apr 26 2018, 10:37 PM
Phabricator · Built by Phacility