Page MenuHomePhabricator

Implement ApplicationTransactions in Differential
Closed, ResolvedPublic

Description

After T2104, we should move Differential to ApplicationTransactions.

Revisions and Commits

rARC Arcanist
D8400
rP Phabricator
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
D8241
D8242
D8356
D8203
D8468
D8456
D8457
D8455
D8454
D8453
D8449
D8452
D8450
D8451
D8445
D8444
D8443
D8442
D8441
D8427
D8426
D8425
D8424
D8405
D8404
D8403
D8402
D8401
D8378
D8377
D8376
D8369
D8368
D8367
D8364
D8362
D8360
D8361
D8359
D8357
AuditedD8355
D8354
D8346
D8343
D8340
D8339
D8333
D8331
D8330
D8328
D8307
D8306
D8304
D8303
D8301
D8293
D8294
D8240
D8239
D8236
D8229
Audited
D8224
D8222
D8223
D8215
D8217
D8218
D8216
Audited
D8210
D8209
D8208
D8206
D8202
D8201
D8200
D8199
D8196
D7513
D7375
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Related Objects

StatusAssignedTask
DuplicateNone
Resolvedepriestley
Resolvedepriestley
OpenNone
Resolvedepriestley
Resolvedepriestley
Resolvedchad
Resolvedchad
OpenNone
OpenNone
DuplicateNone
Resolvedchad
ResolvedNone
Resolvedhsb
Resolvedepriestley
Resolvedepriestley
Resolvedepriestley
Resolvedjoshuaspence
Resolvedepriestley
Resolvedbtrahan
Resolvedbtrahan
Duplicateepriestley
Resolvedepriestley
Wontfixepriestley
Resolvedepriestley
Resolvedepriestley
DuplicateNone
Resolvedepriestley
Resolvedepriestley

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley edited this Maniphest Task.Feb 27 2014, 7:07 PM
epriestley edited this Maniphest Task.Feb 27 2014, 7:19 PM
epriestley edited this Maniphest Task.Feb 27 2014, 8:34 PM
epriestley edited this Maniphest Task.Feb 27 2014, 10:03 PM
epriestley edited this Maniphest Task.Feb 27 2014, 11:05 PM
epriestley edited this Maniphest Task.Feb 27 2014, 11:16 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Feb 28 2014, 12:50 AM
epriestley edited this Maniphest Task.Feb 28 2014, 11:12 PM
epriestley edited this Maniphest Task.Feb 28 2014, 11:20 PM
epriestley edited this Maniphest Task.Feb 28 2014, 11:26 PM
epriestley edited this Maniphest Task.Mar 1 2014, 12:49 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 1 2014, 1:15 AM
epriestley edited this Maniphest Task.Mar 3 2014, 4:36 PM
epriestley edited this Maniphest Task.Mar 5 2014, 1:12 AM
epriestley edited this Maniphest Task.Mar 5 2014, 1:52 AM
epriestley edited this Maniphest Task.Mar 5 2014, 1:55 AM
epriestley edited this Maniphest Task.Mar 5 2014, 2:18 AM
epriestley edited this Maniphest Task.Mar 5 2014, 3:03 AM
epriestley edited this Maniphest Task.Mar 5 2014, 3:53 AM
epriestley edited this Maniphest Task.Mar 5 2014, 6:44 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 5 2014, 6:47 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 5 2014, 8:07 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 6 2014, 4:19 PM
epriestley edited this Maniphest Task.Mar 6 2014, 4:33 PM
epriestley edited this Maniphest Task.Mar 6 2014, 4:37 PM
epriestley edited this Maniphest Task.Mar 6 2014, 5:01 PM
epriestley edited this Maniphest Task.Mar 7 2014, 4:09 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 7 2014, 7:07 PM
epriestley edited this Maniphest Task.Mar 7 2014, 8:04 PM
epriestley edited this Maniphest Task.Mar 7 2014, 8:18 PM
epriestley edited this Maniphest Task.Mar 7 2014, 10:22 PM
epriestley edited this Maniphest Task.Mar 8 2014, 12:01 AM
epriestley edited this Maniphest Task.Mar 8 2014, 1:44 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
Unknown Object (User) added a subscriber: Unknown Object (User).Mar 8 2014, 2:03 PM
Unknown Object (User) added a comment.EditedMar 8 2014, 2:06 PM

xxxxxxx"></''\'\

xxxxxxx"></''\'\xxxxxxx"></''\'\

Macro mushroom: xxxxxxx"></''\'\ xxxxxxx"></''\'\

@jablor Please do not penetration test this install. Install your own local copy of Phabricator instead.

epriestley edited this Maniphest Task.Mar 8 2014, 5:01 PM
epriestley edited this Maniphest Task.Mar 8 2014, 5:20 PM
epriestley edited this Maniphest Task.Mar 8 2014, 6:56 PM
epriestley edited this Maniphest Task.Mar 8 2014, 7:29 PM
epriestley edited this Maniphest Task.Mar 8 2014, 7:44 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:04 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:13 PM
chad removed a subscriber: chad.Mar 8 2014, 8:15 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:15 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:20 PM
epriestley edited this Maniphest Task.Mar 8 2014, 10:45 PM
epriestley edited this Maniphest Task.Mar 9 2014, 5:25 PM
epriestley edited this Maniphest Task.Mar 9 2014, 6:27 PM
epriestley edited this Maniphest Task.Mar 9 2014, 6:47 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:41 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:43 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:47 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:58 PM
epriestley edited this Maniphest Task.Mar 9 2014, 8:19 PM
epriestley edited this Maniphest Task.Mar 9 2014, 8:49 PM
epriestley edited this Maniphest Task.Mar 9 2014, 9:53 PM
epriestley edited this Maniphest Task.Mar 11 2014, 8:06 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley closed this task as Resolved.Mar 11 2014, 8:20 PM

I'm going to close this as resolved; there's some various remaining work but it's not directly related to ApplicationTransactions and pretty well covered by other tasks. All the old editors are gone from the codebase and all edits now use ApplicationTransactions. If you run into bugs, T4481 is the best place to follow up (that task is less noisy and more human-readable).

rm added a subscriber: rm.Jun 5 2014, 8:33 PM

https://secure.phabricator.com/conduit/method/differential.getrevisioncomments/ points me to this task, but this doesn't make it clear to me why differential.getrevisioncomments is doomed, or what I might use to replace it.

Which is not terribly helpful, I suppose.

It's obsolete and doomed because the format it emits is insufficient to represent modern transaction activity, which now records things like title and test plan edits, comment edits, and so on.

Some more general differential.querytransactions method will eventually replace it, but maybe that will be even more general (transactions.query). I don't have concrete plans on this yet.

epriestley edited this Maniphest Task.Jun 22 2014, 3:12 PM
epriestley edited this Maniphest Task.Jun 22 2014, 3:15 PM
epriestley edited this Maniphest Task.Jun 24 2014, 12:30 PM
philip added a subscriber: philip.Jun 21 2015, 8:38 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Aug 28 2015, 8:59 PM
psung added a subscriber: psung.Jun 27 2017, 9:47 PM