Page MenuHomePhabricator
Create Task
Maniphest T2222

Implement ApplicationTransactions in Differential
Closed, ResolvedPublic
Actions

Description

After T2104, we should move Differential to ApplicationTransactions.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

StatusAssignedTask
 DuplicateNoneT7869 Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously)
 ResolvedepriestleyT9456 Evaluate upstream support for third-party build systems
 ResolvedepriestleyT9123 Build Phabricator in Harbormaster (v2)
 ResolvedepriestleyT2543 Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Restricted Maniphest Task
 ResolvedepriestleyT1315 Phacility Launch Status
 ResolvedepriestleyT2795 Phacility (Mid Priority)
 ResolvedchadT2637 Unbeta Pholio
 ResolvedchadT2636 It's difficult to know an inline comment didn't post/save in Pholio
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 OpenNoneT3612 Lightbox v2
Restricted Maniphest Task
 OpenNoneT11332 Present Pholio inline comments in a lightbox
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 DuplicateNoneT2644 Make Pholio work better on mobile
Restricted Maniphest Task
 ResolvedchadT1960 Breadcrumbs or similar UI-navigation for getting back to the ticket overview
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedNoneT1026 Request: ability to select line range for comment via touchscreen
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedhsbT1895 Disable live previews
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedepriestleyT4767 Autoclose and "Fixes/Ref" are too difficult for users to debug
 ResolvedepriestleyT5644 Add controls to prevent `pygmentize` from saturating system resources
 ResolvedepriestleyT5179 Unearth Differential rendering technical debt
 ResolvedjoshuaspenceT1751 Consider ways to improve revert handling
 ResolvedepriestleyT2542 Provide a link from revisions that are blamees to their blamers
 ResolvedbtrahanT3189 [feature request] Tag commits
Restricted Maniphest Task
 ResolvedbtrahanT5875 "Close Revision" and "Merge Task" interactions should be real transactions, not comments
Restricted Maniphest Task
 DuplicateepriestleyT5654 Show more context for inline comments in Differential timeline
 ResolvedepriestleyT2009 Refactor DifferentialChangesetParser to support 1-up views and sanity
Restricted Maniphest Task
 WontfixepriestleyT5742 Add commentor column to "Revision Update History" table
Restricted Maniphest Task
 ResolvedepriestleyT7358 When Replying to an Inline Comment, provide original context in email?
 ResolvedepriestleyT1460 Add "Done" link to an inline comment
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 DuplicateNoneT3959 feed attributes all diff edits to diff owner
 ResolvedepriestleyT2222 Implement ApplicationTransactions in Differential
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedepriestleyT4481 Differential Update Feedback / Rough Edges / Status

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley edited this Maniphest Task.Feb 27 2014, 7:07 PM
epriestley edited this Maniphest Task.Feb 27 2014, 7:19 PM
epriestley edited this Maniphest Task.Feb 27 2014, 8:34 PM
epriestley edited this Maniphest Task.Feb 27 2014, 10:03 PM
epriestley edited this Maniphest Task.Feb 27 2014, 11:05 PM
epriestley edited this Maniphest Task.Feb 27 2014, 11:16 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Feb 28 2014, 12:50 AM
epriestley edited this Maniphest Task.Feb 28 2014, 11:12 PM
epriestley edited this Maniphest Task.Feb 28 2014, 11:20 PM
epriestley edited this Maniphest Task.Feb 28 2014, 11:26 PM
epriestley edited this Maniphest Task.Mar 1 2014, 12:49 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 1 2014, 1:15 AM
epriestley edited this Maniphest Task.Mar 3 2014, 4:36 PM
epriestley edited this Maniphest Task.Mar 5 2014, 1:12 AM
epriestley edited this Maniphest Task.Mar 5 2014, 1:52 AM
epriestley edited this Maniphest Task.Mar 5 2014, 1:55 AM
epriestley edited this Maniphest Task.Mar 5 2014, 2:18 AM
epriestley edited this Maniphest Task.Mar 5 2014, 3:03 AM
epriestley edited this Maniphest Task.Mar 5 2014, 3:53 AM
epriestley edited this Maniphest Task.Mar 5 2014, 6:44 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 5 2014, 6:47 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 5 2014, 8:07 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 6 2014, 4:19 PM
epriestley edited this Maniphest Task.Mar 6 2014, 4:33 PM
epriestley edited this Maniphest Task.Mar 6 2014, 4:37 PM
epriestley edited this Maniphest Task.Mar 6 2014, 5:01 PM
NorthIsUp added a subscriber: NorthIsUp.Mar 6 2014, 7:43 PM
epriestley edited this Maniphest Task.Mar 7 2014, 4:09 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Mar 7 2014, 7:07 PM
epriestley edited this Maniphest Task.Mar 7 2014, 8:04 PM
epriestley edited this Maniphest Task.Mar 7 2014, 8:18 PM
epriestley edited this Maniphest Task.Mar 7 2014, 10:22 PM
epriestley edited this Maniphest Task.Mar 8 2014, 12:01 AM
epriestley edited this Maniphest Task.Mar 8 2014, 1:44 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
Unknown Object (User) added a subscriber: Unknown Object (User).Mar 8 2014, 2:03 PM
Unknown Object (User) added a comment.EditedMar 8 2014, 2:06 PM

xxxxxxx"></''\'\

xxxxxxx"></''\'\xxxxxxx"></''\'\

Macro mushroom: xxxxxxx"></''\'\ xxxxxxx"></''\'\

epriestley added a comment.Mar 8 2014, 2:31 PM

@jablor Please do not penetration test this install. Install your own local copy of Phabricator instead.

epriestley edited this Maniphest Task.Mar 8 2014, 5:01 PM
epriestley edited this Maniphest Task.Mar 8 2014, 5:20 PM
epriestley edited this Maniphest Task.Mar 8 2014, 6:56 PM
epriestley edited this Maniphest Task.Mar 8 2014, 7:29 PM
epriestley edited this Maniphest Task.Mar 8 2014, 7:44 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:04 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:13 PM
chad removed a subscriber: chad.Mar 8 2014, 8:15 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:15 PM
epriestley edited this Maniphest Task.Mar 8 2014, 8:20 PM
epriestley edited this Maniphest Task.Mar 8 2014, 10:45 PM
epriestley edited this Maniphest Task.Mar 9 2014, 5:25 PM
epriestley edited this Maniphest Task.Mar 9 2014, 6:27 PM
epriestley edited this Maniphest Task.Mar 9 2014, 6:47 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:41 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:43 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:47 PM
epriestley edited this Maniphest Task.Mar 9 2014, 7:58 PM
epriestley edited this Maniphest Task.Mar 9 2014, 8:19 PM
epriestley edited this Maniphest Task.Mar 9 2014, 8:49 PM
epriestley edited this Maniphest Task.Mar 9 2014, 9:53 PM
epriestley edited this Maniphest Task.Mar 11 2014, 8:06 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley closed this task as Resolved.Mar 11 2014, 8:20 PM

I'm going to close this as resolved; there's some various remaining work but it's not directly related to ApplicationTransactions and pretty well covered by other tasks. All the old editors are gone from the codebase and all edits now use ApplicationTransactions. If you run into bugs, T4481 is the best place to follow up (that task is less noisy and more human-readable).

rm added a subscriber: rm.Jun 5 2014, 8:33 PM

https://secure.phabricator.com/conduit/method/differential.getrevisioncomments/ points me to this task, but this doesn't make it clear to me why differential.getrevisioncomments is doomed, or what I might use to replace it.

epriestley added a comment.Jun 5 2014, 8:35 PM

See T5112, maybe.

epriestley added a comment.Jun 5 2014, 8:40 PM

Which is not terribly helpful, I suppose.

It's obsolete and doomed because the format it emits is insufficient to represent modern transaction activity, which now records things like title and test plan edits, comment edits, and so on.

Some more general differential.querytransactions method will eventually replace it, but maybe that will be even more general (transactions.query). I don't have concrete plans on this yet.

epriestley edited this Maniphest Task.Jun 22 2014, 3:12 PM
epriestley edited this Maniphest Task.Jun 22 2014, 3:15 PM
epriestley edited this Maniphest Task.Jun 24 2014, 12:30 PM
epriestley added a commit: Restricted Diffusion Commit.Sep 14 2014, 11:29 PM
epriestley mentioned this in T2795: Phacility (Mid Priority).Oct 3 2014, 4:43 AM
philip added a subscriber: philip.Jun 21 2015, 8:38 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Aug 28 2015, 8:59 PM
psung added a subscriber: psung.Jun 27 2017, 9:47 PM
Herald added a subscriber: eadler. · View Herald TranscriptJun 27 2017, 9:47 PM
epriestley mentioned this in T13127: Plans: Form Steering Committee For "+/-" Line Indicators.Apr 26 2018, 10:37 PM
Phabricator · Built by Phacility