HomePhabricator

Simplify selection of inline comments from RevisionView

Description

Simplify selection of inline comments from RevisionView

Summary: Ref T2222. Currently, we load inline comments by commentID here, but we always pass every commentID associated with the revision. Instead, just load non-draft comments by revision ID. This simplifies querying a little bit and is likely faster anyway (draft comments are currently loaded separately).

Test Plan: Looked at some revisions and verified inlines showed up correctly and in the right places.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D6270

Details

Provenance
epriestleyAuthored on Jun 24 2013, 6:01 PM
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Parents
rP3124838d6567: Undo D6266 (DifferentialComment PHID migration)
Branches
Unknown
Tags
Unknown
Tasks
T2222: Implement ApplicationTransactions in Differential

Event Timeline