Paths

Table of Contentst

Differential D8294

Make Differential inline comment rendering more consistent and somewhat more modern
ClosedPublic
Actions

Authored by epriestley on Feb 21 2014, 7:36 PM.

Tags

None

Referenced Files

	F18050986: D8294.id19723.diff
	Sun, Aug 3, 9:48 PM

	F17959763: D8294.id.diff
	Fri, Aug 1, 8:35 AM

	F17945204: D8294.diff
	Thu, Jul 31, 11:36 AM

	F17849515: D8294.diff
	Sun, Jul 27, 8:47 AM

	Unknown Object (File)
	Jun 29 2025, 12:54 AM

	Unknown Object (File)
	Jun 9 2025, 1:58 AM

	Unknown Object (File)
	May 27 2025, 1:37 AM

	Unknown Object (File)
	May 20 2025, 8:07 AM

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP92ac8b5ad9a5: Make Differential inline comment rendering more consistent and somewhat more…

Summary

Ref T2222. Ref T1790. I partially modernized this recently, but bring it to the mail version too.

Test Plan

See screenshots.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

{F116306}

{F116307}

{F116308}

epriestley added inline comments.Feb 21 2014, 7:39 PM

src/applications/differential/controller/DifferentialChangesetViewController.php
359	This `true` -> `1` stuff is for MySQL strict mode.
src/applications/differential/editor/DifferentialCommentEditor.php
662–663	Most of this juggling is to start unraveling our dependence on the old proxy/wrapper objects.
src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
43–45	Stuff is always passed in to this view in the correct order now, and we just respect it.

btrahan accepted this revision.Feb 21 2014, 7:47 PM

Closed by commit rP92ac8b5ad9a5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

2 lines

editor/

DifferentialCommentEditor.php

8 lines

mail/

DifferentialCommentMail.php

78 lines

DifferentialMail.php

2 lines

parser/

DifferentialHunkParser.php

23 lines

__tests__/

DifferentialHunkParserTestCase.php

69 lines

storage/

DifferentialComment.php

5 lines

DifferentialTransactionComment.php

40 lines

view/

DifferentialTransactionView.php

27 lines

infrastructure/

diff/

PhabricatorInlineCommentController.php

2 lines

view/

PhabricatorInlineSummaryView.php

3 lines

Diff 19723

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...

src/applications/differential/editor/DifferentialCommentEditor.php

Loading...

src/applications/differential/mail/DifferentialCommentMail.php

Loading...

src/applications/differential/mail/DifferentialMail.php

Loading...

src/applications/differential/parser/DifferentialHunkParser.php

Loading...

src/applications/differential/parser/tests/DifferentialHunkParserTestCase.php

Loading...

src/applications/differential/storage/DifferentialComment.php

Loading...

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...

src/applications/differential/view/DifferentialTransactionView.php

Loading...

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...

src/infrastructure/diff/view/PhabricatorInlineSummaryView.php

Loading...