Page MenuHomePhabricator

joshuaspence (Joshua Spence)
Code Monkey

Projects (91)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2013, 12:25 AM (680 w, 1 d)
Availability
Available

Recent Activity

Jun 1 2021

bbrdaric awarded Changelog a Heartbreak token.
Jun 1 2021, 8:41 AM

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Jul 18 2019

joshuaspence created P2121 bulk_move_columns.php.
Jul 18 2019, 10:34 PM
joshuaspence created P2120 ConduitIterator.php.
Jul 18 2019, 10:33 PM

May 21 2019

joshuaspence added a revision to T6854: Modify the `lint-test` file format to allow for assertions against linter codes: Unknown Object (Differential Revision).
May 21 2019, 8:02 AM · Lint
joshuaspence closed T6854: Modify the `lint-test` file format to allow for assertions against linter codes as Resolved by committing Restricted Diffusion Commit.
May 21 2019, 3:48 AM · Lint

May 10 2019

joshuaspence edited the content of Community Resources.
May 10 2019, 12:52 AM

May 3 2019

joshuaspence edited the content of Community Resources.
May 3 2019, 4:59 AM
joshuaspence edited the content of Community Resources.
May 3 2019, 4:58 AM

Apr 20 2019

joshuaspence added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

I believe there is very little reason for the "Autoclose" and "Publish" behaviors to actually be separate. That is, there are very few use cases where users want a commit to trigger only Herald or only feed or only audits. These use cases do exist (see T9210 for an example of "Herald, No Feed") but they're overwhelmingly niche and off-label.

Apr 20 2019, 2:19 AM · Plans, Diffusion

Apr 19 2019

remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM

Jan 21 2019

joshuaspence added a watcher for Plans: joshuaspence.
Jan 21 2019, 1:40 AM

Jan 11 2019

PXke awarded T4558: Make Diviner useful for third-parties a Mountain of Wealth token.
Jan 11 2019, 5:46 PM · Diviner

Dec 13 2018

joshuaspence added a comment to T13219: When returning a writable connection as a "r" connection, label it so it can be reused as a "w" connection.

I am seeing a similar issue on our install:

[2018-12-13 12:20:12] EXCEPTION: (PhabricatorClusterImproperWriteException) Unable to establish a write-mode connection (to application database "phabricator_repository") because Phabricator is in read-only mode. Whatever you are trying to do does not function correctly in read-only mode. at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:119] arcanist(head=stable, ref.master=d9a4293ae734, ref.stable=45a8d22c74a6), phabricator(head=stable, ref.master=2951694c2737, ref.stable=237a2a190984), phlab(head=master, ref.master=564c60d09ff4), phutil(head=stable, ref.master=dd136d1c3712, ref.stable=414a4c6abb1b)
  #0 PhabricatorLiskDAO::raiseImproperWrite(string) called at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:60]
  #1 PhabricatorLiskDAO::establishLiveConnection(string) called at [<phabricator>/src/infrastructre/storage/lisk/LiskDAO.php:1011]
  #2 LiskDAO::establishConnection(string) called at [<phabricator>/src/applications/repository/stora... (619 more bytes) ... at [<phutil>/src/future/exec/ExecFuture.php:380]
[13-Dec-2018 12:20:12 Etc/UTC] arcanist(head=stable, ref.master=d9a4293ae734, ref.stable=45a8d22c74a6), phabricator(head=stable, ref.master=2951694c2737, ref.stable=237a2a190984), phlab(head=master, ref.master=564c60d09ff4), phutil(head=stable, ref.master=dd136d1c3712, ref.stable=414a4c6abb1b)
[13-Dec-2018 12:20:12 Etc/UTC]   #0 <#3> ExecFuture::resolvex() called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:446]
[13-Dec-2018 12:20:12 Etc/UTC]   #1 phlog(PhutilProxyException) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:453]
[13-Dec-2018 12:20:12 Etc/UTC]   #2 PhabricatorRepositoryPullLocalDaemon::resolveUpdateFuture(PhabricatorRepository, ExecFuture, integer) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:222]
[13-Dec-2018 12:20:12 Etc/UTC]   #3 PhabricatorRepositoryPullLocalDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:219]
[13-Dec-2018 12:20:12 Etc/UTC]   #4 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:131]
Dec 13 2018, 11:40 PM · Clusters, Infrastructure
joshuaspence added a comment to T13219: When returning a writable connection as a "r" connection, label it so it can be reused as a "w" connection.

I am seeing a similar issue on our install:

Dec 13 2018, 11:38 PM · Clusters, Infrastructure
joshuaspence edited P2111 (An Untitled Masterwork).
Dec 13 2018, 12:36 AM
joshuaspence edited P2111 (An Untitled Masterwork).
Dec 13 2018, 12:25 AM
joshuaspence created P2111 (An Untitled Masterwork).
Dec 13 2018, 12:24 AM

Dec 12 2018

joshuaspence added a comment to T12145: Resource allocator does not create new host resources when one is already active.

I'm having some trouble getting this new behaviour (which IIUC basically means that multiple hosts in a Drydock pool should be load-balanced across). In "active resources" I see three Drydock hosts, which all belong to the same Almanac service. In "active leases", however, I see only a single host lease and many working copy leases.

Dec 12 2018, 10:15 AM · Bug Report, Drydock

Dec 9 2018

joshuaspence added a comment to T12145: Resource allocator does not create new host resources when one is already active.

I'm having some trouble getting this new behaviour (which IIUC basically means that multiple hosts in a Drydock pool should be load-balanced across). In "active resources" I see three Drydock hosts, which all belong to the same Almanac service. In "active leases", however, I see only a single host lease and many working copy leases.

Dec 9 2018, 11:39 PM · Bug Report, Drydock

Nov 21 2018

joshuaspence added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

I do have a real-life example where the prose diff engine rendered a suboptimal diff. I was able to fix it by changing the maximum length of the edit distance matrix from 128 to 256.

Nov 21 2018, 5:44 AM · Prioritized, Transactions

Oct 31 2018

joshuaspence added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

To reproduce this issue, just need to Click on Default Column -> View as Query then leaving without Saving the query.

These reproduction steps don't work for me, and don't make sense given how the software works. If you believe you have a set of reproduction steps, can you walk through them step-by-step in more detail so I can reproduce the issue?

If anyone can come up with reproduction steps which actually work, this will probably take me about 3 minutes to fix. The only thing blocking this is that I have no idea how to reproduce it.

Oct 31 2018, 1:22 AM · Workboards

Oct 4 2018

joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

@epriestley, would you be open to making the chunk size configurable? Changing the chunk size from 32 to 512 reduced the amount of time required for us to lint ~1500 TypeScript files from 370 seconds to 66 seconds.

Oct 4 2018, 3:00 AM · Arcanist

Sep 17 2018

joshuaspence added a revision to T11699: `arc patch` is timing out: Restricted Differential Revision.
Sep 17 2018, 4:57 AM · Conduit, Differential

Aug 20 2018

joshuaspence added a comment to T7303: Provide OAuth access to Conduit.

Even with OAuth, you still can't make AJAX requests to Conduit from client-side JavaScript, right? Is the idea that the backend code uses OAuth to talk to Conduit on a user's behalf?

Aug 20 2018, 8:06 AM · Restricted Project, Conduit, Restricted Project

Jun 29 2018

DragonBe awarded T7408: Consider dropping support for older versions of PHP a Like token.
Jun 29 2018, 11:35 AM · Restricted Project, Infrastructure

Jun 5 2018

joshuaspence added a member for Clusters: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Drydock: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for EditEngine: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Guides: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Inline Comments: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Mailing Lists: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Nuance: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Packages: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Plans: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Process Improvement: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Transactions: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Workboards: joshuaspence.
Jun 5 2018, 10:43 PM
joshuaspence added a member for Almanac: joshuaspence.
Jun 5 2018, 10:40 PM

Mar 9 2018

Gryllida awarded T9412: Annotate all the reasons that a user is included on the recipient list for mail a Love token.
Mar 9 2018, 12:48 AM · llvm, Restricted Project, Mail

Jan 6 2018

cspeckmim awarded Changelog a Mountain of Wealth token.
Jan 6 2018, 4:47 PM

Jan 4 2018

arend.danielek awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 4 2018, 10:38 PM · Prioritized, Restricted Project, Infrastructure

Dec 28 2017

joshuaspence added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

FWIW, I am using a custom file and mail engine that utilises the AWS SDK and supports instance profile credentials. See P2082 and P2083. You need to install and require the AWS SDK before using these extensions.

Dec 28 2017, 2:10 AM · Files
joshuaspence created P2083 PhlabS3FileStorageEngine.php.
Dec 28 2017, 2:09 AM
joshuaspence created P2082 PhlabAmazonSESMailImplementationAdapter.php.
Dec 28 2017, 2:08 AM

Nov 16 2017

mormegil awarded T12144: Ability to reorder milestones on a project's workboard a Haypence token.
Nov 16 2017, 3:53 PM · Projects, Feature Request

Nov 13 2017

joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Nov 13 2017, 4:36 AM · XHPAST

Sep 25 2017

joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Restricted Differential Revision.
Sep 25 2017, 5:32 AM · XHPAST

Sep 18 2017

joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Sep 18 2017, 11:07 AM · XHPAST

Aug 10 2017

joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

Thanks for the detailed response, I certainly didn't expect it.

Aug 10 2017, 1:21 PM · Bug Report, Files

Aug 9 2017

joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230805, @chad wrote:

In general are you aware we no longer take bug reports or feature requests here?

Aug 9 2017, 10:36 PM · Bug Report, Diffusion
joshuaspence renamed T12959: Diffusion shows unexpected diff when an entire directory is removed from Diffusion shows mysterious diff when an entire directory is removed to Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230799, @chad wrote:

What does "mysterious" mean.

Aug 9 2017, 10:21 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:13 PM · Bug Report, Diffusion
joshuaspence created T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:12 PM · Bug Report, Diffusion

Aug 6 2017

joshuaspence updated the task description for T8593: Allow files to have a description.
Aug 6 2017, 3:53 AM · Restricted Project, Files
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

I wonder if this OOM error can also be hit in other workflow though, given that it seems to occur in PhabricatorFileStorageEngine::getRawFileDataIterator.

Aug 6 2017, 1:28 AM · Bug Report, Files
joshuaspence added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

Yep, agreed that the re-targeted proposal is a better solution... I had just assumed that this was a documentation oversight.

Aug 6 2017, 12:15 AM · Bug Report, Files, Setup

Aug 2 2017

joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros
joshuaspence created T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 2 2017, 9:24 PM · Bug Report, Files, Setup
joshuaspence created T12950: Regenerating thumbnails for memes is difficult.
Aug 2 2017, 9:12 PM · Feature Request, Macros
joshuaspence created T12948: Remove the `bin/files purge` workflow.
Aug 2 2017, 12:08 PM · Bug Report, Files

Jul 31 2017

joshuaspence added a revision to T12919: Healthcheck endpoint for alternate file domain: Unknown Object (Differential Revision).
Jul 31 2017, 11:13 AM · Files
joshuaspence added a comment to T10214: Daemons try and fail to publish transactions for newly created diffs.

I'm seeing these errors failing regularly:

Jul 31 2017, 10:17 AM · Bug Report
joshuaspence added a revision to T8591: Undefined index in changeset parser: Unknown Object (Differential Revision).
Jul 31 2017, 7:56 AM · Differential
joshuaspence reopened T8591: Undefined index in changeset parser as "Open".

I've got a reproduction case for this now: https://secure.phabricator.com/differential/diff/44008/

Jul 31 2017, 7:49 AM · Differential

Jul 30 2017

joshuaspence added a revision to T11480: Stop sending misbehaving user nonsense to the error log: Unknown Object (Differential Revision).
Jul 30 2017, 10:05 PM

Jul 25 2017

joshuaspence added a comment to T6524: Support "request is from IP / subnet" policy rule.

@hach-que, did you end up implementing a solution for this?

Jul 25 2017, 12:58 PM · Policy

Jul 24 2017

jcox awarded T9041: Control access to administrator capabilities with custom policies a Like token.
Jul 24 2017, 11:34 AM · FreeBSD, Policy, People
joshuaspence added a revision to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies: Unknown Object (Differential Revision).
Jul 24 2017, 11:00 AM · Diffusion
joshuaspence added a comment to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies.

I am also seeing this error and am trying to work on a fix.

Jul 24 2017, 9:23 AM · Diffusion

Jul 12 2017

joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Another correction, Puppet doesn't //need/ a dedicated server. You can run Puppet in a standalone (agent) mode, if you are willing to somehow get your Puppet manifests onto each host that you wish to provision.

Jul 12 2017, 10:27 PM · Ops, Phacility
joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Terraform Review
Pros:

  • Written in Python, which everyone knows is superior to Ruby in every way
Jul 12 2017, 10:22 PM · Ops, Phacility
joshuaspence created T12919: Healthcheck endpoint for alternate file domain.
Jul 12 2017, 9:58 PM · Files
joshuaspence edited the content of Community Resources.
Jul 12 2017, 9:55 PM
joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

FWIW, I am actively working on a Puppet module for Phabricator, see https://forge.puppet.com/joshuaspence/phabricator.

Jul 12 2017, 9:54 PM · Ops, Phacility
joshuaspence added a comment to T12847: A Pathway Towards Private Clusters.

AWS doesn't have a single device which can both listen for TCP on 22 (only ELB) and terminate SSL for websockets (only ALB).

Jul 12 2017, 9:52 PM · Plans, Ops, Phacility

Jul 11 2017

joshuaspence added a revision to T12910: Allow SES to be used for inbound mail: Unknown Object (Differential Revision).
Jul 11 2017, 1:53 PM · Mail

Jul 10 2017

joshuaspence created T12910: Allow SES to be used for inbound mail.
Jul 10 2017, 12:20 PM · Mail
joshuaspence updated the task description for T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence created T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence renamed T12907: Unable to download large files through alternative file domain from Unable to download large files from secure.phabricator.com to Unable to download large files through alternative file domain.
Jul 10 2017, 12:12 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.

Ah sorry, I should've made that clear. Yes, I am able to reproduce the issue on our installation.

Jul 10 2017, 12:09 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.
In T12907#228951, @chad wrote:

This is not a test install.

Jul 10 2017, 12:03 AM · Bug Report

Jul 9 2017

joshuaspence created T12907: Unable to download large files through alternative file domain.
Jul 9 2017, 11:55 PM · Bug Report

Jul 7 2017

joshuaspence added a comment to T7858: Typeahead/Tokenizer Errata.

Is there a way to exclude users/projects from a query? A user on our install has asked for a way to search for Differential revisions with Project X as a reviewer where the author is not a member of Project X.

Jul 7 2017, 6:47 AM · Restricted Project, Typeahead

Jun 29 2017

Krinkle awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jun 29 2017, 2:59 AM · Prioritized, Restricted Project, Infrastructure

May 31 2017

joshuaspence added a comment to T1026: Request: ability to select line range for comment via touchscreen.

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users

May 31 2017, 7:05 AM · Inline Comments, Differential

May 30 2017

joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

Thanks for the very detailed response.

May 30 2017, 1:52 AM

May 29 2017

joshuaspence abandoned D18040: Maintain POST requests when following redirects.

Yep, that's a better solution. In the mean time, we just updated all of our .arcconfig files.

May 29 2017, 11:31 PM

May 28 2017

joshuaspence added a comment to D18040: Maintain POST requests when following redirects.

@epriestley, if you had any thoughts on this it would be appreciated as this issue is heavily affecting our users. There is a workaround (update our .arcconfig files to point to the new domain), but we have a lot of repositories...

May 28 2017, 11:04 PM
joshuaspence created D18040: Maintain POST requests when following redirects.
May 28 2017, 11:03 PM
joshuaspence created T12769: Applications page shows Diffusion on admin.
May 28 2017, 2:26 AM · Phacility, Bug Report

May 25 2017

joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

For git, is that because discovery only happens on the Almanac device on which the repository is bound to or is it because there is some sort of global lock taken for repository updates? I'm curious to learn more bout how this works.

May 25 2017, 8:51 PM
joshuaspence marked Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 549) as hidden.
May 25 2017, 8:51 PM
joshuaspence added Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 549).
May 25 2017, 8:50 PM
joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

Thanks.

May 25 2017, 8:41 PM
joshuaspence asked Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery`.
May 25 2017, 8:23 PM · Clusters
joshuaspence closed T12754: 404 when trying to create a new repository as Invalid.

This was a misconfiguration on my part and I wasn't properly forwarding the query string from nginx to PHP.

May 25 2017, 1:17 AM · Bug Report