joshuaspence (Joshua Spence)
Code Monkey

Projects (79)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2013, 12:25 AM (201 w, 1 d)
Availability
Available

Recent Activity

Thu, Aug 10

joshuaspence accepted D18384: Remove `bin/files purge` workflow.
Thu, Aug 10, 1:22 PM
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

Thanks for the detailed response, I certainly didn't expect it.

Thu, Aug 10, 1:21 PM · Bug Report, Files
joshuaspence committed rP71eaf3e8c4d6: Remove code that was accidentally landed (authored by joshuaspence).
Remove code that was accidentally landed
Thu, Aug 10, 8:45 AM
joshuaspence closed D18380: Remove code that was accidentally landed by committing rP71eaf3e8c4d6: Remove code that was accidentally landed.
Thu, Aug 10, 8:45 AM

Wed, Aug 9

epriestley awarded D18380: Remove code that was accidentally landed a Cup of Joe token.
Wed, Aug 9, 11:03 PM
joshuaspence created D18380: Remove code that was accidentally landed.
Wed, Aug 9, 11:02 PM
joshuaspence added inline comments to D18378: Remove chatbot example configuration.
Wed, Aug 9, 10:53 PM
joshuaspence added a comment to D18378: Remove chatbot example configuration.

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

Wed, Aug 9, 10:53 PM
joshuaspence added inline comments to D18378: Remove chatbot example configuration.
Wed, Aug 9, 10:52 PM
joshuaspence committed rPbd47d001b548: Remove chatbot example configuration (authored by joshuaspence).
Remove chatbot example configuration
Wed, Aug 9, 10:49 PM
joshuaspence closed D18378: Remove chatbot example configuration by committing rPbd47d001b548: Remove chatbot example configuration.
Wed, Aug 9, 10:49 PM
joshuaspence added a comment to D18378: Remove chatbot example configuration.

(interestingly, I didn't receive an email about this diff being accepted)

Wed, Aug 9, 10:49 PM
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230805, @chad wrote:

In general are you aware we no longer take bug reports or feature requests here?

Wed, Aug 9, 10:36 PM · Bug Report, Diffusion
joshuaspence created D18379: Add a "Reviewed By" Herald condition.
Wed, Aug 9, 10:30 PM
joshuaspence renamed T12959: Diffusion shows unexpected diff when an entire directory is removed from Diffusion shows mysterious diff when an entire directory is removed to Diffusion shows unexpected diff when an entire directory is removed.
Wed, Aug 9, 10:23 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Wed, Aug 9, 10:23 PM · Bug Report, Diffusion
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230799, @chad wrote:

What does "mysterious" mean.

Wed, Aug 9, 10:21 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Wed, Aug 9, 10:13 PM · Bug Report, Diffusion
joshuaspence created T12959: Diffusion shows unexpected diff when an entire directory is removed.
Wed, Aug 9, 10:12 PM · Bug Report, Diffusion
joshuaspence created D18378: Remove chatbot example configuration.
Wed, Aug 9, 10:11 PM

Sun, Aug 6

joshuaspence accepted D18351: Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.
Sun, Aug 6, 1:21 PM
joshuaspence updated the task description for T8593: Allow files to have a description.
Sun, Aug 6, 3:53 AM · Restricted Project, Files
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

I wonder if this OOM error can also be hit in other workflow though, given that it seems to occur in PhabricatorFileStorageEngine::getRawFileDataIterator.

Sun, Aug 6, 1:28 AM · Bug Report, Files
joshuaspence added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

Yep, agreed that the re-targeted proposal is a better solution... I had just assumed that this was a documentation oversight.

Sun, Aug 6, 12:15 AM · Bug Report, Files, Setup

Wed, Aug 2

joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Wed, Aug 2, 9:40 PM · Feature Request, Macros
joshuaspence created T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.
Wed, Aug 2, 9:24 PM · Bug Report, Files, Setup
joshuaspence created T12950: Regenerating thumbnails for memes is difficult.
Wed, Aug 2, 9:12 PM · Feature Request, Macros
joshuaspence created T12948: Remove the `bin/files purge` workflow.
Wed, Aug 2, 12:08 PM · Bug Report, Files

Mon, Jul 31

joshuaspence created D18303: Allow `/status/` endpoint to be served through alternate file domain.
Mon, Jul 31, 11:13 AM
joshuaspence added a revision to T12919: Healthcheck endpoint for alternate file domain: D18303: Allow `/status/` endpoint to be served through alternate file domain.
Mon, Jul 31, 11:13 AM · Files, Feature Request
joshuaspence added a comment to T10214: Daemons try and fail to publish transactions for newly created diffs.

I'm seeing these errors failing regularly:

Mon, Jul 31, 10:17 AM · Bug Report
joshuaspence created D18302: Fix "undefined index" error in Differential changeset parser.
Mon, Jul 31, 7:56 AM
joshuaspence added a revision to T8591: Undefined index in changeset parser: D18302: Fix "undefined index" error in Differential changeset parser.
Mon, Jul 31, 7:56 AM · Differential
joshuaspence reopened T8591: Undefined index in changeset parser as "Open".

I've got a reproduction case for this now: https://secure.phabricator.com/differential/diff/44008/

Mon, Jul 31, 7:49 AM · Differential

Sun, Jul 30

joshuaspence updated the test plan for D18300: Don't log whiny exceptions for AJAX requests.
Sun, Jul 30, 11:03 PM
joshuaspence created D18300: Don't log whiny exceptions for AJAX requests.
Sun, Jul 30, 10:05 PM
joshuaspence added a revision to T11480: Stop sending misbehaving user nonsense to the error log: D18300: Don't log whiny exceptions for AJAX requests.
Sun, Jul 30, 10:05 PM

Thu, Jul 27

joshuaspence added a comment to D18281: In Differential, filter repository operations to just "Land" operations again.

Ok thanks

Thu, Jul 27, 12:35 AM
joshuaspence added a comment to D18281: In Differential, filter repository operations to just "Land" operations again.

See PHI18 for discussion

Thu, Jul 27, 12:31 AM

Tue, Jul 25

joshuaspence added a comment to T6524: Support "request is from IP / subnet" policy rule.

@hach-que, did you end up implementing a solution for this?

Tue, Jul 25, 12:58 PM · Policy
joshuaspence updated the test plan for D18268: Add a missing read lock.
Tue, Jul 25, 7:04 AM
joshuaspence updated the summary of D18275: Allow interpreter arguments for external linters.
Tue, Jul 25, 4:50 AM
joshuaspence created D18275: Allow interpreter arguments for external linters.
Tue, Jul 25, 4:48 AM

Mon, Jul 24

joshuaspence added a comment to D18271: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out.

Good catch

Mon, Jul 24, 8:43 PM
jcox awarded T9041: Control access to administrator capabilities with custom policies a Like token.
Mon, Jul 24, 11:34 AM · FreeBSD, Policy, People
joshuaspence created D18268: Add a missing read lock.
Mon, Jul 24, 11:00 AM
joshuaspence added a revision to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies: D18268: Add a missing read lock.
Mon, Jul 24, 11:00 AM · Diffusion
joshuaspence added a comment to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies.

I am also seeing this error and am trying to work on a fix.

Mon, Jul 24, 9:23 AM · Diffusion

Wed, Jul 19

joshuaspence created D18243: Lock a bunch of config options.
Wed, Jul 19, 1:34 PM
joshuaspence created D18242: Ignore local SSH configuration.
Wed, Jul 19, 1:15 PM
joshuaspence created D18241: Suppress "Permanently added ... to the list of known hosts" messages.
Wed, Jul 19, 1:07 PM
joshuaspence updated the diff for D18205: Add SNS mail endpoint.

minor

Wed, Jul 19, 12:50 PM

Jul 12 2017

joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Another correction, Puppet doesn't //need/ a dedicated server. You can run Puppet in a standalone (agent) mode, if you are willing to somehow get your Puppet manifests onto each host that you wish to provision.

Jul 12 2017, 10:27 PM · Ops, Phacility
joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Terraform Review
Pros:

  • Written in Python, which everyone knows is superior to Ruby in every way
Jul 12 2017, 10:22 PM · Ops, Phacility
joshuaspence created T12919: Healthcheck endpoint for alternate file domain.
Jul 12 2017, 9:58 PM · Files, Feature Request
joshuaspence edited the content of Community Resources.
Jul 12 2017, 9:55 PM
joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

FWIW, I am actively working on a Puppet module for Phabricator, see https://forge.puppet.com/joshuaspence/phabricator.

Jul 12 2017, 9:54 PM · Ops, Phacility
joshuaspence added a comment to T12847: A Pathway Towards Private Clusters.

AWS doesn't have a single device which can both listen for TCP on 22 (only ELB) and terminate SSL for websockets (only ALB).

Jul 12 2017, 9:52 PM · Ops, Phacility

Jul 11 2017

joshuaspence created D18205: Add SNS mail endpoint.
Jul 11 2017, 1:53 PM
joshuaspence added a revision to T12910: Allow SES to be used for inbound mail: D18205: Add SNS mail endpoint.
Jul 11 2017, 1:53 PM · Mail, Feature Request

Jul 10 2017

joshuaspence created T12910: Allow SES to be used for inbound mail.
Jul 10 2017, 12:20 PM · Mail, Feature Request
Herald updated subscribers of T12799: Consider an "API Utilities" application.
Jul 10 2017, 11:25 AM · Conduit
Herald updated subscribers of T12816: Setup NAT for the primary Phacility cluster.
Jul 10 2017, 11:03 AM · Ops, Phacility
joshuaspence updated the task description for T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence created T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence renamed T12907: Unable to download large files through alternative file domain from Unable to download large files from secure.phabricator.com to Unable to download large files through alternative file domain.
Jul 10 2017, 12:12 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.

Ah sorry, I should've made that clear. Yes, I am able to reproduce the issue on our installation.

Jul 10 2017, 12:09 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.
In T12907#228951, @chad wrote:

This is not a test install.

Jul 10 2017, 12:03 AM · Bug Report

Jul 9 2017

joshuaspence created T12907: Unable to download large files through alternative file domain.
Jul 9 2017, 11:55 PM · Bug Report

Jul 7 2017

joshuaspence added a comment to T7858: Typeahead/Tokenizer Errata.

Is there a way to exclude users/projects from a query? A user on our install has asked for a way to search for Differential revisions with Project X as a reviewer where the author is not a member of Project X.

Jul 7 2017, 6:47 AM · Restricted Project, Typeahead

Jun 29 2017

Krinkle awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jun 29 2017, 2:59 AM · Prioritized, Restricted Project, Infrastructure

Jun 28 2017

joshuaspence added a comment to D18170: Update people image for projects.

I think that something is broken here... when I click "Show Raw File (Right)" I get an empty (zero-byte) response.

Jun 28 2017, 4:30 PM

May 31 2017

joshuaspence awarded D18053: Help PROFESSIONAL SOFTWARE ENGINEERS copy text to their clipboard a Mountain of Wealth token.
May 31 2017, 9:14 PM
joshuaspence added a comment to T1026: Request: ability to select line range for comment via touchscreen.

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users

May 31 2017, 7:05 AM · Inline Comments, Differential

May 30 2017

joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

Thanks for the very detailed response.

May 30 2017, 1:52 AM

May 29 2017

joshuaspence abandoned D18040: Maintain POST requests when following redirects.

Yep, that's a better solution. In the mean time, we just updated all of our .arcconfig files.

May 29 2017, 11:31 PM

May 28 2017

joshuaspence added a comment to D18040: Maintain POST requests when following redirects.

@epriestley, if you had any thoughts on this it would be appreciated as this issue is heavily affecting our users. There is a workaround (update our .arcconfig files to point to the new domain), but we have a lot of repositories...

May 28 2017, 11:04 PM
joshuaspence created D18040: Maintain POST requests when following redirects.
May 28 2017, 11:03 PM
joshuaspence created T12769: Applications page shows Diffusion on admin.
May 28 2017, 2:26 AM · Phacility, Bug Report

May 25 2017

joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

For git, is that because discovery only happens on the Almanac device on which the repository is bound to or is it because there is some sort of global lock taken for repository updates? I'm curious to learn more bout how this works.

May 25 2017, 8:51 PM
joshuaspence marked Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 549) as hidden.
May 25 2017, 8:51 PM
joshuaspence added Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 549).
May 25 2017, 8:50 PM
joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

Thanks.

May 25 2017, 8:41 PM
joshuaspence asked Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery`.
May 25 2017, 8:23 PM · Clusters
joshuaspence closed T12754: 404 when trying to create a new repository as Invalid.

This was a misconfiguration on my part and I wasn't properly forwarding the query string from nginx to PHP.

May 25 2017, 1:17 AM · Bug Report
joshuaspence closed T12756: FontAwesome is returning a 404 as Invalid.

This was a misconfiguration on my part and I wasn't properly forwarding the query string from nginx to PHP.

May 25 2017, 1:17 AM · Bug Report
joshuaspence created T12756: FontAwesome is returning a 404.
May 25 2017, 1:10 AM · Bug Report
joshuaspence updated the task description for T12755: Aphlict doesn't work with the latest version of `ws`.
May 25 2017, 12:46 AM · Aphlict, Bug Report
joshuaspence created T12755: Aphlict doesn't work with the latest version of `ws`.
May 25 2017, 12:45 AM · Aphlict, Bug Report

May 24 2017

joshuaspence added a comment to T12754: 404 when trying to create a new repository.

Possibly related, I'm having issues with Almanac too. I created an Almanac device, but clicking on "Add Interface" takes me to /almanac/interface/edit/?deviceID=2 which shows a 404.

May 24 2017, 9:55 PM · Bug Report
joshuaspence created T12754: 404 when trying to create a new repository.
May 24 2017, 9:54 PM · Bug Report
joshuaspence added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

Was this on a test install on localhost? I can only reproduce this if the remote address is part of cluster.addresses.

May 24 2017, 9:43 PM · Auth, Bug Report
tomekj2ee awarded T12144: Ability to reorder milestones on a project's workboard a Like token.
May 24 2017, 6:37 PM · Projects, Feature Request

May 23 2017

joshuaspence added a comment to T12720: Record of hibernating daemon was garbage collected.

Ah this probably explains what I have observed on our installation too.

May 23 2017, 2:27 PM · Customer Impact, Daemons

May 16 2017

joshuaspence added a comment to D17917: Throw an exception if `local.json` can't be read.

As in... If users hot this error from non-CLI mode then they probably need to change the file permissions or add their web user to a group. If users hit this from the CLI then they need sudo

May 16 2017, 10:08 PM
joshuaspence added a comment to D17917: Throw an exception if `local.json` can't be read.

We could tailor the message differently based on CLI/FPM?

May 16 2017, 10:07 PM
joshuaspence added a comment to D17917: Throw an exception if `local.json` can't be read.

Do you have some text which you think would be more clear?

May 16 2017, 10:03 PM
joshuaspence removed 1 blocking reviewer(s) for D17917: Throw an exception if `local.json` can't be read: Blessed Reviewers.
May 16 2017, 10:01 PM
joshuaspence accepted D17917: Throw an exception if `local.json` can't be read.
May 16 2017, 10:01 PM
joshuaspence added a comment to D17917: Throw an exception if `local.json` can't be read.

It may have permissions which are too restrictive.

May 16 2017, 10:00 PM