joshuaspence (Joshua Spence)
Code Monkey

Projects (78)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2013, 12:25 AM (218 w, 1 d)
Availability
Available

Recent Activity

Sun, Nov 26

joshuaspence committed rPHU32746e8b0793: Add support for nullable parameter types (authored by joshuaspence).
Add support for nullable parameter types
Sun, Nov 26, 10:42 PM
joshuaspence closed D18770: Add support for nullable parameter types.
Sun, Nov 26, 10:42 PM
joshuaspence added a commit to T4334: Support PHP5.4+ syntax in XHPAST: rPHU32746e8b0793: Add support for nullable parameter types.
Sun, Nov 26, 10:42 PM · XHPAST

Fri, Nov 24

joshuaspence updated the diff for D18770: Add support for nullable parameter types.

Update src/parser/xhpast/parser_nodes.php

Fri, Nov 24, 5:13 AM
joshuaspence committed rPHUae80e72461d2: Fix node for nullable return value (authored by joshuaspence).
Fix node for nullable return value
Fri, Nov 24, 3:27 AM
joshuaspence added a commit to T4334: Support PHP5.4+ syntax in XHPAST: rPHUae80e72461d2: Fix node for nullable return value.
Fri, Nov 24, 3:27 AM · XHPAST
joshuaspence closed D18639: Fix node for nullable return value.
Fri, Nov 24, 3:27 AM
joshuaspence added a comment to D18770: Add support for nullable parameter types.

I will land it shortly.

Fri, Nov 24, 2:08 AM

Thu, Nov 16

mormegil awarded T12144: Ability to reorder milestones on a project's workboard a Haypence token.
Thu, Nov 16, 3:53 PM · Projects, Feature Request

Nov 13 2017

joshuaspence requested review of D18770: Add support for nullable parameter types.
Nov 13 2017, 4:37 AM
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18770: Add support for nullable parameter types.
Nov 13 2017, 4:36 AM · XHPAST

Oct 10 2017

joshuaspence added inline comments to D18679: Dump tables one at a time, rather than all at once.
Oct 10 2017, 8:10 AM

Oct 9 2017

joshuaspence added inline comments to D18679: Dump tables one at a time, rather than all at once.
Oct 9 2017, 9:17 AM

Sep 27 2017

joshuaspence created D18650: Allow filename for linter tests to be explicitly specified.
Sep 27 2017, 5:14 AM

Sep 25 2017

joshuaspence created D18639: Fix node for nullable return value.
Sep 25 2017, 5:32 AM
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18639: Fix node for nullable return value.
Sep 25 2017, 5:32 AM · XHPAST
joshuaspence committed rPHU134b16a724eb: Update `parser_nodes.php` (authored by joshuaspence).
Update `parser_nodes.php`
Sep 25 2017, 3:21 AM
joshuaspence committed rPHU2596aecadc53: Add support for nullable return types (authored by joshuaspence).
Add support for nullable return types
Sep 25 2017, 3:11 AM
joshuaspence closed D18621: Add support for nullable return types.
Sep 25 2017, 3:11 AM
joshuaspence added a commit to T4334: Support PHP5.4+ syntax in XHPAST: rPHU2596aecadc53: Add support for nullable return types.
Sep 25 2017, 3:11 AM · XHPAST
joshuaspence updated the diff for D18621: Add support for nullable return types.

Minor

Sep 25 2017, 3:09 AM

Sep 18 2017

joshuaspence added inline comments to D18621: Add support for nullable return types.
Sep 18 2017, 11:01 PM
joshuaspence added a comment to D18621: Add support for nullable return types.

Do you want to just delete all the tests and I'll accept those and abandon D17819?

Sep 18 2017, 11:15 AM
joshuaspence added inline comments to D18621: Add support for nullable return types.
Sep 18 2017, 11:12 AM
joshuaspence added a comment to D18621: Add support for nullable return types.

Oh cool. I'm somewhat surprised this is being accepted as I expected it to be blocked on T4334#222499.

Sep 18 2017, 11:10 AM
joshuaspence created D18621: Add support for nullable return types.
Sep 18 2017, 11:07 AM
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18621: Add support for nullable return types.
Sep 18 2017, 11:07 AM · XHPAST

Aug 10 2017

joshuaspence accepted D18384: Remove `bin/files purge` workflow.
Aug 10 2017, 1:22 PM
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

Thanks for the detailed response, I certainly didn't expect it.

Aug 10 2017, 1:21 PM · Bug Report, Files
joshuaspence committed rP71eaf3e8c4d6: Remove code that was accidentally landed (authored by joshuaspence).
Remove code that was accidentally landed
Aug 10 2017, 8:45 AM
joshuaspence closed D18380: Remove code that was accidentally landed by committing rP71eaf3e8c4d6: Remove code that was accidentally landed.
Aug 10 2017, 8:45 AM

Aug 9 2017

epriestley awarded D18380: Remove code that was accidentally landed a Cup of Joe token.
Aug 9 2017, 11:03 PM
joshuaspence created D18380: Remove code that was accidentally landed.
Aug 9 2017, 11:02 PM
joshuaspence added inline comments to D18378: Remove chatbot example configuration.
Aug 9 2017, 10:53 PM
joshuaspence added a comment to D18378: Remove chatbot example configuration.

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

Aug 9 2017, 10:53 PM
joshuaspence added inline comments to D18378: Remove chatbot example configuration.
Aug 9 2017, 10:52 PM
joshuaspence committed rPbd47d001b548: Remove chatbot example configuration (authored by joshuaspence).
Remove chatbot example configuration
Aug 9 2017, 10:49 PM
joshuaspence closed D18378: Remove chatbot example configuration by committing rPbd47d001b548: Remove chatbot example configuration.
Aug 9 2017, 10:49 PM
joshuaspence added a comment to D18378: Remove chatbot example configuration.

(interestingly, I didn't receive an email about this diff being accepted)

Aug 9 2017, 10:49 PM
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230805, @chad wrote:

In general are you aware we no longer take bug reports or feature requests here?

Aug 9 2017, 10:36 PM · Bug Report, Diffusion
joshuaspence created D18379: Add a "Reviewed By" Herald condition.
Aug 9 2017, 10:30 PM
joshuaspence renamed T12959: Diffusion shows unexpected diff when an entire directory is removed from Diffusion shows mysterious diff when an entire directory is removed to Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230799, @chad wrote:

What does "mysterious" mean.

Aug 9 2017, 10:21 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:13 PM · Bug Report, Diffusion
joshuaspence created T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:12 PM · Bug Report, Diffusion
joshuaspence created D18378: Remove chatbot example configuration.
Aug 9 2017, 10:11 PM

Aug 6 2017

joshuaspence accepted D18351: Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.
Aug 6 2017, 1:21 PM
joshuaspence updated the task description for T8593: Allow files to have a description.
Aug 6 2017, 3:53 AM · Restricted Project, Files
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

I wonder if this OOM error can also be hit in other workflow though, given that it seems to occur in PhabricatorFileStorageEngine::getRawFileDataIterator.

Aug 6 2017, 1:28 AM · Bug Report, Files
joshuaspence added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

Yep, agreed that the re-targeted proposal is a better solution... I had just assumed that this was a documentation oversight.

Aug 6 2017, 12:15 AM · Bug Report, Files, Setup

Aug 2 2017

joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros
joshuaspence created T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 2 2017, 9:24 PM · Bug Report, Files, Setup
joshuaspence created T12950: Regenerating thumbnails for memes is difficult.
Aug 2 2017, 9:12 PM · Feature Request, Macros
joshuaspence created T12948: Remove the `bin/files purge` workflow.
Aug 2 2017, 12:08 PM · Bug Report, Files

Jul 31 2017

joshuaspence created D18303: Allow `/status/` endpoint to be served through alternate file domain.
Jul 31 2017, 11:13 AM
joshuaspence added a revision to T12919: Healthcheck endpoint for alternate file domain: D18303: Allow `/status/` endpoint to be served through alternate file domain.
Jul 31 2017, 11:13 AM · Files, Feature Request
joshuaspence added a comment to T10214: Daemons try and fail to publish transactions for newly created diffs.

I'm seeing these errors failing regularly:

Jul 31 2017, 10:17 AM · Bug Report
joshuaspence created D18302: Fix "undefined index" error in Differential changeset parser.
Jul 31 2017, 7:56 AM
joshuaspence added a revision to T8591: Undefined index in changeset parser: D18302: Fix "undefined index" error in Differential changeset parser.
Jul 31 2017, 7:56 AM · Differential
joshuaspence reopened T8591: Undefined index in changeset parser as "Open".

I've got a reproduction case for this now: https://secure.phabricator.com/differential/diff/44008/

Jul 31 2017, 7:49 AM · Differential

Jul 30 2017

joshuaspence updated the test plan for D18300: Don't log whiny exceptions for AJAX requests.
Jul 30 2017, 11:03 PM
joshuaspence created D18300: Don't log whiny exceptions for AJAX requests.
Jul 30 2017, 10:05 PM
joshuaspence added a revision to T11480: Stop sending misbehaving user nonsense to the error log: D18300: Don't log whiny exceptions for AJAX requests.
Jul 30 2017, 10:05 PM

Jul 27 2017

joshuaspence added a comment to D18281: In Differential, filter repository operations to just "Land" operations again.

Ok thanks

Jul 27 2017, 12:35 AM
joshuaspence added a comment to D18281: In Differential, filter repository operations to just "Land" operations again.

See PHI18 for discussion

Jul 27 2017, 12:31 AM

Jul 25 2017

joshuaspence added a comment to T6524: Support "request is from IP / subnet" policy rule.

@hach-que, did you end up implementing a solution for this?

Jul 25 2017, 12:58 PM · Policy
joshuaspence updated the test plan for D18268: Add a missing read lock.
Jul 25 2017, 7:04 AM
joshuaspence updated the summary of D18275: Allow interpreter arguments for external linters.
Jul 25 2017, 4:50 AM
joshuaspence created D18275: Allow interpreter arguments for external linters.
Jul 25 2017, 4:48 AM

Jul 24 2017

joshuaspence added a comment to D18271: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out.

Good catch

Jul 24 2017, 8:43 PM
jcox awarded T9041: Control access to administrator capabilities with custom policies a Like token.
Jul 24 2017, 11:34 AM · FreeBSD, Policy, People
joshuaspence created D18268: Add a missing read lock.
Jul 24 2017, 11:00 AM
joshuaspence added a revision to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies: D18268: Add a missing read lock.
Jul 24 2017, 11:00 AM · Diffusion
joshuaspence added a comment to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies.

I am also seeing this error and am trying to work on a fix.

Jul 24 2017, 9:23 AM · Diffusion

Jul 19 2017

joshuaspence created D18243: Lock a bunch of config options.
Jul 19 2017, 1:34 PM
joshuaspence created D18242: Ignore local SSH configuration.
Jul 19 2017, 1:15 PM
joshuaspence created D18241: Suppress "Permanently added ... to the list of known hosts" messages.
Jul 19 2017, 1:07 PM
joshuaspence updated the diff for D18205: Add SNS mail endpoint.

minor

Jul 19 2017, 12:50 PM

Jul 12 2017

joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Another correction, Puppet doesn't //need/ a dedicated server. You can run Puppet in a standalone (agent) mode, if you are willing to somehow get your Puppet manifests onto each host that you wish to provision.

Jul 12 2017, 10:27 PM · Ops, Phacility
joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Terraform Review
Pros:

  • Written in Python, which everyone knows is superior to Ruby in every way
Jul 12 2017, 10:22 PM · Ops, Phacility
joshuaspence created T12919: Healthcheck endpoint for alternate file domain.
Jul 12 2017, 9:58 PM · Files, Feature Request
joshuaspence edited the content of Community Resources.
Jul 12 2017, 9:55 PM
joshuaspence added a comment to T12856: Evaluate various "infrastructure-as-code" products.

FWIW, I am actively working on a Puppet module for Phabricator, see https://forge.puppet.com/joshuaspence/phabricator.

Jul 12 2017, 9:54 PM · Ops, Phacility
joshuaspence added a comment to T12847: A Pathway Towards Private Clusters.

AWS doesn't have a single device which can both listen for TCP on 22 (only ELB) and terminate SSL for websockets (only ALB).

Jul 12 2017, 9:52 PM · Ops, Phacility

Jul 11 2017

joshuaspence created D18205: Add SNS mail endpoint.
Jul 11 2017, 1:53 PM
joshuaspence added a revision to T12910: Allow SES to be used for inbound mail: D18205: Add SNS mail endpoint.
Jul 11 2017, 1:53 PM · Mail, Feature Request

Jul 10 2017

joshuaspence created T12910: Allow SES to be used for inbound mail.
Jul 10 2017, 12:20 PM · Mail, Feature Request
Herald updated subscribers of T12799: Consider an "API Utilities" application.
Jul 10 2017, 11:25 AM · Conduit
Herald updated subscribers of T12816: Setup NAT for the primary Phacility cluster.
Jul 10 2017, 11:03 AM · Ops, Phacility
joshuaspence updated the task description for T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence created T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence renamed T12907: Unable to download large files through alternative file domain from Unable to download large files from secure.phabricator.com to Unable to download large files through alternative file domain.
Jul 10 2017, 12:12 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.

Ah sorry, I should've made that clear. Yes, I am able to reproduce the issue on our installation.

Jul 10 2017, 12:09 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.
In T12907#228951, @chad wrote:

This is not a test install.

Jul 10 2017, 12:03 AM · Bug Report

Jul 9 2017

joshuaspence created T12907: Unable to download large files through alternative file domain.
Jul 9 2017, 11:55 PM · Bug Report

Jul 7 2017

joshuaspence added a comment to T7858: Typeahead/Tokenizer Errata.

Is there a way to exclude users/projects from a query? A user on our install has asked for a way to search for Differential revisions with Project X as a reviewer where the author is not a member of Project X.

Jul 7 2017, 6:47 AM · Restricted Project, Typeahead

Jun 29 2017

Krinkle awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jun 29 2017, 2:59 AM · Prioritized, Restricted Project, Infrastructure

Jun 28 2017

joshuaspence added a comment to D18170: Update people image for projects.

I think that something is broken here... when I click "Show Raw File (Right)" I get an empty (zero-byte) response.

Jun 28 2017, 4:30 PM

May 31 2017

joshuaspence awarded D18053: Help PROFESSIONAL SOFTWARE ENGINEERS copy text to their clipboard a Mountain of Wealth token.
May 31 2017, 9:14 PM