Page MenuHomePhabricator

joshuaspence (Joshua Spence)
Code Monkey

Projects (91)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2013, 12:25 AM (258 w, 6 d)
Availability
Available

Recent Activity

Mon, Sep 17

joshuaspence added a revision to T11699: `arc patch` is timing out: D19680: Don't pass `revisionIDs` to `differential.querydiffs`.
Mon, Sep 17, 4:57 AM · Conduit, Differential

Thu, Sep 6

joshuaspence committed rARC30b7835c37b5: Allow `willLintPaths` and `didLintPaths` to be overridden (authored by joshuaspence).
Allow `willLintPaths` and `didLintPaths` to be overridden
Thu, Sep 6, 2:44 AM
joshuaspence closed D19630: Allow `willLintPaths` and `didLintPaths` to be overridden.
Thu, Sep 6, 2:44 AM

Wed, Sep 5

joshuaspence added a comment to rPc5960c71f929: Splice in a patch to remove Phriction content rows with no document.

That seems weird, but it sort of expected/desirable.

If the Conduit calls for Branches/Tags fail to generate, we put the error message from the call into the email. This seemed better than: dropping the email; omitting the sections; or putting a generic "something went wrong" message in the email. D13319 and T8574 appear to be the genesis of this behavior.

In most cases, the error is a Conduit-level error ("your account is disabled", "the specified repository does not exist") and one or two lines long, and the message is likely relatively useful in understanding why that section didn't render.

In this case, the host itself was toast since I couldn't get through storage upgrades without this patch, so we got an actual HTTP-level error, and the exception message for these is just a big chunk of the response body since it's sometimes useful in understanding what went wrong.

So even though this outcome is a little goofy, I think all the rules that led us there are mostly pretty reasonable, and don't see anything obvious that should be changed/fixed.

Wed, Sep 5, 2:03 AM
joshuaspence added a comment to D19630: Allow `willLintPaths` and `didLintPaths` to be overridden.

T13098 is "happening" very "soon" quote unquote "quote" "unquote" "Soon™".

Wed, Sep 5, 1:59 AM

Tue, Sep 4

joshuaspence added a comment to D19630: Allow `willLintPaths` and `didLintPaths` to be overridden.

I believe it is nearly the end of days for this version of arc so I'm fine with just letting some stuff like this in.

Tue, Sep 4, 7:53 PM

Mon, Sep 3

joshuaspence abandoned D19629: Link to PHP external symbols using HTTPS.

Almost all of us:

Looks like it depends on which instance you hit: https://www.ssllabs.com/ssltest/analyze.html?d=www.php.net&latest

Mon, Sep 3, 10:26 PM
joshuaspence requested review of D19630: Allow `willLintPaths` and `didLintPaths` to be overridden.
Mon, Sep 3, 5:24 AM

Sun, Sep 2

joshuaspence requested review of D19629: Link to PHP external symbols using HTTPS.
Sun, Sep 2, 11:08 PM

Sat, Sep 1

joshuaspence added a comment to rPc5960c71f929: Splice in a patch to remove Phriction content rows with no document.

Unrelated to this change, but this is from the email I received about it:

Sat, Sep 1, 9:24 PM

Aug 20 2018

joshuaspence added a comment to T7303: Provide OAuth access to Conduit.

Even with OAuth, you still can't make AJAX requests to Conduit from client-side JavaScript, right? Is the idea that the backend code uses OAuth to talk to Conduit on a user's behalf?

Aug 20 2018, 8:06 AM · Restricted Project, Conduit, Restricted Project

Aug 15 2018

joshuaspence committed rPHUc309c5d93354: Ignore PHP types for "needs" symbols (authored by joshuaspence).
Ignore PHP types for "needs" symbols
Aug 15 2018, 8:46 PM
joshuaspence closed D19590: Ignore PHP types for "needs" symbols.
Aug 15 2018, 8:46 PM
joshuaspence updated the diff for D19590: Ignore PHP types for "needs" symbols.

Fix someone else's mistakes

Aug 15 2018, 8:45 PM
joshuaspence committed rPHUac350a7fe787: Extract needed classes/interfaces from return types (authored by joshuaspence).
Extract needed classes/interfaces from return types
Aug 15 2018, 8:43 PM
joshuaspence closed D19589: Extract needed classes/interfaces from return types.
Aug 15 2018, 8:43 PM
joshuaspence committed rPba25586016b2: Improve symbol generation scripts (authored by joshuaspence).
Improve symbol generation scripts
Aug 15 2018, 8:40 PM
joshuaspence closed D19588: Improve symbol generation scripts.
Aug 15 2018, 8:40 PM
joshuaspence requested review of D19590: Ignore PHP types for "needs" symbols.
Aug 15 2018, 2:17 AM
joshuaspence requested review of D19589: Extract needed classes/interfaces from return types.
Aug 15 2018, 2:07 AM
joshuaspence requested review of D19588: Improve symbol generation scripts.
Aug 15 2018, 1:26 AM

Aug 9 2018

joshuaspence accepted D19570: Correctly spell 'committer'.
Aug 9 2018, 8:07 PM

Aug 2 2018

joshuaspence added inline comments to D19491: Attach identities to commits and users to identities.
Aug 2 2018, 10:16 PM
joshuaspence added inline comments to D19491: Attach identities to commits and users to identities.
Aug 2 2018, 4:36 AM

Jun 29 2018

DragonBe awarded T7408: Consider dropping support for older versions of PHP a Like token.
Jun 29 2018, 11:35 AM · Restricted Project, Infrastructure

Jun 5 2018

joshuaspence added a member for Clusters: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Drydock: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for EditEngine: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Guides: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Inline Comments: joshuaspence.
Jun 5 2018, 10:45 PM
joshuaspence added a member for Mailing Lists: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Nuance: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Packages: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Plans: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Process Improvement: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Transactions: joshuaspence.
Jun 5 2018, 10:44 PM
joshuaspence added a member for Workboards: joshuaspence.
Jun 5 2018, 10:43 PM
joshuaspence added a member for Almanac: joshuaspence.
Jun 5 2018, 10:40 PM

Apr 8 2018

joshuaspence added a comment to D18643: Remove "arc lint --cache".

There's still a bunch of logic in ArcanistLintEngine and ArcanistLintEngine regarding caching... should that be removed/deprecated as well?

Apr 8 2018, 12:48 AM

Mar 9 2018

joshuaspence accepted rP9d0cf3c8b82d: Before anyone notices, break the API.
Mar 9 2018, 8:51 PM
Gryllida awarded T9412: Annotate all the reasons that a user is included on the recipient list for mail a Love token.
Mar 9 2018, 12:48 AM · llvm, Restricted Project, Mail

Feb 20 2018

Herald updated subscribers of T5590: Change diffusion.allow-http-auth into an application policy and improve security features.
Feb 20 2018, 10:01 PM · Security, Diffusion

Jan 6 2018

cspeckmim awarded Changelog a Mountain of Wealth token.
Jan 6 2018, 4:47 PM

Jan 4 2018

arend.danielek awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 4 2018, 10:38 PM · Prioritized, Restricted Project, Infrastructure

Dec 28 2017

joshuaspence added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

FWIW, I am using a custom file and mail engine that utilises the AWS SDK and supports instance profile credentials. See P2082 and P2083. You need to install and require the AWS SDK before using these extensions.

Dec 28 2017, 2:10 AM · Files
joshuaspence created P2083 PhlabS3FileStorageEngine.php.
Dec 28 2017, 2:09 AM
joshuaspence created P2082 PhlabAmazonSESMailImplementationAdapter.php.
Dec 28 2017, 2:08 AM

Nov 26 2017

joshuaspence committed rPHU32746e8b0793: Add support for nullable parameter types (authored by joshuaspence).
Add support for nullable parameter types
Nov 26 2017, 10:42 PM
joshuaspence closed D18770: Add support for nullable parameter types.
Nov 26 2017, 10:42 PM
joshuaspence added a commit to T4334: Support PHP5.4+ syntax in XHPAST: rPHU32746e8b0793: Add support for nullable parameter types.
Nov 26 2017, 10:42 PM · XHPAST

Nov 24 2017

joshuaspence updated the diff for D18770: Add support for nullable parameter types.

Update src/parser/xhpast/parser_nodes.php

Nov 24 2017, 5:13 AM
joshuaspence committed rPHUae80e72461d2: Fix node for nullable return value (authored by joshuaspence).
Fix node for nullable return value
Nov 24 2017, 3:27 AM
joshuaspence added a commit to T4334: Support PHP5.4+ syntax in XHPAST: rPHUae80e72461d2: Fix node for nullable return value.
Nov 24 2017, 3:27 AM · XHPAST
joshuaspence closed D18639: Fix node for nullable return value.
Nov 24 2017, 3:27 AM
joshuaspence added a comment to D18770: Add support for nullable parameter types.

I will land it shortly.

Nov 24 2017, 2:08 AM

Nov 16 2017

mormegil awarded T12144: Ability to reorder milestones on a project's workboard a Haypence token.
Nov 16 2017, 3:53 PM · Projects, Feature Request

Nov 13 2017

joshuaspence requested review of D18770: Add support for nullable parameter types.
Nov 13 2017, 4:37 AM
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18770: Add support for nullable parameter types.
Nov 13 2017, 4:36 AM · XHPAST

Oct 10 2017

joshuaspence added inline comments to D18679: Dump tables one at a time, rather than all at once.
Oct 10 2017, 8:10 AM

Oct 9 2017

joshuaspence added inline comments to D18679: Dump tables one at a time, rather than all at once.
Oct 9 2017, 9:17 AM

Sep 27 2017

joshuaspence created D18650: Allow filename for linter tests to be explicitly specified.
Sep 27 2017, 5:14 AM

Sep 25 2017

joshuaspence created D18639: Fix node for nullable return value.
Sep 25 2017, 5:32 AM
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18639: Fix node for nullable return value.
Sep 25 2017, 5:32 AM · XHPAST
joshuaspence committed rPHU134b16a724eb: Update `parser_nodes.php` (authored by joshuaspence).
Update `parser_nodes.php`
Sep 25 2017, 3:21 AM
joshuaspence committed rPHU2596aecadc53: Add support for nullable return types (authored by joshuaspence).
Add support for nullable return types
Sep 25 2017, 3:11 AM
joshuaspence closed D18621: Add support for nullable return types.
Sep 25 2017, 3:11 AM
joshuaspence added a commit to T4334: Support PHP5.4+ syntax in XHPAST: rPHU2596aecadc53: Add support for nullable return types.
Sep 25 2017, 3:11 AM · XHPAST
joshuaspence updated the diff for D18621: Add support for nullable return types.

Minor

Sep 25 2017, 3:09 AM

Sep 18 2017

joshuaspence added inline comments to D18621: Add support for nullable return types.
Sep 18 2017, 11:01 PM
joshuaspence added a comment to D18621: Add support for nullable return types.

Do you want to just delete all the tests and I'll accept those and abandon D17819?

Sep 18 2017, 11:15 AM
joshuaspence added inline comments to D18621: Add support for nullable return types.
Sep 18 2017, 11:12 AM
joshuaspence added a comment to D18621: Add support for nullable return types.

Oh cool. I'm somewhat surprised this is being accepted as I expected it to be blocked on T4334#222499.

Sep 18 2017, 11:10 AM
joshuaspence created D18621: Add support for nullable return types.
Sep 18 2017, 11:07 AM
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18621: Add support for nullable return types.
Sep 18 2017, 11:07 AM · XHPAST

Aug 10 2017

joshuaspence accepted D18384: Remove `bin/files purge` workflow.
Aug 10 2017, 1:22 PM
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

Thanks for the detailed response, I certainly didn't expect it.

Aug 10 2017, 1:21 PM · Bug Report, Files
joshuaspence committed rP71eaf3e8c4d6: Remove code that was accidentally landed (authored by joshuaspence).
Remove code that was accidentally landed
Aug 10 2017, 8:45 AM
joshuaspence closed D18380: Remove code that was accidentally landed by committing rP71eaf3e8c4d6: Remove code that was accidentally landed.
Aug 10 2017, 8:45 AM

Aug 9 2017

epriestley awarded D18380: Remove code that was accidentally landed a Cup of Joe token.
Aug 9 2017, 11:03 PM
joshuaspence created D18380: Remove code that was accidentally landed.
Aug 9 2017, 11:02 PM
joshuaspence added inline comments to D18378: Remove chatbot example configuration.
Aug 9 2017, 10:53 PM
joshuaspence added a comment to D18378: Remove chatbot example configuration.

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

Aug 9 2017, 10:53 PM
joshuaspence added inline comments to D18378: Remove chatbot example configuration.
Aug 9 2017, 10:52 PM
joshuaspence committed rPbd47d001b548: Remove chatbot example configuration (authored by joshuaspence).
Remove chatbot example configuration
Aug 9 2017, 10:49 PM
joshuaspence closed D18378: Remove chatbot example configuration by committing rPbd47d001b548: Remove chatbot example configuration.
Aug 9 2017, 10:49 PM
joshuaspence added a comment to D18378: Remove chatbot example configuration.

(interestingly, I didn't receive an email about this diff being accepted)

Aug 9 2017, 10:49 PM
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230805, @chad wrote:

In general are you aware we no longer take bug reports or feature requests here?

Aug 9 2017, 10:36 PM · Bug Report, Diffusion
joshuaspence created D18379: Add a "Reviewed By" Herald condition.
Aug 9 2017, 10:30 PM
joshuaspence renamed T12959: Diffusion shows unexpected diff when an entire directory is removed from Diffusion shows mysterious diff when an entire directory is removed to Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230799, @chad wrote:

What does "mysterious" mean.

Aug 9 2017, 10:21 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:13 PM · Bug Report, Diffusion
joshuaspence created T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:12 PM · Bug Report, Diffusion
joshuaspence created D18378: Remove chatbot example configuration.
Aug 9 2017, 10:11 PM

Aug 6 2017

joshuaspence accepted D18351: Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.
Aug 6 2017, 1:21 PM
joshuaspence updated the task description for T8593: Allow files to have a description.
Aug 6 2017, 3:53 AM · Restricted Project, Files
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

I wonder if this OOM error can also be hit in other workflow though, given that it seems to occur in PhabricatorFileStorageEngine::getRawFileDataIterator.

Aug 6 2017, 1:28 AM · Bug Report, Files
joshuaspence added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

Yep, agreed that the re-targeted proposal is a better solution... I had just assumed that this was a documentation oversight.

Aug 6 2017, 12:15 AM · Bug Report, Files, Setup

Aug 2 2017

joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros
joshuaspence created T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 2 2017, 9:24 PM · Bug Report, Files, Setup