joshuaspence (Joshua Spence)
Code Monkey

Projects (80)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2013, 12:25 AM (185 w, 3 d)
Availability
Available

Recent Activity

Fri, Apr 21

joshuaspence added a comment to D17756: Remove all "Phabricator Bot" code.

We use the not quite heavily at my company. Is there anything stopping me from just copying the deleted code into a libphutil extension and continuing to use it? Really, PhabricatorBotLogHandler is what we care about most.

Fri, Apr 21, 9:57 PM

Mon, Apr 17

joshuaspence edited the description of T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.
Mon, Apr 17, 11:15 PM · Differential, Herald, Bug Report
joshuaspence added a comment to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.

Hmm ok. I think that I'm not usually listed explicitly as a reviewer, which means that Reviewers: #some_project_that_i_am_a_member_of doesn't include me. Would you be in favor of adding a new [Different was reviewed by] field to Herald?

Mon, Apr 17, 10:56 PM · Differential, Herald, Bug Report
joshuaspence created T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.
Mon, Apr 17, 10:48 PM · Differential, Herald, Bug Report

Thu, Apr 13

joshuaspence added inline comments to D17684: Add validation for config settings of type regex.
Thu, Apr 13, 11:31 PM
joshuaspence added inline comments to D17684: Add validation for config settings of type regex.
Thu, Apr 13, 11:30 PM
joshuaspence created T12548: Unable to initialize database with invalid credentials in configuration file.
Thu, Apr 13, 7:01 AM · Database, Bug Report
joshuaspence renamed T12547: Confusing error message when trying to register an account over HTTP with `security.require-https` from "Unable to create initial user account" to "Confusing error message when trying to register an account over HTTP with `security.require-https`".
Thu, Apr 13, 6:21 AM · Auth, Bug Report
joshuaspence added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

Actually, I figured it out... The problem was that I had security.require-https set to true but I hadn't yet setup HTTPS so I was only using plain old HTTP.

Thu, Apr 13, 6:20 AM · Auth, Bug Report
joshuaspence added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

I tried to reproduce this on a Phacility host, but it doesn't reproduce there because the first user account is setup via OAuth.

Thu, Apr 13, 5:50 AM · Auth, Bug Report
joshuaspence created T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.
Thu, Apr 13, 5:49 AM · Auth, Bug Report

Tue, Apr 11

joshuaspence added a comment to T12534: Differential still appears in "responsible users" query after resigning as a reviewer.

When I turn on bucketing, I can't see it actually. Although I do have a lot of diffs, so it could have overheated.

Tue, Apr 11, 7:22 AM · Bug Report (Needs Information), Differential
joshuaspence added a comment to T12534: Differential still appears in "responsible users" query after resigning as a reviewer.
Tue, Apr 11, 6:39 AM · Bug Report (Needs Information), Differential
joshuaspence created T12534: Differential still appears in "responsible users" query after resigning as a reviewer.
Tue, Apr 11, 5:27 AM · Bug Report (Needs Information), Differential
joshuaspence added a comment to D17651: Correct two parameter strictness issues with file uploads.

How could you??

Tue, Apr 11, 12:13 AM

Mon, Apr 10

joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

This seems to have fixed the issue. Thanks for the quick fix.

Mon, Apr 10, 11:07 PM · Arcanist, Files, Bug Report
epriestley awarded T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0 a Mountain of Wealth token.
Mon, Apr 10, 11:03 PM · Arcanist, Files, Bug Report
joshuaspence accepted D17651: Correct two parameter strictness issues with file uploads.
Mon, Apr 10, 11:00 PM
joshuaspence added inline comments to D17651: Correct two parameter strictness issues with file uploads.
Mon, Apr 10, 10:58 PM
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Not sure if this is useful:

Mon, Apr 10, 10:52 PM · Arcanist, Files, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Hmm, I got a different error with a 9MB file. But this looks like a problem on our end:

Mon, Apr 10, 10:39 PM · Arcanist, Files, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

I originally tried a 1GB file and wasn't able to reproduce...

Mon, Apr 10, 10:38 PM · Arcanist, Files, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

From the server-side error logs:

Mon, Apr 10, 10:35 PM · Arcanist, Files, Bug Report
joshuaspence added a project to T12532: `syntax.filemap` does not validate input: Config.
Mon, Apr 10, 10:33 PM · Contributor Onboarding, Config, Bug Report
joshuaspence created T12532: `syntax.filemap` does not validate input.
Mon, Apr 10, 10:33 PM · Contributor Onboarding, Config, Bug Report
joshuaspence added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Okay, I managed to reproduce it with non-sensitive data:

Mon, Apr 10, 10:28 PM · Arcanist, Files, Bug Report
joshuaspence created T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.
Mon, Apr 10, 10:21 PM · Arcanist, Files, Bug Report

Thu, Apr 6

joshuaspence created T12514: `refs/keep-around/` commits should be ignored.
Thu, Apr 6, 10:17 PM · Diffusion, Bug Report

Mar 28 2017

joshuaspence accepted rP8879118b696f: Fix a mid-air collision around SearchService roles.
Mar 28 2017, 9:19 PM

Mar 21 2017

joshuaspence added inline comments to D17497: Use "git ls-remote" to guess if "git fetch" is a no-op.
Mar 21 2017, 1:41 AM

Mar 20 2017

joshuaspence added a comment to D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.

LGTM, but we need a Blessed Reviewers to sign off on it as well.

Mar 20 2017, 7:32 AM
joshuaspence added inline comments to D17497: Use "git ls-remote" to guess if "git fetch" is a no-op.
Mar 20 2017, 6:30 AM

Mar 16 2017

joshuaspence added a comment to D12692: Allow full URIs to be rendered as object references.

Let me see if I can get this over the edge of the precipice...

Mar 16 2017, 1:19 AM

Mar 13 2017

joshuaspence added a comment to T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.

Mar 13 2017, 3:15 AM · Conduit, Differential, Bug Report
joshuaspence added a comment to T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.

OK weird, I can't reproduce it anymore. Anyway, I'll add the response body from differential.querydiffs here. It shouldn't contain any sensitive information, but I'll restrict the visibility of the file given that it does contain email addresses.

Mar 13 2017, 3:11 AM · Conduit, Differential, Bug Report
joshuaspence created T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.
Mar 13 2017, 3:03 AM · Conduit, Differential, Bug Report

Mar 8 2017

joshuaspence awarded T12270: Unbeta Badges a Like token.
Mar 8 2017, 5:13 AM · Badges (v0)

Mar 5 2017

joshuaspence edited the content of 2017 Week 9 (Early March).
Mar 5 2017, 2:24 AM

Mar 4 2017

CodeMouse92 awarded D17429: Update `phd launch` a Like token.
Mar 4 2017, 1:37 AM

Mar 2 2017

joshuaspence committed rPfcd8c9c240d4: Update `phd launch` (authored by joshuaspence).
Update `phd launch`
Mar 2 2017, 10:37 AM
joshuaspence added a commit to T12298: Allow daemon pools to autoscale down to 0 processes: rPfcd8c9c240d4: Update `phd launch`.
Mar 2 2017, 10:37 AM · Daemons, Ops, Phacility
joshuaspence closed D17429: Update `phd launch` by committing rPfcd8c9c240d4: Update `phd launch`.
Mar 2 2017, 10:37 AM

Feb 28 2017

joshuaspence committed rPHU81494451f9be: Minor fix presumably identified by PHPStan (authored by joshuaspence).
Minor fix presumably identified by PHPStan
Feb 28 2017, 8:43 PM
joshuaspence closed D17435: Minor fix presumably identified by PHPStan by committing rPHU81494451f9be: Minor fix presumably identified by PHPStan.
Feb 28 2017, 8:43 PM
joshuaspence added a comment to D17435: Minor fix presumably identified by PHPStan.

Unit test thing is a PHP7 thing.

Feb 28 2017, 8:42 PM
joshuaspence created D17435: Minor fix presumably identified by PHPStan.
Feb 28 2017, 8:41 PM
epriestley awarded D17429: Update `phd launch` a Cup of Joe token.
Feb 28 2017, 12:46 PM
joshuaspence updated the summary of D17429: Update `phd launch`.
Feb 28 2017, 4:25 AM
joshuaspence created D17429: Update `phd launch`.
Feb 28 2017, 3:49 AM
joshuaspence added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: D17429: Update `phd launch`.
Feb 28 2017, 3:49 AM · Daemons, Ops, Phacility
joshuaspence closed T12329: Unable to establish a connection to any database host (while trying "phabricator_config"). All masters and replicas are completely unreachable as "Invalid".

Oh wait, this is the unit tests failing. Nevermind

Feb 28 2017, 3:47 AM · Phacility, Bug Report
joshuaspence created T12329: Unable to establish a connection to any database host (while trying "phabricator_config"). All masters and replicas are completely unreachable.
Feb 28 2017, 3:45 AM · Phacility, Bug Report

Feb 15 2017

joshuaspence added inline comments to D17357: arc set-config: warn about unknown keys.
Feb 15 2017, 9:54 PM

Feb 14 2017

joshuaspence retitled D17350: Allow external linters to operate on multiple paths in batches from Allow external linters to operate on multiple paths to Allow external linters to operate on multiple paths in batches.
Feb 14 2017, 4:36 AM
joshuaspence created D17350: Allow external linters to operate on multiple paths in batches.
Feb 14 2017, 3:36 AM

Feb 10 2017

joshuaspence accepted D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
Feb 10 2017, 2:45 AM

Feb 9 2017

shepting awarded D11657: Add a ShellCheck linter a Doubloon token.
Feb 9 2017, 5:50 PM

Feb 7 2017

joshuaspence added a comment to I2 Donate to Phacility.

Macro awwyiss2:

Feb 7 2017, 8:54 PM · Phacility
joshuaspence added a comment to I2 Donate to Phacility.

Can haz badge??? 🍺

Feb 7 2017, 8:49 PM · Phacility
joshuaspence backed I2 Donate to Phacility with $3.00 USD.
Feb 7 2017, 8:47 PM · Phacility
joshuaspence backed I2 Donate to Phacility with $1.00 USD.
Feb 7 2017, 8:43 PM · Phacility
joshuaspence added a comment to T8937: Unclear exception when patching non-existant revision.

I don't believe this is related to E being set in variables_order.

Feb 7 2017, 8:40 PM · Arcanist

Feb 1 2017

robertkraig awarded Community Resources a Love token.
Feb 1 2017, 8:22 PM

Jan 25 2017

1stone awarded T4558: Make Diviner useful for third-parties a Like token.
Jan 25 2017, 8:16 AM · Diviner

Jan 23 2017

joshuaspence added a comment to T12144: Ability to reorder milestones on a project's workboard.
In T12144#208351, @chad wrote:

I'd rather fix the core problem if it's an unclear typeahead.

Jan 23 2017, 1:16 AM · Projects, Feature Request

Jan 22 2017

joshuaspence added a comment to T12144: Ability to reorder milestones on a project's workboard.

My understanding is that subprojects are basically just regular projects but with a parent relationship. We didn't want these projects to pollute the projects typeahead because no-one should be creating tasks within these subprojects (given that these subprojects dictate what we are working on). By choosing "milestone" instead of "subproject", it becomes clearer in the project typeahead that the subproject is internal to the parent project. That is, if we made #our_january_goal a subproject then it would show up in the projects typeahead as "Our January Goal" whereas as a milestone it is rendered as "Our Team (Our January Goal)".

Jan 22 2017, 11:45 PM · Projects, Feature Request
joshuaspence created T12144: Ability to reorder milestones on a project's workboard.
Jan 22 2017, 11:10 PM · Projects, Feature Request
chad awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:26 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure

Jan 19 2017

joshuaspence requested changes to D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.

I think you probably want to use CaseInsensitiveArray, otherwise the linter message won't exactly match xhpast.deprecated.functions.

Jan 19 2017, 10:38 PM

Jan 18 2017

cburroughs awarded T5889: Allow herald rules to act on existence of auditors a Mountain of Wealth token.
Jan 18 2017, 9:47 PM · Restricted Project, Audit, Herald
sgielen awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 18 2017, 3:25 PM · Prioritized, Restricted Project, Infrastructure

Jan 13 2017

joshuaspence awarded T12101: Phabricator PHP 7 Compatibility a Mountain of Wealth token.
Jan 13 2017, 10:51 PM · Infrastructure, Guides
skibbipl awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 13 2017, 12:09 PM · Prioritized, Restricted Project, Infrastructure
cmmata awarded T9640: Make Phabricator compatible with PHP7 a 100 token.
Jan 13 2017, 10:16 AM · Prioritized, Restricted Project, Infrastructure
Zolli awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 13 2017, 6:03 AM · Prioritized, Restricted Project, Infrastructure

Jan 12 2017

PhoneixS awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 12 2017, 9:58 AM · Prioritized, Restricted Project, Infrastructure

Jan 8 2017

joshuaspence created T12082: Differential emails are rendering literal HTML tags.
Jan 8 2017, 10:33 PM · Differential, Bug Report
joshuaspence abandoned D17159: Testing blocking reviewers.
Jan 8 2017, 10:32 PM
joshuaspence added a reviewer for D17159: Testing blocking reviewers: epriestley.
Jan 8 2017, 10:30 PM
joshuaspence created D17159: Testing blocking reviewers.
Jan 8 2017, 10:28 PM

Jan 2 2017

joshuaspence added projects to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward): Diffusion, Herald.
Jan 2 2017, 10:26 AM · Diffusion (v3), Herald, Bug Report
joshuaspence added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

You're watching #twitter.

Jan 2 2017, 1:42 AM · Prioritized, Restricted Project, Arcanist, Bug Report

Jan 1 2017

joshuaspence added a comment to T10038: Plan the mid-term pathway for linter bindings.

Do you see there being a "Blessed" foo-linter (maybe as a repo on this instance?), or will there be multiple foo-tributes fending themselves in the wilds of github?

This is all still pretty early, but I imagine this instance mostly just collecting packages into a directory for now. The actual source might be on GitHub, but you'd be able to search this instance to find all foo-linter extensions by authors who had bothered to register their packages.

In some cases, we'd likely pull linters out of arc and turn them into Phacility-Published extensions (secure.phabricator.com/phacility/foo-linter) which we'd sign. These would be "blessed", as long as you continue trusting our signing keys.

In some cases, I'd like to "soft-bless" extensions as "safe, but don't come to us for support" with some sort of "Community Badge of Quality" key. For example, you might publish a secure.phabricator.com/cburroughs/foo-linter) which we'd sign in an advisory way which mean "we looked at the code, it seems fine, but we aren't taking bug reports for it". The UI and arc install would show users that someone they trust also trusts this code.

In some cases, untamed wilds, but collected in one place and searchable, with signing and a consistent toolset.

If nothing is blessed, you may have to make a decision like this yourself:

$ arc install foo-lint
Query "foo-lint" matches multiple packages:

  secure.phabricator.com/alice/foo-lint
  secure.phabricator.com/bob/foo-lint

None of these packages or vendors are signed by anything you trust.

Which package do you want to install?

But I think that should be OK. And we can do some level of positive and negative curation (advisory signing on good packages, disabling bad packages)..

You'll also be able to have an internal package directory for your company's stuff, so you can just publish internal things to it and then everyone can use standard tools to manage extensions.

Some day far in the future I could imagine the package directory integrating with other applications (e.g., giving each package its own repositories and tasks, like GitHub) but that's definitely far in the future. I expect most extensions (like linter bindings) to be small so they wouldn't get much benefit (e.g., 100 lines of code updated a couple times a year) and large extensions (eventually, third-party applications) to probably want to self-host on their own Phabricator instances in most cases.

The immediate goal is just fixing the problem that distributing extensions is a huge pain and all solutions have major downsides, with "convince the upstream to accept the extension" being the best option for everyone but us. The new distribution mechanism would be:

$ arc lint
Okay, automatically installing all the extensions this project needs.

(...prompts if you need to trust new stuff...)

Done!
...
nice lint output

Which fixes distribution. In the long run, there's a lot we can do to build stronger ecosystem tools, but I'm less worried about tackling that stuff today than I am about moving distribution to a broadly reasonable mechanism.

Jan 1 2017, 3:22 AM · Lint, Arcanist

Dec 29 2016

joshuaspence added a comment to D17058: Separate all commit message field parsing out of Differential custom fields.

Thanks for the explanation.

Dec 29 2016, 8:57 PM
joshuaspence added a comment to T11114: Move Differential to EditEngine.

From D17067:

Dec 29 2016, 10:42 AM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
joshuaspence added projects to T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked: Arcanist, Differential.
Dec 29 2016, 7:08 AM · Differential, Arcanist, Feature Request

Dec 28 2016

joshuaspence added a comment to D17058: Separate all commit message field parsing out of Differential custom fields.

Also, is it intentional that the field name is wrapped in pht(...) but the field aliases are not?

Dec 28 2016, 11:59 PM
joshuaspence added inline comments to D17058: Separate all commit message field parsing out of Differential custom fields.
Dec 28 2016, 11:52 PM

Dec 15 2016

J5lx awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Dec 15 2016, 7:13 PM · Prioritized, Restricted Project, Infrastructure

Dec 9 2016

rafaelrabeloit awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Dec 9 2016, 3:53 PM · Prioritized, Restricted Project, Infrastructure

Dec 6 2016

salvian awarded T5155: Evaluate support for AWS IAM Roles in S3 Client a Like token.
Dec 6 2016, 9:30 AM · Files

Dec 2 2016

vanmeeuwen awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Dec 2 2016, 6:48 AM · Prioritized, Restricted Project, Infrastructure

Dec 1 2016

joshuaspence added a project to T11933: Let `PhutilTypeLexer` support PHP style qualified names: libphutil.
Dec 1 2016, 1:36 AM · libphutil, Feature Request

Nov 29 2016

joshuaspence added a comment to T11930: Users don't realise that they must link their account.

That didn't seem to be the case. It might have been because we only enforced Google authentication around one year ago, before that users could use a password for authentication. I can check later today, but perhaps the users that ended up with duplicate accounts never setup Google Auth.

Nov 29 2016, 9:42 PM · NUX, Auth
joshuaspence added a project to T11930: Users don't realise that they must link their account: NUX.
Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence added a comment to T11930: Users don't realise that they must link their account.

To provide some additional context, we originally allowed users to register their own accounts, but we eventually disabled this because we ended up with around 30 duplicate accounts (users with more than one account). I think that this happened because users had listed an alias address in their Phabricator settings, but Google was using a canonical email address to authenticate, which didn't map to any existing user accounts (we have a lot of users that have aliases set up. For example, abraham@mycompany.com would be an alias for the canonical alincoln@mycompany.com address).

Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence created T11930: Users don't realise that they must link their account.
Nov 29 2016, 9:32 PM · NUX, Auth
joshuaspence added a project to T11509: Provide a way to quickly see if all comments on a diff have been marked as "done": Differential.
Nov 29 2016, 12:32 AM · Differential, Restricted Project, Feature Request